From patchwork Wed Nov 20 15:45:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 11254323 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F056E1593 for ; Wed, 20 Nov 2019 15:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0FBA2071B for ; Wed, 20 Nov 2019 15:46:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xUwoi8nv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729631AbfKTPqi (ORCPT ); Wed, 20 Nov 2019 10:46:38 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:36619 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731490AbfKTPpc (ORCPT ); Wed, 20 Nov 2019 10:45:32 -0500 Received: by mail-pf1-f193.google.com with SMTP id b19so14412922pfd.3 for ; Wed, 20 Nov 2019 07:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=UhlgzauEtpF8L0LzttCZ+lpDer0t2cSKin9iOeiQFcw=; b=xUwoi8nvephl72akSmRItCtyuVQZnA8izas8jNZj+rYlyPmcb+9JkRl9ag74UJG+ml a3AmBm12kC24TpIDbEdrgDbeIDEL0YhjYdsNtrjQjlyM081hL+byOlU2NFU5szpTWYtK nfO3e/cnd21wuVHFsY7+BgrknzP5Hem30fzsb/D51u+zIar4n8tLYlXyekC0YXWhkdvA nErhGCt2lCBYiU+tfR/AbEGfmzt6paXzzsmdpMshpDNmQ9cIykUgNZT4dGgKlurhWy/G GSNYEvibA0+XSoA02bj9PeF2pjP186RgMy7enY0pwVH6wDrrHS62DaHoVH8CpcD+Bibe xxsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=UhlgzauEtpF8L0LzttCZ+lpDer0t2cSKin9iOeiQFcw=; b=Vux1CjWnGJSlMyGp5ZBz1doNXkDA8Kqu8do9fRYcDBWfXtFl5dPz8W7Bq5OXYhn5Q4 8nl3r3jLWYQZT0U9qbwkZcKFAJrhpxXI7+g4wCrM6wcaDpxvGrlMkDYpo6KGKgVf92l/ loNtdMS0cOaIuDk8ASwUAHdsh+kC4tK+6ZUxMpg+eckdW/5jgDy8+RNeI1IcSbYMl6X9 TmbgGFVU53tupZQO6uyYu168Ju3DazLmQDBq7GuFqcDiIJeFNJntII9U/lGhI5ZhW5io HR3OSozaCSv2/orqckvKnocpCvavsmojHMsYiV0rWrRB74tcKURSHX7Fwuu0K8jI+LtL qScg== X-Gm-Message-State: APjAAAXg4wcFEQm1K6Oq1J8kg3UESfKtbrgCNr5Og82210ctRf40ee0I YuRNwJ+w734hal5qn30/3ptwew== X-Google-Smtp-Source: APXvYqxkcUp9jMDNLha++k3NBN56jJ2v22CFPJkdR1JKEzFx/AObWFImoUDJuhJFCF2aved+yYTp+w== X-Received: by 2002:a63:778b:: with SMTP id s133mr4140842pgc.406.1574264731098; Wed, 20 Nov 2019 07:45:31 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id y11sm30781168pfq.1.2019.11.20.07.45.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:45:30 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v2 01/11] thermal: of-thermal: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:10 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Replace a comment starting with /** by simply /* to avoid having it interpreted as a kernel-doc comment. Fixes the following warning when compile with make W=1: linux.git/drivers/thermal/of-thermal.c:761: warning: cannot understand function prototype: 'const char *trip_types[] = ' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/of-thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c index dc5093be553e..5235aed2fadd 100644 --- a/drivers/thermal/of-thermal.c +++ b/drivers/thermal/of-thermal.c @@ -754,7 +754,7 @@ static int thermal_of_populate_bind_params(struct device_node *np, return ret; } -/** +/* * It maps 'enum thermal_trip_type' found in include/linux/thermal.h * into the device tree binding of 'trip', property type. */ From patchwork Wed Nov 20 15:45:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 11254319 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A215D138C for ; Wed, 20 Nov 2019 15:46:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8225F20709 for ; Wed, 20 Nov 2019 15:46:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YEVFThby" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732413AbfKTPph (ORCPT ); Wed, 20 Nov 2019 10:45:37 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:37176 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732412AbfKTPpf (ORCPT ); Wed, 20 Nov 2019 10:45:35 -0500 Received: by mail-pl1-f193.google.com with SMTP id bb5so13998420plb.4 for ; Wed, 20 Nov 2019 07:45:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=4TmU0ibaD1fY5ibWJwV7zia/u/t/2yh9Lbt7NaMlJsw=; b=YEVFThbykDuFOr1GtEq6abY7duRfnHI4jaVcRFw7vzdDc2xf1gpAT3jNxbtyZtbPwZ aMtfdH26aYykzeg2IB4I2NafAVv3xFEIIRY7Zs43XTowRnDpQSNLtmf4Tsf8g1Iw7pGI nn/6oVBn+K0nhhX+xEIphl9eUlPv2NW8mhDmyVifedjB5F0z66LVt4bkzAJ76dgsG4S+ 8usbneTJfpUq5fAAj6kzBspsVXaqGx4KLxWjyL8whLq67PrEwVva1wYW27YodK3cU873 2DXeWS/CagJITBLU8OB31P6nW7HponRuy+30OI4pi8a9Qv5CXnMP2XpGebOTKW/42S32 /C5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=4TmU0ibaD1fY5ibWJwV7zia/u/t/2yh9Lbt7NaMlJsw=; b=m7xRjkXrxOAH1NR4m7xHEt4UD2A0AY/M4cKHE5HJkthJKYlbrD1S+1eAk0oNyGPMPG 9apeNyexlcTYPyWSd8tL9ZWs3/9A1XKGgn/Ok9o8Z/nmnVccgMf3ukXbiIKUJiro5IfA dFHrUjUfkq9t8/uEGTHA9WlQOvzcM4Jo+LDbTPSnquzudVtDAx1SFj+RS+cs/bHarm69 hgniLR36JNWXCFx4mua+T0p5mUtbLTN2y9zRFPktm+lXegt2vt9uWmeEOrcxG4bzwHgJ WOvO9Wozn/wFqrLA/jvcxdSt3UkHXDYLKA2wGJKolbdflKBoH2RUA4+g1/yMEMJ01ZFr sb+Q== X-Gm-Message-State: APjAAAWhomcvuSXTiBfx9v+cHyKwcsuP6CmW8Vc0VR1YK9dbJvy5tNGP 4HtkqVtYNVeTZbDeX36ePynd5g== X-Google-Smtp-Source: APXvYqwqWn98sIzUoybOJYVYcRSWVhMeKAFe8/0u1dMDQwQ20DewYj1vMTc1Og9g9ggVyBX4J+5vcQ== X-Received: by 2002:a17:902:a70b:: with SMTP id w11mr3665919plq.27.1574264734625; Wed, 20 Nov 2019 07:45:34 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id b1sm7658518pjw.19.2019.11.20.07.45.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:45:34 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v2 02/11] thermal: cpu_cooling: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:11 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Describe the function parameter to fix the following warning with make W=1: linux.git/drivers/thermal/cpu_cooling.c:92: warning: Function parameter or member 'qos_req' not described in 'cpufreq_cooling_device' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/cpu_cooling.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index 52569b27b426..53dd08f238d5 100644 --- a/drivers/thermal/cpu_cooling.c +++ b/drivers/thermal/cpu_cooling.c @@ -63,6 +63,7 @@ struct time_in_idle { * @policy: cpufreq policy. * @node: list_head to link all cpufreq_cooling_device together. * @idle_time: idle time stats + * @qos_req: PM QoS contraint to apply * * This structure is required for keeping information of each registered * cpufreq_cooling_device. From patchwork Wed Nov 20 15:45:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 11254317 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7E71B13A4 for ; Wed, 20 Nov 2019 15:46:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5AA0820714 for ; Wed, 20 Nov 2019 15:46:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HprR3YeZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730229AbfKTPpm (ORCPT ); Wed, 20 Nov 2019 10:45:42 -0500 Received: from mail-pj1-f67.google.com ([209.85.216.67]:33473 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732425AbfKTPpl (ORCPT ); Wed, 20 Nov 2019 10:45:41 -0500 Received: by mail-pj1-f67.google.com with SMTP id o14so26739pjr.0 for ; Wed, 20 Nov 2019 07:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=bpr+XgLcp0GJ6wIDnaLswXE+7+Imau06ErXv0DJpW/A=; b=HprR3YeZNVzUJusAYWgK/uwgFmScXge99pfc8msCYNQ72Nf4zHGsDis5kchJKKyRJ0 CWKzDLrLfqmS+xtX9sE4rgAR7/d5Znx/HnYAzunhijrbr8cO0hY2ej/Abiy1ibWALYhZ 4kzEE5XgtlcJFzIOfPVLagE/MN57OAaooQNrlUwiNEdbf12hmfUHtf6tA2cr8ApzjDXE 1p09hF8ndjfVOtD0XBxAt1ccoygg8SB4qvt3Upb/W2s+hCVUfNXnJFxt186HIA0Cil7U 5JuMBwXvMuNGWN2lmrjUO9WsiWbGtUfIQ+8X5AuD7eIQx+jKbObMxGP3gPYsxBsBOqfO nlhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=bpr+XgLcp0GJ6wIDnaLswXE+7+Imau06ErXv0DJpW/A=; b=YzPWW4fg+m3pMCR1212bNT5/1E+QdIRz+TH6uYz3B2MOvdhhb1PgcJXW3N2HUCtM9c LdY4my2BYsIELk4CWIzuGuclFSk5L4BnV21tTEhs4sTFIZVJsWpoWWfXtfLnN2+exdQM 2XRp4V9n2ZW4xiviz8NhckavJcNa3oMkHb+XRJAwZrruBzmlQ8Qfs0cHVlBFY0f7A3sK TLUKOgNMJccJsPShYvc9GLb4VzNu5XKygraCmQ/1BGOidKiu7YxFLe/GTjDhjvIARaWe alOdaJwMyOgB2a0gCRBDfKycXI8d5pD4LEZ3KxQv84U6omVfTYMC/5KlHTRceNyOnH5U 1M7Q== X-Gm-Message-State: APjAAAUu6XglIcQo8cdNgaK4+5pBjhvLP2y1LLbfOXmXaskvHQ80Goeq 6R2QIvJDb3KGDjQNwwMxmDGPcg== X-Google-Smtp-Source: APXvYqwoEPmMYiC5RZe26XEvZqQ4Z4Nw9yF/I0EtDQW4twuoRbQQVPeSpxc4pSrm4S5vV6pYT9JKXg== X-Received: by 2002:a17:90b:3007:: with SMTP id hg7mr5111000pjb.73.1574264739276; Wed, 20 Nov 2019 07:45:39 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id f59sm7044014pje.0.2019.11.20.07.45.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:45:38 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v2 03/11] thermal: step_wise: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:12 +0530 Message-Id: <5d48ac6f85667a53902092ad5bbfef8cc89a7162.1574242756.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Replace - with : to appease the kernel-doc gods and fix warnings such as the following when compiled with make W=1: linux-amit.git/drivers/thermal/step_wise.c:187: warning: Function parameter or member 'tz' not described in 'step_wise_throttle' linux-amit.git/drivers/thermal/step_wise.c:187: warning: Function parameter or member 'trip' not described in 'step_wise_throttle' linux.git/drivers/thermal/fair_share.c:79: warning: Function parameter or member 'tz' not described in 'fair_share_throttle' linux.git/drivers/thermal/fair_share.c:79: warning: Function parameter or member 'trip' not described in 'fair_share_throttle' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/fair_share.c | 4 ++-- drivers/thermal/gov_bang_bang.c | 4 ++-- drivers/thermal/step_wise.c | 4 ++-- drivers/thermal/user_space.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/thermal/fair_share.c b/drivers/thermal/fair_share.c index afd99f668c65..aaa07180ab48 100644 --- a/drivers/thermal/fair_share.c +++ b/drivers/thermal/fair_share.c @@ -58,8 +58,8 @@ static long get_target_state(struct thermal_zone_device *tz, /** * fair_share_throttle - throttles devices associated with the given zone - * @tz - thermal_zone_device - * @trip - trip point index + * @tz: thermal_zone_device + * @trip: trip point index * * Throttling Logic: This uses three parameters to calculate the new * throttle state of the cooling devices associated with the given zone. diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c index b831fc77cf64..991a1c54296d 100644 --- a/drivers/thermal/gov_bang_bang.c +++ b/drivers/thermal/gov_bang_bang.c @@ -71,8 +71,8 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) /** * bang_bang_control - controls devices associated with the given zone - * @tz - thermal_zone_device - * @trip - the trip point + * @tz: thermal_zone_device + * @trip: the trip point * * Regulation Logic: a two point regulation, deliver cooling state depending * on the previous state shown in this diagram: diff --git a/drivers/thermal/step_wise.c b/drivers/thermal/step_wise.c index 6e051cbd824f..2ae7198d3067 100644 --- a/drivers/thermal/step_wise.c +++ b/drivers/thermal/step_wise.c @@ -174,8 +174,8 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) /** * step_wise_throttle - throttles devices associated with the given zone - * @tz - thermal_zone_device - * @trip - trip point index + * @tz: thermal_zone_device + * @trip: trip point index * * Throttling Logic: This uses the trend of the thermal zone to throttle. * If the thermal zone is 'heating up' this throttles all the cooling diff --git a/drivers/thermal/user_space.c b/drivers/thermal/user_space.c index 962873fd9242..293cffd9c8ad 100644 --- a/drivers/thermal/user_space.c +++ b/drivers/thermal/user_space.c @@ -17,8 +17,8 @@ /** * notify_user_space - Notifies user space about thermal events - * @tz - thermal_zone_device - * @trip - trip point index + * @tz: thermal_zone_device + * @trip: trip point index * * This function notifies the user space through UEvents. */ From patchwork Wed Nov 20 15:45:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 11254287 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 42B69138C for ; Wed, 20 Nov 2019 15:45:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2266A20692 for ; Wed, 20 Nov 2019 15:45:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Ozv7hJZq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731314AbfKTPpp (ORCPT ); Wed, 20 Nov 2019 10:45:45 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:46107 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732430AbfKTPpn (ORCPT ); Wed, 20 Nov 2019 10:45:43 -0500 Received: by mail-pl1-f193.google.com with SMTP id l4so13990809plt.13 for ; Wed, 20 Nov 2019 07:45:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=LB0mFTtKkHmo2cL12xdptGbf+C8Nvz2KFyNdinT86Hs=; b=Ozv7hJZqH8HGUR9P7JW0bGRieZObuXO21O+rOP+m+JocLXsFbjmIS6wZqm2AAlU+ns tO6Ukn+1PEnZi1PyTTv/o79FJhchMEw+I02xkgXAocUiVyy1QPPcXYNGr4oeEZ7eAADS /q2CKsqN8t++k8KFeA+U8Ykfs+Yi1UHvZQxH3ad7wUea8s0STHkCYkxxj5+DxgDDMVJ0 UfC6nlhol5VLPIaphGXQLYuN+3g9u38AgNbOWe16OyZIzBIaDVUe/ZJJU5XW39KBPFSB pvzEvWKJcd/yolqJz/n+1tX1QL9gEQQw3GQTLdBnqqoOSUM7ZwfFcHota0z0NYHrmcG4 +M4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=LB0mFTtKkHmo2cL12xdptGbf+C8Nvz2KFyNdinT86Hs=; b=ug++vVP4InKiTbbMPeL7KXRWCYBZLoJfIwsVijfbxXH7EIqQy+41+jktgZ6fWBdm8p QqC1KJfInXQw1Bw4rSfJDrWbhrVgCVKlfFu+poVBm4XjQPMYlkrmb5IcX3gTQfXV0jNI Nr0DR6RY7/5ReoWDHN7vSXsTAsbkYULCYaLMMnVVOzc0RuU8/5e0gTErcSV5RWlLRvv9 Yv0F0qPW6JGFYtzxOS6z7ksqKSQRi1MINi3Bi+NVgo9e+qmbQxOPItkN7xBWy70YmjnR UNY+ZbMrYTGt5SRUKk91zPY0Ia0F/Ru9WYSkV0fDs0nHsZmJIlcaEgw9kl4f6j8ffL7S m5aw== X-Gm-Message-State: APjAAAU0oQspU+GwZamgUST2/2biUkjwUi/atCESyGzWf5CdOAdD5GMk KwStOzWqTJNMahBhrhQquHwzIg== X-Google-Smtp-Source: APXvYqyB42bSl+V4AlIGVMjAxYwx7VypP3HVgpqXRen6G2VGgOnmLvy7kE8oL/ksozcdL9YR6IvUBA== X-Received: by 2002:a17:902:7287:: with SMTP id d7mr3666727pll.333.1574264742918; Wed, 20 Nov 2019 07:45:42 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id i102sm7833530pje.17.2019.11.20.07.45.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:45:42 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v2 04/11] thermal: devfreq_cooling: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:13 +0530 Message-Id: <7059d82472fe12139fc7a3379c5b9716a23cce5c.1574242756.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Fix up the following warnings with make W=1: linux.git/drivers/thermal/devfreq_cooling.c:68: warning: Function parameter or member 'capped_state' not described in 'devfreq_cooling_device' linux.git/drivers/thermal/devfreq_cooling.c:593: warning: Function parameter or member 'cdev' not described in 'devfreq_cooling_unregister' linux.git/drivers/thermal/devfreq_cooling.c:593: warning: Excess function parameter 'dfc' description in 'devfreq_cooling_unregister' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/devfreq_cooling.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfreq_cooling.c index ef59256887ff..a87d4fa031c8 100644 --- a/drivers/thermal/devfreq_cooling.c +++ b/drivers/thermal/devfreq_cooling.c @@ -53,6 +53,7 @@ static DEFINE_IDA(devfreq_ida); * 'utilization' (which is 'busy_time / 'total_time'). * The 'res_util' range is from 100 to (power_table[state] * 100) * for the corresponding 'state'. + * @capped_state: index to cooling state with in dynamic power budget */ struct devfreq_cooling_device { int id; @@ -587,7 +588,7 @@ EXPORT_SYMBOL_GPL(devfreq_cooling_register); /** * devfreq_cooling_unregister() - Unregister devfreq cooling device. - * @dfc: Pointer to devfreq cooling device to unregister. + * @cdev: Pointer to devfreq cooling device to unregister. */ void devfreq_cooling_unregister(struct thermal_cooling_device *cdev) { From patchwork Wed Nov 20 15:45:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 11254293 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CEE9913A4 for ; Wed, 20 Nov 2019 15:45:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEBE820878 for ; Wed, 20 Nov 2019 15:45:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="O/nv/MNt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732459AbfKTPpx (ORCPT ); Wed, 20 Nov 2019 10:45:53 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:40863 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732438AbfKTPpr (ORCPT ); Wed, 20 Nov 2019 10:45:47 -0500 Received: by mail-pf1-f195.google.com with SMTP id r4so14400873pfl.7 for ; Wed, 20 Nov 2019 07:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=G8asUZ+0MUW3NBVjjluOo+rKwiQgZJGohdw8KMKLHAE=; b=O/nv/MNtvKF9DpaeXdKEfk/PcEKxE00pZPHw6VLh6xy49SJ9dwGF6xydE0Wl9P1l// kk5YREZIMKPB5bgJiEqU4S0967vPAXa1c+cSzRVHYeAP7vpfPBTJMjRS5+/aJSU6MqPN k2rLEzmv9/RPIrxwNqSZQt8kFtLrURfzYaMjtB46lMMTtKPrAnyio8UO/kyf7pNjHJx7 8GzsBDhn31VMZvklyMHzs83l8VQ9TyLRzkIo4QUWFKmfJ5Uw6UWvN27jrMUqCCvHOqMO 4SPpVfQFeJP1h3BlnPrUqmyGGZtuQNPh2m2jW5cVwFDMBFSbej2XumW3mfZw950NYdrr xxIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=G8asUZ+0MUW3NBVjjluOo+rKwiQgZJGohdw8KMKLHAE=; b=iNGaYpv+Tk1OOsMvpNu8cQh/4ygJLD2CywbVwRefxyKM1q1UPE6OYOfl8bVnPFWH2l l3T9Zf44dgkyS6Lm7LHtHKg0oie1+uwum4poTZLkIeHC0szs/t/Vr+XXfmXxSzw3Wan/ kHz69iLkDwybzDxrJZHWQwFQddpAvSuC304AsgHkUKIzS65dG+xrN/7SuTWeD5W/ylmD EuEFW5j44Tx65VDYAKXo7ngI3Ay8N+aBNSDa1WG755R9Y526L7GrxiFmEamrneyhyb8q fjbcP9vjmi4O7a/aXBxSiGt84doDLhTI7G3RB+934fRdz+SDc/UaNrJBhc8oMZdcR7j5 V/Tw== X-Gm-Message-State: APjAAAVDSIP0uk05byx0ogWOiCp0wGINJwsz+mNX+9tamnv5uqbd8XEP v38KMi9eaO8xnTB2ArXgfgiRNQ== X-Google-Smtp-Source: APXvYqxUqCiSUdn+ULvnrFf3ArsbDyDXwRbDbqTZ7g40QzhR4t3RQ79nWHNkXlBdHX86miMfsC6LFg== X-Received: by 2002:a62:6385:: with SMTP id x127mr4959109pfb.244.1574264746474; Wed, 20 Nov 2019 07:45:46 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id s18sm31208564pfc.120.2019.11.20.07.45.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:45:45 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org Subject: [PATCH v2 05/11] thermal: max77620: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:14 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Fix up the following warning when compiled with make W=1: linux.git/drivers/thermal/max77620_thermal.c:48: warning: Function parameter or member 'temp' not described in 'max77620_thermal_read_temp' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/max77620_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/max77620_thermal.c b/drivers/thermal/max77620_thermal.c index 88fd0fbe0cfa..82d06c7411eb 100644 --- a/drivers/thermal/max77620_thermal.c +++ b/drivers/thermal/max77620_thermal.c @@ -33,7 +33,7 @@ struct max77620_therm_info { /** * max77620_thermal_read_temp: Read PMIC die temperatue. * @data: Device specific data. - * temp: Temperature in millidegrees Celsius + * @temp: Temperature in millidegrees Celsius * * The actual temperature of PMIC die is not available from PMIC. * PMIC only tells the status if it has crossed or not the threshold level From patchwork Wed Nov 20 15:45:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 11254291 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 748A013A4 for ; Wed, 20 Nov 2019 15:45:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4BDDE2071F for ; Wed, 20 Nov 2019 15:45:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E3AnSLk8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730153AbfKTPpw (ORCPT ); Wed, 20 Nov 2019 10:45:52 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:45688 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732455AbfKTPpv (ORCPT ); Wed, 20 Nov 2019 10:45:51 -0500 Received: by mail-pg1-f196.google.com with SMTP id k1so12187137pgg.12 for ; Wed, 20 Nov 2019 07:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=e/+C0/U/7T8ETxCupoulTe1zya9/ISeKYAztNAzb164=; b=E3AnSLk8a93bsgWxr4fcB/GPFvJ4Rxo5soxyRn5bqg6l49xuRK6YcbzlIUUW+u31d/ JA22kRY/pMbbK6pIyxFgfeLHI+IcM3+2nwmI0qvXJDZabbmDuqUiVLRhLr/SlgQh51oV UsRDODil4tFnA/SKcLzQnQ+fH8TLmKtJQuaXjNyammLFz8sJfJUN/4NBihEftSt/l1LP x+sqw0txJaK5+awwGSe60/jM8OFzrCCRY2WBzh7ui94S3wFWodQ+jtN2oCBeDML5mYft gGYXdwx2NpSBdm09KeHKgUEzj1qYlvdnhYlD26aXvxQF6VchwF5Zd1bpM9qETPcn/vAF N3Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=e/+C0/U/7T8ETxCupoulTe1zya9/ISeKYAztNAzb164=; b=KPSM9DuxynOnXbBBEcnsuMjhfVLtSUnjOn2UpiWma2VfLX9FHBXFe8MbG3Twy4pvkA RUOwjbHOj6qDQXBvXKeQJNi4TcYGtrYxhZmXfz3T3UYNLQYA+lSRICC0DEi31Hx3eKNP 9NilF2aXB/W79w/KZaKGRDjHLG3dcRv4ceoxgb0ELIFr8BKyzGOVJyb8yT6j+KtalBkx tIj6Q9j8KaYj+ABfY5vpHGBXXnAkBD4GBiSHBQDxNbThBG4RHauFGTZF34QNMbxzSuGQ zt/lDeddRAwLCIe/RGR2uGokIR+dtDt80EjcyMAw3ZKbp2JQ/QwwTvY/YNu/+O01Q6mF Pdlg== X-Gm-Message-State: APjAAAUrESwq8Js+HRrec+qG4YpDZvknM8QSrnTVvifF9eZw5XNoTZOj r9IZYrTDoMD6he5pcuBzwwTWww== X-Google-Smtp-Source: APXvYqzj7lopeOEFvFadHOn4FAisXgAAfQF8EcvPp5oAfbvhy/8a9sOXfobTdg947a+fRpG3+UQUCw== X-Received: by 2002:a63:d20f:: with SMTP id a15mr4164989pgg.268.1574264750264; Wed, 20 Nov 2019 07:45:50 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id u20sm30558372pgo.50.2019.11.20.07.45.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:45:49 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 06/11] thermal: mediatek: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:15 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Replace a comment starting with /** by simply /* to avoid having it interpreted as a kernel-doc comment. Describe missing function parameters where needed. Fixes up the following warnings when compiled with make W=1: linux.git/drivers/thermal/mtk_thermal.c:374: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8173_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:413: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2701_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:443: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2712_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:499: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8183_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:529: warning: Function parameter or member 'sensno' not described in 'raw_to_mcelsius' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/mtk_thermal.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c index acf4854cbb8b..76e30603d4d5 100644 --- a/drivers/thermal/mtk_thermal.c +++ b/drivers/thermal/mtk_thermal.c @@ -358,7 +358,7 @@ static const int mt7622_mux_values[MT7622_NUM_SENSORS] = { 0, }; static const int mt7622_vts_index[MT7622_NUM_SENSORS] = { VTS1 }; static const int mt7622_tc_offset[MT7622_NUM_CONTROLLER] = { 0x0, }; -/** +/* * The MT8173 thermal controller has four banks. Each bank can read up to * four temperature sensors simultaneously. The MT8173 has a total of 5 * temperature sensors. We use each bank to measure a certain area of the @@ -400,7 +400,7 @@ static const struct mtk_thermal_data mt8173_thermal_data = { .sensor_mux_values = mt8173_mux_values, }; -/** +/* * The MT2701 thermal controller has one bank, which can read up to * three temperature sensors simultaneously. The MT2701 has a total of 3 * temperature sensors. @@ -430,7 +430,7 @@ static const struct mtk_thermal_data mt2701_thermal_data = { .sensor_mux_values = mt2701_mux_values, }; -/** +/* * The MT2712 thermal controller has one bank, which can read up to * four temperature sensors simultaneously. The MT2712 has a total of 4 * temperature sensors. @@ -484,7 +484,7 @@ static const struct mtk_thermal_data mt7622_thermal_data = { .sensor_mux_values = mt7622_mux_values, }; -/** +/* * The MT8183 thermal controller has one bank for the current SW framework. * The MT8183 has a total of 6 temperature sensors. * There are two thermal controller to control the six sensor. @@ -495,7 +495,6 @@ static const struct mtk_thermal_data mt7622_thermal_data = { * data, and this indeed needs the temperatures of the individual banks * for making better decisions. */ - static const struct mtk_thermal_data mt8183_thermal_data = { .auxadc_channel = MT8183_TEMP_AUXADC_CHANNEL, .num_banks = MT8183_NUM_SENSORS_PER_ZONE, @@ -519,7 +518,8 @@ static const struct mtk_thermal_data mt8183_thermal_data = { /** * raw_to_mcelsius - convert a raw ADC value to mcelsius - * @mt: The thermal controller + * @mt: The thermal controller + * @sensno: sensor number * @raw: raw ADC value * * This converts the raw ADC value to mcelsius using the SoC specific From patchwork Wed Nov 20 15:45:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 11254295 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 10A2E138C for ; Wed, 20 Nov 2019 15:45:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D438820730 for ; Wed, 20 Nov 2019 15:45:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CNEfZPSc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732469AbfKTPp5 (ORCPT ); Wed, 20 Nov 2019 10:45:57 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:46724 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732464AbfKTPpz (ORCPT ); Wed, 20 Nov 2019 10:45:55 -0500 Received: by mail-pf1-f194.google.com with SMTP id 193so14385898pfc.13 for ; Wed, 20 Nov 2019 07:45:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=v3CJPtWLFIAdj/z5fwUlZLLT5DwATGfWb2hJrMtJGHc=; b=CNEfZPSc00pRWoq84G/7TVzpTaMRm4f05LM6FCV1VOsDJFHTamkVpCGFoDhuONbHLF fGQ3QFgk9JrPR5QovNQuEOktGYhLYyTUE7QqhttLNJJdgBfd6K9y7RNy2qQC6NTZ6nRK GyGT0usaaxjppXXdsYbHxQFzFo9OPWes7B+dx92L2sMB9Vhg1yAPcqyE9s6iUHHmbKYK aklatOW98Mb6E08K/ThSluXkneUIGi6JY2HhTal3fJc3GrEpmH7Lik/cfIOPa3HokwwS lfBHdgSAEUCuwhZWoNPvdJewIftJz5en5zEsLR1GM8W1VyVpFp5cK9/DVMtFBlsySZ/7 dKgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=v3CJPtWLFIAdj/z5fwUlZLLT5DwATGfWb2hJrMtJGHc=; b=MEKeYql5B/1fuy59zvy5Sv71Zjfzx79FO6YRLD1P/sHMjqs7AEh507IdJXgyP0IWez kjdr4fJ4CkZ16bTvT+cfQy0w8Izuja5F0cOdwc1JG90C5y6a4t4mTFArdVeqoDzf52bF jleTeGdqmolZMTouQYKSAduX99FxViAUwtMXSRNqhpfSanutUp7hQYX4jTqArRYn2nKQ VEyNsxrw4tp/R46Uu2BKfc3HeXxWHyXt8DViqXHtk87sh2bmkReFfDyFe6zKLLU0t6T8 zKMzvO8kTPn2ScyVkQ2v4BPwLXUMbpo5RcKyhkGesAMQRCy7hHB2qF/1hcHGgXdv4DS6 3mDQ== X-Gm-Message-State: APjAAAX6I7kRnLLEiMCP74HDSUOxwOgr3b+wm+9XmQOtja/AlsvjEKih NxdecOYKHaUj0LPCo1LjRIlwGw== X-Google-Smtp-Source: APXvYqxTZ7gTIsjV9nk438TlBRqYyZMMBLSDJ7P/pE/AYAB1y/QGOt8ZB8aniHR4LsuEnlOE8F3Ukg== X-Received: by 2002:a63:a804:: with SMTP id o4mr3735957pgf.401.1574264753964; Wed, 20 Nov 2019 07:45:53 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id 67sm7938816pjz.27.2019.11.20.07.45.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:45:53 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH v2 07/11] thermal: rockchip: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:16 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Replace a comment starting with /** by simply /* to avoid having it interpreted as a kernel-doc comment. Describe missing function parameters where needed. Fixes up the following warnings when compiled with make W=1: linux.git/drivers/thermal/rockchip_thermal.c:27: warning: cannot understand function prototype: 'enum tshut_mode ' linux.git/drivers/thermal/rockchip_thermal.c:37: warning: cannot understand function prototype: 'enum tshut_polarity ' linux.git/drivers/thermal/rockchip_thermal.c:46: warning: cannot understand function prototype: 'enum sensor_id ' linux.git/drivers/thermal/rockchip_thermal.c:56: warning: cannot understand function prototype: 'enum adc_sort_mode ' linux.git/drivers/thermal/rockchip_thermal.c:123: warning: Function parameter or member 'chn_id' not described in 'rockchip_tsadc_chip' linux.git/drivers/thermal/rockchip_thermal.c:123: warning: Function parameter or member 'control' not described in 'rockchip_tsadc_chip' linux.git/drivers/thermal/rockchip_thermal.c:167: warning: Function parameter or member 'sensors' not described in 'rockchip_thermal_data' linux.git/drivers/thermal/rockchip_thermal.c:608: warning: Function parameter or member 'grf' not described in 'rk_tsadcv2_initialize' linux.git/drivers/thermal/rockchip_thermal.c:608: warning: Function parameter or member 'regs' not described in 'rk_tsadcv2_initialize' linux.git/drivers/thermal/rockchip_thermal.c:608: warning: Function parameter or member 'tshut_polarity' not described in 'rk_tsadcv2_initialize' linux.git/drivers/thermal/rockchip_thermal.c:644: warning: Function parameter or member 'grf' not described in 'rk_tsadcv3_initialize' linux.git/drivers/thermal/rockchip_thermal.c:644: warning: Function parameter or member 'regs' not described in 'rk_tsadcv3_initialize' linux.git/drivers/thermal/rockchip_thermal.c:644: warning: Function parameter or member 'tshut_polarity' not described in 'rk_tsadcv3_initialize' linux.git/drivers/thermal/rockchip_thermal.c:732: warning: Function parameter or member 'regs' not described in 'rk_tsadcv3_control' linux.git/drivers/thermal/rockchip_thermal.c:732: warning: Function parameter or member 'enable' not described in 'rk_tsadcv3_control' linux.git/drivers/thermal/rockchip_thermal.c:1211: warning: Function parameter or member 'reset' not described in 'rockchip_thermal_reset_controller' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/rockchip_thermal.c | 22 ++++++++++++++++------ 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index 343c2f5c5a25..9ed8085bb792 100644 --- a/drivers/thermal/rockchip_thermal.c +++ b/drivers/thermal/rockchip_thermal.c @@ -19,7 +19,7 @@ #include #include -/** +/* * If the temperature over a period of time High, * the resulting TSHUT gave CRU module,let it reset the entire chip, * or via GPIO give PMIC. @@ -29,7 +29,7 @@ enum tshut_mode { TSHUT_MODE_GPIO, }; -/** +/* * The system Temperature Sensors tshut(tshut) polarity * the bit 8 is tshut polarity. * 0: low active, 1: high active @@ -39,7 +39,7 @@ enum tshut_polarity { TSHUT_HIGH_ACTIVE, }; -/** +/* * The system has two Temperature Sensors. * sensor0 is for CPU, and sensor1 is for GPU. */ @@ -48,7 +48,7 @@ enum sensor_id { SENSOR_GPU, }; -/** +/* * The conversion table has the adc value and temperature. * ADC_DECREMENT: the adc value is of diminishing.(e.g. rk3288_code_table) * ADC_INCREMENT: the adc value is incremental.(e.g. rk3368_code_table) @@ -80,13 +80,14 @@ struct chip_tsadc_table { /** * struct rockchip_tsadc_chip - hold the private data of tsadc chip - * @chn_id[SOC_MAX_SENSORS]: the sensor id of chip correspond to the channel + * @chn_id: array of sensor ids of chip corresponding to the channel * @chn_num: the channel number of tsadc chip * @tshut_temp: the hardware-controlled shutdown temperature value * @tshut_mode: the hardware-controlled shutdown mode (0:CRU 1:GPIO) * @tshut_polarity: the hardware-controlled active polarity (0:LOW 1:HIGH) * @initialize: SoC special initialize tsadc controller method * @irq_ack: clear the interrupt + * @control: enable/disable method for the tsadc controller * @get_temp: get the temperature * @set_alarm_temp: set the high temperature interrupt * @set_tshut_temp: set the hardware-controlled shutdown temperature @@ -139,7 +140,7 @@ struct rockchip_thermal_sensor { * @chip: pointer to the platform/configuration data * @pdev: platform device of thermal * @reset: the reset controller of tsadc - * @sensors[SOC_MAX_SENSORS]: the thermal sensor + * @sensors: array of thermal sensors * @clk: the controller clock is divided by the exteral 24MHz * @pclk: the advanced peripherals bus clock * @grf: the general register file will be used to do static set by software @@ -590,6 +591,9 @@ static int rk_tsadcv2_code_to_temp(const struct chip_tsadc_table *table, /** * rk_tsadcv2_initialize - initialize TASDC Controller. + * @grf: the general register file will be used to do static set by software + * @regs: the base address of tsadc controller + * @tshut_polarity: the hardware-controlled active polarity (0:LOW 1:HIGH) * * (1) Set TSADC_V2_AUTO_PERIOD: * Configure the interleave between every two accessing of @@ -624,6 +628,9 @@ static void rk_tsadcv2_initialize(struct regmap *grf, void __iomem *regs, /** * rk_tsadcv3_initialize - initialize TASDC Controller. + * @grf: the general register file will be used to do static set by software + * @regs: the base address of tsadc controller + * @tshut_polarity: the hardware-controlled active polarity (0:LOW 1:HIGH) * * (1) The tsadc control power sequence. * @@ -723,6 +730,8 @@ static void rk_tsadcv2_control(void __iomem *regs, bool enable) /** * rk_tsadcv3_control - the tsadc controller is enabled or disabled. + * @regs: the base address of tsadc controller + * @enable: boolean flag to enable the controller * * NOTE: TSADC controller works at auto mode, and some SoCs need set the * tsadc_q_sel bit on TSADCV2_AUTO_CON[1]. The (1024 - tsadc_q) as output @@ -1206,6 +1215,7 @@ rockchip_thermal_register_sensor(struct platform_device *pdev, /** * Reset TSADC Controller, reset all tsadc registers. + * @reset: the reset controller of tsadc */ static void rockchip_thermal_reset_controller(struct reset_control *reset) { From patchwork Wed Nov 20 15:45:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 11254315 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B306F13A4 for ; Wed, 20 Nov 2019 15:46:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92B6D20709 for ; Wed, 20 Nov 2019 15:46:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pyfzMEiX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731516AbfKTPq0 (ORCPT ); Wed, 20 Nov 2019 10:46:26 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:33973 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732464AbfKTPp6 (ORCPT ); Wed, 20 Nov 2019 10:45:58 -0500 Received: by mail-pf1-f196.google.com with SMTP id n13so14420077pff.1 for ; Wed, 20 Nov 2019 07:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=NSg5zBP2bkEtgf/AJ9lwtdlcJh9mMI+s8A/QE9EBrqI=; b=pyfzMEiXET5WNLh0lbzWH2k8Ma4kL/gchA2TSfgf9FOt77Ipge3tgeetL+B/eMQ3nQ qK74PRyKA6Xzfhp8SDKE8IDOG9FnvPqI6zAxyvVWg6TQP7y92eClE7VPgn5EQgevKmTn 31isyeVwYrt/63T3W7c/7GYIA5cpiXc/FjWnfRx3+zoDJBZViOljMLADxrUxQ7RA6vsu R4P0FAggkEapQV9P/JrJvCvOqiJCr2EcBVxIorboYb7NdrqFEAaI3ZrbK10/PJQHQdmL XAbs0VUQKIfNCfpp8OueO+3Wys7vJrR6BqL9ZgscME+PrmMK7xFCfeyBCRbpBj9pzPrW baSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=NSg5zBP2bkEtgf/AJ9lwtdlcJh9mMI+s8A/QE9EBrqI=; b=kF2xZGOXDBdRtfP21wAbxis/Y89JL4WXVztVfNgRlvJhH3T6hVOmDZGsW/l7uH4EwR LZhURGAB0Ej6e9EGcw5rBhPmuaD9dFKaZgMAX/EG72nSVLkmrkDphcp68m3ymnVMPULb LwcGN06eDu5gcdYRUUwsBGDaEBKsAh/dDZc14pcX7x5KW12YJWjbTJ68vR2Gr44hth5o iiopaoBO9zsVZQvmpDh7RpUuZvPc5kXeaGrCddymGJ8Zb0/68KNd3Xbj/+tLoPf13YJ8 QZ6CbEiATGYrzU0InH6TS652iwU/GrCaG+cGCBKLhB2HPb2dacFOUsCWc5RwDr7oCvl6 URsQ== X-Gm-Message-State: APjAAAUtQq/QySdU22hK3ET1YPhynas78PXYSk8Ym0OrQ7pEzKUP1m+E +WELCW82n/7kbw/plgJihr7BAw== X-Google-Smtp-Source: APXvYqzJUD458tw9LKLIOVTpzUVrazVeldBx+3/BvF6tmCLBMY2h07OohUoX/CJQd6M8piZEF0jNfw== X-Received: by 2002:aa7:8b08:: with SMTP id f8mr4854182pfd.92.1574264757863; Wed, 20 Nov 2019 07:45:57 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id 125sm29559387pfu.136.2019.11.20.07.45.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:45:57 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 08/11] thermal: samsung: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:17 +0530 Message-Id: <1ded1697c6e5eff11b034b3302b9c79e88fa9c42.1574242756.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Fix up the following warning when compiled with make W=1: linux.git/drivers/thermal/samsung/exynos_tmu.c:141: warning: bad line: driver linux.git/drivers/thermal/samsung/exynos_tmu.c:203: warning: Function parameter or member 'tzd' not described in 'exynos_tmu_data' linux.git/drivers/thermal/samsung/exynos_tmu.c:203: warning: Function parameter or member 'tmu_set_trip_temp' not described in 'exynos_tmu_data' linux.git/drivers/thermal/samsung/exynos_tmu.c:203: warning: Function parameter or member 'tmu_set_trip_hyst' not described in 'exynos_tmu_data' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/samsung/exynos_tmu.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index fb2c55123a99..8193b66a3f83 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -138,7 +138,7 @@ enum soc_type { /** * struct exynos_tmu_data : A structure to hold the private data of the TMU - driver + * driver * @id: identifier of the one instance of the TMU controller. * @base: base address of the single instance of the TMU controller. * @base_second: base address of the common registers of the TMU controller. @@ -162,8 +162,11 @@ enum soc_type { * 0 < reference_voltage <= 31 * @regulator: pointer to the TMU regulator structure. * @reg_conf: pointer to structure to register with core thermal. + * @tzd: pointer to thermal_zone_device structure * @ntrip: number of supported trip points. * @enabled: current status of TMU device + * @tmu_set_trip_temp: SoC specific method to set trip (rising threshold) + * @tmu_set_trip_hyst: SoC specific to set hysteresis (falling threshold) * @tmu_initialize: SoC specific TMU initialization method * @tmu_control: SoC specific TMU control method * @tmu_read: SoC specific TMU temperature read method From patchwork Wed Nov 20 15:45:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 11254309 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2B45013A4 for ; Wed, 20 Nov 2019 15:46:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED1E220709 for ; Wed, 20 Nov 2019 15:46:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="v+OCpIVA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732496AbfKTPqH (ORCPT ); Wed, 20 Nov 2019 10:46:07 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:43929 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730270AbfKTPqD (ORCPT ); Wed, 20 Nov 2019 10:46:03 -0500 Received: by mail-pf1-f195.google.com with SMTP id 3so14395587pfb.10 for ; Wed, 20 Nov 2019 07:46:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=K3vR2uD6aSmik2p5f+bI9hiJX4uAEUswd2VgOXlpWQQ=; b=v+OCpIVAIUha5dasNMn3UvNfvT62nwwgAYOV8SZl2s4KlPXzNx+Y4y++1y289foJj4 b3iRbEixPzm4H6s9NnmRYjccAQ1YKlJHSXNG7J3NYVhSi9KYAkVZL7+r+qZQfnArJKNn Yw+IhGEIrPZ8HYEGcbWz3FpdlBjSD01zuR9DPZ8junhpswl8xHCTYf96heDEVns7SbdA oqXVAJ7lKIYa/hzP14UjsMuqpTfAsr4X/OoBdfEWPZhCK+XoJKn/Ni1kYs0UjzSYv59O Bo1+ORxjDzOFp1d4H1WTVGTV9FhN+VcdMDKqLxkkXHiR956QFnkeYxnNFjO3o19o7DeS lWMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=K3vR2uD6aSmik2p5f+bI9hiJX4uAEUswd2VgOXlpWQQ=; b=nChSdoJzIHDhHacRvbubdtAm22tknYZgpBNu02Vh0uOjM0Fwtk5dDse98r8311wvXC OH62KJnjq2v5HSfO8r34okxPIQnA8i9Q2CkHwiRhRdNPbBPD8L1neaJeIr2YEO+iQelS AUSK3AUpP1beA0DZntJR9Lt6iHulH00L8vMn7e6OPpdEyOBlTKoKBDEM7BwIs9hCiVFK xGAPBAC37G4vTvdRDo9Nkr9uIjGyqJw8umYjSWNbWS0l89OFulKZAIZcd1bUz5FH06ei nGtnHz3UJ4WjSYT+9oCenY+R0Ke10MLu2kfpYT65jjG3fgm9XDm0kre1yJJ5ByOy3hA0 3YRg== X-Gm-Message-State: APjAAAXH2b8qXpHQCPf7IM+Agke4l6Tf6NJTV9C9KDjV+dQA4eLocEil iyYcDEARH4pKTs+99R7fHow7rw== X-Google-Smtp-Source: APXvYqxCyiCzIH5NKxNZcPzn1VR+PddAQf1yOZ8U85b+2Izo7oqHFzfQTCS3bhYodrVfdki555hMYQ== X-Received: by 2002:a62:83ca:: with SMTP id h193mr4757521pfe.218.1574264761731; Wed, 20 Nov 2019 07:46:01 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id z187sm27879675pgd.82.2019.11.20.07.46.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:46:00 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org Subject: [PATCH v2 09/11] thermal: tegra: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:18 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Fix up the following warning when compiled with make W=1: linux.git/drivers/thermal/tegra/soctherm.c:369: warning: Function parameter or member 'value' not described in 'ccroc_writel' linux.git/drivers/thermal/tegra/soctherm.c:369: warning: Excess function parameter 'v' description in 'ccroc_writel' linux.git/drivers/thermal/tegra/soctherm.c:447: warning: Function parameter or member 'dev' not described in 'enforce_temp_range' linux.git/drivers/thermal/tegra/soctherm.c:772: warning: Function parameter or member 'sg' not described in 'tegra_soctherm_set_hwtrips' linux.git/drivers/thermal/tegra/soctherm.c:772: warning: Function parameter or member 'tz' not described in 'tegra_soctherm_set_hwtrips' linux.git/drivers/thermal/tegra/soctherm.c:944: warning: Function parameter or member 'ts' not described in 'soctherm_oc_intr_enable' linux.git/drivers/thermal/tegra/soctherm.c:1167: warning: Function parameter or member 'data' not described in 'soctherm_oc_irq_disable' linux.git/drivers/thermal/tegra/soctherm.c:1167: warning: Excess function parameter 'irq_data' description in 'soctherm_oc_irq_disable' linux.git/drivers/thermal/tegra/soctherm.c:1224: warning: Function parameter or member 'ctrlr' not described in 'soctherm_irq_domain_xlate_twocell' linux.git/drivers/thermal/tegra/soctherm.c:1686: warning: Function parameter or member 'pdev' not described in 'soctherm_init_hw_throt_cdev' linux.git/drivers/thermal/tegra/soctherm.c:1764: warning: Function parameter or member 'ts' not described in 'throttlectl_cpu_level_cfg' linux.git/drivers/thermal/tegra/soctherm.c:1812: warning: Function parameter or member 'ts' not described in 'throttlectl_cpu_level_select' linux.git/drivers/thermal/tegra/soctherm.c:1855: warning: Function parameter or member 'ts' not described in 'throttlectl_cpu_mn' linux.git/drivers/thermal/tegra/soctherm.c:1886: warning: Function parameter or member 'ts' not described in 'throttlectl_gpu_level_select' linux.git/drivers/thermal/tegra/soctherm.c:1928: warning: Function parameter or member 'ts' not described in 'soctherm_throttle_program' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/tegra/soctherm.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c index 5acaad3a594f..66e0639da4bf 100644 --- a/drivers/thermal/tegra/soctherm.c +++ b/drivers/thermal/tegra/soctherm.c @@ -360,7 +360,7 @@ static struct soctherm_oc_irq_chip_data soc_irq_cdata; /** * ccroc_writel() - writes a value to a CCROC register * @ts: pointer to a struct tegra_soctherm - * @v: the value to write + * @value: the value to write * @reg: the register offset * * Writes @v to @reg. No return value. @@ -435,6 +435,7 @@ static int tegra_thermctl_get_temp(void *data, int *out_temp) /** * enforce_temp_range() - check and enforce temperature range [min, max] + * @dev: struct device * of the SOC_THERM instance * @trip_temp: the trip temperature to check * * Checks and enforces the permitted temperature range that SOC_THERM @@ -747,6 +748,8 @@ static int get_hot_temp(struct thermal_zone_device *tz, int *trip, int *temp) /** * tegra_soctherm_set_hwtrips() - set HW trip point from DT data * @dev: struct device * of the SOC_THERM instance + * @sg: pointer to the sensor group to set the thermtrip temperature for + * @tz: struct thermal_zone_device * * * Configure the SOC_THERM HW trip points, setting "THERMTRIP" * "THROTTLE" trip points , using "thermtrips", "critical" or "hot" @@ -931,6 +934,7 @@ static irqreturn_t soctherm_thermal_isr_thread(int irq, void *dev_id) /** * soctherm_oc_intr_enable() - Enables the soctherm over-current interrupt + * @ts: pointer to a struct tegra_soctherm * @alarm: The soctherm throttle id * @enable: Flag indicating enable the soctherm over-current * interrupt or disable it @@ -1156,7 +1160,7 @@ static void soctherm_oc_irq_enable(struct irq_data *data) /** * soctherm_oc_irq_disable() - Disables overcurrent interrupt requests - * @irq_data: The interrupt request information + * @data: The interrupt request information * * Clears the interrupt request enable bit of the overcurrent * interrupt request chip data. @@ -1206,6 +1210,7 @@ static int soctherm_oc_irq_map(struct irq_domain *h, unsigned int virq, /** * soctherm_irq_domain_xlate_twocell() - xlate for soctherm interrupts * @d: Interrupt request domain + * @ctrlr: Controller device tree node * @intspec: Array of u32s from DTs "interrupt" property * @intsize: Number of values inside the intspec array * @out_hwirq: HW IRQ value associated with this interrupt @@ -1681,6 +1686,7 @@ static int soctherm_throt_cfg_parse(struct device *dev, /** * soctherm_init_hw_throt_cdev() - Parse the HW throttle configurations * and register them as cooling devices. + * @pdev: Pointer to platform_device struct */ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev) { @@ -1751,6 +1757,7 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev) /** * throttlectl_cpu_level_cfg() - programs CCROC NV_THERM level config + * @ts: pointer to a struct tegra_soctherm * @level: describing the level LOW/MED/HIGH of throttling * * It's necessary to set up the CPU-local CCROC NV_THERM instance with @@ -1798,6 +1805,7 @@ static void throttlectl_cpu_level_cfg(struct tegra_soctherm *ts, int level) /** * throttlectl_cpu_level_select() - program CPU pulse skipper config + * @ts: pointer to a struct tegra_soctherm * @throt: the LIGHT/HEAVY of throttle event id * * Pulse skippers are used to throttle clock frequencies. This @@ -1841,6 +1849,7 @@ static void throttlectl_cpu_level_select(struct tegra_soctherm *ts, /** * throttlectl_cpu_mn() - program CPU pulse skipper configuration + * @ts: pointer to a struct tegra_soctherm * @throt: the LIGHT/HEAVY of throttle event id * * Pulse skippers are used to throttle clock frequencies. This @@ -1874,6 +1883,7 @@ static void throttlectl_cpu_mn(struct tegra_soctherm *ts, /** * throttlectl_gpu_level_select() - selects throttling level for GPU + * @ts: pointer to a struct tegra_soctherm * @throt: the LIGHT/HEAVY of throttle event id * * This function programs soctherm's interface to GK20a NV_THERM to select @@ -1918,6 +1928,7 @@ static int soctherm_oc_cfg_program(struct tegra_soctherm *ts, /** * soctherm_throttle_program() - programs pulse skippers' configuration + * @ts: pointer to a struct tegra_soctherm * @throt: the LIGHT/HEAVY of the throttle event id. * * Pulse skippers are used to throttle clock frequencies. From patchwork Wed Nov 20 15:45:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 11254301 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9DC76138C for ; Wed, 20 Nov 2019 15:46:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E3722080F for ; Wed, 20 Nov 2019 15:46:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TTD/GPgb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732492AbfKTPqG (ORCPT ); Wed, 20 Nov 2019 10:46:06 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:44932 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732444AbfKTPqG (ORCPT ); Wed, 20 Nov 2019 10:46:06 -0500 Received: by mail-pf1-f196.google.com with SMTP id q26so14388019pfn.11 for ; Wed, 20 Nov 2019 07:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=AgDAyNnziZ2/rpXVW+6uZm6qCS/g3MtXyy21omVhiKk=; b=TTD/GPgbVJlqWJezadRMyot/6RcSAW4tTnmkmdhwjB+qH876bPgz4yk5cS7IiGyP3K trLYX6i0Vl5wNDbXS6dOb4z3Jji0Zde+ZejgKmxq+3s/LVxGpRJbJv8Gl2YzYZ2azXgr J/YNU2VewuB697Ynqi/+TODfrCjqZ3gVhcTfO13sryD2gZlgriNpW636jt++tlGJQZQP d6nK84JZI6WOMBLBBUMqz4sR9NWbVcGQ2fRx3/ctZE88lH5y/l2gMKLwbSOxWVXk/j53 atgnWdYX91MJ1T3R5xvOHUtLt7nF+uncFHBbik2aiHOtlUqjlO4/wzlwJ5J3nE2GEpua Fppg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=AgDAyNnziZ2/rpXVW+6uZm6qCS/g3MtXyy21omVhiKk=; b=rVgF+2CYD4t3xOpKHzJuF4tc/ZZmr5AcLlUyfzHp3zK/3OsyoFdwyZ/agNUquddIgs 4ElImKNG1qsDZFNhievBdgoaYhRlxqxesx74tJ3efMxoXuYtxc2vscwVXr/RCfMO7noH 6/aYQOxyvMNTE0QeE82++E2G9n89/iXwINoJ7Pfxp5LygkccOFJJyQpKP9VGb5Ml55sR Bs1bhfCmNXI1l6dvkT1UX0TixeU7rx0nMItCD5ki25K6opFM7PjnGr0JFB0EebaztqLH Ci0m1f7KqmiXPKsjW0gzRMnEMdjHWOLkCYhQNl7NxW2u9fx4K/zoKdD3KVR2z9ZgSVQS 9KiQ== X-Gm-Message-State: APjAAAU6Q/yh0lYMVs410RcTzcUP2N50uPafyRXSrHeXG1/a2CBAmhUr U28AlQgp0LwjNlQjjISmaFq0gg== X-Google-Smtp-Source: APXvYqyB7lY58RH7CXaXDrsbQa1IXAGZ2t49P4RvoB6lsC3HH+gC0HPsfAEo+5uM2xZEinvTSMklGw== X-Received: by 2002:a62:e119:: with SMTP id q25mr4862880pfh.161.1574264765290; Wed, 20 Nov 2019 07:46:05 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id 136sm30313724pfb.49.2019.11.20.07.46.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:46:04 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org Subject: [PATCH v2 10/11] thermal: amlogic: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:19 +0530 Message-Id: <139c9191f1a18d528b5f94376facf40291d28244.1574242756.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Fix up the following warning when compiled with make W=1: linux.git/drivers/thermal/amlogic_thermal.c:78: warning: Function parameter or member 'A' not described in 'amlogic_thermal_soc_calib_data' linux.git/drivers/thermal/amlogic_thermal.c:78: warning: Function parameter or member 'B' not described in 'amlogic_thermal_soc_calib_data' linux.git/drivers/thermal/amlogic_thermal.c:78: warning: Function parameter or member 'm' not described in 'amlogic_thermal_soc_calib_data' linux.git/drivers/thermal/amlogic_thermal.c:78: warning: Function parameter or member 'n' not described in 'amlogic_thermal_soc_calib_data' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/amlogic_thermal.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c index 8a9e9bc421c6..ccb1fe18e993 100644 --- a/drivers/thermal/amlogic_thermal.c +++ b/drivers/thermal/amlogic_thermal.c @@ -67,7 +67,11 @@ /** * struct amlogic_thermal_soc_calib_data - * @A, B, m, n: calibration parameters + * @A: calibration parameters + * @B: calibration parameters + * @m: calibration parameters + * @n: calibration parameters + * * This structure is required for configuration of amlogic thermal driver. */ struct amlogic_thermal_soc_calib_data { From patchwork Wed Nov 20 15:45:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 11254305 X-Patchwork-Delegate: eduardo.valentin@ti.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5D26413A4 for ; Wed, 20 Nov 2019 15:46:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D2B72080F for ; Wed, 20 Nov 2019 15:46:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FVXrQCwG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732506AbfKTPqL (ORCPT ); Wed, 20 Nov 2019 10:46:11 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:33863 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732491AbfKTPqJ (ORCPT ); Wed, 20 Nov 2019 10:46:09 -0500 Received: by mail-pl1-f196.google.com with SMTP id h13so14020647plr.1 for ; Wed, 20 Nov 2019 07:46:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=XsaIBKQXmIKdbRdQ/GaM37eqJC/1U/v/pIK3m7cBLow=; b=FVXrQCwGGlFa8AiYBJLxFUB/FwOeAS6Iyd+JEgzbLkClNVuIjQ3OetLej32TbAu2aP MxQu2vBBglMV9Uwx934dgYhz8BoF8vm7yZS+vOEqXl6QmiezSAJWHw/Bn+mVFlDZNMFW cqg6O8KhRBst6sZ/DfDMK00auNWQr7GsgDHm0vX31D9JbEOEfS/lBRFkuMOcX4c8OYCe aOUT9+CS9AAmyM/s7C5zAQeA7vzsaEMYa1Qgm+qiXY4n7u4nhIH9OZ+4sg57WP5KyBRY UzGjLg202ZnsAGtWqHFCMXq9SFn01hDQwfWWWnxkeMbpqWmsB9rttG9ol1F5VQMMoMXS O6jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=XsaIBKQXmIKdbRdQ/GaM37eqJC/1U/v/pIK3m7cBLow=; b=DtsxZ5FndZJ7kBpH3h1PIhmCqrnThDWTJqva/L8rauMgCAAbUM0hBz8npWkUDntXrP tl5ood+5sb9iuY5mKXEAuctyYVyRtpzwOjkvXvxHQ/xtHIYg/5aU/yzDdFLupTvsAJV3 nbI/JBnmoNvWfd9d19iI/yLutKho/BUKNediI2BrTS3t3cA0Zdxxpxi8uOBfjkRx126v 3kFew+z6QslgDgb27djsMzVvPdjABaJqP3Q2ELscjgcnvh8+SbQfYuTfAmNQB4/gKD8Y CakvweOEn25Mrb9h932zCZngrCFR9iuWhuxKJp3CUkLQ8TFEZSXibamBmeRt5vZNT+Pb vAnw== X-Gm-Message-State: APjAAAXnJo0DdqCOMtVVq04bFz/Lz8cxzueZLHK6z8fTOb86Oy9zc3px zI1kqhNZy6COkCeonC4pdApWSQ== X-Google-Smtp-Source: APXvYqwSje57oE5y3bBVJjGXG2B2M4xxUYYkxaLEakRWmjFy/GHedrja+GYKVJcVdFnwtR7GHryhvg== X-Received: by 2002:a17:90b:3108:: with SMTP id gc8mr4878371pjb.54.1574264769037; Wed, 20 Nov 2019 07:46:09 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id o16sm7414811pjp.23.2019.11.20.07.46.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:46:08 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org Subject: [PATCH v2 11/11] thermal: zx2967: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:20 +0530 Message-Id: <1b4f6fb91e2e713ad5135f0d40dcded65dee9d0e.1574242756.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Fix up the following warning when compiled with make W=1: linux.git/drivers/thermal/zx2967_thermal.c:57: warning: Function parameter or member 'dev' not described in 'zx2967_thermal_priv' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/zx2967_thermal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/thermal/zx2967_thermal.c b/drivers/thermal/zx2967_thermal.c index 7c8a82c8e1e9..8e3a2d3c2f9a 100644 --- a/drivers/thermal/zx2967_thermal.c +++ b/drivers/thermal/zx2967_thermal.c @@ -45,6 +45,7 @@ * @clk_topcrm: topcrm clk structure * @clk_apb: apb clk structure * @regs: pointer to base address of the thermal sensor + * @dev: struct device pointer */ struct zx2967_thermal_priv {