From patchwork Thu Jul 26 16:17:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546115 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E9114112E for ; Thu, 26 Jul 2018 16:18:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D6E2C2B88E for ; Thu, 26 Jul 2018 16:18:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CAF262B895; Thu, 26 Jul 2018 16:18:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 49B162B88E for ; Thu, 26 Jul 2018 16:18:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731800AbeGZRgI (ORCPT ); Thu, 26 Jul 2018 13:36:08 -0400 Received: from mail-eopbgr10052.outbound.protection.outlook.com ([40.107.1.52]:34018 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731819AbeGZRgH (ORCPT ); Thu, 26 Jul 2018 13:36:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JvZvY5UvKahSel7LlWvKLI0viIevn8p40qsDPimS030=; b=SpaRNrYb/2w2E5RXizjxHirLXj3JMoIJP0VK6XrbaskGbSbhA1G8XnWy+V6VWPOLal3rHwOqyewjZXRKTpP9urGTuUmWjWGD6hcgRo2SvxkoBdoOihrK3UEol67Wl0Vr8phXDP3hgusBIQbe+UG2Lhf2bxz11U/E2jgnfPiHkC0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:27 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v2 01/10] drm/atomic: Add __drm_atomic_helper_plane_reset Date: Thu, 26 Jul 2018 17:17:47 +0100 Message-Id: <20180726161756.1794-2-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fcd5840e-af78-4e89-9b0e-08d5f3136c5f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;3:wqaV7SZwBTiiI0I1cX7m24AvV50TvZK2MmrdCmenWelEkOPUbZkW0ONCiXJiqtm2Pv1VMDHWt3h5oEUan+OSSclAFcwFwnP60M0xDGX+PbHcSNPCdKrX63uChhf0LgVJc2VMH1RrPXbO7oCt/RQrb+JykFGK6SgiBrAicZrr1grXI9PGaM1cuLN2TLjgj2GHQXJf4VOtdSfe7nPWSxEDc5OcGOj6zzrrirfL22b/uKowr5VXBDnCG7TlR6BD5f4u;25:WGQg/18uBCnmhNJejQ60X3JFFJPY1ygan7Os6Vl9LTdCjAvq6J/YuDUIG9O6Ivb6azIfaB1jzHcNwsoydTES4hK3Bvsy1AZoLTDPXPJ/58DxUdKnq52jtjz37ZS3zSq3R0+5rfJPWS6iuFV/SoJF+r9a90fgq2KlfLsCTOo1L64kTkDUiERBHBsnFQj3hskE+C10TZ/UOBvZ26wxtxUHVPz2EoshO+yGQ2mW9Rs5wc1nVIZ8bmEb7HyCR2XV9bMov0mN/nZYxL/I+BteMwDkrMyGZgqIADa9jYzaWiI6FRxqC8pQ2I8SY92kxYcy2BPbW+nlqquHnHQH4NU/YxNc8A==;31:02iz13OnCo8QZI/ihuujXeycxhsC+ny6To9vUV4u5jgWBJsRV/yTLRSjyQ9t/8BxqMaFy720PM6LUIzljK7Z9JloS8wjuo6uKCqOtTePXeHXyO7imqx0pxTlaC+uSNauZFJcClI5/P/gtwWMpLLZg5dIkkdBUs5FWaXX0kxXXm7wH2ZpbmWU8Y91G4uIT8GYJhdcMXo3thKlDrBr+e2qD1j38w/Ktt/Qpkdw7vN9Md8= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;20:W/DAeMZb15xX+M+4kITNPvS5m+XmAp1b6asYaSvs0oIWPefFCYF9UgGusfsfe4m9mf44wx4eIxznJvg+kAtcqLc3CIs3pXSDIWvLXnaoG7QEzIXdjHGAdS9+ZirlZQh5zPE7/5QuxhSvlZ8VcTdsyc2cTVT/sv4dMn0/URiiDTQ3eJqVZ48SwPOyMnwyhiz8mwcVpBE8rQ1KfR1AGIY8NoxLuGJXdTrxR4qRJUB566QH5UZdOTAq87XlrUut0wb88xPT8drXo4MSsBIXgv+dQAsbwBazKvrTmtAgX2QCzT1AihMZHve5sFP4dCms30d41P9rXB1Z6M3lOK+quU13dw==;4:p2jYrR7pdvBF0hi2/AGPyJ/l29svBZoPbGLdFwTuIGSkBxChlnmBJyyO05cWnrEBGnNTqWxMznSetlQg58h4pya0inxDpyLZYPHwuFl0x8GqeUWSQ6Q5Mqhtg+Me6R7K4cGCumaTdnx1qUNGF4ieqh9iBbf5kcI7niaOcxsTpAIVODvPIb00uqNKjVkn16H5C+atXx3NR6fcFs19QwV3Aw/d1KkzRGoaNxO3nV+YUxL9XIYzl5ZDwYjsmcRs/KlBnfnXAd11Ui7QXanQmTxQACz/Z+jrI7ut4ydll3fIbaspmMB9xu5cDwlKlTkeX40O X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(6666003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2552;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;23:kpq+xSZ9NV+6SgaD0Vwf+SicPxFnlbox7lyW4zewn0pEfSQQ2rLKsmIj268Kkc+HGiTVnwHz6jWGXDxAvhHPozafd35oJl6CDlAaVpAM14obi5eWpjugC4txG4b973f6sjwClHYVHlnSF5fPG1YdJcnhgRcJzembdkbFAuoZAte2qaudr+iEO4UBofJR3lr2b0tQLoBKSx53wMxywkGiYenIIUIHgq+kDHeD3tSOliBfcWebjiOwnAbpmwM3YaBYCepZ1dC3H8LVgRWJGZ4zU/fJCf4kXhDIr33q8/1V45Oun5EwHSguzw5h05l2aecXUdV7Aib+4fZSU4GqtBA27v0tWWzOk9qxrwTqBIkMeQmiUg81SFTb5tEI+q0GfND4Yd4qg4yqWIkkWm3ZD4LxjSoThyiWJiOZuA+2b8dfm7UYGENQzSuPKI9TfHc1eDIF6UxRQZD6FuhCbZPfl0Ya/HIjDUSgi1y8UERUBWsZrpdwT07K8YyJfPZq2Hf6Of1fXI31Vm0inwmgMzmhOrPr8rL6e9w3BfRB7lSiK55xt9KQy0GOR276GbayMw1FmSCpT0693O+MoAnIE2t+HTeW9N+o5AOIF84Mf0jm9/J5aXgbdtHk614WN3VFtHv0JuVT7bIh33c7HxJOEP2j2RUj63qQwcjB2geN6ORaHn62gQRGf0qvv5iOeqARTETLAby4O7xNTk1HnDQaSILcCVZig4at4+OSJEQrr03EmZxl97S3HeZybUPWAchw6urMvisa/unwjX499ZIEsci8wiC6HoqzFUa5ndHx+RCKAFwG+7FRdUZe5nneNGLFcaA48ZWS1FoUllNKe52qMiN/G//IF2n9FB1FpXP2a++FikXNjYeIGZsogNwpYBlBKsfuZoQCycNK8hG2eBEg15aaDEWICd4jie80GK9TKj+5h9a4Y3EYjorCbQSpFl3m5j8PfTmvpTYuPX9DnRd0js9XcCYTMhHfpwjQhIUXkzqYuOAt+bT3qAIbQ15crQ+drMnJWFdsSYphx93s1XdoGKHFqEAT0G7yQWsT8uidjJR73V3hWq5TtLWDQm9txf4hUIJOA7QNYmdtnyXBjhaeUzN79ETIl21SUCwMBuqtrbaLUCEAWvwqzQKdrJ9q/S0W5z0wY87cOZyHcFV/5SHz867WIezK5rcexlIKIcREJAI1g1V0eita3mZUYdgRMrQ+nGIRFuaGuF9dS6P0W+gTgLpcn/YXVV4OCaW/5oxULGN0p94W5mg= X-Microsoft-Antispam-Message-Info: ZdoNaNDVYTd+SMUcI7G97IVa6VHoDrL/fwAp7l3EFtHG/l3/lOFrF9KoLJB1iZoiezKgFUYyqgWYqSnXotxOTAQ+Vm/We/08v2+pdowqtTinmWEUo5qSp4iRVyJnPPMr78MeBbBx3gIDzG+N+mX4gZnNdpPuzmGiTdbeTD9E9leAh6k+XRXU9KZCX/vbGN3gi6jjGgjKasepU5qZTUBX9IAegBkmdAvNi1sY58tPgY9lcEUbBh45wJZ6NVZyBR9wOzaFhUktLlaENYRVWnz5E5AgeSx8K7wCsAR3EoqRkhitXJWtQFNYBISdmT3mk0nltpL9QASPQrCYUMQdZRm44u/X8MuShIZeOApd0aLRJWI= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;6:UgidXKD7a/sozSZZCNIVidXlM1jCf3TkohJq+ZSLySEgdxVwYXHtLfix9l04Tnlrb14FnZA2zLChA1WFdZttzzUgGwI2JUBeMnLkFUKdJJQWvoZEYY5eRMhvIPQM88sF0t7y36loBUIptKJtwCQcyE3+tcXKqGtNQywlPi+r4ntQy0jm3/Z3QtPJEvv39Gu0KLfUcmtBZaA5uf/HbZYy3sqjYSvnJMMuSE9kdK2pnXWp0/wmZui/UT9w495ja2SRtJa1RXyIDDiFpQD8U/7QTLKrdsfbF2ZNghCoBCN0LsPT71dbfCwv9oYniiDVFtfV5uQdNeSuNjZIUZkbJncw4qDFSE5P3OTLnr1zo+/VuXbgXSGQW2iEBV8Lefq7FpqZaohDEoHFpI7cUcOsOQ6XNc+h2oNM0JusvVFfhrg0Xc4xSNmOZZJEW5Z+Ewx+ymLtzPWA4msNgm8VvcvestsrRA==;5:RsErnf8l+TB98TMwKOq3t1MSCsncTXczBRkn1SJqkdIBlBQLPk95BLwtg7V/J8ARgL+FXtUutJu9kgCy4+fEY0cRBaeN1y9V7UKxCXq+iQWHtDAdumY+O69G1vZYxbSNyIG8z5fQf3jw7PO/ONOrpn9bj1w21KwPiDQxUK0cYjw=;7:4FFFS6WTBN+S7NBboXYZsfZXXE6W16t9MnOV7UTsr2kufqsRV13bRlj26DRBgf6PF9Poeh2AMpWYAXN0PK4Z+g6QuqAjhKZmjbBR5Hmf2KF0i9K/1xKKYYigdiaCwa6GDyWrVfvQuCcFQ7rPLLjJc7Lt2xWBHv+qSAOWcyRrt5BTg0a24IBD6fGx0vzXSPAkD7pYIp/gxDIZzgLNEzDKTVjtqAxGBAF65/SJsE5qPOt6oAGzbWNNyem3lWpLxcND SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:27.6664 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fcd5840e-af78-4e89-9b0e-08d5f3136c5f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There are a lot of drivers that subclass drm_plane_state, all of them duplicate the code that links toghether the plane with plane_state. On top of that, drivers that enable core properties also have to duplicate the code for initializing the properties to their default values, which in all cases are the same as the defaults from core. Change since v1: - Make it consistent with the other helpers and require that both plane and state not be NULL, suggested by Boris Brezillon and Philipp Zabel. Signed-off-by: Alexandru Gheorghe Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/drm_atomic_helper.c | 31 ++++++++++++++++++++--------- include/drm/drm_atomic_helper.h | 2 ++ 2 files changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 866a2cc72ef6..7f5aafc5b1a0 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -3552,6 +3552,26 @@ void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc, } EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state); +/** + * __drm_atomic_helper_plane_reset - resets planes state to default values + * @plane: plane object, must not be NULL + * @state: atomic plane state, must not be NULL + * + * Initializes plane state to default. This is useful for drivers that subclass + * the plane state. + */ +void __drm_atomic_helper_plane_reset(struct drm_plane *plane, + struct drm_plane_state *state) +{ + state->plane = plane; + state->rotation = DRM_MODE_ROTATE_0; + /* Reset the alpha value to fully opaque if it matters */ + if (plane->alpha_property) + state->alpha = plane->alpha_property->values[1]; + plane->state = state; +} +EXPORT_SYMBOL(__drm_atomic_helper_plane_reset); + /** * drm_atomic_helper_plane_reset - default &drm_plane_funcs.reset hook for planes * @plane: drm plane @@ -3566,15 +3586,8 @@ void drm_atomic_helper_plane_reset(struct drm_plane *plane) kfree(plane->state); plane->state = kzalloc(sizeof(*plane->state), GFP_KERNEL); - - if (plane->state) { - plane->state->plane = plane; - plane->state->rotation = DRM_MODE_ROTATE_0; - - /* Reset the alpha value to fully opaque if it matters */ - if (plane->alpha_property) - plane->state->alpha = plane->alpha_property->values[1]; - } + if (plane->state) + __drm_atomic_helper_plane_reset(plane, plane->state); } EXPORT_SYMBOL(drm_atomic_helper_plane_reset); diff --git a/include/drm/drm_atomic_helper.h b/include/drm/drm_atomic_helper.h index 99e2a5297c69..f4c7ed876c97 100644 --- a/include/drm/drm_atomic_helper.h +++ b/include/drm/drm_atomic_helper.h @@ -156,6 +156,8 @@ void __drm_atomic_helper_crtc_destroy_state(struct drm_crtc_state *state); void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc, struct drm_crtc_state *state); +void __drm_atomic_helper_plane_reset(struct drm_plane *plane, + struct drm_plane_state *state); void drm_atomic_helper_plane_reset(struct drm_plane *plane); void __drm_atomic_helper_plane_duplicate_state(struct drm_plane *plane, struct drm_plane_state *state); From patchwork Thu Jul 26 16:17:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546117 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0D6F139A for ; Thu, 26 Jul 2018 16:18:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9F2B3296A3 for ; Thu, 26 Jul 2018 16:18:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 923E72B898; Thu, 26 Jul 2018 16:18:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AC9882B891 for ; Thu, 26 Jul 2018 16:18:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731007AbeGZRgK (ORCPT ); Thu, 26 Jul 2018 13:36:10 -0400 Received: from mail-eopbgr10052.outbound.protection.outlook.com ([40.107.1.52]:34018 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731803AbeGZRgK (ORCPT ); Thu, 26 Jul 2018 13:36:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DlpQOLnwONaKzLpnF0WxrsliRRlfdmWDpIzV6xFwsRY=; b=f0PM3RC9C02L8qaOdvC0D1T9wthR2AofeHUnmsuR1mpc4tcyiSB42VQ5JZSGSRTnd2doZG+PyAjSeQ1tdAPzjLtT5cleEoBdCaXWu0clqet4+Mm2+kneFdaLIs0U0TvrF+1ahPnMLkwrWuYaIx72H0xes9Vpb9YipDx1zc7aGpw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:30 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v2 02/10] drm/amd/display: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Thu, 26 Jul 2018 17:17:48 +0100 Message-Id: <20180726161756.1794-3-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d95161e-e8b5-4310-2a4f-08d5f3136e11 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;3:tyGP+jSk2YWRnjKdgy90Sun1lv2dD6QYRlnuiDndxrpBdDDtzOIVzx+3f3FRKq/XkWQqQK9WvOME4cGQ0uG98d2SLdnvVjiwSlAduP8JC+zrDY83gGenHWX4HgEAi+cYAjeVZc6HhmRG5zRp/DCG1OIfxyBuiy6I101ZLskGV7WtJ5o6C8ZSMbW4UuBwIbPDm4Fj145TJeJgwON3RFJm06zaa133A+cEGnhjX/olwKfDfePuwy0j/2STvwPuPclu;25:qFXBl9xMBlINAgh3voyCmeOQv2LXZI6xUU6Dke1yv2lZaI2h54KzMch0hD10BCI4MHet47T2YWlZlIawHKoziEenCd2y8I5ycuQWgJB6p22VOy7V3IjpdotBWwYlC5l6ngZ9rkKrfqO2kGwQubQn7hnLOwpw0VOEiKGtpUcco3HW8Q3hbm0C4w4nVqykcJzRcR5VBMf0o8ld/Q4aOfW9e4CE0Rtqm6bXqeiu3g460MKWmI6wfBmyCHIPRta4bumUoGYvkS/99quboQ+lmfkbeR9Jr16tSSzgcJ1O5oP273BnscKgIWWLZYH2WrN/1zBc8hdLBt7T6Hc+bThLXxFVaw==;31:yk0tpWjQ/nHTmoKPbLW4oAKf/BDj786ar9TRfhYMifwlUQRBTKY8vwogidruXY10bET4GBLEkAf5l4EXtJh83B+9VYxg9tGAAttFuZUuWJjYjp7O5geUuq9nWg1mcAEY/GyUpXEJoMVVdjpzOK4Q6fUf+dN/ovDFXGTmCbeJ60duxp5ZdxFpcNNpRzhjETL9jFwonaMCtRqM5BJruN7ZV1ZtZNbsZrbW1Wttq6Y6inw= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;20:vL5xk22Z1lSZp0ChA1i5kFrnaZBCpKZXzcRpbiIk/QoNVteDVYOjbxPPWDMbsMsHxsfWHnoKSdLW3PRv9hItHCfmhAZwY+RdYiCBbv1DPGPLhD+DUqYiJBwlOk27NfLAFzHU2Duh9u3FXNSwQsJrqglArxaqEmOQQwzNcdRqECnovpc61iCISlCwiI04rK+2Ni7aaFskfOMaFLIRRZr/XdIx7LjqXAr+/uhDVUdQ/mWz60xjNnLhwdAb1BOjC06/ve+Dd4Y06By/7re8dGsVx0H2ECnmp17yK8WsbV25bYlwGI6cyAcquvopXHmJPMuQvQpaKpiB5YCSohkkhu/Jcg==;4:lkPNk7BwL5HNRTu/a9gZa+tC/IfLLqMvBz0LrxBychqhUkmjgzzENnc5vIG0IyiXsk4JH/eUSSBezAfF2FVg34nf3ieTvBY20Se+G3A7K1LUaZg7Z/oD3fR1w3FAlVTdVb6lyKidQcykAjwae9VYrWs3BJ5Spr1Mh9fAO91zrPsp50fTplGriRRaOuSbYyBD+rgh/+Ne1Iya80x4Up42kobu58l5yZOuvNKhtb+R6QEIGmRJr5aoSJd1w1qkeniEcXIPuUXdpRjSx0m/7iH62tciDnVhmZ+0cRz/6YB5UCeR3eEVKNPtUcFTWNga37lbYfxRfLHdBdCf6QsD94f8V+x+7wMqwgrRIRj8lN2v1E4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(6666003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2552;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;23:7JavtrL5jHtLbDqPhRiC5po7sB9CmmGa1EvAzl/YbedUKhMHi7IOM6ohBP7RkvIxsTn9E6W9lg2htc+GSM22abp4DLs9tgnLt/GcqWyGfUzkG8b3mrMxM6hcnMzSoSUjwqiaYV4M2ce4EdQ2/LvY7rLmuc3K9yuhw/zl3RwcMaqUXbK9V42VgCHiUAlsoeQG5uLVBDicPEyfnTmrbpzinRtFQt8XN8dVYuk11nobVwYGgMiOPyxq1+9cxYVuLqkYMIe7rswpH6S3/TVquMFDRBxfRqxPwXK2R6dvmUZY+N+d9Pn5Odm1lGzblDmnDzqBfh4hHDfpI9gyxLFfPv5VnJ8V6fNzCC7eEXUV9d6qQn/ExQFHD/VsJr/K491bjSYSWp+62MfZyglHGDEg3agEQKA8MQQPJpGgJoVW+QbyO8ipS+PsacGvrMKXTYPrMOAJ2ll4TUpiYfxnZ3RpU+8Ng5n6dVrlN21Qma0QSxtXEw0bhTQn+b+s5K9PFPCrIneWmpUiY1nrtyaYu2wpQQoZ+VG8iJUdiCY2gIhcvqnwdnl70JBKdBufXeAMgEIjnONhojpRQ7B26lghjDlokJHzhp4u805HqTjrVFvyRDHc1jCQYztGx9Rf3So4IuwdjJvyQdp015CCgwysfbSKq2Np5fRNz+4234If0e5YO3OuXYCE4goBTuFsWt9U0aUEgQkOeeXwUOYyyceC6J5UF5J7Gch4IjGuV0P6MrReVM61CZHtIY+WHP3S8d1NlggbjLE9Z7mFlB+6F679AY3yRWoUYWnl1xmwe4h0iOljQLNCdLcmS1esH0OjFXGZF7fa7GMW2mLEufhiyZXIlI3xyWYvnEY8T6l/t3GE4Esikw+WhA5CSvl0LGAVN8VA8mN5TruXLLpvvu57TytAsQx3jz6ehJZr6h7FbCPc3qnnJB1aGhas9XAeFeLrCtDAVGd9tfNxtLZ+D1ZNz9Dy1tdlwQNLkHCNc2PHzEQ70y5Kfbj6ux9NhhJUhS9dPDAWy3F565op+631Zjl8knXv/HZLAW9CY81j8BhBk/K0aq89RD1ZwWGDF/j8B0kO5suk4BD01GI7Q/H+BPjHPd2XBMMqO7xTaoQczJDMhTqRDjcdurqF08PWYsOX3H/lnTtvoVJrxzvxjnz1KX/tiSrdI0YtZbaE2Qn6wlg+dN56SYsfZw3vJdLJuCCQgyajldrEteKz4UYLWNj5meAbudwO2tLapVfQFza++hSNkf+Te01ajsiAXCQ= X-Microsoft-Antispam-Message-Info: MQYXaDIoaC4FelvvtG5dJ2Ljgf7OVe7/vJWn/K0aLX7QmX1nMb7hINOCGNxNth2VNBPFP/yqs861+X5TpmMXPUjOKYtH+FkAACNL2cuI3mfghPuc0QA+K+GuSxd/bU+1k9Xm/Wdk1WJxdIP9MDxeirrtJ+29+KsNr7GQMRo8MpvZet0xRNUhv91XMRu6JrezXZxUAZ8vl9NSk7bXuO8QPABRopTGAWKQ/35qcnVOKUbg8lPynj53EJssEwyi+5RYZdqWFKFt6i+q2pRq2YDCwCOVTuVVa9CbelKJIedomlSsnEju7mBgbLYImYQ3J2Kawykvyjuc24FYnuZEamTa7GBRWWpldK/8TiIB3OF3sUA= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;6:hekpwW7eBxEZ/Hur/9oGJNznjW5fnNTJEsR6VOirRRBV+LH5mxsziT3vKe5kK+Rnf5FySf0QzB2/kqTFEdZ7iSi1uipqIe75nVuhj0lfeDpd+UqAp3dE9WXEhV+W1tSEsXwooxcNfQaxhSKZXBid9Gh44n6oOR7mDPDYrbgyg/W87nZ4e/XJC/ca3qbb0yqtAaWczRjO3YgSsPN6BacU8NmDqIc0mSlxSEjPX06K9HoD5fQrK9tK0Olgn4HAMiX/o+0pcpCdXvZATeS4B89F86i1mDVsMiAj4zWooFUu62BCnefwBpN3fuErSS/+bm8qP3UX6nJZFwy9oedk1ydLB6EPmLohhiNIgKu2OIdMlH0b0NLEuc6IGPg6+9f2TsTMC+09fZM8whZ0pPz01UnY+PXNeubI/FU1n/dhDsDNyjvfdn/MZXZ1KY+nOMNfWZ9p4XGxAbeojA4ZeazAGPvCMA==;5:HW5MI6J7Hs54UO3suyxld8M2cHw3yeQ5SDrVf4PlJ/l81JWllQ2gNl9OrsRxhmzmkzUHtJ3oKtkqbSMtLd0qOcAvbKL0nWU+ISDVKSGB48AZ/MAaoaLVe6oeWQJGPcMFkcitWaG2grCzLUQlMsaMAeQ/7YWB/a+PDPCbekVbKwI=;7:hXv2ATpzoFxVfnGgfhZrKmV0N7cRQIaGCC7bg/ucESbMV6p9QAltxfQF6RuPTpnasAZDsbQRKgRK5qTYv/vKvjgJLf5szCoadR8ByNVxpgWiDpNJXaDhNB5v8hEbBRwPkCdH1eWESh+IoPXHHc9kD5j8fO/AqlKkWyDlDpzdoO0rAJ9QSpruOCx743ipVturObPX0pceoF/t82qryI6jN3n7utGZM0XW8dAMuD8JrSv8MNn/RTEV0NA7d65GL87X SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:30.5148 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4d95161e-e8b5-4310-2a4f-08d5f3136e11 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc) to their default values. Use that instead of duplicating the logic. Reviewed-by: Harry Wentland Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index ae09331eed00..8e4978d5b83f 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -2965,11 +2965,8 @@ static void dm_drm_plane_reset(struct drm_plane *plane) amdgpu_state = kzalloc(sizeof(*amdgpu_state), GFP_KERNEL); WARN_ON(amdgpu_state == NULL); - if (amdgpu_state) { - plane->state = &amdgpu_state->base; - plane->state->plane = plane; - plane->state->rotation = DRM_MODE_ROTATE_0; - } + if (amdgpu_state) + __drm_atomic_helper_plane_reset(plane, &amdgpu_state->base); } static struct drm_plane_state * From patchwork Thu Jul 26 16:17:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546121 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6FA3C112E for ; Thu, 26 Jul 2018 16:18:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5F44F2A514 for ; Thu, 26 Jul 2018 16:18:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 521112B898; Thu, 26 Jul 2018 16:18:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DFA822A514 for ; Thu, 26 Jul 2018 16:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731803AbeGZRgO (ORCPT ); Thu, 26 Jul 2018 13:36:14 -0400 Received: from mail-eopbgr10052.outbound.protection.outlook.com ([40.107.1.52]:34018 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731600AbeGZRgO (ORCPT ); Thu, 26 Jul 2018 13:36:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sGPAb3GohodAk8ybrbheLMKhexV9LGF4tVcCwI9+U0g=; b=LGsP9Gq5OYZJ9M4LSG5iOZKKquuC05xE6Nezd5CPehduUwY7IBbLPRNTB4wyXhBaF9FA+nGH7PXWyD0qqI9kSkDLr6i+eNAOk179WK2EXtqcwyRLnm0PhG0cwfYRbEIbYlNGh2/u1pdG11ZffJDnypTWMgSpCcpIpSBxOZPOc1c= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:33 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v2 03/10] drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Thu, 26 Jul 2018 17:17:49 +0100 Message-Id: <20180726161756.1794-4-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 22e419bb-84e7-404d-625c-08d5f3136fb2 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;3:sPmw9PAVGNBsg09ZGe486aA0GsPaiHNf9sGrxu4unPY9dcvDeyJq9EiALR1BjD9azdQ/Dsmj3rE8S+g8iiqe9wbMjmoOxqfLb1pHldiB3J/pRoEFDjtoLDxKkzdS5hjbe96i+7QJOmfpu3UkfsVU+PPhl4PAR7T3yiRQEXwRgbR77axF2OOx9n9VSRrSsMi2arpO/uXGgOgYUDMHh130FlcwociCvHhzSKTRhKu0Rx0nInlrxS5AFwZy0FzPWbM9;25:YmzCIPXWPMf2pDREMk18Dsw66RsecjOIGPS+9SQySj4ZNDL/KnXWKnm+Qc7bAJzvbCM42coWkJztfYp77rXoEXJr/4uFnzCkBIVzG6mebuqSlKeoAhf0rD9SZPCYJGAtVv22DvbWsss5C5zIxa4fQL2Ecj1jOThfFdhbkVoliZp5BeOg+ZF/4fKWUvKULSpbbJzjVzRvmvvrUzRh7zfJEz//AndQG+DCLXeogUErcLoa18jmnFwNa2uMHQGialfCLB63Z7RP4egj+mnzcWeuYGCK7eA8TkCrIWZjckfVOwmt9bVJsJ2Yn8EGj6AAW2g6I1+Lr8/ys5K14ocd8HDgZA==;31:N3hpIK35cmvqj8X33KoGlR2GCcLp1DZG7C4dd99fqblDR5g3IzxgqrmbZ9L7V9rkk3qV+5MCs9hHUr3Y8y6IYJyQacCvU96jcePyaH8MXS1W4IPdZl2T4HVOssCyM3zz+jgYnHaKXGSov5SEHKu796FArL+3rAKVh1WKSSrjpe52/vPgXGjLGDRW5B8/254gNvwX1JiPTsMfQHtEXgIUwJcm+1kenJexK1ccO0KIsiQ= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;20:RInirCzzPFJuztZAWd2neWNEt9zBr1qDX0VFU2Jp8GogQWH2KKVcVHUfHz5uXha7wYKOU0S9RE6Q7SybzRv/osXNqi5174Ulr/cuT7wprtv+MjDOWMlNk4n8x69oS/h0p0sc/XqVXOoS3awfdUIlX8Lv9AFzmL8FV8PvQCb2FNuLDEF3PE/kgybnwsh+E+1UDgjtHZ6azm1HQu8POrPAEiP4L6V/0oAczyU/nkobYiyn468gKCRGmme2WNIDCa5fX5TZ30aLTkSOKV6yNJDPyObEmRe7zTD1frBcgn8apCQd5I4eUhUM+CHU7XlJU/226CiRc+170TIa8B0ajBVRsg==;4:I4K/e+I9drcHSej1ay4PIY6/0UeVhNxWk0WKUTaNrfwFcHMtYUYbBKvFmdCC/TcJWiUtnArwBEORCshjN7vY9gt1ex3V+WAomrN8/0iny3gGrBajwKQuJK8E4dOHCUZX7SbZKc4qD+9IR0f/Au9gHPn0Dn29qCfaTerXq1EMRY1mI/Aa1L0r+oTh34QxJu5b0mO6rTIhMSvEH6aaKcu1VLFKwhMehzJTLmL7LMbM5x/J8D2NPDm0MLtQBcS18SSblaVAaSYsjT4EfqxrF44uJJWKI04IQObeRelIcPHXDs6EeeKyRTiF8cGis9SOLTIc X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(6666003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2552;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;23:HfkrphFBOPsgZGxoHVsrbjBVq9xzcjwViECAncKvtTsG/6pBiwYqk2AQ7HCITCASPnSP8ehYMcX8IMCPHYTJnwMk0a/QkutXlaFzTRy3esf8tmnHST5n+QUCAOqoRJXm9fQv4JcJjNJD2V0Tjoq76AtMVCv+3S7Y0tE919133vlgIy3a49BO8tpqYBToRP42fP5JdLKT2lIESwldrb5vELbJ8WGoOgCSbXsTcpJyo8T0G7gk+suYJEe6Ef9a2RBDndRmiPqEs7r5wHcU8+bAPrVy1bSxiJDWziqkDutCO4uBnSEllbuM4bi4ZrfgGw2AUXjSeLXKv55ow8Ok9YKZZp6ZlrDk4ZjmxJ6HOL6rnAYE+WiNacoAz+G1vxtfxrPaQrp6EG6WZiqv+Ie6ZlRnkDR3Z84H0XrYS7d0v2tN3CAuDJWex9WwMAKwI4dTkpHS0GnnXCqFPyOKYo5nZkByAgCPYK1qeXkLpAVYWTziQ1fIXhHwrCcJwTlthQEfCHoJ3LQI9uxpuQE/8kPBRIvdgGB4pGjkstVApY/fufeDQqFwenpTEZQKurZY7Yq8lkTgOGZjCDU/XMc2Iwm/wFxAQNlSAok5p3hoveC93DV6oDAZpX5GmjW7dha1KRmLbV1Nk+jI7BY2BrQGwojVeI8+yQX4t1aHfwZilmM5/iYYYozqvmhRr6LfCvnoxZTz2Lli2lEjNaJ4T76TPVpy3lWSruynasdJysirK3OnxYgCcqzliN3AjYQ2h0b4frGGno0VHhylZOL9aWbC0d4PHo5APzv06/J+gCWgdMAwvGJF2+Eny4f/MCOOIMbC83+jJpUvCUAD8OO4xnE3WZGEN6mvlORDzyU4VV4xfpxJj7y7w2pNbA7+vP8HhJEcfoMWxyZEvGbNIgVSJdoiBrxIjpJ1/yrO/d51zDcWUyXcLgUOIW1MeSXA+t5fySHn5DogW7cizwqXejy70we+xibCJejzah1QJ8E3jEUpVZ7ytkd66sWTxg7XwDJW5xBha3Aev23rFn5AsVbA5keRlX8fstYczHoyzb6D0VrvycGgu2gPWh9J3ZAdJe4TNlpy59MM0e4rEHZbY8Y6iY+rsTmP6bqaAe0ohO1FTn0SwF4xHG6+z6x3PivtcolEJBCbK0XGOT1ECe2z5wIeyDCm42JQYxj4C2p5BbeRzEaIw0oxvfVFs8BMF856HiNer3RSR1MAaXxs5Hf8Cr7QF0pgyJfKy/B2LhaZ9bm/oO+ShG+yx40UP8M= X-Microsoft-Antispam-Message-Info: DXv6vtnPo6g2aQxBqGX8orv8g7djdmfGB/QNy8vMmnaSF8Gfgv4g1THenv7oNN+4rWXyql2ylUxg77GxDrS90nzsjeOcMnG8Coom2am3T7Cg43oMcUBpINn18D4uby5tY1DckTFcLLZeOCa0IJ/9NEmRRI+a+AXZYPE/YK6vzQ882DxDT5Pif7bh5ZoVF/QKRMmGsPHKtZ7TomJIKQwAIy0aisd9gYBDGHXeCo93PM5jQORq7kT5G73be0F5J1tUBnBvN2q139EFq/SJs/Q1wKbXoRenNJLmuly2/24+7fHRr6xYKJJV/aZpr57iLnwY7uwJBW+npyE5ckZLEl3mN5/r7xhUjeqzKdW2ei+Vmbw= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;6:hMdPDAUmmRdLmGev6mqlM5TtLo2/hwrusaFdUGRCNkmI6egfiBG3pvd/gVD5dBiCqEpALyzYuFMPIBj5M7msshsMtqZuYRSyNkmJFY0uhR8TOe1G2inkgvMIhriqTVw8vlSW8OLfp0lBkPddTbOZwryh4J5kAcyn62a48ZNrrMKl106g/YVyP6xNVgf5G9cSsUn/mL7NGmFYwHBZVtCtB+3j6uX02edJdP2jV427Hcspfe1vDaokop38nCh18zSV50CbahubSoiVnGrC/h8IIYpOcbO9bRDSxkY86O4BKylY4HYowKBD/UpHNSq8wps4W538Ayh4cFKDmH1oBgi73mBcA01IjT0KYs0VOrCCsUMB4XP7tGPEcymSIf97CfBDv29ciF9A7Wjrk/FlG4973S/e/sOTCXOYo+hfBKWH08UQIR6f0mvOD4ztcdQ35nTuOXSx0l4nR21QDx+Fn2jq1w==;5:Dcm8NXn5KRI7ltNWx3FmstYvE3rJrpfeLYGFLeQtOMwN/nKPV2g9f5yYBTno1GTPPw4qntnxlomogrs2QzAyjYX6EMWOqts2afYo+OmQd/bW5IA+ywKxsVuANlFcNTVMf23WSMffWRk0gm7WwwHbvBfH9n7DkkVbP1Z8visJQRs=;7:BeR2FDceklKXEojYqUcMCXv5yZdbmTJUTM4ng19gEglL7sj07HcMp0owl+9WFYlQLWthYeQxPEnkuSWy3VOTi/O5oj7CpMRnt6rX17IRBlqDvut9NyoNULUhE+c+H6Caj4OP4pWRfVg1XerxyZ9tDV0DnRwkUBTQ5y/YpdpmW8JkGvlL+UmwOLfkroJYd/sG/WyO8sOAM7a249W7/U5ZLAU1UchOtNhF3N47JEAzO7PptKa3FenXzP5t+V/u99SL SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:33.2491 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22e419bb-84e7-404d-625c-08d5f3136fb2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. Reviewed-by: Ayan Kumar halder Acked-by: Liviu Dudau Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/arm/malidp_planes.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c index 29409a65d864..49c37f6dd63e 100644 --- a/drivers/gpu/drm/arm/malidp_planes.c +++ b/drivers/gpu/drm/arm/malidp_planes.c @@ -78,11 +78,8 @@ static void malidp_plane_reset(struct drm_plane *plane) kfree(state); plane->state = NULL; state = kzalloc(sizeof(*state), GFP_KERNEL); - if (state) { - state->base.plane = plane; - state->base.rotation = DRM_MODE_ROTATE_0; - plane->state = &state->base; - } + if (state) + __drm_atomic_helper_plane_reset(plane, &state->base); } static struct From patchwork Thu Jul 26 16:17:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546129 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 42252112E for ; Thu, 26 Jul 2018 16:18:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3010D2A514 for ; Thu, 26 Jul 2018 16:18:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2117A2B88E; Thu, 26 Jul 2018 16:18:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A62702A514 for ; Thu, 26 Jul 2018 16:18:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731819AbeGZRgS (ORCPT ); Thu, 26 Jul 2018 13:36:18 -0400 Received: from mail-eopbgr10052.outbound.protection.outlook.com ([40.107.1.52]:34018 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731600AbeGZRgS (ORCPT ); Thu, 26 Jul 2018 13:36:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZXEf8Msz5N6VKyG0qIrHK5r4oSmfWmCrnulObrD9mNs=; b=fUSy/LgDbkkByyeykOGXB0WlMNsRbI3MqkRTFNEFYhfyCL9civ7EOxGhBmDFYCJWNa/+j5s0hzSSi03F+rudXGF6m9Np+BzjE/CP1tBEwcrFgMv4emlPIAnixfVtoSufDCNzhj2cZ1Mo3cQy0sQwPPyZw00JqWwEPLIRBU5mWmc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:36 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v2 04/10] drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Thu, 26 Jul 2018 17:17:50 +0100 Message-Id: <20180726161756.1794-5-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c687c91-9ce7-4607-bd92-08d5f31371bd X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;3:dDX4zgCDe3JUr34M0YSXOoNQYaimOiPwj4Oe649BFDVDJJvdhowGinFZbg2AsEJf14hYoMmbUqXiQT0jpBUfVbma9i+H4L1ghrtvycmx9e/q6mNxIdfRa1w3mbkMq+JN6tvTgOUbWjtG7DJtyo0f5sBv98FF2nycqE6SHY6sX7LbdcpPeG+OvHIBPEmSAVsopDf56Wu17CFMEz2dadpPVngGebaj2MokJWLTpbUyqxMnqgfCIIwagmjzV1KNl2qi;25:djNzK9GWrlyqr8ZZSMhK7mUWDmzk98fd1jgog+c6HI/oqeNbGRaFDrZFD6dNqxOTeuWlAB36Xwo+Eod7BSwqi8YT5FjyrJSRDmucPPyC+8LqScGg5vRfC5eixQtIgvrnuZSiQgM+e0OSTurecH/GZZQGBh7jaLEX4fpcML2P5D28d0S8FOJNrI12usLdVPA7xLbSUt7BPXLalkLgk3T+zY1ImV/5KtWpJ1yoGEZOK5JOJzbquiXL/9YxYvCUDOdE/K4pcyfJMMi8J8p+23HvFUtjc5Tyv+Lfjr2dowEYopbZAD2G1E4q4A0mPpN0U10CohoXl2SlNcpuqxZ6DVcHKg==;31:kQJH6Xrs3zGZAGFjGniSIQV+sglxr8WzSpFkWUuV70ZQgGGXKuCDsCjKRfVpxz8S+DC5ckvR8J8+jtGICYU2Kjf7iuV7kIBRZ5PNZnkCKr6/DBkBtdNpAJ0CH/EKuxXQqhy1vqEe31IzBKB8q/iGz9td9P8HBh0R6mIbicuMP6AVigPqMjpBICFuxnYRTuKZRsbh30KD6FKNPjcgWNKWxNdzmK08kie7P2C/x1z+DtE= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;20:f7iamJImEXk50aqhJzVls8YbKYerCgo4PIuw/6cNqDHYq8HHzZkvLjACfM8VzxfuZ5wkboHSwDEbfWmcuzW28WJ/t2rWV2BPY0ZvDZuqQNPYbOLtaX+yjr8/2bsWIf+LyHx7bf5VVEWv+rK0qup/4n5+D4k+XaHst3uS7S44K1o9F/HVf4Rfcx2TdyJD9Vj8sm1H6oAoj+Givk9dJH+jAkzG3zY6ceQR8YkZWiWD911nTfzzr+Wl1Uum5hNHiWd3a+KlAHgLNPPC0StBJGsUeqf8qAYsX94hN4Fln9t4xLNEgG3r+9Y2gczuvtkudWu6brA3bqdhBhyLvEjeTn/Vlg==;4:XdD2Az6gxfBdc9OeKRyrUaDSO8WLR+drvEsme4PULTfwbLtGq216ZtfoKFjEz/P7kBQMs+hhxgdEXV7Tli16mNHoWRU/1qM5bHKgg43yde4b08ArOU8wIMYE83iZo8J5wBZIIHKG2YtV/sySKx88DFXz9yb45lnjy2e8/E1HFBifriV3wBxgAfx8QVGvhUAibfS7xntMPXGpArqMTvqSyvPg63HoiiJI9rByEP1TPtAmik3zawdn3F1u5mVmyp064TW8RBIb61OqfaYWOntp4/u9vXADYnkKW4P2GTVzuCHCiZ6k/hXX8bkTWh6jVJ45 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(6666003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2552;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;23:frtj9uP8r2lE+BvkNQex/Nb4sxuHlE8mqaGKbA6CLau5Qp6xEcI6nvKUD0JXenwCTzbGtH8H23Ww96HvWMf4Jvlmj21Q2j8ya7VmSkBic9wbL0n7xvtWd10UOa01X9AeqRSutdTECiq8k2Vx/msclmImxWAeuhKi20RAL3X2jym6L7WYQD3M/LCYFkZwfnMT02GQbHK3d4x9yIoQCVylDDbM+AYpJYa1L+uZ3ZBbeFROq1ivzdbwjvc1JMFQ43B84P6RxEiv9n4Pww7SGVt+joZVy7lPryGETktLJ+BNVDFSbqsWs0vE+uDHm5IvAkKOZJpfxE5muXVzIlBQ9re8maIqwQK1xIZsi8FMI41CU5dmpDgb1wuNYCq85Xjt8+mZpRkOVRfBfAt4C2WqKhn30X53QMhMWKkFyY3xsA/Hn2Yig/0zjJczT04PcjYwD2pUkwA/QBaI0QjbIlMVP3fNdZBa3xfCbYJ3D4cQp0kW52PyQZK5GFkyrWJBayh0GvpDBHc6I+Xy0/MJOsY7YrcHMCmmGwgF89gONJhIaCSyBNklNcynbawqLqMp6wbveZjwhMP6RRZkDdMzuGNoFxub01tGRgzJum7xRHWVyZSW1jsT5/MIryy6Lw/Ok1TZMswST3MzS6dLF1IBEPdSmpBPHx1o9mBzYftmtmg/CPpB1PmcDl2tuOHZkNZWrw5x7oYALX0H7YkdXNRwDf72tFZAhW7boT3fbSpVRGSQuENf72EMZ0Ba0mUmK2XKJIbZvma69tPjEhZ2IAJb+0kT7vfhYUPPb7xRywApwhSzSNfKFxEXUyY3O+UXO/y5hfxLrOxDgfn+EFsxX06c8XWxJHSKD3dEFmT+qbAm1MQDzITeyZSHyxTDnNeur8vHAAydcHuExaBV4bdYOvx5r+WFf6WqNLzIRnhdSNXzM0omzcmjR3mmapTROZ+HybHux9oB6z1b8y7pn2kP7QEFgLt3lDP8g/m3fEMB843C6bzlwk7Bqi5T44MNMDZRgz6s73Uv1GXdB0H2OXqv4BGD/0kdd1AShK/lu9SJ8GwbIuPqdZjWiAT0Dmwd3KijQFfmM22GvBTClBbvcOUoLbsqktEWLC2Pf3DoGf2lRqFQ3lTzKLt0yy9WZ4MFZdViCRyirH6170dhVtGd7rKoJ2olQh37EVT0AnkH3mQ4o10x9LukEP9danyFJOMIhZEvgHs4ccGmZ9/eq6rb+F1yzT0RvXoUqOmtI2qHN3RT3x6sCfHWYmw6JZo= X-Microsoft-Antispam-Message-Info: uiepA60wzstOILoVe0ovCZhOPDwM43elhjKSbTbTfdWXkALqOrsXKfPOYqE3Kasx4mqz6+Dm6d1o8JKQqP7vyOSbnfpYrIIjluM8piAPfHr8pJk0jq5kG4h/NSxItaZRCM+e35KmD21Q16FqEFvxps4Jfznr94NvCpLQI3auAp2kq2qJlunYuwA6HdnMw9wsLPPaB2cMgwoZkcupLr0HRganwR8kc/l9zdX4u49+3ngeva9Z9waMwOg9SX0RdaCxjeQqVYlKk9a69fVQ2O1RNYY3nQ9bh2/a8B+z4RLTArpeSXFWd4c/Nsb37mHtk1PMppqNmncA/1Scsgr9+zvw9kEYoz0/gRls7zJyl/iEEEI= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;6:r1xdRY2rwCACXXw6fbaDxX1M7BWq0gC1CmplpxG7Wg15FtZeHrhmquK5GpcsScugmMYr8sK2Ny+i4WfPAd/f6gz2VvPVeVbSCh8dV3ff9yH0K1hV5cYWxKdwv9jJP3f/+fwW7/c9LXn0k7dw/hi6Y5wj1BerHzzyXkORgNjNIFfJdYl9dzklEOrwuGrkWlh9kC9JFToa8+RHtm2RpHhnfbv6Fmu1QQeV3bqW96URco8itG/NDEwaSSromtZqWMW63agvEkuSTfcN7nls7OtnBcIGbj3t2Fxj7Z/+AHrTARYRY2uOPPvfBuk+oWMwVEQ6aPsl0mIz60WDJ+fBdYajBtSxpVsZDrvCp0Fn6OUZi8lV+pcZJaCqlA71YwO+7u+LDJI1+Mz1Sy4pWGXLA+AkUCVTgAh+b2U8AN2qWycfx11q5sQiPIJIWkCNjBa3TfeNrK9x3wC//NLJDklp/0cfZQ==;5:7XmJ8GggpRIaqUuKwkzvQfe35zRC/0P8VPQzE4LZsVVoHYTTuAZOllkRubE8I/RtrOScMniJcSbvmMa91JUPClCykOp/Of4JtwxHcBea0uz0M+X3MvORE3KA6cEEh63YhAXomDSV+mS80qdoeCaw5V7cS7eN7SruAndTLBJAjbU=;7:B3gPs/CMAXhBqggUkOtJXbZxY72a/fWj/edHtOQCjEgpnh2l2DgIKkegXz43bBqFPPb0+yZ5ykw1tNuODSZIa0qDLYtddpOUX3kZrXszd3Ez5Q9RtBwm4wqPy3ftiu/RAiySL4Qi7WPu64Qp0bidQpUWBRp3/ULkGgB6l5RvqGtquzjk97zsRB8PLN2L+VJk26rS/W62jhItBsICjdjC4W4fuAfSt0XpbbGx6UusZhFsPVsZSEAbc/JwJ4x6vF4t SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:36.6729 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c687c91-9ce7-4607-bd92-08d5f31371bd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. __drm_atomic_helper_plane_reset initializes the alpha property to its max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE, so nothing changes regarding the alpha value. Acked-by: Boris Brezillon Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c index 04440064b9b7..9330a076e15a 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c @@ -942,10 +942,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane *p) "Failed to allocate initial plane state\n"); return; } - - p->state = &state->base; - p->state->alpha = DRM_BLEND_ALPHA_OPAQUE; - p->state->plane = p; + __drm_atomic_helper_plane_reset(p, &state->base); } } From patchwork Thu Jul 26 16:17:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546131 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 40541139A for ; Thu, 26 Jul 2018 16:18:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2E6C62A514 for ; Thu, 26 Jul 2018 16:18:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 20D442B88E; Thu, 26 Jul 2018 16:18:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A8CC62A514 for ; Thu, 26 Jul 2018 16:18:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731898AbeGZRgU (ORCPT ); Thu, 26 Jul 2018 13:36:20 -0400 Received: from mail-eopbgr10052.outbound.protection.outlook.com ([40.107.1.52]:34018 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731600AbeGZRgU (ORCPT ); Thu, 26 Jul 2018 13:36:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UJpGmcOv3Lv1jhgQfrzvW2LdGRdDwYVUXj/y7BXZsOo=; b=qBuy3Q7Rrjm9jyGDohoJEzMSSmh157QXMbd7D5DXAAxckg8oXR3eR4rS8qklz39o7WrYHC4ohUzN63x2emzfhsb8P4s8LwsgUuJTtowKnqMYL0k7w79ilf9aDUxxHRlM67QYkc6y259YbPTAArkrOu934PKnBsDKmx45N20X6Cw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:39 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v2 05/10] drm/exynos: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Thu, 26 Jul 2018 17:17:51 +0100 Message-Id: <20180726161756.1794-6-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2e09337a-4bb6-4390-551f-08d5f3137341 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;3:T8JzD9+yKGl1q81Akbn6WMiPfgEgUlp2AaLFNq3o0eLvUlxrlziWXjgYVax1cOZd/oT4pJBb7G4DU5f9ZLIbjQtzrvXM/J5bmklH2l2+1G0eVJkar3efaHAiv5gJWxZTYBbJZ3igfiZUt+LAkgRJtNgbIxI3I/+Kv1FX0tbQh8iw8MybIvsjRlDapat8FTppu1/zdoVX8uCk9Y1ryePRebdqx8sSIpj4VOgntDXaSDjmKz+5y4lP71GdL+sGHysl;25:iM17UhEP7PicTXpCgQglOJIQ6e2DWAzIwzOlaIcza21p2R439hAwTDE+ZncJOlIt/m0LxHQxIUbnhjoBDTQ+7pXhHLXqqTIxps7AZeMU7ODxMyRBLl/C/AvfrYqRJf5yApTU+9UZKH/BUP7u6frwgrphemZwyuq5J8StADCGv2h2wsS7CSMgmfkZIu8X8JbD+pSqGX1A2WoNEHEIseQ4Qj8atE2Sv6S3+BaMJctPHw5yZ17Va3KNSepOoiW7GHq8lDJG2GsWwmxaO+W6BI9m/dd45zwzKqhKIdxaROuQN5vHTpupJX8NlaSMPfsTtpkZO6gAVuRzmVDF6uk+X30l7A==;31:l/c/GfMteHCnZno2USS9vxqsBYEjiE3nOuHfbycYsRTxrK5SJdW1DXyc4qQv6iSEGZO7eK0my/VP6p1MSw4qx4KHHgTw8ZnB47tRCEV5aP7bb5Q8bg4jhloWo3th1V14M4rAssE9pkeKJlfd5xsuMbr4lC40HS5NJ6Vu7/9XPV5wS/TfJxcluRpABSREl49TBhaaXqYdW3HpjHLgxvKiK8fUHh6aXOH7yPoJd66NuHw= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;20:CA7vTc1hQ65/v5RNd5pOivkFN4yfurt+1c1/C32yVjIbtlN22i8zHFGSciGQ48f9rfCHgB0jajt0B9DLdMzF5LWiPkJ4Q1wVaGiUtXrbr++d6FTUA46/ZG9R3ZeSiogqzz1yVoX5bKLIOkSTwYhIWdMAq5zei+U0Q4QFFxfKQEbVuYVTSvmK2w2z8Pt94H0N6hQgBsQyBxvZ6ZgEkchkBWDVfOrsByBXyuwbHSaTDF69lZ9caXFUXL/Ikxor3dZGiXv2Is1swi93UROS1Js8lyIu0uZT7WQ89wH5lIvfkWVxeYuyYYDtVQXWxwxbTy41a/7HtdzUCDTXHPcF2a4ZkA==;4:CF2OCJtD9DtZMClhSJuPMaswmBVJuAkAVpLgY/E2QRFnV0RebGEvcF6CxtEaKhW62tqLqgThUMA48R5egfmVMYXguczJqcjVWAkWEdXtzkti6NYJc7RKvkEW3gFp0iNU15tuS7wNQxdt/FIdsyY+bE9ZAkU7Lncd7c0xpxZfjL3rdqSJlU+3EzbJh06wH3qGMhYzs7b/MpGRVuy1ZzB1nU/39/4TqU9ZSUWtJqjykOTCSZPb8LtJDfPhU7loG/8BjqgQVn99M+sXyNO9QKuyPSYZXYTudj6WEvEh0pi6ZxJhgBlgdP3RbWj+HBGPVSb2 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(6666003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2552;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;23:jSDynYFxj74sKcBTZ0sAIohrAPEfzxb2xF+FmesGeRqrMflw1Y+XKMsJrDNF9CmgRiucEwEL0vNHU0jvF3ej+keB99fs3bvn0e+ShQnztsKZMGZ8EgHfy2SpiAuhzyBfQeHTRSMdGn+vGbX7/DAznIUk9FMMfv00TsOS45oOuJZerRS/t2ViAsWnP51Zu8dNB231s+8QwFD2BVyyx1k4cs8kjNKATytvXES+t4jy0xv75xF84mtX4IwILNU/mTOo6Dh8oCD6S0tDwnbjptPhhVI5+EX4wVf3N/zmbzTKQXUpdleJJZHMvE4RotkIPBo6rh0dwE5LfFzpD9+Lnoq7Zl8zcTGyJJDOg7psiCR+fvx3YqQrcyTFscwKiW9tjSS9jaJEX9+jX62/nGQcKZt7zvxiiZ8I+1GsONA/AlLKUqSVukRNT2Lyx+FQ0Kggs5I9239Q2oIs2okVkNaWbpsjLnfD1iwdieel5+BcUYAXPMFRfKmIB8Ixxm1AxXhJebgbzBKdp53iPT7LxIHuMASUGNuwqaB94TlPqKw3Lan3Tn3e1G0tGw2Jk4JmEuvzoHTuk7LmmGRiQ/4X2Ir0xyHEU1ScoBHx7yaP1s8Z0ug3pg7BnnRm6bcGHEfLk8pbMjD1QN2ewFtUSjp0ya9NkPgGtX2Yx2lDBVqbh5oYaZ7+7kKVMOu6FvNmtVBRpyV7LWBovX5Jke2b4lp+gNqNAEmYD+MHgHuOuhdeEtjWZ67vHXp/jkfqcRZBEBdAPoINDfSGwIhwjAFp4CBNx2h4J8PySR5wIonU/HVFJUaOVJTT/TAKTr/zn8q7aFfW/5SAYrjpHAjUiB8EW3S8O+s62I4M/9wJzFWBu2xFPdvTIaw/enBIsSo5JbHtPh3edxrzmvUbNlYtaBrTZEpxKb57NJRQGxch0h7H1D/lnYsy+rfB3kM4yywaLyWPBLb2pTlNSUtCYrRX73ZfkoM9YR20Y4txkq5ovfIGrbBPhUgHH0/9CRCUTL8YIJToh//5RlMFfgyCE5G8evrd1mp4+8b6ZgCEqSRcLuOlLf0xv/gwI9sEI39XxfHhScafMslXMYWy5TLfAc3QMNx1hBhKtW67EDHrTxg5q0gfVaMQr7uynrJTL4MXTiP9Ax795dA2yxAx5OsK7EyC4t8ZP+Nx4A+OpXUyucuh2SGccGMXOHvYODHvxwZsbnta38Qaoi8gCFqiH8RDr94BCGZ1nwS11M+i+L6XcQHkuFB4Pi7dz6fORBZcwBo= X-Microsoft-Antispam-Message-Info: lhUD0kgzs4OKNC6m73cdltbBv/tN2kqjx+fWsvdomfN7Z/B+iPuf04MYP9syhi0ZgO/hsapnoOXUe9OZ7cTmHNdMdzCYjoomYUGb44h2wndlj66LUL3OB1gtazZL/gPUsR21i5tMDMukMw3IbecoI1cEAT7190Ju+PoNHrxvsJpmdHWLCB1HJoszd6ipT6T8eh3T1s4x8Bn4jHwgJsMZhajoMNRPGVad2Scc/jjIBQc2x3yU0Y45m97WTYpiblLiT+y0jEs4RpIPqNZit0KIYb6Mk6eJjaQwTtrpl5F3ox+g30EgmkK8Cwo3fYBb5wMJtS+XhYzwra/LJqRbjQRZ9k/uTyHmV6hpCmfbycmIfNQ= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;6:u1JkEGksPSVSkT6vgOKvhdMvj8dW9/lYQ4DqKAgHWehLYSOFdqUJ8vOkdkthaYsG1lV+rk6cp/NMOnVgQEDs00XKSraKmtp/V5lGhG2MkPZ8UAPLkQsX9M2LtsUYLNL3heNWmqeRfV/qIKv+XVhk4lzMVpmFUFdNdGYLwegDgvGCA0Lg9x1+1W/nngeu6ZQXEmR0xC4DkVu83Dmq8DlCudG1QSugHOmivKGeSRYK6sUCkRlRcbBcB45laO1vd/71yGGfIdWo1IhNO2Dps43bkqKuKi/FXWS965brnEAd+E+dxgFX9qcjpteVyq14TC6xnILmzUsANOtxT1AJvlIgaPN1rSjZp6NKBAK+NKRiDeGWc5vhKx/rnt7IpVR11Dhqu2qPpf6KBT/IjYeiSDakKECl2CeKGOsWMMwHWoY6iM2ETgCXp19moOS8YYwYabnZbDuUlMM5ZWLADpmxjuX6mQ==;5:FMjwJffSQuJ+Vh8Ep+gXDNTKWbTIpzTiZcvKznVPYH/2f7RSZYffQfZKTZwCLh/PTQ8BucHQYRHiG7h7FYP9HpNlOpniTiUeZDY884owve7wWDxY09yXc8KDiWWAjp9e9HOF8q/xMk3ICPt5PG43D0Km8ONmlLfF2KM/9vwsK3o=;7:03NJ2JAJd4hJKiJOVcIV2JBeYIigHlxv2GDZCL0zIxGaB5Dlb3RI1qztazVmQODvS96AwrbRcfSfRHCQqz/WknlnZzfs4TOp6ywbzHMaYMvK/0OPvqDjm4Atmx/OU6PutaFjBXHiJCNdYkaGowz6Wf8+fLx0KZgt9ydYus/2NBJ+4itU6p6cUttYJ8b5qJEe7msOUgwAeWFi7drtpbNT+jHuIf3xkeyg/Q1IRHk0FNjR9pPVJMmY+RyGb1T2mrKZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:39.2181 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e09337a-4bb6-4390-551f-08d5f3137341 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/exynos/exynos_drm_plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c index eb9915da7dec..681328fbe7de 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c @@ -139,8 +139,7 @@ static void exynos_drm_plane_reset(struct drm_plane *plane) exynos_state = kzalloc(sizeof(*exynos_state), GFP_KERNEL); if (exynos_state) { - plane->state = &exynos_state->base; - plane->state->plane = plane; + __drm_atomic_helper_plane_reset(plane, &exynos_state->base); plane->state->zpos = exynos_plane->config->zpos; } } From patchwork Thu Jul 26 16:17:52 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546139 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 67715139A for ; Thu, 26 Jul 2018 16:19:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55EF02B418 for ; Thu, 26 Jul 2018 16:19:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 471BF2B855; Thu, 26 Jul 2018 16:19:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CC0062B855 for ; Thu, 26 Jul 2018 16:19:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731321AbeGZRgf (ORCPT ); Thu, 26 Jul 2018 13:36:35 -0400 Received: from mail-eopbgr10052.outbound.protection.outlook.com ([40.107.1.52]:34018 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731600AbeGZRgf (ORCPT ); Thu, 26 Jul 2018 13:36:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pj27aaNpdpdtt3EtOpfd408ePjffUMDtKvscrLn+cfY=; b=QIIHuC3hlZS4FDfQer+TyhNOoJFqWEiXCf2wfyXItQwR+gd6IQrCgBBdSidv6zVrw4fakNB4T+4f1XcfdL06c8s6ERlQkw3C9v5ts1sFZ9X1jb6+PeFdIUGUGG5tukhVZBlp26I4skg05x1NzYUX+2AxLtYUtffHdIaPXeV3m5U= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:42 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v2 06/10] drm/imx: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Thu, 26 Jul 2018 17:17:52 +0100 Message-Id: <20180726161756.1794-7-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 70dfcebf-a9f6-4cec-9c91-08d5f31374f9 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;3:KuE9Xq+PviUwOBlyNTp0Iz6NXD3vaP65qxT68bIy1VAKAp9xf6+RnS/BbLFO964g8azilPZC40AD4u+qMsVIRq+gOfcCOhK6vCAAp/j8UdRSTWXF3EBkd+a6Y5SwvtFt0j3oKLR6mdEG/FRiy2QVC5dMDxwNNS4l7ClOOcREDDMsqcTJ3JX6MmF85HAcEKUEf8z9Ut+WYQBz5lhyLiHUG8B6hzsbIYjxMSrcuCJmBaoqxyYvUg9qy+0gdDzDrDMI;25:0HhdN04fXJMrzLxs0b2Bg6bw9zLi1dSiZwvA5Nk/yHjAcrYQxGokTeIBo1+w2GDeiwO0EKluSkZUZvZ4+bnd3qF6zWr/LEEjcPkWFUEu+zQiq5qw+DeCOtbjGd2yFJ5hpJS3e09NCtp/ryHO0L6x5tQPsYHM3YfTOM6wAGwS91HGoZtOjsu/HnoU+KT84GM2qW8K6TUxi45xAAB+62JepxicFtt6Vvn2xxFWoW9jCNYxbdUZ/Y+/1QO1/94+5xSK69G8D/h92SsLZM8L0Gio6h5VHkKhrtqvZNp/qOq6JXlctYis1Rqx7bFY4N+trupS/dUMUQxoKJY3ftj7DV9SeA==;31:QRzDJ9xtuYdO6feBNhPBNI4bQpu0lzQTFReN8zNA2JnuA9A3QJdnzBzFuM+wb3DNQdpCyYz6Q3S68WimQxs5cYfDSzW2chuKbl1IERUbHm1yi5wKSB3LIwKUoVv8DUIDRgwixxIsRdc4741vOQK96NG6dw/49mpcElKt5qlvYTbdZEyxaRn5BZ1am+VKuoAYsu2Ep+8kZQM0tsKhkrtTozsI9wP8rRnJkSpN4bBi14w= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;20:NTmuwNUDdsd2vQWvtrkxgIxQUgaffnT7KvjNoKBfiSa4DSmd21hfgVjnIOCNwoNqMx30sDCzm5xUqEib1Xzod1OLSW1uI1oBf9bU1j+YrWluRC6xSLbLyxEKFXIFnBfeMHQjDsxOYk6K0P81CsAoSIiLhV0+dkUyqh5r90SHBXnyntGtIrcBBzpsapZxhQCtK6ht5Z/Rm7Q5TfzA4AicPwzrVaf5vJd4i2MGuBD5S+GMoysqOZNff/wGy3O2B2ywYA+iRFfsfEp+MNpxexF+N0rdSu3QsU/Mg7wSrkwW53t+uiYUz786ElJ4nJUe06xV5Ju+YNd09OJQ2K6EBao86w==;4:VJ+r0hz3Xvjc3FeC5kijPFO/1lyhZSQH6zZGvNjpyjNm3A3uZxe3yLRX3/PtDbyVL5KFwwnj24F3LGjEKOxC5IuQtLhyDKINuy/MTLygNExo7eXsJVOFwgcIqaOCef2oDEifQEjXUiWPLvo1aIFZncaRnKDNKUxKnnMhmop1yN1ANSj1zNmEB2RRgxTDYVSDed9kLyU9AdsCBNkMOvnpZ9SMWyd5iTcdUsyJ+EbX+fbkB3kB801LS/mndbiQPRJ539HPeFjX+3q8hOhGgGVvma1pEDsta+qRpX/VA/2JTgMmKGihV8Xt8BdNFvOkUWbH X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(1496009)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(6666003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2552;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;23:R1cwiB6SBbBJ/vD2wJJchVjm6cdmAthqwq0YY/X9A0Jyj5ibn9Sx92Ouy+BRDZpKfi5QoLytQXnLMvd8xgN0In2uwCP5nJGNSGiTFuQGV0isQkTkE7RoXVmTHTo2wRDWVgIrOVdHdlyqBCP2GQgtEsprVnftxt6+cdLs4r9UiS1MlRBxvYPV7VgXHX28afiQPmwzQi6se+nxu+Y5RArUm2/EwlzeTNp9zTmczShyiCD7IyXYR5tFgYwV4mX01Eyhoicp+fv+EJJxdP2hrjFhCBIs9rawOs3iyzLMqRVd22fKRZTkauwUVqklAeaoUJnIt8iXl4YIPhmAywrEv/uDuPtOm4FXcBcKuTNyvW4SIB73lzTA954piGUG93yvcz//Wg7szuldTpUwZdFOOa+mvKgu7qSEhKw0gCEbZvQLES/2jSdMcY1FLqPXRnRHYHjTTcyalrgnmauS5RXd/mS2erS4LYJx6uzBJ+fhzkUVIk6PashbJuxlsTworqZxoxWCTtGI9sL+o0E1k1kudPANpsEu3UmXnFhWu6642b+qYWBFw+SVi4W7Cl8t+SBivzWlNn0OgsVdp+unjqVxcDWQ2tOIjrOXrCjiNPpcDoZl1LVTr+nMXHveWpY/OcytBY8c8w2AWSEjcb9dxT4rnkfu+nBEhUtN6CsEoRYVf2B77M7u9Io1De3xjcM7cx9EJ1WXZmCm1bEkKwvUMTY5a0aYfS1Q7pB3WuRQJCBbq26vo2RGvHZCunHR9mRa1xP0b6jQ3xbQRP0U+DbCOAC0D4iaKbD2qSDpyqUVR4i1/6/VYXNtOhQduBeIpelBIOFj2L/Wp+ou8ma8F3Q9Y158isqsooYz4/EbXOjMwgP5Fl9NbuAoEyCnIyy3UQi0n53jbteoudUm1VMDd+kAcEYcZnGgwl6b/mojKLWEpRnGavPkVhwxo/Os1eL6dN3H4VJEtfSXXFDQgHCffTLVn/6LcK3BFziH44YtraIjpZjF3pe3eKaH2VmBgSI9DDNJmG1HtuHU6O4/rt15aOq8NFH/1d2BVNjywcC3k+e6LFc6ZNhrcAuGZzZbkPg88vr30VB4j+vkfwqCgGOPQ5BgQEK9ai+hE8bXsDUtwSeEW/qPI8jTdITMgiH3MrgkG9iMxNjD127Wt43itXCQmJB6W+KI/hThhgznUqEp+XyPdKsq8cDSHdP2dESWgOBfQ9qzBUQN0riQTvJUYs9wt/vdzqc6sp62mbWlOhhTXmhvb2ymGuGawFZuuLXmXxrO2JQKEwb9Ah8t X-Microsoft-Antispam-Message-Info: cLRmtzU+2uq/m+c8DnAAxNo7vcAZTIkWjqSdTnw0lizrtUt+zkI68BgrLUv1mdlwYELSj8dFeyZ0UdrAmgj16xfoJQ1bDus7uH3oYkKGNr+/QU25y9pPmQBFtVCOnehBZFdA5EJp+esjrhTQbaNlYEeT8OjMNlmgCPB+cQTi+YrD9i4s/vmsIDjqQ04Ct3Pt4zG5QVojP1rRKx9Pg0rS0fFNoLKJybRD6muedOoxwuPZyMcErHKIfwUNATXtPjO6sYikKGkC3PozTgdM637hTwj+vEwDslUQvJC3Wd3aXMqHx7K+lhG0Yia4aZ9bsVk2S21Sc6LpjO3yMoxyAbo8cfeoFETWEQSjdLOhs0AWPlg= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;6:fuje1QP9xnXiKjD9NkLp7smCOKpdd0hqO7zBl3InjNU8D8U20d1KR7jR9uzXceRCdVx4/N2rG5eEC3xwDczHB5v/oGq7frKjzLUa5mcSmYcg1RmhU1EMjN6zp0JHPpRv0mex6QnT/czCaZp1zuEbmIbWdKvEE/C37S1HBQhTsuF9UM+jdGqDzucKiwYaCLe82cbeqdiTUhhrXe5Gk4TfpYNYkiUbyIqvPKG9JKXn7OtUKO4VPOO4KZuxq0kv5QQKEBNk5Pa9fOvNkrtPPNoZfRRCVZT5UFGxAtng2GEuywndu7f62steNdzquOtjiyZQ+Jr2PHViaZ6BZasOx8cFPVrcOAX9o2/bq5lfcof9Ri1zy8KZvDztouLtO/VDFlr5bYJ6q8r8VBF6S/nUaLEyv22Iv3r8OhhZBZH+dDDtHbPMgZfNhwnAVFKeqQ8vRuih8xAUxo2WMpjlIZmvZCL8Gg==;5:q8uRBY32N/hNYEBsNxLMl8DNLeIOKH46ThvMbIz3B6Z5zJyG06euLA1OT21AFDKKVTT12dGiSHa2HZdr+Gl9I733VGEa/tDQ5PTUIW/ktAyLISW8OSbiKaXfX8KS0resrzfow4cpMulsNM14h1AkwWe30TZtSaG5OxrPvRtY7rY=;7:EjUgoQdsRTjjRqMLIX4LMXt8gqd1IvQwouXkBc6FejJVVm7XXqbV1P45BK77YU/eFuCpVDuvSkoKNmYYdnU14Wu8O51jw9mVWC7jIM6e0pdepvY7l0oyTD2fj/qJBvNOt/G1BbXWU493NINKMidIZX1+HDVXOUJQ2wG1H6Z2/H2qnyidFnRrcDjYyLWcT+NUfw1UCT76GnuOdrRGekJM166Ej9oXGiP4haCXX39yHR6CW3gLizFge61NkasXQlBn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:42.0975 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 70dfcebf-a9f6-4cec-9c91-08d5f31374f9 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/imx/ipuv3-plane.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 203f247d4854..1bd4de03ce9e 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3-plane.c @@ -281,16 +281,14 @@ static void ipu_plane_state_reset(struct drm_plane *plane) ipu_state = to_ipu_plane_state(plane->state); __drm_atomic_helper_plane_destroy_state(plane->state); kfree(ipu_state); + plane->state = NULL; } ipu_state = kzalloc(sizeof(*ipu_state), GFP_KERNEL); - if (ipu_state) { - ipu_state->base.plane = plane; - ipu_state->base.rotation = DRM_MODE_ROTATE_0; - } + if (ipu_state) + __drm_atomic_helper_plane_reset(plane, &ipu_state->base); - plane->state = &ipu_state->base; } static struct drm_plane_state * From patchwork Thu Jul 26 16:17:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546141 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F2995112E for ; Thu, 26 Jul 2018 16:19:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2F612B418 for ; Thu, 26 Jul 2018 16:19:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D5B952B898; Thu, 26 Jul 2018 16:19:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5FDB12B418 for ; Thu, 26 Jul 2018 16:19:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732034AbeGZRgi (ORCPT ); Thu, 26 Jul 2018 13:36:38 -0400 Received: from mail-eopbgr10052.outbound.protection.outlook.com ([40.107.1.52]:34018 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731600AbeGZRgi (ORCPT ); Thu, 26 Jul 2018 13:36:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fkZXfLvRwTBnBCYgu9KXSH1aWUTaCHQUfIcPSf0MKeM=; b=iZP76r9+tnoBhv/0ZPYutMyb0XniEO5C6nVXBqan7j+5TpCWoQanIm2xEn3NpyN1NQiu/VBds367I2Ce9+tAKaplTF2Dp3izANNNR5HNh7SBJ6Nbxz3icYArG7iTJOCahTapt2uqCmSqvmzIx33lmYIPRcfhlz5bZY+UwgGKF84= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:44 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v2 07/10] drm: rcar-du: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Thu, 26 Jul 2018 17:17:53 +0100 Message-Id: <20180726161756.1794-8-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1070793d-6b85-414d-5ddd-08d5f3137686 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;3:cG5vC9ZuqlyhWGKNFM7/mwHkBKAdIfTsWG1Z4G/o/W7xAiQREx+WrNnNTHVeSyM1iVVzOt/4KE889NCaLmeCkvxG6GOuRA2mDzG15TeOwElvLYiXKWGKiy4Kvtu5XBijr6MtUJoXDJbrSF7aaRqxOorrB5Gz1dWbKturpw/qcnlirWk+MKRVnTnuxku5b3Iwg7tcz5164f3jsRNQabBRl4Co9eooqUrgi74a1Xp9MtYlLCvIX775w1+6HuIWMclE;25:t2kKBM+JPEt1HuhwPIe9UfmLxkvhCDaDQ09GdnkN3mYMdkkgWiuPpbDEYoZ2zbGLpTMW3mFCMh6/sh7BljntAxVX3EIBMA2oKosjO2fQMk7paOQsH3RHTLfnwkByE2RryHzXo92vZGMdbt41TwbuLizc2/LIer0a2T7aTRKW7P8QhfjA8+qHSiwHCgtmaZuVv+Y2WQmdrdrfdtEYiJ+a8E0EFKalKJpeT1vLUPMFe7+GxQR95DZw6a+v3lFB5gC0GdsLiQUW9ZhUVK3F2Zz4JWhbWTLadKyviyyj/87pY9dMCartF2ZD7ket1izGN+tRCEetZx+3v/KAWiVjy85/Xw==;31:RNwaoXbl3OiDXxvIz7ilny4CGc8Pc/l63ou0Hmi4kTQpmCpGyca68XCPVYrOx3lpm7m0WcUgeVwhhFl7DLofJYn3GlbdvL9/wOzWq5yfQEO9RR16LIm7NEIqO04K7gGia/uQ2LquNUymMzQwkOPWbZE7sJGqd5NwiStnUagn2UegCrzItZ6ZkPAQkxnv5yBWU7hOPNTz/IgtMsuuF9+41Ed3iXhfHnMAL7g6G8UfZsk= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;20:vbMqarHJXnVmsYQh/2vANLlST/hCe8BSYTZieRrv4xFlZg6pePEIPMpnc1C9m4ok4fdJL006TxFMSv+dW+oC3X1V0LGiDxRTz4dG8crRxwDExykNRmGTpyDqMSvoAGrnaQiqNrSPcndKUo+w9ETaUYQPfR+O9WcqqB9vbwH+h2aGnesdv8Kpc/V/qJfm6vNxK9+tEtxoJikZIBk9/pHZWwUmjl0lq+lQObWNO8ScCL+G6XQ8hJiMfJVo702rdZy0/Pmz9Jp0Xt2oswSTxftzywub/0Kib+LqFoKvHVhjBsF49o3pqwtDUrU9f+/MKLKJX3ZPf1xE3jJaWJSlNl9V0g==;4:BctgCZwE6uENyQs5m0kIgnzxvFJuCjd0pW7X/stDlTUUhj+zvRN3NPLwi6qz8NyzP/vQLR9m3kMmfjZTnfJqDXP8ZWJ4xz3kH9SpVXiv0JdDS8flIKDhMH4FJfMLYgm+hf1Uekedh5rAfs4tfKW6OjYMW2lG2pDrZ+tIxv+gB1ioU0lvM55J6ej1xwWQStn8tUHMndrFWRhOF926/FfMEQvlwLZrMFfrsUhWaGS61i91FoQp7gOjKg9kfZJe5+7IOvRrVuiBBfuxSegPcYphuspBlXwNTlTM7knQGo4fNeyuccqgvTqkbCe0TK+0o/Kn X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(1496009)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(575784001)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(6666003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2552;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;23:nzkiZMgnSPlqQUmBVHJG/V7jjo5StY4yr1p0SyVF60NebJLA/xlabW8cr6pKSFePH/trg/XpPqS53zvA/lDhSX87bDqj24t33+WltVzM045ub+CI9SN92wbCCO6/SjAKiXrVvq+XjjR+24hJ6DKXkYKgHnh9vjBkUsPIqVanV4fOkZDwggELBg50lOV///vyjtTexu2+Wxg16Lfn3e80iUynQSmrPSjZUurJZSIPYQQeRduHoiRmY5gppUcDPBMBILc3BIcGG1J9hesOtmMkI64s8qLVUp2aO5WjzPhcxycjMbzA9iwjp9JNJdRNg/btmlojvcvJsfut6F2PiU/9wQkIourS+09a+hX0d5FJK7Q7CNUoajalAZ+wlX6YqP+dU35/LSyxX2oNJpfy1y5rEEl92gtuCqwZksWBsKvEZYzc+e4PZqoO2nLSchLJaT9HrMdL2KXQ9mtC1LA2IwA7Q+BaFiCeIvJii35Yc/0Hwg9zkP8EQKLj0KH6siN6r0xQzyQOmayH7yyLBptXLndjoF4EVeWFS4Js3/DAINEfVQnOVNgOWKAsibZwywEAbQoT22xvp85IkHlthqkY715b+8zup42ZysYglKvpbozTnNyOL3i4gL7hoC+vdw/379NgZri1URtDDFsA8djeT48aiKLoIJsL4rvqj40TCuBFUivL10fo/6QQq2funKdVBx5s6BLh+Nmm7OjpKzjvA2VhurjOuWJYC0EOC4OzOsLFpZQNSB5BoI8/fcucVYBqqxK0SVrIVy4/61QXNxiRRDZJ4Ya5AIMI4q9NJCMetb1IgNtusniKnoAQ3gFxAzwutbgHyF73QB3c+rhXZBmA7G9eNqDMiF5AWYk9V4iLLRuKbnw9iZ+WY9tEsHTs1GWzWj4LNffB2dQfdPlkeVjhUe0ZEbe0aXYPLH/XKuLak2DaQPjgsN4VOad/ikb/Lh9c555K6iP7DkAlvF0ySPY60mNOc9NsVme8bg/mOPJHS1w4bRQ85VUg7l5M/DXqJoVdtAy0flrk5dRLjs81Xpji6H+S3U4BAQ0wyqnDkTd9B0FX3M1UIpfd+ZSPtrt/a3kz8DsIkk86sgSU7sqP5mtzwLWGJHURJ0+0ZW8+Oa//KRcbB3Ut3F5PkGscQRHbV3GBSI4bBvzAVMe7GXtHqAM2ZFSa2e5UW4MejYJyH13Z7WXZBJ6BqiGu7Jc1whUPj84BKHAuB/m4ZMpDoDPAOPVB4d8Fh+CJD/1+wUvVDTSFfpxR0VXAGcYpgYR2njLSBVr2IGdBBIpxvMBTVRA//KKHhpKOdg== X-Microsoft-Antispam-Message-Info: l2L58xy5vhe0y1wi/Fp6u4MHpZfBL/xbMk7D2evw47h/yC94+MjPLZyoSDLH3blNJqw1VXdkVFHKbjSgZHDIeQLXuw4zYLs5sS69e6idjM9SweVQCJS8NcR8SoNjr6FJljYWSp1Oys0j0iMG8UUnx/FnndFwEbkrTXT+0S0XkW1uyCi/RLuVtgKuuQIpdm5QYp/fvs+MrwZr3XRTOnsL9szM+si9Id7INfhR06Ll4o+0WHYg67Q+XcR5FPAE13Vk0eCYTen7gViMGT5eAdFRM3A147a1ftT9hU+V+lozD5r5UB4vNPzxUZFaF3A4X5fJaHOkj+D8avXrPkfJUBBCAiR8HwTRk4LlmtK9tHqwt1A= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;6:D3v9WNUuOxoIDkQcdN+xjS1qcB/Mypc6n5ZZTpC80aYWkn1OTrQlDcxqOXMlLkI1zWnup/gLvfDvJpCgrHiZSEfIfphm13i/xo4XgiCSgZ6uc8PBikRpL3+E3YgDd/nDWisuwZ2YHoFU1wChVIYtz2VO2JheXTX3hLFQ2mN2oZ7/ExA5WNGhhnUD5Gjw+19B3HB3sNMLOofY1CMif/wumlMaK5sDKXlAjLQm7ieoLv+deDSDn5lYox8DcLsic4QQlRDqawKRRgz6GKqEdGHhKRoRub0NFH+m3Fm5zG27RO9wO3EtVV/u0p/8oQ9P2eof1dJct3RHSekXtokHd816CIzdgEAC44EC9YdqN6RgPOa/I12AbszfwiBut9fhmqUYMbpA2nYuIL7IS4a2NKs5ELlqZpnCppAPQDMWB+0MUV3HzC7W7xXBIEB7O2vZW3B1xRWc5kcJQ3W+zFC92wrSGw==;5:pnWsC/FTRYpqwxsSyBDJVaUDkMpB6z9nTytcFPDUFbVtkbAq1UASdLcRdntraCZKWqjIEkoaK5QDX8bzvP1MBuq4hYqhIQK2Ufq3rltyq1kae31B2hBJ8uimhCL5a/b+uhCZ3d77yfvGyoE2h5oWcJiKsAA7SnYg9b8AQeacSfE=;7:5FBiK2Iuia8TYqg+RuXHyt9oBPdXbIv2+ZOlVyFOwpCCghsHR08UuEDgEx2m7uo/ZaLV+9L5Uqem0/NIv57vsfAAsnes1mwLnKCgF9ac9I4wAJIuYtxwYGO66qX1xj1uKd4oGrd2irWxBoTTopMOS9OpFJK9VE5UngOpOA2yM0azoldHGfJcm1uRdY+S76K+CezBqKui2/GG5lnN5SVKlE3GT9ma/PhjArQQOgYOq4IlbCUkhvDve1+FgBuC/QP+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:44.7056 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1070793d-6b85-414d-5ddd-08d5f3137686 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. __drm_atomic_helper_plane_reset initializes the alpha property to its max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE, so nothing changes regarding the alpha value. Signed-off-by: Alexandru Gheorghe Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 4 +--- drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_plane.c b/drivers/gpu/drm/rcar-du/rcar_du_plane.c index c20f7ed48c8d..19a9d5f6db1c 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_plane.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_plane.c @@ -689,15 +689,13 @@ static void rcar_du_plane_reset(struct drm_plane *plane) state = kzalloc(sizeof(*state), GFP_KERNEL); if (state == NULL) return; + __drm_atomic_helper_plane_reset(plane, &state->state); state->hwindex = -1; state->source = RCAR_DU_PLANE_MEMORY; state->colorkey = RCAR_DU_COLORKEY_NONE; state->state.zpos = plane->type == DRM_PLANE_TYPE_PRIMARY ? 0 : 1; - plane->state = &state->state; - plane->state->alpha = DRM_BLEND_ALPHA_OPAQUE; - plane->state->plane = plane; } static int rcar_du_plane_atomic_set_property(struct drm_plane *plane, diff --git a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c index 72eebeda518e..0a0aa490f805 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_vsp.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_vsp.c @@ -346,11 +346,9 @@ static void rcar_du_vsp_plane_reset(struct drm_plane *plane) if (state == NULL) return; - state->state.alpha = DRM_BLEND_ALPHA_OPAQUE; + __drm_atomic_helper_plane_reset(plane, &state->state); state->state.zpos = plane->type == DRM_PLANE_TYPE_PRIMARY ? 0 : 1; - plane->state = &state->state; - plane->state->plane = plane; } static const struct drm_plane_funcs rcar_du_vsp_plane_funcs = { From patchwork Thu Jul 26 16:17:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546147 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6EF77112E for ; Thu, 26 Jul 2018 16:19:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D4472B418 for ; Thu, 26 Jul 2018 16:19:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4FB1C2B88E; Thu, 26 Jul 2018 16:19:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D5B822B418 for ; Thu, 26 Jul 2018 16:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732036AbeGZRgo (ORCPT ); Thu, 26 Jul 2018 13:36:44 -0400 Received: from mail-eopbgr10052.outbound.protection.outlook.com ([40.107.1.52]:34018 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731600AbeGZRgo (ORCPT ); Thu, 26 Jul 2018 13:36:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KuNvUJTxO0U/rbM3VfErL/l6i3CR17spyY/jOK5cpfE=; b=JfGPcbPnu9oODnhDblydHdTzkLStw77JaWj2IlB+41I4GfUARKWox1mFGhiAJPLFAZXU4zbI94D+QF3jGlujLvcq3yjyDjykdo32xYA7go4DwM5m8QuLS3kFmyBXocUZ2iMrq9ZaQCk5CkW6alLxOJ5FVE9uJyCkmuGqxGOu2JE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:47 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v2 08/10] drm/sun4i: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Thu, 26 Jul 2018 17:17:54 +0100 Message-Id: <20180726161756.1794-9-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d1504a7a-cd7b-4f74-6be6-08d5f31377ff X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;3:5kPqF3/FL8o/oq27YkFHknOHcCKv2Cl3TFpk895kEr0SzUqVswqwS5mj3/THTtznv538VKdVz/m/F2CB/yO5V+2c6bte6pWWXuXqH05+HDqwBIRStxD+2vASTSNTZ9Hfapnr36BpyW6+ww+F4GRqttI0Alw6ll+wXQMe3NvszfBUEu3pMTzL6bPkn+IDeMeqNcxfsRIrU5acBMuwC48g/gDRcdLmuTi8V8roVzuAjynSxm5lDoru6CLwmE3NVTO4;25:M05R+fhH4D3+sVtBsQLSMiUic8M4kZmlk9rq2sBNjA4PNB5wtXgTerHvztslySDJP30kOWbbdu6h1IXe7O1/vEw0QSDV8LPY4Xt6njPAV6DvjBrWBJDgfnMaFQ7xyDZHIgG8bLOMJtcSgadYPYmS4JdPUE/GlolPIRovcQTgkRrIPbMTJoMFa00JcjGiD1EBJSqJgP6oMjXvEEFHkcw73STKCt5JzsWG8rQrNvHQrNGb2jIzaqViEOg3tCcGMkXnlw+ZIbbRrhNgU1DVeE02kJQX0HYzPSrMhoNEoUwgBUeeJFxef1MNjiXHylIvIee8InN4T8dB3aCkAJH2HckYWw==;31:gieygxOSlyHaneZpjEfofPUCcAlf8rHGg8cKs29MwfMWTyWRjz2XsrfuBIlSRXbmtrppWU+Zv0z34tm/b13Q8FhGJ6XkTZZO7KMXFhMKPglji94NFOyQdwI1/9O60kfi/XkLcpl2U4MBW1fmm9wBqsE3MlHA1IBJN+6OLrEqCsnXB5h/mALHe/e0HVMUhGJhDphaHuxEiFenluvbYKil3pIxlc1U/+2iprg3VMwVM/M= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;20:jIxPrfkvre2mxu8kdAocxguIfSMpf8U2RtL/Og+FjvE+8NAVFeTP2xtQX3Fi3fZgBtwJppkOlTwJa7EUHeVU+NVruRwsjsLOZrtRIwKGu36Yh2vEXXr4kSwsNObsnPJHvnxaPOC6VwzXzsqCWAaV7Ql/oQiVXpiUS54HdHZAfawC771oo3r/8r0s4STXa5HGWWeDtsFjvcua7BqbjSJ3TGoF/qY2HIG9sq+uMjMpPdossLM5/xfmey31GtpSMt6ZliFUasRO8Esvxehi+Om5gaTPozzWECFmsEFKnP+UgjFy4nmbig0SkdQkM8XcCmgpa3Ao5/cXFyxkTGNL0cZTHQ==;4:C4juNiYhk/0k8vPHrBWeFoX1+mjYh8bbBopgglt5hKGrubI7hBXmx3euKTrCNLh1OroCqkFfaK4C6DeDjZvxVdGmopCdasMsB4Q3Q370KU+N+UfVQEGZVdI+4qay9N0NFBMj9DfFh3S/hIaHEWiZLNyUCz+MguUUdgboRp8BUpUOzPhOJaJelZmqx6mWT0f9ePOArLcETpHA34lkTuMOwNPYdWpvFDugg6paEZiWMIVeNyfmcXdi/9VLFacQaduF1N7Z7QaKnXBj3elULiqADF+fCD/sG/z8KoXNY/7/RxsI3kmG34EydeRDeBGdhgCj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(1496009)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(6666003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2552;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;23:hV/rbKFGMehySohUoCIuedzuDgwHcXxsl79ag5+j48HAivutH3mAU0XoVBa4EQw4EMF75Cq3ngDSRcQT2vQWVpgNZI70JybjIErnKChjAdfq2pRJj2dCiFaodytKW3LID3zOUUCASezEe+fyl8stcPdq7LYsIyy0HsASCm+Ks1BBe/VvuRKwxSYCZ0Z/jVxAP4Uk4U8GCmQ4684HH9zWDcMSnKOzWep0LxVsDapP/Zub4nm2gp/01uRlKAHEwT2qScWmc06izeI6Bpxw/AStSTAP8Eut1u1UcfIvLmAMETokDdKkNpe3dS+HQqkne0xDjjmkirLfuRCiu04aP5UVLXbHtypUPyNLklcJfMEd4s44Z2pRiO13wqbleSxoxZ+y8REvZ54l3QvpiNVztjq4DYIZoHhhEsNrQv1FcXIEOuRfJncqLqgYF7Fkg0wqEeRWdT0wQP2AdECmRXUIOTEi0pA1xE1jQvoV2lrcEQoPmJGu3lPxFe9eCEkHr7VC5oIKbgcF2KNgnGHKjFmztdO2LzttbDjFsv/bn4uebrA3W0kUutrJUbviIM8/44PYgoKPETJprLEP1Zblag83Gw8XqfDA2f+Itc5h/uTU+ZQvGBiU1ueL4zsUtM74YGDgvGIoRCbBUGHLFamX3dgPa3pTjT32Dp1KttnzqoJrIL3xVAB7IbDA4YmO0kxdI2ePfsiq/J20OVzb6+GoK4XO99oX1DQweQ8xd1EHIBH7/5am6SCUpcB7QPX2iSvUqEQPD32lZyr61k/1dO8Bi/7mHp5q7b+YZOcXScDuScocDmncrORR+FQGpoBhYD8sleMw6DuF92VgVSssncsgb9Z4d8ze/zvDOo9JmqqVNiboXqBiNjx+yHvqb0uHSAXTETsG1f2qcr4REcaMRAKXKNA2wj1MgRhRCJSHgVJwji1a/JYZsUYN258X1lmj8c1GQ75pI/ynyZcPFUdRL3tpgaqD+FCj2s1TY+rGKmIlr6rrtt15K6Zvu9nxFEZTuOwsp+LFpKFfMWzjmEYaVDGr8atIKW5r7q9aQJY9LbMzgwihKEH6db0+WPwrDJ72RTB3mthiySnXqXtnDBM/K6tnRae/DJZr1pgeg+fi8CQR/iTP5/FDPvE/0yb97pLBSZJoTk++nqkTV/KvhNXgS9y2NJao5YLNZL1zarxgd5m/zDpKfma1w1li9ynz1FnUw73pgG8HXbdKBhMKw+1bsBnsQiMAlBysHS1eEmCxU3MVKnj9aza3PjV2gPtv4CsW4pNarruSNOvg X-Microsoft-Antispam-Message-Info: bWPn1Bxb4CbArqjjE5YcWG1G4wCSrhtyJ86uVSDjFXDWRHULnRinXipySqYVmtmyWYVpK10d85V/Aj3jzRECXpOaVJwPXW69WvnbwSSL+H+dmwz269YjuQc/KVAsXfaEly1GajfoBcgDxDROoiUdGuWFJluD2Z2V7d2549/5ipionvoMaMncez4HBKxtbtyLyW7DTxOMoJmUGxPMoyRFxSDsy53GvtiUO2+U2ItFY4gsuN3CIrTCZ7Ohpmk7Czv2g+2K+nGyR5yMOYjIJI7RifaNa2VFE6LDGUbfKqym+tUk1pVHAX7cBfElTss+32fe+8++5ts68sQVyv61nYKi+QjrZquYOugC6JkkJ1yWH9c= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;6:JLA2b0usQBhNUn802bUJRfDbo/ZngG7zq2olTWqzdjIwwqg+H/7rfPIJrFGRUGouevA8gczEhuCxZVsshpKL1BucATDfwKSai9DC5WK5QIPMwCvJyeZxD4d4MMfrrXFY+rns4j1rk9rJTWPkbUgDathUGD8iK7pAB9LOPvt1vdude9N1BfNpWTnFNoLuWodJYXJXC/xj4dkZ79mQkszKtZmBKYTIiBTEtBvi3jl15K5eIP5C5NcUnHtEvXnpxsDOrZzUSUYHhgIPpJVn1iYd4clQPmOeU8IfUg8gOAFS1/+M57cJ0Dd9RYmO4rmjkto4w/e6V+ucclh8/u32uezO9OwC83MEkIORhIQ13FNhO5YmBp8HEK9mLe/BEC8fW10eYPhxFciQq1yDcWSaSDMYq17gOPQ/BypnhVcQA/JH03VKWAo2m9BcTavJ2kkBZw+euwIrZDKl1z5LdRUJ3u155Q==;5:lv9cpWLhBTLOFhaJd7SwAmYGctxwV6345SxXZMdZ4lixcWRZsGqi8TLVhwGErIYgnG8YnDhmSiqmuP0ychiBiVMo98D8jpGRl6wjkp2aFVNTWGx+nfNzrw7MELd84PUwksmBLqAJYZuXkAPrq0RO0n1kmO8TeDlebkZD8HFbvCM=;7:AF8/YHfbvhn7g896E6VmORJ5epV0o397Wm+0LgiHR9S0Ivdo+4d88zWryf7aCap2ax77QX9DaijenN1+kxUWIAgP0MYlFHCGtapoADqgCrXcRaslu8nWZp+RAgtZmhO1UjbsOVdVwxyJXI7qjK28/9ZON/Y6Gyu0RZ65W9ieJ+aWx1McOtUSzFp24Wu6zVgZfpGZRgVN1tiq95HuO50r6EJNZmTeb0fC8KGT//9wIHwHdvvm/0xepMfwtPDnXR9b SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:47.1697 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d1504a7a-cd7b-4f74-6be6-08d5f31377ff X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. __drm_atomic_helper_plane_reset initializes the alpha property to its max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE, so nothing changes regarding the alpha value. Signed-off-by: Alexandru Gheorghe Acked-by: Maxime Ripard --- drivers/gpu/drm/sun4i/sun4i_layer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_layer.c b/drivers/gpu/drm/sun4i/sun4i_layer.c index 750ad24de1d7..78f77af8805a 100644 --- a/drivers/gpu/drm/sun4i/sun4i_layer.c +++ b/drivers/gpu/drm/sun4i/sun4i_layer.c @@ -35,9 +35,7 @@ static void sun4i_backend_layer_reset(struct drm_plane *plane) state = kzalloc(sizeof(*state), GFP_KERNEL); if (state) { - plane->state = &state->state; - plane->state->plane = plane; - plane->state->alpha = DRM_BLEND_ALPHA_OPAQUE; + __drm_atomic_helper_plane_reset(plane, &state->state); plane->state->zpos = layer->id; } } From patchwork Thu Jul 26 16:17:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546151 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9A8B6139A for ; Thu, 26 Jul 2018 16:19:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 883A22B418 for ; Thu, 26 Jul 2018 16:19:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7C1842B88E; Thu, 26 Jul 2018 16:19:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0FC332B418 for ; Thu, 26 Jul 2018 16:19:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731007AbeGZRgr (ORCPT ); Thu, 26 Jul 2018 13:36:47 -0400 Received: from mail-eopbgr10052.outbound.protection.outlook.com ([40.107.1.52]:34018 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731600AbeGZRgq (ORCPT ); Thu, 26 Jul 2018 13:36:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5e6iJUsYRCNX5AmHFtVRKk8GG0lxjSuDWv5Fqay92Do=; b=hfdRviu8EXMW6JcjlHqi5ph6J4ngTVfce3VZWhdSNa7/T7Qc+5LWUY9t5/MKfeXKChPj2kng8koDcwTxZOhisnNmLv0Esv0iikF6XTrbYqWh9jvpH5zXXfEJbA+Uwi/Q3kkDFAt78pMYSoT4GJ4E9GtDNHfUV12UBjWymBMN73Q= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:49 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v2 09/10] drm/vc4: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Thu, 26 Jul 2018 17:17:55 +0100 Message-Id: <20180726161756.1794-10-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 129eb402-936d-4610-362d-08d5f313799c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;3:IjxoInD4c00EpmB0iBcmZcdIQInsh+VyAE5doCbml1IEAdm0dbyamNwBQ0iwZJ9tdB+Vis1lE8MHtdC7nCSTUZ9JasDi1gPv3HGAOjOzO4CK0bUWEejG9M/hzFxI8tQfZfeygfN84+bBDorYawfh6P8IQdA7vAlKFuTAEpmaSOndQ/a+vq0brZ3EhpqPqINnZT9orFal9E3KIPk2aKfi6UTywx5ER7RCPN6AIFkvl91H2/S9eF2YKFid7sKi0u/D;25:yVKNlrHzQX84vf/cXeWciF7HcwsLua8BdUhUrxZRDXFmndt0mpjm3LKYyyxyedWLHgc+k94h+7wk4W81SiEgPYr43sszr+WTKQmZzbfavDbN1y016YoCtNqjxJsE6UdoqaWqCDtsDw7DvXm96LlTw6e1V53lXfBwXigUTqxK/pCv4ha9bZXDQdKoPYf9XiVtu0YaqvldIHq0QbeDme3vm1r5AunJOV1DHChGuiA1z3cB3R3a+oXbWoBJtqEwy4VVc14gzMoFGaAXypLgKWwVOF9PU8EZCEzKekjYdw4Eoyro5uf2Lb/Ow9yaucvqAMbtCKNzdnXLmZTMIi3eJle1wQ==;31:GgSCOG9aRdanTOadKG3YiD9NkcncLYyFG+BXSqf2XurE0jxBQcoOQlgLcg/rf6U+N6iUfBVztcEWzkvOArBurhzMRgOdVBdA5ZdbLvY1QJxfkTeNl7gbeQfD0vJjkB/l2pzc1gD2KfXjycLIb92RkUqMR9apMSbvcVD1G1pgWCd/QR9KEoj3Jos5c86rLjJ0dCAG1rrGsA84AfYjCY3JYlq26/lWpfz8AaiqJU6GMHM= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;20:sb3+ehAP1T8n6y/yJcfAt5Fyq9bS4Z11t2+D6QJKlu135RIoogTDtJQ38BCinlK0wt5jfGIpfROzeqnPhCVfjcOumwL3djbhcXNFdcIoWA+faQc+h+OtjoZ9JgbrgqrPHZ7vt35g1BMGJzgziyxXUUOxtFlGVEg5P70t7KcLDRQgZ4vj1JFT+GNeM6xsu61uu0+XaiGjxmPkISszuzyoxvH2FbEdJsJrWIVCv98Z/VFM3I2byHBAHl4aSOWiJ86zjy1OpbbMjudAI9D632YnLbH3sehOqI3qCKoqiGmuwqTpdg9tPUWinGa/ZCSIXyummk6IEVScw9vaTxs+AiXFvQ==;4:Y8aoap9lZyMGPYA5ytbntxy3az64iDf4AdYq+FqazxPgKx7ZgDz3b6M11jYN0OHyPaMZYLBt2CTjpZk1wl0eppIMZ7Oy33wBkttTmcYNexkR8vYuXw1ZoYDpRWY8tqWr225726NOk+Q4zsFFtVlOS/J676DKnV6dXY2vEWeMA/R5aLm/NhJ4W0nJ2Ea6YRbwjajHWlwZ3BMR6gm+Dkj0vnlbuL8dnQOMPE3Kthner1Eu2ivb3XVpVEDrF0qa08cTsp9Q/7XxplBYQRmNZzHqgkR7lip5lnHHfJuvpFy/PQLBpxeWWU0+iyOUx5p0o440 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(1496009)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(575784001)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(6666003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2552;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;23:86OSP8mYMBnIvkbHRsTft1Gqw7MqgfR7yng7GLqRouGMcqSF++6Yhd9r4zzr/QbTw0JtZFpe0rawyEr6UrdacPfVpWtTWwna7YfvCgWwDiJUn+aYebXltvLc0zMXDzPOOGgG7/7I0Xq6wOGSP0k1hYhaNyBBEz9Yb73dIekKtA8nZX0S8g5ei7kTVhRzx6AMGPCZQR1qpzs4E6aUElYN7rutzd7ttVIruuG2MCcFEQY3JxdGP4um90sf2Oj7fkWw5b3KmOhhJsusy4Q9BcLVV4jbSbCggiq+LEZBIkrlxOXN3GQSiSFqofP/8rGxFtzvF1ToyYmHehhL8WH83AbXJuUZtstF9v7CVsGj9LHwaInYzrctsNqVr9uDpAtR9E6sP2UoLIasHrGgJ9WvqMYkXQeOLF4iKot/wvNEZdh4wjnGw85tacfy88x4I6myCF0kDXWeIPfBqBZGiIlBJBAGf7gdAvi575Zbj6QdZGYRJKBYbfqCyog2D/T7m2FVMQmprbTlfz16loFelQYEADJBhADTGcv7zSQjT4XfC7B+RHbW15vsGhK3418rVUmnpNQ0Au965LmmXM2dlW9TF+AGDImXbniGuoDLzkfa6+ZpLfORHrdHlLrTlPwARpmVrros+M4oVpUBnHN81Y4YbaaX5SmEOvCAJtIYjyo3clGM+uKUPWEf38vNTkTfa+Fc1/slynOVLHtDmiPdyrr0gBFN5P3q+WzcADcZrgeg9ekyTSUtiM8QoJADTjYAIVCqlPZ9EEs8qVBpqsxuDbHdPLxLQm6tOjFznMJ8OZz49kcGLmv0WQaL6WoCsx8Z6FO+r+KVsrqp1wg4OcDcEWDTC5e3jrIzo1TFt68O00Iu3zCAafVjmkZvPO0si77m5wxzo93HnvJhCihr1nsd8wiV12wkFTP7XHgXwRooox27A+z6BWyePafhiP0mIkOGaPydtWAyBC2EPW5maeruY44FfVyGxNbYaYr8qdG3Ak6C0gPrsvGfOetElUGYtKaT09LbsPzNsLXJy1prvjlsGWjxFznBU66vSebLrjYAJyzXDeais3TH0B/49+zZ6lKPq2X6GSmKFDJxJii2mIc+kqwtwH0x1uZL5QWyQVUZrAlEeZcAcvcCglTPXuWQQcmz/iKk4Ew4TYVdhH16xYA2z9PvZOjuXj17BLBGgicshK6r1FzCV5+8hIXrEJDONarpSG0VltXTg+neMaFCX9BG6Wu6et5qgtvxgZ4H9PbKEcg2mY40TiFHEnCnTdZUdGLvmWxSZhOjA4cVw2a5DviKGuZHEYN8og== X-Microsoft-Antispam-Message-Info: 9DYesdNkDWfWBENLDI/hoGvGxm3VmsOcPcuV1bQdlod3lrJri1lVqj9swlUaeJEVXClyi9Dm2tK1Rt4tv4lIvzSyXXF3CdpyYYrVeSketEBu/cDdzU4WSK08p6svAJMcz5Yb1aLgnJOwVBKWy4dikGQ2p+2gZn2sHL7CIYWgKPyXI/pzyge2PcoX5QuyDFB0BsaknTMwHa5kt9mO5LYHuAFAWfXwaTLPjOvWErioXRfkm7LW6hmhLgkbHunOSVleJWlbphfrR8dAUc+XsUELlvfMkn65nGIS4U/odRpOxmzrodY1RkWQM1TpvFgjk6ItK1+UPJtIHnQ+CWeswMpr2J+mkd6CJ+lpqIOEL3/Y6lA= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;6:8feppcYfjFTtHEdYWYbPM0/EXXssNITvqQD3qDje6wdclFG7PIeGB0nR05+rJMhGVTHzxXGeg1HsupodX+bDoNHSZOiSLDvoYK2XGPLxnBT2VPjV6koc+l4IeCOT2bF0lB6qydaSGnCb3/DRXruhGe58WitKVk92y9waqv8fnPiPZorOCPbsAkHbzIdNJbLoGu3du0BNyAo4pqAC1z6Q+pUHPLdJkDTwOSvMLSQyYuitQMyONagmLft3IDFsc9n2jslV2JKn87ZIavA7X01AbfwcL3UZ9Qr5uEgiKCxEERfhKhEdbjw48Yx0vpTuugiqH4MXpNOT8q+TwpYlWgeOVuBac81mdvgv5YG9h4Thx/z73g6wRTaVpjDk1vFzDBSbjHb6b+3S+QMBQY37NCzbWXuH6YXiKFA6CzGBhDJJ9t+EZFKWLrNDdhJvLGPwyANDCnzKB5W2ZgnSVNj0/MS7kg==;5:o2mPh9wbBM6y88yopQggDz6iYlN1qjGYZqlYOQ2HWC9xHgERQcN0dphStXe5gOIsz/HzZ/Wzoc/NMrgPg6Rj7Hm3o3xK2ZIVrkp9EH/d/XoenyQY1Viw6MMpnCGOpE0mVPwxABf9dS5n/6IVlFJ9ub9d2dcB1LaHqrGmwToWHrk=;7:J9hij1C+p6HmKlE9uU0sPf4WeeTUUeFAzyWSxoxagOOq0jiGFbwYtHMQrd/txcoMxDEb3V0QuhxVFxieFMoJ4afShC8u4GbHwZQwJ2/k6a9l0QcII0HPeQ7cJcnIE4EaX0g9KMB2jV9vdSbu+Yra548QEVAPW3J6db1AEks3K11p+UdmdbR/7AhlvdsdPdW4U6c/Eqc1DOc6we3y9LhyLgQU0wBczjQAsPUnbTtY3SYlkPMM/G3PoPBdyDdIl5Es SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:49.5687 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 129eb402-936d-4610-362d-08d5f313799c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. __drm_atomic_helper_plane_reset initializes the alpha property to its max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE, so nothing changes regarding the alpha value. Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/vc4/vc4_plane.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c index 9d7a36f148cf..688ad9bb0f08 100644 --- a/drivers/gpu/drm/vc4/vc4_plane.c +++ b/drivers/gpu/drm/vc4/vc4_plane.c @@ -200,9 +200,7 @@ static void vc4_plane_reset(struct drm_plane *plane) if (!vc4_state) return; - plane->state = &vc4_state->base; - plane->state->alpha = DRM_BLEND_ALPHA_OPAQUE; - vc4_state->base.plane = plane; + __drm_atomic_helper_plane_reset(plane, &vc4_state->base); } static void vc4_dlist_write(struct vc4_plane_state *vc4_state, u32 val) From patchwork Thu Jul 26 16:17:56 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546153 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A9613139A for ; Thu, 26 Jul 2018 16:19:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 972302B418 for ; Thu, 26 Jul 2018 16:19:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8AC9E2B88E; Thu, 26 Jul 2018 16:19:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1A4052B418 for ; Thu, 26 Jul 2018 16:19:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732037AbeGZRgt (ORCPT ); Thu, 26 Jul 2018 13:36:49 -0400 Received: from mail-eopbgr10052.outbound.protection.outlook.com ([40.107.1.52]:34018 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731600AbeGZRgs (ORCPT ); Thu, 26 Jul 2018 13:36:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=igHps58fnSKIpDQXLFg095hEiyQmMKYAjiidMjft2bU=; b=Ufhy7BH2KQp8ud9FQw7Jta2+CElPda45iC2iY5z4u3Kh/9fx03Lw9amVw2qMPZfRopJ/v1DSFrDYZzUk43+aCJVvS+ssHhQp0p0DgI7lC1ychHc6uFJK4jUM4OVOfoPsdtzQNgsv1okHsMfgG0aajLrv4eGhOOPFSFdmr1H1XZE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:53 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v2 10/10] drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Thu, 26 Jul 2018 17:17:56 +0100 Message-Id: <20180726161756.1794-11-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3f69fe89-f1ff-4773-8ec4-08d5f3137b9e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;3:UScYIkrFbOHwud1NcWbdsEHd/RJggF1rOjMqWX1XWGpV6qEUPTEs7mv2wVz1LoCU58gYszvg1v/M5NyzRKS84HuqtQzNcoLrUSb2EQTjZ6Q3WhHfXKzbFNnwFTu6FjGAD1nANFXeKtgLNKaQyJWIQqVVdGZEeXOfyJi98P04ay5C4pcuTrdArZYYD6YxaaVwYjGA2mobVHHtKPikjB2b8xClge/77XiPI/ylFx7zW6mjU1l1cPsUaMTUV+HW3sT9;25:gzK6S0AIfMtqsG5JzyEJl6YZ5UllxyJB4/lPEcZh14xKc1PcL0xSLbmM87din+WGbHgip/pKKpJipKT8KG3d6zu5+C9vA82Evkl+KoYO9RG1HHtrwZbiWhHw07YjpVvFns94EEBZ3PCbXpIKmk+PwEhOksuxEM1hkx+sBru6X9StaRz0dAPdxjy45pXCA1UfzL0HPN1K9o2jWsJqByvC+2pK/Qj+RXY9dZ8ojgwq3i25s7nVFtsJLFrPMln1Gnb6dsHYtPHK4nyXjDDNQbjLp3HfXwO5396+UiuJdcU+GE4GuwFCLKESEQ9Q6dlleBrfcp9XJFexhX375HZLIp8kmA==;31:fDvbgv1WbsvJa5XkdWhOI3Lga4StgAkhMSsGUyTl/DLNT5F8lshFtp9m9K+Z3N+ULRzxAFK5Tqq0cpNtVbI9S0cP+Pm+H8L1IcLhnSLmL/AFlWPh6gFnMVkt+v6Wubd2MidtkW8Olkc8Ti+ogmx4ciGuhOAUNi5ZCCKmTr6GCxd+bggbidGM6r/bKDYyWnDewuy2LjSWDTzeL0zADib7lUTuIVP8JwQZpdv5bRoLYiA= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;20:16Bg8ojFgmjp8rTHFM0mlHR/HZW2bbqqsbZvoZSBM00mGgS+Mb1fcSqpgIcGPbsFmOMvQ5AytF8v7UK9sVQ+uCMMuI9RePblv67EFR/fPpguf6pxqltYjTOgqDil3K+CCHO/yopxCC22AR4Vj80Rb0aVSZl7+1nW+1UHG3KIqct+PAuyZeloRS6ZHJRqIM6KkMB2DmJ6UXHOD9cmg0rD0X4Tb43PTn/osYTLSoohZUl1LQIn67wZSkc/nvAOTz98Z1jEzLO5siTIddphHUDcK9iLczxw71UhUU2N/UDO+SG5VLigCR338EbIp1WDTaGHMFekr+VJ2S0awrYB/M6Yrg==;4:LzFIoUWeBVxnVv4cVyykz24Et90gcmK5NcO9yPXef6o45dKS7qqbyVACvhfqpNQ5Fl9OsWSpY3sU4CIZ2gxsk+XP+216tpTER6IcgZH98yh7LCC8kV2ksnJ5Um0I/tzLsLcNJmynhIB4cbguX0DP4hBcv5ncE6+AYXwH8R2J7L/v1+zPMTjAyTORHXi3wOa4gYJbTQHrTgWjzWKMchRSUAP4/TdsXArjr3Z1ZZ97sy+Dk0fbwtZHGsYtIHJFHHuDjmZ4K0CI4mBg1aNqRShrL0GSEiNzbg4rxe2ErB8eFPlTjyH6I3+dJC3DhVsLE0K6VEVdlULGOTboH93UoJCtCDdu458lJy/Zukutq8B8ZcY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(61668805478150)(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(1496009)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(575784001)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2552;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;23:KaGmsFPv9y91y3pE15T6Owy7DC7OAwKQOR9ms5CqdWM2AC7f1QEWYQd9OljvaNp558aeJ+m0CWRHnKacgrbnGhVWXPaGJl7IpF0lGz/4i6TAkRZogIi2cxai085bJ+FvCurYMwGuk2aZRk69hwiDhDwrEpy+SGSb+Usn6eBN/CgWO6vz97Vl4L6FcRzZo8UGDgaXy2aL0TxGSz6t5RegOP8I3n0MMq3LaPTi6psG81l/9L/PjEtB8fmYYWM3P2xts5NdE1oCvIPmWPf3hSdThm/UAAy6Hd654mX48+rodpZfgNQLl5xRdiUIec/EMppGDjkNZJmQY1Ww5xa2o49rZ5kEWFW645J8uYaxzVI5MXjdX05ftL8XhfrrpgC2VGtESVlNZ6Q7Ihsrt9Ge/X1KNSJfxOMqSeJ9uqJPoenHlZZWRoSNj530ZFAW9GJjg+JzPqndTeVzSl52ibZ0DA/e5PiyJ98w9qFKPySD8yTBJSH9k7J5TuGJQIzhLOYoIekZU3Fv0XhznIkszPVVSbPxclF8sHJEvopBPRt/uNLVGt0SWbnB8ueHkOdrazS608mlYHIQJ+jhSTVz3psmj//gGMqwYCfQLQ5I83pBvMx5p77fcYm52VM+p8m9FyVDGVeRz3tTQMFJKp4VgnKSUZIepm09XJROaAJx75ol/Ua00lrEut49WiPh9SdZ/LPUEKovqm0gewRdopm/IW4T0ttqza3je1moSMYmhrsD3r/gc30iRb5VlLNoV3y3bDTsJ3nAip2RqNujVFYajE/g7n2k/g1erq8Sl0cOUcBSgKvs8k7V7naPzgc0EIzZbpVaVAteb2h+Jx3nMj6ABYVCZUTQAsP7IFc2GTPTNxir7dtNgTnjPX730UnKqN/cGvuEp9eLqJ0pNeV5lQMLhupXe3UbOq6wU2A9W9V2btv+Vo/eQrZvKfXx7o7Bl4N3Sn/c6HQS8hGYYMcHzPO1Uy0EK850c9behQMr+Nl1hadryid9f3E8le0YvPQfdsMT10kSx143XaidQA3eSoHQajOda899ZpX7TPX7l9Hc+BhE3dvLUn+2hOwQuPqhB0DnUJF1tpniI4sJALxaW1ffQ4pudHD4p9dWhUMp8LTyETj4lY5Uou3Pn3xxkb+OI49YrsukBlKOQ3YdkM5tbCDr6nrAxDpTLGU9L+ZSMTPwWa8jbODHR2LgjXTC83F3Lr+o7IEYa2ogoySN4S5HLNpmkt3lt8nxOlRubbUbzZlnTDDcUdc2056FcIv271bKdfPR64kM2WTN X-Microsoft-Antispam-Message-Info: v6P+zb3+e9Z2C7bGEGAZVXK4Rkg0tGRnZbCKF40i4ofzT7p5trJ08MnhZPUxa/afsHbfq6/kTVFlpTRVYuFQKJtUKW2ywmiMhwR8TmyOgiVJZt8LJV9RwCp3SkHwxpjZBpEh8CvMFnBr05G8J0h1rgKXs8Wa44CxftA4Nzg0sy5D6z6lmp5O9Mg8XuuamKT8wMGu19cdfcEc9mfAZ5ZNg3xboJwiIuD+0B3Tn2thDL0zFNt9CyI10xaFiKDyvhCiyTZYo5wDZWaFfafG7kUXNwXf/Pll8aIZP4VzLBOclaGNl0TnsiUtT0l1Hs/tFtyGDN8Y60qAF87WvO4Uwa13wWWa71mxZZ0s4NaEPVVzFfg= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;6:QUODnvBwsicvoAIF2oxHwVOzWXQFp5aW8xIeUbg/Z8YhiGteoTu5KUoVbWGp0GVuPSyFbuDQC0YOBlXP5LkPMwpt8RZm747cXnLCj8+pAefzUQ5z8xvgcz8KQLCcYZ2XP+qLjk/X1xCcpyeGLsDnL9d3IA82gQ24unwkXoSoeQhp6x/LJIMy3I4M/Ib6784EOqaPg+5870+22u3u7Hmu6JGEEb9sjA4ODrLPVnze84j3zc573b7vNJwMpBIqyyEvqTupwqUB3WkH9LXMLdNNrursV5Rq6sRs6YdqKhzoi62WFmdQlfQo1Eov4kykl0YhNhWrBZoKN+RSH6kTb969gJAIE/hk3cucu8ZhU2PNMIFh/WZxX4maja7GHFqU0prjDO438L6vOX2VJjZckY+ArtLSLJS4Sa89FK84lFeQqkpgPX84tMwMAB0o6XveAh2PlXhz6cT1xvqsGLsKE1g7qw==;5:2QvkH2t5fItWms/BaXlKdactGvjTIJyMEwLKx6jFwWg+qImIc4tANGD54u6qsebJdOfgSRHcu+vy0jy4RCfhK5eHco8xIGbD2tY5qvOLYnIG/L5H9dvgxAlD7JodC6mJrcRVHVMFmH76fOtJNEQtxTRZZyBuPqMn7oUZR7AifQc=;7:MF90su3od3hBcM+fQ34vGUY2vMc430FeTpgqJpiIAvU/MMeiYWGVjJNJGsw27pUzkjZFDk2iQl/NZHBp/7ux2uIQz2g87SpfzeMWOuqPmxR4mXBKu7osE8dTuOgGoGSLFwknltFT1lHAvsMNE4x6DMRXuXudQTwDQMgAvgsDDwmSqMp0TPkPCPD5+54fFOqMGcFp5vbkb9Q3YRiBvLt1YTupvX/kk3Xcsgmft/Urx+42WrW/mHfkhXFQJnVLAX1U SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:53.2338 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3f69fe89-f1ff-4773-8ec4-08d5f3137b9e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. Reviewed-by: Sinclair Yeh Reviewed-by: Deepak Rawat Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c index 4a0f0f41afa1..61824e360619 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -720,9 +720,7 @@ void vmw_du_plane_reset(struct drm_plane *plane) return; } - plane->state = &vps->base; - plane->state->plane = plane; - plane->state->rotation = DRM_MODE_ROTATE_0; + __drm_atomic_helper_plane_reset(plane, &vps->base); }