From patchwork Tue Dec 3 10:35:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270939 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4D58A159A for ; Tue, 3 Dec 2019 10:35:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2BEC12073B for ; Tue, 3 Dec 2019 10:35:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zusgn0Ca" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725773AbfLCKfa (ORCPT ); Tue, 3 Dec 2019 05:35:30 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:34500 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfLCKf3 (ORCPT ); Tue, 3 Dec 2019 05:35:29 -0500 Received: by mail-lf1-f67.google.com with SMTP id l18so2529240lfc.1 for ; Tue, 03 Dec 2019 02:35:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UlloWdexl+9O5OkTNnM3Udk0+LESBNPOa46PpvzWRgk=; b=Zusgn0CaacQbbc8XpRPSOyNTt6jmZQwWk7cSMh5M9fLvDooFpGR8Eg8pWGo0yelduX q+E+lzKFXByc7jWx4X0JAk9CMII6RTp/tSsA1OWm22NTurVLlpXl1tNr1CutMoGMEO2G ZnsxLGfa7UFd5NTEuetMqfBClxSshPo58sBRXvK/TOqjP8Jb01hSiWwRThaGFGywfJMA XakLyy3Vh8lIGSJQ6M4rLYc5olHAudvNmCj3VFqY5oGXWgyvlWUmv97LL2QrLlOEUazF ECmSeLVfqxAW7rJ3BJ7MfsX8yjz8zdQd4kuI0LwDwv2t0x1chWSeZ41BjRigu2oX66g/ 0dpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UlloWdexl+9O5OkTNnM3Udk0+LESBNPOa46PpvzWRgk=; b=sIAJRtNNZuxuOb2/cyASRWySFlkfR298BNQSyAdzgmu4YtjrkaEPNA5FkDtHmetCO9 uOkDT0t6ZhuqILMno3uGef36aQiJ4aow2RoAvuBTVT/MPW5w73cBux2O+NcpWT6zDndA t3NxAUdZrfoDyvngq7NImZrHKqKRBKmj9hoJQfNKy3Ya4wwmTMDWZw5wmGKGgqGyaIma w0mYf2UgmDU8ZUcOu8Qxn6WgtJWOHHnlUFyWiYusWuz4QFzGN2X8+jBEg4MUnBYrCfmU uajKucfHe4X5U0OK7FpEOvpbpk2+jzHGLzMCx51/yCV2CMJCM0jzplkmk/HzLYZPtPht z+yg== X-Gm-Message-State: APjAAAVYYq22Te6TuWPtn5Q5GCRyKhdcxci4Y/QntV21NJCvM9wOVty6 jcjJ7muBUhN3qHc4qOVTUjg= X-Google-Smtp-Source: APXvYqzuEd/BmNS0iaPdkm/fQghoc0awpjCYfviGNxpWkWtfK088H7nbUs6SAZ9qkZqdyW+He9vGWw== X-Received: by 2002:ac2:455c:: with SMTP id j28mr2369225lfm.184.1575369327539; Tue, 03 Dec 2019 02:35:27 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:26 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 01/18] trace-cmd: Implement new lib API: tracecmd_local_events_system() Date: Tue, 3 Dec 2019 12:35:05 +0200 Message-Id: <20191203103522.482684-2-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org From: Tzvetomir Stoyanov The new tracecmd lib API tracecmd_local_events_system() creates a tep handler and initializes it with the events of the specified subsystems. Signed-off-by: Tzvetomir Stoyanov --- include/trace-cmd/trace-cmd.h | 4 +- lib/trace-cmd/trace-util.c | 102 +++++++++++++++++++++++----------- 2 files changed, 72 insertions(+), 34 deletions(-) diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 13afce7..9363a26 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -27,8 +27,10 @@ extern int tracecmd_disable_plugins; char **tracecmd_event_systems(const char *tracing_dir); char **tracecmd_system_events(const char *tracing_dir, const char *system); struct tep_handle *tracecmd_local_events(const char *tracing_dir); +struct tep_handle *tracecmd_local_events_system(const char *tracing_dir, + const char * const *sys_names); int tracecmd_fill_local_events(const char *tracing_dir, - struct tep_handle *pevent, int *parsing_failures); + struct tep_handle *tep, int *parsing_failures); char **tracecmd_local_plugins(const char *tracing_dir); char **tracecmd_add_list(char **list, const char *name, int len); diff --git a/lib/trace-cmd/trace-util.c b/lib/trace-cmd/trace-util.c index b5bb0d5..49a80ae 100644 --- a/lib/trace-cmd/trace-util.c +++ b/lib/trace-cmd/trace-util.c @@ -616,39 +616,20 @@ static int read_header(struct tep_handle *pevent, const char *events_dir) return ret; } -/** - * tracecmd_local_events - create a pevent from the events on system - * @tracing_dir: The directory that contains the events. - * - * Returns a pevent structure that contains the pevents local to - * the system. - */ -struct tep_handle *tracecmd_local_events(const char *tracing_dir) +static bool contains(const char *name, const char * const *names) { - struct tep_handle *pevent = NULL; - - pevent = tep_alloc(); - if (!pevent) - return NULL; - - if (tracecmd_fill_local_events(tracing_dir, pevent, NULL)) { - tep_free(pevent); - pevent = NULL; - } - - return pevent; + if (!names) + return false; + for (; *names; names++) + if (strcmp(name, *names) == 0) + return true; + return false; } -/** - * tracecmd_fill_local_events - Fill a pevent with the events on system - * @tracing_dir: The directory that contains the events. - * @pevent: Allocated pevent which will be filled - * @parsing_failures: return number of failures while parsing the event files - * - * Returns whether the operation succeeded - */ -int tracecmd_fill_local_events(const char *tracing_dir, - struct tep_handle *pevent, int *parsing_failures) +static int tracecmd_fill_local_events_system(const char *tracing_dir, + struct tep_handle *tep, + const char * const *sys_names, + int *parsing_failures) { struct dirent *dent; char *events_dir; @@ -677,7 +658,7 @@ int tracecmd_fill_local_events(const char *tracing_dir, goto out_free; } - ret = read_header(pevent, events_dir); + ret = read_header(tep, events_dir); if (ret < 0) { ret = -1; goto out_free; @@ -690,7 +671,8 @@ int tracecmd_fill_local_events(const char *tracing_dir, if (strcmp(name, ".") == 0 || strcmp(name, "..") == 0) continue; - + if (sys_names && !contains(name, sys_names)) + continue; sys = append_file(events_dir, name); ret = stat(sys, &st); if (ret < 0 || !S_ISDIR(st.st_mode)) { @@ -698,7 +680,7 @@ int tracecmd_fill_local_events(const char *tracing_dir, continue; } - ret = load_events(pevent, name, sys); + ret = load_events(tep, name, sys); free(sys); @@ -716,6 +698,60 @@ int tracecmd_fill_local_events(const char *tracing_dir, return ret; } +/** + * tracecmd_local_events_system - create a tep from the events of the specified subsystem. + * + * @tracing_dir: The directory that contains the events. + * @sys_name: Array of system names, to load the events from. + * The last element from the array must be NULL + * + * Returns a tep structure that contains the tep local to + * the system. + */ +struct tep_handle *tracecmd_local_events_system(const char *tracing_dir, + const char * const *sys_names) +{ + struct tep_handle *tep = NULL; + + tep = tep_alloc(); + if (!tep) + return NULL; + + if (tracecmd_fill_local_events_system(tracing_dir, tep, sys_names, NULL)) { + tep_free(tep); + tep = NULL; + } + + return tep; +} + +/** + * tracecmd_local_events - create a pevent from the events on system + * @tracing_dir: The directory that contains the events. + * + * Returns a pevent structure that contains the pevents local to + * the system. + */ +struct tep_handle *tracecmd_local_events(const char *tracing_dir) +{ + return tracecmd_local_events_system(tracing_dir, NULL); +} + +/** + * tracecmd_fill_local_events - Fill a pevent with the events on system + * @tracing_dir: The directory that contains the events. + * @tep: Allocated tep handler which will be filled + * @parsing_failures: return number of failures while parsing the event files + * + * Returns whether the operation succeeded + */ +int tracecmd_fill_local_events(const char *tracing_dir, + struct tep_handle *tep, int *parsing_failures) +{ + return tracecmd_fill_local_events_system(tracing_dir, tep, + NULL, parsing_failures); +} + /** * tracecmd_local_plugins - returns an array of available tracer plugins * @tracing_dir: The directory that contains the tracing directory From patchwork Tue Dec 3 10:35:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270933 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0B9A3138C for ; Tue, 3 Dec 2019 10:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DE61A2073C for ; Tue, 3 Dec 2019 10:35:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I1ZzpfB8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726079AbfLCKfa (ORCPT ); Tue, 3 Dec 2019 05:35:30 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:43903 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbfLCKfa (ORCPT ); Tue, 3 Dec 2019 05:35:30 -0500 Received: by mail-lj1-f195.google.com with SMTP id a13so3145122ljm.10 for ; Tue, 03 Dec 2019 02:35:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2UB+7TyCvOxtXN0b6w3H+2SysAGSr92bcpZfqsJmkPw=; b=I1ZzpfB83cTeq8pttGslT9FhnihpTTkkEvMB4+2A8hnvsgUcVBxrjaojQQiJCcnWM7 5mY/Stpr82tK3X+GuG6g5PTnlUVrLbc0E6SEUCbbsavqK0ufSAqPqr/7xapr9MQNmVRK u7p+HOrMQEy4XO0lWqcOyBovOJmX44lyqwiDMgCKKXj0T7oBRyAvvTVBQfOEx+LsiD1B weVd6clEHtqmotQpNdvBjr2xQFGAKbkOXgTSkl4eeOVg5kyIyafxhw/bkKV8OsQmOYJg jSQKe8HRJMmujtXU2oqjCrAdjM6u9k7H0yX+P3Cy95RJeCOwsCxOv+wkSkgtBLr/KU1e 9n3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2UB+7TyCvOxtXN0b6w3H+2SysAGSr92bcpZfqsJmkPw=; b=cVpmajaEiLsBB/dRl3cWBnL1w34W7+tBuRrbNc89/SFAGy8gdSgUh1Knlrh9I9Q3M2 nUVV8xVHvLmMqjOMYGMBWvPjl1uC+NtvMw/oboXB85mId/N/MZ6MFlSrH+SHPKmpOZnc RS3gFWWOhtZPgAWIyqogFOEvSQqlST+EVkdetgm1VXgHsERLj8QTei47k7Dg+nHrVPPf Izz6IWBzn8a7u7hN+MQmYrEOOxPzjD52sNS/z0+cRFclhaMTMwlDaZWOuz03FPzhEeu4 NXMprtFc8MDgxxkN0n7PFVYufjNHbxeLBC+lwrMQXzEOodgSe47FU2CccWlThpdW8I87 QhiA== X-Gm-Message-State: APjAAAUus6q4hQok3OEa8PCHOH+XHVhi+rIi8WEBl2rjXlcygKiICebI QP6rj9qV11F8wg6xGJFOutK6HfU1X0k= X-Google-Smtp-Source: APXvYqxGRuvabwsugNJkz44iYqu76AzHXC67F3A71YpEYh/VnHvVSZ+FVa+Par/QdivLWuNwk/MikA== X-Received: by 2002:a2e:8953:: with SMTP id b19mr1903890ljk.249.1575369328711; Tue, 03 Dec 2019 02:35:28 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:28 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 02/18] trace-cmd: Add support for negative time offsets in trace.dat file Date: Tue, 3 Dec 2019 12:35:06 +0200 Message-Id: <20191203103522.482684-3-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org From: Tzvetomir Stoyanov When synchronizing timestamps between different machines, there are cases when the time offset is negative. This patch changes the way time offset is written and read from trace.dat file - as signed decimal, instead of hex. Signed-off-by: Tzvetomir Stoyanov --- include/trace-cmd/trace-cmd.h | 2 +- lib/trace-cmd/trace-input.c | 6 +++--- tracecmd/trace-read.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 9363a26..7f9cb73 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -138,7 +138,7 @@ const char *tracecmd_buffer_instance_name(struct tracecmd_input *handle, int ind struct tracecmd_input *tracecmd_buffer_instance_handle(struct tracecmd_input *handle, int indx); int tracecmd_is_buffer_instance(struct tracecmd_input *handle); -void tracecmd_set_ts_offset(struct tracecmd_input *handle, unsigned long long offset); +void tracecmd_set_ts_offset(struct tracecmd_input *handle, long long offset); void tracecmd_set_ts2secs(struct tracecmd_input *handle, unsigned long long hz); void tracecmd_print_events(struct tracecmd_input *handle, const char *regex); diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c index 3b187e3..91362f3 100644 --- a/lib/trace-cmd/trace-input.c +++ b/lib/trace-cmd/trace-input.c @@ -90,7 +90,7 @@ struct tracecmd_input { bool read_page; bool use_pipe; struct cpu_data *cpu_data; - unsigned long long ts_offset; + long long ts_offset; double ts2secs; char * cpustats; char * uname; @@ -2127,7 +2127,7 @@ static int init_cpu(struct tracecmd_input *handle, int cpu) } void tracecmd_set_ts_offset(struct tracecmd_input *handle, - unsigned long long offset) + long long offset) { handle->ts_offset = offset; } @@ -2305,7 +2305,7 @@ tracecmd_search_task_map(struct tracecmd_input *handle, static int handle_options(struct tracecmd_input *handle) { - unsigned long long offset; + long long offset; unsigned short option; unsigned int size; char *cpustats = NULL; diff --git a/tracecmd/trace-read.c b/tracecmd/trace-read.c index c0d640d..4ce2e98 100644 --- a/tracecmd/trace-read.c +++ b/tracecmd/trace-read.c @@ -58,7 +58,7 @@ static struct list_head handle_list; struct input_files { struct list_head list; const char *file; - unsigned long long tsoffset; + long long tsoffset; unsigned long long ts2secs; }; static struct list_head input_files; @@ -1466,7 +1466,7 @@ void trace_report (int argc, char **argv) struct input_files *inputs; struct handle_list *handles; enum output_type otype; - unsigned long long tsoffset = 0; + long long tsoffset = 0; unsigned long long ts2secs = 0; unsigned long long ts2sc; int show_stat = 0; From patchwork Tue Dec 3 10:35:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270937 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 79D79184E for ; Tue, 3 Dec 2019 10:35:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 592F2206F0 for ; Tue, 3 Dec 2019 10:35:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a9Bbf3hs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725997AbfLCKfc (ORCPT ); Tue, 3 Dec 2019 05:35:32 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:42782 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfLCKfc (ORCPT ); Tue, 3 Dec 2019 05:35:32 -0500 Received: by mail-lj1-f193.google.com with SMTP id e28so3151816ljo.9 for ; Tue, 03 Dec 2019 02:35:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xcPmnM5x0UQ4YKDSV2MogiGotivYJlB+VWUCe41AAqY=; b=a9Bbf3hsMiJUWAwE0nwQ2dzVlSoh39i+NrwcYGCt+k3iBQBYYqDoVl4fhPj74tMUoq b0C3vt9FC37s65kZ7LVIW3uMzPpt0U9gWl2Jf15/+b5T9mm//w6k1wMjQ8Cq5I6ZnqyJ XtyGrA2T6GJE9C3bA8x1txU9g4rN8XkvTOA7UNf7HhpAe8vudYYEkHRq8rHd2vvD8pUp EMYjfyVKB03zqcDUSxq40l0Zzs/ct066tflTj4K7wFqapiCYg3U9RA+zerutedT39FmR W+BoARFZiMup29C3B81+9rM77EM6ha9GxPy1xk3vKCa6gLaxXDUtShi1PvO+FawjrWsx FJBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xcPmnM5x0UQ4YKDSV2MogiGotivYJlB+VWUCe41AAqY=; b=FBvgOzldAJI/VpI+nOppGr+bMG6iAfPv0SFG4MU4BEdWRI8+zyifNgh4hJbmfUTz9P QnlFDhvDpgIuTAE8FQXxBC0ijpCBD1JAEafiyc3DnARjevTt9KvynUtr8/pmjo/p9xb2 tstKc75Lg26PZAGU2Yj3uGV5UahSu27+7ZcVTJb2uUcHY8HVti09v2vJa7cTWq/cWvjo BzqEpZaKsv6RXytOGYdAaJVGsV5nCFlCFDX8JbYzw6nrUkZS8Yi/ae4TbDvUmjm/zh9V /8vv23+MfVf43vh0QbUt/8+zfSlrz/1Xnl4Wf++XcnC5EkS7PnqNPTBVTw3pZgXR0AeV h3Ow== X-Gm-Message-State: APjAAAUK9nV3we7Gjd5fa5lUMRAepRKveVwVntdLqcJErImXJkx6tbIx 9REUzbqEVsCuHjwxUvTL13I= X-Google-Smtp-Source: APXvYqyFT25Tl2N+MCuYwIUPKEP2LhaUO+Xm5G6kjN2px694ycj1wI6PQcljD7Fg4kV4wilKM0FE0A== X-Received: by 2002:a05:651c:112c:: with SMTP id e12mr2158080ljo.169.1575369329821; Tue, 03 Dec 2019 02:35:29 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:29 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 03/18] trace-cmd: Add implementations of htonll() and ntohll() Date: Tue, 3 Dec 2019 12:35:07 +0200 Message-Id: <20191203103522.482684-4-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org From: Tzvetomir Stoyanov Implementations of htonll() and ntohll() are added as macros, if they are not already defined. Signed-off-by: Tzvetomir Stoyanov --- include/trace-cmd/trace-msg.h | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/include/trace-cmd/trace-msg.h b/include/trace-cmd/trace-msg.h index aab8a69..654ca43 100644 --- a/include/trace-cmd/trace-msg.h +++ b/include/trace-cmd/trace-msg.h @@ -12,4 +12,14 @@ extern unsigned int page_size; +#ifndef htonll +# if __BYTE_ORDER == __LITTLE_ENDIAN +#define htonll(x) __bswap_64(x) +#define ntohll(x) __bswap_64(x) +#else +#define htonll(x) (x) +#define ntohll(x) (x) +#endif +#endif + #endif /* _TRACE_MSG_H_ */ From patchwork Tue Dec 3 10:35:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270945 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D1B771922 for ; Tue, 3 Dec 2019 10:35:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92C832073F for ; Tue, 3 Dec 2019 10:35:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HRS8BFCz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725774AbfLCKfh (ORCPT ); Tue, 3 Dec 2019 05:35:37 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:43915 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfLCKfh (ORCPT ); Tue, 3 Dec 2019 05:35:37 -0500 Received: by mail-lj1-f195.google.com with SMTP id a13so3145324ljm.10 for ; Tue, 03 Dec 2019 02:35:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8BtKYTA6xxHKi5JJuPFRfKVPOtDulvCy35nEYDQfeZ0=; b=HRS8BFCz8Ngol9d5MLGs/bvYYF9p3iS1/56/ficRkkoLueqOgj7aItTGgZ32EhwNuC QsgEKrKnHXeur/N0p5p4SvWcGMgYXveJC8fJ9G+TZctx+Ad/9Fv7MYOXVDfgEbg4OuDZ UM7VQxijASYFbCB/7npwDJXRhBB6DdaEJIhI+56EJqAptU/Tbf9n7I+mNafPLo18cvoN RqvUnu8X5bj1pprjBIyFo2oalp711I70pfjxVGcnt6NzMAVjptA8JyG3Q+ekIPMYFuGs xgHgf4NhgqIofvNoEHBNyzeGAqnq7d07klRYcBJ0Gmrqj1NzcqOe1pVdC4lSC5HGi/cs AQqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8BtKYTA6xxHKi5JJuPFRfKVPOtDulvCy35nEYDQfeZ0=; b=RZFxP5F2gDTXuNKFe4FenwDG1VDz1rabgCQPWXTM3MyNTToFpKQVSHtHisZZr6mIV2 NHNoDig7GXp+k2SRc2Ksd4ih/2oO+NxRu8tK7QRSPYp+T3jw8Fel37J6kNbq2FjQiA74 U7dIcDGsSr+YYW24f3FURPxTdWV3nBBhSEs4V3fDEV35sZVHRhPtTx7cqPuQEi19eQxZ xjM64OJIf66dakQJrllM07gdG5Ues7SlcYuRuyLByznVs4bCmR36Ct6920qq3raS2EqJ FCRLj+2zFRuzeWduHHqGgO9UsiClq56BtfTDSISewnGzOluNKvNxWMcZJDvc4qleq87Q cArQ== X-Gm-Message-State: APjAAAWmOUKFkX6jhnRmnwokPC49qSgqSP0ubiLxr/tIJ64S5nXQI2Sy e66wELVeR8J3+GVmh7qk778= X-Google-Smtp-Source: APXvYqw3XMzqYVQ0t5mR7BhvDvEyQuM98j7hiOVbzk5MpriZ7A6YxvcAmidTn2kpLlq+4F6uoI+Qig== X-Received: by 2002:a2e:9b95:: with SMTP id z21mr1827613lji.112.1575369331487; Tue, 03 Dec 2019 02:35:31 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:30 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 04/18] trace-cmd: Add new library APIs for ftrace instances. Date: Tue, 3 Dec 2019 12:35:08 +0200 Message-Id: <20191203103522.482684-5-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org From: Tzvetomir Stoyanov In order to reuse the code, the functionality related to ftrace instances is moved from trace-cmd application to libtracecmd. The following new library APIs are introduced: library structure, representing a ftrace instance: struct tracecmd_instance { char *name; char *clock; }; APIs for creating and deleting ftrace instances: struct tracecmd_instance *tracecmd_create_instance(const char *name); void tracecmd_free_instance(struct tracecmd_instance *instance); int tracecmd_make_instance(struct tracecmd_instance *instance); void tracecmd_remove_instance(struct tracecmd_instance *instance); APIs for reading and writing ftrace files, instance aware: char *tracecmd_get_instance_file(struct tracecmd_instance *instance, const char *file); char *tracecmd_get_instance_dir(struct tracecmd_instance *instance); int tracecmd_write_instance_file(struct tracecmd_instance *instance, const char *file, const char *str, const char *type); int tracecmd_write_file(const char *file, const char *str, const char *type); char *tracecmd_read_instance_file(struct tracecmd_instance *instance, char *file, int *psize); API for setting ftrace clock, instance aware: void tracecmd_set_clock(struct tracecmd_instance *instance, char **old_clock); Signed-off-by: Tzvetomir Stoyanov (VMware) --- include/trace-cmd/trace-cmd.h | 24 ++ lib/trace-cmd/Makefile | 1 + lib/trace-cmd/include/trace-cmd-local.h | 33 +-- lib/trace-cmd/trace-instance.c | 265 ++++++++++++++++++ lib/trace-cmd/trace-util.c | 71 ++++- tracecmd/include/trace-local.h | 6 +- tracecmd/trace-list.c | 2 +- tracecmd/trace-record.c | 341 +++++++----------------- tracecmd/trace-show.c | 2 + tracecmd/trace-stat.c | 20 +- 10 files changed, 472 insertions(+), 293 deletions(-) create mode 100644 lib/trace-cmd/trace-instance.c diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 7f9cb73..5287d23 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -356,6 +356,30 @@ int tracecmd_msg_send_trace_resp(struct tracecmd_msg_handle *msg_handle, int tracecmd_msg_recv_trace_resp(struct tracecmd_msg_handle *msg_handle, int *nr_cpus, int *page_size, unsigned int **ports, bool *use_fifos); +/* --- ftrace instances --- */ + +struct tracecmd_instance { + char *name; + char *clock; +}; + +struct tracecmd_instance *tracecmd_create_instance(const char *name); +void tracecmd_free_instance(struct tracecmd_instance *instance); +int tracecmd_make_instance(struct tracecmd_instance *instance); +void tracecmd_remove_instance(struct tracecmd_instance *instance); +char * +tracecmd_get_instance_file(struct tracecmd_instance *instance, const char *file); +char *tracecmd_get_instance_dir(struct tracecmd_instance *instance); +int tracecmd_write_instance_file(struct tracecmd_instance *instance, + const char *file, const char *str, + const char *type); + +int tracecmd_write_file(const char *file, const char *str, const char *type); +char *tracecmd_read_instance_file(struct tracecmd_instance *instance, + char *file, int *psize); + +void tracecmd_set_clock(struct tracecmd_instance *instance, char **old_clock); + /* --- Plugin handling --- */ extern struct tep_plugin_option trace_ftrace_options[]; diff --git a/lib/trace-cmd/Makefile b/lib/trace-cmd/Makefile index 3b4b5aa..18c7013 100644 --- a/lib/trace-cmd/Makefile +++ b/lib/trace-cmd/Makefile @@ -13,6 +13,7 @@ OBJS += trace-input.o OBJS += trace-output.o OBJS += trace-recorder.o OBJS += trace-util.o +OBJS += trace-instance.o OBJS += trace-filter-hash.o OBJS += trace-msg.o diff --git a/lib/trace-cmd/include/trace-cmd-local.h b/lib/trace-cmd/include/trace-cmd-local.h index 09574db..eef4d39 100644 --- a/lib/trace-cmd/include/trace-cmd-local.h +++ b/lib/trace-cmd/include/trace-cmd-local.h @@ -18,36 +18,7 @@ #define STR(x) _STR(x) #define FILE_VERSION_STRING STR(FILE_VERSION) -static ssize_t __do_write(int fd, const void *data, size_t size) -{ - ssize_t tot = 0; - ssize_t w; - - do { - w = write(fd, data + tot, size - tot); - tot += w; - - if (!w) - break; - if (w < 0) - return w; - } while (tot != size); - - return tot; -} - -static ssize_t -__do_write_check(int fd, const void *data, size_t size) -{ - ssize_t ret; - - ret = __do_write(fd, data, size); - if (ret < 0) - return ret; - if (ret != size) - return -1; - - return 0; -} +ssize_t __do_write_check(int fd, const void *data, size_t size); +void __noreturn die(const char *fmt, ...); /* Can be overriden */ #endif /* _TRACE_CMD_LOCAL_H */ diff --git a/lib/trace-cmd/trace-instance.c b/lib/trace-cmd/trace-instance.c new file mode 100644 index 0000000..1175b8c --- /dev/null +++ b/lib/trace-cmd/trace-instance.c @@ -0,0 +1,265 @@ +// SPDX-License-Identifier: LGPL-2.1 +/* + * Copyright (C) 2019, VMware, Tzvetomir Stoyanov tz.stoyanov@gmail.com> + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +#include "trace-cmd.h" +#include "trace-cmd-local.h" + +/** + * tracecmd_put_tracing_file - Free tracing file / dir, created by + * tracecmd_get_instance_dir() or tracecmd_get_instance_file() + * APIs. + *@name: The name of the tracing file or dir + */ +void tracecmd_put_tracing_file(char *name) +{ + free(name); +} + +/** + * tracecmd_create_instance - allocate a new ftrace instance + * @name: The name of the instance (instance will point to this) + * + * Returns a newly allocated instance. Note that @name will not be + * copied, and the instance buffer will point to the string itself. + */ +struct tracecmd_instance *tracecmd_create_instance(const char *name) +{ + struct tracecmd_instance *instance; + + instance = malloc(sizeof(*instance)); + if (!instance) + return NULL; + memset(instance, 0, sizeof(*instance)); + if (name) + instance->name = strdup(name); + + return instance; +} + +/** + * tracecmd_free_instance - Free an instance struct, previously allocated by + * tracecmd_create_instance(). + *@instance: Pointer to the instance to be freed + * + */ +void tracecmd_free_instance(struct tracecmd_instance *instance) +{ + if (!instance) + return; + + free(instance->name); + free(instance); +} + +/** + * tracecmd_make_instance - Create a new ftrace instance + * @instance: Pointer to the instance to be created + * + * Returns -1 in case of an erro, or 0 otherwise. + */ +int tracecmd_make_instance(struct tracecmd_instance *instance) +{ + struct stat st; + char *path; + int ret; + + path = tracecmd_get_instance_dir(instance); + ret = stat(path, &st); + if (ret < 0) { + ret = mkdir(path, 0777); + if (ret < 0) + return ret; + + } else + ret = 1; + tracecmd_put_tracing_file(path); + return ret; +} + +/** + * tracecmd_remove_instance - Remove a ftrace instance + * @instance: Pointer to the instance to be removed + * + */ +void tracecmd_remove_instance(struct tracecmd_instance *instance) +{ + char *path; + + path = tracecmd_get_instance_dir(instance); + rmdir(path); + tracecmd_put_tracing_file(path); +} + +/** + * tracecmd_get_instance_file - return the path to a instance file. + * @instance: buffer instance for the file, can be NULL for the top instance + * @file: name of file to return + * + * Returns the path name of the @file for the given @instance. + * + * Must use tracecmd_put_tracing_file() to free the returned string. + */ +char * +tracecmd_get_instance_file(struct tracecmd_instance *instance, const char *file) +{ + char *path; + char *buf; + int ret; + + if (instance && instance->name) { + ret = asprintf(&buf, "instances/%s/%s", instance->name, file); + if (ret < 0) + die("Failed to allocate name for %s/%s", instance->name, file); + path = tracecmd_get_tracing_file(buf); + free(buf); + } else + path = tracecmd_get_tracing_file(file); + + return path; +} + +/** + * tracecmd_get_instance_file - return the path to a instance file. + * @instance: buffer instance for the file, can be NULL for the top instance + * @file: name of file to return + * + * Returns the path name of the @file for the given @instance. + * + * Must use tracecmd_put_tracing_file() to free the returned string. + */ +char *tracecmd_get_instance_dir(struct tracecmd_instance *instance) +{ + char *buf; + char *path; + int ret; + + if (instance->name) { + ret = asprintf(&buf, "instances/%s", instance->name); + if (ret < 0) + die("Failed to allocate for instance %s", instance->name); + path = tracecmd_get_tracing_file(buf); + free(buf); + } else + path = tracecmd_find_tracing_dir(); + + return path; +} + +/** + * tracecmd_write_instance_file - Write in trace file of specific instance. + * @instance: buffer instance for the file, can be NULL for the top instance + * @file: name of the file + * @str: Null terminated string, that will be written in the file. + * @type: Null terminated string, describing the current write operation. + * Used for logging purposes. + * + * Returns the number of written bytes, or -1 in case of an error + */ +int tracecmd_write_instance_file(struct tracecmd_instance *instance, + const char *file, const char *str, + const char *type) +{ + struct stat st; + char *path; + int ret; + + path = tracecmd_get_instance_file(instance, file); + ret = stat(path, &st); + if (ret == 0) + ret = tracecmd_write_file(path, str, type); + tracecmd_put_tracing_file(path); + + return ret; +} + +/** + * tracecmd_read_instance_file - Read from a trace file of specific instance. + * @instance: buffer instance for the file, can be NULL for the top instance + * @file: name of the file + * @psize: Returns the number of bytes read. + * + * Returns a pointer to a NULL terminated string, read from the file, or NULL in + * case of an error. + */ +char *tracecmd_read_instance_file(struct tracecmd_instance *instance, + char *file, int *psize) +{ + char buffer[BUFSIZ]; + int size = 0; + char *path; + char *buf; + int fd; + int r; + + path = tracecmd_get_instance_file(instance, file); + fd = open(path, O_RDONLY); + tracecmd_put_tracing_file(path); + if (fd < 0) { + warning("File %s not found", file); + return NULL; + } + do { + r = read(fd, buffer, BUFSIZ); + if (r <= 0) + continue; + if (size) + buf = realloc(buf, size+r+1); + else + buf = malloc(r+1); + if (!buf) + die("Failed to allocate instance file buffer"); + memcpy(buf+size, buffer, r); + size += r; + } while (r); + + buf[size] = '\0'; + if (psize) + *psize = size; + return buf; +} + +/** + * tracecmd_set_clock - Set the clock of ftrace event's timestamps, per instance. + * @instance: Pointer to ftrace instance, containing the desired clock. + * @old_clock: Optional, return the newly allocated string with the old clock. + * + */ +void tracecmd_set_clock(struct tracecmd_instance *instance, char **old_clock) +{ + char *content; + char *str; + + if (!instance->clock) + return; + + /* The current clock is in brackets, reset it when we are done */ + content = tracecmd_read_instance_file(instance, "trace_clock", NULL); + + /* check if first clock is set */ + if (*content == '[') + str = strtok(content+1, "]"); + else { + str = strtok(content, "["); + if (!str) + die("Can not find clock in trace_clock"); + str = strtok(NULL, "]"); + } + if (old_clock) + *old_clock = strdup(str); + + free(content); + tracecmd_write_instance_file(instance, + "trace_clock", instance->clock, "clock"); +} diff --git a/lib/trace-cmd/trace-util.c b/lib/trace-cmd/trace-util.c index 49a80ae..4c70d9a 100644 --- a/lib/trace-cmd/trace-util.c +++ b/lib/trace-cmd/trace-util.c @@ -918,11 +918,6 @@ char *tracecmd_get_tracing_file(const char *name) return file; } -void tracecmd_put_tracing_file(char *name) -{ - free(name); -} - void __noreturn __vdie(const char *fmt, va_list ap) { int ret = errno; @@ -967,6 +962,38 @@ void __weak *malloc_or_die(unsigned int size) return data; } + +static ssize_t __do_write(int fd, const void *data, size_t size) +{ + ssize_t tot = 0; + ssize_t w; + + do { + w = write(fd, data + tot, size - tot); + tot += w; + + if (!w) + break; + if (w < 0) + return w; + } while (tot != size); + + return tot; +} + +ssize_t +__do_write_check(int fd, const void *data, size_t size) +{ + ssize_t ret; + + ret = __do_write(fd, data, size); + if (ret < 0) + return ret; + if (ret != size) + return -1; + + return 0; +} #define LOG_BUF_SIZE 1024 static void __plog(const char *prefix, const char *fmt, va_list ap, FILE *fp) { @@ -1084,3 +1111,37 @@ int tracecmd_stack_tracer_status(int *status) *status = num; return 1; /* full success */ } + +/* + * tracecmd_write_file - Write in trace file + * @file: Full name of the trace file. + * @str: Null terminated string, that will be written in the file. + * @type: Null terminated string, describing the current write operation. + * Used for logging purposes. + * + * Returns the number of written bytes, or -1 in case of an error + */ +int tracecmd_write_file(const char *file, const char *str, const char *type) +{ + char buf[BUFSIZ]; + int ret; + int fd; + + fd = open(file, O_WRONLY | O_TRUNC); + if (fd < 0) + die("opening to '%s'", file); + ret = write(fd, str, strlen(str)); + close(fd); + if (ret < 0 && type) { + /* write failed */ + fd = open(file, O_RDONLY); + if (fd < 0) + die("writing to '%s'", file); + /* the filter has the error */ + while ((ret = read(fd, buf, BUFSIZ)) > 0) + fprintf(stderr, "%.*s", ret, buf); + die("Failed %s of %s\n", type, file); + close(fd); + } + return ret; +} diff --git a/tracecmd/include/trace-local.h b/tracecmd/include/trace-local.h index fedc0b7..3a05e9c 100644 --- a/tracecmd/include/trace-local.h +++ b/tracecmd/include/trace-local.h @@ -181,7 +181,7 @@ struct pid_addr_maps { struct buffer_instance { struct buffer_instance *next; - const char *name; + struct tracecmd_instance *ftrace; char *cpumask; struct event_list *events; struct event_list **event_next; @@ -195,7 +195,6 @@ struct buffer_instance { struct func_list *filter_funcs; struct func_list *notrace_funcs; - const char *clock; unsigned int *client_ports; struct trace_seq *s_save; @@ -225,6 +224,8 @@ struct buffer_instance { bool use_fifos; }; +void init_top_instance(void); + extern struct buffer_instance top_instance; extern struct buffer_instance *buffer_instances; extern struct buffer_instance *first_instance; @@ -238,7 +239,6 @@ extern struct buffer_instance *first_instance; struct buffer_instance *create_instance(const char *name); void add_instance(struct buffer_instance *instance, int cpu_count); -char *get_instance_file(struct buffer_instance *instance, const char *file); void update_first_instance(struct buffer_instance *instance, int topt); void show_instance_file(struct buffer_instance *instance, const char *name); diff --git a/tracecmd/trace-list.c b/tracecmd/trace-list.c index 65099a5..e0782ed 100644 --- a/tracecmd/trace-list.c +++ b/tracecmd/trace-list.c @@ -33,7 +33,7 @@ void show_instance_file(struct buffer_instance *instance, const char *name) { char *path; - path = get_instance_file(instance, name); + path = tracecmd_get_instance_file(instance->ftrace, name); dump_file_content(path); tracecmd_put_tracing_file(path); } diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index 80b2234..13a7cda 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -173,7 +173,7 @@ static struct reset_file *reset_files; /* Triggers need to be cleared in a special way */ static struct reset_file *reset_triggers; -struct buffer_instance top_instance = { .flags = BUFFER_FL_KEEP }; +struct buffer_instance top_instance; struct buffer_instance *buffer_instances; struct buffer_instance *first_instance; @@ -191,7 +191,7 @@ static inline int no_top_instance(void) return first_instance != &top_instance; } -static void init_instance(struct buffer_instance *instance) +void tracecmd_init_instance(struct buffer_instance *instance) { instance->event_next = &instance->events; } @@ -318,7 +318,7 @@ static void reset_save_file_cond(const char *file, int prio, */ void add_instance(struct buffer_instance *instance, int cpu_count) { - init_instance(instance); + tracecmd_init_instance(instance); instance->next = buffer_instances; if (first_instance == buffer_instances) first_instance = instance; @@ -371,7 +371,12 @@ struct buffer_instance *create_instance(const char *name) if (!instance) return NULL; memset(instance, 0, sizeof(*instance)); - instance->name = name; + + instance->ftrace = tracecmd_create_instance(name); + if (!instance->ftrace) { + free(instance); + return NULL; + } return instance; } @@ -471,7 +476,7 @@ void tracecmd_stat_cpu_instance(struct buffer_instance *instance, return; snprintf(file, 40, "per_cpu/cpu%d/stats", cpu); - path = get_instance_file(instance, file); + path = tracecmd_get_instance_file(instance->ftrace, file); free(file); fd = open(path, O_RDONLY); tracecmd_put_tracing_file(path); @@ -505,12 +510,12 @@ static void add_event(struct buffer_instance *instance, struct event_list *event static void reset_event_list(struct buffer_instance *instance) { instance->events = NULL; - init_instance(instance); + tracecmd_init_instance(instance); } static char *get_temp_file(struct buffer_instance *instance, int cpu) { - const char *name = instance->name; + const char *name = instance->ftrace->name; char *file = NULL; int size; @@ -557,7 +562,7 @@ static void put_temp_file(char *file) static void delete_temp_file(struct buffer_instance *instance, int cpu) { - const char *name = instance->name; + const char *name = instance->ftrace->name; char file[PATH_MAX]; if (name) @@ -783,96 +788,6 @@ static int set_ftrace(int set, int use_proc) return 0; } -/** - * get_instance_file - return the path to a instance file. - * @instance: buffer instance for the file - * @file: name of file to return - * - * Returns the path name of the @file for the given @instance. - * - * Must use tracecmd_put_tracing_file() to free the returned string. - */ -char * -get_instance_file(struct buffer_instance *instance, const char *file) -{ - char *buf; - char *path; - int ret; - - if (instance->name) { - ret = asprintf(&buf, "instances/%s/%s", instance->name, file); - if (ret < 0) - die("Failed to allocate name for %s/%s", instance->name, file); - path = tracecmd_get_tracing_file(buf); - free(buf); - } else - path = tracecmd_get_tracing_file(file); - - return path; -} - -static char * -get_instance_dir(struct buffer_instance *instance) -{ - char *buf; - char *path; - int ret; - - /* only works for instances */ - if (!instance->name) - return NULL; - - ret = asprintf(&buf, "instances/%s", instance->name); - if (ret < 0) - die("Failed to allocate for instance %s", instance->name); - path = tracecmd_get_tracing_file(buf); - free(buf); - - return path; -} - -static int write_file(const char *file, const char *str, const char *type) -{ - char buf[BUFSIZ]; - int fd; - int ret; - - fd = open(file, O_WRONLY | O_TRUNC); - if (fd < 0) - die("opening to '%s'", file); - ret = write(fd, str, strlen(str)); - close(fd); - if (ret < 0 && type) { - /* write failed */ - fd = open(file, O_RDONLY); - if (fd < 0) - die("writing to '%s'", file); - /* the filter has the error */ - while ((ret = read(fd, buf, BUFSIZ)) > 0) - fprintf(stderr, "%.*s", ret, buf); - die("Failed %s of %s\n", type, file); - close(fd); - } - return ret; -} - -static int -write_instance_file(struct buffer_instance *instance, - const char *file, const char *str, const char *type) -{ - struct stat st; - char *path; - int ret; - - path = get_instance_file(instance, file); - ret = stat(path, &st); - if (ret == 0) - ret = write_file(path, str, type); - tracecmd_put_tracing_file(path); - - return ret; -} - static void __clear_trace(struct buffer_instance *instance) { FILE *fp; @@ -882,7 +797,7 @@ static void __clear_trace(struct buffer_instance *instance) return; /* reset the trace */ - path = get_instance_file(instance, "trace"); + path = tracecmd_get_instance_file(instance->ftrace, "trace"); fp = fopen(path, "w"); if (!fp) die("writing to '%s'", path); @@ -916,8 +831,8 @@ static void clear_trace(void) static void reset_max_latency(struct buffer_instance *instance) { - write_instance_file(instance, - "tracing_max_latency", "0", "max_latency"); + tracecmd_write_instance_file(instance->ftrace, + "tracing_max_latency", "0", "max_latency"); } static void add_filter_pid(int pid, int exclude) @@ -1363,7 +1278,8 @@ static void add_event_pid(const char *buf) struct buffer_instance *instance; for_all_instances(instance) - write_instance_file(instance, "set_event_pid", buf, "event_pid"); + tracecmd_write_instance_file(instance->ftrace, + "set_event_pid", buf, "event_pid"); } static void add_new_filter_pid(int pid) @@ -1592,7 +1508,7 @@ set_plugin_instance(struct buffer_instance *instance, const char *name) if (is_guest(instance)) return; - path = get_instance_file(instance, "current_tracer"); + path = tracecmd_get_instance_file(instance->ftrace, "current_tracer"); fp = fopen(path, "w"); if (!fp) { /* @@ -1616,7 +1532,7 @@ set_plugin_instance(struct buffer_instance *instance, const char *name) /* Make sure func_stack_trace option is disabled */ /* First try instance file, then top level */ - path = get_instance_file(instance, "options/func_stack_trace"); + path = tracecmd_get_instance_file(instance->ftrace, "options/func_stack_trace"); fp = fopen(path, "w"); if (!fp) { tracecmd_put_tracing_file(path); @@ -1677,8 +1593,6 @@ static int set_option(const char *option) return 0; } -static char *read_instance_file(struct buffer_instance *instance, char *file, int *psize); - static void disable_func_stack_trace_instance(struct buffer_instance *instance) { struct stat st; @@ -1691,13 +1605,13 @@ static void disable_func_stack_trace_instance(struct buffer_instance *instance) if (is_guest(instance)) return; - path = get_instance_file(instance, "current_tracer"); + path = tracecmd_get_instance_file(instance->ftrace, "current_tracer"); ret = stat(path, &st); tracecmd_put_tracing_file(path); if (ret < 0) return; - content = read_instance_file(instance, "current_tracer", &size); + content = tracecmd_read_instance_file(instance->ftrace, "current_tracer", &size); cond = strstrip(content); if (memcmp(cond, "function", size - (cond - content)) !=0) goto out; @@ -1850,7 +1764,7 @@ static int trace_check_file_exists(struct buffer_instance *instance, char *file) char *path; int ret; - path = get_instance_file(instance, file); + path = tracecmd_get_instance_file(instance->ftrace, file); ret = stat(path, &st); tracecmd_put_tracing_file(path); @@ -1929,7 +1843,7 @@ reset_events_instance(struct buffer_instance *instance) } c = '0'; - path = get_instance_file(instance, "events/enable"); + path = tracecmd_get_instance_file(instance->ftrace, "events/enable"); fd = open(path, O_WRONLY); if (fd < 0) die("opening to '%s'", path); @@ -1937,7 +1851,7 @@ reset_events_instance(struct buffer_instance *instance) close(fd); tracecmd_put_tracing_file(path); - path = get_instance_file(instance, "events/*/filter"); + path = tracecmd_get_instance_file(instance->ftrace, "events/*/filter"); globbuf.gl_offs = 0; ret = glob(path, 0, NULL, &globbuf); tracecmd_put_tracing_file(path); @@ -2009,7 +1923,7 @@ static int find_trigger(const char *file, char *buf, int size, int fields) static void write_filter(const char *file, const char *filter) { - write_file(file, filter, "filter"); + tracecmd_write_file(file, filter, "filter"); } static void clear_filter(const char *file) @@ -2019,12 +1933,12 @@ static void clear_filter(const char *file) static void write_trigger(const char *file, const char *trigger) { - write_file(file, trigger, "trigger"); + tracecmd_write_file(file, trigger, "trigger"); } static void write_func_filter(const char *file, const char *trigger) { - write_file(file, trigger, "function filter"); + tracecmd_write_file(file, trigger, "function filter"); } static void clear_trigger(const char *file) @@ -2117,7 +2031,7 @@ static void update_reset_files(void) reset_files = reset->next; if (!keep) - write_file(reset->path, reset->reset, "reset"); + tracecmd_write_file(reset->path, reset->reset, "reset"); free(reset->path); free(reset->reset); free(reset); @@ -2198,7 +2112,7 @@ static int open_instance_fd(struct buffer_instance *instance, int fd; char *path; - path = get_instance_file(instance, file); + path = tracecmd_get_instance_file(instance->ftrace, file); fd = open(path, flags); if (fd < 0) { /* instances may not be created yet */ @@ -2227,7 +2141,7 @@ static int open_tracing_on(struct buffer_instance *instance) return fd; } -static void write_tracing_on(struct buffer_instance *instance, int on) +void write_tracing_on(struct buffer_instance *instance, int on) { int ret; int fd; @@ -2507,7 +2421,7 @@ static void set_mask(struct buffer_instance *instance) if (!instance->cpumask) return; - path = get_instance_file(instance, "tracing_cpumask"); + path = tracecmd_get_instance_file(instance->ftrace, "tracing_cpumask"); if (!path) die("could not allocate path"); reset_save_file(path, RESET_DEFAULT_PRIO); @@ -2555,39 +2469,6 @@ void tracecmd_enable_events(void) enable_events(first_instance); } -static void set_clock(struct buffer_instance *instance) -{ - char *path; - char *content; - char *str; - - if (is_guest(instance)) - return; - - if (!instance->clock) - return; - - /* The current clock is in brackets, reset it when we are done */ - content = read_instance_file(instance, "trace_clock", NULL); - - /* check if first clock is set */ - if (*content == '[') - str = strtok(content+1, "]"); - else { - str = strtok(content, "["); - if (!str) - die("Can not find clock in trace_clock"); - str = strtok(NULL, "]"); - } - path = get_instance_file(instance, "trace_clock"); - add_reset_file(path, str, RESET_DEFAULT_PRIO); - - free(content); - tracecmd_put_tracing_file(path); - - write_instance_file(instance, "trace_clock", instance->clock, "clock"); -} - static void set_max_graph_depth(struct buffer_instance *instance, char *max_graph_depth) { char *path; @@ -2596,16 +2477,16 @@ static void set_max_graph_depth(struct buffer_instance *instance, char *max_grap if (is_guest(instance)) return; - path = get_instance_file(instance, "max_graph_depth"); + path = tracecmd_get_instance_file(instance->ftrace, "max_graph_depth"); reset_save_file(path, RESET_DEFAULT_PRIO); tracecmd_put_tracing_file(path); - ret = write_instance_file(instance, "max_graph_depth", max_graph_depth, - NULL); + ret = tracecmd_write_instance_file(instance->ftrace, + "max_graph_depth", max_graph_depth, + NULL); if (ret < 0) die("could not write to max_graph_depth"); } - /** * create_event - create and event descriptor * @instance: instance to use @@ -2717,7 +2598,7 @@ static int expand_event_files(struct buffer_instance *instance, if (ret < 0) die("Failed to allocate event filter path for %s", file); - path = get_instance_file(instance, p); + path = tracecmd_get_instance_file(instance->ftrace, p); globbuf.gl_offs = 0; ret = glob(path, 0, NULL, &globbuf); @@ -3179,10 +3060,7 @@ create_recorder_instance_pipe(struct buffer_instance *instance, unsigned flags = recorder_flags | TRACECMD_RECORD_BLOCK; char *path; - if (instance->name) - path = get_instance_dir(instance); - else - path = tracecmd_find_tracing_dir(); + path = tracecmd_get_instance_dir(instance->ftrace); if (!path) die("malloc"); @@ -3192,7 +3070,7 @@ create_recorder_instance_pipe(struct buffer_instance *instance, recorder = tracecmd_create_buffer_recorder_fd(brass[1], cpu, flags, path); - if (instance->name) + if (instance->ftrace->name) tracecmd_put_tracing_file(path); return recorder; @@ -3227,10 +3105,10 @@ create_recorder_instance(struct buffer_instance *instance, const char *file, int if (brass) return create_recorder_instance_pipe(instance, cpu, brass); - if (!instance->name) + if (!instance->ftrace->name) return tracecmd_create_recorder_maxkb(file, cpu, recorder_flags, max_kb); - path = get_instance_dir(instance); + path = tracecmd_get_instance_dir(instance->ftrace); record = tracecmd_create_buffer_recorder_maxkb(file, cpu, recorder_flags, path, max_kb); @@ -3284,8 +3162,8 @@ static int create_recorder(struct buffer_instance *instance, int cpu, } if (fd < 0) die("Failed connecting to client"); - if (instance->name && !is_agent(instance)) - path = get_instance_dir(instance); + if (instance->ftrace->name && !is_agent(instance)) + path = tracecmd_get_instance_dir(instance->ftrace); else path = tracecmd_find_tracing_dir(); recorder = tracecmd_create_buffer_recorder_fd(fd, cpu, flags, path); @@ -3598,7 +3476,7 @@ static void connect_to_agent(struct buffer_instance *instance) bool use_fifos = false; if (!no_fifos) { - nr_fifos = open_guest_fifos(instance->name, &fds); + nr_fifos = open_guest_fifos(instance->ftrace->name, &fds); use_fifos = nr_fifos > 0; } @@ -3625,7 +3503,7 @@ static void connect_to_agent(struct buffer_instance *instance) if (nr_cpus != nr_fifos) { warning("number of FIFOs (%d) for guest %s differs " "from number of virtual CPUs (%d)", - nr_fifos, instance->name, nr_cpus); + nr_fifos, instance->ftrace->name, nr_cpus); nr_cpus = nr_cpus < nr_fifos ? nr_cpus : nr_fifos; } free(ports); @@ -3651,7 +3529,7 @@ static void setup_guest(struct buffer_instance *instance) int fd; /* Create a place to store the guest meta data */ - file = get_guest_file(output_file, instance->name); + file = get_guest_file(output_file, instance->ftrace->name); if (!file) die("Failed to allocate memory"); @@ -3827,7 +3705,7 @@ add_buffer_stat(struct tracecmd_output *handle, struct buffer_instance *instance int i; trace_seq_init(&s); - trace_seq_printf(&s, "\nBuffer: %s\n\n", instance->name); + trace_seq_printf(&s, "\nBuffer: %s\n\n", instance->ftrace->name); tracecmd_add_option(handle, TRACECMD_OPTION_CPUSTAT, s.len+1, s.buffer); trace_seq_destroy(&s); @@ -3893,7 +3771,7 @@ static void print_stat(struct buffer_instance *instance) return; if (!is_top_instance(instance)) - printf("\nBuffer: %s\n\n", instance->name); + printf("\nBuffer: %s\n\n", instance->ftrace->name); for (cpu = 0; cpu < instance->cpu_count; cpu++) trace_seq_do_printf(&instance->s_print[cpu]); @@ -3933,7 +3811,7 @@ static void write_guest_file(struct buffer_instance *instance) char **temp_files; int i, fd; - file = get_guest_file(output_file, instance->name); + file = get_guest_file(output_file, instance->ftrace->name); if (!file) die("Failed to allocate memory"); @@ -4049,7 +3927,7 @@ static void record_data(struct common_record_context *ctx) continue; buffer_options[i++] = tracecmd_add_buffer_option(handle, - instance->name, + instance->ftrace->name, cpus); add_buffer_stat(handle, instance); } @@ -4096,7 +3974,7 @@ static int write_func_file(struct buffer_instance *instance, if (!*list) return 0; - path = get_instance_file(instance, file); + path = tracecmd_get_instance_file(instance->ftrace, file); fd = open(path, O_WRONLY | O_TRUNC); if (fd < 0) @@ -4140,7 +4018,7 @@ static int functions_filtered(struct buffer_instance *instance) char *path; int fd; - path = get_instance_file(instance, "set_ftrace_filter"); + path = tracecmd_get_instance_file(instance->ftrace, "set_ftrace_filter"); fd = open(path, O_RDONLY); tracecmd_put_tracing_file(path); if (fd < 0) { @@ -4148,7 +4026,7 @@ static int functions_filtered(struct buffer_instance *instance) warning("Can not set set_ftrace_filter"); else warning("Can not set set_ftrace_filter for %s", - instance->name); + instance->ftrace->name); return 0; } @@ -4308,45 +4186,10 @@ static unsigned long long find_time_stamp(struct tep_handle *pevent) return ts; } -static char *read_instance_file(struct buffer_instance *instance, char *file, int *psize) -{ - char buffer[BUFSIZ]; - char *path; - char *buf; - int size = 0; - int fd; - int r; - - path = get_instance_file(instance, file); - fd = open(path, O_RDONLY); - tracecmd_put_tracing_file(path); - if (fd < 0) { - warning("%s not found, --date ignored", file); - return NULL; - } - do { - r = read(fd, buffer, BUFSIZ); - if (r <= 0) - continue; - if (size) - buf = realloc(buf, size+r+1); - else - buf = malloc(r+1); - if (!buf) - die("Failed to allocate instance file buffer"); - memcpy(buf+size, buffer, r); - size += r; - } while (r); - - buf[size] = '\0'; - if (psize) - *psize = size; - return buf; -} static char *read_file(char *file, int *psize) { - return read_instance_file(&top_instance, file, psize); + return tracecmd_read_instance_file(top_instance.ftrace, file, psize); } /* @@ -4479,7 +4322,7 @@ static void set_buffer_size_instance(struct buffer_instance *instance) snprintf(buf, BUFSIZ, "%d", buffer_size); - path = get_instance_file(instance, "buffer_size_kb"); + path = tracecmd_get_instance_file(instance->ftrace, "buffer_size_kb"); fd = open(path, O_WRONLY); if (fd < 0) { warning("can't open %s", path); @@ -4540,7 +4383,7 @@ static void clear_instance_triggers(struct buffer_instance *instance) enum event_iter_type type; enum event_process processed = PROCESSED_NONE; - path = get_instance_file(instance, "events"); + path = tracecmd_get_instance_file(instance->ftrace, "events"); if (!path) die("malloc"); @@ -4601,7 +4444,7 @@ static void clear_instance_filters(struct buffer_instance *instance) enum event_iter_type type; enum event_process processed = PROCESSED_NONE; - path = get_instance_file(instance, "events"); + path = tracecmd_get_instance_file(instance->ftrace, "events"); if (!path) die("malloc"); @@ -4637,7 +4480,8 @@ static void reset_clock(void) struct buffer_instance *instance; for_all_instances(instance) - write_instance_file(instance, "trace_clock", "local", "clock"); + tracecmd_write_instance_file(instance->ftrace, + "trace_clock", "local", "clock"); } static void reset_cpu_mask(void) @@ -4656,7 +4500,8 @@ static void reset_cpu_mask(void) strcat(buf, ",ffffffff"); for_all_instances(instance) - write_instance_file(instance, "tracing_cpumask", buf, "cpumask"); + tracecmd_write_instance_file(instance->ftrace, + "tracing_cpumask", buf, "cpumask"); } static void reset_event_pid(void) @@ -4685,7 +4530,7 @@ static void clear_func_filters(void) for_all_instances(instance) { for (i = 0; files[i]; i++) { - path = get_instance_file(instance, files[i]); + path = tracecmd_get_instance_file(instance->ftrace, files[i]); clear_func_filter(path); tracecmd_put_tracing_file(path); } @@ -4695,32 +4540,20 @@ static void clear_func_filters(void) static void make_instances(void) { struct buffer_instance *instance; - struct stat st; - char *path; - int ret; for_each_instance(instance) { if (is_guest(instance)) continue; - - path = get_instance_dir(instance); - ret = stat(path, &st); - if (ret < 0) { - ret = mkdir(path, 0777); - if (ret < 0) - die("mkdir %s", path); - } else + if (tracecmd_make_instance(instance->ftrace) > 0) { /* Don't delete instances that already exist */ instance->flags |= BUFFER_FL_KEEP; - tracecmd_put_tracing_file(path); + } } } void tracecmd_remove_instances(void) { struct buffer_instance *instance; - char *path; - int ret; for_each_instance(instance) { /* Only delete what we created */ @@ -4730,11 +4563,7 @@ void tracecmd_remove_instances(void) close(instance->tracing_on_fd); instance->tracing_on_fd = 0; } - path = get_instance_dir(instance); - ret = rmdir(path); - if (ret < 0) - die("rmdir %s", path); - tracecmd_put_tracing_file(path); + tracecmd_remove_instance(instance->ftrace); } } @@ -5028,7 +4857,7 @@ static int test_stacktrace_trigger(struct buffer_instance *instance) int ret = 0; int fd; - path = get_instance_file(instance, "events/sched/sched_switch/trigger"); + path = tracecmd_get_instance_file(instance->ftrace, "events/sched/sched_switch/trigger"); clear_trigger(path); @@ -5210,6 +5039,15 @@ void update_first_instance(struct buffer_instance *instance, int topt) first_instance = buffer_instances; } +void init_top_instance(void) +{ + if (!top_instance.ftrace) + top_instance.ftrace = tracecmd_create_instance(NULL); + top_instance.cpu_count = count_cpus(); + top_instance.flags = BUFFER_FL_KEEP; + tracecmd_init_instance(&top_instance); +} + enum { OPT_user = 243, OPT_procmap = 244, @@ -5234,7 +5072,7 @@ void trace_stop(int argc, char **argv) int topt = 0; struct buffer_instance *instance = &top_instance; - init_instance(instance); + init_top_instance(); for (;;) { int c; @@ -5275,7 +5113,7 @@ void trace_restart(int argc, char **argv) int topt = 0; struct buffer_instance *instance = &top_instance; - init_instance(instance); + init_top_instance(); for (;;) { int c; @@ -5317,7 +5155,7 @@ void trace_reset(int argc, char **argv) int topt = 0; struct buffer_instance *instance = &top_instance; - init_instance(instance); + init_top_instance(); /* if last arg is -a, then -b and -d apply to all instances */ int last_specified_all = 0; @@ -5402,9 +5240,8 @@ static void init_common_record_context(struct common_record_context *ctx, memset(ctx, 0, sizeof(*ctx)); ctx->instance = &top_instance; ctx->curr_cmd = curr_cmd; - init_instance(ctx->instance); local_cpu_count = count_cpus(); - ctx->instance->cpu_count = local_cpu_count; + init_top_instance(); } #define IS_EXTRACT(ctx) ((ctx)->curr_cmd == CMD_extract) @@ -5642,7 +5479,7 @@ static void parse_record_options(int argc, } break; case 'C': - ctx->instance->clock = optarg; + ctx->instance->ftrace->clock = optarg; break; case 'v': neg_event = 1; @@ -5964,6 +5801,23 @@ static bool has_local_instances(void) return false; } +static void set_clock(struct buffer_instance *instance) +{ + char *old_clock = NULL; + char *path; + + if (is_guest(instance)) + return; + + tracecmd_set_clock(instance->ftrace, &old_clock); + if (old_clock) { + path = tracecmd_get_instance_file(instance->ftrace, "trace_clock"); + if (path) + add_reset_file(path, old_clock, RESET_DEFAULT_PRIO); + free(old_clock); + tracecmd_put_tracing_file(path); + } +} /* * This function contains common code for the following commands: * record, start, stream, profile. @@ -6015,7 +5869,6 @@ static void record_trace(int argc, char **argv, for_all_instances(instance) set_clock(instance); - /* Record records the date first */ if (ctx->date && ((IS_RECORD(ctx) && has_local_instances()) || IS_RECORD_AGENT(ctx))) diff --git a/tracecmd/trace-show.c b/tracecmd/trace-show.c index 96bfe77..ca0f4cf 100644 --- a/tracecmd/trace-show.c +++ b/tracecmd/trace-show.c @@ -51,6 +51,8 @@ void trace_show(int argc, char **argv) {NULL, 0, NULL, 0} }; + init_top_instance(); + while ((c = getopt_long(argc-1, argv+1, "B:c:fsp", long_options, &option_index)) >= 0) { switch (c) { diff --git a/tracecmd/trace-stat.c b/tracecmd/trace-stat.c index 538f4ad..32aebc5 100644 --- a/tracecmd/trace-stat.c +++ b/tracecmd/trace-stat.c @@ -30,7 +30,7 @@ static int get_instance_file_fd(struct buffer_instance *instance, char *path; int fd; - path = get_instance_file(instance, file); + path = tracecmd_get_instance_file(instance->ftrace, file); fd = open(path, O_RDONLY); tracecmd_put_tracing_file(path); @@ -347,7 +347,7 @@ static void report_events(struct buffer_instance *instance) free(str); - path = get_instance_file(instance, "events"); + path = tracecmd_get_instance_file(instance->ftrace, "events"); if (!path) die("malloc"); @@ -436,7 +436,7 @@ static void report_event_filters(struct buffer_instance *instance) enum event_iter_type type; enum event_process processed = PROCESSED_NONE; - path = get_instance_file(instance, "events"); + path = tracecmd_get_instance_file(instance->ftrace, "events"); if (!path) die("malloc"); @@ -509,7 +509,7 @@ static void report_event_triggers(struct buffer_instance *instance) enum event_iter_type type; enum event_process processed = PROCESSED_NONE; - path = get_instance_file(instance, "events"); + path = tracecmd_get_instance_file(instance->ftrace, "events"); if (!path) die("malloc"); @@ -598,7 +598,7 @@ static void report_graph_funcs(struct buffer_instance *instance) { char *path; - path = get_instance_file(instance, "set_graph_function"); + path = tracecmd_get_instance_file(instance->ftrace, "set_graph_function"); if (!path) die("malloc"); @@ -606,7 +606,7 @@ static void report_graph_funcs(struct buffer_instance *instance) tracecmd_put_tracing_file(path); - path = get_instance_file(instance, "set_graph_notrace"); + path = tracecmd_get_instance_file(instance->ftrace, "set_graph_notrace"); if (!path) die("malloc"); @@ -619,7 +619,7 @@ static void report_ftrace_filters(struct buffer_instance *instance) { char *path; - path = get_instance_file(instance, "set_ftrace_filter"); + path = tracecmd_get_instance_file(instance->ftrace, "set_ftrace_filter"); if (!path) die("malloc"); @@ -627,7 +627,7 @@ static void report_ftrace_filters(struct buffer_instance *instance) tracecmd_put_tracing_file(path); - path = get_instance_file(instance, "set_ftrace_notrace"); + path = tracecmd_get_instance_file(instance->ftrace, "set_ftrace_notrace"); if (!path) die("malloc"); @@ -857,7 +857,7 @@ static void stat_instance(struct buffer_instance *instance) if (instance != &top_instance) { if (instance != first_instance) printf("---------------\n"); - printf("Instance: %s\n", instance->name); + printf("Instance: %s\n", instance->ftrace->name); } report_plugin(instance); @@ -882,6 +882,8 @@ void trace_stat (int argc, char **argv) int status; int c; + init_top_instance(); + for (;;) { c = getopt(argc-1, argv+1, "tB:"); if (c == -1) From patchwork Tue Dec 3 10:35:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270935 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 66F521805 for ; Tue, 3 Dec 2019 10:35:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B70C20684 for ; Tue, 3 Dec 2019 10:35:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZbyxxI07" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726107AbfLCKff (ORCPT ); Tue, 3 Dec 2019 05:35:35 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:42796 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbfLCKfe (ORCPT ); Tue, 3 Dec 2019 05:35:34 -0500 Received: by mail-lj1-f196.google.com with SMTP id e28so3152001ljo.9 for ; Tue, 03 Dec 2019 02:35:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jZjcSHRXcQc9LXYl9gLx4saHozoSnnADGecLzjfnxP4=; b=ZbyxxI07RR1XWPG4qlFq9t3wf8zXQ9W0SkeySzOooj9EL4CBwMkAdKURU3ShChVTXE UhxdSWReOEKhmNzWZjWJmW8ZvtC1WISp9lz941g+wV3tCkmdMv/hwk+g22kG1j9rQ/MX iJ8BtZ6fuFFUmB0kdVHW8aHgynj+HwuoS1O/L2t8q4cL+A9snrunkzZzPzSU5sbUEk3d qxeHV7Xma4sxwGAeny+RuPddxElnhVst1hw3R8hWBfNZQhu9/K3cfNpOSnPkH8DRHLrT B9VO7P/8w3pF5CXl8IxjnVeNtutHPnLhLDL117GIkTgAM5VPhNa43hUCs1zPDBO+a5ud VDxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jZjcSHRXcQc9LXYl9gLx4saHozoSnnADGecLzjfnxP4=; b=lOfaPZLL7y6eVb849nJlFMgQvG3U9Z/VD7WFu5YXb8qVp0VhTtVLykN91K8aS0/e65 q7c1BlXKQbnYGG9aLUpKFdegPrmKOOURhJwQj7WNIVayYkTf/NdVTNn3EAEI7Up3f2ls rJ8f4pewQ8yTSvbeVsX6h6Evi0IsYgvjztCY/G1Z7xkbdm6pv25+998CD8U90HfQO7fO /rkUohq2/3OOCJ0lhItcgPRhgjTtOLuXPutBWV1TdilTaX/lPMyB/NaHdFjL7cfRdzBQ bCcdNPzUmOR6UeZ8GHI0z2YIN2pNmqr/dPDlqPmf+DeLQXAZReYWrMW9/VfycqNsYDi5 cZPA== X-Gm-Message-State: APjAAAXf5yrZRL/XohpZztoKZ6mg2vIvQTXC0iihdWXb4t0WiEeQtC6F qnm70jd8mirapMbKgZjq2jE= X-Google-Smtp-Source: APXvYqx9hniq9+vAHMHBy3DaTAEq80tUif1w/A4JQlIczl59waGZfs7y4onF6NR/GM+hsx2wm70wAQ== X-Received: by 2002:a05:651c:3dc:: with SMTP id f28mr2229659ljp.35.1575369332610; Tue, 03 Dec 2019 02:35:32 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:32 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 05/18] trace-cmd: Add new library API for local CPU count Date: Tue, 3 Dec 2019 12:35:09 +0200 Message-Id: <20191203103522.482684-6-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org In order to reuse the code, the function detecting the number of local CPU is moved from trace-cmd application to libtracecmd. The following new library API is introduced: int tracecmd_count_cpus(void); Signed-off-by: Tzvetomir Stoyanov (VMware) --- include/trace-cmd/trace-cmd.h | 3 +++ lib/trace-cmd/trace-util.c | 40 +++++++++++++++++++++++++++++ tracecmd/include/trace-local.h | 2 -- tracecmd/trace-agent.c | 2 +- tracecmd/trace-profile.c | 2 +- tracecmd/trace-record.c | 46 +++------------------------------- tracecmd/trace-stat.c | 4 +-- 7 files changed, 50 insertions(+), 49 deletions(-) diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 5287d23..5d4292e 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -427,6 +427,9 @@ void tracecmd_plog(const char *fmt, ...); void tracecmd_plog_error(const char *fmt, ...); int tracecmd_set_logfile(char *logfile); +/* --- System --- */ +int tracecmd_count_cpus(void); + /* --- Hack! --- */ int tracecmd_blk_hack(struct tracecmd_input *handle); diff --git a/lib/trace-cmd/trace-util.c b/lib/trace-cmd/trace-util.c index 4c70d9a..e019dce 100644 --- a/lib/trace-cmd/trace-util.c +++ b/lib/trace-cmd/trace-util.c @@ -1112,6 +1112,46 @@ int tracecmd_stack_tracer_status(int *status) return 1; /* full success */ } +int tracecmd_count_cpus(void) +{ + FILE *fp; + char buf[1024]; + int cpus = 0; + char *pbuf; + size_t *pn; + size_t n; + int r; + + cpus = sysconf(_SC_NPROCESSORS_CONF); + if (cpus > 0) + return cpus; + + warning("sysconf could not determine number of CPUS"); + + /* Do the hack to figure out # of CPUS */ + n = 1024; + pn = &n; + pbuf = buf; + + fp = fopen("/proc/cpuinfo", "r"); + if (!fp) + die("Can not read cpuinfo"); + + while ((r = getline(&pbuf, pn, fp)) >= 0) { + char *p; + + if (strncmp(buf, "processor", 9) != 0) + continue; + for (p = buf+9; isspace(*p); p++) + ; + if (*p == ':') + cpus++; + } + fclose(fp); + + return cpus; +} + /* * tracecmd_write_file - Write in trace file * @file: Full name of the trace file. diff --git a/tracecmd/include/trace-local.h b/tracecmd/include/trace-local.h index 3a05e9c..a51f0d0 100644 --- a/tracecmd/include/trace-local.h +++ b/tracecmd/include/trace-local.h @@ -243,8 +243,6 @@ void update_first_instance(struct buffer_instance *instance, int topt); void show_instance_file(struct buffer_instance *instance, const char *name); -int count_cpus(void); - /* moved from trace-cmd.h */ void tracecmd_create_top_instance(char *name); void tracecmd_remove_instances(void); diff --git a/tracecmd/trace-agent.c b/tracecmd/trace-agent.c index 93e3edf..1c6e0a3 100644 --- a/tracecmd/trace-agent.c +++ b/tracecmd/trace-agent.c @@ -203,7 +203,7 @@ static void agent_serve(unsigned int port) signal(SIGCHLD, handle_sigchld); - nr_cpus = count_cpus(); + nr_cpus = tracecmd_count_cpus(); page_size = getpagesize(); sd = make_vsock(port); diff --git a/tracecmd/trace-profile.c b/tracecmd/trace-profile.c index 231e381..cfae2a2 100644 --- a/tracecmd/trace-profile.c +++ b/tracecmd/trace-profile.c @@ -1314,7 +1314,7 @@ void trace_init_profile(struct tracecmd_input *handle, struct hook_list *hook, * system. */ if (!h->cpus) - h->cpus = count_cpus(); + h->cpus = tracecmd_count_cpus(); list_head_init(&h->migrate_starts); h->cpu_starts = malloc(sizeof(*h->cpu_starts) * h->cpus); diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index 13a7cda..4459c90 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -2726,46 +2726,6 @@ static void expand_event_list(void) expand_event_instance(instance); } -int count_cpus(void) -{ - FILE *fp; - char buf[1024]; - int cpus = 0; - char *pbuf; - size_t *pn; - size_t n; - int r; - - cpus = sysconf(_SC_NPROCESSORS_CONF); - if (cpus > 0) - return cpus; - - warning("sysconf could not determine number of CPUS"); - - /* Do the hack to figure out # of CPUS */ - n = 1024; - pn = &n; - pbuf = buf; - - fp = fopen("/proc/cpuinfo", "r"); - if (!fp) - die("Can not read cpuinfo"); - - while ((r = getline(&pbuf, pn, fp)) >= 0) { - char *p; - - if (strncmp(buf, "processor", 9) != 0) - continue; - for (p = buf+9; isspace(*p); p++) - ; - if (*p == ':') - cpus++; - } - fclose(fp); - - return cpus; -} - static void finish(int sig) { /* all done */ @@ -4487,7 +4447,7 @@ static void reset_clock(void) static void reset_cpu_mask(void) { struct buffer_instance *instance; - int cpus = count_cpus(); + int cpus = tracecmd_count_cpus(); int fullwords = (cpus - 1) / 32; int bits = (cpus - 1) % 32 + 1; int len = (fullwords + 1) * 9; @@ -5043,7 +5003,7 @@ void init_top_instance(void) { if (!top_instance.ftrace) top_instance.ftrace = tracecmd_create_instance(NULL); - top_instance.cpu_count = count_cpus(); + top_instance.cpu_count = tracecmd_count_cpus(); top_instance.flags = BUFFER_FL_KEEP; tracecmd_init_instance(&top_instance); } @@ -5240,7 +5200,7 @@ static void init_common_record_context(struct common_record_context *ctx, memset(ctx, 0, sizeof(*ctx)); ctx->instance = &top_instance; ctx->curr_cmd = curr_cmd; - local_cpu_count = count_cpus(); + local_cpu_count = tracecmd_count_cpus(); init_top_instance(); } diff --git a/tracecmd/trace-stat.c b/tracecmd/trace-stat.c index 32aebc5..44ee559 100644 --- a/tracecmd/trace-stat.c +++ b/tracecmd/trace-stat.c @@ -737,7 +737,7 @@ static void report_cpumask(struct buffer_instance *instance) cont = strstrip(str); /* check to make sure all CPUs on this machine are set */ - cpus = count_cpus(); + cpus = tracecmd_count_cpus(); for (i = strlen(cont) - 1; i >= 0 && cpus > 0; i--) { if (cont[i] == ',') @@ -896,7 +896,7 @@ void trace_stat (int argc, char **argv) instance = create_instance(optarg); if (!instance) die("Failed to create instance"); - add_instance(instance, count_cpus()); + add_instance(instance, tracecmd_count_cpus()); /* top instance requires direct access */ if (!topt && is_top_instance(first_instance)) first_instance = instance; From patchwork Tue Dec 3 10:35:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270943 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 327EE1892 for ; Tue, 3 Dec 2019 10:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1120E20684 for ; Tue, 3 Dec 2019 10:35:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BQPROc8c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726074AbfLCKff (ORCPT ); Tue, 3 Dec 2019 05:35:35 -0500 Received: from mail-lj1-f172.google.com ([209.85.208.172]:40998 "EHLO mail-lj1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbfLCKff (ORCPT ); Tue, 3 Dec 2019 05:35:35 -0500 Received: by mail-lj1-f172.google.com with SMTP id h23so3158227ljc.8 for ; Tue, 03 Dec 2019 02:35:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wMgCn+O1gDF3PGkitqN6z1Pc9HBAPztdVZ4+0qW0KJ0=; b=BQPROc8cSH17p0BrSB0FB+JRnwdMUVgqr6WHv9b/KwDewEkWosWXa+fpaJfRawXog5 xCRLQvu4k4AGH+GYsEkXgBuffCoqIBo03a6a8YB7B0cunqkLLJjsUEnqtbxOf7iCf7oJ HaVXiiPaa41KQybrdeO6p8FSraISzPGVssH4C6WVSGbdAkaGwXSoY2/rT6FO5e7hs4f4 2QxBlNvqyPqNOuXZUOULBwBcn6oAJhJ/mBuYt4CGSTxY388TJthdGRWofpHpSHUMp+J9 Rn2KLZ4LPtvUUcyiFdkMaJH9iQ0Z/NbNDEamk0HBaK58XYlHUw03MXf6m/ynlYdQfjL1 GJmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wMgCn+O1gDF3PGkitqN6z1Pc9HBAPztdVZ4+0qW0KJ0=; b=riYzLeilWnZKzJ3Hn8mqcochGcAsmhHskcXYZS93TwxPZ6dPPv9h98aPIBx8jpPe9A RxIrpXzbk93/1BmvQeyHlPDR88rELjgscuBcvDUuJTQvTOXf/tGtuKBx42eI/o8nA1A/ ofSGdgZPXJ2vlRnhSbYv1UthzdfTdQ7QtKWNsZkrsPFUjsUfCJtvwiGmOh1S29llqmLp eQ+Bzaoxqfg/e4xN5W0+jDeSW86hMf7McPezrwnu93gev20RrMWfjm4JcNEsFqz5iRQZ ehQE0tUCfnF9cfXskJBFcV4tlSbA5QjIzqv5j3QE9agd67vIYXu+EQAsJugN55m9XcGv HVig== X-Gm-Message-State: APjAAAWmRNlaHQnI/Bvr2lBG+GOOug/s0UlsEPTl50REYatGy9dge1kM g5ebfuiM0TOCBQihc5wzhiE= X-Google-Smtp-Source: APXvYqw8rXIZi8KQ9w4S22rW+JXUNPK/yvUqlSLIvlNwL6Vm5C3ii8GMvwQ2im5BlhKdBJKpH8AMaQ== X-Received: by 2002:a2e:89da:: with SMTP id c26mr2178997ljk.54.1575369333669; Tue, 03 Dec 2019 02:35:33 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:33 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 06/18] trace-cmd: Add new library API for reading ftrace buffers Date: Tue, 3 Dec 2019 12:35:10 +0200 Message-Id: <20191203103522.482684-7-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org A new libtracecmd API is introduced: int tracecmd_iterate_raw_events(struct tep_handle *tep, struct tracecmd_instance *instance, int (*callback)(struct tep_event *, struct tep_record *, int, void *context), void *callback_context); It reads events from trace_pipe_raw, per cpu ftrace buffer, and calls a user callback for each of them. The API is instance aware. Signed-off-by: Tzvetomir Stoyanov (VMware) --- include/trace-cmd/trace-cmd.h | 8 +++ lib/trace-cmd/trace-util.c | 114 ++++++++++++++++++++++++++++++++++ 2 files changed, 122 insertions(+) diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 5d4292e..831bb1a 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -380,6 +380,14 @@ char *tracecmd_read_instance_file(struct tracecmd_instance *instance, void tracecmd_set_clock(struct tracecmd_instance *instance, char **old_clock); +int tracecmd_iterate_raw_events(struct tep_handle *tep, + struct tracecmd_instance *instance, + int (*callback)(struct tep_event *, + struct tep_record *, + int, void *context), + void *callback_context); + + /* --- Plugin handling --- */ extern struct tep_plugin_option trace_ftrace_options[]; diff --git a/lib/trace-cmd/trace-util.c b/lib/trace-cmd/trace-util.c index e019dce..a54a905 100644 --- a/lib/trace-cmd/trace-util.c +++ b/lib/trace-cmd/trace-util.c @@ -1185,3 +1185,117 @@ int tracecmd_write_file(const char *file, const char *str, const char *type) } return ret; } + +static int +get_events_in_page(struct tep_handle *tep, void *page, + int size, int cpu, + int (*callback)(struct tep_event *, + struct tep_record *, + int, void *), + void *callback_context) +{ + struct tep_record *last_record = NULL; + struct tep_event *event = NULL; + struct tep_record *record; + int id, cnt = 0; + + if (size <= 0) + return 0; + + while (true) { + event = NULL; + record = tracecmd_read_page_record(tep, page, size, + last_record); + if (!record) + break; + free_record(last_record); + id = tep_data_type(tep, record); + event = tep_find_event(tep, id); + if (event && callback) { + if (callback(event, record, cpu, callback_context)) + break; + } + last_record = record; + } + free_record(last_record); + + return cnt; +} + +/* + * tracecmd_iterate_raw_events - Iterate through events in trace_pipe_raw + * per CPU trace files + * @tep: a handle to the trace event parser context + * @instance: ftrace instance, can be NULL for the top instance + * @callback: A user function, called for each record from the file. + * @callback_context: A custom context, passed to the user callback function + * + * If the @callback returns non-zero, the iteration stops. + * + * Returns -1 in case of an error, or 0 otherwise. + */ +int tracecmd_iterate_raw_events(struct tep_handle *tep, + struct tracecmd_instance *instance, + int (*callback)(struct tep_event *, + struct tep_record *, + int, void *), + void *callback_context) +{ + unsigned int p_size; + struct dirent *dent; + char file[PATH_MAX]; + void *page = NULL; + struct stat st; + char *path; + DIR *dir; + int ret; + int cpu; + int fd; + int r; + + p_size = getpagesize(); + path = tracecmd_get_instance_file(instance, "per_cpu"); + if (!path) + return -1; + dir = opendir(path); + if (!dir) { + ret = -1; + goto error; + } + page = malloc(p_size); + if (!page) { + ret = -1; + goto error; + } + while ((dent = readdir(dir))) { + const char *name = dent->d_name; + + if (strlen(name) < 4 || strncmp(name, "cpu", 3) != 0) + continue; + cpu = atoi(name + 3); + sprintf(file, "%s/%s", path, name); + ret = stat(file, &st); + if (ret < 0 || !S_ISDIR(st.st_mode)) + continue; + + sprintf(file, "%s/%s/trace_pipe_raw", path, name); + fd = open(file, O_RDONLY | O_NONBLOCK); + if (fd < 0) + continue; + do { + r = read(fd, page, p_size); + if (r > 0) + get_events_in_page(tep, page, r, cpu, + callback, callback_context); + } while (r > 0); + close(fd); + } + ret = 0; + +error: + if (dir) + closedir(dir); + free(page); + tracecmd_put_tracing_file(path); + return ret; +} From patchwork Tue Dec 3 10:35:11 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270941 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 88384186E for ; Tue, 3 Dec 2019 10:35:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 680A32073B for ; Tue, 3 Dec 2019 10:35:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mdZQLAIC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726114AbfLCKfh (ORCPT ); Tue, 3 Dec 2019 05:35:37 -0500 Received: from mail-lf1-f65.google.com ([209.85.167.65]:34924 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbfLCKfh (ORCPT ); Tue, 3 Dec 2019 05:35:37 -0500 Received: by mail-lf1-f65.google.com with SMTP id r15so2531036lff.2 for ; Tue, 03 Dec 2019 02:35:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1vr5+JkKcuoZVsjx/XbK96E0u7JOyC3v723be9HMndo=; b=mdZQLAICg0Na9kD7LhvR3LzITosoXHBgrOOYOAPoW4QzQQB9Vm+2fqZjWBlKFjt5vO AoZGdnw0m0yYsfI+J3fs3iwUpmJgbwOfzD3G45Bi84n8EhDDhryf14deBX0fNYY++Hk6 rg+FfDBzhEus/cOSINOA1HJ3vk1dUb+ht/iMyUZE0qP7VisZEY+ZKvXLctg5M5HDbeBf 6C81dD3ko0E8Vyv+xLEOe7rqudlKLYnkpXQk8aCDrIrw50W5u4EGQYRU1hwX+xzML9kD UV2ErBPBvfNxpnpufcllwXjd0zTFVFC9Eubadw2aI+o65nFoVq2YiJyE/Xa7HscDgTKW gQNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1vr5+JkKcuoZVsjx/XbK96E0u7JOyC3v723be9HMndo=; b=jalI4z6oWW/yn9BKnGB6I1D1lz3aKrMKsNiCFixhSkxoOioywd0+A0KTNP/KIHZJjT JV9Kf6g0o83bwQWBE5q7gS+TkfDJ5iMNe8/lq6T/5+vRzl0+Plg6Mgzq4mUQu16Zau/r 2H3+jsfa6Jl+JfzLe+e2EL/zcehREytOJmZHq/s8ZGC/vUuaHQlkXFlNPsPFM5HsdyG3 9bWMjn9JKmw7Edw+HYgs1blSG1Xk46aHa4BzqPTLx0Bh040+kQfuiXz6jv6/3/94/o5q hrapSIauNnq/15CRkWB9qfa2z5wVBD11FQSm1nmc+q2CBpP54NhOWmk4TbHfE1ICa1gh K1vw== X-Gm-Message-State: APjAAAWwTI7nXzgaLQNGtZAacKTOV0g7xdMNaow412RwrofPzavmUKwy WtBqy+8nUOwG8AZME/yZBEc= X-Google-Smtp-Source: APXvYqz9JXl8Y5elpedCoMllnHV74RB0jQ7ty2JDpFi22vXy+ObTLsqD4lyweIXjTtRTpUgY1zZviQ== X-Received: by 2002:ac2:4a91:: with SMTP id l17mr2270005lfp.75.1575369334902; Tue, 03 Dec 2019 02:35:34 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:34 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 07/18] trace-cmd: Find and store pids of tasks, which run virtual CPUs of given VM Date: Tue, 3 Dec 2019 12:35:11 +0200 Message-Id: <20191203103522.482684-8-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org From: Tzvetomir Stoyanov In order to match host and guest events, a mapping between guest VCPU and the host task, running this VCPU is needed. Extended existing struct guest to hold such mapping and added logic in read_qemu_guests() function to initialize it. Implemented a new internal API, get_guest_vcpu_pid(), to retrieve VCPU-task mapping for given VM. Signed-off-by: Tzvetomir Stoyanov --- tracecmd/include/trace-local.h | 2 ++ tracecmd/trace-record.c | 57 ++++++++++++++++++++++++++++++++++ 2 files changed, 59 insertions(+) diff --git a/tracecmd/include/trace-local.h b/tracecmd/include/trace-local.h index a51f0d0..51abef1 100644 --- a/tracecmd/include/trace-local.h +++ b/tracecmd/include/trace-local.h @@ -243,6 +243,8 @@ void update_first_instance(struct buffer_instance *instance, int topt); void show_instance_file(struct buffer_instance *instance, const char *name); +int get_guest_vcpu_pid(unsigned int guest_cid, unsigned int guest_vcpu); + /* moved from trace-cmd.h */ void tracecmd_create_top_instance(char *name); void tracecmd_remove_instances(void); diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index 4459c90..fd7ca82 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -2873,10 +2873,12 @@ static bool is_digits(const char *s) return true; } +#define VCPUS_MAX 256 struct guest { char *name; int cid; int pid; + int cpu_pid[VCPUS_MAX]; }; static struct guest *guests; @@ -2894,6 +2896,46 @@ static char *get_qemu_guest_name(char *arg) return arg; } +static void read_qemu_guests_pids(char *guest_task, struct guest *guest) +{ + struct dirent *entry; + char path[PATH_MAX]; + char *buf = NULL; + size_t n = 0; + int vcpu; + DIR *dir; + FILE *f; + + snprintf(path, sizeof(path), "/proc/%s/task", guest_task); + dir = opendir(path); + if (!dir) + return; + + while ((entry = readdir(dir))) { + if (!(entry->d_type == DT_DIR && is_digits(entry->d_name))) + continue; + + snprintf(path, sizeof(path), "/proc/%s/task/%s/comm", + guest_task, entry->d_name); + f = fopen(path, "r"); + if (!f) + continue; + if (getline(&buf, &n, f) < 0) + goto next; + if (strncmp(buf, "CPU ", 4) != 0) + goto next; + + vcpu = atoi(buf+4); + if (!(vcpu >= 0 && vcpu < VCPUS_MAX)) + goto next; + guest->cpu_pid[vcpu] = atoi(entry->d_name); + +next: + fclose(f); + } + free(buf); +} + static void read_qemu_guests(void) { static bool initialized; @@ -2957,6 +2999,8 @@ static void read_qemu_guests(void) if (!is_qemu) goto next; + read_qemu_guests_pids(entry->d_name, &guest); + guests = realloc(guests, (guests_len + 1) * sizeof(*guests)); if (!guests) die("Can not allocate guest buffer"); @@ -3002,6 +3046,19 @@ static char *parse_guest_name(char *guest, int *cid, int *port) return guest; } +int get_guest_vcpu_pid(unsigned int guest_cid, unsigned int guest_vcpu) +{ + int i; + + if (!guests || guest_vcpu >= VCPUS_MAX) + return -1; + + for (i = 0; i < guests_len; i++) + if (guest_cid == guests[i].cid) + return guests[i].cpu_pid[guest_vcpu]; + return -1; +} + static void set_prio(int prio) { struct sched_param sp; From patchwork Tue Dec 3 10:35:12 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270947 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 024FE18EC for ; Tue, 3 Dec 2019 10:35:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CA98F2080A for ; Tue, 3 Dec 2019 10:35:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KIBN0+kj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726138AbfLCKfj (ORCPT ); Tue, 3 Dec 2019 05:35:39 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:34107 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726098AbfLCKfj (ORCPT ); Tue, 3 Dec 2019 05:35:39 -0500 Received: by mail-lj1-f193.google.com with SMTP id m6so3218797ljc.1 for ; Tue, 03 Dec 2019 02:35:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Irh037ZGGW4R8h8ErESe2jql4GwDXX/8LCDplJHfmvE=; b=KIBN0+kjRoqBdRn6ae5hfvnL4l/Koabn8iuaTGkg0Y6Ubhb/LyKG4Ihv1oEzIK1/zB uvpOiZnVnMjOoaTIZ2t9PR1znQzxiTvJR/MkUGg8KHrXERSAHIs4LfEnZlq0Pa44IoOK FUlSxQiH0k6K9vAK4fWRX7yC5rCRGMwXIJYDmgnRB3nKLtQIGVucU9FrhZrMaL/2asxI L+xqtlHJaVyOkzvbHz5qnzXN/kKMSrdcxrJyWg1bzt2DFhyzbTK2wHsE+oqgg/Wd9Aby v71TduzSbm4EeGORuTG8Qtkvx3ZA6+JW/Khr5MsIa2B56UCG5kSvzo7uXeXA8w1f/Akv qMMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Irh037ZGGW4R8h8ErESe2jql4GwDXX/8LCDplJHfmvE=; b=saYB5JhdjEtryzLzxVHcHwZcw2PnFlsYzMeNAaP5JmlzhwwuG3El76Ro6HplikERuh 798h7cxukLdqgQG4ypWK+Co7gozySU8WUdkw54GROlrsHj6lwCyYBQcxIzIuIa7owdhw WmO3yX8FdL2DuY4sLz0Rli3ESTZynrMQeXh1WZNxfeY8YEdFNNKYpluujJIT2ppNKpYL Q7dyAtzX6HwYX6sSFQDyPX/3QRNwxF/wSWxEHSGTwZubDRwBDB1iKdeYx08bcb11cQe+ U60wbkWFahZv/4/32Stm5ioRL6psSeajxtI6QNt5J4K2VYps97QSu2dIIJiS2x5mntEA nEMw== X-Gm-Message-State: APjAAAXhx1TCTw0lUN4ZZLcBGWgAWNa26tIAowc8HTxr8CPGwTAsqt0b j+QE9GzrawQ2zyVEvSfNWe6eJfC+Ovk= X-Google-Smtp-Source: APXvYqwruU9DaLKIb6xRV4Fw4pyF9TzhH9kk4auCOczJQ9JfXMMF0kQ85mZk43VJz8kRKldvx/JeOQ== X-Received: by 2002:a2e:2201:: with SMTP id i1mr2094350lji.110.1575369336155; Tue, 03 Dec 2019 02:35:36 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:35 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 08/18] trace-cmd: Implement new API tracecmd_add_option_v() Date: Tue, 3 Dec 2019 12:35:12 +0200 Message-Id: <20191203103522.482684-9-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org From: Tzvetomir Stoyanov A new tracecmd API tracecmd_add_option_v() is introduced. It adds new option in trace.dat, similar to tracecmd_add_option(), but the option's data is passed as list of buffers. The standard struct iovec is used as input parameter, containing the option's data buffers. Signed-off-by: Tzvetomir Stoyanov --- include/trace-cmd/trace-cmd.h | 5 ++ include/traceevent/event-parse.h | 1 + lib/trace-cmd/trace-output.c | 116 +++++++++++++++++++++++++++---- 3 files changed, 108 insertions(+), 14 deletions(-) diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 831bb1a..47fa463 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -261,11 +261,16 @@ struct tracecmd_output *tracecmd_create_init_file_override(const char *output_fi struct tracecmd_option *tracecmd_add_option(struct tracecmd_output *handle, unsigned short id, int size, const void *data); +struct tracecmd_option * +tracecmd_add_option_v(struct tracecmd_output *handle, + unsigned short id, const struct iovec *vector, int count); + struct tracecmd_option *tracecmd_add_buffer_option(struct tracecmd_output *handle, const char *name, int cpus); int tracecmd_write_cpus(struct tracecmd_output *handle, int cpus); int tracecmd_write_options(struct tracecmd_output *handle); +int tracecmd_append_options(struct tracecmd_output *handle); int tracecmd_update_option(struct tracecmd_output *handle, struct tracecmd_option *option, int size, const void *data); diff --git a/include/traceevent/event-parse.h b/include/traceevent/event-parse.h index a77af4c..30e06a7 100644 --- a/include/traceevent/event-parse.h +++ b/include/traceevent/event-parse.h @@ -11,6 +11,7 @@ #include #include #include +#include #include "traceevent/trace-seq.h" diff --git a/lib/trace-cmd/trace-output.c b/lib/trace-cmd/trace-output.c index be4d3f5..db65ee4 100644 --- a/lib/trace-cmd/trace-output.c +++ b/lib/trace-cmd/trace-output.c @@ -950,21 +950,27 @@ static struct tracecmd_output *create_file(const char *output_file, } /** - * tracecmd_add_option - add options to the file + * tracecmd_add_option_v - add options to the file * @handle: the output file handle name * @id: the id of the option * @size: the size of the option data * @data: the data to write to the file. + * @vector: array of vectors, pointing to the data to write in the file + * @count: number of items in the vector array + * * * Returns handle to update option if needed. * Just the content can be updated, with smaller or equal to * content than the specified size. */ struct tracecmd_option * -tracecmd_add_option(struct tracecmd_output *handle, - unsigned short id, int size, const void *data) +tracecmd_add_option_v(struct tracecmd_output *handle, + unsigned short id, const struct iovec *vector, int count) + { struct tracecmd_option *option; + char *data = NULL; + int i, size = 0; /* * We can only add options before they were written. @@ -973,32 +979,63 @@ tracecmd_add_option(struct tracecmd_output *handle, if (handle->options_written) return NULL; - handle->nr_options++; + for (i = 0; i < count; i++) + size += vector[i].iov_len; + /* Some IDs (like TRACECMD_OPTION_TRACECLOCK) pass vector with 0 / NULL data */ + if (size) { + data = malloc(size); + if (!data) { + warning("Insufficient memory"); + return NULL; + } + } option = malloc(sizeof(*option)); if (!option) { warning("Could not allocate space for option"); + free(data); return NULL; } - option->id = id; - option->size = size; - option->data = malloc(size); - if (!option->data) { - warning("Insufficient memory"); - free(option); - return NULL; + handle->nr_options++; + option->data = data; + for (i = 0; i < count; i++) { + if (vector[i].iov_base && vector[i].iov_len) { + memcpy(data, vector[i].iov_base, vector[i].iov_len); + data += vector[i].iov_len; + } } - /* Some IDs (like TRACECMD_OPTION_TRACECLOCK) pass 0 / NULL data */ - if (size) - memcpy(option->data, data, size); + option->size = size; + option->id = id; list_add_tail(&option->list, &handle->options); return option; } +/** + * tracecmd_add_option - add options to the file + * @handle: the output file handle name + * @id: the id of the option + * @size: the size of the option data + * @data: the data to write to the file. + * + * Returns handle to update option if needed. + * Just the content can be updated, with smaller or equal to + * content than the specified size. + */ +struct tracecmd_option * +tracecmd_add_option(struct tracecmd_output *handle, + unsigned short id, int size, const void *data) +{ + struct iovec vect; + + vect.iov_base = (void *) data; + vect.iov_len = size; + return tracecmd_add_option_v(handle, id, &vect, 1); +} + int tracecmd_write_cpus(struct tracecmd_output *handle, int cpus) { cpus = convert_endian_4(handle, cpus); @@ -1046,6 +1083,57 @@ int tracecmd_write_options(struct tracecmd_output *handle) return 0; } +int tracecmd_append_options(struct tracecmd_output *handle) +{ + struct tracecmd_option *options; + unsigned short option; + unsigned short endian2; + unsigned int endian4; + off_t offset; + int r; + + /* If already written, ignore */ + if (handle->options_written) + return 0; + + if (lseek64(handle->fd, 0, SEEK_END) == (off_t)-1) + return -1; + offset = lseek64(handle->fd, -2, SEEK_CUR); + if (offset == (off_t)-1) + return -1; + + r = pread(handle->fd, &option, 2, offset); + if (r != 2 || option != TRACECMD_OPTION_DONE) + return -1; + + list_for_each_entry(options, &handle->options, list) { + endian2 = convert_endian_2(handle, options->id); + if (do_write_check(handle, &endian2, 2)) + return -1; + + endian4 = convert_endian_4(handle, options->size); + if (do_write_check(handle, &endian4, 4)) + return -1; + + /* Save the data location in case it needs to be updated */ + options->offset = lseek64(handle->fd, 0, SEEK_CUR); + + if (do_write_check(handle, options->data, + options->size)) + return -1; + } + + option = TRACECMD_OPTION_DONE; + + if (do_write_check(handle, &option, 2)) + return -1; + + handle->options_written = 1; + handle->options_written = 1; + + return 0; +} + int tracecmd_update_option(struct tracecmd_output *handle, struct tracecmd_option *option, int size, const void *data) From patchwork Tue Dec 3 10:35:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270949 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2E0FA19B7 for ; Tue, 3 Dec 2019 10:35:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BED220848 for ; Tue, 3 Dec 2019 10:35:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BaPGGZFk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726098AbfLCKfj (ORCPT ); Tue, 3 Dec 2019 05:35:39 -0500 Received: from mail-lj1-f196.google.com ([209.85.208.196]:35941 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfLCKfj (ORCPT ); Tue, 3 Dec 2019 05:35:39 -0500 Received: by mail-lj1-f196.google.com with SMTP id r19so3211132ljg.3 for ; Tue, 03 Dec 2019 02:35:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=K8ZZRaXB75jmADvYv/7v8U9DJpWLr4FMA5xXySBgHmY=; b=BaPGGZFk5zUBQSzd5PshWr3VZf2dME9eIGpFVlsWSEqcOqCb6AzA7hOKV47l55NaMB w2PoAXgv3+65v3lvjLHOiPQWZH0/83P45O3Pbkq8EQivQRYnX7OqzoryJFADHLfmS+DY p50HEWCmYs213dmFvCaEKHZfq94XnbmObaKcX8qbPPfuLR5EbmO4mQcPzCQekfeCo1Kn F6hyMmAOt+aN4GuKtVjxusvOchJCKjS5xqPjFr8xIwV8ca4c4u3Q6G8BfvU/1ViZr+XZ 9Ga+HJnc4UsPi7DNgZzAOCrUmA8wp6S3d7VQx8gyS+VByoezBAqP6t39eoWnxb4eno/k Ix9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=K8ZZRaXB75jmADvYv/7v8U9DJpWLr4FMA5xXySBgHmY=; b=Y+tj5q9LRsl0tZtweyZ7v24QoLkF8A5PY9+4fZJj5t26Tr/nG1+Nrt64jgjnkc0/hv pEK23He4IWK6NvrKKJ1OQ0REPZ7kseGg/AJDoaRTgt0eU1tYSicuxcjs8cwJ9NOns6ZI DqLu8KJ7wxSQyFjTURDmDM1lmjnVNDQjfT2MhnknTK2pmXEiFS8QuCNJR+3q2WfYqwnz zNDVIbSywD1feEwwurDDBCiQ0rB2yA00LV2uI5nCgBTVXtAu5XZ7+fFeffabGi1Lij0y J/XAKG3BnThE27tVzKuUYAioZKSFyeoufxmCCiUVeLfaGiJEXI9NLZyDliU6xLYjyHj/ gjkQ== X-Gm-Message-State: APjAAAUjIgxTfEfmGDCIvlXJC0dvNTkym+ea8vXgnEA7CA12QJ8eBOA0 0JjO5wUoYAZU1F/SGwtj+xE= X-Google-Smtp-Source: APXvYqyblYqPNiJ37yLTjVh+q81Q/AqRZ2jybQ6XMsoHu3TnkdrOjdZ+dtoM0k7xXXPzK4oD6mHcVg== X-Received: by 2002:a2e:8606:: with SMTP id a6mr1346712lji.119.1575369337346; Tue, 03 Dec 2019 02:35:37 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:36 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 09/18] trace-cmd: Add new API to generate a unique ID of the tracing session Date: Tue, 3 Dec 2019 12:35:13 +0200 Message-Id: <20191203103522.482684-10-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org A new libtracecmd API is implemented: unsigned long long tracecmd_generate_traceid(void); At trace-cmd init phase a unique ID, used for the current tracing session. Signed-off-by: Tzvetomir Stoyanov (VMware) --- include/trace-cmd/trace-cmd.h | 1 + lib/trace-cmd/trace-util.c | 31 +++++++++++++++++++++++++++++++ tracecmd/include/trace-local.h | 1 + tracecmd/trace-record.c | 1 + 4 files changed, 34 insertions(+) diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 47fa463..6d50b08 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -441,6 +441,7 @@ void tracecmd_plog_error(const char *fmt, ...); int tracecmd_set_logfile(char *logfile); /* --- System --- */ +unsigned long long tracecmd_generate_traceid(void); int tracecmd_count_cpus(void); /* --- Hack! --- */ diff --git a/lib/trace-cmd/trace-util.c b/lib/trace-cmd/trace-util.c index a54a905..2231eb8 100644 --- a/lib/trace-cmd/trace-util.c +++ b/lib/trace-cmd/trace-util.c @@ -18,6 +18,8 @@ #include #include #include +#include +#include #include "trace-cmd.h" #include "event-utils.h" @@ -1299,3 +1301,32 @@ error: tracecmd_put_tracing_file(path); return ret; } + +#define FNV_64_PRIME 0x100000001b3ULL +unsigned long long tracecmd_generate_traceid(void) +{ + unsigned long long hash = 0; + unsigned char *ustr; + struct sysinfo sinfo; + struct timespec ts; + char *str = NULL; + + clock_gettime(CLOCK_MONOTONIC_RAW, &ts); + sysinfo(&sinfo); + asprintf(&str, "%ld %ld %ld %ld %ld %ld %ld %ld %d", + ts.tv_sec, ts.tv_nsec, + sinfo.loads[0], sinfo.loads[1], sinfo.loads[2], + sinfo.freeram, sinfo.sharedram, sinfo.freeswap, + sinfo.procs); + if (!str) + return 0; + ustr = (unsigned char *)str; + hash = 0; + while (*ustr) { + hash ^= (unsigned long long)*ustr++; + hash *= FNV_64_PRIME; + } + + free(str); + return hash; +} diff --git a/tracecmd/include/trace-local.h b/tracecmd/include/trace-local.h index 51abef1..6203e0d 100644 --- a/tracecmd/include/trace-local.h +++ b/tracecmd/include/trace-local.h @@ -182,6 +182,7 @@ struct pid_addr_maps { struct buffer_instance { struct buffer_instance *next; struct tracecmd_instance *ftrace; + unsigned long long trace_id; char *cpumask; struct event_list *events; struct event_list **event_next; diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index fd7ca82..1583c53 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -5062,6 +5062,7 @@ void init_top_instance(void) top_instance.ftrace = tracecmd_create_instance(NULL); top_instance.cpu_count = tracecmd_count_cpus(); top_instance.flags = BUFFER_FL_KEEP; + top_instance.trace_id = tracecmd_generate_traceid(); tracecmd_init_instance(&top_instance); } From patchwork Tue Dec 3 10:35:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270951 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D6B6E1953 for ; Tue, 3 Dec 2019 10:35:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4FAC2080F for ; Tue, 3 Dec 2019 10:35:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oIIGHNcJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726139AbfLCKfl (ORCPT ); Tue, 3 Dec 2019 05:35:41 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:37684 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbfLCKfl (ORCPT ); Tue, 3 Dec 2019 05:35:41 -0500 Received: by mail-lj1-f195.google.com with SMTP id u17so3205233lja.4 for ; Tue, 03 Dec 2019 02:35:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dJh9bOTjIBbrOvc3zjfyKy7sz2k7yipWu0hohdR9QZQ=; b=oIIGHNcJ9W4sBhJ4t4iYLfm+xqpJGWvKj5KJWetiE6so9Fh+0nCt/WTqYjfDOWHToP JRbE9z+UeFC4jzIbctD+py0W2VvAUBgaUV/1txRZOoKqkaHu5/n+XvtneXO17UdZZJz0 3UkbQJx6d2uAGFqlEdsu2noD2rht6+zmFJDvaugCZjk+j9EglOkJ9dbyW0nvcFn1N7Gk LPBerUOmen+pPmV7GSgMdSNoe8LeVMeq/A9fQQtIGqlKgZ45INkxTRmD+kS61rZIl+OL u3uWFRPX2n1gDDGUkFaOqnxe7q6n54bu/Ck/vPm2pe3+4Qe40sbIOt3BOs9djGTNDxOj 3rzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dJh9bOTjIBbrOvc3zjfyKy7sz2k7yipWu0hohdR9QZQ=; b=dhHPik+F1QZe8H+QYIIku0vQ7rWb4Fjy1OkREMuhpomJNFDHb2XMFZSgaOQWVBaZa5 XFfTCR2uZcMKoDWSDhyXsI8IuE0yX4/W2WcxcLEgt5G2Rzw2y4y+AIXgLQbxyX2ssq8I F+N+k0r9NuQYB/af463jI4GdxQix0dHv3o1Zfp/Nle21uA0TnWfV+c6ZLnW3RRzKhRmu rm91N1yWMDSFa0uxzBemRykaEUV07zMhdiebLqahcs3xNPT1Xyv1BVqNLKsq3TxYXnCu Hsr3oAQDVy023xsIz2XlTz12SiJayfPH1q7vpXnW92+K93cD2LrHudl//4bfteCWwnyE z2ow== X-Gm-Message-State: APjAAAU2RvZTAlMOs8ZzaTRvzUquFniEICt4vPWMloM+Fy6h8Cmioh41 qNQpmMZDFWzhreJV88DCsEY= X-Google-Smtp-Source: APXvYqxOJrT2FKI3LL4R7rpHpVN7mO/KtLhVn5RAK3PNpU3gZl732EYtnTDOlwx44ijlVa5/+gSuoA== X-Received: by 2002:a2e:b52a:: with SMTP id z10mr2067892ljm.178.1575369338583; Tue, 03 Dec 2019 02:35:38 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:38 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 10/18] trace-cmd: Store the session tracing ID in the trace.dat file Date: Tue, 3 Dec 2019 12:35:14 +0200 Message-Id: <20191203103522.482684-11-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org The ID of the current tracing session is stored in the trace.dat file. A new file option is introduced: TRACECMD_OPTION_TRACEID The data is stored in the file as NULL terminated string: "\nTraceID: %llu\n" A new libtracecmd API is introduced, to get the ID when the trace.dat file is read: unsigned long long tracecmd_get_traceid(struct tracecmd_input *handle); Signed-off-by: Tzvetomir Stoyanov (VMware) --- include/trace-cmd/trace-cmd.h | 2 ++ lib/trace-cmd/trace-input.c | 25 +++++++++++++++++++++++++ tracecmd/trace-record.c | 15 +++++++++++++++ 3 files changed, 42 insertions(+) diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 6d50b08..82def44 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -86,6 +86,7 @@ enum { TRACECMD_OPTION_CPUCOUNT, TRACECMD_OPTION_VERSION, TRACECMD_OPTION_PROCMAPS, + TRACECMD_OPTION_TRACEID, }; enum { @@ -128,6 +129,7 @@ int tracecmd_copy_headers(struct tracecmd_input *handle, int fd); void tracecmd_set_flag(struct tracecmd_input *handle, int flag); void tracecmd_clear_flag(struct tracecmd_input *handle, int flag); unsigned long tracecmd_get_flags(struct tracecmd_input *handle); +unsigned long long tracecmd_get_traceid(struct tracecmd_input *handle); void tracecmd_parse_trace_clock(struct tracecmd_input *handle, char *file, int size); diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c index 91362f3..40d9825 100644 --- a/lib/trace-cmd/trace-input.c +++ b/lib/trace-cmd/trace-input.c @@ -79,6 +79,7 @@ struct tracecmd_input { struct tep_plugin_list *plugin_list; struct tracecmd_input *parent; unsigned long flags; + unsigned long long trace_id; int fd; int long_size; int page_size; @@ -2169,6 +2170,15 @@ static void procmap_free(struct pid_addr_maps *maps) free(maps); } +static int trace_traceid_load(struct tracecmd_input *handle, char *buf) +{ + + if (sscanf(buf, "%*s %llu", &handle->trace_id) == 1) + return 0; + + return -1; +} + #define STR_PROCMAP_LINE_MAX (PATH_MAX+22) static int trace_pid_map_load(struct tracecmd_input *handle, char *buf) { @@ -2406,6 +2416,10 @@ static int handle_options(struct tracecmd_input *handle) if (buf[size-1] == '\0') trace_pid_map_load(handle, buf); break; + case TRACECMD_OPTION_TRACEID: + if (buf[size-1] == '\0') + trace_traceid_load(handle, buf); + break; default: warning("unknown option %d", option); break; @@ -3507,3 +3521,14 @@ void tracecmd_set_show_data_func(struct tracecmd_input *handle, { handle->show_data_func = func; } + +/** + * tracecmd_get_traceid - get the trace id of the session + * @handle: input handle for the trace.dat file + * + * Returns the trace id, written in the trace file + */ +unsigned long long tracecmd_get_traceid(struct tracecmd_input *handle) +{ + return handle->trace_id; +} diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index 1583c53..01a74f1 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -3715,6 +3715,19 @@ add_pid_maps(struct tracecmd_output *handle, struct buffer_instance *instance) trace_seq_destroy(&s); } +static void +add_trace_id(struct tracecmd_output *handle, struct buffer_instance *instance) +{ + char *str = NULL; + int len; + + len = asprintf(&str, "\nTraceID: %llu\n", instance->trace_id); + if (len < 1) + return; + tracecmd_add_option(handle, TRACECMD_OPTION_TRACEID, len + 1, str); + free(str); +} + static void add_buffer_stat(struct tracecmd_output *handle, struct buffer_instance *instance) { @@ -3818,6 +3831,8 @@ static void add_options(struct tracecmd_output *handle, struct common_record_con add_option_hooks(handle); add_uname(handle); add_version(handle); + if (!no_top_instance()) + add_trace_id(handle, &top_instance); } static void write_guest_file(struct buffer_instance *instance) From patchwork Tue Dec 3 10:35:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270957 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 825181A28 for ; Tue, 3 Dec 2019 10:35:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 562C42084B for ; Tue, 3 Dec 2019 10:35:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ntTCeRB+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726182AbfLCKfn (ORCPT ); Tue, 3 Dec 2019 05:35:43 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:37685 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfLCKfn (ORCPT ); Tue, 3 Dec 2019 05:35:43 -0500 Received: by mail-lj1-f194.google.com with SMTP id u17so3205290lja.4 for ; Tue, 03 Dec 2019 02:35:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7rulsqHWqiPANINuxP9O9HND35R2Nw4MwCZU59/68X0=; b=ntTCeRB++mJcVaa/pKrPZ3+6E0W3t63XD76+1fn6/4xTL1EMAlxuUl1Ka8zGbCxNlT UtSQD0X/mXHd6J4eZ4GT1X8Tk49NyLuSVWerAM8K+0BVWfQut5iEfXMFJB83JnuwWyaH CWRxbejs0fMEzRDuVXZP7QZlGXUr2gyzmq8haTCFo4xm+HEKEMMmyr7FLh0uYcqmd4L3 UtiMH3a6UN0oaN9Ztgs6OR4Oiv9FilhDO+ykxE3dgs4BSw71lpeD9zREK9+HXczTDG9S 8vtfHkC8iKUpvXMClwjjzzHkiohLzrnoYBNatZLzyDvd70PYIqs6dSGAbkrUB/lKZBWJ jMdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7rulsqHWqiPANINuxP9O9HND35R2Nw4MwCZU59/68X0=; b=G9hL0AdOoDPOxvXjwH52ZHDUhV2rFtgdZrJUzEjW6TAPAcdYz+3GL57b6EM7tpxuwd Gfxffgx90Mpezszd5kcfAGSWUvdGCqukm2gHPZgQetBnmDKY0R8l5P1CNOkFMcZ/IZ2m d8CfvJAbK+eDr1JIAK8FCRnXu6Kgd7QjT/xnuiYH2jr7jsQMrSYdiLDqi3p3UYPrPQgv Iazr1CBDT5fZrHifBaR0GN9M2HqLKOfbPlGedeATcCVD3IsBsBfjBmJ+97UBs6hHyNYr +4qB38Q2VA9g5LsgvubgKUazZ9onH4EOk5eXU/MpmUfwpd7xymr5YOWYXHi78qqYiIbL GsJg== X-Gm-Message-State: APjAAAXjUakJ7vh7jcGTevQv/z0PYKk/F74YY6rXNJ8zNKCd7d7OAWMF WYDMtzAOepXsjV3JQ/Vh39M= X-Google-Smtp-Source: APXvYqxZ4y0bd7tf8uFHiES6S6Ju4rdBit8jWOjnmk6vsuMxVYTIdA32EBIkiioeRYx7Kx8u3OVv2w== X-Received: by 2002:a2e:8eda:: with SMTP id e26mr2016568ljl.65.1575369339793; Tue, 03 Dec 2019 02:35:39 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:39 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 11/18] trace-cmd: Exchange tracing IDs between host and guest Date: Tue, 3 Dec 2019 12:35:15 +0200 Message-Id: <20191203103522.482684-12-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org Extend the trace request and trace reply messages, to include also the IDs of host and guest tracing sessions. Those IDs are used to unambiguously match the tracing sessions, when reading trace.dat files. Signed-off-by: Tzvetomir Stoyanov (VMware) --- include/trace-cmd/trace-cmd.h | 12 ++++++++---- lib/trace-cmd/trace-msg.c | 31 +++++++++++++++++++++++-------- tracecmd/include/trace-local.h | 5 +++-- tracecmd/trace-agent.c | 12 +++++++----- tracecmd/trace-record.c | 12 +++++++++--- 5 files changed, 50 insertions(+), 22 deletions(-) diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 82def44..90fa146 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -353,16 +353,20 @@ bool tracecmd_msg_done(struct tracecmd_msg_handle *msg_handle); void tracecmd_msg_set_done(struct tracecmd_msg_handle *msg_handle); int tracecmd_msg_send_trace_req(struct tracecmd_msg_handle *msg_handle, - int argc, char **argv, bool use_fifos); + int argc, char **argv, bool use_fifos, + unsigned long long trace_id); int tracecmd_msg_recv_trace_req(struct tracecmd_msg_handle *msg_handle, - int *argc, char ***argv, bool *use_fifos); + int *argc, char ***argv, bool *use_fifos, + unsigned long long *trace_id); int tracecmd_msg_send_trace_resp(struct tracecmd_msg_handle *msg_handle, int nr_cpus, int page_size, - unsigned int *ports, bool use_fifos); + unsigned int *ports, bool use_fifos, + unsigned long long trace_id); int tracecmd_msg_recv_trace_resp(struct tracecmd_msg_handle *msg_handle, int *nr_cpus, int *page_size, - unsigned int **ports, bool *use_fifos); + unsigned int **ports, bool *use_fifos, + unsigned long long *trace_id); /* --- ftrace instances --- */ struct tracecmd_instance { diff --git a/lib/trace-cmd/trace-msg.c b/lib/trace-cmd/trace-msg.c index 9c8a690..a34297f 100644 --- a/lib/trace-cmd/trace-msg.c +++ b/lib/trace-cmd/trace-msg.c @@ -63,12 +63,14 @@ struct tracecmd_msg_rinit { struct tracecmd_msg_trace_req { be32 flags; be32 argc; + u64 trace_id; } __attribute__((packed)); struct tracecmd_msg_trace_resp { be32 flags; be32 cpus; be32 page_size; + u64 trace_id; } __attribute__((packed)); struct tracecmd_msg_header { @@ -811,7 +813,8 @@ int tracecmd_msg_wait_close_resp(struct tracecmd_msg_handle *msg_handle) return tracecmd_msg_wait_for_cmd(msg_handle, MSG_CLOSE_RESP); } -static int make_trace_req(struct tracecmd_msg *msg, int argc, char **argv, bool use_fifos) +static int make_trace_req(struct tracecmd_msg *msg, int argc, char **argv, + bool use_fifos, unsigned long long trace_id) { size_t args_size = 0; char *p; @@ -823,6 +826,7 @@ static int make_trace_req(struct tracecmd_msg *msg, int argc, char **argv, bool msg->hdr.size = htonl(ntohl(msg->hdr.size) + args_size); msg->trace_req.flags = use_fifos ? htonl(MSG_TRACE_USE_FIFOS) : htonl(0); msg->trace_req.argc = htonl(argc); + msg->trace_req.trace_id = htonll(trace_id); msg->buf = calloc(args_size, 1); if (!msg->buf) return -ENOMEM; @@ -835,13 +839,15 @@ static int make_trace_req(struct tracecmd_msg *msg, int argc, char **argv, bool } int tracecmd_msg_send_trace_req(struct tracecmd_msg_handle *msg_handle, - int argc, char **argv, bool use_fifos) + int argc, char **argv, bool use_fifos, + unsigned long long trace_id) { struct tracecmd_msg msg; int ret; tracecmd_msg_init(MSG_TRACE_REQ, &msg); - ret = make_trace_req(&msg, argc, argv, use_fifos); + ret = make_trace_req(&msg, argc, argv, + use_fifos, trace_id); if (ret < 0) return ret; @@ -854,7 +860,8 @@ int tracecmd_msg_send_trace_req(struct tracecmd_msg_handle *msg_handle, * free(argv); */ int tracecmd_msg_recv_trace_req(struct tracecmd_msg_handle *msg_handle, - int *argc, char ***argv, bool *use_fifos) + int *argc, char ***argv, bool *use_fifos, + unsigned long long *trace_id) { struct tracecmd_msg msg; char *p, *buf_end, **args; @@ -901,6 +908,7 @@ int tracecmd_msg_recv_trace_req(struct tracecmd_msg_handle *msg_handle, *argc = nr_args; *argv = args; *use_fifos = ntohl(msg.trace_req.flags) & MSG_TRACE_USE_FIFOS; + *trace_id = ntohll(msg.trace_req.trace_id); /* * On success we're passing msg.buf to the caller through argv[0] so we @@ -921,7 +929,8 @@ out: } static int make_trace_resp(struct tracecmd_msg *msg, int page_size, int nr_cpus, - unsigned int *ports, bool use_fifos) + unsigned int *ports, bool use_fifos, + unsigned long long trace_id) { int data_size; @@ -935,19 +944,22 @@ static int make_trace_resp(struct tracecmd_msg *msg, int page_size, int nr_cpus, msg->trace_resp.flags = use_fifos ? htonl(MSG_TRACE_USE_FIFOS) : htonl(0); msg->trace_resp.cpus = htonl(nr_cpus); msg->trace_resp.page_size = htonl(page_size); + msg->trace_resp.trace_id = htonll(trace_id); return 0; } int tracecmd_msg_send_trace_resp(struct tracecmd_msg_handle *msg_handle, int nr_cpus, int page_size, - unsigned int *ports, bool use_fifos) + unsigned int *ports, bool use_fifos, + unsigned long long trace_id) { struct tracecmd_msg msg; int ret; tracecmd_msg_init(MSG_TRACE_RESP, &msg); - ret = make_trace_resp(&msg, page_size, nr_cpus, ports, use_fifos); + ret = make_trace_resp(&msg, page_size, nr_cpus, ports, + use_fifos, trace_id); if (ret < 0) return ret; @@ -956,13 +968,15 @@ int tracecmd_msg_send_trace_resp(struct tracecmd_msg_handle *msg_handle, int tracecmd_msg_recv_trace_resp(struct tracecmd_msg_handle *msg_handle, int *nr_cpus, int *page_size, - unsigned int **ports, bool *use_fifos) + unsigned int **ports, bool *use_fifos, + unsigned long long *trace_id) { struct tracecmd_msg msg; char *p, *buf_end; ssize_t buf_len; int i, ret; + memset(&msg, 0, sizeof(msg)); ret = tracecmd_msg_recv(msg_handle->fd, &msg); if (ret < 0) return ret; @@ -981,6 +995,7 @@ int tracecmd_msg_recv_trace_resp(struct tracecmd_msg_handle *msg_handle, *use_fifos = ntohl(msg.trace_resp.flags) & MSG_TRACE_USE_FIFOS; *nr_cpus = ntohl(msg.trace_resp.cpus); *page_size = ntohl(msg.trace_resp.page_size); + *trace_id = ntohll(msg.trace_resp.trace_id); *ports = calloc(*nr_cpus, sizeof(**ports)); if (!*ports) { ret = -ENOMEM; diff --git a/tracecmd/include/trace-local.h b/tracecmd/include/trace-local.h index 6203e0d..a6f79c5 100644 --- a/tracecmd/include/trace-local.h +++ b/tracecmd/include/trace-local.h @@ -98,8 +98,9 @@ void trace_usage(int argc, char **argv); int trace_record_agent(struct tracecmd_msg_handle *msg_handle, int cpus, int *fds, - int argc, char **argv, bool use_fifos); - + int argc, char **argv, + bool use_fifos, + unsigned long long trace_id); struct hook_list; void trace_init_profile(struct tracecmd_input *handle, struct hook_list *hooks, diff --git a/tracecmd/trace-agent.c b/tracecmd/trace-agent.c index 1c6e0a3..cc330b7 100644 --- a/tracecmd/trace-agent.c +++ b/tracecmd/trace-agent.c @@ -128,6 +128,7 @@ cleanup: static void agent_handle(int sd, int nr_cpus, int page_size) { struct tracecmd_msg_handle *msg_handle; + unsigned long long trace_id; unsigned int *ports; char **argv = NULL; int argc = 0; @@ -144,7 +145,8 @@ static void agent_handle(int sd, int nr_cpus, int page_size) if (!msg_handle) die("Failed to allocate message handle"); - ret = tracecmd_msg_recv_trace_req(msg_handle, &argc, &argv, &use_fifos); + ret = tracecmd_msg_recv_trace_req(msg_handle, &argc, &argv, + &use_fifos, &trace_id); if (ret < 0) die("Failed to receive trace request"); @@ -153,13 +155,13 @@ static void agent_handle(int sd, int nr_cpus, int page_size) if (!use_fifos) make_vsocks(nr_cpus, fds, ports); - + trace_id = tracecmd_generate_traceid(); ret = tracecmd_msg_send_trace_resp(msg_handle, nr_cpus, page_size, - ports, use_fifos); + ports, use_fifos, trace_id); if (ret < 0) die("Failed to send trace response"); - - trace_record_agent(msg_handle, nr_cpus, fds, argc, argv, use_fifos); + trace_record_agent(msg_handle, nr_cpus, fds, argc, argv, + use_fifos, trace_id); free(argv[0]); free(argv); diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index 01a74f1..e51134f 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -3507,12 +3507,16 @@ static void connect_to_agent(struct buffer_instance *instance) die("Failed to allocate message handle"); ret = tracecmd_msg_send_trace_req(msg_handle, instance->argc, - instance->argv, use_fifos); + instance->argv, use_fifos, + top_instance.trace_id); + if (ret < 0) die("Failed to send trace request"); ret = tracecmd_msg_recv_trace_resp(msg_handle, &nr_cpus, &page_size, - &ports, &use_fifos); + &ports, &use_fifos, + &instance->trace_id); + if (ret < 0) die("Failed to receive trace response"); @@ -6117,7 +6121,8 @@ void trace_record(int argc, char **argv) int trace_record_agent(struct tracecmd_msg_handle *msg_handle, int cpus, int *fds, int argc, char **argv, - bool use_fifos) + bool use_fifos, + unsigned long long trace_id) { struct common_record_context ctx; char **argv_plus; @@ -6147,6 +6152,7 @@ int trace_record_agent(struct tracecmd_msg_handle *msg_handle, ctx.instance->flags |= BUFFER_FL_AGENT; ctx.instance->msg_handle = msg_handle; msg_handle->version = V3_PROTOCOL; + top_instance.trace_id = trace_id; record_trace(argc, argv, &ctx); free(argv_plus); From patchwork Tue Dec 3 10:35:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270955 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A289519B8 for ; Tue, 3 Dec 2019 10:35:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 766BF205ED for ; Tue, 3 Dec 2019 10:35:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bXscYGym" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726190AbfLCKfo (ORCPT ); Tue, 3 Dec 2019 05:35:44 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:35697 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbfLCKfo (ORCPT ); Tue, 3 Dec 2019 05:35:44 -0500 Received: by mail-lj1-f195.google.com with SMTP id j6so3215691lja.2 for ; Tue, 03 Dec 2019 02:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B224P4RxVMyJM0B0WPGLDNxjdh952JhNi7+WGoEhibc=; b=bXscYGymLeo7EgQkMycQFKi0uEsoADHivAcnfRjaWO/To/bc0DaNvQI0/ORWFhNtzw HLkHuQbiSUAGF2QJaYzvU8a6KIlYYWPHVqA+LKkSYgyFFJt2qDm++Sbf2pDhANKvMI/v 3otMbqXzCoG85aLhZdPn534K6w20MmMWIZRQYBZQ6HLzJN3r634LS+2G8/WUu91RVxnG 5dhWag4BpzXhXn2CCaN6jXAWcmvPXpPsoNYSgD429VbVz8iXr5YoE6rbQVm7GmW9opyV JVc43whf9RkGYHMWy3OAe03vhMKiEu0yMX+85sRIPUsDkprZyKuwlPDcjpoc5R+Oetkg 37gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B224P4RxVMyJM0B0WPGLDNxjdh952JhNi7+WGoEhibc=; b=ZkuvY3M3fImjT7zgT6LK0bzJV69u1svABS1prIs8IENxAe/EVsEmHg76D5XAxggnnY B300GQKulKs94QUiW/E9S/C2+MGiUjY06lwbYesI8/81QqAs19QWz9hNDDKpZFoUNJgL 2lGI6w95KR6/uqyhYVEKhNazTHCySDZoJjmgLi/vEnNDm3G8IrVC6pGEHyQXA1uNSfyc jbfh1o82nUWfQ6bzw3zj+iAAP2jxh1Z0GX8lqZXFP5OwC62ULmRss4spifBS5He+r4lr 1RLmJKNL3pnMJsiSGLCGz/Ca7iGFPjKSuCoO8AJxUFim3xIS/38wtIiAD8NIQ9whbzBf d6IA== X-Gm-Message-State: APjAAAUL+Omm00x0Sbi+FlZkjHwgz2dFU0bwGPhtSQwooyUbsQiyvLs1 9wX7bPDyvKxEfieZKHDMZAs= X-Google-Smtp-Source: APXvYqxZAg4CxHyRxrq2wAKDLyA2ayzwHzBMO8C4K2+aZPSGuP1VBixXis1hO6t/CFudBG8VFXjPLA== X-Received: by 2002:a2e:7f08:: with SMTP id a8mr2028911ljd.164.1575369340849; Tue, 03 Dec 2019 02:35:40 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:40 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 12/18] trace-cmd: Implement new option in trace.dat file: TRACECMD_OPTION_TIME_SHIFT Date: Tue, 3 Dec 2019 12:35:16 +0200 Message-Id: <20191203103522.482684-13-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org From: Tzvetomir Stoyanov The TRACECMD_OPTION_TIME_SHIFT is used when synchronizing trace time stamps between two trace.dat files. It contains multiple long long (time, offset) pairs, describing time stamps _offset_, measured in the given local _time_. The content of the option buffer is: 8 bytes - long long integer, ID of the tracing session 4 bytes - integer, count of timestamp offsets long long array of size _count_, local time in which the offset is measured long long array of size _count_, offset of the time stamps Signed-off-by: Tzvetomir Stoyanov --- include/trace-cmd/trace-cmd.h | 6 ++ lib/trace-cmd/trace-input.c | 170 +++++++++++++++++++++++++++++++++- 2 files changed, 174 insertions(+), 2 deletions(-) diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 90fa146..1240b4a 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -87,6 +87,7 @@ enum { TRACECMD_OPTION_VERSION, TRACECMD_OPTION_PROCMAPS, TRACECMD_OPTION_TRACEID, + TRACECMD_OPTION_TIME_SHIFT, }; enum { @@ -130,6 +131,11 @@ void tracecmd_set_flag(struct tracecmd_input *handle, int flag); void tracecmd_clear_flag(struct tracecmd_input *handle, int flag); unsigned long tracecmd_get_flags(struct tracecmd_input *handle); unsigned long long tracecmd_get_traceid(struct tracecmd_input *handle); +int tracecmd_get_guest_cpumap(struct tracecmd_input *handle, + unsigned long long trace_id, + char *name, + int *vcpu_count, int *cpu_pid); +unsigned long long tracecmd_get_tsync_peer(struct tracecmd_input *handle); void tracecmd_parse_trace_clock(struct tracecmd_input *handle, char *file, int size); diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c index 40d9825..a6b675a 100644 --- a/lib/trace-cmd/trace-input.c +++ b/lib/trace-cmd/trace-input.c @@ -74,6 +74,18 @@ struct input_buffer_instance { size_t offset; }; +struct ts_offset_sample { + long long time; + long long offset; +}; + +struct host_trace_info { + bool sync_enable; + unsigned long long trace_id; + int ts_samples_count; + struct ts_offset_sample *ts_samples; +}; + struct tracecmd_input { struct tep_handle *pevent; struct tep_plugin_list *plugin_list; @@ -92,6 +104,7 @@ struct tracecmd_input { bool use_pipe; struct cpu_data *cpu_data; long long ts_offset; + struct host_trace_info host; double ts2secs; char * cpustats; char * uname; @@ -1072,6 +1085,67 @@ static void free_next(struct tracecmd_input *handle, int cpu) free_record(record); } +static inline unsigned long long +timestamp_correction_calc(unsigned long long ts, struct ts_offset_sample *min, + struct ts_offset_sample *max) +{ + long long tscor = min->offset + + (((((long long)ts) - min->time)* + (max->offset-min->offset))/(max->time-min->time)); + + if (tscor < 0) + return ts - llabs(tscor); + + return ts + tscor; +} + +static unsigned long long timestamp_correct(unsigned long long ts, + struct tracecmd_input *handle) +{ + struct host_trace_info *host = &handle->host; + int min, mid, max; + + if (handle->ts_offset) + return ts + handle->ts_offset; + + if (!host->sync_enable || !host->ts_samples_count || !host->ts_samples) + return ts; + + /* We have one sample, nothing to calc here */ + if (host->ts_samples_count == 1) + return ts + host->ts_samples[0].offset; + + /* We have two samples, nothing to search here */ + if (host->ts_samples_count == 2) + return timestamp_correction_calc(ts, &host->ts_samples[0], + &host->ts_samples[1]); + + /* We have more than two samples */ + if (ts <= host->ts_samples[0].time) + return timestamp_correction_calc(ts, + &host->ts_samples[0], + &host->ts_samples[1]); + else if (ts >= host->ts_samples[host->ts_samples_count-1].time) + return timestamp_correction_calc(ts, + &host->ts_samples[host->ts_samples_count-2], + &host->ts_samples[host->ts_samples_count-1]); + min = 0; + max = host->ts_samples_count-1; + mid = (min + max)/2; + while (min <= max) { + if (ts < host->ts_samples[mid].time) + max = mid - 1; + else if (ts > host->ts_samples[mid].time) + min = mid + 1; + else + break; + mid = (min + max)/2; + } + + return timestamp_correction_calc(ts, &host->ts_samples[mid], + &host->ts_samples[mid+1]); +} + /* * Page is mapped, now read in the page header info. */ @@ -1093,7 +1167,7 @@ static int update_page_info(struct tracecmd_input *handle, int cpu) kbuffer_subbuffer_size(kbuf)); return -1; } - handle->cpu_data[cpu].timestamp = kbuffer_timestamp(kbuf) + handle->ts_offset; + handle->cpu_data[cpu].timestamp = timestamp_correct(kbuffer_timestamp(kbuf), handle); if (handle->ts2secs) handle->cpu_data[cpu].timestamp *= handle->ts2secs; @@ -1820,7 +1894,7 @@ read_again: goto read_again; } - handle->cpu_data[cpu].timestamp = ts + handle->ts_offset; + handle->cpu_data[cpu].timestamp = timestamp_correct(ts, handle); if (handle->ts2secs) { handle->cpu_data[cpu].timestamp *= handle->ts2secs; @@ -2143,6 +2217,47 @@ void tracecmd_set_ts2secs(struct tracecmd_input *handle, handle->use_trace_clock = false; } +static int tsync_offset_cmp(const void *a, const void *b) +{ + struct ts_offset_sample *ts_a = (struct ts_offset_sample *)a; + struct ts_offset_sample *ts_b = (struct ts_offset_sample *)b; + + if (ts_a->time > ts_b->time) + return 1; + if (ts_a->time < ts_b->time) + return -1; + return 0; +} + +static void tsync_offset_load(struct tracecmd_input *handle, char *buf) +{ + struct host_trace_info *host = &handle->host; + long long *buf8 = (long long *)buf; + int i, j; + + for (i = 0; i < host->ts_samples_count; i++) { + host->ts_samples[i].time = tep_read_number(handle->pevent, + buf8 + i, 8); + host->ts_samples[i].offset = tep_read_number(handle->pevent, + buf8 + host->ts_samples_count+i, 8); + } + qsort(host->ts_samples, host->ts_samples_count, + sizeof(struct ts_offset_sample), tsync_offset_cmp); + /* Filter possible samples with equal time */ + for (i = 0, j = 0; i < host->ts_samples_count; i++) { + if (i == 0 || host->ts_samples[i].time != host->ts_samples[i-1].time) + host->ts_samples[j++] = host->ts_samples[i]; + } + host->ts_samples_count = j; + host->sync_enable = true; +} + +static void trace_tsync_offset_free(struct host_trace_info *host) +{ + free(host->ts_samples); + host->ts_samples = NULL; +} + static int trace_pid_map_cmp(const void *a, const void *b) { struct tracecmd_proc_addr_map *m_a = (struct tracecmd_proc_addr_map *)a; @@ -2323,6 +2438,7 @@ static int handle_options(struct tracecmd_input *handle) struct input_buffer_instance *buffer; struct hook_list *hook; char *buf; + int sampes_size; int cpus; /* By default, use usecs, unless told otherwise */ @@ -2370,6 +2486,28 @@ static int handle_options(struct tracecmd_input *handle) offset = strtoll(buf, NULL, 0); handle->ts_offset += offset; break; + case TRACECMD_OPTION_TIME_SHIFT: + /* + * long long int (8 bytes) trace session ID + * int (4 bytes) count of timestamp offsets. + * long long array of size [count] of times, + * when the offsets were calculated. + * long long array of size [count] of timestamp offsets. + */ + if (size < 12 || handle->flags & TRACECMD_FL_IGNORE_DATE) + break; + handle->host.trace_id = tep_read_number(handle->pevent, + buf, 8); + handle->host.ts_samples_count = tep_read_number(handle->pevent, + buf + 8, 4); + sampes_size = (8 * handle->host.ts_samples_count); + if (size != (12 + (2 * sampes_size))) + break; + handle->host.ts_samples = malloc(2 * sampes_size); + if (!handle->host.ts_samples) + return -ENOMEM; + tsync_offset_load(handle, buf + 12); + break; case TRACECMD_OPTION_CPUSTAT: buf[size-1] = '\n'; cpustats = realloc(cpustats, cpustats_size + size + 1); @@ -3078,6 +3216,8 @@ void tracecmd_close(struct tracecmd_input *handle) trace_pid_map_free(handle->pid_maps); handle->pid_maps = NULL; + trace_tsync_offset_free(&handle->host); + if (handle->flags & TRACECMD_FL_BUFFER_INSTANCE) tracecmd_close(handle->parent); else { @@ -3532,3 +3672,29 @@ unsigned long long tracecmd_get_traceid(struct tracecmd_input *handle) { return handle->trace_id; } + +/** + * tracecmd_get_tsync_peer - get the trace session id of the peer host + * @handle: input handle for the trace.dat file + * + * Returns the trace id of the peer host, written in the trace file + * + * This information is stored in guest trace.dat file + */ +unsigned long long tracecmd_get_tsync_peer(struct tracecmd_input *handle) +{ + return handle->host.trace_id; +} + +/** + * tracecmd_enable_tsync - enable / disable the timestamps correction + * @handle: input handle for the trace.dat file + * @enable: enable / disable the timestamps correction + * + * Enables or disables timestamps correction on file load, using the array of + * recorded time offsets + */ +void tracecmd_enable_tsync(struct tracecmd_input *handle, bool enable) +{ + handle->host.sync_enable = enable; +} From patchwork Tue Dec 3 10:35:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270959 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6DD481AA3 for ; Tue, 3 Dec 2019 10:35:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 42B0520684 for ; Tue, 3 Dec 2019 10:35:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PuP5lavG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726086AbfLCKfp (ORCPT ); Tue, 3 Dec 2019 05:35:45 -0500 Received: from mail-lf1-f67.google.com ([209.85.167.67]:44762 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726186AbfLCKfo (ORCPT ); Tue, 3 Dec 2019 05:35:44 -0500 Received: by mail-lf1-f67.google.com with SMTP id v201so2467991lfa.11 for ; Tue, 03 Dec 2019 02:35:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wcQL78XUCyajNt4YlqnV1DffF7NrC/gu/1/VE/NGmdc=; b=PuP5lavGrtAGfGs1cKNbdTC1mS8RYGYcbo/tvhXvuPDFbxXBI9kL1vIHb2jl/Yyxav L70uWVJaLYuYQaWtUYZSczmUiOmlTUWYbsEMRDq+ZpQlEM7h46P91sM/M1HVm8NGgQtz 9MLsizXpLrYJuy9nT/oSE8jCxZgnbN8xsnKOL8h4ScaR+qGG3ORlYuULtQTUf1expfdh TzblCMBMTvswqtzkbB6H5acCSKleSLyWcuAPsv0xP+61qli5kXYMQDuIdmSI+yeYN4LD 9K0I4Dg4WyQSOk12/gNA1Erp61E0CrWdWTSk2vVJ4ZPK2HpvrCIJILJ1ejhSIjEtXwNM S9iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wcQL78XUCyajNt4YlqnV1DffF7NrC/gu/1/VE/NGmdc=; b=dlxqg0gENyj/E4Yh+UyJoAkUxNgesw1ffWEXKoHWypEkVcEK3dJZ2hzfFhYj4vqg6E 69ZvEnwxNWRog00FR+P39Gh7XZ6WuI5g70+3K+ApU46xDG3Plksi58S2q9UYHZqQwnd5 Nbwh8aNIbmSsE0qIx/zj5bmkSEgLxEfO1beTkj2MBAq2pdURkLFwULiIBPQ1ZWVvTMwu f+WAd0rMl5RVAnRCvDHDj2lsonwilk7A+CSf/yQeShG55K1ad4+/K/rUjl2ZDaQDLd06 t93CCMU2M8+eW+DGHw6VbKeSunZ14L8kvtdPxfBURLALwCK2GxBcAkJ3O6thht4NKTRe zJHQ== X-Gm-Message-State: APjAAAXaRUmxNNC0izT9UcGqNTGtvcVM4qRKmS/NHTG42t+W/X555r/1 w0ADOMkfXk839Bon4tN+qeY5rDSje6Q= X-Google-Smtp-Source: APXvYqwwPRTdFNSPfv7jZ17/GGBHRm85Wvzft89/Rlo0s3cNBs86dHBGmx44/QYgB89Cq0UFBGopTw== X-Received: by 2002:ac2:4adc:: with SMTP id m28mr2275671lfp.26.1575369341898; Tue, 03 Dec 2019 02:35:41 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:41 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 13/18] trace-cmd: Add guest information in host's trace.dat file Date: Tue, 3 Dec 2019 12:35:17 +0200 Message-Id: <20191203103522.482684-14-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org New trace.dat option is introduced: TRACECMD_OPTION_GUEST. Written in the host's trace.dat file, it contains information about guests, traced at the same time: guest trace ID, number of VCPUs and PIDs of the host tasks, running those VCPU. The data is stored in the file as NULL terminated string: "Guest %s %llu %d\n" -> guest name, number of VCPUs "%d %d\n" -> VCPU, PID of host task ..... "%d %d\n" -> VCPU, PID of host task Signed-off-by: Tzvetomir Stoyanov (VMware) --- include/trace-cmd/trace-cmd.h | 1 + lib/trace-cmd/trace-input.c | 113 ++++++++++++++++++++++++++++++++++ tracecmd/trace-record.c | 45 ++++++++++++++ 3 files changed, 159 insertions(+) diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 1240b4a..17badf2 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -88,6 +88,7 @@ enum { TRACECMD_OPTION_PROCMAPS, TRACECMD_OPTION_TRACEID, TRACECMD_OPTION_TIME_SHIFT, + TRACECMD_OPTION_GUEST, }; enum { diff --git a/lib/trace-cmd/trace-input.c b/lib/trace-cmd/trace-input.c index a6b675a..e36ebaa 100644 --- a/lib/trace-cmd/trace-input.c +++ b/lib/trace-cmd/trace-input.c @@ -79,6 +79,14 @@ struct ts_offset_sample { long long offset; }; +struct guest_trace_info { + struct guest_trace_info *next; + char *name; + unsigned long long trace_id; + int vcpu_count; + int *cpu_pid; +}; + struct host_trace_info { bool sync_enable; unsigned long long trace_id; @@ -112,6 +120,7 @@ struct tracecmd_input { char * trace_clock; struct input_buffer_instance *buffers; int parsing_failures; + struct guest_trace_info *guest; struct tracecmd_ftrace finfo; @@ -2294,6 +2303,73 @@ static int trace_traceid_load(struct tracecmd_input *handle, char *buf) return -1; } +static void trace_guests_free(struct tracecmd_input *handle) +{ + struct guest_trace_info *guest; + + while (handle->guest) { + guest = handle->guest; + handle->guest = handle->guest->next; + free(guest->name); + free(guest->cpu_pid); + free(guest); + } +} + +static int trace_guest_load(struct tracecmd_input *handle, char *buf) +{ + struct guest_trace_info *guest = NULL; + unsigned long long tid; + char *line; + int cpu, pid; + + line = strchr(buf, '\n'); + if (!line) + goto error; + *line = '\0'; + + guest = calloc(1, sizeof(struct guest_trace_info)); + if (!guest) + goto error; + + if (sscanf(buf, "%*s %ms %llu %d", &guest->name, &tid, &cpu) != 3) + goto error; + guest->trace_id = tid; + guest->vcpu_count = cpu; + + guest->cpu_pid = calloc(guest->vcpu_count, sizeof(int)); + if (!guest->cpu_pid) + goto error; + + buf = line + 1; + line = strchr(buf, '\n'); + while (line) { + *line = '\0'; + if (sscanf(buf, "%d %d", &cpu, &pid) != 2) + goto error; + + if (cpu < guest->vcpu_count) + guest->cpu_pid[cpu] = pid; + buf = line + 1; + if (!*buf) + break; + + line = strchr(buf, '\n'); + } + + guest->next = handle->guest; + handle->guest = guest; + return 0; + +error: + if (guest) { + free(guest->cpu_pid); + free(guest->name); + free(guest); + } + return -1; +} + #define STR_PROCMAP_LINE_MAX (PATH_MAX+22) static int trace_pid_map_load(struct tracecmd_input *handle, char *buf) { @@ -2558,6 +2634,10 @@ static int handle_options(struct tracecmd_input *handle) if (buf[size-1] == '\0') trace_traceid_load(handle, buf); break; + case TRACECMD_OPTION_GUEST: + if (buf[size-1] == '\0') + trace_guest_load(handle, buf); + break; default: warning("unknown option %d", option); break; @@ -3217,6 +3297,7 @@ void tracecmd_close(struct tracecmd_input *handle) handle->pid_maps = NULL; trace_tsync_offset_free(&handle->host); + trace_guests_free(handle); if (handle->flags & TRACECMD_FL_BUFFER_INSTANCE) tracecmd_close(handle->parent); @@ -3673,6 +3754,38 @@ unsigned long long tracecmd_get_traceid(struct tracecmd_input *handle) return handle->trace_id; } +/** + * tracecmd_get_guest_cpumap - get the mapping of guest VCPU to host process + * @handle: input handle for the trace.dat file + * @trace_id: ID of the guest tracing session + * + * Returns @name of the guest, number of VPUs (@vcpu_count) + * and array @cpu_pid with size @vcpu_count. Array index is VCPU id, array + * content is PID of the host process, running this VCPU. + * + * This information is stored in host trace.dat file + */ +int tracecmd_get_guest_cpumap(struct tracecmd_input *handle, + unsigned long long trace_id, + char *name, + int *vcpu_count, int *cpu_pid) +{ + struct guest_trace_info *guest = handle->guest; + + while (guest) { + if (guest->trace_id == trace_id) + break; + guest = guest->next; + } + if (!guest) + return -1; + + name = guest->name; + *vcpu_count = guest->vcpu_count; + cpu_pid = guest->cpu_pid; + return 0; +} + /** * tracecmd_get_tsync_peer - get the trace session id of the peer host * @handle: input handle for the trace.dat file diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index e51134f..49730d6 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -2884,6 +2884,19 @@ struct guest { static struct guest *guests; static size_t guests_len; +static struct guest *get_guest_info(unsigned int guest_cid) +{ + int i; + + if (!guests) + return NULL; + + for (i = 0; i < guests_len; i++) + if (guest_cid == guests[i].cid) + return guests + i; + return NULL; +} + static char *get_qemu_guest_name(char *arg) { char *tok, *end = arg; @@ -3689,6 +3702,33 @@ static void append_buffer(struct tracecmd_output *handle, } } +static void +add_guest_info(struct tracecmd_output *handle, struct buffer_instance *instance) +{ + struct guest *guest = get_guest_info(instance->cid); + struct trace_seq s; + int i; + + if (!guest) + return; + for (i = 0; i < VCPUS_MAX; i++) + if (!guest->cpu_pid[i]) + break; + + trace_seq_init(&s); + + trace_seq_printf(&s, "Guest %s %llu %d\n", + guest->name, instance->trace_id, i); + for (i = 0; i < VCPUS_MAX; i++) { + if (!guest->cpu_pid[i]) + break; + trace_seq_printf(&s, "%d %d\n", i, guest->cpu_pid[i]); + } + trace_seq_terminate(&s); + tracecmd_add_option(handle, TRACECMD_OPTION_GUEST, + s.len + 1, s.buffer); + trace_seq_destroy(&s); +} static void add_pid_maps(struct tracecmd_output *handle, struct buffer_instance *instance) @@ -3976,6 +4016,11 @@ static void record_data(struct common_record_context *ctx) add_pid_maps(handle, instance); } + for_all_instances(instance) { + if (is_guest(instance)) + add_guest_info(handle, instance); + } + tracecmd_append_cpu_data(handle, local_cpu_count, temp_files); for (i = 0; i < max_cpu_count; i++) From patchwork Tue Dec 3 10:35:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270961 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A23E31A2B for ; Tue, 3 Dec 2019 10:35:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 78623206F0 for ; Tue, 3 Dec 2019 10:35:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZbhRjTI0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726186AbfLCKfp (ORCPT ); Tue, 3 Dec 2019 05:35:45 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:37691 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726057AbfLCKfp (ORCPT ); Tue, 3 Dec 2019 05:35:45 -0500 Received: by mail-lj1-f195.google.com with SMTP id u17so3205441lja.4 for ; Tue, 03 Dec 2019 02:35:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TzKltY28zxysFwGXwi4Pp9PUBgVROhECvLFXCt3zpQw=; b=ZbhRjTI0kupL+RkuyB7ehxPQIRY8aj9s1pcy0xs+0FugABbzho1uOGNp1Ra/Um7TNH fuK6awqymr8RUPMMIpfr5C+ZFOnOnqiA7UGioZd5mTkW9tkvtljFH9neYvIgqycsitlY ee1dWiO2jO83g5/U3DNb+FXfbfDc/slgYYQGEvPONNeTOtZn37CQYbwBWa1aD4A4P1/I hkGydDGpLJRvTMfpyqSxM2b265G6LUTVB/OgMJzo9W5GPsRFjdVp9G58vii30b2EnDFZ ucq3hb/yvZBzY45mwsxeW/ll487Bor45TwncnW3QOwFNJj9IlC2GSArfdYz6IuFp+rWp WKvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TzKltY28zxysFwGXwi4Pp9PUBgVROhECvLFXCt3zpQw=; b=Z8N7Iw+wRUH5oUdJ2g1zLI5yk/PMPp3a8ltGgTeWscxFNjDh5e3sXxehlzZJhKUtaN M2I6A63l1ykBFZEhWXAiXeirZ0TMpBaWrr+b8jYiIh4/C54qiPqKVnnnk758FwJzgBk5 6U/5fkAgNruz1/PKV30kE3bqf1zApFBdx8kIX0u7SU3FHmNnXN0XasH/aJ566rbqcrcQ SeWQF74ENUUrIhMIyxRZLo3AtX3VqR1d05Ix4qH3cRyA8K8QguHuRqwk8hs0VLJF5oOC 7zHE8fOcAeo6F2iMLgx9W7MOoB/8rSyrAA/DED3M4hp8IxLOJEVhr9Nf3gF8EUcaaJdH 19gA== X-Gm-Message-State: APjAAAU0Xpq5juC6EbKvMIa5sZNVReKkI6GGd85TrA42SIlaKHKBQ6Id uB+i/1Ru+OYqXBINcVt8wPwlwklaQ8A= X-Google-Smtp-Source: APXvYqyx1pEV+R3IDMEnqODxRVKv9W78SLLbCKt44fs4mbCgA8scqh3qvptLl0DI21zBLj5pFS6w9A== X-Received: by 2002:a2e:b0db:: with SMTP id g27mr2218985ljl.74.1575369343002; Tue, 03 Dec 2019 02:35:43 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:42 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 14/18] trace-cmd: Add host trace clock as guest trace argument Date: Tue, 3 Dec 2019 12:35:18 +0200 Message-Id: <20191203103522.482684-15-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org When tracing host and guest machines, both should use the same tracing clock for event timestamps. If a clock is specified as host tracing argument, with option "-C clock_name", the same is injected as guest tracing argument. If the user wants to use different tracing clocks, it can specify it using "-C clock_name" as guest tracing argument. In that case, the one specified by the user has higher priority. Signed-off-by: Tzvetomir Stoyanov (VMware) --- tracecmd/trace-record.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index 49730d6..e7fb1bd 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -5405,6 +5405,8 @@ static void parse_record_options(int argc, char *sav; int name_counter = 0; int neg_event = 0; + struct buffer_instance *instance; + bool guest_config = false; init_common_record_context(ctx, curr_cmd); @@ -5562,6 +5564,7 @@ static void parse_record_options(int argc, break; case 'C': ctx->instance->ftrace->clock = optarg; + guest_config = true; break; case 'v': neg_event = 1; @@ -5779,14 +5782,26 @@ static void parse_record_options(int argc, /* If --date is specified, prepend it to all guest VM flags */ if (ctx->date) { - struct buffer_instance *instance; - for_all_instances(instance) { if (is_guest(instance)) add_argv(instance, "--date", true); } } + if (guest_config) { + /* If -C is specified, prepend clock to all guest VM flags */ + for_all_instances(instance) { + if (top_instance.ftrace->clock) { + if (is_guest(instance)) { + add_argv(instance, + (char *)top_instance.ftrace->clock, + true); + add_argv(instance, "-C", true); + } + } + } + } + if (!ctx->filtered && ctx->instance->filter_mod) add_func(&ctx->instance->filter_funcs, ctx->instance->filter_mod, "*"); From patchwork Tue Dec 3 10:35:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270967 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DE4721B2A for ; Tue, 3 Dec 2019 10:35:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC74A20684 for ; Tue, 3 Dec 2019 10:35:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m0CoRDN1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726057AbfLCKfq (ORCPT ); Tue, 3 Dec 2019 05:35:46 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:35951 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbfLCKfq (ORCPT ); Tue, 3 Dec 2019 05:35:46 -0500 Received: by mail-lj1-f195.google.com with SMTP id r19so3211469ljg.3 for ; Tue, 03 Dec 2019 02:35:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bzEwug/40m8ZvyhZ632ZBE59iLeXEZb5sxMd3ibrnBs=; b=m0CoRDN1DfC3oRZlDc7z2PvWTc0k2mWbAKSsvLx+JPmlD4WiWFtyiTPymMFKoOT2Eu dVpHQvvU/FUOJc/jr+gMacLkEYHepK8jFy7Ce090UB5qCE/S6tp/7QiNZzXbC3GyY9u9 sGoLOItON+Csyn7MEbI70RDjVXTkXz918NZGzZu9gmPyDiPp/qHKisgCBGEI0x8oyiWO PjqhlAp4jZwYh5Xl3UuCQeVNUBEBkpGhGPLWpVbuOGA6B0xy7WNani/JPASP3BxpGnMh Rr4Zt7irDzhaKqIv5qphqSsjlAInOfHVf8GvDbBRyG0kY/N9VrXcCbnRrBTTGyKLyM+6 hJtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bzEwug/40m8ZvyhZ632ZBE59iLeXEZb5sxMd3ibrnBs=; b=Pg3EtNaFzzioo/V1kI11GzJTYkWR5lY+oZUvSct52blXDEcUt32YJfxm7CZ02zyhmP xk4l1sYazX/fd9AGshG6o9gXS3UTYgQGF4bGrdQzH4C2N9EXmBBlDSeiJsT4kQHrf63D +K/yNbIdBOJKJbifmRRkqhyPuemHVHMNCiSY33gNLS/szTEaSYCZn5ZgBRaPmbIYZBe9 b8IYyOeWl/MbAyjkhKevPGCqF9nbtx4ZMPj5M9SZHboOf2ErTX2CTioYesr2ij6SX/z/ CRFICoBQSL9k7mvGEiB7iE1p24TfanzycrkMvUsBXBe2nyw5BfRmHAxQI3JNf7m2dHL/ BWCA== X-Gm-Message-State: APjAAAV1Vbus5RkTHqmapLIyiHYJ9eHHSlEAJUqepzvPFrhWGT3MAH/S mqfWFb+LlbkRkeZgWbGf1ArMEDWiwu4= X-Google-Smtp-Source: APXvYqyDBLbJuxUsp0A48l3SeH76Yh2zJrs90nJ7jsHoHEshxt3XwEMHYumazbrVgd9FG2FwLpyVxQ== X-Received: by 2002:a05:651c:2046:: with SMTP id t6mr1858552ljo.180.1575369344239; Tue, 03 Dec 2019 02:35:44 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:43 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 15/18] trace-cmd: Refactor few trace-cmd internal functions. Date: Tue, 3 Dec 2019 12:35:19 +0200 Message-Id: <20191203103522.482684-16-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org In order to reuse code inside trace-cmd application context, few functions are made non static: int make_vsock(unsigned int port); int get_vsock_port(int sd, unsigned int *port); int open_vsock(unsigned int cid, unsigned int port); char *get_guest_file(const char *file, const char *guest); Signed-off-by: Tzvetomir Stoyanov (VMware) --- tracecmd/include/trace-local.h | 8 ++++++++ tracecmd/trace-agent.c | 4 ++-- tracecmd/trace-record.c | 8 ++++---- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/tracecmd/include/trace-local.h b/tracecmd/include/trace-local.h index a6f79c5..17ef31a 100644 --- a/tracecmd/include/trace-local.h +++ b/tracecmd/include/trace-local.h @@ -19,6 +19,8 @@ #define GUEST_FIFO_FMT GUEST_DIR_FMT "/" GUEST_PIPE_NAME "%d" #define VIRTIO_FIFO_FMT "/dev/virtio-ports/" GUEST_PIPE_NAME "%d" +#define TRACE_FILENAME "trace.dat" + /* fix stupid glib guint64 typecasts and printf formats */ typedef unsigned long long u64; @@ -258,6 +260,12 @@ void tracecmd_disable_tracing(void); void tracecmd_enable_tracing(void); void tracecmd_stat_cpu(struct trace_seq *s, int cpu); +int make_vsock(unsigned int port); +int get_vsock_port(int sd, unsigned int *port); +int open_vsock(unsigned int cid, unsigned int port); + +char *get_guest_file(const char *file, const char *guest); + /* No longer in event-utils.h */ void __noreturn die(const char *fmt, ...); /* Can be overriden */ void *malloc_or_die(unsigned int size); /* Can be overridden */ diff --git a/tracecmd/trace-agent.c b/tracecmd/trace-agent.c index cc330b7..530f972 100644 --- a/tracecmd/trace-agent.c +++ b/tracecmd/trace-agent.c @@ -40,7 +40,7 @@ static int get_local_cid(unsigned int *cid) return ret; } -static int make_vsock(unsigned int port) +int make_vsock(unsigned int port) { struct sockaddr_vm addr = { .svm_family = AF_VSOCK, @@ -64,7 +64,7 @@ static int make_vsock(unsigned int port) return sd; } -static int get_vsock_port(int sd, unsigned int *port) +int get_vsock_port(int sd, unsigned int *port) { struct sockaddr_vm addr; socklen_t addr_len = sizeof(addr); diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index e7fb1bd..e66f999 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -68,7 +68,7 @@ static int rt_prio; static int keep; -static const char *output_file = "trace.dat"; +static const char *output_file = TRACE_FILENAME; static int latency; static int sleep_time = 1000; @@ -536,7 +536,7 @@ static char *get_temp_file(struct buffer_instance *instance, int cpu) return file; } -static char *get_guest_file(const char *file, const char *guest) +char *get_guest_file(const char *file, const char *guest) { const char *p; char *out = NULL; @@ -2772,7 +2772,7 @@ static int connect_port(const char *host, unsigned int port) } #ifdef VSOCK -static int open_vsock(unsigned int cid, unsigned int port) +int open_vsock(unsigned int cid, unsigned int port) { struct sockaddr_vm addr = { .svm_family = AF_VSOCK, @@ -2835,7 +2835,7 @@ static bool can_splice_read_vsock(void) } #else -static inline int open_vsock(unsigned int cid, unsigned int port) +int open_vsock(unsigned int cid, unsigned int port) { die("vsock is not supported"); return -1; From patchwork Tue Dec 3 10:35:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270969 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 922D126DD for ; Tue, 3 Dec 2019 10:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 52AC7205ED for ; Tue, 3 Dec 2019 10:35:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sq5Xb+l3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726189AbfLCKfv (ORCPT ); Tue, 3 Dec 2019 05:35:51 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:47044 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726075AbfLCKfu (ORCPT ); Tue, 3 Dec 2019 05:35:50 -0500 Received: by mail-lj1-f193.google.com with SMTP id z17so3133545ljk.13 for ; Tue, 03 Dec 2019 02:35:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1jYMAo+Y9bVlun2MuCGvK1ZYOMAz25ZWB99+zLAqnJ4=; b=Sq5Xb+l3EH7KdrVpKKy9icjUYQP/Upl623ta/c8/AOliGCNRWezDaHOV/+vz88A9nx YJSXWkOgJnN6mj45f4BeYoLxgrDuL81uvcGoPcLP1Wp05T4go+a4my/30Gd3kM5ocK6O h+vpC+7JvpeMtUbMmiA6bkoDOBfwH15DjCUWlH5Gpq2G3pnWZqbiG7usgW7Yq4xUeGmH PHfT7m4SOiP98guxejL1zZFUAH9kdK0bCcb2ftzbQJh+KHvahm4ld88EwGKIC7Oi3Th0 ROoeMDFISlY37yfG3su2ByTNCAk5cnSabPbqNaDKesnNRox1bdBYvU1gHACZrDH8SduD cPdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1jYMAo+Y9bVlun2MuCGvK1ZYOMAz25ZWB99+zLAqnJ4=; b=XRq2645ucGBOELaFJfcoLta/IN2Pa2WWjC6cmmIs0ou2YqxgqyKZDE1mZ04T8kSbdc A+D20HDE3MjRvlH0OL87o5hg9A/FsHwYONvKbMwQ4O5ayStngRMWC0cQ4nUCrbuKc605 PVtLGzONMFJTmIZ9jXQh50ZteqzunIszTSi3P58oND6OwFslnE6qF1LRJv7zUBXm96Lm FS0r23UIlFfcfhubNA3HQve1QJuTnl78ZB8McRr2NYEcLFeEYgzyGlQBfv4F3yA8hPM+ /0WtZGAVHRDaz0HVNPMqvtS/Mmw23JCpIC2r0TX3T/yoG8JO6tOUxOAvQ1Sh2Cpvqqu2 DqfQ== X-Gm-Message-State: APjAAAUmrGAwnM3M4CsCbbFcED0PftlbSDAqzCkSLhm0HcsXLq6Rl7V/ TZOMJjla8s01wQsdIMoG6jM7BqvvP1c= X-Google-Smtp-Source: APXvYqydoNrNwWLbK/cOjdCpwufWtdLuzyY1pfY3nbOEa+vhdn+qf3pAAQqG6oNEScGr6L2SDiD4eQ== X-Received: by 2002:a2e:6a14:: with SMTP id f20mr2222621ljc.87.1575369345555; Tue, 03 Dec 2019 02:35:45 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:44 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 16/18] trace-cmd: Basic infrastructure for host - guest timestamp synchronization Date: Tue, 3 Dec 2019 12:35:20 +0200 Message-Id: <20191203103522.482684-17-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org The infrastructure for host - guest timestamp synchronization is divided in two parts: - logic in libtracecmd - logic in trace-cmd application The libtracecmd is extended with new trace message, MSG_TIME_SYNC, used to exchange time synch information between host and guest. The trace request and response messages are extended to handle the time synch negotiation. The logic is implemented in trace-timesync.c file: - Register / unregister time sync protocols. - Choosing what protocol will be used for a tracing session. - Init common context, used by all protocols - a ftrace instance, vsockets. - Invoke protocol routines to perform time synchronization. - Store calculated offsets in an array. The trace-cmd application is extended to perform timestamp synchronization. The main logic is in trace-tsync.c file - Negotiate what time synch algorithm will be used for the tracing session. - Run pthreads, to do continuous timestamp synchronization, during the trace. - Store calculated offsets in guest's trace.dat file, using TRACECMD_OPTION_TIME_SHIFT option - A new trace-cmd option is added, to control the timestamp synchronization: --tsync-interval: set the time sync loop interval, in ms. The default value is 0 - timestamp synchronization is performed twice, before and after the trace. If a negative number is specified, the timestamp synchronization is disabled. Signed-off-by: Tzvetomir Stoyanov (VMware) --- Documentation/trace-cmd-record.1.txt | 6 + include/trace-cmd/trace-cmd.h | 54 ++- lib/trace-cmd/Makefile | 1 + lib/trace-cmd/include/trace-tsync-local.h | 36 ++ lib/trace-cmd/trace-msg.c | 147 ++++++- lib/trace-cmd/trace-timesync.c | 461 ++++++++++++++++++++++ tracecmd/Makefile | 3 +- tracecmd/include/trace-local.h | 11 + tracecmd/trace-agent.c | 34 +- tracecmd/trace-record.c | 37 +- tracecmd/trace-tsync.c | 268 +++++++++++++ tracecmd/trace-usage.c | 4 + 12 files changed, 1035 insertions(+), 27 deletions(-) create mode 100644 lib/trace-cmd/include/trace-tsync-local.h create mode 100644 lib/trace-cmd/trace-timesync.c create mode 100644 tracecmd/trace-tsync.c diff --git a/Documentation/trace-cmd-record.1.txt b/Documentation/trace-cmd-record.1.txt index 0d75e43..6f09200 100644 --- a/Documentation/trace-cmd-record.1.txt +++ b/Documentation/trace-cmd-record.1.txt @@ -338,6 +338,12 @@ OPTIONS the offset will also be in nanoseconds even if the displayed units are in microseconds. +*--tsync-interval*:: + Set the loop interval, in ms, for timestamps synchronization with guests: + If a negative number is specified, timestamps synchronization is disabled + If 0 is specified, no loop is performed - timestamps offset is calculated only twice," + at the beginning and at the end of the trace\n" + *--stderr*:: Have output go to stderr instead of stdout, but the output of the command executed will not be changed. This is useful if you want to monitor the diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 17badf2..6abcc9f 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -6,6 +6,7 @@ #ifndef _TRACE_CMD_H #define _TRACE_CMD_H +#include #include "traceevent/event-parse.h" #define ARRAY_SIZE(_a) (sizeof(_a) / sizeof((_a)[0])) @@ -361,19 +362,35 @@ void tracecmd_msg_set_done(struct tracecmd_msg_handle *msg_handle); int tracecmd_msg_send_trace_req(struct tracecmd_msg_handle *msg_handle, int argc, char **argv, bool use_fifos, - unsigned long long trace_id); + unsigned long long trace_id, + unsigned int tsync_protos); int tracecmd_msg_recv_trace_req(struct tracecmd_msg_handle *msg_handle, int *argc, char ***argv, bool *use_fifos, - unsigned long long *trace_id); + unsigned long long *trace_id, + unsigned int *tsync_protos); int tracecmd_msg_send_trace_resp(struct tracecmd_msg_handle *msg_handle, int nr_cpus, int page_size, unsigned int *ports, bool use_fifos, - unsigned long long trace_id); + unsigned long long trace_id, + unsigned int tsync_proto, + unsigned int tsync_port); int tracecmd_msg_recv_trace_resp(struct tracecmd_msg_handle *msg_handle, int *nr_cpus, int *page_size, unsigned int **ports, bool *use_fifos, - unsigned long long *trace_id); + unsigned long long *trace_id, + unsigned int *tsync_proto, + unsigned int *tsync_port); + +int tracecmd_msg_send_time_sync(struct tracecmd_msg_handle *msg_handle, + unsigned int sync_protocol, + unsigned int sync_msg_id, + unsigned int payload_size, char *payload); +int tracecmd_msg_recv_time_sync(struct tracecmd_msg_handle *msg_handle, + unsigned int *sync_protocol, + unsigned int *sync_msg_id, + unsigned int *payload_size, char **payload); + /* --- ftrace instances --- */ struct tracecmd_instance { @@ -406,6 +423,35 @@ int tracecmd_iterate_raw_events(struct tep_handle *tep, void *callback_context); +/* --- Timestamp synchronization --- */ + +enum{ + TRACECMD_TIME_SYNC_PROTO_NONE = 0, +}; +enum{ + TRACECMD_TIME_SYNC_CMD_PROBE = 1, + TRACECMD_TIME_SYNC_CMD_STOP = 2, +}; + +#define TRACECMD_TIME_SYNC_PROTO_PTP_WEIGHT 10 + +struct tracecmd_time_sync { + unsigned int sync_proto; + int loop_interval; + sem_t sem; + char *clock_str; + struct tracecmd_msg_handle *msg_handle; + void *context; +}; + +unsigned int tracecmd_tsync_proto_getall(void); +unsigned int tracecmd_tsync_proto_select(unsigned int protos); +void tracecmd_tsync_with_host(struct tracecmd_time_sync *tsync); +void tracecmd_tsync_with_guest(struct tracecmd_time_sync *tsync); +int tracecmd_tsync_get_offsets(struct tracecmd_time_sync *tsync, + int *count, + long long **ts, long long **offsets); +void tracecmd_tsync_free(struct tracecmd_time_sync *tsync); /* --- Plugin handling --- */ extern struct tep_plugin_option trace_ftrace_options[]; diff --git a/lib/trace-cmd/Makefile b/lib/trace-cmd/Makefile index 18c7013..6221b36 100644 --- a/lib/trace-cmd/Makefile +++ b/lib/trace-cmd/Makefile @@ -16,6 +16,7 @@ OBJS += trace-util.o OBJS += trace-instance.o OBJS += trace-filter-hash.o OBJS += trace-msg.o +OBJS += trace-timesync.o # Additional util objects OBJS += trace-blk-hack.o diff --git a/lib/trace-cmd/include/trace-tsync-local.h b/lib/trace-cmd/include/trace-tsync-local.h new file mode 100644 index 0000000..72a6556 --- /dev/null +++ b/lib/trace-cmd/include/trace-tsync-local.h @@ -0,0 +1,36 @@ +/* SPDX-License-Identifier: LGPL-2.1 */ +/* + * Copyright (C) 2019, VMware, Tzvetomir Stoyanov + * + */ +#ifndef _TRACE_TSYNC_LOCAL_H +#define _TRACE_TSYNC_LOCAL_H + +#include + +struct clock_sync_context { + void *proto_data; + bool server; + struct tracecmd_instance *vinst; + + int sync_size; + int sync_count; + long long *sync_ts; + long long *sync_offsets; + + unsigned int local_cid; + unsigned int local_port; + unsigned int remote_cid; + unsigned int remote_port; +}; + +int tracecmd_tsync_proto_register(unsigned int proto_id, int weight, + int (*init)(struct tracecmd_time_sync *), + int (*free)(struct tracecmd_time_sync *), + int (*calc)(struct tracecmd_time_sync *, + long long *, long long *)); +int tracecmd_tsync_proto_unregister(unsigned int proto_id); + +int ptp_clock_sync_register(void); + +#endif /* _TRACE_TSYNC_LOCAL_H */ diff --git a/lib/trace-cmd/trace-msg.c b/lib/trace-cmd/trace-msg.c index a34297f..b6ea5fc 100644 --- a/lib/trace-cmd/trace-msg.c +++ b/lib/trace-cmd/trace-msg.c @@ -28,6 +28,8 @@ typedef __u32 u32; typedef __be32 be32; +typedef __u64 u64; +typedef __s64 s64; static inline void dprint(const char *fmt, ...) { @@ -64,6 +66,7 @@ struct tracecmd_msg_trace_req { be32 flags; be32 argc; u64 trace_id; + be32 tsync_protos; } __attribute__((packed)); struct tracecmd_msg_trace_resp { @@ -71,6 +74,13 @@ struct tracecmd_msg_trace_resp { be32 cpus; be32 page_size; u64 trace_id; + be32 tsync_proto; + be32 tsync_port; +} __attribute__((packed)); + +struct tracecmd_msg_tsync { + be32 sync_protocol; + be32 sync_msg_id; } __attribute__((packed)); struct tracecmd_msg_header { @@ -88,7 +98,8 @@ struct tracecmd_msg_header { C(NOT_SUPP, 5, 0), \ C(TRACE_REQ, 6, sizeof(struct tracecmd_msg_trace_req)), \ C(TRACE_RESP, 7, sizeof(struct tracecmd_msg_trace_resp)),\ - C(CLOSE_RESP, 8, 0), + C(CLOSE_RESP, 8, 0), \ + C(TIME_SYNC, 9, sizeof(struct tracecmd_msg_tsync)), #undef C #define C(a,b,c) MSG_##a = b @@ -122,6 +133,7 @@ struct tracecmd_msg { struct tracecmd_msg_rinit rinit; struct tracecmd_msg_trace_req trace_req; struct tracecmd_msg_trace_resp trace_resp; + struct tracecmd_msg_tsync tsync; }; char *buf; } __attribute__((packed)); @@ -264,6 +276,17 @@ static int tracecmd_msg_send(int fd, struct tracecmd_msg *msg) return ret; } +static int tracecmd_msg_send_nofree(int fd, struct tracecmd_msg *msg) +{ + int ret = 0; + + ret = msg_write(fd, msg); + if (ret < 0) + ret = -ECOMM; + + return ret; +} + static int msg_read(int fd, void *buf, u32 size, int *n) { ssize_t r; @@ -814,7 +837,8 @@ int tracecmd_msg_wait_close_resp(struct tracecmd_msg_handle *msg_handle) } static int make_trace_req(struct tracecmd_msg *msg, int argc, char **argv, - bool use_fifos, unsigned long long trace_id) + bool use_fifos, unsigned long long trace_id, + unsigned int tsync_protos) { size_t args_size = 0; char *p; @@ -824,7 +848,11 @@ static int make_trace_req(struct tracecmd_msg *msg, int argc, char **argv, args_size += strlen(argv[i]) + 1; msg->hdr.size = htonl(ntohl(msg->hdr.size) + args_size); - msg->trace_req.flags = use_fifos ? htonl(MSG_TRACE_USE_FIFOS) : htonl(0); + msg->trace_req.flags = 0; + if (use_fifos) + msg->trace_req.flags |= MSG_TRACE_USE_FIFOS; + msg->trace_req.flags = htonl(msg->trace_req.flags); + msg->trace_req.tsync_protos = htonl(tsync_protos); msg->trace_req.argc = htonl(argc); msg->trace_req.trace_id = htonll(trace_id); msg->buf = calloc(args_size, 1); @@ -840,28 +868,30 @@ static int make_trace_req(struct tracecmd_msg *msg, int argc, char **argv, int tracecmd_msg_send_trace_req(struct tracecmd_msg_handle *msg_handle, int argc, char **argv, bool use_fifos, - unsigned long long trace_id) + unsigned long long trace_id, + unsigned int tsync_protos) { struct tracecmd_msg msg; int ret; tracecmd_msg_init(MSG_TRACE_REQ, &msg); ret = make_trace_req(&msg, argc, argv, - use_fifos, trace_id); + use_fifos, trace_id, tsync_protos); if (ret < 0) return ret; return tracecmd_msg_send(msg_handle->fd, &msg); } - /* - * NOTE: On success, the returned `argv` should be freed with: - * free(argv[0]); - * free(argv); - */ +/* + * NOTE: On success, the returned `argv` should be freed with: + * free(argv[0]); + * free(argv); + */ int tracecmd_msg_recv_trace_req(struct tracecmd_msg_handle *msg_handle, int *argc, char ***argv, bool *use_fifos, - unsigned long long *trace_id) + unsigned long long *trace_id, + unsigned int *tsync_protos) { struct tracecmd_msg msg; char *p, *buf_end, **args; @@ -908,6 +938,7 @@ int tracecmd_msg_recv_trace_req(struct tracecmd_msg_handle *msg_handle, *argc = nr_args; *argv = args; *use_fifos = ntohl(msg.trace_req.flags) & MSG_TRACE_USE_FIFOS; + *tsync_protos = ntohl(msg.trace_req.tsync_protos); *trace_id = ntohll(msg.trace_req.trace_id); /* @@ -928,9 +959,81 @@ out: return ret; } +int tracecmd_msg_send_time_sync(struct tracecmd_msg_handle *msg_handle, + unsigned int sync_protocol, + unsigned int sync_msg_id, + unsigned int payload_size, char *payload) +{ + struct tracecmd_msg msg; + + tracecmd_msg_init(MSG_TIME_SYNC, &msg); + msg.tsync.sync_protocol = htonl(sync_protocol); + msg.tsync.sync_msg_id = htonl(sync_msg_id); + msg.hdr.size = htonl(ntohl(msg.hdr.size) + payload_size); + + msg.buf = payload; + return tracecmd_msg_send_nofree(msg_handle->fd, &msg); +} + +int tracecmd_msg_recv_time_sync(struct tracecmd_msg_handle *msg_handle, + unsigned int *sync_protocol, + unsigned int *sync_msg_id, + unsigned int *payload_size, char **payload) +{ + struct tracecmd_msg msg; + int ret = -1; + int buf_size; + + memset(&msg, 0, sizeof(msg)); + ret = tracecmd_msg_recv(msg_handle->fd, &msg); + if (ret < 0) + goto out; + + if (ntohl(msg.hdr.cmd) != MSG_TIME_SYNC) { + ret = -EOPNOTSUPP; + goto out; + } + + if (sync_protocol) + *sync_protocol = ntohl(msg.tsync.sync_protocol); + if (sync_msg_id) + *sync_msg_id = ntohl(msg.tsync.sync_msg_id); + + buf_size = msg_buf_len(&msg); + if (buf_size < 0) { + ret = -EINVAL; + goto out; + } + + if (buf_size && payload && payload_size) { + if (*payload_size) { + if (*payload_size != buf_size || *payload == NULL) { + ret = -ENOMEM; + goto out; + } + memcpy(*payload, msg.buf, buf_size); + goto out; + } + + *payload = malloc(buf_size); + if (*payload == NULL) { + ret = -ENOMEM; + goto out; + } + *payload_size = buf_size; + memcpy(*payload, msg.buf, buf_size); + } + +out: + msg_free(&msg); + return ret; +} + static int make_trace_resp(struct tracecmd_msg *msg, int page_size, int nr_cpus, unsigned int *ports, bool use_fifos, - unsigned long long trace_id) + unsigned long long trace_id, + unsigned int tsync_proto, + unsigned int tsync_port) { int data_size; @@ -941,7 +1044,13 @@ static int make_trace_resp(struct tracecmd_msg *msg, int page_size, int nr_cpus, write_uints(msg->buf, data_size, ports, nr_cpus); msg->hdr.size = htonl(ntohl(msg->hdr.size) + data_size); - msg->trace_resp.flags = use_fifos ? htonl(MSG_TRACE_USE_FIFOS) : htonl(0); + msg->trace_resp.flags = 0; + if (use_fifos) + msg->trace_resp.flags |= MSG_TRACE_USE_FIFOS; + msg->trace_resp.flags = htonl(msg->trace_resp.flags); + msg->trace_resp.tsync_proto = htonl(tsync_proto); + msg->trace_resp.tsync_port = htonl(tsync_port); + msg->trace_resp.cpus = htonl(nr_cpus); msg->trace_resp.page_size = htonl(page_size); msg->trace_resp.trace_id = htonll(trace_id); @@ -952,14 +1061,16 @@ static int make_trace_resp(struct tracecmd_msg *msg, int page_size, int nr_cpus, int tracecmd_msg_send_trace_resp(struct tracecmd_msg_handle *msg_handle, int nr_cpus, int page_size, unsigned int *ports, bool use_fifos, - unsigned long long trace_id) + unsigned long long trace_id, + unsigned int tsync_proto, + unsigned int tsync_port) { struct tracecmd_msg msg; int ret; tracecmd_msg_init(MSG_TRACE_RESP, &msg); ret = make_trace_resp(&msg, page_size, nr_cpus, ports, - use_fifos, trace_id); + use_fifos, trace_id, tsync_proto, tsync_port); if (ret < 0) return ret; @@ -969,7 +1080,9 @@ int tracecmd_msg_send_trace_resp(struct tracecmd_msg_handle *msg_handle, int tracecmd_msg_recv_trace_resp(struct tracecmd_msg_handle *msg_handle, int *nr_cpus, int *page_size, unsigned int **ports, bool *use_fifos, - unsigned long long *trace_id) + unsigned long long *trace_id, + unsigned int *tsync_proto, + unsigned int *tsync_port) { struct tracecmd_msg msg; char *p, *buf_end; @@ -996,6 +1109,8 @@ int tracecmd_msg_recv_trace_resp(struct tracecmd_msg_handle *msg_handle, *nr_cpus = ntohl(msg.trace_resp.cpus); *page_size = ntohl(msg.trace_resp.page_size); *trace_id = ntohll(msg.trace_resp.trace_id); + *tsync_proto = ntohl(msg.trace_resp.tsync_proto); + *tsync_port = ntohl(msg.trace_resp.tsync_port); *ports = calloc(*nr_cpus, sizeof(**ports)); if (!*ports) { ret = -ENOMEM; diff --git a/lib/trace-cmd/trace-timesync.c b/lib/trace-cmd/trace-timesync.c new file mode 100644 index 0000000..073423d --- /dev/null +++ b/lib/trace-cmd/trace-timesync.c @@ -0,0 +1,461 @@ +// SPDX-License-Identifier: LGPL-2.1 +/* + * Copyright (C) 2019, VMware, Tzvetomir Stoyanov + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include "trace-cmd.h" +#include "trace-cmd-local.h" +#include "trace-tsync-local.h" + +struct tsync_proto { + struct tsync_proto *next; + unsigned int proto_id; + int weight; + + int (*clock_sync_init)(struct tracecmd_time_sync *clock_context); + int (*clock_sync_free)(struct tracecmd_time_sync *clock_context); + int (*clock_sync_calc)(struct tracecmd_time_sync *clock_context, + long long *offset, long long *timestamp); +} static * tsync_proto_list; + +static struct tsync_proto *tsync_proto_get(unsigned int proto_id) +{ + struct tsync_proto *proto = tsync_proto_list; + + while (proto) { + if (proto->proto_id == proto_id) + return proto; + proto = proto->next; + } + return NULL; +} + +int tracecmd_tsync_proto_register(unsigned int proto_id, int weight, + int (*init)(struct tracecmd_time_sync *), + int (*free)(struct tracecmd_time_sync *), + int (*calc)(struct tracecmd_time_sync *, + long long *, long long *)) +{ + struct tsync_proto *proto; + + if (tsync_proto_get(proto_id)) + return -1; + proto = calloc(1, sizeof(struct tsync_proto)); + if (!proto) + return -1; + proto->proto_id = proto_id; + proto->weight = weight; + proto->clock_sync_init = init; + proto->clock_sync_free = free; + proto->clock_sync_calc = calc; + + proto->next = tsync_proto_list; + tsync_proto_list = proto; + return 0; +} + +int tracecmd_tsync_proto_unregister(unsigned int proto_id) +{ + struct tsync_proto *proto = tsync_proto_list; + struct tsync_proto *pdel; + + if (tsync_proto_list && tsync_proto_list->proto_id == proto_id) { + pdel = tsync_proto_list; + tsync_proto_list = pdel->next; + free(pdel); + return 0; + } + + while (proto->next) { + if (proto->next->proto_id == proto_id) { + pdel = proto->next; + proto->next = pdel->next; + free(pdel); + return 0; + } + proto = proto->next; + } + + return -1; +} + +/** + * tracecmd_tsync_get_offsets - Return the calculated time offsests + * + * @tsync: Pointer to time sync context. + * @count: Returns the number of calculated time offsets. + * @ts: Array of size @count containing timestamps of callculated offsets + * @offsets: array of size @count, containing offsets for each timestamp. + * + * Retuns -1 in case of an error, or 0 otherwise + */ +int tracecmd_tsync_get_offsets(struct tracecmd_time_sync *tsync, + int *count, + long long **ts, long long **offsets) +{ + struct clock_sync_context *tsync_context; + + if (!tsync || !tsync->context) + return -1; + tsync_context = (struct clock_sync_context *)tsync->context; + if (count) + *count = tsync_context->sync_count; + if (ts) + *ts = tsync_context->sync_ts; + if (offsets) + *offsets = tsync_context->sync_offsets; + return 0; +} + +/** + * tracecmd_tsync_proto_select - Select time sync protocol, to be used for + * timestamp synchronization with a peer. + * + * @protos: Bitmask of time sync protocols, supported by the peer. + * + * Retuns Id of a time sync protocol, that can be used with the peer, or 0 + * in case there is no match with supported protocols. + */ +unsigned int tracecmd_tsync_proto_select(unsigned int protos) +{ + struct tsync_proto *proto = tsync_proto_list; + struct tsync_proto *selected = NULL; + + while (proto) { + if (proto->proto_id & protos) { + if (selected) { + if (selected->weight < proto->weight) + selected = proto; + } else + selected = proto; + } + proto = proto->next; + } + + if (selected) + return selected->proto_id; + + return 0; +} + +/** + * tracecmd_tsync_proto_getall - Returns bitmask of all supported + * time sync protocols. + * + */ +unsigned int tracecmd_tsync_proto_getall(void) +{ + struct tsync_proto *proto = tsync_proto_list; + unsigned int protos = 0; + + while (proto) { + protos |= proto->proto_id; + proto = proto->next; + } + + return protos; +} + +static int get_vsocket_params(int fd, unsigned int *lcid, unsigned int *lport, + unsigned int *rcid, unsigned int *rport) +{ + struct sockaddr_vm addr; + socklen_t addr_len = sizeof(addr); + + memset(&addr, 0, sizeof(addr)); + if (getsockname(fd, (struct sockaddr *)&addr, &addr_len)) + return -1; + if (addr.svm_family != AF_VSOCK) + return -1; + *lport = addr.svm_port; + *lcid = addr.svm_cid; + + memset(&addr, 0, sizeof(addr)); + addr_len = sizeof(addr); + if (getpeername(fd, (struct sockaddr *)&addr, &addr_len)) + return -1; + if (addr.svm_family != AF_VSOCK) + return -1; + *rport = addr.svm_port; + *rcid = addr.svm_cid; + + return 0; +} + +static struct tracecmd_instance * +clock_synch_create_instance(const char *clock, unsigned int cid) +{ + struct tracecmd_instance *vinst; + char inst_name[256]; + + snprintf(inst_name, 256, "clock_synch-%d", cid); + + vinst = tracecmd_create_instance(inst_name); + if (!vinst) + return NULL; + + tracecmd_make_instance(vinst); + tracecmd_write_instance_file(vinst, "trace", "\0", NULL); + if (clock) + vinst->clock = strdup(clock); + tracecmd_set_clock(vinst, NULL); + return vinst; +} + +static void +clock_synch_delete_instance(struct tracecmd_instance *inst) +{ + if (!inst) + return; + tracecmd_remove_instance(inst); + free(inst->clock); + tracecmd_free_instance(inst); +} + +static int clock_context_init(struct tracecmd_time_sync *tsync, bool server) +{ + struct clock_sync_context *clock = NULL; + struct tsync_proto *protocol; + + if (tsync->context) + return 0; + + protocol = tsync_proto_get(tsync->sync_proto); + if (!protocol) + return -1; + + clock = calloc(1, sizeof(struct clock_sync_context)); + if (!clock) + return -1; + + clock->server = server; + if (get_vsocket_params(tsync->msg_handle->fd, &clock->local_cid, + &clock->local_port, &clock->remote_cid, + &clock->remote_port)) + goto error; + + clock->vinst = clock_synch_create_instance(tsync->clock_str, + clock->remote_cid); + if (!clock->vinst) + goto error; + + tsync->context = clock; + if (protocol->clock_sync_init && protocol->clock_sync_init(tsync) < 0) + goto error; + + return 0; +error: + tsync->context = NULL; + free(clock); + return -1; +} + +/** + * tracecmd_tsync_free - Free time sync context, allocated by + * tracecmd_tsync_with_host() or tracecmd_tsync_with_guest() APIs + * + * @tsync: Pointer to time sync context. + * + */ +void tracecmd_tsync_free(struct tracecmd_time_sync *tsync) +{ + struct clock_sync_context *tsync_context; + struct tsync_proto *proto; + + if (!tsync->context) + return; + tsync_context = (struct clock_sync_context *)tsync->context; + + proto = tsync_proto_get(tsync->sync_proto); + if (proto && proto->clock_sync_free) + proto->clock_sync_free(tsync); + + clock_synch_delete_instance(tsync_context->vinst); + tsync_context->vinst = NULL; + + free(tsync_context->sync_ts); + free(tsync_context->sync_offsets); + tsync_context->sync_ts = NULL; + tsync_context->sync_offsets = NULL; + tsync_context->sync_count = 0; + tsync_context->sync_size = 0; + sem_destroy(&tsync->sem); + free(tsync->clock_str); +} + +static int tracecmd_tsync_send(struct tracecmd_time_sync *tsync, + struct tsync_proto *proto) +{ + long long timestamp = 0; + long long offset = 0; + int ret; + + ret = proto->clock_sync_calc(tsync, &offset, ×tamp); + + return ret; +} + +/** + * tracecmd_tsync_with_host - Synchronize timestamps with host + * + * @tsync: Pointer to time sync context. + * + * This API is supposed to be called in guest context. It waits for a time + * sync request from the host and replies with a time sample, until time sync + * stop command is received. + * + */ +void tracecmd_tsync_with_host(struct tracecmd_time_sync *tsync) +{ + struct tsync_proto *proto; + unsigned int protocol; + unsigned int command; + int ret; + + proto = tsync_proto_get(tsync->sync_proto); + if (!proto || !proto->clock_sync_calc) + return; + + clock_context_init(tsync, true); + if (!tsync->context) + return; + + while (true) { + ret = tracecmd_msg_recv_time_sync(tsync->msg_handle, + &protocol, &command, + NULL, NULL); + + if (ret || + protocol != TRACECMD_TIME_SYNC_PROTO_NONE || + command != TRACECMD_TIME_SYNC_CMD_PROBE) + break; + ret = tracecmd_tsync_send(tsync, proto); + if (ret) + break; + } +} + +static int tracecmd_tsync_get(struct tracecmd_time_sync *tsync, + struct tsync_proto *proto, + int array_step) +{ + struct clock_sync_context *clock; + long long *sync_offsets = NULL; + long long *sync_ts = NULL; + long long timestamp = 0; + long long offset = 0; + int ret; + + ret = proto->clock_sync_calc(tsync, &offset, ×tamp); + if (ret) { + warning("Failed to synchronize timestamps with guest"); + return -1; + } + if (!offset || !timestamp) + return 0; + clock = tsync->context; + if (clock->sync_count >= clock->sync_size) { + sync_ts = realloc(clock->sync_ts, + (clock->sync_size + array_step) * sizeof(long long)); + sync_offsets = realloc(clock->sync_offsets, + (clock->sync_size + array_step) * sizeof(long long)); + if (!sync_ts || !sync_offsets) { + free(sync_ts); + free(sync_offsets); + return -1; + } + clock->sync_size += array_step; + clock->sync_ts = sync_ts; + clock->sync_offsets = sync_offsets; + } + + clock->sync_ts[clock->sync_count] = timestamp; + clock->sync_offsets[clock->sync_count] = offset; + clock->sync_count++; + + return 0; +} + +#define TIMER_SEC_NANO 1000000000LL +static inline void get_ts_loop_delay(struct timespec *timeout, int delay_ms) +{ + memset(timeout, 0, sizeof(struct timespec)); + clock_gettime(CLOCK_REALTIME, timeout); + + timeout->tv_nsec += ((unsigned long long)delay_ms * 1000000LL); + + if (timeout->tv_nsec >= TIMER_SEC_NANO) { + timeout->tv_sec += timeout->tv_nsec / TIMER_SEC_NANO; + timeout->tv_nsec %= TIMER_SEC_NANO; + } +} + +#define CLOCK_TS_ARRAY 5 +/** + * tracecmd_tsync_with_guest - Synchronize timestamps with guest + * + * @tsync: Pointer to time sync context. + * + * This API is supposed to be called in host context, in a separate thread. + * It loops infinite, until the timesync semaphore is released. + * + */ +void tracecmd_tsync_with_guest(struct tracecmd_time_sync *tsync) +{ + int ts_array_size = CLOCK_TS_ARRAY; + struct tsync_proto *proto; + struct timespec timeout; + bool end = false; + int ret; + + proto = tsync_proto_get(tsync->sync_proto); + if (!proto || !proto->clock_sync_calc) + return; + + clock_context_init(tsync, false); + if (!tsync->context) + return; + + if (tsync->loop_interval > 0 && + tsync->loop_interval < (CLOCK_TS_ARRAY * 1000)) + ts_array_size = (CLOCK_TS_ARRAY * 1000) / tsync->loop_interval; + + while (true) { + ret = tracecmd_msg_send_time_sync(tsync->msg_handle, + TRACECMD_TIME_SYNC_PROTO_NONE, + TRACECMD_TIME_SYNC_CMD_PROBE, + 0, NULL); + ret = tracecmd_tsync_get(tsync, proto, ts_array_size); + if (ret || end) + break; + if (tsync->loop_interval > 0) { + get_ts_loop_delay(&timeout, tsync->loop_interval); + ret = sem_timedwait(&tsync->sem, &timeout); + if (ret < 0) { + if (errno != ETIMEDOUT && errno != EINTR) + break; + } else if (!ret) + end = true; + } else { + sem_wait(&tsync->sem); + end = true; + } + }; + + tracecmd_msg_send_time_sync(tsync->msg_handle, + TRACECMD_TIME_SYNC_PROTO_NONE, + TRACECMD_TIME_SYNC_CMD_STOP, + 0, NULL); +} diff --git a/tracecmd/Makefile b/tracecmd/Makefile index 29a623b..908dab2 100644 --- a/tracecmd/Makefile +++ b/tracecmd/Makefile @@ -30,6 +30,7 @@ TRACE_CMD_OBJS += trace-check-events.o TRACE_CMD_OBJS += trace-show.o TRACE_CMD_OBJS += trace-list.o TRACE_CMD_OBJS += trace-usage.o +TRACE_CMD_OBJS += trace-tsync.o ifeq ($(VSOCK_DEFINED), 1) TRACE_CMD_OBJS += trace-agent.o @@ -42,7 +43,7 @@ all_objs := $(sort $(ALL_OBJS)) all_deps := $(all_objs:$(bdir)/%.o=$(bdir)/.%.d) CONFIG_INCLUDES = -CONFIG_LIBS = -lrt +CONFIG_LIBS = -lrt -lpthread CONFIG_FLAGS = all: $(TARGETS) diff --git a/tracecmd/include/trace-local.h b/tracecmd/include/trace-local.h index 17ef31a..d652317 100644 --- a/tracecmd/include/trace-local.h +++ b/tracecmd/include/trace-local.h @@ -226,6 +226,10 @@ struct buffer_instance { unsigned int port; int *fds; bool use_fifos; + + pthread_t tsync_thread; + bool tsync_thread_running; + struct tracecmd_time_sync tsync; }; void init_top_instance(void); @@ -260,6 +264,13 @@ void tracecmd_disable_tracing(void); void tracecmd_enable_tracing(void); void tracecmd_stat_cpu(struct trace_seq *s, int cpu); +int tracecmd_host_tsync(struct buffer_instance *instance, + unsigned int tsync_port); +void tracecmd_host_tsync_complete(struct buffer_instance *instance); +unsigned int tracecmd_guest_tsync(unsigned int tsync_protos, char *clock, + unsigned int *tsync_port, + pthread_t *thr_id); + int make_vsock(unsigned int port); int get_vsock_port(int sd, unsigned int *port); int open_vsock(unsigned int cid, unsigned int port); diff --git a/tracecmd/trace-agent.c b/tracecmd/trace-agent.c index 530f972..1581de8 100644 --- a/tracecmd/trace-agent.c +++ b/tracecmd/trace-agent.c @@ -19,6 +19,7 @@ #include #include #include +#include #include "trace-local.h" #include "trace-msg.h" @@ -125,11 +126,28 @@ cleanup: return ret; } +static char *get_clock(int argc, char **argv) +{ + int i; + + if (!argc || !argv) + return NULL; + + for (i = 0; i < argc - 1; i++) { + if (!strcmp("-C", argv[i])) + return argv[i+1]; + } + return NULL; +} + static void agent_handle(int sd, int nr_cpus, int page_size) { struct tracecmd_msg_handle *msg_handle; unsigned long long trace_id; + unsigned int tsync_protos = 0; + unsigned int tsync_port = 0; unsigned int *ports; + pthread_t sync_thr; char **argv = NULL; int argc = 0; bool use_fifos; @@ -146,7 +164,8 @@ static void agent_handle(int sd, int nr_cpus, int page_size) die("Failed to allocate message handle"); ret = tracecmd_msg_recv_trace_req(msg_handle, &argc, &argv, - &use_fifos, &trace_id); + &use_fifos, &trace_id, + &tsync_protos); if (ret < 0) die("Failed to receive trace request"); @@ -155,14 +174,25 @@ static void agent_handle(int sd, int nr_cpus, int page_size) if (!use_fifos) make_vsocks(nr_cpus, fds, ports); + if (tsync_protos) { + tsync_protos = tracecmd_guest_tsync(tsync_protos, + get_clock(argc, argv), + &tsync_port, &sync_thr); + if (!tsync_protos) + warning("Failed to negotiate timestamps synchronization with the host"); + } trace_id = tracecmd_generate_traceid(); ret = tracecmd_msg_send_trace_resp(msg_handle, nr_cpus, page_size, - ports, use_fifos, trace_id); + ports, use_fifos, trace_id, + tsync_protos, tsync_port); if (ret < 0) die("Failed to send trace response"); trace_record_agent(msg_handle, nr_cpus, fds, argc, argv, use_fifos, trace_id); + if (tsync_protos) + pthread_join(sync_thr, NULL); + free(argv[0]); free(argv); free(ports); diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index e66f999..e543c40 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -670,6 +670,11 @@ static void tell_guests_to_stop(void) tracecmd_msg_send_close_msg(instance->msg_handle); } + for_all_instances(instance) { + if (is_guest(instance)) + tracecmd_host_tsync_complete(instance); + } + /* Wait for guests to acknowledge */ for_all_instances(instance) { if (is_guest(instance)) { @@ -3501,6 +3506,8 @@ static void connect_to_agent(struct buffer_instance *instance) { struct tracecmd_msg_handle *msg_handle; int sd, ret, nr_fifos, nr_cpus, page_size; + unsigned int tsync_protos_reply = 0; + unsigned int tsync_port = 0; unsigned int *ports; int i, *fds = NULL; bool use_fifos = false; @@ -3519,19 +3526,32 @@ static void connect_to_agent(struct buffer_instance *instance) if (!msg_handle) die("Failed to allocate message handle"); + if (instance->tsync.loop_interval >= 0) + instance->tsync.sync_proto = tracecmd_tsync_proto_getall(); + ret = tracecmd_msg_send_trace_req(msg_handle, instance->argc, instance->argv, use_fifos, - top_instance.trace_id); + top_instance.trace_id, + instance->tsync.sync_proto); if (ret < 0) die("Failed to send trace request"); ret = tracecmd_msg_recv_trace_resp(msg_handle, &nr_cpus, &page_size, &ports, &use_fifos, - &instance->trace_id); + &instance->trace_id, + &tsync_protos_reply, &tsync_port); if (ret < 0) - die("Failed to receive trace response"); + die("Failed to receive trace response %d", ret); + + if (instance->tsync.sync_proto) { + if (instance->tsync.sync_proto & tsync_protos_reply) { + instance->tsync.sync_proto = tsync_protos_reply; + tracecmd_host_tsync(instance, tsync_port); + } else + warning("Failed to negotiate timestamps synchronization with the guest"); + } if (use_fifos) { if (nr_cpus != nr_fifos) { @@ -3578,7 +3598,9 @@ static void setup_guest(struct buffer_instance *instance) close(fd); } -static void setup_agent(struct buffer_instance *instance, struct common_record_context *ctx) +static void setup_agent(struct buffer_instance *instance, + struct common_record_context *ctx) + { struct tracecmd_output *network_handle; @@ -5131,6 +5153,7 @@ void init_top_instance(void) } enum { + OPT_tsyncinterval = 242, OPT_user = 243, OPT_procmap = 244, OPT_quiet = 245, @@ -5433,6 +5456,7 @@ static void parse_record_options(int argc, {"proc-map", no_argument, NULL, OPT_procmap}, {"user", required_argument, NULL, OPT_user}, {"module", required_argument, NULL, OPT_module}, + {"tsync-interval", required_argument, NULL, OPT_tsyncinterval}, {NULL, 0, NULL, 0} }; @@ -5771,6 +5795,10 @@ static void parse_record_options(int argc, ctx->instance->filter_mod = optarg; ctx->filtered = 0; break; + case OPT_tsyncinterval: + top_instance.tsync.loop_interval = atoi(optarg); + guest_config = true; + break; case OPT_quiet: case 'q': quiet = true; @@ -5799,6 +5827,7 @@ static void parse_record_options(int argc, add_argv(instance, "-C", true); } } + instance->tsync.loop_interval = top_instance.tsync.loop_interval; } } diff --git a/tracecmd/trace-tsync.c b/tracecmd/trace-tsync.c new file mode 100644 index 0000000..e4189e0 --- /dev/null +++ b/tracecmd/trace-tsync.c @@ -0,0 +1,268 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2019, VMware, Tzvetomir Stoyanov + * + */ +#include +#include +#include +#include +#include +#include +#include + +#include "trace-local.h" +#include "trace-msg.h" + +static int get_first_cpu(cpu_set_t **pin_mask, size_t *m_size) +{ + int cpus = tracecmd_count_cpus(); + cpu_set_t *cpu_mask; + int mask_size; + int i; + + cpu_mask = CPU_ALLOC(cpus); + *pin_mask = CPU_ALLOC(cpus); + if (!cpu_mask || !*pin_mask || 1) + goto error; + + mask_size = CPU_ALLOC_SIZE(cpus); + CPU_ZERO_S(mask_size, cpu_mask); + CPU_ZERO_S(mask_size, *pin_mask); + + if (sched_getaffinity(0, mask_size, cpu_mask) == -1) + goto error; + + for (i = 0; i < cpus; i++) { + if (CPU_ISSET_S(i, mask_size, cpu_mask)) { + CPU_SET_S(i, mask_size, *pin_mask); + break; + } + } + + if (CPU_COUNT_S(mask_size, *pin_mask) < 1) + goto error; + + CPU_FREE(cpu_mask); + *m_size = mask_size; + return 0; + +error: + if (cpu_mask) + CPU_FREE(cpu_mask); + if (*pin_mask) + CPU_FREE(*pin_mask); + *pin_mask = NULL; + *m_size = 0; + return -1; +} + +static void *tsync_host_thread(void *data) +{ + struct tracecmd_time_sync *tsync = NULL; + + tsync = (struct tracecmd_time_sync *)data; + + tracecmd_tsync_with_guest(tsync); + + tracecmd_msg_handle_close(tsync->msg_handle); + tsync->msg_handle = NULL; + + pthread_exit(0); +} + +int tracecmd_host_tsync(struct buffer_instance *instance, + unsigned int tsync_port) +{ + struct tracecmd_msg_handle *msg_handle = NULL; + cpu_set_t *pin_mask = NULL; + pthread_attr_t attrib; + size_t mask_size = 0; + int ret; + int fd; + + if (!instance->tsync.sync_proto) + return -1; + + fd = open_vsock(instance->cid, tsync_port); + if (fd < 0) { + ret = -1; + goto out; + } + msg_handle = tracecmd_msg_handle_alloc(fd, 0); + if (!msg_handle) { + ret = -1; + goto out; + } + + instance->tsync.msg_handle = msg_handle; + if (top_instance.ftrace->clock) + instance->tsync.clock_str = strdup(top_instance.ftrace->clock); + ret = sem_init(&instance->tsync.sem, 0, 0); + if (ret) + goto out; + + pthread_attr_init(&attrib); + pthread_attr_setdetachstate(&attrib, PTHREAD_CREATE_JOINABLE); + if (!get_first_cpu(&pin_mask, &mask_size)) + pthread_attr_setaffinity_np(&attrib, mask_size, pin_mask); + + ret = pthread_create(&instance->tsync_thread, &attrib, + tsync_host_thread, &instance->tsync); + if (!ret) + instance->tsync_thread_running = true; + if (pin_mask) + CPU_FREE(pin_mask); + pthread_attr_destroy(&attrib); + +out: + if (ret) { + if (msg_handle) + tracecmd_msg_handle_close(msg_handle); + } + + return ret; +} + +static void write_guest_time_shift(struct buffer_instance *instance) +{ + struct tracecmd_output *handle; + struct iovec vector[4]; + long long *offsets; + long long *ts; + char *file; + int count; + int ret; + int fd; + + ret = tracecmd_tsync_get_offsets(&instance->tsync, &count, &ts, &offsets); + if (ret < 0 || !count || !ts || !offsets) + return; + + file = get_guest_file(TRACE_FILENAME, instance->ftrace->name); + fd = open(file, O_RDWR); + if (fd < 0) + die("error opening %s", file); + free(file); + handle = tracecmd_get_output_handle_fd(fd); + vector[0].iov_len = 8; + vector[0].iov_base = &top_instance.trace_id; + vector[1].iov_len = 4; + vector[1].iov_base = &count; + vector[2].iov_len = 8 * count; + vector[2].iov_base = ts; + vector[3].iov_len = 8 * count; + vector[3].iov_base = offsets; + tracecmd_add_option_v(handle, TRACECMD_OPTION_TIME_SHIFT, vector, 4); + tracecmd_append_options(handle); + tracecmd_output_close(handle); +#ifdef TSYNC_DEBUG + if (count > 1) + printf("Got %d timestamp synch samples for guest %s in %lld ns trace\n\r", + count, instance->ftrace->name, ts[count - 1] - ts[0]); +#endif +} + +void tracecmd_host_tsync_complete(struct buffer_instance *instance) +{ + if (!instance->tsync_thread_running) + return; + + sem_post(&instance->tsync.sem); + pthread_join(instance->tsync_thread, NULL); + write_guest_time_shift(instance); + tracecmd_tsync_free(&instance->tsync); +} + +static void *tsync_agent_thread(void *data) +{ + struct tracecmd_time_sync *tsync = NULL; + int sd; + + tsync = (struct tracecmd_time_sync *)data; + + while (true) { + sd = accept(tsync->msg_handle->fd, NULL, NULL); + if (sd < 0) { + if (errno == EINTR) + continue; + goto out; + } + break; + } + close(tsync->msg_handle->fd); + tsync->msg_handle->fd = sd; + + tracecmd_tsync_with_host(tsync); + +out: + tracecmd_msg_handle_close(tsync->msg_handle); + tracecmd_tsync_free(tsync); + free(tsync); + close(sd); + + pthread_exit(0); +} + +unsigned int tracecmd_guest_tsync(unsigned int tsync_protos, char *clock, + unsigned int *tsync_port, + pthread_t *thr_id) +{ + struct tracecmd_time_sync *tsync = NULL; + cpu_set_t *pin_mask = NULL; + pthread_attr_t attrib; + size_t mask_size = 0; + unsigned int proto; + int ret; + int fd; + + fd = -1; + proto = tracecmd_tsync_proto_select(tsync_protos); + if (!proto) + return 0; +#ifdef VSOCK + fd = make_vsock(VMADDR_PORT_ANY); + if (fd < 0) + goto error; + + ret = get_vsock_port(fd, tsync_port); + if (ret < 0) + goto error; +#else + return 0; +#endif + + tsync = calloc(1, sizeof(struct tracecmd_time_sync)); + tsync->msg_handle = tracecmd_msg_handle_alloc(fd, 0); + if (clock) + tsync->clock_str = strdup(clock); + + pthread_attr_init(&attrib); + tsync->sync_proto = proto; + pthread_attr_setdetachstate(&attrib, PTHREAD_CREATE_JOINABLE); + if (!get_first_cpu(&pin_mask, &mask_size)) + pthread_attr_setaffinity_np(&attrib, mask_size, pin_mask); + + ret = pthread_create(thr_id, &attrib, tsync_agent_thread, tsync); + + if (pin_mask) + CPU_FREE(pin_mask); + pthread_attr_destroy(&attrib); + + if (ret) + goto error; + + return proto; + +error: + if (tsync) { + if (tsync->msg_handle) + tracecmd_msg_handle_close(tsync->msg_handle); + if (tsync->clock_str) + free(tsync->clock_str); + free(tsync); + } + if (fd > 0) + close(fd); + return 0; +} diff --git a/tracecmd/trace-usage.c b/tracecmd/trace-usage.c index 05ec021..9fa61e1 100644 --- a/tracecmd/trace-usage.c +++ b/tracecmd/trace-usage.c @@ -60,6 +60,10 @@ static struct usage_help usage_help[] = { " --no-filter include trace-cmd threads in the trace\n" " --proc-map save the traced processes address map into the trace.dat file\n" " --user execute the specified [command ...] as given user\n" + " --tsync-interval set the loop interval, in ms, for timestamps synchronization with guests:" + " If a negative number is specified, timestamps synchronization is disabled" + " If 0 is specified, no loop is performed - timestamps offset is calculated only twice," + " at the beginnig and at the end of the trace\n" }, { "start", From patchwork Tue Dec 3 10:35:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270965 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BD59326D6 for ; Tue, 3 Dec 2019 10:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9B7A1205ED for ; Tue, 3 Dec 2019 10:35:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j0gBwkqQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726075AbfLCKfv (ORCPT ); Tue, 3 Dec 2019 05:35:51 -0500 Received: from mail-lf1-f66.google.com ([209.85.167.66]:42870 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbfLCKfv (ORCPT ); Tue, 3 Dec 2019 05:35:51 -0500 Received: by mail-lf1-f66.google.com with SMTP id y19so2483874lfl.9 for ; Tue, 03 Dec 2019 02:35:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XN8IigCi1xoE5/5AsTY/DIuDr9k6S7/P1NzzmuigKbg=; b=j0gBwkqQk6zXxoOwpWsadnlOQcdIkvwUxWthv+qHCqqF22o6854oVNM/S7CSWYT3u6 64fR7JO55oaWpdEvuOX/KkTqkkaDnHAQLBqnKyhH1clsFcgU6SWJd8QchaQNu/7USrK7 CZYv7Wd6RFKFuaPdlogjh+qdKbkAsdb7K+GDVx0o9a4KcW28k/BW7LnrDOx2sL7qfrxy P9Z2F201ZZMknnCCMzRt0YZKI/GBpLbJ6+mgYRbNQfr/ZYZaJ5b0biaRArmcvAoFsp2a U2v6t4rpmJ+ykL8jzTmVQT2Wy3YnUEbx1xPwXlpQDLXyhjIdsf+/27QsbsXGMJJZsYM0 MU2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XN8IigCi1xoE5/5AsTY/DIuDr9k6S7/P1NzzmuigKbg=; b=QS0ud3sRXT3XgkckvIyZptVhvzxHodf1G60Px54T65TGUnGMbHbEd6IpIblHYKc9bC oOHkiJM+aIdblV82LmwfWDyUPiXihXm4yxr5LoFu4Jl1HCbIM6ykoQ+a3POmSUIPnesN +d3awLG3R4D7i0X/MdzSHCLosrn4fFQLFROLv/dvitmjh4BinXL0/Xt/cMy2t7A5z/bR uQiRMJp7Yg/xMZH96LHvP3eXLkURcPUaE+5bf4T/Fq7ZkK9ygdZv5ACmzH4o2tkFiQg8 1aqxie4Q2+cvc59KXBAxpvcjX4LBHl/uYoe8sK/AXH4WbtWcFiXPfUuDwxOKHyMoRcI/ 3Q4A== X-Gm-Message-State: APjAAAVwsz6Ik+q4NEVAlnIgh8EnBSfIEBzFKcIHAA0AV3hJ1YP4ADKc t1HR8NeY1btrgZZAGCzc65xDg2aC4+c= X-Google-Smtp-Source: APXvYqzdpxm89XczEpyIfLP5HwxQIr1ibC5Vv4X2URjIy6kOSeCMr0zT06uIvKEQZwvCscZUY9+DtA== X-Received: by 2002:ac2:47e6:: with SMTP id b6mr2237963lfp.96.1575369346684; Tue, 03 Dec 2019 02:35:46 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:46 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 17/18] trace-cmd: [POC] PTP-like algorithm for host - guest timestamp synchronization Date: Tue, 3 Dec 2019 12:35:21 +0200 Message-Id: <20191203103522.482684-18-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org PTP protocol is designed for synchronizing clocks of machines in a local network. The same approach can be used for host - guest timestamp synchronization. This implementation uses ftrace raw markers to track trace timestamps of PTP events. The patch is a POC, two different algorithms for PTP calculations are proposed: - Choosing the sample with the fastest response time for calculating the clocks offset. - Calculating the clocks offset using the average of all PTP samples. The implementation can be tuned using those parameters: - #define FASTEST_RESPONSE - is defined, the sample with the fastest response time is used for calculating the clocks offset. Otherwise the histogram of all samples is used. - #define PTP_SYNC_LOOP 340 - defines the number of samples, used for one calculation. - --tsync-interval - a trace-cmd argument, choose the intervals between offset calculations, performed continuously during the trace. - #define TSYNC_DEBUG - if defined, a debug information is collected and stored in files, in the guest machine: s-cid*.txt - For each offset calculation: host and guest clocks and calculated offset. res-cid*.txt - For each tracing session: all calculated clock offsets. Signed-off-by: Tzvetomir Stoyanov (VMware) --- include/trace-cmd/trace-cmd.h | 2 + lib/trace-cmd/Makefile | 1 + lib/trace-cmd/trace-timesync-ptp.c | 649 +++++++++++++++++++++++++++++ lib/trace-cmd/trace-timesync.c | 8 + tracecmd/trace-agent.c | 2 + tracecmd/trace-record.c | 25 +- 6 files changed, 679 insertions(+), 8 deletions(-) create mode 100644 lib/trace-cmd/trace-timesync-ptp.c diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h index 6abcc9f..013160a 100644 --- a/include/trace-cmd/trace-cmd.h +++ b/include/trace-cmd/trace-cmd.h @@ -427,6 +427,7 @@ int tracecmd_iterate_raw_events(struct tep_handle *tep, enum{ TRACECMD_TIME_SYNC_PROTO_NONE = 0, + TRACECMD_TIME_SYNC_PROTO_PTP = 1 << 0, }; enum{ TRACECMD_TIME_SYNC_CMD_PROBE = 1, @@ -444,6 +445,7 @@ struct tracecmd_time_sync { void *context; }; +void tracecmd_tsync_init(void); unsigned int tracecmd_tsync_proto_getall(void); unsigned int tracecmd_tsync_proto_select(unsigned int protos); void tracecmd_tsync_with_host(struct tracecmd_time_sync *tsync); diff --git a/lib/trace-cmd/Makefile b/lib/trace-cmd/Makefile index 6221b36..a2b9d08 100644 --- a/lib/trace-cmd/Makefile +++ b/lib/trace-cmd/Makefile @@ -17,6 +17,7 @@ OBJS += trace-instance.o OBJS += trace-filter-hash.o OBJS += trace-msg.o OBJS += trace-timesync.o +OBJS += trace-timesync-ptp.o # Additional util objects OBJS += trace-blk-hack.o diff --git a/lib/trace-cmd/trace-timesync-ptp.c b/lib/trace-cmd/trace-timesync-ptp.c new file mode 100644 index 0000000..6a5f5b7 --- /dev/null +++ b/lib/trace-cmd/trace-timesync-ptp.c @@ -0,0 +1,649 @@ +// SPDX-License-Identifier: LGPL-2.1 +/* + * Copyright (C) 2019, VMware, Tzvetomir Stoyanov tz.stoyanov@gmail.com> + * + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include "trace-cmd.h" +#include "trace-tsync-local.h" +#include "trace-msg.h" + +typedef __be32 be32; +typedef __u64 u64; +typedef __s64 s64; + +#define PTP_SYNC_LOOP 340 + +#define PTP_SYNC_PKT_START 1 +#define PTP_SYNC_PKT_PROBE 2 +#define PTP_SYNC_PKT_PROBES 3 +#define PTP_SYNC_PKT_OFFSET 4 +#define PTP_SYNC_PKT_END 5 + +#define TSYNC_DEBUG + +struct ptp_clock_sync { + struct tep_handle *tep; + int raw_id; + int marker_fd; + int series_id; + int debug_fd; + +}; + +struct ptp_clock_start_msg { + be32 series_id; +} __attribute__((packed)); + +struct ptp_clock_sample { + s64 ts; + be32 id; +} __attribute__((packed)); + +struct ptp_clock_result_msg { + be32 series_id; + be32 count; + struct ptp_clock_sample samples[2*PTP_SYNC_LOOP]; +} __attribute__((packed)); + +struct ptp_clock_offset_msg { + s64 ts; + s64 offset; +}; + +struct ptp_markers_context { + struct clock_sync_context *clock; + struct ptp_clock_sync *ptp; + int size; + struct ptp_clock_result_msg msg; +}; + +struct ptp_marker_buf { + int local_cid; + int remote_cid; + int count; + int packet_id; +} __attribute__((packed)); + +struct ptp_marker{ + int series_id; + struct ptp_marker_buf data; +} __attribute__((packed)); + +static int ptp_clock_sync_init(struct tracecmd_time_sync *tsync) +{ + const char *systems[] = { "ftrace", NULL}; + struct clock_sync_context *clock_context; + struct ptp_clock_sync *ptp; + struct tep_event *raw; + char *path; + + if (!tsync || !tsync->context) + return -1; + clock_context = (struct clock_sync_context *)tsync->context; + if (clock_context->proto_data) + return 0; + + ptp = calloc(1, sizeof(struct ptp_clock_sync)); + if (!ptp) + return -1; + + ptp->marker_fd = -1; + ptp->debug_fd = -1; + + path = tracecmd_get_instance_dir(clock_context->vinst); + if (!path) + goto error; + ptp->tep = tracecmd_local_events_system(path, systems); + tracecmd_put_tracing_file(path); + if (!ptp->tep) + goto error; + raw = tep_find_event_by_name(ptp->tep, "ftrace", "raw_data"); + if (!raw) + goto error; + + ptp->raw_id = raw->id; + tep_set_file_bigendian(ptp->tep, tracecmd_host_bigendian()); + tep_set_local_bigendian(ptp->tep, tracecmd_host_bigendian()); + + path = tracecmd_get_instance_file(clock_context->vinst, "trace_marker_raw"); + if (!path) + goto error; + ptp->marker_fd = open(path, O_WRONLY); + tracecmd_put_tracing_file(path); + + clock_context->proto_data = ptp; + +#ifdef TSYNC_DEBUG + if (clock_context->server) { + char buff[256]; + int res_fd; + + sprintf(buff, "res-cid%d.txt", clock_context->remote_cid); + + res_fd = open(buff, O_CREAT|O_WRONLY|O_TRUNC, 0644); + if (res_fd > 0) + close(res_fd); + } +#endif + + return 0; + +error: + if (ptp) { + tep_free(ptp->tep); + if (ptp->marker_fd >= 0) + close(ptp->marker_fd); + } + free(ptp); + return -1; +} + +static int ptp_clock_sync_free(struct tracecmd_time_sync *tsync) +{ + struct clock_sync_context *clock_context; + struct ptp_clock_sync *ptp; + + if (!tsync || !tsync->context) + return -1; + clock_context = (struct clock_sync_context *)tsync->context; + + if (clock_context && clock_context->proto_data) { + ptp = (struct ptp_clock_sync *)clock_context->proto_data; + tep_free(ptp->tep); + if (ptp->marker_fd >= 0) + close(ptp->marker_fd); + if (ptp->debug_fd >= 0) + close(ptp->debug_fd); + free(clock_context->proto_data); + clock_context->proto_data = NULL; + } + return 0; +} + +static int ptp_marker_find(struct tep_event *event, struct tep_record *record, + int cpu, void *context) +{ + struct ptp_markers_context *ctx; + struct tep_format_field *field; + struct tep_format_field *id; + struct ptp_marker *marker; + int index = -1; + + ctx = (struct ptp_markers_context *)context; + + /* Make sure this is our event */ + if (event->id != ctx->ptp->raw_id) + return 0; + id = tep_find_field(event, "id"); + field = tep_find_field(event, "buf"); + if (field && id && + record->size >= (id->offset + sizeof(struct ptp_marker))) { + marker = (struct ptp_marker *)(record->data + id->offset); + if (marker->data.local_cid == ctx->clock->local_cid && + marker->data.remote_cid == ctx->clock->remote_cid && + marker->series_id == ctx->ptp->series_id && + marker->data.count) { + if (marker->data.packet_id == 'r' && + marker->data.count <= ctx->size) { + index = marker->data.count - 1; + } else if (marker->data.packet_id == 's' && + marker->data.count*2 <= ctx->size){ + index = ctx->size / 2 + marker->data.count - 1; + } + } + if (index >= 0) { + ctx->msg.samples[index].id = marker->data.count; + ctx->msg.samples[index].ts = record->ts; + ctx->msg.count++; + } + } + + return 0; +} + +//#define FASTEST_RESPONSE + +#ifdef FASTEST_RESPONSE +static int ptp_calc_offset(struct clock_sync_context *clock, + struct ptp_clock_result_msg *server, + struct ptp_clock_result_msg *client, + long long *offset_ret, long long *ts_ret, + int *bad_probes) +{ + struct ptp_clock_sample *sample_send; + long long delta_min = 0; + long long offset = 0; + long long delta = 0; + long long ts = 0; + int i; + + *bad_probes = 0; + sample_send = server->samples + (server->count / 2); + for (i = 0; i * 2 < server->count && i < client->count; i++) { + if (!server->samples[i].ts || + !sample_send[i].ts || + !client->samples[i].ts || + server->samples[i].id != sample_send[i].id || + server->samples[i].id != client->samples[i].id) { + (*bad_probes)++; + continue; + } + + ts = (sample_send[i].ts + server->samples[i].ts) / 2; + offset = client->samples[i].ts - ts; + + delta = server->samples[i].ts - sample_send[i].ts; + if (!delta_min || delta_min > delta) { + delta_min = delta; + *offset_ret = offset; + *ts_ret = ts; + } +#ifdef TSYNC_DEBUG + { + struct ptp_clock_sync *ptp; + + ptp = (struct ptp_clock_sync *)clock->proto_data; + if (ptp && ptp->debug_fd > 0) { + char buff[256]; + + sprintf(buff, "%lld %lld %lld\n", + ts, client->samples[i].ts, offset); + write(ptp->debug_fd, buff, strlen(buff)); + } + } +#endif + } + + return 0; +} + +#else /* histogram */ + +static int ptp_calc_offset(struct clock_sync_context *clock, + struct ptp_clock_result_msg *server, + struct ptp_clock_result_msg *client, + long long *offset_ret, long long *ts_ret, + int *bad_probes) +{ + struct ptp_clock_sample *sample_send; + long long timestamps[PTP_SYNC_LOOP]; + long long offsets[PTP_SYNC_LOOP]; + int hist[PTP_SYNC_LOOP]; + long long offset_max = 0; + long long offset_min = 0; + int ind, max = 0; + long long bin; + int i, k = 0; + + *bad_probes = 0; + memset(hist, 0, sizeof(int) * PTP_SYNC_LOOP); + sample_send = server->samples + (server->count / 2); + for (i = 0; i * 2 < server->count && i < client->count; i++) { + if (!server->samples[i].ts || + !sample_send[i].ts || + !client->samples[i].ts || + server->samples[i].id != sample_send[i].id || + server->samples[i].id != client->samples[i].id) { + (*bad_probes)++; + continue; + } + + timestamps[k] = (sample_send[i].ts + server->samples[i].ts) / 2; + offsets[k] = client->samples[i].ts - timestamps[k]; + if (!offset_max || offset_max < llabs(offsets[k])) + offset_max = llabs(offsets[k]); + if (!offset_min || offset_min > llabs(offsets[k])) + offset_min = llabs(offsets[k]); +#ifdef TSYNC_DEBUG + { + struct ptp_clock_sync *ptp; + + ptp = (struct ptp_clock_sync *)clock->proto_data; + + if (ptp && ptp->debug_fd > 0) { + char buff[256]; + + sprintf(buff, "%lld %lld %lld\n", + timestamps[k], + client->samples[i].ts, offsets[k]); + write(ptp->debug_fd, buff, strlen(buff)); + } + } +#endif + k++; + } + + bin = (offset_max - offset_min) / PTP_SYNC_LOOP; + for (i = 0; i < k; i++) { + ind = (llabs(offsets[i]) - offset_min) / bin; + if (ind < PTP_SYNC_LOOP) { + hist[ind]++; + if (max < hist[ind]) { + max = hist[ind]; + *offset_ret = offsets[i]; + *ts_ret = timestamps[i]; + } + } + } + + return 0; +} +#endif + +static void ntoh_ptp_results(struct ptp_clock_result_msg *msg) +{ + int i; + + msg->count = ntohl(msg->count); + for (i = 0; i < msg->count; i++) { + msg->samples[i].id = ntohl(msg->samples[i].id); + msg->samples[i].ts = ntohll(msg->samples[i].ts); + } + msg->series_id = ntohl(msg->series_id); +} + + +static void hton_ptp_results(struct ptp_clock_result_msg *msg) +{ + int i; + + for (i = 0; i < msg->count; i++) { + msg->samples[i].id = htonl(msg->samples[i].id); + msg->samples[i].ts = htonll(msg->samples[i].ts); + } + msg->series_id = htonl(msg->series_id); + msg->count = htonl(msg->count); +} + +static int ptp_clock_client(struct tracecmd_time_sync *tsync, + long long *offset, long long *timestamp) +{ + struct clock_sync_context *clock_context; + struct ptp_clock_offset_msg res_offset; + unsigned int sync_proto, sync_msg; + struct ptp_clock_start_msg start; + struct ptp_markers_context ctx; + struct ptp_clock_sync *ptp; + struct ptp_marker marker; + unsigned int size; + char *msg; + int count; + int ret; + + if (!tsync || !tsync->context || !tsync->msg_handle) + return -1; + + clock_context = (struct clock_sync_context *)tsync->context; + if (clock_context->proto_data == NULL) + return -1; + + ptp = (struct ptp_clock_sync *)clock_context->proto_data; + size = sizeof(start); + msg = (char *)&start; + ret = tracecmd_msg_recv_time_sync(tsync->msg_handle, + &sync_proto, &sync_msg, + &size, &msg); + if (ret || sync_proto != TRACECMD_TIME_SYNC_PROTO_PTP || + sync_msg != PTP_SYNC_PKT_START) + return -1; + ret = tracecmd_msg_send_time_sync(tsync->msg_handle, + TRACECMD_TIME_SYNC_PROTO_PTP, + PTP_SYNC_PKT_START, sizeof(start), + (char *)&start); + marker.data.local_cid = clock_context->local_cid; + marker.data.remote_cid = clock_context->remote_cid; + marker.series_id = ntohl(start.series_id); + marker.data.packet_id = 'r'; + ptp->series_id = marker.series_id; + msg = (char *)&count; + size = sizeof(count); + while (true) { + count = 0; + ret = tracecmd_msg_recv_time_sync(tsync->msg_handle, + &sync_proto, &sync_msg, + &size, &msg); + if (ret || sync_proto != TRACECMD_TIME_SYNC_PROTO_PTP || + sync_msg != PTP_SYNC_PKT_PROBE || !ntohl(count)) + break; + + marker.data.count = ntohl(count); + write(ptp->marker_fd, &marker, sizeof(marker)); + ret = tracecmd_msg_send_time_sync(tsync->msg_handle, + TRACECMD_TIME_SYNC_PROTO_PTP, + PTP_SYNC_PKT_PROBE, + sizeof(count), (char *)&count); + if (ret) + break; + } + + if (sync_proto != TRACECMD_TIME_SYNC_PROTO_PTP || + sync_msg != PTP_SYNC_PKT_END) + return -1; + + ctx.size = PTP_SYNC_LOOP; + ctx.ptp = ptp; + ctx.clock = clock_context; + ctx.msg.count = 0; + ctx.msg.series_id = ptp->series_id; + tracecmd_iterate_raw_events(ptp->tep, clock_context->vinst, + ptp_marker_find, &ctx); + hton_ptp_results(&ctx.msg); + ret = tracecmd_msg_send_time_sync(tsync->msg_handle, + TRACECMD_TIME_SYNC_PROTO_PTP, + PTP_SYNC_PKT_PROBES, + sizeof(ctx.msg), (char *)&ctx.msg); + + msg = (char *)&res_offset; + size = sizeof(res_offset); + ret = tracecmd_msg_recv_time_sync(tsync->msg_handle, + &sync_proto, &sync_msg, + &size, (char **)&msg); + if (ret || sync_proto != TRACECMD_TIME_SYNC_PROTO_PTP || + sync_msg != PTP_SYNC_PKT_OFFSET) + return -1; + + *offset = ntohll(res_offset.offset); + *timestamp = ntohll(res_offset.ts); + + return 0; +} + + +static int ptp_clock_server(struct tracecmd_time_sync *tsync, + long long *offset, long long *timestamp) +{ + struct ptp_clock_result_msg *results = NULL; + struct clock_sync_context *clock_context; + struct ptp_clock_offset_msg res_offset; + unsigned int sync_proto, sync_msg; + struct ptp_clock_start_msg start; + struct ptp_markers_context ctx; + int sync_loop = PTP_SYNC_LOOP; + struct ptp_clock_sync *ptp; + struct ptp_marker marker; + unsigned int size; + int bad_probes; + int count = 1; + int msg_count; + int msg_ret; + char *msg; + int ret; + + if (!tsync || !tsync->context || !tsync->msg_handle) + return -1; + + clock_context = (struct clock_sync_context *)tsync->context; + if (clock_context->proto_data == NULL) + return -1; + + ptp = (struct ptp_clock_sync *)clock_context->proto_data; + start.series_id = htonl(ptp->series_id + 1); + ret = tracecmd_msg_send_time_sync(tsync->msg_handle, + TRACECMD_TIME_SYNC_PROTO_PTP, + PTP_SYNC_PKT_START, sizeof(start), + (char *)&start); + if (!ret) + ret = tracecmd_msg_recv_time_sync(tsync->msg_handle, + &sync_proto, &sync_msg, + NULL, NULL); + if (ret || sync_proto != TRACECMD_TIME_SYNC_PROTO_PTP || + sync_msg != PTP_SYNC_PKT_START) + return -1; + + tracecmd_write_instance_file(clock_context->vinst, "trace", "\0", NULL); + + ptp->series_id++; + marker.data.local_cid = clock_context->local_cid; + marker.data.remote_cid = clock_context->remote_cid; + marker.series_id = ptp->series_id; + msg = (char *)&msg_ret; + size = sizeof(msg_ret); + do { + marker.data.count = count++; + marker.data.packet_id = 's'; + msg_count = htonl(marker.data.count); + write(ptp->marker_fd, &marker, sizeof(marker)); + ret = tracecmd_msg_send_time_sync(tsync->msg_handle, + TRACECMD_TIME_SYNC_PROTO_PTP, + PTP_SYNC_PKT_PROBE, + sizeof(msg_count), + (char *)&msg_count); + if (!ret) + ret = tracecmd_msg_recv_time_sync(tsync->msg_handle, + &sync_proto, &sync_msg, + &size, &msg); + + marker.data.packet_id = 'r'; + write(ptp->marker_fd, &marker, sizeof(marker)); + if (ret || sync_proto != TRACECMD_TIME_SYNC_PROTO_PTP || + sync_msg != PTP_SYNC_PKT_PROBE || + ntohl(msg_ret) != marker.data.count) + break; + } while (--sync_loop); + + if (sync_loop) + return -1; + + ret = tracecmd_msg_send_time_sync(tsync->msg_handle, + TRACECMD_TIME_SYNC_PROTO_PTP, + PTP_SYNC_PKT_END, 0, NULL); + + size = 0; + ret = tracecmd_msg_recv_time_sync(tsync->msg_handle, + &sync_proto, &sync_msg, + &size, (char **)&results); + if (ret || sync_proto != TRACECMD_TIME_SYNC_PROTO_PTP || + sync_msg != PTP_SYNC_PKT_PROBES || size == 0 || results == NULL) + return -1; + + ntoh_ptp_results(results); + + ctx.size = 2*PTP_SYNC_LOOP; + ctx.ptp = ptp; + ctx.clock = clock_context; + ctx.msg.count = 0; + ctx.msg.series_id = ptp->series_id; + tracecmd_iterate_raw_events(ptp->tep, clock_context->vinst, + ptp_marker_find, &ctx); + + ptp_calc_offset(clock_context, &ctx.msg, results, offset, + timestamp, &bad_probes); + +#ifdef TSYNC_DEBUG + { + char buff[256]; + int res_fd; + + sprintf(buff, "res-cid%d.txt", clock_context->remote_cid); + + res_fd = open(buff, O_WRONLY|O_APPEND, 0644); + if (res_fd > 0) { + if (*offset && *timestamp) { + sprintf(buff, "%d %lld %lld\n", + ptp->series_id, *offset, *timestamp); + write(res_fd, buff, strlen(buff)); + } + close(res_fd); + } + + printf("\n calculated offset %d: %lld, %d probes, filtered out %d\n\r", + ptp->series_id, *offset, results->count, bad_probes); + if (ptp && ptp->debug_fd > 0) { + sprintf(buff, "%lld %lld 0\n", *offset, *timestamp); + write(ptp->debug_fd, buff, strlen(buff)); + close(ptp->debug_fd); + ptp->debug_fd = -1; + } + + } +#endif + + res_offset.offset = htonll(*offset); + res_offset.ts = htonll(*timestamp); + ret = tracecmd_msg_send_time_sync(tsync->msg_handle, + TRACECMD_TIME_SYNC_PROTO_PTP, + PTP_SYNC_PKT_OFFSET, + sizeof(res_offset), + (char *)&res_offset); + + free(results); + return 0; +} + +static int ptp_clock_sync_calc(struct tracecmd_time_sync *tsync, + long long *offset, long long *timestamp) +{ + struct clock_sync_context *clock_context; + int ret; + + if (!tsync || !tsync->context) + return -1; + clock_context = (struct clock_sync_context *)tsync->context; + +#ifdef TSYNC_DEBUG + if (clock_context->server) { + struct ptp_clock_sync *ptp; + char buff[256]; + + ptp = (struct ptp_clock_sync *)clock_context->proto_data; + if (ptp->debug_fd > 0) + close(ptp->debug_fd); + sprintf(buff, "s-cid%d_%d.txt", + clock_context->remote_cid, ptp->series_id+1); + ptp->debug_fd = open(buff, O_CREAT|O_WRONLY|O_TRUNC, 0644); + } +#endif + + + if (clock_context->server) + ret = ptp_clock_server(tsync, offset, timestamp); + else + ret = ptp_clock_client(tsync, offset, timestamp); + + return ret; +} + +int ptp_clock_sync_register(void) +{ + return tracecmd_tsync_proto_register(TRACECMD_TIME_SYNC_PROTO_PTP, + TRACECMD_TIME_SYNC_PROTO_PTP_WEIGHT, + ptp_clock_sync_init, + ptp_clock_sync_free, + ptp_clock_sync_calc); + +} + +int ptp_clock_sync_unregister(void) +{ + return tracecmd_tsync_proto_unregister(TRACECMD_TIME_SYNC_PROTO_PTP); +} diff --git a/lib/trace-cmd/trace-timesync.c b/lib/trace-cmd/trace-timesync.c index 073423d..5458c4f 100644 --- a/lib/trace-cmd/trace-timesync.c +++ b/lib/trace-cmd/trace-timesync.c @@ -42,6 +42,14 @@ static struct tsync_proto *tsync_proto_get(unsigned int proto_id) return NULL; } +/** + * tracecmd_tsync_init - Initialize the global, per task, time sync data. + */ +void tracecmd_tsync_init(void) +{ + ptp_clock_sync_register(); +} + int tracecmd_tsync_proto_register(unsigned int proto_id, int weight, int (*init)(struct tracecmd_time_sync *), int (*free)(struct tracecmd_time_sync *), diff --git a/tracecmd/trace-agent.c b/tracecmd/trace-agent.c index 1581de8..46874cf 100644 --- a/tracecmd/trace-agent.c +++ b/tracecmd/trace-agent.c @@ -242,6 +242,8 @@ static void agent_serve(unsigned int port) if (sd < 0) die("Failed to open vsocket"); + tracecmd_tsync_init(); + if (!get_local_cid(&cid)) printf("listening on @%u:%u\n", cid, port); diff --git a/tracecmd/trace-record.c b/tracecmd/trace-record.c index e543c40..c29f1ce 100644 --- a/tracecmd/trace-record.c +++ b/tracecmd/trace-record.c @@ -5944,10 +5944,7 @@ static void set_clock(struct buffer_instance *instance) tracecmd_put_tracing_file(path); } } -/* - * This function contains common code for the following commands: - * record, start, stream, profile. - */ + static void record_trace(int argc, char **argv, struct common_record_context *ctx) { @@ -6080,12 +6077,24 @@ static void record_trace(int argc, char **argv, finalize_record_trace(ctx); } +/* + * This function contains common code for the following commands: + * record, start, stream, profile. + */ +static void record_trace_command(int argc, char **argv, + struct common_record_context *ctx) +{ + tracecmd_tsync_init(); + record_trace(argc, argv, ctx); +} + + void trace_start(int argc, char **argv) { struct common_record_context ctx; parse_record_options(argc, argv, CMD_start, &ctx); - record_trace(argc, argv, &ctx); + record_trace_command(argc, argv, &ctx); exit(0); } @@ -6165,7 +6174,7 @@ void trace_stream(int argc, char **argv) struct common_record_context ctx; parse_record_options(argc, argv, CMD_stream, &ctx); - record_trace(argc, argv, &ctx); + record_trace_command(argc, argv, &ctx); exit(0); } @@ -6184,7 +6193,7 @@ void trace_profile(int argc, char **argv) if (!buffer_instances) top_instance.flags |= BUFFER_FL_PROFILE; - record_trace(argc, argv, &ctx); + record_trace_command(argc, argv, &ctx); do_trace_profile(); exit(0); } @@ -6203,7 +6212,7 @@ void trace_record(int argc, char **argv) struct common_record_context ctx; parse_record_options(argc, argv, CMD_record, &ctx); - record_trace(argc, argv, &ctx); + record_trace_command(argc, argv, &ctx); exit(0); } From patchwork Tue Dec 3 10:35:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Tzvetomir Stoyanov (VMware)" X-Patchwork-Id: 11270963 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 49A571ABA for ; Tue, 3 Dec 2019 10:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26AD8205ED for ; Tue, 3 Dec 2019 10:35:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YFiSYFor" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725773AbfLCKfv (ORCPT ); Tue, 3 Dec 2019 05:35:51 -0500 Received: from mail-lf1-f53.google.com ([209.85.167.53]:40300 "EHLO mail-lf1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbfLCKfu (ORCPT ); Tue, 3 Dec 2019 05:35:50 -0500 Received: by mail-lf1-f53.google.com with SMTP id y5so2507731lfy.7 for ; Tue, 03 Dec 2019 02:35:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nY5ircyGmJVBcwcMrvZaPID8lurhvLRNnjjwQUGl8j4=; b=YFiSYForcORnOtrpM2oVBqGdBMQ1ALSnL8vhLU8zEtOdtl0JQICS6mD7EVZQVwYFN3 o+XLxwsTP+kkOuhmMMD2ywqo6gewohbd7yTh9wSyQbTADJl+LQcVRps8P4KJlZf9yPis gE0EkyupAZR31tIAkbESaMKPf/p+1lB3GTV8Dp8A1a4B/Z3YB/aF9T1ueKNdVFL+5sKy kgG6rzAGhPNC01/ZuJWPGTU/GFlOnOWdpveUp/aJIg811TJuuXnFIrRcH84k9O0X1kS/ vmCJUqUID52G67bwpfZdQVtRjaNeV8B4hyZwEZC27ZjB9xHlCs8PMWb6Pv8advMqFvuo 55uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nY5ircyGmJVBcwcMrvZaPID8lurhvLRNnjjwQUGl8j4=; b=OvJYQyd4wjr/9PoDVzcGgO/S/I8eb4T84uFUGoXTfP89LQZkpJRPYdx+G7twsnxAou 40nFr4S8lwKrc3mockVZMowsHb4dSZp7OcMM89en1O7JTxF6M6YjQWHecX0hiIAuLIif dDSS1M04bqrCSFpzF86dbpe7zeJmVMhmZagXrdOVmtwjpNKZDCQmkoUawPJYDahYJL2Y PzTO7l5XxCP4vRU7ZrgGXNYGvX41EtHQ76//WM4CRrp14vGuy3etCW7S+33otV4fY8LU IM7AZSo2BAapxxPku4JI6rTc+dINjoLztTc36Oh81MEx99IayVYWJDUTEvjvTAv5l7Fr Q0aQ== X-Gm-Message-State: APjAAAXrKNsbsxgYnbQdv74CpKh+LZgP6ggyNQWuxgAiHkVawI4EkySy wxalEwcDePJqT5P5t2GjfFcEGossV94= X-Google-Smtp-Source: APXvYqxLZmjuULKqruNUdM2/FcehZseO4UhrW/+W70PNaS6uo2J6m8CiPZQCkW407kz704Vs341xUw== X-Received: by 2002:ac2:4422:: with SMTP id w2mr2302781lfl.178.1575369347762; Tue, 03 Dec 2019 02:35:47 -0800 (PST) Received: from oberon.eng.vmware.com ([146.247.46.5]) by smtp.gmail.com with ESMTPSA id t9sm1053023lfl.51.2019.12.03.02.35.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 02:35:47 -0800 (PST) From: "Tzvetomir Stoyanov (VMware)" To: rostedt@goodmis.org Cc: linux-trace-devel@vger.kernel.org Subject: [PATCH v17 18/18] trace-cmd: Debug scripts for PTP-like algorithm for host - guest timestamp synchronization Date: Tue, 3 Dec 2019 12:35:22 +0200 Message-Id: <20191203103522.482684-19-tz.stoyanov@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191203103522.482684-1-tz.stoyanov@gmail.com> References: <20191203103522.482684-1-tz.stoyanov@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org These scripts can be used to visualise debug files, written when the PTP-like algorithm is compiled with TSYNC_DEBUG defined. The files are located in the guest machine: s-cid*.txt - For each offset calculation: host and guest clocks and calculated offset. res-cid*.txt - For each tracing session: all calculated clock offsets. tsync_hist.py plots a histogram, using data from a s-cid*.txt file: "python tsync_hist.py s-cid2_1.txt" tsync_res.py plots a line, using data from res-cid*.txt file: "python tsync_res.py res-cid2.txt" Signed-off-by: Tzvetomir Stoyanov (VMware) --- scripts/debug/tsync_hist.py | 57 +++++++++++++++++++++++++++++++++++++ scripts/debug/tsync_readme | 12 ++++++++ scripts/debug/tsync_res.py | 46 ++++++++++++++++++++++++++++++ 3 files changed, 115 insertions(+) create mode 100644 scripts/debug/tsync_hist.py create mode 100644 scripts/debug/tsync_readme create mode 100644 scripts/debug/tsync_res.py diff --git a/scripts/debug/tsync_hist.py b/scripts/debug/tsync_hist.py new file mode 100644 index 0000000..819d1e8 --- /dev/null +++ b/scripts/debug/tsync_hist.py @@ -0,0 +1,57 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Copyright (C) 2019, VMware Inc, Tzvetomir Stoyanov +# Copyright (C) 2019, VMware Inc, Yordan Karadzhov + + +import matplotlib.pyplot as plt +import matplotlib.lines as mlines +import numpy as np +import sys + +def newline(p1, p2): + ax = plt.gca() + xmin, xmax = ax.get_xbound() + + if(p2[0] == p1[0]): + xmin = xmax = p1[0] + ymin, ymax = ax.get_ybound() + else: + ymax = p1[1]+(p2[1]-p1[1])/(p2[0]-p1[0])*(xmax-p1[0]) + ymin = p1[1]+(p2[1]-p1[1])/(p2[0]-p1[0])*(xmin-p1[0]) + + l = mlines.Line2D([xmin,xmax], [ymin,ymax], color='red') + ax.add_line(l) + return l + + +data = np.loadtxt(fname = sys.argv[1]) +selected_ts = data[-1, 1] +selected_ofs = data[-1, 0] +data = data[:-1,:] + +x = data[:, 1] - data[:, 0] + +mean = x.mean() +std = x.std() + +num_bins = 500 +min = x.min() #+ .4 * (x.max() - x.min()) +max = x.max() #- .4 * (x.max() - x.min()) +bins = np.linspace(min, max, num_bins, endpoint = False, dtype=int) + +fig, ax = plt.subplots() + +# the histogram of the data +n, bins, patches = ax.hist(x, bins, histtype=u'step'); + +ax.set_xlabel('clock offset [$\mu$s]') +ax.set_ylabel('entries') +ax.set_title("$\sigma$=%i" % std) + +x1, y1 = [selected_ofs, min], [selected_ofs, max] +newline(x1, y1) + +# Tweak spacing to prevent clipping of ylabel +fig.tight_layout() +plt.show() diff --git a/scripts/debug/tsync_readme b/scripts/debug/tsync_readme new file mode 100644 index 0000000..f3ebb25 --- /dev/null +++ b/scripts/debug/tsync_readme @@ -0,0 +1,12 @@ +PTP-like algorithm debug +======================== + +tsync_*.py scripts can be used to visualise debug files, written when the PTP-like algorithm +is compiled with TSYNC_DEBUG defined. The files are located in the guest machine: + s-cid*.txt - For each offset calculation: host and guest clocks and calculated offset. + res-cid*.txt - For each tracing session: all calculated clock offsets. + +tsync_hist.py plots a histogram, using data from a s-cid*.txt file: + "python tsync_hist.py s-cid2_1.txt" +tsync_res.py plots a line, using data from res-cid*.txt file: + "python tsync_res.py res-cid2.txt" diff --git a/scripts/debug/tsync_res.py b/scripts/debug/tsync_res.py new file mode 100644 index 0000000..7d10986 --- /dev/null +++ b/scripts/debug/tsync_res.py @@ -0,0 +1,46 @@ +# SPDX-License-Identifier: GPL-2.0 +# +# Copyright (C) 2019, VMware Inc, Tzvetomir Stoyanov +# Copyright (C) 2019, VMware Inc, Yordan Karadzhov + + +import matplotlib.pyplot as plt +import matplotlib.lines as mlines +import numpy as np +import sys + +def newline(p1, p2): + ax = plt.gca() + xmin, xmax = ax.get_xbound() + + if(p2[0] == p1[0]): + xmin = xmax = p1[0] + ymin, ymax = ax.get_ybound() + else: + ymax = p1[1]+(p2[1]-p1[1])/(p2[0]-p1[0])*(xmax-p1[0]) + ymin = p1[1]+(p2[1]-p1[1])/(p2[0]-p1[0])*(xmin-p1[0]) + + l = mlines.Line2D([xmin,xmax], [ymin,ymax], color='red') + ax.add_line(l) + return l + +data = np.loadtxt(fname = sys.argv[1]) +x = data[:, 0] +y = data[:, 1] + +fig, ax = plt.subplots() + +ax.set_xlabel('samples (t)') +ax.set_ylabel('clock offset') +ax.set_title("$\delta$=%i ns" % (max(y) - min(y))) + +l = mlines.Line2D(x, y) +ax.add_line(l) +ax.set_xlim(min(x), max(x)) +ax.set_ylim(min(y), max(y) ) + +print(min(y), max(y), max(y) - min(y)) + +# Tweak spacing to prevent clipping of ylabel +fig.tight_layout() +plt.show()