From patchwork Fri Dec 6 21:38:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Oberholtzer X-Patchwork-Id: 11277045 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E8EA7930 for ; Fri, 6 Dec 2019 21:39:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C596F2173E for ; Fri, 6 Dec 2019 21:39:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=qrpff.net header.i=@qrpff.net header.b="CkrDYzZd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726553AbfLFVjQ (ORCPT ); Fri, 6 Dec 2019 16:39:16 -0500 Received: from egyptian.birch.relay.mailchannels.net ([23.83.209.56]:47051 "EHLO egyptian.birch.relay.mailchannels.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726552AbfLFVjQ (ORCPT ); Fri, 6 Dec 2019 16:39:16 -0500 X-Sender-Id: dreamhost|x-authsender|stevie@qrpff.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id CBA00218D2 for ; Fri, 6 Dec 2019 21:39:14 +0000 (UTC) Received: from pdx1-sub0-mail-a45.g.dreamhost.com (100-96-4-107.trex.outbound.svc.cluster.local [100.96.4.107]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 4A47C20A1F for ; Fri, 6 Dec 2019 21:39:14 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|stevie@qrpff.net Received: from pdx1-sub0-mail-a45.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.5); Fri, 06 Dec 2019 21:39:14 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|stevie@qrpff.net X-MailChannels-Auth-Id: dreamhost X-Average-Interest: 6f3d77d8233ac10f_1575668354513_794911050 X-MC-Loop-Signature: 1575668354513:3799710336 X-MC-Ingress-Time: 1575668354512 Received: from pdx1-sub0-mail-a45.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a45.g.dreamhost.com (Postfix) with ESMTP id 07A6A933AB for ; Fri, 6 Dec 2019 13:39:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=qrpff.net; h=mime-version :from:date:message-id:subject:to:content-type; s=qrpff.net; bh=D Rj83HgMYQ+ij2T8nRPYtFzpT9Q=; b=CkrDYzZd9IlVfWIG+QOxulClYdNVkmUnc ulJTMOjXfjHTdGpww6yF45uri8NwBm++XaL7zZmHCKySddYeC/7kb8iGeIoqG65L ku+HmjbqCVi95YOGzuDlQurynx9qDeje1sDTodFttWa1hPeMdz6cNyBPaYEtwiY1 Qu/iR8yQ6A= Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: stevie@qrpff.net) by pdx1-sub0-mail-a45.g.dreamhost.com (Postfix) with ESMTPSA id 9A4DB9322E for ; Fri, 6 Dec 2019 13:39:08 -0800 (PST) Received: by mail-lf1-f46.google.com with SMTP id f15so5514903lfl.13 for ; Fri, 06 Dec 2019 13:39:08 -0800 (PST) X-Gm-Message-State: APjAAAXb7xHhYXpQ9IS+vHVKSnsCCpzzWhCBLkaGeNiUqAsBdc7+ATs5 T8yyZ/qLxtpB6OiqY2VaodZGAkapoA871BS1Qg0= X-Google-Smtp-Source: APXvYqw1AGFQKfkSlkRC1QtAiK9lfLxZqMcKlpukSL/J1eJDHrnBJh1QQNmHOHz2AgQc5OoK7aZCsNQiil6OibULHXc= X-Received: by 2002:ac2:5a43:: with SMTP id r3mr9579314lfn.150.1575668346651; Fri, 06 Dec 2019 13:39:06 -0800 (PST) MIME-Version: 1.0 X-DH-BACKEND: pdx1-sub0-mail-a45 From: Stephen Oberholtzer Date: Fri, 6 Dec 2019 16:38:55 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: [PATCH] Use explicit '%s' when formatting a signal name To: dash@vger.kernel.org Sender: dash-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dash@vger.kernel.org Dash fails to build from source on recent Debian setups, due to a non-constant string being used as a format string, which trips over -Werror=format-security. --- src/jobs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1 -- Stephen Oberholtzer diff --git a/src/jobs.c b/src/jobs.c index 606d603..9728579 100644 --- a/src/jobs.c +++ b/src/jobs.c @@ -428,7 +428,7 @@ sprint_status(char *s, int status, int sigonly) goto out; #endif } - col = fmtstr(s, 32, strsignal(st)); + col = fmtstr(s, 32, "%s", strsignal(st)); #ifdef WCOREDUMP if (WCOREDUMP(status)) { col += fmtstr(s + col, 16, " (core dumped)");