From patchwork Wed Dec 11 00:35:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11283653 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C44BF112B for ; Wed, 11 Dec 2019 00:36:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A15462073D for ; Wed, 11 Dec 2019 00:36:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mMm9OjJq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725999AbfLKAga (ORCPT ); Tue, 10 Dec 2019 19:36:30 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:42712 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726598AbfLKAg3 (ORCPT ); Tue, 10 Dec 2019 19:36:29 -0500 Received: by mail-pj1-f68.google.com with SMTP id o11so8163225pjp.9 for ; Tue, 10 Dec 2019 16:36:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FP/zf8K1mqQfn8K0ftqgHZHJkSfo2eQNHAUrAnf9xJs=; b=mMm9OjJqHaCdZ8bw5nQR5ALK6Vvq1vvnOx/1JoAZq+nyus+8xOU3LLEqdKoJlDDBpT k0ouqFNdxes2yTJ5conUr5xMaJ0GVpw6NQYsh+ghC21UfebkirgvIMkF+nPRVUkAwzl6 o2++Q32flzjDaXapq5Iqowm5PmrJBJYiWOoC0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FP/zf8K1mqQfn8K0ftqgHZHJkSfo2eQNHAUrAnf9xJs=; b=aj6Ns9xTb3uIR+z1dBy5IjkgeJdlYskxYAtRc7vbXpESx/T/ruU12o4vDkkLFuxvF3 G2Y7vaGk6um1m2f+7bWIXD2+BYbvx2pMZgLOwi8Hq175oQh9VqSbT5ZE9opOJ4kRogIg m/IJdKtAwKj7qa/GkB0Y/B3seNpXLz4KsFcpTNOcOARR3TYqFkQsLWZ/0jhU6S/8j38x gsj2ezkHLHd8+c3WL+l4zpypMGKRrsVJLO0vN6mb+PKn/e/VI6lsiJVTs9MiGdRtW8lH UzBNftHh2gtLN/GwzZXGPyw5882lOfJ2gTexiLaSwnv7mDhk+jKxLWff80ER2XIBDP4z o8jQ== X-Gm-Message-State: APjAAAU3Pda8qcmJctL6vEdk7/xT1wFXIgB9JXafXwl1UZZxORgy2Ho3 zjh9txGB+yLvG3yn0FYPTXaDNA== X-Google-Smtp-Source: APXvYqyyMYn3eEkOXOSpuNWtCY++KZHNmwUrop6lejJN8jyCdg0iqPJPyizJpEsGK/R5di1B2iynhg== X-Received: by 2002:a17:902:7c88:: with SMTP id y8mr299401pll.104.1576024589168; Tue, 10 Dec 2019 16:36:29 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id d38sm159954pgd.59.2019.12.10.16.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 16:36:28 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Andy Gross Cc: mka@chromium.org, Roja Rani Yarubandi , Rajendra Nayak , Stephen Boyd , Douglas Anderson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Mark Rutland Subject: [PATCH 1/2] arm64: dts: sc7180: Fix indentation/ordering of qspi nodes in sc7180-idp Date: Tue, 10 Dec 2019 16:35:39 -0800 Message-Id: <20191210163530.1.I69a6c29e08924229d160b651769c84508a07b3c6@changeid> X-Mailer: git-send-email 2.24.0.525.g8f36a354ae-goog MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The qspi pinctrl nodes had the wrong intentation and sort ordering and the main qspi node was placed down in the pinctrl section. Fix. Fixes: ba3fc6496366 ("arm64: dts: sc7180: Add qupv3_0 and qupv3_1") Signed-off-by: Douglas Anderson Reviewed-by: Rajendra Nayak --- arch/arm64/boot/dts/qcom/sc7180-idp.dts | 73 +++++++++++++------------ 1 file changed, 37 insertions(+), 36 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts index 189254f5ae95..5eab3a282eba 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts @@ -232,6 +232,20 @@ vreg_bob: bob { }; }; +&qspi { + status = "okay"; + pinctrl-names = "default"; + pinctrl-0 = <&qspi_clk &qspi_cs0 &qspi_data01>; + + flash@0 { + compatible = "jedec,spi-nor"; + reg = <0>; + spi-max-frequency = <25000000>; + spi-tx-bus-width = <2>; + spi-rx-bus-width = <2>; + }; +}; + &qupv3_id_0 { status = "okay"; }; @@ -250,6 +264,29 @@ &uart8 { /* PINCTRL - additions to nodes defined in sc7180.dtsi */ +&qspi_clk { + pinconf { + pins = "gpio63"; + bias-disable; + }; +}; + +&qspi_cs0 { + pinconf { + pins = "gpio68"; + bias-disable; + }; +}; + +&qspi_data01 { + pinconf { + pins = "gpio64", "gpio65"; + + /* High-Z when no transfers; nice to park the lines */ + bias-pull-up; + }; +}; + &qup_i2c2_default { pinconf { pins = "gpio15", "gpio16"; @@ -364,39 +401,3 @@ pinconf { }; }; -&qspi { - status = "okay"; - pinctrl-names = "default"; - pinctrl-0 = <&qspi_clk &qspi_cs0 &qspi_data01>; - - flash@0 { - compatible = "jedec,spi-nor"; - reg = <0>; - spi-max-frequency = <25000000>; - spi-tx-bus-width = <2>; - spi-rx-bus-width = <2>; - }; -}; - -&qspi_cs0 { - pinconf { - pins = "gpio68"; - bias-disable; - }; -}; - -&qspi_clk { - pinconf { - pins = "gpio63"; - bias-disable; - }; -}; - -&qspi_data01 { - pinconf { - pins = "gpio64", "gpio65"; - - /* High-Z when no transfers; nice to park the lines */ - bias-pull-up; - }; -}; From patchwork Wed Dec 11 00:35:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11283655 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ED130112B for ; Wed, 11 Dec 2019 00:36:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAAA32073D for ; Wed, 11 Dec 2019 00:36:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dDPPKNbr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727145AbfLKAge (ORCPT ); Tue, 10 Dec 2019 19:36:34 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:45132 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726718AbfLKAgb (ORCPT ); Tue, 10 Dec 2019 19:36:31 -0500 Received: by mail-pf1-f196.google.com with SMTP id 2so821581pfg.12 for ; Tue, 10 Dec 2019 16:36:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YgLOEq+b3z3/DTsjuxwC7KLaORE8dq4xMxztFesSO1E=; b=dDPPKNbrgbLGmMbRNeNgFCRoeauYBwrY00fbTjRfRSmxMpI2OpLj9AtyX7y2oPRgR6 d4I5SVqsBlXmaqb1+77ddPC5CfFwyJMR96XAaSBkO1Vrqw1lgldlKHJA2puQAKdgKKiM NU/GaCpRjAa/67cieZTL6Nn4UliUEpYmfjKF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YgLOEq+b3z3/DTsjuxwC7KLaORE8dq4xMxztFesSO1E=; b=Khm3Q94Z7+Vm2pPILMSNDgsUrUYbVQQ0od7msm332r/mDXc0QtLMDZjovpd3J1EMtQ 8q5EBZ1kmc0egXq0mUbmAmKIvNb/s5jWmi3rpU0dOZPnjhI7RuqVO7hJRCryZi3oiZrA 5pBvIfbWJzyC+0jGjmM3QGMyjPfuasGdylN0hBee25QSDh83f62HODdez1i867icN/v4 R1JdJ3No907ph9qU0mmanZETkjsJDdwnzvVs7sZZPL7XpTDs8g1a5/FtNykWGNLJ7rQm v3yC6O9iIb4WYkp8PlQ+rkRxkK9MA4Z9DXkV6HnuPM/gCRcp6j7g5B2uQtXZBBQbSJy6 LyfA== X-Gm-Message-State: APjAAAVmz7jSbZFgudVshjaeQ4R929PzRDh5r/RzY7VQqYE+j7CYob+q kI+TSoYLpbHhg/OrZbvPMY+vKg== X-Google-Smtp-Source: APXvYqzDHrJPYBFC/4ZRlo6kMRGcctk9Da8+L6mFYu9ZNYUFhmEDZGFglvH1i+JoExCrNLitCmIaUA== X-Received: by 2002:aa7:9145:: with SMTP id 5mr779281pfi.74.1576024590404; Tue, 10 Dec 2019 16:36:30 -0800 (PST) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id d38sm159954pgd.59.2019.12.10.16.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 16:36:29 -0800 (PST) From: Douglas Anderson To: Bjorn Andersson , Andy Gross Cc: mka@chromium.org, Roja Rani Yarubandi , Rajendra Nayak , Stephen Boyd , Douglas Anderson , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Mark Rutland Subject: [PATCH 2/2] arm64: dts: sc7180: Add a comment to i2c7 about external pullup Date: Tue, 10 Dec 2019 16:35:40 -0800 Message-Id: <20191210163530.2.I8d4cbb3d7ac5824f8e950c53038df8c27a512905@changeid> X-Mailer: git-send-email 2.24.0.525.g8f36a354ae-goog In-Reply-To: <20191210163530.1.I69a6c29e08924229d160b651769c84508a07b3c6@changeid> References: <20191210163530.1.I69a6c29e08924229d160b651769c84508a07b3c6@changeid> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Make i2c7 symmetric with the other i2c busses and comment that we have no internal pull because there is an external one. Fixes: ba3fc6496366 ("arm64: dts: sc7180: Add qupv3_0 and qupv3_1") Signed-off-by: Douglas Anderson Reviewed-by: Rajendra Nayak --- arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts index 5eab3a282eba..05d30a56eca9 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts @@ -311,6 +311,8 @@ &qup_i2c7_default { pinconf { pins = "gpio6", "gpio7"; drive-strength = <2>; + + /* Has external pullup */ bias-disable; }; };