From patchwork Wed Dec 11 09:42:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janusz Krzysztofik X-Patchwork-Id: 11284645 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 87A8C138D for ; Wed, 11 Dec 2019 09:56:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70016214D8 for ; Wed, 11 Dec 2019 09:56:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70016214D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC4106EAEF; Wed, 11 Dec 2019 09:56:30 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org X-Greylist: delayed 427 seconds by postgrey-1.36 at gabe; Wed, 11 Dec 2019 09:56:29 UTC Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 842CF6EAEE; Wed, 11 Dec 2019 09:56:29 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 01:49:21 -0800 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="363544981" Received: from jkrzyszt-desk.igk.intel.com ([172.22.244.17]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 01:49:20 -0800 From: Janusz Krzysztofik To: igt-dev@lists.freedesktop.org Date: Wed, 11 Dec 2019 10:42:43 +0100 Message-Id: <20191211094243.6939-1-janusz.krzysztofik@linux.intel.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH i-g-t] tests/prime_vgem: Give meaningful messages on SKIP X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Messages displayed on SKIPs introduced by commit 92caadb4e551 ("tests/prime_vgem: Skip basic-read/write subtests if not supported") don't inform clearly enough that those SKIPs are expected behavior. Fix it. Signed-off-by: Janusz Krzysztofik Cc: Ewelina Musial Reviewed-by: Ewelina Musial --- tests/prime_vgem.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/prime_vgem.c b/tests/prime_vgem.c index 6595818c..3bdb2300 100644 --- a/tests/prime_vgem.c +++ b/tests/prime_vgem.c @@ -46,7 +46,8 @@ static void test_read(int vgem, int i915) handle = prime_fd_to_handle(i915, dmabuf); close(dmabuf); - igt_skip_on(__gem_read(i915, handle, 0, &i, sizeof(i))); + igt_skip_on_f(__gem_read(i915, handle, 0, &i, sizeof(i)), + "PREAD from dma-buf not supported on this hardware\n"); ptr = vgem_mmap(vgem, &scratch, PROT_WRITE); for (i = 0; i < 1024; i++) @@ -83,7 +84,8 @@ static void test_fence_read(int i915, int vgem) handle = prime_fd_to_handle(i915, dmabuf); close(dmabuf); - igt_skip_on(__gem_read(i915, handle, 0, &i, sizeof(i))); + igt_skip_on_f(__gem_read(i915, handle, 0, &i, sizeof(i)), + "PREAD from dma-buf not supported on this hardware\n"); igt_fork(child, 1) { close(master[0]); @@ -195,7 +197,8 @@ static void test_write(int vgem, int i915) handle = prime_fd_to_handle(i915, dmabuf); close(dmabuf); - igt_skip_on(__gem_write(i915, handle, 0, &i, sizeof(i))); + igt_skip_on_f(__gem_write(i915, handle, 0, &i, sizeof(i)), + "PWRITE to dma-buf not supported on this hardware\n"); ptr = vgem_mmap(vgem, &scratch, PROT_READ); gem_close(vgem, scratch.handle);