From patchwork Fri Dec 13 09:54:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 11290361 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 214DC6C1 for ; Fri, 13 Dec 2019 09:55:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2B3E2073D for ; Fri, 13 Dec 2019 09:55:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Mjz9bgaS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="Jantg6rY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2B3E2073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=pHCEPlKRShmdt8KOiO7q5VteX+eiDpVDBrPioq3qnZQ=; b=Mjz9bgaSvGsjyf OkvGNFpvYTWp7fLk/11tQccxBK0J4et0/PGWTZtkq+bHyovLgxC7bMaDzTMteRXARMwLGrW7Z2EYi bt80NtFEplmrMRiInazknnF0GE3g4xC3b0+l+aBewOwKb/q7a2ILPXN2msYIMCU+Bl5VD26rqfhZp E+VK6WKavKxc391vVbV2v58kT3Q81SnqoAvc+0em5GoWmP37zWNctowGxBfdUQ5aINfJKETYPUgmt 6c754jn0FW1eAvl4WGa3bibQdPdd6hvFoemwIE6ZynuFW8/J9FAClugPCdq6yP2OWEbkX28HUgUCQ 4PW2UwAlhgx96kaEy4Kg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifhfX-0002Bc-RT; Fri, 13 Dec 2019 09:55:31 +0000 Received: from esa6.microchip.iphmx.com ([216.71.154.253]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifhev-0000ZD-W0 for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2019 09:54:55 +0000 Received-SPF: Pass (esa6.microchip.iphmx.com: domain of Tudor.Ambarus@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="Tudor.Ambarus@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com -exists:%{i}.spf.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa6.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa6.microchip.iphmx.com; spf=Pass smtp.mailfrom=Tudor.Ambarus@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: bViNsiJ3DQeCiZKKvkIIL7zaEXM1OPf9+i3sBHEvmI1PS5OGz8z84mj5fFTRhd7p2MKsy2JNR/ IYbXysvdM0ukbkEfYKazkRCuW1Lk4VEWwRNYUeWiVunmKb4oZNsaqyDPtFRo7Nr3KvxmiXtJAa ddBl79MmvOgxOh+QiQSGioaR/6jIU8hjSmU2JRmICUJkSSA5uDKh/sltMZ+Frlca+HYqpJvBAr VMlDuGJLyiL+otSN48wJ4FD1BbScZA2q6LpAnOE4JIuBXi29r2TPbdgLBm17CgwFNmqep2MW63 YkE= X-IronPort-AV: E=Sophos;i="5.69,309,1571727600"; d="scan'208";a="57649458" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Dec 2019 02:54:50 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 13 Dec 2019 02:54:44 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 13 Dec 2019 02:54:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bSd01B7JW5zphuj6BMXYLZKz1vF7HF9TxfVvuJlIXutoSnlwPa29e7t/cHBV5gLn09vdnmOcBNU8Zo+hhZGKLRl/hR5Xk5PCQPtv87SNQnWNMFZprt6KjazyL8/pX2hUHpTpJ/byFDFyZmbEYqcEYDbb5pRMOpvC/aC82GF8PtGzD2Bk1u6WfkX9LetWxp28kDjLhnLD/pFhnvUe8bX4/k2mw31XkXgr9iXx4sHu1YmPM78hC25EJYPbrszbKAIKGg1UPO2LC7jE3jTw/IJW5sciGympRyMqLpvWB7bhKjDcY37K9gdEauQyfZwwadO8My3jnZ9YF+KWtVFPCNQitg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oSU3hhunHsne2rZGzBHQ2zhp1GWPr0QuAbAo0sEba3A=; b=FLQVsvJ1tA7ldAYGkLruQY7/YLb668sIMerh9tysGN9GIPxNtmLdWvWNUC7Be8J4aqKjHk6i2dWL7UA4oQFilPhRI05rijxYlIgFZ0pJ/RqXk9o70Bxw/g3r6ccUOpmcc0BeTp783Nb1wBMO71/00MHchL91oXroAYPvWy0719E+3S4s/ttvwAmk0XB/y2AkJsAZ1aJAhgRRVX/eF7PMIvHSI4TsBpRmqJOXfGPG40fLEieYqpi4E6b6GKJiyYiDNfL1ZAbGw2BOISjRzqeANNyAZ450q4aHnX65XSuwmsE4teTdX/kIMOzFmWEFxYTAu5GYa+cLqOH0vAjCuCiRjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oSU3hhunHsne2rZGzBHQ2zhp1GWPr0QuAbAo0sEba3A=; b=Jantg6rY17u6Jj8RAE96B2sSlwK+5o7FVhYRf0T3UCS0R/rlmenEvTpO5u8WIAWaYz0Tquyd/yYd+DfO4FbmpLoc2gEI7BU9Q709tlX/rP4MoasAh8qfsV+reXAHKrhhrRQ7pSo2gpYxSu64O3iXkLMReEC7YIhA+nUZVeWDJOo= Received: from MN2PR11MB4448.namprd11.prod.outlook.com (52.135.39.157) by MN2PR11MB4029.namprd11.prod.outlook.com (10.255.181.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.17; Fri, 13 Dec 2019 09:54:42 +0000 Received: from MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::84c:6e75:22df:cbc9]) by MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::84c:6e75:22df:cbc9%5]) with mapi id 15.20.2538.017; Fri, 13 Dec 2019 09:54:42 +0000 From: To: Subject: [PATCH 1/5] crypto: atmel-{aes,sha} - Fix incorrect use of dmaengine_terminate_all() Thread-Topic: [PATCH 1/5] crypto: atmel-{aes,sha} - Fix incorrect use of dmaengine_terminate_all() Thread-Index: AQHVsZtXl3FLQBYVpUWR9FcsoWA+VA== Date: Fri, 13 Dec 2019 09:54:42 +0000 Message-ID: <20191213095423.6687-1-tudor.ambarus@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR0501CA0046.eurprd05.prod.outlook.com (2603:10a6:800:60::32) To MN2PR11MB4448.namprd11.prod.outlook.com (2603:10b6:208:193::29) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [86.122.210.80] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 85fe602a-fc97-464e-cfff-08d77fb279e3 x-ms-traffictypediagnostic: MN2PR11MB4029: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0250B840C1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(396003)(366004)(136003)(189003)(199004)(2616005)(2906002)(186003)(71200400001)(6916009)(6512007)(86362001)(6486002)(478600001)(52116002)(26005)(66556008)(5660300002)(1076003)(36756003)(81156014)(64756008)(107886003)(81166006)(54906003)(8676002)(316002)(6506007)(66946007)(66476007)(4326008)(8936002)(66446008)(142933001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB4029; H:MN2PR11MB4448.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 15Q4QUEuYyLGKjdS3uo/5ciFvwFZIbg82OfZRSSgz4VukqrQSdp5XIh17O2bKW6PptkTf1AGkVgX5cirlQg1drEZQCttQF/0zbI263zO1le274WQFVyqH4xUhuYtQG3Jefu9DFD1dTHmf93hNPQBk8TKxnfF4LWzJtFFTFbp5dX61UoWunVNiY0Fu+aUnXyG5fA12WyECKPZnkuzQ2c7aqW0qK9rPjS+fb0JXjfm18+Bh0kTH3I1edr/yBsz/IpUVofmgWgpDEb95jPS8XiQfUDffryxgzrHjBjqw6d5xmCpULvjdCXj/vH6zJDwMg2VwgvVvt66A3DC8ZHobYqXq/U3JsoNNKNNmcrJK/l/0jP04/HfnZ36U+/EG9YRDPCMlQuj74NEHdETAY41Nz9tn01Rj0gADsCSx8FYhA5/ZNK7djznBsnt2wa5xLRf1ks8w3MgZXFFlgfGhr5RTXZ+7tWLUmE5CWBsTNPKH2AztK45grCjHfxz6vTFyXDxrWOF MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 85fe602a-fc97-464e-cfff-08d77fb279e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2019 09:54:42.4442 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4lE4oAYFGEeu1r1pHuPHIzDAXcxeAo3X9W1m/qMqANc8Jvl+RYiE5AhqyArakGJFCTgKAWMELaOtCXMmzyLu2k5hrUgpIlULl3k0nHAgVVo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4029 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_015454_066213_A0C9BB78 X-CRM114-Status: GOOD ( 10.82 ) X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [216.71.154.253 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, Tudor.Ambarus@microchip.com, Ludovic.Desroches@microchip.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Tudor Ambarus device_terminate_all() is used to abort all the pending and ongoing transfers on the channel, it should be used just in the error path. Also, dmaengine_terminate_all() is deprecated and one should use dmaengine_terminate_async() or dmaengine_terminate_sync(). The method is not used in atomic context, use dmaengine_terminate_sync(). A secondary aspect of this patch is that it luckily avoids a deadlock between atmel_aes and at_hdmac.c. While in tasklet with the lock held, the dma controller invokes the client callback (dmaengine_terminate_all), which tries to get the same lock. The at_hdmac fix would be to drop the lock before invoking the client callback, a fix on at_hdmac will follow. Signed-off-by: Tudor Ambarus --- drivers/crypto/atmel-aes.c | 32 ++------------------------------ drivers/crypto/atmel-sha.c | 1 - 2 files changed, 2 insertions(+), 31 deletions(-) diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index 47b20df3adfc..c3f0e99d24b0 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c @@ -857,27 +857,6 @@ static int atmel_aes_dma_transfer_start(struct atmel_aes_dev *dd, return 0; } -static void atmel_aes_dma_transfer_stop(struct atmel_aes_dev *dd, - enum dma_transfer_direction dir) -{ - struct atmel_aes_dma *dma; - - switch (dir) { - case DMA_MEM_TO_DEV: - dma = &dd->src; - break; - - case DMA_DEV_TO_MEM: - dma = &dd->dst; - break; - - default: - return; - } - - dmaengine_terminate_all(dma->chan); -} - static int atmel_aes_dma_start(struct atmel_aes_dev *dd, struct scatterlist *src, struct scatterlist *dst, @@ -936,25 +915,18 @@ static int atmel_aes_dma_start(struct atmel_aes_dev *dd, return -EINPROGRESS; output_transfer_stop: - atmel_aes_dma_transfer_stop(dd, DMA_DEV_TO_MEM); + dmaengine_terminate_sync(dd->dst.chan); unmap: atmel_aes_unmap(dd); exit: return atmel_aes_complete(dd, err); } -static void atmel_aes_dma_stop(struct atmel_aes_dev *dd) -{ - atmel_aes_dma_transfer_stop(dd, DMA_MEM_TO_DEV); - atmel_aes_dma_transfer_stop(dd, DMA_DEV_TO_MEM); - atmel_aes_unmap(dd); -} - static void atmel_aes_dma_callback(void *data) { struct atmel_aes_dev *dd = data; - atmel_aes_dma_stop(dd); + atmel_aes_unmap(dd); dd->is_async = true; (void)dd->resume(dd); } diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c index ebf500153700..7cf4ec9ed93a 100644 --- a/drivers/crypto/atmel-sha.c +++ b/drivers/crypto/atmel-sha.c @@ -1429,7 +1429,6 @@ static void atmel_sha_dma_callback2(void *data) struct scatterlist *sg; int nents; - dmaengine_terminate_all(dma->chan); dma_unmap_sg(dd->dev, dma->sg, dma->nents, DMA_TO_DEVICE); sg = dma->sg; From patchwork Fri Dec 13 09:54:46 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 11290353 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B275A6C1 for ; Fri, 13 Dec 2019 09:54:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F6882073D for ; Fri, 13 Dec 2019 09:54:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pM2e8u/W"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="utfwM0TM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F6882073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mWDYe2ZMZqgLzvGxp5pM0LgL5WnxbANxXC6fTuCv3zQ=; b=pM2e8u/WhMy04r K+sl9NDPJjMmGApVWXrNrKg1TvuXBmmleMprlqUG+Tj6K+wqchXxOryCy5C7brxUS6nWxemGfLrj4 FUpf2NA0PPKzJ1LzQJaPs9QImvCIIU+tcyIvwClU4t0a+M8+i8e28QNiRsqhE7eIWl9DidUhpLX5Y 1wKJlyE+UwlUJrSa/NyKaWuHYbDVFHWdNNoX2cbufKIoW3CJGDZ2E6WLS8ttwHC9JzN/vv5+mY+FD QaHefNAXkUB36jkA3QCf5jJlGEy77F9D/qGdVdKrdc3X0GtckOTWAclMruDuMtV0FBGYtRmR1Jv6B y7GorMVhlI0fNMdOQRmg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifhey-0000a7-2K; Fri, 13 Dec 2019 09:54:56 +0000 Received: from esa6.microchip.iphmx.com ([216.71.154.253]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifheu-0000Yh-AO for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2019 09:54:53 +0000 Received-SPF: Pass (esa6.microchip.iphmx.com: domain of Tudor.Ambarus@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="Tudor.Ambarus@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com -exists:%{i}.spf.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa6.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa6.microchip.iphmx.com; spf=Pass smtp.mailfrom=Tudor.Ambarus@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: Wxc1BHQu0Ft7Vbod7NyRM3QAGynH88OulwHc/OzbHDOVOzyfLInMj0V4jzA+xeylAXnO8qRjkn sdL+6zAd5BFufsSPWemqcze6326oMlaIwxgtuK1DQAOBrI0BWb+B41du4qml1Afsjql+5RAhfR 7TmFMy8NsIS2YW7LENGGVvdZJjSwWfQXcuecNq1pl2ScF3HDOZFEiutPG1bky01bdw9akqdeuK rROm26FaBbKV8e5w2i9FaNsk+Gzy4wpB6miTI9Y4NlsdTgEkrQlL72/ThZdG1q/0LkvsBee+rz 0hQ= X-IronPort-AV: E=Sophos;i="5.69,309,1571727600"; d="scan'208";a="57649452" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Dec 2019 02:54:49 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 13 Dec 2019 02:54:49 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 13 Dec 2019 02:54:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JAZv96/oVjhy0TywBkSEm7i4soEA9IiAMBMMYiRiTKRbpvEEa5A01H2IZyV+kkL8lU+rlp7I2QyNoalu82yXJBDO3bqdv4S9f9YHPYLWp42hXZaXmzeye8ApvVwH4EKrLj79A2XKHrgl4Zz4U5MggkLvg43EDiOq6cjd//v5fh/Wif852kYEiozCfxWJzJdxq9DVb7S5RAcrnK4gbSCeVzVnZjU67mFf6W7S7Loxs75PcWWV/T43jPrOxViRv9iOeSYhucpBET9LmVF/mLqW0JPh2joszzJEIi9c/dnnLMaOhcHGCz0d+iLiBgxHvYnUMEj/9YRJlDBgOCUw3ILJEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4NeDqx7LrQMA08AVT50hCJsEFCoejkUetk+9QxD5C1U=; b=ErJ6of+E7zlpc4KITDHQVgmjRfiVCXhFFKp2qDggf7DK9ULvr64PtKaLbHdyODaerETTrAmcA9GJdTxMqUAASsbMtTuDCk55KsAj4r+DNOMEx3+J9KIhwcwBpreCrwdRd7DMXqJmHncag9YjCgnqeHKtBalvc1ECCGQsLnOzqJp2bRZHAg5drl+ORTWiR5zaF7V3UtaKZyPsXYt9JfVCC6RaFYtcH25SVQMMCjjVkvlgc3F3N3ofeGlSeKOQLZW0dt5BYX7fjmjEdBP5WDJAJUIU8xv3U21lyID/LgA733MHlRqZSYPh3FsLTq9XK+7zOY4hxj7hta0k0onhM+BkSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4NeDqx7LrQMA08AVT50hCJsEFCoejkUetk+9QxD5C1U=; b=utfwM0TM+MhWbJkhV6BrO5ZbUYdDZ8OWapruG9NpAbY6FWuAYSrlR8KLDgCFhkF/SQg1jObeJei8XUnnFolaQ+panmIetUNsfd6lGtkXmYcfySZXYWlZUzwopvUcN+lBR1E5c0zW8lbk9MJNIzyYZjkpwVv5Zmp/MiRNeaiRA5s= Received: from MN2PR11MB4448.namprd11.prod.outlook.com (52.135.39.157) by MN2PR11MB3935.namprd11.prod.outlook.com (10.255.180.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.17; Fri, 13 Dec 2019 09:54:47 +0000 Received: from MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::84c:6e75:22df:cbc9]) by MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::84c:6e75:22df:cbc9%5]) with mapi id 15.20.2538.017; Fri, 13 Dec 2019 09:54:47 +0000 From: To: Subject: [PATCH 2/5] crypto: atmel-{aes,sha,tdes} - Drop duplicate init of dma_slave_config.direction Thread-Topic: [PATCH 2/5] crypto: atmel-{aes,sha,tdes} - Drop duplicate init of dma_slave_config.direction Thread-Index: AQHVsZta6SvbcgatykCqmhrO1amI4Q== Date: Fri, 13 Dec 2019 09:54:46 +0000 Message-ID: <20191213095423.6687-2-tudor.ambarus@microchip.com> References: <20191213095423.6687-1-tudor.ambarus@microchip.com> In-Reply-To: <20191213095423.6687-1-tudor.ambarus@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR0501CA0046.eurprd05.prod.outlook.com (2603:10a6:800:60::32) To MN2PR11MB4448.namprd11.prod.outlook.com (2603:10b6:208:193::29) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [86.122.210.80] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 489a8edc-f158-4a83-9cba-08d77fb27ca3 x-ms-traffictypediagnostic: MN2PR11MB3935: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0250B840C1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(396003)(366004)(136003)(199004)(189003)(2616005)(2906002)(6486002)(6916009)(71200400001)(6512007)(86362001)(186003)(26005)(478600001)(52116002)(64756008)(66446008)(81156014)(1076003)(5660300002)(81166006)(54906003)(107886003)(8936002)(36756003)(316002)(66556008)(66476007)(66946007)(6506007)(4326008)(8676002)(142933001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3935; H:MN2PR11MB4448.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: av3zv3dJ38E3DTZRebKgenpfp6Y+gyGx1mDOnpUDLblKsAf4ATwF8xQieqbQDciNjho22Q7SD2ZpR6gkCJVodvKBdCCLs0tR8IIsLHxEJKAQxYOYJtlehWZ1rj85+GJqyeMeqCuT+ijYYUX4pMq6Tu6JYBBccdjYTDd6E5GqyH41jBy/ajue+5dpq8C0uRq93A8t1PGB7+vg5PSsuHYUYFqRcH9ZbVnZCmCMGTeFLEZwbtLzjNTtwZeIO41aCLdFO7mg/LECGAO5vl70S6VepQ+a/TevSS88LFtfYpKoapZc0NExXuuZt81qC10DNMbBm4+QBFibUg7nOwm/jsvFdgFUKcZebCo6fSCrgjHdbhkcOPwRjI165t/9bDaTjCHfkpTJ2XKDol6+o0Hc3OoGUjFmi+umNZnN1D+7/IKujfvHrAeZHeynqgqMIIWmyc9fTUacT6RGZi1rqBJ6dQQldrLP1hu2aWrxuGjhDhCyUnTq2IyeX+JhYvRhItW8/Pc9 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 489a8edc-f158-4a83-9cba-08d77fb27ca3 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2019 09:54:46.9947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: emSCxbgYZo2dhNWivkyxxsLvezPZE7X60Q4r6I64A+FY11s9B62KLOSnivfTw8uer1E7WPn+l8BDGNgk7tZc2G6dmLECT+trrQMihiee8BQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3935 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_015452_396629_C7C1425B X-CRM114-Status: UNSURE ( 8.02 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [216.71.154.253 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, Tudor.Ambarus@microchip.com, Ludovic.Desroches@microchip.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Tudor Ambarus The 'direction' member of the dma_slave_config will be going away as it duplicates the direction given in the prepare call. Signed-off-by: Tudor Ambarus --- drivers/crypto/atmel-aes.c | 1 - drivers/crypto/atmel-sha.c | 1 - drivers/crypto/atmel-tdes.c | 2 -- 3 files changed, 4 deletions(-) diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index c3f0e99d24b0..d5a116693010 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c @@ -817,7 +817,6 @@ static int atmel_aes_dma_transfer_start(struct atmel_aes_dev *dd, int err; memset(&config, 0, sizeof(config)); - config.direction = dir; config.src_addr_width = addr_width; config.dst_addr_width = addr_width; config.src_maxburst = maxburst; diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c index 7cf4ec9ed93a..21fcc04f6688 100644 --- a/drivers/crypto/atmel-sha.c +++ b/drivers/crypto/atmel-sha.c @@ -2493,7 +2493,6 @@ static int atmel_sha_dma_init(struct atmel_sha_dev *dd, return ret; } - dd->dma_lch_in.dma_conf.direction = DMA_MEM_TO_DEV; dd->dma_lch_in.dma_conf.dst_addr = dd->phys_base + SHA_REG_DIN(0); dd->dma_lch_in.dma_conf.src_maxburst = 1; diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c index 12268b549596..51b332527efd 100644 --- a/drivers/crypto/atmel-tdes.c +++ b/drivers/crypto/atmel-tdes.c @@ -753,7 +753,6 @@ static int atmel_tdes_dma_init(struct atmel_tdes_dev *dd, goto err_dma_in; } - dd->dma_lch_in.dma_conf.direction = DMA_MEM_TO_DEV; dd->dma_lch_in.dma_conf.dst_addr = dd->phys_base + TDES_IDATA1R; dd->dma_lch_in.dma_conf.src_maxburst = 1; @@ -770,7 +769,6 @@ static int atmel_tdes_dma_init(struct atmel_tdes_dev *dd, goto err_dma_out; } - dd->dma_lch_out.dma_conf.direction = DMA_DEV_TO_MEM; dd->dma_lch_out.dma_conf.src_addr = dd->phys_base + TDES_ODATA1R; dd->dma_lch_out.dma_conf.src_maxburst = 1; From patchwork Fri Dec 13 09:54:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 11290359 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 68936138D for ; Fri, 13 Dec 2019 09:55:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 430A324658 for ; Fri, 13 Dec 2019 09:55:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uDLG75QR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="oqf8w3iq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 430A324658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gzPBTggRbag9aNHS6z412N3KdqfDVeeaE75DL/TXIaA=; b=uDLG75QRsv7qm9 BBN6wKzDG1o82MgvaOtGe/SxIU9LPMvpaGNV4Xx+7f1pfVOs+XySpJev4v4Z4t2qPr9sdgZId2RrK zJXR9nH7cs5yjovz6tZWAMxe+Is1/Xv0lYfsLb64iP+u9QFIXf1vKNlrq4Y7ZCDSlmvPq6qztc3rV fDUA1+MzmrsLudx1YODAX3DJM37Wr3Sj06XJhztl98Kitf2ubi9oyAd7UaTtPlslEOfZiniCGvlka e4JWk2MLBZbf7goOlwkuK9kVaXUWSo59qKvGwXxvlXx7PRBc6FaFtkpvJAfyGCoz3FzVvUlzL5ZU8 aZsD3YWr7OAmcf+Znz0g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifhfI-0001yh-SO; Fri, 13 Dec 2019 09:55:16 +0000 Received: from esa6.microchip.iphmx.com ([216.71.154.253]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifhev-0000Yh-Pb for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2019 09:54:55 +0000 Received-SPF: Pass (esa6.microchip.iphmx.com: domain of Tudor.Ambarus@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="Tudor.Ambarus@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com -exists:%{i}.spf.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa6.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa6.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa6.microchip.iphmx.com; spf=Pass smtp.mailfrom=Tudor.Ambarus@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: CQXblHFAnDE/4gj70aa2Fm05rncKwNJjzaRIKBsAWhM35Mxq3DvxA+uarksJQjwACy7micLudS AL53+knQHUoMyAzMP1vR63EnZ88eS4czLJwpXhvurCz/3UcOR2Yfilqma4et8HzQ4Dc0ZE2XpU RhZecbNSQL3aeRflXTkR81FTtu2ZNgu0cDyEt/qLH/mLKFnOlDsV2EHXX4mko8yMwnGu1Xdw/m FPiPPcY+cMTztoGr4beUynemy2n2+0pjtpaZU7CuYGLTHl7N1QEzwItSB7weQN/K9bveg8ApU1 Nnw= X-IronPort-AV: E=Sophos;i="5.69,309,1571727600"; d="scan'208";a="57649455" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Dec 2019 02:54:50 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 13 Dec 2019 02:54:50 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 13 Dec 2019 02:54:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OedSMFtP2yVbw5Qx8RCA988S09xEMuNMi8Zgd/jOhOL3RUhYwxP7kuWY0izbHdtI1TJh2zaYWWiWjSreNodfX90ryLUjidjXM6zvd6lpItoTpKp8L0B/NzmLvcsYROwwRAas/camolSqcoY56bxrLe0iuKKibkxpXzLReBa6rOKfMOsLSA0c58Nx5SYx0+qNGn9AUbCwBI+k7Nt11gnjD6dK4TZQ1DXFgieSwDVgMXRsNSzjDNtyGtGXtDeFwX7AjUv2gumfXwIVU9cYipKf2iUnAZuxAKaJB2lV5UPDW/rbmMq9yqiioFaj7HkNGkr3dVs2/K3WOAjbVJufD78Wog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W4XB05tfkqYEMHuUwPlILJvhhTDoOIFJlaErhf7T3i4=; b=eYxVn5ffjTnr0W93hsVKfSGxTNewyHmykjmZkqTuL/7ogIMYtHpfQeWIXdtrB0yxRGH6WMBY6VVZCTytjz+B8MoIU1z77WroSEpAelw14hU2kQF7lqFlE+SRji9zE7duUywADMLa84qQ2tsmL3WXxsXDHIx/C9bAFwDQ3gwss9NAjEJ67G0nHUE5pPFfr6w9ljxdnJqfDzGsVOgN4PjdJrbvYpo0u4BeKvpb7kMpMspoWoNvB8JjF+bTFNY6C7/FOmrTU4yGoN7+hayIUKetkNOc4MWS2ka0Wl60yxGQ2xYZ1Y3WnDZCJqCZUR4qhId3E6JBOyjSwn808Ax4nRpQAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W4XB05tfkqYEMHuUwPlILJvhhTDoOIFJlaErhf7T3i4=; b=oqf8w3iqZ21pWoVrLbdpp6DVhS2uUk3Sez7sWfnQTdR+MQBooS0eoIhDWkqNM5L8z2Wx9aipNvDlaSClvpH1pcRxhJYGXLAONgpsxSTSDr/T9L+If9q2T4/HIEnWNNemQ3A0eKQajbR3I3NyNbeYoHR3iGP7zJQZiacEicFfceQ= Received: from MN2PR11MB4448.namprd11.prod.outlook.com (52.135.39.157) by MN2PR11MB3935.namprd11.prod.outlook.com (10.255.180.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.17; Fri, 13 Dec 2019 09:54:49 +0000 Received: from MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::84c:6e75:22df:cbc9]) by MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::84c:6e75:22df:cbc9%5]) with mapi id 15.20.2538.017; Fri, 13 Dec 2019 09:54:49 +0000 From: To: Subject: [PATCH 3/5] crypto: atmel-{aes,sha,tdes} - Stop passing unused argument in _dma_init() Thread-Topic: [PATCH 3/5] crypto: atmel-{aes,sha,tdes} - Stop passing unused argument in _dma_init() Thread-Index: AQHVsZtb4TmLqdhnCEy1DKQBtubjBA== Date: Fri, 13 Dec 2019 09:54:49 +0000 Message-ID: <20191213095423.6687-3-tudor.ambarus@microchip.com> References: <20191213095423.6687-1-tudor.ambarus@microchip.com> In-Reply-To: <20191213095423.6687-1-tudor.ambarus@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR0501CA0046.eurprd05.prod.outlook.com (2603:10a6:800:60::32) To MN2PR11MB4448.namprd11.prod.outlook.com (2603:10b6:208:193::29) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [86.122.210.80] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 391e608d-1b5a-460b-0526-08d77fb27de4 x-ms-traffictypediagnostic: MN2PR11MB3935: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:586; x-forefront-prvs: 0250B840C1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(396003)(366004)(136003)(199004)(189003)(2616005)(2906002)(6486002)(6916009)(71200400001)(6512007)(86362001)(186003)(26005)(478600001)(52116002)(64756008)(66446008)(81156014)(1076003)(5660300002)(81166006)(54906003)(107886003)(8936002)(36756003)(316002)(66556008)(66476007)(66946007)(6506007)(4326008)(8676002)(142933001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3935; H:MN2PR11MB4448.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SdNMZBT9z0MOPJnrlaccVJnXvb2LKR/yaEhY3FeBd7wJF5wZnz1EyZ1o2Ss5yQBDUOG71AaCwNmJ0/vaiGWRUldEyT0E2p2IPqc0dvRfoXRnjdmA62FKrj2BUy7hLR9l9bePzWRR6N9TrHcqnffhOqu4aAzJuSNWJAD+kmThm4zmzrKHRok+NjLDWXgjAt341qvgHkVjMgaFP5F0yVWO1UnAu2YdUUY91EDYO6ZiNBwNyh5PhXk5jDMcJ5CVudTpe8f/ulunNHC5uN7IZ8tV92lrMfjbLyPK34+1BaS+fwBjNsx5skPZxl2kbRrvTnrzgvSPkvaXDTWnb9eTcDCkkHLtkUVIWzQb4jZPWLfgBPMfquTLLPoWJoOd1ITx5qYwMe02jjcJ/S+xTnwA3QrOManeYruK6nEIp4I958OjKq1HC3TzxafxDlr8krnifJOxsVdyJasWg6D967cH4tnL7sKcAYdSfoWWqrDGrGp+JpVD7zLjbflqLsdVFsP73xMo MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 391e608d-1b5a-460b-0526-08d77fb27de4 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2019 09:54:49.0805 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eRmQtNB1jDe92tFIQFe9A5IOhUQb8SlnL3V5QnsJo8BU381twweYR/84yVlNgkt72sI7aAylUKYioW4+hhPnx6gg/yVq0ZUwES5GDaoAWJ8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3935 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_015453_889218_06DF3D4D X-CRM114-Status: UNSURE ( 8.01 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [216.71.154.253 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, Tudor.Ambarus@microchip.com, Ludovic.Desroches@microchip.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Tudor Ambarus pdata is not used. Signed-off-by: Tudor Ambarus --- drivers/crypto/atmel-aes.c | 5 ++--- drivers/crypto/atmel-sha.c | 5 ++--- drivers/crypto/atmel-tdes.c | 5 ++--- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index d5a116693010..986f1ca682aa 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c @@ -2270,8 +2270,7 @@ static void atmel_aes_buff_cleanup(struct atmel_aes_dev *dd) free_page((unsigned long)dd->buf); } -static int atmel_aes_dma_init(struct atmel_aes_dev *dd, - struct crypto_platform_data *pdata) +static int atmel_aes_dma_init(struct atmel_aes_dev *dd) { int ret; @@ -2598,7 +2597,7 @@ static int atmel_aes_probe(struct platform_device *pdev) if (err) goto err_iclk_unprepare; - err = atmel_aes_dma_init(aes_dd, pdata); + err = atmel_aes_dma_init(aes_dd); if (err) goto err_buff_cleanup; diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c index 21fcc04f6688..a0d42bdc311f 100644 --- a/drivers/crypto/atmel-sha.c +++ b/drivers/crypto/atmel-sha.c @@ -2481,8 +2481,7 @@ static int atmel_sha_register_algs(struct atmel_sha_dev *dd) return err; } -static int atmel_sha_dma_init(struct atmel_sha_dev *dd, - struct crypto_platform_data *pdata) +static int atmel_sha_dma_init(struct atmel_sha_dev *dd) { dd->dma_lch_in.chan = dma_request_chan(dd->dev, "tx"); if (IS_ERR(dd->dma_lch_in.chan)) { @@ -2674,7 +2673,7 @@ static int atmel_sha_probe(struct platform_device *pdev) } } - err = atmel_sha_dma_init(sha_dd, pdata); + err = atmel_sha_dma_init(sha_dd); if (err) goto err_iclk_unprepare; diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c index 51b332527efd..d42b22775ee9 100644 --- a/drivers/crypto/atmel-tdes.c +++ b/drivers/crypto/atmel-tdes.c @@ -741,8 +741,7 @@ static int atmel_tdes_crypt(struct skcipher_request *req, unsigned long mode) return atmel_tdes_handle_queue(ctx->dd, req); } -static int atmel_tdes_dma_init(struct atmel_tdes_dev *dd, - struct crypto_platform_data *pdata) +static int atmel_tdes_dma_init(struct atmel_tdes_dev *dd) { int ret; @@ -1268,7 +1267,7 @@ static int atmel_tdes_probe(struct platform_device *pdev) } } - err = atmel_tdes_dma_init(tdes_dd, pdata); + err = atmel_tdes_dma_init(tdes_dd); if (err) goto err_buff_cleanup; From patchwork Fri Dec 13 09:54:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 11290363 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A9CC5138D for ; Fri, 13 Dec 2019 09:55:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F71B2073D for ; Fri, 13 Dec 2019 09:55:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ek/7Vucr"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="TxMhJwu+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F71B2073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=slwWsA1myVp3kIk7XBiV9g0j1rXUpo5NYY8omRxWQk4=; b=Ek/7VucrtrkjeA gt+FbSY48s4hRT96iI79IYKhIdTQ/L+vcvn83BEs9ZQ5Ast2CObiN9zsrbTSqQ+CGbHOoFcrNLRcp t/ltjrWLzlkNvNrP1leMGJFaZB8GrxnM7H3yR9K84WCwjplRn3oSkYteKjaxkcSxklzUGSxCg/cv9 q6PUMOocjp4fyHUm/ihQUcGzyzrcenxdssjDgyL8bYzcbRBVeMPbuEqP2FPWCOX/namOYWBF14DYr nr8dJqiMOzyn+3Rh+4yiHwpDpKCqDctHjPbPsBGUYPgLHNPNz84HPYNyYdR8SKmZejE+hQK7SdAY2 RnVPPiXiIFYoC+r0cBpQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifhfr-0002Wo-H1; Fri, 13 Dec 2019 09:55:51 +0000 Received: from esa3.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifhf1-0000cx-Ts for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2019 09:55:01 +0000 Received-SPF: Pass (esa3.microchip.iphmx.com: domain of Tudor.Ambarus@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa3.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="Tudor.Ambarus@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com -exists:%{i}.spf.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa3.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa3.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa3.microchip.iphmx.com; spf=Pass smtp.mailfrom=Tudor.Ambarus@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: GJ7oKUEKgVDOso5Hu66lahXBApPq7nJet+Mst8Y9OpA0JOQCgSv1Xl+EtagboXPBcGVLWANUgf UVP2U3zssQo1An/uY8ON7b/F8mwc9A/ZC1b3ivJKLtwu+oRoAH/DjzGHtEjmb/mu5XEgCT9Fys CEIg91U6VlvAv7ymcfC5Zmmi0marddu22AKDjHiye/JtmlxxXw9TEiaQENMX4VNtHRfjzvAA3m Zhl8MzyLR1Zxj8e4tCUD9rBPBZ2khzvPJrvqWeTZr3LCfBYA8noqzv5eIY5EgIH/6iaT/HYvg1 omE= X-IronPort-AV: E=Sophos;i="5.69,309,1571727600"; d="scan'208";a="60267803" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Dec 2019 02:54:56 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 13 Dec 2019 02:54:56 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 13 Dec 2019 02:54:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VJVP7nzXe62BWYvNW0qUOimHLVcxVOkfkud+ySQSLbm6WkJ/GYh3pBxeLPtYmZ6Owo/x0tEZ2Xl023NQGeMJAkZSbS3vEWgEPMprS2s/WLUm4oVripRelYtogiQcUVyQOhW+VkMEr57oUVKLaDwiVybB9Lv93H7sSvUUxxbCk4iuuUbMqxIl975xevIYxHaP/79ms5Lv8+NtTjV5f+NTyRtKHpsu8TRz/6JOPqPNUcFYeUuZ8MdaAVshGt9p9MsLplTdUMFtHJpsaouJhKuDeWcex/F+ZcTeJpOqJk63RY87s6q6MIgKXtxZhk8/5ufKfmxANX1gE62k0ZichfjTBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M+8xSIbOtjmSYYRyoy2ZTUhVEHOqGhVXQzY1H9wCCFk=; b=bM+SbKMas8BYQjPmVcAkT9t0FDXCkxKECOwsvuGZQ6SAr9IHDXqCjanijKUUJ0t+gUJcs10ZBFa/JNHiGnuUPmZiIFbYPj67qE8bsfk7Y/eS1CkIqFHVWw0X7iR8mNz4/Oe9jnL9or9ZgcOFygRzFut5Szcv2fBoQeVbSHxUT00o5JCt0/gY55Vhr7Mtbzd9uSsvieRvaMpjnankurmVl3TkyhFZawmOUw1k1zdN9Xfqq6J8saAyo8j8d0Tfx15eEj8ltA/sdA1kYrU4hfeVwdGfGAwIyyM+fpeOZ/+zmtSfT+5EUKnplVHk+leNODfy2bhA3xQyUZgw7txU9XLnWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M+8xSIbOtjmSYYRyoy2ZTUhVEHOqGhVXQzY1H9wCCFk=; b=TxMhJwu+A+Z80/u3Egr9aBAlG3C/Cui2UfiWBsWcu0Rn0kjGudGq1W77rx5R1JL2EORb/jVOz3pVMu6xupip0SClNVx0Zy0G6JtLc68GMgqtelTjfusfpl7ce7Zg6sxbfATSFuIAK0+kTbuVoY4o5AZGOjrweRT8pLT47okjx30= Received: from MN2PR11MB4448.namprd11.prod.outlook.com (52.135.39.157) by MN2PR11MB3935.namprd11.prod.outlook.com (10.255.180.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.17; Fri, 13 Dec 2019 09:54:54 +0000 Received: from MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::84c:6e75:22df:cbc9]) by MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::84c:6e75:22df:cbc9%5]) with mapi id 15.20.2538.017; Fri, 13 Dec 2019 09:54:54 +0000 From: To: Subject: [PATCH 4/5] crypto: atmel-{sha,tdes} - Print warn message even when deferring Thread-Topic: [PATCH 4/5] crypto: atmel-{sha,tdes} - Print warn message even when deferring Thread-Index: AQHVsZteWaZn226a1EOkK8oh3K5wUg== Date: Fri, 13 Dec 2019 09:54:54 +0000 Message-ID: <20191213095423.6687-4-tudor.ambarus@microchip.com> References: <20191213095423.6687-1-tudor.ambarus@microchip.com> In-Reply-To: <20191213095423.6687-1-tudor.ambarus@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR0501CA0046.eurprd05.prod.outlook.com (2603:10a6:800:60::32) To MN2PR11MB4448.namprd11.prod.outlook.com (2603:10b6:208:193::29) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [86.122.210.80] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 61343722-f60c-4cf4-bfcf-08d77fb2812e x-ms-traffictypediagnostic: MN2PR11MB3935: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 0250B840C1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(396003)(366004)(136003)(199004)(189003)(2616005)(2906002)(6486002)(6916009)(71200400001)(6512007)(86362001)(186003)(26005)(478600001)(52116002)(64756008)(66446008)(81156014)(1076003)(5660300002)(81166006)(54906003)(107886003)(8936002)(36756003)(316002)(66556008)(66476007)(66946007)(6506007)(4326008)(8676002)(15650500001)(142933001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3935; H:MN2PR11MB4448.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UA5zgAIifrCeQmIp64Kbc9IkWyaZzfT+bIl10z6okjKDel1e3YiTi8IpFvW3LcHDlytl33ysG+FOjMO5UQzfKanc1HQ5H3SNahrEQhb/kowtMYy48ue6xE/fyNI7DQFU9sJ31D9Was0NCXfB7ByDg13t3KTxgxVgK23hLQshl9wLhuwxJdQGh4NbEhEGO+obHZn9o0C3oQPC/Gv/GpBJeVjgq5bpg4bhP05FRO7DqGZNvUW6KMJ/tUMDEDiFl/P1Q0Vp2I2Q6DjIpxuf4NMDtOuJn6DbWUwv78dZ3ehU6F7eCw+5QtpxIej1+nYObj8kxEIOQIQi9ZQiX4zsLPu2d2M4yf6/xZ1by3KN9Cy3HHvwwAwxus+0S8/RD1uoXyy+cPs6siQ0EHZjo/T+xPLgEBEYxT2dKF83JBq0HEAqgyCRCOKONEzB6hQxsgDb0JRr+5a3DA5w5M6bP8NQIYkkVlNIagvOC64zo0yDUYc33ZCalfeiqkLebb6Xeh/h9UYF MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 61343722-f60c-4cf4-bfcf-08d77fb2812e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2019 09:54:54.6424 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 81Q2KsrswA9X9+sEeX/Q5FY/4VTwSGqaAtcR/Ik37QCx0VDhFyXvuhAFVrOneYGuQ16Eq2In4S4XhRNDEErJsx+jXbv0QEQ46qeMVhreWAs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3935 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_015500_005551_A0ED4F03 X-CRM114-Status: GOOD ( 10.24 ) X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.153.233 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, Tudor.Ambarus@microchip.com, Ludovic.Desroches@microchip.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Tudor Ambarus Even when deferring, we would like to know what caused it. Update dev_warn to dev_err because if the DMA init fails, the probe is stopped. Signed-off-by: Tudor Ambarus --- drivers/crypto/atmel-aes.c | 2 +- drivers/crypto/atmel-sha.c | 7 ++----- drivers/crypto/atmel-tdes.c | 3 +-- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index 986f1ca682aa..855f0ccc9368 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c @@ -2292,7 +2292,7 @@ static int atmel_aes_dma_init(struct atmel_aes_dev *dd) err_dma_out: dma_release_channel(dd->src.chan); err_dma_in: - dev_warn(dd->dev, "no DMA channel available\n"); + dev_err(dd->dev, "no DMA channel available\n"); return ret; } diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c index a0d42bdc311f..e8e4200c1ab3 100644 --- a/drivers/crypto/atmel-sha.c +++ b/drivers/crypto/atmel-sha.c @@ -2485,11 +2485,8 @@ static int atmel_sha_dma_init(struct atmel_sha_dev *dd) { dd->dma_lch_in.chan = dma_request_chan(dd->dev, "tx"); if (IS_ERR(dd->dma_lch_in.chan)) { - int ret = PTR_ERR(dd->dma_lch_in.chan); - - if (ret != -EPROBE_DEFER) - dev_warn(dd->dev, "no DMA channel available\n"); - return ret; + dev_err(dd->dev, "DMA channel is not available\n"); + return PTR_ERR(dd->dma_lch_in.chan); } dd->dma_lch_in.dma_conf.dst_addr = dd->phys_base + diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c index d42b22775ee9..83a6d42c8921 100644 --- a/drivers/crypto/atmel-tdes.c +++ b/drivers/crypto/atmel-tdes.c @@ -783,8 +783,7 @@ static int atmel_tdes_dma_init(struct atmel_tdes_dev *dd) err_dma_out: dma_release_channel(dd->dma_lch_in.chan); err_dma_in: - if (ret != -EPROBE_DEFER) - dev_warn(dd->dev, "no DMA channel available\n"); + dev_err(dd->dev, "no DMA channel available\n"); return ret; } From patchwork Fri Dec 13 09:54:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tudor Ambarus X-Patchwork-Id: 11290365 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E94CB14DB for ; Fri, 13 Dec 2019 09:56:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C650A2073D for ; Fri, 13 Dec 2019 09:56:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mU/5flFR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microchiptechnology.onmicrosoft.com header.i=@microchiptechnology.onmicrosoft.com header.b="hUAJWCLl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C650A2073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=idL+aFp6+xKs95TmTvhRe9mxJI1zUxOREJWtLQSCTGs=; b=mU/5flFR47hLrx PDJ6aq8GRWMovRpDuAi1d3nML4mzGSBdV0blZT4JjoQQRiTAziEOEW8zH9ROjUnmc0VuMEIh4KRW/ dYRGhyf5pTvL41ndXBm5KAWmv9De0FJpag3bVf1QoSsJkLq/dEW36CU1k7RC3aRXvFzHmEkQAVxuN 0Ph9i0xw6lsYgj99PrrTWo0tec9ELvx6AviDCl1yiPRLuSyZ+OcWym+uZNW6eZqDvirtWOOHI2anZ WwG/cCDIQpAKD1RaAIvkJ8/6y6nqpf72EwPt66dHDaahitKoMwnoJfAlD8cudQSCgA2hIOwiIVLOs OLgifIBLwUEw1QZl9sbw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifhg6-0002ka-8T; Fri, 13 Dec 2019 09:56:06 +0000 Received: from esa3.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifhf4-0000cx-DZ for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2019 09:55:04 +0000 Received-SPF: Pass (esa3.microchip.iphmx.com: domain of Tudor.Ambarus@microchip.com designates 198.175.253.82 as permitted sender) identity=mailfrom; client-ip=198.175.253.82; receiver=esa3.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="Tudor.Ambarus@microchip.com"; x-conformance=spf_only; x-record-type="v=spf1"; x-record-text="v=spf1 mx a:ushub1.microchip.com a:smtpout.microchip.com -exists:%{i}.spf.microchip.iphmx.com include:servers.mcsv.net include:mktomail.com include:spf.protection.outlook.com ~all" Received-SPF: None (esa3.microchip.iphmx.com: no sender authenticity information available from domain of postmaster@email.microchip.com) identity=helo; client-ip=198.175.253.82; receiver=esa3.microchip.iphmx.com; envelope-from="Tudor.Ambarus@microchip.com"; x-sender="postmaster@email.microchip.com"; x-conformance=spf_only Authentication-Results: esa3.microchip.iphmx.com; spf=Pass smtp.mailfrom=Tudor.Ambarus@microchip.com; spf=None smtp.helo=postmaster@email.microchip.com; dkim=pass (signature verified) header.i=@microchiptechnology.onmicrosoft.com; dmarc=pass (p=none dis=none) d=microchip.com IronPort-SDR: rP/er24DGt+qDdQxEk8Rh3UZP830ZG17zaAMTV6r001FM40FTdYs327wI+6w25U/cdM8tRrOa5 uBNeDBr5TWeN78otg/kdjIqKqy5e/kHPxgSEfKbKYxGOCUNht1YE2RdtELOOLUrMTOtCTJIhVs OZMSEmaQ/vZqQW6G3F/vRHohSzH26Nwsy6rXCBXEn4PcXZ6IabaPG+sQk15PzK7vFxDb09qqeu mPQUU+GFcwTlyzFOErbaa/KYjPO/ZSdSiSlXzi1Jv5fKaum/sCOR9cE0U7R7ZXQSMvqNd7JEIn /jU= X-IronPort-AV: E=Sophos;i="5.69,309,1571727600"; d="scan'208";a="60267812" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa3.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Dec 2019 02:55:01 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 13 Dec 2019 02:54:58 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 13 Dec 2019 02:54:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QnjMNDI6gmAaTaDpCaI1rNiYTaixV/SngiUx2zYbOJ1Rkb53vcagK5HRmyRvoeOaWD6s+YQCuhDA/hmPTk2Om/VKKjWO2U1nN47ktFrcRIUeJOOQm6NqKETMl1zkFvGW3PD2NJSOFlS0dOyqDIiqcE0g2EqEpSiO0LnDNSh2TC5Z2cttKc0L8rCOxMm5hSwD3pUbR4u+nDf3udXAruycmQiETrJLPfQLZv5Sy6GKy3VN9RmwmabAk4yEnwmNaFG6yp1bH9mET4swavHg1ZFSlA1+rqvDtbSNN4Xnwp3vRyGA83zUGzfMpB6I7MIOHumtUbWjgSqqitfNnjrEaCF+nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=32EckjQQqgoLtOx0b8/KiJ0d5GeJ/4L9UgJWttysbLY=; b=iW+acy3UKhKw9lJe+1bEKORnIYu4+Iz8GCRo87mwR0HZ8IYQoXN6qceIE6zMYiUEYIr7F2K65gkwJV0wBzbwTX5GUZhTWHWQ0gly5tw5kl736Z8p8iZdXpucCbSCvzKF9cLJoYunj8cgru2wQT7TwhunJzNA8o/rtP+JJ+ULuShukMX8aETjP49SD2Vmf98Tfa8zEyL8hxei70Q/9Y2wPqqFisSwhMr9dWhXnzNd5LlNzb3x4HrnESmbwGxFJG1YNeoQWYhR7mNL4TlpH8ELB3H0RVQd446zwSIuIzq/87GEeAB0LrPGHfPlAUVpHNxPGSiJbZ+kvKJMzBXCLNP/ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=32EckjQQqgoLtOx0b8/KiJ0d5GeJ/4L9UgJWttysbLY=; b=hUAJWCLljEZh+3/9HtpWGNOJ0pCd/zXDbEQ6K0dgAJXYg+WSugJ4BeDRomdo8Hu/VaQ4TnaN9YS1fyRUW/mF6Oa/e9P39xa3REhPRIbykkdZ7p9NJjeHusLq9vgYfA1kjprZMUBzNejr6TA4rxlc4V60Gn2EruKKRNgIHubYUPM= Received: from MN2PR11MB4448.namprd11.prod.outlook.com (52.135.39.157) by MN2PR11MB3935.namprd11.prod.outlook.com (10.255.180.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.17; Fri, 13 Dec 2019 09:54:56 +0000 Received: from MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::84c:6e75:22df:cbc9]) by MN2PR11MB4448.namprd11.prod.outlook.com ([fe80::84c:6e75:22df:cbc9%5]) with mapi id 15.20.2538.017; Fri, 13 Dec 2019 09:54:56 +0000 From: To: Subject: [PATCH 5/5] crypto: atmel-{aes, tdes} - Update the IV only when the op succeeds Thread-Topic: [PATCH 5/5] crypto: atmel-{aes,tdes} - Update the IV only when the op succeeds Thread-Index: AQHVsZtfj2psfTAPsECkyIsj65ou2A== Date: Fri, 13 Dec 2019 09:54:56 +0000 Message-ID: <20191213095423.6687-5-tudor.ambarus@microchip.com> References: <20191213095423.6687-1-tudor.ambarus@microchip.com> In-Reply-To: <20191213095423.6687-1-tudor.ambarus@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1PR0501CA0046.eurprd05.prod.outlook.com (2603:10a6:800:60::32) To MN2PR11MB4448.namprd11.prod.outlook.com (2603:10b6:208:193::29) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.20.1 x-originating-ip: [86.122.210.80] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ad02d5c2-fd9b-4189-3765-08d77fb2824e x-ms-traffictypediagnostic: MN2PR11MB3935: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 0250B840C1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(39860400002)(396003)(366004)(136003)(199004)(189003)(2616005)(2906002)(6486002)(6916009)(71200400001)(6512007)(86362001)(186003)(26005)(478600001)(52116002)(64756008)(66446008)(81156014)(1076003)(5660300002)(81166006)(54906003)(107886003)(8936002)(36756003)(316002)(66556008)(66476007)(66946007)(6506007)(4326008)(8676002)(15650500001)(142933001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR11MB3935; H:MN2PR11MB4448.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cOVB8Zw4/ACkPzdwfQVTgVBX+eAow3QMhxO6U9P3LZAS9URY0cyvhJMe6+E3hHiF8w+Jx7G1Hgfwr5vjaCcqxeMTvUYH+f7DDv1AjTVurRW15nN5qj4QNMsY4XV+UeGFuPfn/tQuJBlReczYu671d00SZH2s4z+1iig5y6PijskwSRz6tOL8CHITNZ3ziEVdrAYEOvD3cwW6K01ZURN8tZKp9VIEFe+OMdsgVoki7Bj2Owx11XSISDwzg8HTl5sQTmuWp9cJwFnp04zZgSIOXQJi4H0BXXJ2fArSquj2hleb6gC9MRZ4eCg1Hky8j9iQdNnkBDJJX+PRTYiZTXPP3nptZDwaeQAKVmoL1cMgM1kZPLgcF5v8j8CUSGF8hxRZs02RfV+2e49Eq5o0gMhY6O2QpHgUMZHXl1JESLZTaKpuGyxYfg+3Vypmf299E7WH/9O8tvG0BZC2aZOunJfz+cGCP0HP96HbgrS28pPQ+WvSMaig85Ime1SI+Hjj1AUx MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ad02d5c2-fd9b-4189-3765-08d77fb2824e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Dec 2019 09:54:56.5393 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0u7v3FAzpqFb9NF+Dql5Sqf1/TrMm8L74G8DhElwsk0vpvyQtwQnTutwxSJM6Nd5iSGUAo5KHdNQrmj8ulJ6qcnlyOJMfZaHJ3M+7D6Ywe8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3935 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_015502_899841_0D747A92 X-CRM114-Status: UNSURE ( 9.57 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.153.233 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, Tudor.Ambarus@microchip.com, Ludovic.Desroches@microchip.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Tudor Ambarus Do not update the IV in case of errors. Signed-off-by: Tudor Ambarus --- drivers/crypto/atmel-aes.c | 2 +- drivers/crypto/atmel-tdes.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index 855f0ccc9368..245d45f93b61 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c @@ -546,7 +546,7 @@ static inline int atmel_aes_complete(struct atmel_aes_dev *dd, int err) clk_disable(dd->iclk); dd->flags &= ~AES_FLAGS_BUSY; - if (!dd->ctx->is_aead && + if (!err && !dd->ctx->is_aead && (rctx->mode & AES_FLAGS_OPMODE_MASK) != AES_FLAGS_ECB) { if ((rctx->mode & AES_FLAGS_OPMODE_MASK) != AES_FLAGS_CTR) atmel_aes_set_iv_as_last_ciphertext_block(dd); diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c index 83a6d42c8921..e7cd7b01b931 100644 --- a/drivers/crypto/atmel-tdes.c +++ b/drivers/crypto/atmel-tdes.c @@ -597,7 +597,7 @@ static void atmel_tdes_finish_req(struct atmel_tdes_dev *dd, int err) dd->flags &= ~TDES_FLAGS_BUSY; - if ((rctx->mode & TDES_FLAGS_OPMODE_MASK) != TDES_FLAGS_ECB) + if (!err && (rctx->mode & TDES_FLAGS_OPMODE_MASK) != TDES_FLAGS_ECB) atmel_tdes_set_iv_as_last_ciphertext_block(dd); req->base.complete(&req->base, err);