From patchwork Thu Jul 26 21:10:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10546479 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7E87D1822 for ; Thu, 26 Jul 2018 21:10:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7FBEE2BC4F for ; Thu, 26 Jul 2018 21:10:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 73DC02BC52; Thu, 26 Jul 2018 21:10:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D7832BC50 for ; Thu, 26 Jul 2018 21:10:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731343AbeGZW3P (ORCPT ); Thu, 26 Jul 2018 18:29:15 -0400 Received: from esa6.hgst.iphmx.com ([216.71.154.45]:42050 "EHLO esa6.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730402AbeGZW3P (ORCPT ); Thu, 26 Jul 2018 18:29:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1532639439; x=1564175439; h=from:to:cc:subject:date:message-id; bh=Tj4GZkxqS7l1Mokmc385ZfiwbgOHZsO/5GwQyejX840=; b=AZMFSBtRO52Ea4AQ2jni+OgCvqQ/X7f8EV/8wozaRdJKNC9ze8q9wRJ2 ZvomX+4MY0xOCgAK//OcAEW2fceksuMe2CQQgTAM+2KClJ93TTgv+jS9u /5ZlaApqJClpazM5Po49QBYvp9nr15l03G9r4uipXhRDkMTfrCs1Jg+zz F8FRYMdwE/64QeXV/eT6lH3YGWdX8dMSwvTkzblWjwoNQGGlX23NdaJge jQjx5hCZcdsPJdXqqV6L3r29hZnyx1XBewUbqLgO/vPzUsd+B+ab/VqUz xmMpX2g5N9+ujLW3wIcTOVgrCjbeamGQFOYdA7cQ7jLVWghRpWBFbJ3J5 A==; X-IronPort-AV: E=Sophos;i="5.51,406,1526313600"; d="scan'208";a="86514059" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 27 Jul 2018 05:10:38 +0800 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP; 26 Jul 2018 13:58:42 -0700 Received: from thinkpad-bart.sdcorp.global.sandisk.com ([10.111.67.248]) by uls-op-cesaip02.wdc.com with ESMTP; 26 Jul 2018 14:10:38 -0700 From: Bart Van Assche To: "Martin K . Petersen" , "James E . J . Bottomley" Cc: linux-scsi@vger.kernel.org, Bart Van Assche , QLogic-Storage-Upstream@cavium.com, stable@vger.kernel.org Subject: [PATCH] qedi: Fix a potential buffer overflow Date: Thu, 26 Jul 2018 14:10:37 -0700 Message-Id: <20180726211037.6257-1-bart.vanassche@wdc.com> X-Mailer: git-send-email 2.18.0 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Tell snprintf() to store at most 255 characters in the output buffer instead of 256. This patch avoids that smatch reports the following warning: drivers/scsi/qedi/qedi_main.c:891: qedi_get_boot_tgt_info() error: snprintf() is printing too much 256 vs 255 Signed-off-by: Bart Van Assche Cc: Cc: Acked-by: Nilesh Javali --- drivers/scsi/qedi/qedi_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index 682f3ce31014..ea62180d9ec8 100644 --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi/qedi_main.c @@ -888,7 +888,7 @@ static void qedi_get_boot_tgt_info(struct nvm_iscsi_block *block, ipv6_en = !!(block->generic.ctrl_flags & NVM_ISCSI_CFG_GEN_IPV6_ENABLED); - snprintf(tgt->iscsi_name, NVM_ISCSI_CFG_ISCSI_NAME_MAX_LEN, "%s\n", + snprintf(tgt->iscsi_name, sizeof(tgt->iscsi_name), "%s\n", block->target[index].target_name.byte); tgt->ipv6_en = ipv6_en;