From patchwork Mon Dec 16 18:32:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 11294995 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B679B112B for ; Mon, 16 Dec 2019 18:33:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94DA8218AC for ; Mon, 16 Dec 2019 18:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576521194; bh=ymG65eyYvOkGT/a1o3YdUCpKSlzLO0odxHAPgjHBxno=; h=From:To:Cc:Subject:Date:List-ID:From; b=DeDTc+Z4ApkZE6ARMfa/8SroD6Mn8iDsHOeR0Fsmbc6vbIWzfQT/DU5d1u7vNADZd 8g5iwrToabH0V5r0WbjgCPsYFqykyV0dKBuWSqOX1J6uMr7WpC+xwX1BDq9aBG334O HItAaJC8KasOrwZNL7W2DBRYS0J3VEcqrA9l9bAg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728973AbfLPScw (ORCPT ); Mon, 16 Dec 2019 13:32:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:60232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728309AbfLPScv (ORCPT ); Mon, 16 Dec 2019 13:32:51 -0500 Received: from localhost.localdomain (unknown [122.182.192.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1A44207FF; Mon, 16 Dec 2019 18:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576521171; bh=ymG65eyYvOkGT/a1o3YdUCpKSlzLO0odxHAPgjHBxno=; h=From:To:Cc:Subject:Date:From; b=2Bn0vV2zeXZU42Qw/Iw9TpgoDoWqkVhKIjIuQJH4XiImIpywXcXN9r6B/r9yN8nxN UNdyhISxhr5AgbOi71Oe3VEUwchQi9DKK026Cj5gmyebGmfAnRa5zAvmAmGO7qvzK7 1vy46WuyaWgjjgx2ElTXOTWZXfS5RcmtXxFg0qq4= From: Vinod Koul To: Andy Gross , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, Vinod Koul , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] arm64: dts: qcom: sm8150: Update UFS resets Date: Tue, 17 Dec 2019 00:02:31 +0530 Message-Id: <20191216183232.1570675-1-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The reset described is the phy reset so it should be named ufsphy, so update it and add the UFS card reset Earlier reset description was incorrect as phy reset was pointed to 'rst' as well as 'ufsphy' so both phy and core attempted to reset this causing UFS to not come up. This was discovered with 870b1279c7a0 ("scsi: ufs-qcom: Add reset control support for host controller") Signed-off-by: Vinod Koul --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index f36d621a53e2..6a351e0cb3a6 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -517,8 +517,9 @@ phy-names = "ufsphy"; lanes-per-direction = <2>; #reset-cells = <1>; - resets = <&gcc GCC_UFS_PHY_BCR>; - reset-names = "rst"; + resets = <&gcc GCC_UFS_PHY_BCR>, + <&gcc GCC_UFS_CARD_BCR>; + reset-names = "ufsphy", "rst"; clock-names = "core_clk", From patchwork Mon Dec 16 18:32:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 11294989 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 94B93109A for ; Mon, 16 Dec 2019 18:33:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70B55207FF for ; Mon, 16 Dec 2019 18:33:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576521180; bh=3tE9VgX0PlQp/RfUUXS8IU04W0aYzDGAQGslLTTAyVU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xLjPz9GNce2gSsyb7WhoptX7X7C5FJD+5/ezrscVc+CylouJNrNu7hoVh5pOOlqtz Nr3796VOq36PUcgB1N3jq3+tLJwTHF3ODQW8WAW5zUQqsgXVxLnEGuhVbec7FR6woW r+9MTM5MwyOQ/WFM0EQ8RbFsMu2YJKEpwmx0EL0c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728316AbfLPSc4 (ORCPT ); Mon, 16 Dec 2019 13:32:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:60464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728309AbfLPScz (ORCPT ); Mon, 16 Dec 2019 13:32:55 -0500 Received: from localhost.localdomain (unknown [122.182.192.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1058B21835; Mon, 16 Dec 2019 18:32:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576521174; bh=3tE9VgX0PlQp/RfUUXS8IU04W0aYzDGAQGslLTTAyVU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C0iGQ2ixYzFmDaqZNqHqnDKmFspPklMfqVaOQrE1FiwbT5qYqMc13VczctAlqx+IR am07LeI5/ZP2enYXkvTe5DRQhnPXz2b+GvlPRqZ3tBIlDY3hqgEYHJxeZXJdkAvem1 GQUQ1D1lX6g5vRX0Ax6KFmU9kErYpGcuyQnW/FY0= From: Vinod Koul To: Andy Gross , Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, Vinod Koul , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] arm64: dts: qcom: sm8150-mtp: Add reset line for UFS Date: Tue, 17 Dec 2019 00:02:32 +0530 Message-Id: <20191216183232.1570675-2-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191216183232.1570675-1-vkoul@kernel.org> References: <20191216183232.1570675-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add the reset line for the UFS node. Signed-off-by: Vinod Koul --- arch/arm64/boot/dts/qcom/sm8150-mtp.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts index 1eb93a768a85..9cab51759d2f 100644 --- a/arch/arm64/boot/dts/qcom/sm8150-mtp.dts +++ b/arch/arm64/boot/dts/qcom/sm8150-mtp.dts @@ -7,6 +7,7 @@ /dts-v1/; #include +#include #include "sm8150.dtsi" #include "pm8150.dtsi" #include "pm8150b.dtsi" @@ -389,6 +390,8 @@ &ufs_mem_hc { status = "okay"; + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>; + vcc-supply = <&vreg_l10a_2p5>; vcc-max-microamp = <750000>; vccq-supply = <&vreg_l9a_1p2>;