From patchwork Tue Dec 17 11:11:55 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Junho X-Patchwork-Id: 11297269 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B4756921 for ; Tue, 17 Dec 2019 11:12:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 919BD2082E for ; Tue, 17 Dec 2019 11:12:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ov2Q68fE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725940AbfLQLMJ (ORCPT ); Tue, 17 Dec 2019 06:12:09 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44291 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727190AbfLQLMI (ORCPT ); Tue, 17 Dec 2019 06:12:08 -0500 Received: by mail-pg1-f195.google.com with SMTP id x7so5470983pgl.11; Tue, 17 Dec 2019 03:12:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=IA63TGuvmpsUwo2vleoz36+x8xqbZ3/90CJ5cyT26rE=; b=ov2Q68fE4IPuyR5otK9oGd1ob0KD3NBMeg3ueAQ2G7Imjtmj/SZgK/g9SyTI6GU/5k yyuzeiGwvVA7fajsCKeFg+wSdXZgEfbZ+r3C84y1lnHDtLpV+m/luBPK9GnwD+QUz6Qa vD7PyXU3QxWXFzIKg+kuM4TkJWHjmSOTPeCpIL9IFm8gYcHq/vFIsCkxy+RE2SguFnoo t/ZG6/TXWfe19YB9rDADSOo8cnkOEqfsbCb37gN6qELnqVgkAPA3jR7eOG8CHma/peRL 513k37sbD+qEMuDiYlKXolfF7hv5irZHWiXBuIj6DjO2QBXLKnpaG+EJAIHqqRpPccIP Irzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IA63TGuvmpsUwo2vleoz36+x8xqbZ3/90CJ5cyT26rE=; b=e1zSfcGKxHkWyQVCTbIBiDgdmh8Y3nwA20weip1SxVie44ryYp4tqMdFkN0NLjuacw PpsahcfWiUhwPW8MWBrCUHt7aLm+51I/gye+d90YNF+2f6DfLlQ1w4YLyUOlVQFG8zhl 6JrL5cI6LdQEghC7Aycl03YckQPxNyqMODKtvXEo9NEIFGuRyvkkBE/bQDrnroBqHoK0 oioVxIzXL2w0bjx7rQVBrIcR8ux6hyzKAEtJdJLw4IaIW1ElSDIaSLsR8YWw7IU/b4Hc BJWnWTWw7SGwJTU1vIUqCHEPHzUQaIonbYaQSaGqq5oAdpUKxdlmx2nH63UrJWvWXL5G NunA== X-Gm-Message-State: APjAAAVnD1gxk1cooHJK8fj39CjUDm4wepQcAy/xA8tyVU5c+mPGdJz9 OrO7d+TuycI4jIuJy1CSt28= X-Google-Smtp-Source: APXvYqx3B52CUga00ZeCK8d+KiYISZhQGFTvXYBAVPqUZLT/tLWcL0ydJgiHqoIIgC25awsDJeezLg== X-Received: by 2002:a65:4344:: with SMTP id k4mr23959422pgq.193.1576581127562; Tue, 17 Dec 2019 03:12:07 -0800 (PST) Received: from brcpsddjunho-l.padtec.com.br (apolo.padtec.com.br. [200.228.158.130]) by smtp.gmail.com with ESMTPSA id 81sm25855190pfx.73.2019.12.17.03.12.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 03:12:06 -0800 (PST) From: Daniel Junho To: "Jonathan Cameron" , "Ardelean, Alexandru" , "Popa, Stefan Serban" , "lkcamp@lists.libreplanetbr.org" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "pmeerw@pmeerw.net" , "knaack.h@gmx.de" , "Hennerich, Michael" , "lars@metafoo.de" Subject: [PATCH v3 1/4] iio: adc: ad7923: Remove the unused defines Date: Tue, 17 Dec 2019 08:11:55 -0300 Message-Id: <20191217111158.30888-2-djunho@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191217111158.30888-1-djunho@gmail.com> References: <20191217111158.30888-1-djunho@gmail.com> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Removes the unused define AD7923_CHANNEL_x from the code. Signed-off-by: Daniel Junho Reviewed-by: Alexandru Ardelean --- drivers/iio/adc/ad7923.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c index 3212eb4c0f25..969c06b7d2b7 100644 --- a/drivers/iio/adc/ad7923.c +++ b/drivers/iio/adc/ad7923.c @@ -29,10 +29,6 @@ #define AD7923_PM_MODE_AS (1) /* auto shutdown */ #define AD7923_PM_MODE_FS (2) /* full shutdown */ #define AD7923_PM_MODE_OPS (3) /* normal operation */ -#define AD7923_CHANNEL_0 (0) /* analog input 0 */ -#define AD7923_CHANNEL_1 (1) /* analog input 1 */ -#define AD7923_CHANNEL_2 (2) /* analog input 2 */ -#define AD7923_CHANNEL_3 (3) /* analog input 3 */ #define AD7923_SEQUENCE_OFF (0) /* no sequence fonction */ #define AD7923_SEQUENCE_PROTECT (2) /* no interrupt write cycle */ #define AD7923_SEQUENCE_ON (3) /* continuous sequence */ From patchwork Tue Dec 17 11:11:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Junho X-Patchwork-Id: 11297271 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B52E914E3 for ; Tue, 17 Dec 2019 11:12:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9283720716 for ; Tue, 17 Dec 2019 11:12:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hCpwf90q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727341AbfLQLMM (ORCPT ); Tue, 17 Dec 2019 06:12:12 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:42575 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727190AbfLQLML (ORCPT ); Tue, 17 Dec 2019 06:12:11 -0500 Received: by mail-pf1-f194.google.com with SMTP id 4so7354517pfz.9; Tue, 17 Dec 2019 03:12:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=tDASqqq00AoUFhkrpIeD5i5da1G2sBy2LHsU0nWW8fI=; b=hCpwf90q/OrfsAHOaR73nV4fXGokdZnKxQAEvF5Z2Ia1JhFgNa3ykBd38tixTrgqF/ fbniDkJNygUGXcMrwe5mocSrJjqOAtUA2V9a1I0Az3DUtimR7nKKBPiEub0wwkHHnQDo qO4JlpgqGzsZrqzEzYMg/i4Rkp8NiGv60eG9GWxQbukvKMJ74nEg7k3MJCuhSxL5ClzP ceVtf5k8bmDTqtcrG+r3RZWjjN03oQ0SMCs8TywOLNTQ8XkTYA8447eGMa5E89fXiDsB YNSYFXzH/Ls8f64ZksBiqhRno5qd+m/Xbl8T7HFwSOUXdopzWyR5FEli/AOTreVO+/V6 lA7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tDASqqq00AoUFhkrpIeD5i5da1G2sBy2LHsU0nWW8fI=; b=EA5KsSXo/K1ctGD5f0cRJ+EbhDZG8q/EAGM1cM4vgmcMcppeOjn2Ons7eTi4yn62GV 7IvOj7Z/wFbU29Mzzmq+IESZW16uqiqyUPsUDo/4WubBucVi3P+SgrlCX2xY9Wq//LW1 m4L2jvoaGgOAbRCaYorTjMGVehJOFRhFhMQ3iqEv2/pCo6mK+JJsUlpViCDXmjrrlaVj 3Fm856mZZIXxwW4SgrKwb8vUW4ICMlC2M01F5Pg2Ru/jw3YNu+PZo+2mEC7waJ8gabPu UL4tcvNoydcQcYlfv19WWS1wLqumLrR9dZCnNIg+cbQk28OLSk27NlqwkojtnVb8To08 LgOA== X-Gm-Message-State: APjAAAXGaiNjYZ1U/+9ciUAcobtWwpirAEkGH2g/Ny0hN+NsqeRdi9WV E0UTLMXJD9ly/7nkhps0940= X-Google-Smtp-Source: APXvYqxiYGC+TrwRnhox51l4gq20/VDouU9UFpaUB/1tW0upYpQSwe88orItsMFSPZvwDXhrDUD0+w== X-Received: by 2002:a65:4109:: with SMTP id w9mr24061803pgp.383.1576581130885; Tue, 17 Dec 2019 03:12:10 -0800 (PST) Received: from brcpsddjunho-l.padtec.com.br (apolo.padtec.com.br. [200.228.158.130]) by smtp.gmail.com with ESMTPSA id 81sm25855190pfx.73.2019.12.17.03.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 03:12:10 -0800 (PST) From: Daniel Junho To: "Jonathan Cameron" , "Ardelean, Alexandru" , "Popa, Stefan Serban" , "lkcamp@lists.libreplanetbr.org" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "pmeerw@pmeerw.net" , "knaack.h@gmx.de" , "Hennerich, Michael" , "lars@metafoo.de" Subject: [PATCH v3 2/4] iio: adc: ad7923: Fix checkpatch warning Date: Tue, 17 Dec 2019 08:11:56 -0300 Message-Id: <20191217111158.30888-3-djunho@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191217111158.30888-1-djunho@gmail.com> References: <20191217111158.30888-1-djunho@gmail.com> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Fix checkpatch warning: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' +static int ad7923_scan_direct(struct ad7923_state *st, unsigned ch) Signed-off-by: Daniel Junho Reviewed-by: Alexandru Ardelean --- drivers/iio/adc/ad7923.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c index 969c06b7d2b7..e535cec9fc02 100644 --- a/drivers/iio/adc/ad7923.c +++ b/drivers/iio/adc/ad7923.c @@ -184,7 +184,7 @@ static irqreturn_t ad7923_trigger_handler(int irq, void *p) return IRQ_HANDLED; } -static int ad7923_scan_direct(struct ad7923_state *st, unsigned ch) +static int ad7923_scan_direct(struct ad7923_state *st, unsigned int ch) { int ret, cmd; From patchwork Tue Dec 17 11:11:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Junho X-Patchwork-Id: 11297273 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 637DF17F0 for ; Tue, 17 Dec 2019 11:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 41BC82146E for ; Tue, 17 Dec 2019 11:12:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VYdWIVof" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727402AbfLQLMP (ORCPT ); Tue, 17 Dec 2019 06:12:15 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:33989 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727397AbfLQLMP (ORCPT ); Tue, 17 Dec 2019 06:12:15 -0500 Received: by mail-pj1-f68.google.com with SMTP id j11so4441362pjs.1; Tue, 17 Dec 2019 03:12:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=gLPsXf1M5gmXwUcxazQUZ7xNr2aBinYX1xs0OI9I9S4=; b=VYdWIVofnGsdB2NADPwAXAnESwKkMoKkOvTYlbwhnrqAJEcFL484nJqdgUZXzlF7te MZLtp+rCqg5BmIznBO6kuqppjFnxsaNCiq6ByVD8ntKa/s0O/mVr7d+BtUiOIngH1TV8 BWCBjeSsGSJV0uQDGPN/ogQdHzM2IWRVTGTDY/DqALc6IKlSNu1MXV9MuuQxBGq2yu10 +M1nc1/hi+NtZ3UzK7mPuyvf2p57XeneskIcsNiXuQPvty0WcDBaD6wTXTukN3kj9gr3 RO6VZeQvhjzePAQLTuXrVaGfMScoRSuYzocPqEsvfbGZHvxB4fkJ/H2gXsy9T/1FGplH 1Yhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gLPsXf1M5gmXwUcxazQUZ7xNr2aBinYX1xs0OI9I9S4=; b=cyhComrKtKIQptgj5feznE2H3y1BSYMsrtUPap1Pg02vbifBkvWVV1F90fwEK4+J+2 6ZOmVBRA8jCkHCznxA2h6rRBAGpKCCd0nrwwKMghqmrxmczxTe6eFpOLQZ7GxiOfYA3Z SEt7RoS2X8qHNFJZcZJcN+o6RYjbPmAaTaLRGslfcLBGaeYNovsL2Eepii2RgAZ6H1mf UnFKWLAk4N2Tb/IEKlS04bNmjGkdllTdyh2h41SHVfhbc7sZtFk8pLmyjDd/Qud53/sK 3m1Ka8eaDiSzkyXprCHYNTLi2/1ouP/ysMxeRk/L24QP/O94poALqt8CUP/+hHfDR2y+ Clog== X-Gm-Message-State: APjAAAVhRiP8X2rtrg2Ax6Rm7oLWkdGqbHtl6rAD/lJberc6w/xPZtyC W8byRqatumXuvpY9gix0cnw= X-Google-Smtp-Source: APXvYqxxtDdg7H7hS9kzLrmzUSDsgQEaNfS2QkpewoXAmH/+9UFHymPBTndK7/foHeWlYvdLwA3ltg== X-Received: by 2002:a17:90a:9dc3:: with SMTP id x3mr5276099pjv.45.1576581134621; Tue, 17 Dec 2019 03:12:14 -0800 (PST) Received: from brcpsddjunho-l.padtec.com.br (apolo.padtec.com.br. [200.228.158.130]) by smtp.gmail.com with ESMTPSA id 81sm25855190pfx.73.2019.12.17.03.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 03:12:14 -0800 (PST) From: Daniel Junho To: "Jonathan Cameron" , "Ardelean, Alexandru" , "Popa, Stefan Serban" , "lkcamp@lists.libreplanetbr.org" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "pmeerw@pmeerw.net" , "knaack.h@gmx.de" , "Hennerich, Michael" , "lars@metafoo.de" Subject: [PATCH v3 3/4] iio: adc: ad7923: Add of_device_id table Date: Tue, 17 Dec 2019 08:11:57 -0300 Message-Id: <20191217111158.30888-4-djunho@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191217111158.30888-1-djunho@gmail.com> References: <20191217111158.30888-1-djunho@gmail.com> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Accomplish device tree compatibility to driver AD7923 by adding of_device_id table and making a subsequent call to MODULE_DEVICE_TABLE. Signed-off-by: Daniel Junho Reviewed-by: Alexandru Ardelean --- drivers/iio/adc/ad7923.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c index e535cec9fc02..6d56fa0b9e30 100644 --- a/drivers/iio/adc/ad7923.c +++ b/drivers/iio/adc/ad7923.c @@ -348,9 +348,19 @@ static const struct spi_device_id ad7923_id[] = { }; MODULE_DEVICE_TABLE(spi, ad7923_id); +static const struct of_device_id ad7923_of_match[] = { + { .compatible = "adi,ad7904", }, + { .compatible = "adi,ad7914", }, + { .compatible = "adi,ad7923", }, + { .compatible = "adi,ad7924", }, + { }, +}; +MODULE_DEVICE_TABLE(of, ad7923_of_match); + static struct spi_driver ad7923_driver = { .driver = { .name = "ad7923", + .of_match_table = ad7923_of_match, }, .probe = ad7923_probe, .remove = ad7923_remove, From patchwork Tue Dec 17 11:11:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Junho X-Patchwork-Id: 11297275 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ECADE921 for ; Tue, 17 Dec 2019 11:12:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1F0D2082E for ; Tue, 17 Dec 2019 11:12:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bIesV/oY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727434AbfLQLMT (ORCPT ); Tue, 17 Dec 2019 06:12:19 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:39470 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727397AbfLQLMS (ORCPT ); Tue, 17 Dec 2019 06:12:18 -0500 Received: by mail-pj1-f66.google.com with SMTP id v11so503677pjb.6; Tue, 17 Dec 2019 03:12:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=J0n454KnKg0Yc+bUS3no/ANTSoAZTXltdRIhNnO6eoo=; b=bIesV/oYgstBVWDyuwRFe1X6bV0ShbctC64iI0sR5AKtWNOJBE5AALWlLCl4o72vnP q56oRYjZNy2HjQ1jkibmnYdf+SL0qxADvzHAn/hJ1+wF7oHtgs0hEjF/7N2DByTqOTZS W+chM93scIqJj1Vg7SguhrGlwDiCOsGeWkTvfbG6GGR0xa0ciBal+cM20HSXWNCcxJPQ sEKGRHZ3XMUj1tDGUQ8bMSNAMrRShgezyfTKLq0fNZ+Qv4OOOJ41VauGb7TB7HWt+FmI vk5wPe+O1iSF1Qcr45jMRauOIiB/eiUt1/7k+7/2GdiAx0c7H2+qSj9rho7821IeuE0t 6IdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J0n454KnKg0Yc+bUS3no/ANTSoAZTXltdRIhNnO6eoo=; b=c3Sp81wDb2yIhT4KX35GogENm1AKG3mnIuJOb+ONMPdCWVSbcwEVZbvCn+NRnOigb/ 3Bcq5oBWK0ZSRIybE+6jdejllh+G7/xw9A+Eqhw7CSvsE6MjuhcScvPL8wUj9y0r90Cd VDICnpMtS3AyOVr3L4+2aTLqP2qWafi208MiTr4MZ1/zIE6632jXZ8gSi9m/H8zu1/Gi SaExVHsJuMN5ZZ5dJ+m+HTh9YXv/vhFKO/t9Mii+oBhmoVvxz1J1Yf4/0TzwMUdodtv1 FGOInHgju2y6oQdl2U6fui1NUbMBFpszaOTqp3UP3RclqOjiVIfRTtjZ66yAfGzwBWyy N/xw== X-Gm-Message-State: APjAAAXxab7O3Xyg8pYpmx/5kzfWQFBu04S8GEr5RN9nhkYA7WJnat0G i0q/fnS/aMugIdVB1PeAXO8= X-Google-Smtp-Source: APXvYqz3ETSIvhjvJN/qT4R3kYd+peU/mNtmbK96NtL5LTuU+DeVmBRk0OVJOE0sPObNFMQbDQHDqQ== X-Received: by 2002:a17:90a:20c4:: with SMTP id f62mr5470172pjg.70.1576581137900; Tue, 17 Dec 2019 03:12:17 -0800 (PST) Received: from brcpsddjunho-l.padtec.com.br (apolo.padtec.com.br. [200.228.158.130]) by smtp.gmail.com with ESMTPSA id 81sm25855190pfx.73.2019.12.17.03.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 03:12:17 -0800 (PST) From: Daniel Junho To: "Jonathan Cameron" , "Ardelean, Alexandru" , "Popa, Stefan Serban" , "lkcamp@lists.libreplanetbr.org" , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "pmeerw@pmeerw.net" , "knaack.h@gmx.de" , "Hennerich, Michael" , "lars@metafoo.de" Subject: [PATCH v3 4/4] iio: adc: ad7923: Add support for the ad7908/ad7918/ad7928 Date: Tue, 17 Dec 2019 08:11:58 -0300 Message-Id: <20191217111158.30888-5-djunho@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191217111158.30888-1-djunho@gmail.com> References: <20191217111158.30888-1-djunho@gmail.com> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The ad7928 is software compatible with the ad7923. The ad7908 and ad7918 are the 8 and 10-bit versions of the ad7928. Signed-off-by: Daniel Junho Reviewed-by: Alexandru Ardelean --- drivers/iio/adc/ad7923.c | 57 +++++++++++++++++++++++++++++++++++----- 1 file changed, 50 insertions(+), 7 deletions(-) diff --git a/drivers/iio/adc/ad7923.c b/drivers/iio/adc/ad7923.c index 6d56fa0b9e30..1077036d1ed8 100644 --- a/drivers/iio/adc/ad7923.c +++ b/drivers/iio/adc/ad7923.c @@ -1,6 +1,6 @@ // SPDX-License-Identifier: GPL-2.0-only /* - * AD7904/AD7914/AD7923/AD7924 SPI ADC driver + * AD7904/AD7914/AD7923/AD7924/AD7908/AD7918/AD7928 SPI ADC driver * * Copyright 2011 Analog Devices Inc (from AD7923 Driver) * Copyright 2012 CS Systemes d'Information @@ -29,11 +29,13 @@ #define AD7923_PM_MODE_AS (1) /* auto shutdown */ #define AD7923_PM_MODE_FS (2) /* full shutdown */ #define AD7923_PM_MODE_OPS (3) /* normal operation */ -#define AD7923_SEQUENCE_OFF (0) /* no sequence fonction */ -#define AD7923_SEQUENCE_PROTECT (2) /* no interrupt write cycle */ -#define AD7923_SEQUENCE_ON (3) /* continuous sequence */ -#define AD7923_MAX_CHAN 4 +#define AD7923_SEQUENCE_OFF (0x00) /* no sequence function */ +#define AD7908_SEQUENCE_SHADOW (0x01) /* use the shadow register + * for programming + */ +#define AD7923_SEQUENCE_PROTECT (0x10) /* no interrupt write cycle */ +#define AD7923_SEQUENCE_ON (0x11) /* continuous sequence */ #define AD7923_PM_MODE_WRITE(mode) ((mode) << 4) /* write mode */ #define AD7923_CHANNEL_WRITE(channel) ((channel) << 6) /* write channel */ @@ -74,6 +76,9 @@ enum ad7923_id { AD7904, AD7914, AD7924, + AD7908, + AD7918, + AD7928 }; #define AD7923_V_CHAN(index, bits) \ @@ -102,9 +107,25 @@ const struct iio_chan_spec name ## _channels[] = { \ IIO_CHAN_SOFT_TIMESTAMP(4), \ } +#define DECLARE_AD7908_CHANNELS(name, bits) \ +const struct iio_chan_spec name ## _channels[] = { \ + AD7923_V_CHAN(0, bits), \ + AD7923_V_CHAN(1, bits), \ + AD7923_V_CHAN(2, bits), \ + AD7923_V_CHAN(3, bits), \ + AD7923_V_CHAN(4, bits), \ + AD7923_V_CHAN(5, bits), \ + AD7923_V_CHAN(6, bits), \ + AD7923_V_CHAN(7, bits), \ + IIO_CHAN_SOFT_TIMESTAMP(8), \ +} + static DECLARE_AD7923_CHANNELS(ad7904, 8); static DECLARE_AD7923_CHANNELS(ad7914, 10); static DECLARE_AD7923_CHANNELS(ad7924, 12); +static DECLARE_AD7908_CHANNELS(ad7908, 8); +static DECLARE_AD7908_CHANNELS(ad7918, 10); +static DECLARE_AD7908_CHANNELS(ad7928, 12); static const struct ad7923_chip_info ad7923_chip_info[] = { [AD7904] = { @@ -119,6 +140,18 @@ static const struct ad7923_chip_info ad7923_chip_info[] = { .channels = ad7924_channels, .num_channels = ARRAY_SIZE(ad7924_channels), }, + [AD7908] = { + .channels = ad7908_channels, + .num_channels = ARRAY_SIZE(ad7908_channels), + }, + [AD7918] = { + .channels = ad7918_channels, + .num_channels = ARRAY_SIZE(ad7918_channels), + }, + [AD7928] = { + .channels = ad7928_channels, + .num_channels = ARRAY_SIZE(ad7928_channels), + }, }; /** @@ -131,7 +164,11 @@ static int ad7923_update_scan_mode(struct iio_dev *indio_dev, int i, cmd, len; len = 0; - for_each_set_bit(i, active_scan_mask, AD7923_MAX_CHAN) { + /* + * For this driver the last channel is always the software timestamp so + * skip that one. + */ + for_each_set_bit(i, active_scan_mask, indio_dev->num_channels - 1) { cmd = AD7923_WRITE_CR | AD7923_CHANNEL_WRITE(i) | AD7923_SEQUENCE_WRITE(AD7923_SEQUENCE_OFF) | st->settings; @@ -344,6 +381,9 @@ static const struct spi_device_id ad7923_id[] = { {"ad7914", AD7914}, {"ad7923", AD7924}, {"ad7924", AD7924}, + {"ad7908", AD7908}, + {"ad7918", AD7918}, + {"ad7928", AD7928}, {} }; MODULE_DEVICE_TABLE(spi, ad7923_id); @@ -353,6 +393,9 @@ static const struct of_device_id ad7923_of_match[] = { { .compatible = "adi,ad7914", }, { .compatible = "adi,ad7923", }, { .compatible = "adi,ad7924", }, + { .compatible = "adi,ad7908", }, + { .compatible = "adi,ad7918", }, + { .compatible = "adi,ad7928", }, { }, }; MODULE_DEVICE_TABLE(of, ad7923_of_match); @@ -370,5 +413,5 @@ module_spi_driver(ad7923_driver); MODULE_AUTHOR("Michael Hennerich "); MODULE_AUTHOR("Patrick Vasseur "); -MODULE_DESCRIPTION("Analog Devices AD7904/AD7914/AD7923/AD7924 ADC"); +MODULE_DESCRIPTION("Analog Devices AD7923 and similar ADC"); MODULE_LICENSE("GPL v2");