From patchwork Fri Dec 20 10:17:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 11305133 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 194D814F6 for ; Fri, 20 Dec 2019 10:17:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBF1024686 for ; Fri, 20 Dec 2019 10:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837063; bh=Ck3ilHyvx6XvHA65br3cwI6dDkzvtwpztH+Uhmy2tGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=lyykzbKIP714Z4svvyZb4uNkOnxoY6rSCh5szqa2i+iHpR7cYtd8wk651/8V5Qw/j UD4sdq2QyLnWsO4PI/EUi9XFHA2jcE4bHtYVLvvSW2pX2GexvyGVI7CZ6C2qfS2/Cq /IX9akHBWlMKOiVgSP6HNQm2RXTumlHedKhg8XT0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726210AbfLTKRm (ORCPT ); Fri, 20 Dec 2019 05:17:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:53056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727347AbfLTKRm (ORCPT ); Fri, 20 Dec 2019 05:17:42 -0500 Received: from localhost.localdomain (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C32424682; Fri, 20 Dec 2019 10:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837061; bh=Ck3ilHyvx6XvHA65br3cwI6dDkzvtwpztH+Uhmy2tGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B/zZDE4n02b82w4qCokUUQjSkUgLZwjv5e9nYqSUAfE2q2owaqqvaS3AF/cUOvdjo g5afNUbO3sB9dU/TtmkVlAQ8BVSKRaVjvOhcwUfVlDkdaxp72791c0zBTYM3nZZsls ty+wyajBHF3lWNajncHVZ6hMXVgq6u63SMDr45JU= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org, Evan Green , Vinod Koul Subject: [PATCH v2 1/5] phy: qcom-qmp: Increase PHY ready timeout Date: Fri, 20 Dec 2019 15:47:15 +0530 Message-Id: <20191220101719.3024693-2-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191220101719.3024693-1-vkoul@kernel.org> References: <20191220101719.3024693-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org From: Bjorn Andersson It's typical for the QHP PHY to take slightly above 1ms to initialize, so increase the timeout of the PHY ready check to 10ms - as already done in the downstream PCIe driver. Signed-off-by: Bjorn Andersson Tested-by: Evan Green Tested-by: Vinod Koul Signed-off-by: Vinod Koul --- drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 091e20303a14..66f91726b8b2 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -66,7 +66,7 @@ /* QPHY_V3_PCS_MISC_CLAMP_ENABLE register bits */ #define CLAMP_EN BIT(0) /* enables i/o clamp_n */ -#define PHY_INIT_COMPLETE_TIMEOUT 1000 +#define PHY_INIT_COMPLETE_TIMEOUT 10000 #define POWER_DOWN_DELAY_US_MIN 10 #define POWER_DOWN_DELAY_US_MAX 11 From patchwork Fri Dec 20 10:17:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 11305135 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9474314F6 for ; Fri, 20 Dec 2019 10:17:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 739B624687 for ; Fri, 20 Dec 2019 10:17:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837066; bh=AIPv8fFMMsHNljU/EUBaNwyln0JkI1Y+vYsA84xKH64=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=H/H2nzsJ5Mx5Gi0MC+AXHjYhLQHaLTAnritSUc5vR+LP5OfYHB6C6JsChhYsPdfHG qap6Vm5Vzsrh/mtRGlUcC3FjNCmLgalXIsmDprGsTqyHyS2sCiEtKSW5VnotGVOEyZ ImGCvqaPUvspsL+Ed0Bli39CE/F5hCMcZP2olaWk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727347AbfLTKRp (ORCPT ); Fri, 20 Dec 2019 05:17:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:53130 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727327AbfLTKRp (ORCPT ); Fri, 20 Dec 2019 05:17:45 -0500 Received: from localhost.localdomain (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2E8222467F; Fri, 20 Dec 2019 10:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837065; bh=AIPv8fFMMsHNljU/EUBaNwyln0JkI1Y+vYsA84xKH64=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lJ2ORSCcvS0TR3JABMss3CAEJC3xAKGknJykh0LoIk5dx0J0UPB43q/DMBs6PrBKi PXMqsiEGCg+owBLOM1D2EwPPFLdjpR3dPwyypumyWNwRmg7bSNmTH3twyQPkJaZ5ee ZNqaxsY4DJSjS3aHU1tT9VQ/boEd74NXpRR/B9mU= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: [PATCH v2 2/5] phy: qcom-qmp: Use register defines Date: Fri, 20 Dec 2019 15:47:16 +0530 Message-Id: <20191220101719.3024693-3-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191220101719.3024693-1-vkoul@kernel.org> References: <20191220101719.3024693-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org We already define register offsets so use them in register layout. Signed-off-by: Vinod Koul Reviewed-by: Jeffrey Hugo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 66f91726b8b2..1196c85aa023 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -166,8 +166,8 @@ static const unsigned int sdm845_ufsphy_regs_layout[] = { }; static const unsigned int sm8150_ufsphy_regs_layout[] = { - [QPHY_START_CTRL] = 0x00, - [QPHY_PCS_READY_STATUS] = 0x180, + [QPHY_START_CTRL] = QPHY_V4_PHY_START, + [QPHY_PCS_READY_STATUS] = QPHY_V4_PCS_READY_STATUS, }; static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = { From patchwork Fri Dec 20 10:17:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 11305137 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 855DF13B6 for ; Fri, 20 Dec 2019 10:17:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6348324686 for ; Fri, 20 Dec 2019 10:17:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837070; bh=9y+vE6be/fQg89xEmZaoRg10l2d1ad2HMwJK38tcPPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=XaN6eRQgDlFVW9K+T6I24bMYP6nW0mTIGJ80J5wyYHIR9OjbRz5fuVbBA830Eaxlb 7FoEbSqb4Uya41MXepBzP1FySypdRXpmXiSI7jWRJb5hsC7KHZBpCAo7Vsd2RdDwwz haAEgSNgm8VckE5FZuIKpPNliPJHkOWfHjE1LoeE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727276AbfLTKRt (ORCPT ); Fri, 20 Dec 2019 05:17:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:53184 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727327AbfLTKRt (ORCPT ); Fri, 20 Dec 2019 05:17:49 -0500 Received: from localhost.localdomain (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC00F24685; Fri, 20 Dec 2019 10:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837068; bh=9y+vE6be/fQg89xEmZaoRg10l2d1ad2HMwJK38tcPPo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pek5gpwXHKbqG0cPWLKoN1eHZXptlJROT1u799eqAhU4dZ5tI1/IKP2caoTQHk2b4 nEG/JO1B2/yVpEub4V/AnObpUSzvwqMjIQZDuERG9q+WxHIWCEqGwGislHMT43+NVx iKtMWxDgRTJwtqr8k70e6DXf3K8T/rRJi2qz4ZGc= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: [PATCH v2 3/5] phy: qcom-qmp: Add optional SW reset Date: Fri, 20 Dec 2019 15:47:17 +0530 Message-Id: <20191220101719.3024693-4-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191220101719.3024693-1-vkoul@kernel.org> References: <20191220101719.3024693-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org For V4 QMP UFS Phy, we need to assert reset bits, configure the phy and then deassert it, so add optional has_sw_reset flag and use that to configure the QPHY_SW_RESET register. Signed-off-by: Vinod Koul --- drivers/phy/qualcomm/phy-qcom-qmp.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 1196c85aa023..47a66d55107d 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -168,6 +168,7 @@ static const unsigned int sdm845_ufsphy_regs_layout[] = { static const unsigned int sm8150_ufsphy_regs_layout[] = { [QPHY_START_CTRL] = QPHY_V4_PHY_START, [QPHY_PCS_READY_STATUS] = QPHY_V4_PCS_READY_STATUS, + [QPHY_SW_RESET] = QPHY_V4_SW_RESET, }; static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = { @@ -1023,6 +1024,9 @@ struct qmp_phy_cfg { /* true, if PCS block has no separate SW_RESET register */ bool no_pcs_sw_reset; + + /* true if sw reset needs to be invoked */ + bool has_sw_reset; }; /** @@ -1391,6 +1395,7 @@ static const struct qmp_phy_cfg sm8150_ufsphy_cfg = { .is_dual_lane_phy = true, .no_pcs_sw_reset = true, + .has_sw_reset = true, }; static void qcom_qmp_phy_configure(void __iomem *base, @@ -1475,6 +1480,9 @@ static int qcom_qmp_phy_com_init(struct qmp_phy *qphy) SW_USB3PHY_RESET_MUX | SW_USB3PHY_RESET); } + if (cfg->has_sw_reset) + qphy_setbits(pcs, cfg->regs[QPHY_SW_RESET], SW_RESET); + if (cfg->has_phy_com_ctrl) qphy_setbits(serdes, cfg->regs[QPHY_COM_POWER_DOWN_CONTROL], SW_PWRDN); @@ -1651,6 +1659,9 @@ static int qcom_qmp_phy_enable(struct phy *phy) if (cfg->has_phy_dp_com_ctrl) qphy_clrbits(dp_com, QPHY_V3_DP_COM_SW_RESET, SW_RESET); + if (cfg->has_sw_reset) + qphy_clrbits(pcs, cfg->regs[QPHY_SW_RESET], SW_RESET); + /* start SerDes and Phy-Coding-Sublayer */ qphy_setbits(pcs, cfg->regs[QPHY_START_CTRL], cfg->start_ctrl); From patchwork Fri Dec 20 10:17:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 11305139 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 83A6513B6 for ; Fri, 20 Dec 2019 10:17:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 616E324682 for ; Fri, 20 Dec 2019 10:17:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837074; bh=gWCt3r6TgCbriGXQfdsqIUuQ6iWj5AjVkeFPdeu1DoU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=nyjXjMBgH/pK8CNMUmeS5AlNrapwRwLO6WESzf1FHvxSDwUp4Bbg8P21wanwBvzWQ Iz9m7+KAIg3pkAcKa1OznPwvvFKc57ZfSSNgyU/tSJ3PnH5KxMuUSHrY9jSiPcFfQs lzDBLGMVqOn0/p/iLqyoI63GEa5tOch17nMfm83Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727437AbfLTKRx (ORCPT ); Fri, 20 Dec 2019 05:17:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:53258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727327AbfLTKRw (ORCPT ); Fri, 20 Dec 2019 05:17:52 -0500 Received: from localhost.localdomain (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 358CC2467F; Fri, 20 Dec 2019 10:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837072; bh=gWCt3r6TgCbriGXQfdsqIUuQ6iWj5AjVkeFPdeu1DoU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zzBFMGgg36f7Qz2mrSyFRGxf0x4yGX+0VdWzI4numDiw5hJUtlw7aYyeXaoBwrMkK N1kbStn7uv2wCg5ZUgqAVV3bf8uiIZ3MKEUGSi7Z8zAskEwmqEoq2eKxk6kfVULp14 Y22Sn0XfWMpD+VJEPP37lGD/X1JCRJXzBVuVHtG0= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: [PATCH v2 4/5] phy: qcom-qmp: remove duplicate powerdown write Date: Fri, 20 Dec 2019 15:47:18 +0530 Message-Id: <20191220101719.3024693-5-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191220101719.3024693-1-vkoul@kernel.org> References: <20191220101719.3024693-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org We already write to QPHY_POWER_DOWN_CONTROL in qcom_qmp_phy_com_init() before invoking qcom_qmp_phy_configure() so remove the duplicate write. Signed-off-by: Vinod Koul Reviewed-by: Jeffrey Hugo Reviewed-by: Can Guo --- drivers/phy/qualcomm/phy-qcom-qmp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 47a66d55107d..2a12a0b3bd72 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -886,7 +886,6 @@ static const struct qmp_phy_init_tbl msm8998_usb3_pcs_tbl[] = { }; static const struct qmp_phy_init_tbl sm8150_ufsphy_serdes_tbl[] = { - QMP_PHY_INIT_CFG(QPHY_POWER_DOWN_CONTROL, 0x01), QMP_PHY_INIT_CFG(QSERDES_V4_COM_SYSCLK_EN_SEL, 0xd9), QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_SEL, 0x11), QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_HS_SWITCH_SEL, 0x00), From patchwork Fri Dec 20 10:17:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 11305141 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 47B6814F6 for ; Fri, 20 Dec 2019 10:18:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2526324682 for ; Fri, 20 Dec 2019 10:18:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837081; bh=WDlz/eaahcbrJ7H+D15Kf/SYPxCgh/g8ow8gZBeOjYM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=COC77H9u0wkZjht/qkTRLxWoi6l4D+3fz5lV2PfZ0nrj7xmjp/dkWr0Pj9F3KlFl7 BLqr+dU3528bLNS/Crf9ORqJphmV58L1crGbNiD0VuxdD9DHPFbNWhguuPYS8G832l QEmwqVeyVjVQpmFbMewh9EgEU2XIhIzsqZytYyTA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727452AbfLTKR4 (ORCPT ); Fri, 20 Dec 2019 05:17:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:53354 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727327AbfLTKR4 (ORCPT ); Fri, 20 Dec 2019 05:17:56 -0500 Received: from localhost.localdomain (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B3AEC24683; Fri, 20 Dec 2019 10:17:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576837075; bh=WDlz/eaahcbrJ7H+D15Kf/SYPxCgh/g8ow8gZBeOjYM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CKgzrY8lQJgst6jMMwjLnhJx/QOO63BykHJmIpDRSHgezSg5UJ+HZ44h9hQUB0RLj rGzPL+MXbubTsausxdVAYQJ5Z/xDnqUPaf30y6Uow24kKY2pc2/jTOSNZF2Q9EsStK qn0IF9kqEMc7+mGi40jmvLEAsShryp065uWyVSU8= From: Vinod Koul To: Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Vinod Koul , Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: [PATCH v2 5/5] phy: qcom-qmp: remove no_pcs_sw_reset for sm8150 Date: Fri, 20 Dec 2019 15:47:19 +0530 Message-Id: <20191220101719.3024693-6-vkoul@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191220101719.3024693-1-vkoul@kernel.org> References: <20191220101719.3024693-1-vkoul@kernel.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org SM8150 QMPY phy for UFS and onwards the PHY_SW_RESET is present in PHY's PCS register so we should not mark no_pcs_sw_reset for sm8150 and onwards Signed-off-by: Vinod Koul --- drivers/phy/qualcomm/phy-qcom-qmp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c index 2a12a0b3bd72..2696640ee3f9 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c @@ -1393,7 +1393,6 @@ static const struct qmp_phy_cfg sm8150_ufsphy_cfg = { .pwrdn_ctrl = SW_PWRDN, .is_dual_lane_phy = true, - .no_pcs_sw_reset = true, .has_sw_reset = true, };