From patchwork Thu Jan 2 17:27:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Klinger X-Patchwork-Id: 11315973 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 78955109A for ; Thu, 2 Jan 2020 17:28:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 602F421835 for ; Thu, 2 Jan 2020 17:28:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727859AbgABR2L (ORCPT ); Thu, 2 Jan 2020 12:28:11 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:43099 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727422AbgABR2K (ORCPT ); Thu, 2 Jan 2020 12:28:10 -0500 Received: from localhost ([31.212.60.142]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MXXdn-1jELFl2hBv-00Z0ZR; Thu, 02 Jan 2020 18:27:54 +0100 Date: Thu, 2 Jan 2020 18:27:51 +0100 From: Andreas Klinger To: jic23@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, rpi-receiver@htl-steyr.ac.at, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: devantech-srf04.yaml: add pm feature Message-ID: <20200102172749.v7ufupd32ytf7jda@arbad> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) X-Provags-ID: V03:K1:twtpBPb9KWROwZySwiuyXDwXX6qeWA5mWAW+x4wn8wM67nRTwe6 ZSlxkH4GwZxwh9CdipN/SmD6ekPysE5S3lJFpSOcJnObfiRAYmgJ5sIs6syghn+4D6EFMG0 8UtCLK4fKNz/Hx6vfE4ves9pTCoZJqw/515et4d7qHl4yxksK9h6TOvKxfChoYvcBRm2JIF +rTX7ZheKNDF/k+iKOb5g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:2JbhkBLaumQ=:Q3nFZQ78naGyBYH/muDFpn iS0Sx6w/fx2srMl805v4vMjmID0mhYyGxWP7NsRDigFRJ3qmL/aSxnCzjao1dkWqaaaqLr/lX 08ciheX2GqCquQAJ5Hql4YZkBGakg+Y4BN5Vwk/Fh2AkIRA+fjKMwMTu7ivD7/0Mynw+xBboq 4Bn9WvSfA3845ST8EX6bdT6quHQlqJbjeMbRpmYAArzUnf1y5cKeN2dCL2kolWlnvdNgnKUSp piyOqgGWVSDua0yP5MnSDnnfmgw+7OwHtwcvfGdhW8mxmndJYcRWO4rHLkkJqbYNAwJ54RiVg WwZMAmdCFFDcIzCIMcbcv0FNp1NLd6I/0RjOPAFICSad/37bCyrncgE1ieboEGyAEaj7YKrxQ r0CQ4yG8hC46ZYkKa0wPgD7K7ykQMpbx2aPRZCEZh/9uGLfdTC0hEdOIsxCLbQ3bUDDS7Ut7E lEXogP/R9nre+/thSfa8AIgJrMRzfHe9bAs0DeG6S8DdLQt8mhlKZkPnIs8bhUDY33oaDT2XR vLK7670P0uMXnHbRcPFwp4IIyr7HIBiXNR7sJWTVhSp8kCau2zPMNW91Tkq2k82oJZ1XfqMRu BkwKdnotgjz3qedfAU87LrQ1aE5tbR5N8u7swtE7Jxmfcfa3THNaCCeBjObA+sLvdC9u6aN3s /0Oi5+FbVBkSEMnvkcaQCYBI/k3BSLeFqyRCLUXFyX1TkgnQ8hka29pKFVIV95O41ecBz8WcN 2dV4iURGK6sGO3U3Z/wEFfL9EhwJQz9IM+VFW7aPaKDqs9JlQ8scPgWsl+NxL09bOxVNUV137 rvYAIgEnTB1xc091CRvKFPULipJM+qgotmoGzxkbhbVPJwaH2q6dGA5EY+L03LMjI6glsJUc1 wgMBmIIViuJN6LVnw8Bw== Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Add GPIO line and startup time for usage of power management Signed-off-by: Andreas Klinger --- .../bindings/iio/proximity/devantech-srf04.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml index 4e80ea7c1475..b3fcb3b79485 100644 --- a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml +++ b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml @@ -51,6 +51,22 @@ properties: the time between two interrupts is measured in the driver. maxItems: 1 + power-gpios: + description: + Definition of the GPIO for power management of connected peripheral + (output). + This GPIO can be used by the external hardware for power management. + When the device gets suspended it's switched off and when it resumes + it's switched on again. After some period of inactivity the driver + get suspended automatically (autosuspend feature). + maxItems: 1 + + startup-time-ms: + $ref: /schemas/types.yaml#/definitions/uint32 + description: + This is the startup time the device needs after a resume to be up and + running. + required: - compatible - trig-gpios From patchwork Thu Jan 2 17:28:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andreas Klinger X-Patchwork-Id: 11315975 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A92061395 for ; Thu, 2 Jan 2020 17:29:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87268217F4 for ; Thu, 2 Jan 2020 17:29:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727770AbgABR3B (ORCPT ); Thu, 2 Jan 2020 12:29:01 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:54221 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727422AbgABR3A (ORCPT ); Thu, 2 Jan 2020 12:29:00 -0500 Received: from localhost ([31.212.60.142]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MKsSj-1j1huT06wf-00LJ2m; Thu, 02 Jan 2020 18:28:44 +0100 Date: Thu, 2 Jan 2020 18:28:43 +0100 From: Andreas Klinger To: jic23@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, rpi-receiver@htl-steyr.ac.at, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] iio: srf04: add power management feature Message-ID: <20200102172841.iv2ej5gtnufkqmll@arbad> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) X-Provags-ID: V03:K1:kpxqvnxU/14xcISH9Vs4iYpjFPgF+e9DupLuJTMB0sPPmTuFfud S2LZ5n1tFEL4LNDrnQGsnwWfvD1DTBBTHAFY4jzWpNEZgi7RGMExP4uWPF1R5edYZFUgY1I zMoTuZHxzLMrJEgBaH8ucLa+YbFz1sdexbtBlGslHM5d/6Jk8cYU96QI+tlL3vRBAxhfiHL QbAU13R5vtI94dXfD8urQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:HWY5LQvu8DU=:1ozE28T7Iwzi4a3NmLbjh2 PFOus3z0uNkvKELjeyyQhBgBjDebgZNUsr80G+IYss1EUb1ZPeJ5qt8VCIWVa7MJgIsmt5OwO e/H/VJoX0kx+QFbRxup1BAiFKcfwqg8zpS6C1N7tZl0aIqHpSoCyOfM1i5c1teIRsBkpnesmP q1WhrP8UIY0v2b4/90+KvDMusmByRBSiB4gPPv494hoRLek0Pmb15iZ1N/EY96eZlPO63BoBs XcwAdixWdsyntr1lp+FoWjMS8FIjctm5QjdE6yVyvTzzLu0bJqEfjlbiJ8XTD/DFmruX7EtwI o+pPsYHuR61NQbeutVHPmc658Gjbsp30JKCk6pIwsCv0lIOaNU6HF8VWllz4kt7DKs8/RUoJe vQrTfogUZQjpEUDXVSu7Mntxh3uOU60VIcb/u4uLh0VsozcvUc8/MaVqk4izsUVaTYteZFpmP So40h6UwKr9ropaiBJasLm7/PawRSleyIRL7pBUnRjiB3RrXJ953D5yTnaSxs/4MDFbtmEebD /0GCZHrT2i7ZSQKQ4wFbiWECCl3dUEhfytdfYK90CgbcIol3QRjj9u+DdjqwJ7vp4U03R76UU Sx8AJ4aRUkFBmu03qdAt4fvixrMNtlZ1RTR+wswHf6aI4pqiVjk+y2VnbPXPvLsHo+HWkAPZ/ cY6oZ1R09MrI800KjDJCStTpp3ABX4/Vr745AZeV+6MU0lWne+MmudfYRpNeHpOTxdro1+cRe SPrk3rFQgNFuhawm+JtNuiw913tnMR7/J0H4sDnJk3svuO9l1D/Wlbh3U5vQAV7oaDRA2fV4Y bhhkKcjYOZzkPR3Kcv1xIleYZalVfHnmb9mJXjOvc3/c4F4TNSiF00O0uA0jSZ2+bI2eoejqq Iwhh19GB/BOijlT5HTAA== Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Add suspend and resume operations for being used by optional power management. The suspend function is switching off an GPIO which can be used by the hardware to switch power off. The resume function is switching the GPIO on and sleeps an adjustable time to give the device a chance to be up and running. If activated the driver gets into autosuspend after some time of inactivity. Suggested-by: Franz Parzer Signed-off-by: Andreas Klinger --- drivers/iio/proximity/srf04.c | 104 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 103 insertions(+), 1 deletion(-) diff --git a/drivers/iio/proximity/srf04.c b/drivers/iio/proximity/srf04.c index 01eb8cc63076..b19d910298d6 100644 --- a/drivers/iio/proximity/srf04.c +++ b/drivers/iio/proximity/srf04.c @@ -45,6 +45,7 @@ #include #include #include +#include #include #include @@ -56,6 +57,7 @@ struct srf04_data { struct device *dev; struct gpio_desc *gpiod_trig; struct gpio_desc *gpiod_echo; + struct gpio_desc *gpiod_power; struct mutex lock; int irqnr; ktime_t ts_rising; @@ -63,6 +65,7 @@ struct srf04_data { struct completion rising; struct completion falling; const struct srf04_cfg *cfg; + int startup_time_ms; }; static const struct srf04_cfg srf04_cfg = { @@ -97,6 +100,9 @@ static int srf04_read(struct srf04_data *data) u64 dt_ns; u32 time_ns, distance_mm; + if (data->gpiod_power) + pm_runtime_get_sync(data->dev); + /* * just one read-echo-cycle can take place at a time * ==> lock against concurrent reading calls @@ -110,6 +116,11 @@ static int srf04_read(struct srf04_data *data) udelay(data->cfg->trigger_pulse_us); gpiod_set_value(data->gpiod_trig, 0); + if (data->gpiod_power) { + pm_runtime_mark_last_busy(data->dev); + pm_runtime_put_autosuspend(data->dev); + } + /* it should not take more than 20 ms until echo is rising */ ret = wait_for_completion_killable_timeout(&data->rising, HZ/50); if (ret < 0) { @@ -268,6 +279,26 @@ static int srf04_probe(struct platform_device *pdev) return PTR_ERR(data->gpiod_echo); } +#ifdef CONFIG_PM + data->gpiod_power = devm_gpiod_get_optional(dev, "power", + GPIOD_OUT_LOW); + if (IS_ERR(data->gpiod_power)) { + dev_err(dev, "failed to get power-gpios: err=%ld\n", + PTR_ERR(data->gpiod_power)); + return PTR_ERR(data->gpiod_power); + } + if (data->gpiod_power) { + + if (of_property_read_u32(dev->of_node, "startup-time-ms", + &data->startup_time_ms)) + data->startup_time_ms = 100; + dev_dbg(dev, "using power gpio: startup-time-ms=%d\n", + data->startup_time_ms); + } +#else + data->gpiod_power = NULL; +#endif + if (gpiod_cansleep(data->gpiod_echo)) { dev_err(data->dev, "cansleep-GPIOs not supported\n"); return -ENODEV; @@ -296,14 +327,85 @@ static int srf04_probe(struct platform_device *pdev) indio_dev->channels = srf04_chan_spec; indio_dev->num_channels = ARRAY_SIZE(srf04_chan_spec); - return devm_iio_device_register(dev, indio_dev); + ret = iio_device_register(indio_dev); + if (ret < 0) { + dev_err(data->dev, "iio_device_register: %d\n", ret); + return ret; + } + + if (data->gpiod_power) { + pm_runtime_set_autosuspend_delay(data->dev, 1000); + pm_runtime_use_autosuspend(data->dev); + + ret = pm_runtime_set_active(data->dev); + if (ret) { + dev_err(data->dev, "pm_runtime_set_active: %d\n", ret); + iio_device_unregister(indio_dev); + } + + pm_runtime_enable(data->dev); + pm_runtime_idle(data->dev); + } + + return ret; } +static int srf04_remove(struct platform_device *pdev) +{ + struct iio_dev *indio_dev = platform_get_drvdata(pdev); + struct srf04_data *data = iio_priv(indio_dev); + + iio_device_unregister(indio_dev); + + if (data->gpiod_power) { + pm_runtime_disable(data->dev); + pm_runtime_set_suspended(data->dev); + } + + return 0; +} + +#ifdef CONFIG_PM +static int srf04_pm_runtime_suspend(struct device *dev) +{ + struct platform_device *pdev = container_of(dev, + struct platform_device, dev); + struct iio_dev *indio_dev = platform_get_drvdata(pdev); + struct srf04_data *data = iio_priv(indio_dev); + + gpiod_set_value(data->gpiod_power, 0); + + return 0; +} + +static int srf04_pm_runtime_resume(struct device *dev) +{ + struct platform_device *pdev = container_of(dev, + struct platform_device, dev); + struct iio_dev *indio_dev = platform_get_drvdata(pdev); + struct srf04_data *data = iio_priv(indio_dev); + + gpiod_set_value(data->gpiod_power, 1); + msleep(data->startup_time_ms); + + return 0; +} + +static const struct dev_pm_ops srf04_pm_ops = { + SET_RUNTIME_PM_OPS(srf04_pm_runtime_suspend, + srf04_pm_runtime_resume, NULL) +}; +#endif + static struct platform_driver srf04_driver = { .probe = srf04_probe, + .remove = srf04_remove, .driver = { .name = "srf04-gpio", .of_match_table = of_srf04_match, +#ifdef CONFIG_PM + .pm = &srf04_pm_ops, +#endif }, };