From patchwork Fri Jan 10 14:51:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qian Cai X-Patchwork-Id: 11327503 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C87596C1 for ; Fri, 10 Jan 2020 14:51:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 952F92072E for ; Fri, 10 Jan 2020 14:51:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="XvXJIL50" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 952F92072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C3F0A8E0007; Fri, 10 Jan 2020 09:51:19 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id BEE618E0001; Fri, 10 Jan 2020 09:51:19 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADD4D8E0007; Fri, 10 Jan 2020 09:51:19 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id 980DD8E0001 for ; Fri, 10 Jan 2020 09:51:19 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 460595840 for ; Fri, 10 Jan 2020 14:51:19 +0000 (UTC) X-FDA: 76362012678.23.drum08_7fe06da320f1b X-Spam-Summary: 2,0,0,dff00d1eff2b36fe,d41d8cd98f00b204,cai@lca.pw,:akpm@linux-foundation.org:steven.price@arm.com:catalin.marinas@arm.com:will@kernel.org:linux-arm-kernel@lists.infradead.org::linux-kernel@vger.kernel.org:sfr@canb.auug.org.au:cai@lca.pw,RULES_HIT:41:355:379:541:800:960:967:973:988:989:1260:1263:1311:1314:1345:1437:1515:1534:1541:1711:1730:1747:1777:1792:1801:2393:2525:2559:2564:2682:2685:2730:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3865:3867:3872:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4605:5007:6261:6653:7903:8599:8660:9025:9121:10004:10913:11026:11658:11914:12043:12296:12297:12517:12519:12555:12783:12895:12986:13069:13148:13161:13229:13230:13311:13357:13846:13894:14018:14181:14384:14394:14721:14849:21080:21433:21444:21451:21611:21627:30054:30056:30065:30075,0,RBL:209.85.160.195:@lca.pw:.lbl8.mailshell.net-62.14.0.100 66.201.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bu lk,SPF:f X-HE-Tag: drum08_7fe06da320f1b X-Filterd-Recvd-Size: 4796 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Fri, 10 Jan 2020 14:51:18 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id i13so2118073qtr.3 for ; Fri, 10 Jan 2020 06:51:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dP+yKJgC1PvcZ6U9Dq2dx4CeTIqnBT2BpMb+Wm9xBlI=; b=XvXJIL509aqMK2SYSrcuBHs3ubP49aSVcCcSnaLIVODThTeP9V7pW0nppWBOxcYAFa bjB4oOI3tAwc/h00HrwKTxD9G0UO1Lph0w6EKUqapEElolCyhF4Hf6oZ9FjVSetVEUdm O3JiR6QqZ8scDs44UW6b1b7U9cb13OfMwy/gFmwtV9CEegOsqB6RKUc0a72mfBUhejf4 UigXKGLEtJigBM89KHaZovH43iToYo0COVkWVSQ9RFLznGLPm90tlcoKptpf0ur0fUlL DkJf8j4lx18+xVYkPyPNcnU2D3iwCSIoMQdS8fnzDRxhmmNsOI967yfdLiXyWadXNgUa KCGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dP+yKJgC1PvcZ6U9Dq2dx4CeTIqnBT2BpMb+Wm9xBlI=; b=pB2zBr6DCxPWpvJAyNthSUNIfR0JKN4PG5FFRoLk0a1E+GdbGdSimV7yJYQJ8nwOqe 2I248HwZPybzdfNE9stCoudNvxRhlWqEVjfm/b+EmSpGSdDne2KhuNaodbevChRsPRuN mqvw68mMvewOHIds0ZMmWh5EpqAFEnBPmek1XETTAyqRpMWWSzl1227thih1vOtKDipC ZqBIhlFxBeunVozprV5ZlNNIEH7XXR2BlBY2JvrTuU5KLyXfjzmBQG6DozYbfJm7KOoJ RPKsrXWwOr2XX8EgK6vU2M6iYpRdvNhUV/PWyBq5EYf9OgJ479hYlkYT5Tw/Iav74sFp 8pew== X-Gm-Message-State: APjAAAWv/oZ2fMeG3KZJqbMywdUzhCaN+UQnZ3HtDKtHX2WOmnBKBrtu N329as4R0uq2S31rhItmWYYQZg== X-Google-Smtp-Source: APXvYqx9tJ3xrVEVF5uE1eywbilOUQ3Qf7BtHeKw64SIwazRSBjH4hEsmA1DxrDcg6Xwsp77x30DnQ== X-Received: by 2002:aed:3ee5:: with SMTP id o34mr2772503qtf.164.1578667877943; Fri, 10 Jan 2020 06:51:17 -0800 (PST) Received: from ovpn-123-250.rdu2.redhat.com (pool-71-184-117-43.bstnma.fios.verizon.net. [71.184.117.43]) by smtp.gmail.com with ESMTPSA id z4sm1093288qta.73.2020.01.10.06.51.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Jan 2020 06:51:17 -0800 (PST) From: Qian Cai To: akpm@linux-foundation.org Cc: steven.price@arm.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, Qian Cai Subject: [PATCH -next] arm64/mm/dump: fix a compilation error Date: Fri, 10 Jan 2020 09:51:12 -0500 Message-Id: <20200110145112.7959-1-cai@lca.pw> X-Mailer: git-send-email 2.21.0 (Apple Git-122.2) MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The linux-next commit "x86: mm: avoid allocating struct mm_struct on the stack" [1] introduced a compilation error with "arm64: mm: convert mm/dump.c to use walk_page_range()" [2]. Fixed it by using the new API. arch/arm64/mm/dump.c:326:38: error: too few arguments to function call, expected 3, have 2 ptdump_walk_pgd(&st.ptdump, info->mm); ~~~~~~~~~~~~~~~ ^ ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm, pgd_t *pgd); ^ arch/arm64/mm/dump.c:364:38: error: too few arguments to function call, expected 3, have 2 ptdump_walk_pgd(&st.ptdump, &init_mm); ~~~~~~~~~~~~~~~ ^ ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm, pgd_t *pgd); ^ 2 errors generated. [1] http://lkml.kernel.org/r/20200108145710.34314-1-steven.price@arm.com [2] http://lkml.kernel.org/r/20191218162402.45610-22-steven.price@arm.com Signed-off-by: Qian Cai Reviewed-by: Steven Price Acked-by: Will Deacon --- arch/arm64/mm/dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c index ef4b3ca1e058..860c00ec8bd3 100644 --- a/arch/arm64/mm/dump.c +++ b/arch/arm64/mm/dump.c @@ -323,7 +323,7 @@ void ptdump_walk(struct seq_file *s, struct ptdump_info *info) } }; - ptdump_walk_pgd(&st.ptdump, info->mm); + ptdump_walk_pgd(&st.ptdump, info->mm, NULL); } static void ptdump_initialize(void) @@ -361,7 +361,7 @@ void ptdump_check_wx(void) } }; - ptdump_walk_pgd(&st.ptdump, &init_mm); + ptdump_walk_pgd(&st.ptdump, &init_mm, NULL); if (st.wx_pages || st.uxn_pages) pr_warn("Checked W+X mappings: FAILED, %lu W+X pages found, %lu non-UXN pages found\n",