From patchwork Fri Jul 27 03:38:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 10546613 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 072E4112B for ; Fri, 27 Jul 2018 03:38:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E98412BA56 for ; Fri, 27 Jul 2018 03:38:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DA1902BA5B; Fri, 27 Jul 2018 03:38:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8C6402BA56 for ; Fri, 27 Jul 2018 03:38:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725988AbeG0E60 (ORCPT ); Fri, 27 Jul 2018 00:58:26 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:36640 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725828AbeG0E60 (ORCPT ); Fri, 27 Jul 2018 00:58:26 -0400 Received: by mail-pg1-f193.google.com with SMTP id s7-v6so2395293pgv.3; Thu, 26 Jul 2018 20:38:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=DHAPU5UIhScx9JZon8uYOagBreRNQYhap7VuA//AZ3w=; b=Hnr/MehjghF5S1oQ9OnvZBMzVlBsqJmgEdw+MewcnVFVyi5UTtsZ6RLE4SFJ4vwbfT 2jx1iR9P3fjaY839F4k4x8aeu9WJLRd1EcAlHWaQL/NLWwuV1sWsVbQGBeT003Thn8ay 8Fci2bweL0TBJW854YWibG4rjmrjEfgkc0ZvHfszyeh2eb4ZZFXhmGlASBViVSEcals5 KSsNMbCNgC5OrvZPwiPGz99Cd0AjCwaHrnnWuCYcsUn3Ax3ggA0UHJBsx1LVaM0Q3lkN nSWglILxDE2B7fywIVbB8TZUurm68aCTb96Ey5dkvQNX+XE0Lfp/7WYBw/JfM4H9B8Um KkDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=DHAPU5UIhScx9JZon8uYOagBreRNQYhap7VuA//AZ3w=; b=a/6jA1Sot6DjV9OIZtGbvZFjoTeTlSPltSXYmQPd52IWz+jz6fe0YBxPXKGAHHho6e dAAUJTKleB9MtiWsn2vT5TH06WdwGP7WrD64NYSx0U6bGVCsjFP5hhpd5ab+kEhRjRhd HIduLlC1iWeDbUOQs4Lg5E4I3yVUzafn83g6oKtcqWiWaVre7o9Xd+dl9Ppu69OOFrPe IkXuY7ztSgUajHRRZKk2jYDhXkwgoe8Hr0LSeJRlQdhA+MBnElQw+gozDW2TDRI1R4cq GZw8C6x3ml++JD2Db8mhGrLLgebrG/BKiQOdFT8SF4QQjsdhw790tCwJB5a8twtpygPd +1mQ== X-Gm-Message-State: AOUpUlGeSM5Q5Lif76yWZj1/vB1W/TtFWi1yINTIFTt76oxG3Z9BwNGC BbufHPEj3TWQsKpRbN/S+fw87l4H X-Google-Smtp-Source: AAOMgpdFRvm5fxwfRcLIfzNE9OqyDVGmtmafTKC9duywOG5iel4VKLne3wFBhtiqqfFgDd036usI+g== X-Received: by 2002:a65:428b:: with SMTP id j11-v6mr4309697pgp.200.1532662717591; Thu, 26 Jul 2018 20:38:37 -0700 (PDT) Received: from localhost.localdomain ([2402:f000:1:4414:6c14:7712:e625:1be4]) by smtp.gmail.com with ESMTPSA id l185-v6sm3949429pga.65.2018.07.26.20.38.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jul 2018 20:38:37 -0700 (PDT) From: Jia-Ju Bai To: mchehab@kernel.org, hverkuil@xs4all.nl Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH 1/2] media: pci: cx88: Replace mdelay() with msleep() in cx88_card_setup_pre_i2c() Date: Fri, 27 Jul 2018 11:38:23 +0800 Message-Id: <20180727033823.4148-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP cx88_card_setup_pre_i2c() is never called in atomic context. It calls mdelay() to busily wait, which is not necessary. mdelay() can be replaced with msleep(). This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- drivers/media/pci/cx88/cx88-cards.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/cx88/cx88-cards.c b/drivers/media/pci/cx88/cx88-cards.c index 4c92d2388c26..07e1483e987d 100644 --- a/drivers/media/pci/cx88/cx88-cards.c +++ b/drivers/media/pci/cx88/cx88-cards.c @@ -3307,9 +3307,9 @@ static void cx88_card_setup_pre_i2c(struct cx88_core *core) case CX88_BOARD_PROLINK_PV_GLOBAL_XTREME: case CX88_BOARD_PROLINK_PV_8000GT: cx_write(MO_GP2_IO, 0xcf7); - mdelay(50); + msleep(50); cx_write(MO_GP2_IO, 0xef5); - mdelay(50); + msleep(50); cx_write(MO_GP2_IO, 0xcf7); usleep_range(10000, 20000); break; From patchwork Fri Jul 27 03:41:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia-Ju Bai X-Patchwork-Id: 10546615 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DE538112B for ; Fri, 27 Jul 2018 03:41:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C44A228745 for ; Fri, 27 Jul 2018 03:41:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B85052BA5A; Fri, 27 Jul 2018 03:41:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 616B828745 for ; Fri, 27 Jul 2018 03:41:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725964AbeG0FBq (ORCPT ); Fri, 27 Jul 2018 01:01:46 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:40905 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbeG0FBq (ORCPT ); Fri, 27 Jul 2018 01:01:46 -0400 Received: by mail-pl0-f67.google.com with SMTP id s17-v6so1716169plp.7; Thu, 26 Jul 2018 20:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=tpTJPg5QWaipjTJYMVBmNVQXCw0qelx4b/0mN4xIPGo=; b=qRvtAJ/uYnWzRSCk6inyX/P8aZWs7w2HryZrG7XlP3Ywddj3sf5WuQICfBV+MUbG8h sX6dqKRn5PacfOzCqhWfmAsaAfvnVR29eJLXoEOg5ywJPtbIZi609ym+hm//bYkKrj8s aVXILvzsrLKWwMJVkXsvuxDi3yyda8F5zF0v1g+lN++P1Ylu2sTjMpRWRmmZQT0Mt/48 0msuUMglIzLyyUM6UjAMqnh+Ob8xtHZSbb8QerzXxjh/Hy3GrowyP3AnDpZzZM4Vf7rN fat3j0zJkZQSgfmAhj8r/SMqDI81/kjOW7rpBQWJmxRZxJgd6qp3GdlkmBP4TpxAnnzl VZWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=tpTJPg5QWaipjTJYMVBmNVQXCw0qelx4b/0mN4xIPGo=; b=EZz61HGBRhp8Hc5MjZ8Zmww8hQ3qhAbFxCDqYfjSSDdLVVMnnEavkdrAuFxf5On/W/ di1Ixxf7YqoR40LWC8gmm01vaTswcaPG7yX7PbIniV06/zM/Esw09ygOQWANfhA0fgCS Z3zrvI+ubyNCDWxuMc7cqB+u4TorM7d5Xxl1GUx5aMrzCtjwK8ZDb/ZE+r27wP4I7ADf t3eKI19rBWudBEFX5kM+Fn+M0Bqmwz9vJzBikh5P66bQLyReThYvU1dJ8BgQ7aNcTxui I876+DyrbmNvvbT2liGTzOi4lSmyz6pRL87K7NpludE72W4nPij4jqMljNHprwCaE2RR Nhrw== X-Gm-Message-State: AOUpUlHaB9VZKFCUxdf/d6ScZNigt/1XEUydijHb3M98BHaa7UeRKNnQ CbR9KcyebZSpULBv/ZbDyKKEgzc9 X-Google-Smtp-Source: AAOMgpcIdaz2ie+6nsbZSWJj73+v+HTLVRNE/855zt8cJZt8hUhhj1C4msdEsVzIP5u4fOaFfYl10A== X-Received: by 2002:a17:902:aa87:: with SMTP id d7-v6mr4389445plr.215.1532662916484; Thu, 26 Jul 2018 20:41:56 -0700 (PDT) Received: from localhost.localdomain ([2402:f000:1:4414:6c14:7712:e625:1be4]) by smtp.gmail.com with ESMTPSA id d132-v6sm3681147pga.10.2018.07.26.20.41.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Jul 2018 20:41:56 -0700 (PDT) From: Jia-Ju Bai To: mchehab@kernel.org, hverkuil@xs4all.nl Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jia-Ju Bai Subject: [PATCH 2/2] media: pci: cx88: Replace mdelay() with msleep() in dvb_register() Date: Fri, 27 Jul 2018 11:41:50 +0800 Message-Id: <20180727034150.4259-1-baijiaju1990@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP dvb_register() is never called in atomic context. It calls mdelay() to busily wait, which is not necessary. mdelay() can be replaced with msleep(). This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai --- drivers/media/pci/cx88/cx88-dvb.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/media/pci/cx88/cx88-dvb.c b/drivers/media/pci/cx88/cx88-dvb.c index 2f886140dd2e..f350adc94cb8 100644 --- a/drivers/media/pci/cx88/cx88-dvb.c +++ b/drivers/media/pci/cx88/cx88-dvb.c @@ -1229,9 +1229,9 @@ static int dvb_register(struct cx8802_dev *dev) /* Do a hardware reset of chip before using it. */ cx_clear(MO_GP0_IO, 1); - mdelay(100); + msleep(100); cx_set(MO_GP0_IO, 1); - mdelay(200); + msleep(200); /* Select RF connector callback */ fusionhdtv_3_gold.pll_rf_set = lgdt330x_pll_rf_set; @@ -1250,9 +1250,9 @@ static int dvb_register(struct cx8802_dev *dev) /* Do a hardware reset of chip before using it. */ cx_clear(MO_GP0_IO, 1); - mdelay(100); + msleep(100); cx_set(MO_GP0_IO, 9); - mdelay(200); + msleep(200); fe0->dvb.frontend = dvb_attach(lgdt330x_attach, &fusionhdtv_3_gold, &core->i2c_adap); @@ -1268,9 +1268,9 @@ static int dvb_register(struct cx8802_dev *dev) /* Do a hardware reset of chip before using it. */ cx_clear(MO_GP0_IO, 1); - mdelay(100); + msleep(100); cx_set(MO_GP0_IO, 1); - mdelay(200); + msleep(200); fe0->dvb.frontend = dvb_attach(lgdt330x_attach, &fusionhdtv_5_gold, &core->i2c_adap); @@ -1289,9 +1289,9 @@ static int dvb_register(struct cx8802_dev *dev) /* Do a hardware reset of chip before using it. */ cx_clear(MO_GP0_IO, 1); - mdelay(100); + msleep(100); cx_set(MO_GP0_IO, 1); - mdelay(200); + msleep(200); fe0->dvb.frontend = dvb_attach(lgdt330x_attach, &pchdtv_hd5500, &core->i2c_adap); @@ -1582,9 +1582,9 @@ static int dvb_register(struct cx8802_dev *dev) cx_set(MO_GP0_IO, 0x0101); cx_clear(MO_GP0_IO, 0x01); - mdelay(100); + msleep(100); cx_set(MO_GP0_IO, 0x01); - mdelay(200); + msleep(200); fe0->dvb.frontend = dvb_attach(stv0299_attach, &samsung_stv0299_config,