From patchwork Wed Sep 26 06:52:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Pyhalov X-Patchwork-Id: 10615335 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5F53215A6 for ; Wed, 26 Sep 2018 06:52:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4E6A22A608 for ; Wed, 26 Sep 2018 06:52:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 42CA82A61F; Wed, 26 Sep 2018 06:52:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6ABB72A608 for ; Wed, 26 Sep 2018 06:52:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726938AbeIZNDi (ORCPT ); Wed, 26 Sep 2018 09:03:38 -0400 Received: from mail-yb1-f169.google.com ([209.85.219.169]:34313 "EHLO mail-yb1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726377AbeIZNDi (ORCPT ); Wed, 26 Sep 2018 09:03:38 -0400 Received: by mail-yb1-f169.google.com with SMTP id 184-v6so10909722ybg.1 for ; Tue, 25 Sep 2018 23:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=VbW3oxelilY3sGslGcU+1syihWYMGPJVEl+xvkIv0xM=; b=aeCXFcmmXe0kTl0WuCwhRYZ/x9IFnsqruQXP8iuQ5G3KzrGhuh+/zR0y0NFB6yIUOc /ujTdvzhxGc11xPHDwmLbabw+rhTz/JNNFRBYVWpYY9Qy2OpLuvlmSU1soMIRO3rDVaD wSJbEpWG7HB3uEylGYoLXwpUn134lkycCXOWWIqFdtJFwdoYyQCsjmojeDyTMmtxalDx Gvlgc5/kLAtMvAK9ylSi0bKqbuZhDbhjnHtQBbXME7pb+fxrn1gSODrsryae+YtmlvvS waw/tRLv1Djpzi3cN+2DuYj4BPYoyeZY8lF0zc65oIJPQcXR+e61+dSi3/1khgzGJDr7 avOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=VbW3oxelilY3sGslGcU+1syihWYMGPJVEl+xvkIv0xM=; b=QQpAQxbTu/rOZc6aK6FzgOBbDdYq9hKqiERvkJC/5TCs5LoNOBgS0aaWATAPCKHyeA XPvrPaeLfwpSkbyIGA9EyWVK2IVJlqFG20oQjto04vmYZO4BJEBBfbYYzvhk7PUlb63w SBzRzbqq/LiZ0A8ogjlHKINjK1obpKqdHGhSNP98Na38G8qdv/9oNl3Isamb2OlD/wNa 3lsMv7wKI4IOW6B0iZjYGsfBHuXSvLUdMu+8CHk+VzsNF9tspR0MwCJx+4Q2VGYBj1lb H2DlY+RBPesA/cQS90Oau3n3Ed7bHBgc5P/XxaIKFKSBziH/c62vUy5XnHn8qM+sz1XK 523A== X-Gm-Message-State: ABuFfojqbkCeS4p/bmC2qrOLsSkQ8fKE/porQLuChXsvTKh675o6TCFI Cx9DnXQMJuqp4/EIEclovKAAyMO3gfrb7T12f200yQrhKIU= X-Google-Smtp-Source: ACcGV61N58kgjcnEDgU4iPCesJp1ijAaAGIgHw0K2xAtntyjkilhmqbelbcm43tAIllIgTqXlVdOQXL1rWTxdaBXmiQ= X-Received: by 2002:a25:bdcd:: with SMTP id g13-v6mr2348062ybk.253.1537944732795; Tue, 25 Sep 2018 23:52:12 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:248c:0:0:0:0:0 with HTTP; Tue, 25 Sep 2018 23:52:12 -0700 (PDT) From: Alexander Pyhalov Date: Wed, 26 Sep 2018 09:52:12 +0300 Message-ID: Subject: t7005-editor.sh failure To: git@vger.kernel.org Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On updating git to 2.19 we've suddenly got t7005-editor.sh test failures. The issue seems to be that generated "e space.sh" file can't handle files with spaces. Instead of 'echo space >$1' it should be 'echo space > "$1"' or git editor fails when gets file with spaces in name. The patch is simple: Reported-by: Alexander Pyhalov Signed-off-by: Junio C Hamano --- git-2.19.0/t/t7005-editor.sh.~1~ Mon Sep 10 21:39:13 2018 +++ git-2.19.0/t/t7005-editor.sh Wed Sep 26 09:41:30 2018 @@ -112,7 +112,7 @@ done test_expect_success 'editor with a space' ' - echo "echo space >\$1" >"e space.sh" && + echo "echo space > \"\$1\"" > "e space.sh" && chmod a+x "e space.sh" && GIT_EDITOR="./e\ space.sh" git commit --amend && test space = "$(git show -s --pretty=format:%s)"