From patchwork Wed Jan 22 22:32:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11346485 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0D1B91580 for ; Wed, 22 Jan 2020 22:34:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D77A32465A for ; Wed, 22 Jan 2020 22:34:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="S7OsV2F1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D77A32465A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:47810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOa6-0003Eu-Ge for patchwork-qemu-devel@patchwork.kernel.org; Wed, 22 Jan 2020 17:34:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33475) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOYh-0001g2-Ui for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuOYg-0001Qc-Ur for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:11 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:20911 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuOYg-0001PT-QQ for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579732390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=quW2yWOs2j+1PNJl1s6nqMfCGNqNDaRH3YTdjFarJ+U=; b=S7OsV2F1BUGj/PQHlM87EXsmzpbC5yczj1jtDCgwEGXLCiTVj83FF/rQTQl8H251xUgVcI +rY5VUL+KtGDpBMihxTWXaLrpJ4MBgewR3wDRU3vWDSLq0V53PjATU809i6QQlLURfuRS5 QDY9Gmrjg4WQW3Ze1rpS5TLl6b29jp4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-89-pg2VDHO9O9eh2hZdXTdIrQ-1; Wed, 22 Jan 2020 17:33:08 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 972238010CA; Wed, 22 Jan 2020 22:33:07 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-78.brq.redhat.com [10.40.204.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 347DC86446; Wed, 22 Jan 2020 22:33:03 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: "Michael S . Tsirkin" , Denis Plotnikov , qemu-devel@nongnu.org Subject: [PATCH 1/6] tests/acceptance/virtio_seg_max_adjust: Only remove listed machines Date: Wed, 22 Jan 2020 23:32:42 +0100 Message-Id: <20200122223247.30419-2-philmd@redhat.com> In-Reply-To: <20200122223247.30419-1-philmd@redhat.com> References: <20200122223247.30419-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: pg2VDHO9O9eh2hZdXTdIrQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Eduardo Habkost , Stefan Hajnoczi , Cleber Rosa Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Do not remove unavailable machines, this fixes: VirtioMaxSegSettingsCheck.test_machine_types: ERROR: list.remove(x): x not in list (0.12 s) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cornelia Huck --- tests/acceptance/virtio_seg_max_adjust.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_seg_max_adjust.py index 5458573138..4a417b8ef5 100755 --- a/tests/acceptance/virtio_seg_max_adjust.py +++ b/tests/acceptance/virtio_seg_max_adjust.py @@ -109,14 +109,15 @@ class VirtioMaxSegSettingsCheck(Test): return False def test_machine_types(self): - # collect all machine types except 'none', 'isapc', 'microvm' + EXCLUDED_MACHINES = ['none', 'isapc', 'microvm'] + # collect all machine types except the ones in EXCLUDED_MACHINES with QEMUMachine(self.qemu_bin) as vm: vm.launch() machines = [m['name'] for m in vm.command('query-machines')] vm.shutdown() - machines.remove('none') - machines.remove('isapc') - machines.remove('microvm') + for m in EXCLUDED_MACHINES: + if m in machines: + machines.remove(m) for dev_type in DEV_TYPES: # create the list of machine types and their parameters. From patchwork Wed Jan 22 22:32:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11346487 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0F2C217EA for ; Wed, 22 Jan 2020 22:34:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8C202465A for ; Wed, 22 Jan 2020 22:34:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cP2c2IVd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D8C202465A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:47812 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOaE-0003Oa-Ka for patchwork-qemu-devel@patchwork.kernel.org; Wed, 22 Jan 2020 17:34:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33635) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOYm-0001jz-Eo for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuOYk-0001Vp-DP for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:16 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:55866 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuOYk-0001VF-9s for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579732393; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WfbFbjO3CVtH6Hm3NqnkBneFE06NKsCSxcSEnAOyc3g=; b=cP2c2IVdYE+6n/lhP9C5iKmAdt+8AL42ufuB+wsJc3mPVVfUlCV6TeDMzql7wOlfe+myX1 6d2uBICEKmKXIZKfXzgaJ9gn5Z0+RB7Sx6t+tV/cG72KVAtRqtgqSP1cBdI+JFXJ8ndlUy vM8dm1DcK1x5SIU//KSK4Yk3LTlqSsI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-gL9XE_u7M8uIIjvkqQz8Ig-1; Wed, 22 Jan 2020 17:33:12 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3A72EDB60; Wed, 22 Jan 2020 22:33:11 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-78.brq.redhat.com [10.40.204.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6638C845A5; Wed, 22 Jan 2020 22:33:08 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: "Michael S . Tsirkin" , Denis Plotnikov , qemu-devel@nongnu.org Subject: [PATCH 2/6] tests/acceptance/virtio_seg_max_adjust: Improve exception logging Date: Wed, 22 Jan 2020 23:32:43 +0100 Message-Id: <20200122223247.30419-3-philmd@redhat.com> In-Reply-To: <20200122223247.30419-1-philmd@redhat.com> References: <20200122223247.30419-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: gL9XE_u7M8uIIjvkqQz8Ig-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Eduardo Habkost , Stefan Hajnoczi , Cleber Rosa Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/virtio_seg_max_adjust.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_seg_max_adjust.py index 4a417b8ef5..51a2dd76e8 100755 --- a/tests/acceptance/virtio_seg_max_adjust.py +++ b/tests/acceptance/virtio_seg_max_adjust.py @@ -77,8 +77,12 @@ class VirtioMaxSegSettingsCheck(Test): vm.set_machine(mt["name"]) for s in VM_DEV_PARAMS[dev_type_name]: vm.add_args(s) - vm.launch() - query_ok, props, error = self.query_virtqueue(vm, dev_type_name) + try: + vm.launch() + query_ok, props, error = self.query_virtqueue(vm, dev_type_name) + except: + query_ok = False + error = sys.exc_info()[0] if not query_ok: self.fail('machine type {0}: {1}'.format(mt['name'], error)) From patchwork Wed Jan 22 22:32:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11346493 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1619B1580 for ; Wed, 22 Jan 2020 22:38:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E085D2253D for ; Wed, 22 Jan 2020 22:38:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cPaeEQ2F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E085D2253D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:47864 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOdO-0007FU-NZ for patchwork-qemu-devel@patchwork.kernel.org; Wed, 22 Jan 2020 17:38:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33957) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOYy-0001xO-JK for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuOYx-0001la-IZ for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:28 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:43308 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuOYw-0001kG-8g for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579732405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LUDnoyq16U5np06iAFR+GXWOHXUpAtrYy/aZrfRRKw4=; b=cPaeEQ2FIyk9C4fv1dhJyyT9Ywns6mGQrnrUJPn0KB+wx6lMCh30Y03fiIiysInta4VCvO KRdYsW0gpbb8ccr06pEcH+4fWBCVJMvp2OdLbZlga2B0MoGeG+7Lsab0MFoZ5BPuiHhLjl LxEA+qwWZ39Yt9JEhbf7vtMw2d/J8oE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-61-elifdNFq_TCyrRH8-0w-1; Wed, 22 Jan 2020 17:33:22 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 524451800D78; Wed, 22 Jan 2020 22:33:21 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-78.brq.redhat.com [10.40.204.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F190786443; Wed, 22 Jan 2020 22:33:11 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: "Michael S . Tsirkin" , Denis Plotnikov , qemu-devel@nongnu.org Subject: [PATCH 3/6] tests/acceptance/virtio_seg_max_adjust: List machine being tested Date: Wed, 22 Jan 2020 23:32:44 +0100 Message-Id: <20200122223247.30419-4-philmd@redhat.com> In-Reply-To: <20200122223247.30419-1-philmd@redhat.com> References: <20200122223247.30419-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 61-elifdNFq_TCyrRH8-0w-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Eduardo Habkost , Stefan Hajnoczi , Cleber Rosa Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Add logging for easier debugging of failures: $ avocado --show=machine run tests/acceptance/virtio_seg_max_adjust.py (1/1) tests/acceptance/virtio_seg_max_adjust.py:VirtioMaxSegSettingsCheck.test_machine_types: machine: {'name': 'pc-i440fx-2.12', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'} machine: {'name': 'pc-i440fx-2.0', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'} machine: {'name': 'pc-q35-4.2', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'} machine: {'name': 'pc-i440fx-2.5', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'} machine: {'name': 'pc-i440fx-4.2', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'} ... Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/virtio_seg_max_adjust.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_seg_max_adjust.py index 51a2dd76e8..f679b0eec7 100755 --- a/tests/acceptance/virtio_seg_max_adjust.py +++ b/tests/acceptance/virtio_seg_max_adjust.py @@ -21,6 +21,7 @@ import sys import os import re +import logging sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python')) from qemu.machine import QEMUMachine @@ -73,6 +74,9 @@ class VirtioMaxSegSettingsCheck(Test): return query_ok, props, error def check_mt(self, mt, dev_type_name): + mt['device'] = dev_type_name # Only for the debug() call. + logger = logging.getLogger('machine') + logger.debug(mt) with QEMUMachine(self.qemu_bin) as vm: vm.set_machine(mt["name"]) for s in VM_DEV_PARAMS[dev_type_name]: From patchwork Wed Jan 22 22:32:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11346491 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B080B1580 for ; Wed, 22 Jan 2020 22:37:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B7DA2253D for ; Wed, 22 Jan 2020 22:37:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FOmdbkyu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B7DA2253D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:47858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOd1-0006jo-Eh for patchwork-qemu-devel@patchwork.kernel.org; Wed, 22 Jan 2020 17:37:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34066) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOZ3-00022K-BG for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuOZ1-0001qP-Ez for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:32 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:40950 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuOZ1-0001p6-0s for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579732409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JFGQ2SP7BDswGuZiV7ppV32pBVt5j4zcY6wW+AuqMTw=; b=FOmdbkyuyCTijAl44dyvONSgsB+h297L4Iy7QAn0m2u4XeGG+WGmWxGV0g4t3AHgtRq2Sk 5bkvrGp0ALk5d/GeggpZPjfaOOvUgyZY/chdl39TxWjYHkur2a8YEjv5Be7MhDwDnVrUp7 ETInGr9JVMNUfDrsS6NPZKLamsVFyc0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-140-AkDXhuApNEueZLvIu7np6Q-1; Wed, 22 Jan 2020 17:33:26 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E662107ACC5; Wed, 22 Jan 2020 22:33:25 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-78.brq.redhat.com [10.40.204.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 21161845A5; Wed, 22 Jan 2020 22:33:21 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: "Michael S . Tsirkin" , Denis Plotnikov , qemu-devel@nongnu.org Subject: [PATCH 4/6] tests/acceptance/virtio_seg_max_adjust: Only test Xen as superuser Date: Wed, 22 Jan 2020 23:32:45 +0100 Message-Id: <20200122223247.30419-5-philmd@redhat.com> In-Reply-To: <20200122223247.30419-1-philmd@redhat.com> References: <20200122223247.30419-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: AkDXhuApNEueZLvIu7np6Q-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Eduardo Habkost , Stefan Hajnoczi , Cleber Rosa Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" When running the test unprivileged, we get: $ avocado --show=app,machine run tests/acceptance/virtio_seg_max_adjust.py JOB ID : b631d5d692e49b791b211d33b80730315d561d45 JOB LOG : job-results/job-2020-01-22T17.56-b631d5d/job.log (1/1) tests/acceptance/virtio_seg_max_adjust.py:VirtioMaxSegSettingsCheck.test_machine_types: machine: {'name': 'pc-i440fx-2.12', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'} machine: {'name': 'pc-i440fx-2.0', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'} machine: {'name': 'xenpv', 'seg_max_adjust': 'false', 'device': 'virtio-scsi-pci'} FAIL: machine type xenpv: (0.40 s) Looking at the job.log file we find: xencall: error: Could not obtain handle on privileged command interface: No such file or directory xen be core: xen be core: can't open xen interface Do not run this test on Xen machines if not superuser. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Cornelia Huck --- tests/acceptance/virtio_seg_max_adjust.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_seg_max_adjust.py index f679b0eec7..ad736bcda3 100755 --- a/tests/acceptance/virtio_seg_max_adjust.py +++ b/tests/acceptance/virtio_seg_max_adjust.py @@ -118,6 +118,8 @@ class VirtioMaxSegSettingsCheck(Test): def test_machine_types(self): EXCLUDED_MACHINES = ['none', 'isapc', 'microvm'] + if os.geteuid() != 0: + EXCLUDED_MACHINES += ['xenfv', 'xenpv'] # collect all machine types except the ones in EXCLUDED_MACHINES with QEMUMachine(self.qemu_bin) as vm: vm.launch() From patchwork Wed Jan 22 22:32:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11346495 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 00A2B17EA for ; Wed, 22 Jan 2020 22:40:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86AC92253D for ; Wed, 22 Jan 2020 22:40:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Nv+YDu+D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86AC92253D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:47892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOfU-0000pI-Di for patchwork-qemu-devel@patchwork.kernel.org; Wed, 22 Jan 2020 17:40:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34106) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOZ5-00023p-Aw for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuOZ3-0001s5-EG for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:35 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:33890 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuOZ3-0001r8-8x for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579732412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6BfEXEJk/FNg8im5gWHkwQZ/daMJUMlm2g5Q0qhEjXk=; b=Nv+YDu+Dq3DXmv0/oBsRYlL2gwiroboqomRgTeoTfl6NIvcOumdbO1EeS9umTBnRr2iSwU ch+RUQMXYNqXdMptHIXPsA7aNkvI7jdfhOShCUwp7SkunElL1P9M00VOP+FxFTUe+o/IS9 4JvW7WMy+h4xxIDkcKjKMc/20iaNoFs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-111-ArhIvvKeM3uEB4XKBW0mRQ-1; Wed, 22 Jan 2020 17:33:29 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1AAE0DB60; Wed, 22 Jan 2020 22:33:28 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-78.brq.redhat.com [10.40.204.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B2CE8845A5; Wed, 22 Jan 2020 22:33:25 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: "Michael S . Tsirkin" , Denis Plotnikov , qemu-devel@nongnu.org Subject: [PATCH 5/6] tests/acceptance/virtio_seg_max_adjust: Restrict to X86 architecture Date: Wed, 22 Jan 2020 23:32:46 +0100 Message-Id: <20200122223247.30419-6-philmd@redhat.com> In-Reply-To: <20200122223247.30419-1-philmd@redhat.com> References: <20200122223247.30419-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: ArhIvvKeM3uEB4XKBW0mRQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Eduardo Habkost , Stefan Hajnoczi , Cleber Rosa Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Running on mainstream KVM architectures, we get: - Aarch64 Timeout. job.log: ------- No machine specified, and there is no default Use -machine help to list supported machines - MIPS: (1/1) VirtioMaxSegSettingsCheck.test_machine_types: ERROR: argument of type 'NoneType' is not iterable (0.14 s) job.log: ------- Could not load MIPS bios 'mipsel_bios.bin', and no -kernel argument was specified - PowerPC (1/1) VirtioMaxSegSettingsCheck.test_machine_types: ERROR: invalid literal for int() with base 10: 'sxxm' (0.16 s) job.log: ------- >>> {'execute': 'query-machines'} <<< {'return': [{'hotpluggable-cpus': True, 'name': 'pseries-2.12-sxxm', 'numa-mem-supported': True, 'default-cpu-type': 'power8_v2.0-powerpc64-cpu', 'cpu-max': 1024, 'deprecated': False}, ... - S390X: (1/1) VirtioMaxSegSettingsCheck.test_machine_types: ERROR: invalid literal for int() with base 10: 'virtio' (0.14 s) job.log: ------- Traceback (most recent call last): File "virtio_seg_max_adjust.py", line 139, in test_machine_types if self.seg_max_adjust_enabled(m): File "virtio_seg_max_adjust.py", line 113, in seg_max_adjust_enabled major = int(ver[0]) ValueError: invalid literal for int() with base 10: 'virtio' >>> {'execute': 'query-machines'} <<< {'return': [{'hotpluggable-cpus': True, 'name': 's390-ccw-virtio-4.0', 'numa-mem-supported': False, 'default-cpu-type': 'qemu-s390x-cpu', 'cpu-max': 248, 'deprecated': False}, ... Assuming this test is only expected to run on the X86 architecture, restrict the test to this particular architecture. When this test is run on other architecture, the tests will be skipped. Examples: - running on S390X: (1/1) tests/acceptance/virtio_seg_max_adjust.py:VirtioMaxSegSettingsCheck.test_machine_types: SKIP: Architecture 's390' unsupported - running on Aarch64 setting the QEMU binary path: $ uname -m && avocado --show=app run -p qemu_bin=x86_64-softmmu/qemu-system-x86_64 tests/acceptance/virtio_seg_max_adjust.py aarch64 JOB ID : 92b7fae8868920aada0cb143f9571dffdf60931d JOB LOG : job-results/job-2020-01-22T17.54-92b7fae/job.log (1/1) tests/acceptance/virtio_seg_max_adjust.py:VirtioMaxSegSettingsCheck.test_machine_types: PASS (25.99 s) RESULTS : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0 JOB TIME : 26.13 s Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/virtio_seg_max_adjust.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_seg_max_adjust.py index ad736bcda3..2fc6bfcbd8 100755 --- a/tests/acceptance/virtio_seg_max_adjust.py +++ b/tests/acceptance/virtio_seg_max_adjust.py @@ -26,6 +26,7 @@ import logging sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python')) from qemu.machine import QEMUMachine from avocado_qemu import Test +from avocado.core.exceptions import TestSkipError #list of machine types and virtqueue properties to test VIRTIO_SCSI_PROPS = {'seg_max_adjust': 'seg_max_adjust'} @@ -117,12 +118,22 @@ class VirtioMaxSegSettingsCheck(Test): return False def test_machine_types(self): + """ + :avocado: tags=arch:i386 + :avocado: tags=arch:x86_64 + """ EXCLUDED_MACHINES = ['none', 'isapc', 'microvm'] if os.geteuid() != 0: EXCLUDED_MACHINES += ['xenfv', 'xenpv'] # collect all machine types except the ones in EXCLUDED_MACHINES with QEMUMachine(self.qemu_bin) as vm: vm.launch() + # Skip test if target is not X86 + # TODO: Move this check to Avocado (based on the test tags) + target_arch = vm.command('query-target')['arch'] + if target_arch not in ['i386', 'x86_64']: + errmsg = "Architecture '%s' unsupported" % target_arch + raise TestSkipError(errmsg) machines = [m['name'] for m in vm.command('query-machines')] vm.shutdown() for m in EXCLUDED_MACHINES: From patchwork Wed Jan 22 22:32:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11346489 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 146B417EA for ; Wed, 22 Jan 2020 22:35:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEF8D2465A for ; Wed, 22 Jan 2020 22:35:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SWCiQ2g4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEF8D2465A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:47814 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOaW-0003r6-Ho for patchwork-qemu-devel@patchwork.kernel.org; Wed, 22 Jan 2020 17:35:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34169) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuOZ6-00026M-Uy for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuOZ5-0001tN-Cl for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:36 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:26555 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iuOZ5-0001sj-8S for qemu-devel@nongnu.org; Wed, 22 Jan 2020 17:33:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579732414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=77vF3k15FTYFomIOoon+XSCFO0pcEnC1dHzATvCNB/0=; b=SWCiQ2g42dVBeDcoGGnIhQsiYF62OdtIWvUzS5Pzv1EC/KfXLypQ9ctxxOF18CWYtkRlxt Q1DbY+jRv6UQYoy3vVTUyAGOmbZqisAqec8pVVLsaKJ0CD+BjFCAxKGSv6NmLDAfmP6I2O 4GCnF8B8tr1FEzZq91ajDx/dk1y6OJk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-215-54ohBjJeNeaOjHLqiW4vAw-1; Wed, 22 Jan 2020 17:33:32 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C289B10054E3; Wed, 22 Jan 2020 22:33:31 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-78.brq.redhat.com [10.40.204.78]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8752B845A5; Wed, 22 Jan 2020 22:33:28 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: "Michael S . Tsirkin" , Denis Plotnikov , qemu-devel@nongnu.org Subject: [PATCH 6/6] tests/acceptance/virtio_seg_max_adjust: Restrict to Linux host Date: Wed, 22 Jan 2020 23:32:47 +0100 Message-Id: <20200122223247.30419-7-philmd@redhat.com> In-Reply-To: <20200122223247.30419-1-philmd@redhat.com> References: <20200122223247.30419-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: 54ohBjJeNeaOjHLqiW4vAw-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Eduardo Habkost , Stefan Hajnoczi , Cleber Rosa Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" This test is failing on OSX: TestFail: machine type pc-i440fx-2.0: Looking at the job.log: Unexpected error in object_property_find() at qom/object.c:1201: qemu-system-x86_64: -device virtio-blk-pci,id=scsi0,drive=drive0: can't apply global virtio-blk-device.scsi=true: Property '.scsi' not found Which makes sense looking at hw/block/virtio-blk.c: 1261 static Property virtio_blk_properties[] = { 1262 DEFINE_BLOCK_PROPERTIES(VirtIOBlock, conf.conf), ... 1268 #ifdef __linux__ 1269 DEFINE_PROP_BIT64("scsi", VirtIOBlock, host_features, 1270 VIRTIO_BLK_F_SCSI, false), 1271 #endif Fix by only running this test on a Linux host: (38/55) tests/acceptance/virtio_seg_max_adjust.py:VirtioMaxSegSettingsCheck.test_machine_types: SKIP: Host OS is not Linux Signed-off-by: Philippe Mathieu-Daudé --- tests/acceptance/virtio_seg_max_adjust.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/acceptance/virtio_seg_max_adjust.py b/tests/acceptance/virtio_seg_max_adjust.py index 2fc6bfcbd8..f8fd03e3b6 100755 --- a/tests/acceptance/virtio_seg_max_adjust.py +++ b/tests/acceptance/virtio_seg_max_adjust.py @@ -27,6 +27,7 @@ sys.path.append(os.path.join(os.path.dirname(__file__), '..', '..', 'python')) from qemu.machine import QEMUMachine from avocado_qemu import Test from avocado.core.exceptions import TestSkipError +from avocado import skipUnless #list of machine types and virtqueue properties to test VIRTIO_SCSI_PROPS = {'seg_max_adjust': 'seg_max_adjust'} @@ -117,6 +118,8 @@ class VirtioMaxSegSettingsCheck(Test): return True return False + + @skipUnless(sys.platform.startswith('linux'), 'Host OS is not Linux') def test_machine_types(self): """ :avocado: tags=arch:i386