From patchwork Fri Jan 24 05:56:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasily Averin X-Patchwork-Id: 11349785 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F391514B4 for ; Fri, 24 Jan 2020 05:56:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D22232072C for ; Fri, 24 Jan 2020 05:56:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730602AbgAXF40 (ORCPT ); Fri, 24 Jan 2020 00:56:26 -0500 Received: from relay.sw.ru ([185.231.240.75]:51168 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727250AbgAXF40 (ORCPT ); Fri, 24 Jan 2020 00:56:26 -0500 Received: from vvs-ws.sw.ru ([172.16.24.21]) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1iurxA-0007jZ-30; Fri, 24 Jan 2020 08:56:24 +0300 From: Vasily Averin Subject: [PATCH 1/1] snic_trc_seq_next should increase position index To: linux-scsi@vger.kernel.org Cc: Karan Tilak Kumar , Sesidhar Baddela Message-ID: <0617d789-fea3-53ae-cd19-78894d6bbd81@virtuozzo.com> Date: Fri, 24 Jan 2020 08:56:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org if seq_file .next fuction does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin --- drivers/scsi/snic/snic_debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/snic/snic_debugfs.c b/drivers/scsi/snic/snic_debugfs.c index 2b34936..b20c724 100644 --- a/drivers/scsi/snic/snic_debugfs.c +++ b/drivers/scsi/snic/snic_debugfs.c @@ -419,6 +419,7 @@ void snic_stats_debugfs_init(struct snic *snic) static void * snic_trc_seq_next(struct seq_file *sfp, void *data, loff_t *pos) { + (*pos)++; return NULL; }