From patchwork Wed Sep 26 22:49:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Valdis_Kl=C4=93tnieks?= X-Patchwork-Id: 10617015 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2119A175A for ; Wed, 26 Sep 2018 22:49:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0FE292B74B for ; Wed, 26 Sep 2018 22:49:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 01DBA2B752; Wed, 26 Sep 2018 22:49:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 14DD62B74B for ; Wed, 26 Sep 2018 22:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726549AbeI0FE6 (ORCPT ); Thu, 27 Sep 2018 01:04:58 -0400 Received: from outbound.smtp.vt.edu ([198.82.183.121]:41586 "EHLO omr2.cc.vt.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726186AbeI0FE6 (ORCPT ); Thu, 27 Sep 2018 01:04:58 -0400 Received: from mr1.cc.vt.edu (mr1.cc.vt.edu [IPv6:2607:b400:92:8300:0:31:1732:8aa4]) by omr2.cc.vt.edu (8.14.4/8.14.4) with ESMTP id w8QMnjNn010954 for ; Wed, 26 Sep 2018 18:49:45 -0400 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mr1.cc.vt.edu (8.14.7/8.14.7) with ESMTP id w8QMneHH025693 for ; Wed, 26 Sep 2018 18:49:45 -0400 Received: by mail-qt1-f197.google.com with SMTP id p52-v6so588655qtf.9 for ; Wed, 26 Sep 2018 15:49:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:mime-version:date:message-id; bh=s+4DODPYq3XlxXA/Wuyzxp5KZT1vdyoEe9bMkQmO5Ac=; b=Cz7UI13i6KASxactmaFIjSObfF8jTQXdFl/5rcl6xqlhjbSE5joi2Ac/2AAGKizgcb n96rCHruQ/qSB6Rg26UN06V2fIUl6705VzJCE5phZ0oeM1tRlVdz8hBP1rpbhlFyFvWT qPodamMUIqnX2cqWoRVTGLRcj7mhhUwwvwm1lE4HGDObVsCP03rAYFgPYtA32jgjjWVu 3N7CFiTTqOOVzKlUDYBZ+OKnBjm79Y/Ceiw5uy5WhCsvo16vDDfaGfEiaxWOzW2GYKU0 zy32Ds4+kzFhYZ3fxixZPi0Vj0sOChpHTgzvrhmsYDvHNwYiwX2CEzRWANYjjHds2mEu ZXew== X-Gm-Message-State: ABuFfogU4TqzsUMBR/5LBhAYGRuyUuBrpxS/qZZHs7ggbk1QTP4myJHE 6Fh8l0QUv4Zm2N4EQfTj8qiHtZ+BoKkv0RjXlw0n5OdF4q9+e9nzBKrOqjqQADvB7fUuG70cWwX /Vq6hJCpIFGMYvTTM6hjyNKCKWwXAqRhoBsA= X-Received: by 2002:a0c:a281:: with SMTP id g1-v6mr5952405qva.60.1538002180562; Wed, 26 Sep 2018 15:49:40 -0700 (PDT) X-Google-Smtp-Source: ACcGV61qTl6U+l9Mrf45pSW6UiKrBaSOFcaO/gBqIgNFuoyBHqlQ25Qk597nBwcRUqFuhQjN992NrQ== X-Received: by 2002:a0c:a281:: with SMTP id g1-v6mr5952394qva.60.1538002180255; Wed, 26 Sep 2018 15:49:40 -0700 (PDT) Received: from turing-police.cc.vt.edu (turing-police.cc.ipv6.vt.edu. [2001:468:c80:2103:f21f:afff:fe0c:8ada]) by smtp.gmail.com with ESMTPSA id o2-v6sm237352qkl.63.2018.09.26.15.49.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Sep 2018 15:49:39 -0700 (PDT) X-Mailer: exmh version 2.8.0 04/21/2017 with nmh-1.7+dev From: valdis.kletnieks@vt.edu To: Herbert Xu , "David S. Miller" cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto/morus(640,1280) - make crypto_...-algs static Mime-Version: 1.0 Date: Wed, 26 Sep 2018 18:49:38 -0400 Message-ID: <113445.1538002178@turing-police.cc.vt.edu> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP sparse complains thusly: CHECK arch/x86/crypto/morus640-sse2-glue.c arch/x86/crypto/morus640-sse2-glue.c:38:1: warning: symbol 'crypto_morus640_sse2_algs' was not declared. Should it be static? CHECK arch/x86/crypto/morus1280-sse2-glue.c arch/x86/crypto/morus1280-sse2-glue.c:38:1: warning: symbol 'crypto_morus1280_sse2_algs' was not declared. Should it be static? CHECK arch/x86/crypto/morus1280-avx2-glue.c arch/x86/crypto/morus1280-avx2-glue.c:38:1: warning: symbol 'crypto_morus1280_avx2_algs' was not declared. Should it be static? and sparse is correct - these don't need to be global and polluting the namespace. Signed-off-by: Valdis Kletnieks Acked-by: Ondrej Mosnacek diff --git a/include/crypto/morus1280_glue.h b/include/crypto/morus1280_glue.h index b26dd70efd9a..ba782e10065e 100644 --- a/include/crypto/morus1280_glue.h +++ b/include/crypto/morus1280_glue.h @@ -82,7 +82,7 @@ void cryptd_morus1280_glue_exit_tfm(struct crypto_aead *aead); { \ } \ \ - struct aead_alg crypto_morus1280_##id##_algs[] = {\ + static struct aead_alg crypto_morus1280_##id##_algs[] = {\ { \ .setkey = crypto_morus1280_glue_setkey, \ .setauthsize = crypto_morus1280_glue_setauthsize, \ diff --git a/include/crypto/morus640_glue.h b/include/crypto/morus640_glue.h index 90c8db07e740..27fa790a2362 100644 --- a/include/crypto/morus640_glue.h +++ b/include/crypto/morus640_glue.h @@ -82,7 +82,7 @@ void cryptd_morus640_glue_exit_tfm(struct crypto_aead *aead); { \ } \ \ - struct aead_alg crypto_morus640_##id##_algs[] = {\ + static struct aead_alg crypto_morus640_##id##_algs[] = {\ { \ .setkey = crypto_morus640_glue_setkey, \ .setauthsize = crypto_morus640_glue_setauthsize, \