From patchwork Tue Feb 4 02:05:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pan Nengyuan X-Patchwork-Id: 11363909 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B6607112B for ; Tue, 4 Feb 2020 02:06:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96E542084E for ; Tue, 4 Feb 2020 02:06:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96E542084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:51846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iync9-0003Kf-Px for patchwork-qemu-devel@patchwork.kernel.org; Mon, 03 Feb 2020 21:06:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35159) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iynbe-0002nQ-SE for qemu-devel@nongnu.org; Mon, 03 Feb 2020 21:06:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iynbd-0007UO-PU for qemu-devel@nongnu.org; Mon, 03 Feb 2020 21:06:26 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:2754 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iynbb-0006gX-1i; Mon, 03 Feb 2020 21:06:23 -0500 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 01129323CB897F3B19F3; Tue, 4 Feb 2020 10:06:17 +0800 (CST) Received: from DESKTOP-9NTIQGG.china.huawei.com (10.173.221.136) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.439.0; Tue, 4 Feb 2020 10:06:11 +0800 From: To: Subject: [PATCH v2] pl031: add finalize function to avoid memleaks Date: Tue, 4 Feb 2020 10:05:54 +0800 Message-ID: <20200204020554.9380-1-pannengyuan@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.173.221.136] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Euler Robot , qemu-arm@nongnu.org, Pan Nengyuan , zhang.zhanghailiang@huawei.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" From: Pan Nengyuan There is a memory leak when we call 'device_list_properties' with typename = pl031. It's easy to reproduce as follow: virsh qemu-monitor-command vm1 --pretty '{"execute": "device-list-properties", "arguments": {"typename": "pl031"}}' The memory leak stack: Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7f6e0925a970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970) #1 0x7f6e06f4d49d in g_malloc0 (/lib64/libglib-2.0.so.0+0x5249d) #2 0x564a0f7654ea in timer_new_full /mnt/sdb/qemu/include/qemu/timer.h:530 #3 0x564a0f76555d in timer_new /mnt/sdb/qemu/include/qemu/timer.h:551 #4 0x564a0f765589 in timer_new_ns /mnt/sdb/qemu/include/qemu/timer.h:569 #5 0x564a0f76747d in pl031_init /mnt/sdb/qemu/hw/rtc/pl031.c:198 #6 0x564a0fd4a19d in object_init_with_type /mnt/sdb/qemu/qom/object.c:360 #7 0x564a0fd4b166 in object_initialize_with_type /mnt/sdb/qemu/qom/object.c:467 #8 0x564a0fd4c8e6 in object_new_with_type /mnt/sdb/qemu/qom/object.c:636 #9 0x564a0fd4c98e in object_new /mnt/sdb/qemu/qom/object.c:646 #10 0x564a0fc69d43 in qmp_device_list_properties /mnt/sdb/qemu/qom/qom-qmp-cmds.c:204 #11 0x564a0ef18e64 in qdev_device_help /mnt/sdb/qemu/qdev-monitor.c:278 Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Reviewed-by: Philippe Mathieu-Daudé --- Changes V2 to V1: - Delay the timer_new until realize instead of putting it into instance_init, since the pl031 can't be hotplugged(suggested by Peter Maydell). --- hw/rtc/pl031.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/rtc/pl031.c b/hw/rtc/pl031.c index ae47f09635..0b9253eb30 100644 --- a/hw/rtc/pl031.c +++ b/hw/rtc/pl031.c @@ -190,7 +190,11 @@ static void pl031_init(Object *obj) qemu_get_timedate(&tm, 0); s->tick_offset = mktimegm(&tm) - qemu_clock_get_ns(rtc_clock) / NANOSECONDS_PER_SECOND; +} +static void pl031_realize(DeviceState *dev, Error **errp) +{ + PL031State *s = PL031(dev); s->timer = timer_new_ns(rtc_clock, pl031_interrupt, s); } @@ -321,6 +325,7 @@ static void pl031_class_init(ObjectClass *klass, void *data) DeviceClass *dc = DEVICE_CLASS(klass); dc->vmsd = &vmstate_pl031; + dc->realize = pl031_realize; device_class_set_props(dc, pl031_properties); }