From patchwork Thu Sep 27 09:24:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 10617727 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CD32814BD for ; Thu, 27 Sep 2018 09:27:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE3D62AFF0 for ; Thu, 27 Sep 2018 09:27:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B20922B04B; Thu, 27 Sep 2018 09:27:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D34222AFF0 for ; Thu, 27 Sep 2018 09:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727502AbeI0Po5 (ORCPT ); Thu, 27 Sep 2018 11:44:57 -0400 Received: from mail-ve1eur01on0050.outbound.protection.outlook.com ([104.47.1.50]:48730 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727505AbeI0Po5 (ORCPT ); Thu, 27 Sep 2018 11:44:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2BMra5JZUXtb9QzesBMf7k9W7rBPAYVPPOX4dQm3LJ8=; b=1Z03YufONm2KvExIdcoyMUZYY0QmNWrhZzjLEmco4Ix3FZMGzZwKDK0Pn5efP4g0sl84Rh7/HiqLayC3TTFsZ+TygTf9wrVGhF4Ej1e6Cg2kkT4vTSJ+b9vS12UbcowSVJtdwCvpgjYFg6sparShgaqvM0jnNejo/XmvRyNHAfk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Michal.Vokac@ysoft.com; Received: from iota-build.ysoft.local (89.24.100.190) by AM0PR04MB4660.eurprd04.prod.outlook.com (2603:10a6:208:75::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Thu, 27 Sep 2018 09:27:30 +0000 From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: Bartlomiej Zolnierkiewicz , Shawn Guo Cc: Fabio Estevam , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, =?utf-8?b?TWljaGFsIFZva8OhxI0=?= Subject: [RESEND PATCH v2 1/3] video: ssd1307fb: Use gpiod_set_value_cansleep() for reset Date: Thu, 27 Sep 2018 11:24:39 +0200 Message-Id: <1538040281-21319-1-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 X-Originating-IP: [89.24.100.190] X-ClientProxiedBy: HE1PR05CA0360.eurprd05.prod.outlook.com (2603:10a6:7:94::19) To AM0PR04MB4660.eurprd04.prod.outlook.com (2603:10a6:208:75::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9dab4e8e-82ee-4be5-929e-08d6245b7365 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);SRVR:AM0PR04MB4660; X-Microsoft-Exchange-Diagnostics: 1;AM0PR04MB4660;3:svqcGGM1SossD5VrIF8tvIVLYsrb1Rv9IqzdwcXkNFWgHPoeaL0UYJ0C+aiCou79dDpNlAH0Fxh8W8cqDxFYuVCkSd2pxjOPZUvOCnlw2/lFUMlPCYetgNEnob4waEl3kt67IvQNEaul1nC2Zlbjeg/sM0kdf1gtu9ZUQy2ZSEoTvRQgBvv1zE4G2E2kTBlptvlF2sO3PStFXOpMv0C8Gh5ItBe6InIXJTiM63u+ThKM8timBNBRPW7D5NAUD2it;25:m5jSCfeTS3m+JtJpCkIhewmjS6cUarw3T0BDw3gn0f8aLf5eVXXzHUhvmIl5Lbr/N97XGy0QdtegmM4jZLOjFsg32qGUGDOEHgnHMo9rWuXx34XVoaIMugRpRgJ83LDhtusgYjmPn5tiphdL8RXp1aLNicO2FWo5YgGSk4oAiI8avg8s0WJQRJ9kOOSsSrroCeuY9GbYOQaRbOLugH2xy21Z/oqUtDfrMXbjjXBCgfW+b1WeInBWPoNqfPhRIZdTX/HWWTGYwswpeiZVddWYnW6WMsAISEavQ7ElSWLp0DHaR9S7wco1+AxXYyAiQ6+YiLeFgt5sPiRjO2mb7N2yuA==;31:+k7CfEfTwzpuPxoJT3jpSnSHlwPAIyRgiMSZ9NqGjHPMN/iGxOB6ZniqrzaDNF7y2H9gWFwJod/qs97v6X0mGuaNpAmmR8ONJCB5eqIwmmCxAhqCWdyiU02IFz+JFGpzca7I2VRqc3LtzoTHZj95NFp1lIf24N4dr+QV4X8egF2+CFP0j9uixStOsuTWMJOWW1QlKPv5HY0WrtRxv59SMb7bYjEAKgPTvTwwHCySMSs= X-MS-TrafficTypeDiagnostic: AM0PR04MB4660: X-Microsoft-Exchange-Diagnostics: 1;AM0PR04MB4660;20:8ouyH+bkkRyZTxJB5QEg/l7UrH0JLBnnXVB7BdeqhlcZVqnMO3R5cuh9vSwEDKy1EY+2jTba+/PbaImdZifgMMMJPDgKw/Q0Eh7pmHUx1WUyR/ngjiVDqtIQsYtHtKIrXO/B+GMN3gMP3f0LLaQz26kpO19cLZyWZregIImOMfxz5dhlhwBL9Y683wXQS5r88Ddgjb6mE7YNQ4BkgawDRjLyCBjzGs88DFuHS4wqbCOHzuBZb+YtWEpvTnuuzKzi;4:hRwViQrChsVJnZKwyp6nADhWBEweIRsGtFE50JeP1hVWWmQB2hqxql7UpTEI+ae/z9b6Yy/WJGepG+6R45d+5A3L2cJn2NEj43e97EpoXovbmbggB/0BUyXoi/Ywe8HRDNVuJGXAZU2u9OBCWcI9thld9yajJU7kYsCPLvynr8x9CDdrseFlrnnWUwhrN1g5WktqrrL9NOv7ho5l/9w1TrTwdnpk6A32+DT3YmO5zn0a21JamjSgV+1JFhQXGqoOpk4FN47MRhrC+AS+EIkkLRxVEDQur2vroAoCzHu6r7Wz6STAWLw1q8kdlo/wVbLu X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231355)(944501410)(52105095)(149066)(150057)(6041310)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(201708071742011)(7699051);SRVR:AM0PR04MB4660;BCL:0;PCL:0;RULEID:;SRVR:AM0PR04MB4660; X-Forefront-PRVS: 0808323E97 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(376002)(346002)(136003)(366004)(39850400004)(396003)(199004)(189003)(6116002)(3846002)(26005)(476003)(97736004)(2870700001)(81166006)(81156014)(8676002)(486006)(86362001)(316002)(8936002)(72206003)(50226002)(2616005)(186003)(956004)(36756003)(16526019)(53936002)(2906002)(52116002)(6512007)(23676004)(47776003)(305945005)(217873002)(50466002)(478600001)(6506007)(386003)(107886003)(5660300001)(106356001)(66066001)(54906003)(110136005)(4326008)(25786009)(7736002)(34290500001)(105586002)(68736007)(6486002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB4660;H:iota-build.ysoft.local;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: ysoft.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BAM0PR04MB4660=3B23=3A85btynh?= =?utf-8?q?ah7yfTikQjqLeKUVAW52uxczctysA6X3OUHRbnMPqID0IYmlAMT672hTVBmPmt6ZH?= =?utf-8?q?+72N57aA5Bwj6foU8tNi5Px7ywNWF0oc0v5j1lDbg9IbZQBDPYQZwjHIu04JYn2UB?= =?utf-8?q?Re9EKvTK07xBlva3KnBtgfNHtcUvv5oE0/9yTx2/3e0VRdhNt0E/vTtWDHdiQqznL?= =?utf-8?q?grkBnw2323FLqLYAfr8T9jI8YbsDprLijTbahzHAJkPh3yoaPyHKBeSe661SpoqPI?= =?utf-8?q?ToHSH3MNJ8TLFjotJ2ySHVipuan7sextwDxwdKPjArhcDCinubAjzhuhVIGtcU+Wr?= =?utf-8?q?LjLNHmm7f0lfl6ickytNHFW0ci1xhj+Hj+c+Xgb2QpGIGzOrPk3/SenHPdO4LOkYO?= =?utf-8?q?y76ALWl8lU7NqOhJJnf22nmP3gWcFqJdz82bIodu6iPaz+rpw0O8fQfXWF4/RiA9N?= =?utf-8?q?XLSystJ7Uub57IzmJUX8f8ZDYw7dSDS9WG4xMSP9c1PNyW4APs5nZiIYKWufBYOyA?= =?utf-8?q?W9eNqoCOkTJCmcCMZeOfnHokhfFdCd1rwm5zjv0cIRdw2f8oKEA6FBpRuRoocSwHK?= =?utf-8?q?Jf3XLm4xBEyVk1zylF7pWOKhg3RkUcR0X+q5ta1qmmPv+Q/qV0HWWDD2MDJisMWXD?= =?utf-8?q?9mjPwmQDvH7e4oB71IsYHA/MThqrpkUZtK3KMgcJyPbW8lmBpTQBlAsLWBx6xhCyj?= =?utf-8?q?SM1vKUZDHC7NyJXOhJcfiMXglIRFJepHGYf8JdUDPi1EfioWjzvhmyq9Qo5pg2DW7?= =?utf-8?q?HDdp6iFm0/ehruDixnVUtODmyUc2H+WoAakosUxs0tuPsEWFGNODLHvXmILluK0xK?= =?utf-8?q?N1mKutSSYRDTXWNZ54iL4Qt1LzP2vGDsDMrHD+vsyCyb7sZrJtCrUg+zL20+Qdjhd?= =?utf-8?q?pDsBz04VBi97u1kv7kmV8ookqzwu78I0sSrQiiqKnjEZM8Qlj3qCsUbWyuEzvgUFN?= =?utf-8?q?daqKSYVuwQ7Ic7Gm9S9EAEQoKCcWEVX+RTgiqHKzPHuBr7rQ4kXHqCnvwqUFps0KT?= =?utf-8?q?1usbbyiJzUVYZ5gnnMA7mToTWuHWzGJvdQXUpNfzdVLC9mzUeU4ByJug9TDm+rhUd?= =?utf-8?q?+OAB6PCR9sMZbVbkQml7Zk75L2ZWgbIwa3AzD5fmAVq82/NiH3DcsVBqTTvnKJcfV?= =?utf-8?q?5Vpb6BQHHuCRMSjwnc=3D?= X-Microsoft-Antispam-Message-Info: b/tUMZDlb6ZWKQHA3agNaL+qUjv0RMavyWrDDYplf9U/Ca1fTa7KfVShRdCdkqublxdD5TbfTCTwQw/wetzVdTqPkCetE7uXHL5mFXEjKeFD0mqIWxI8Kuw1RqFf5HMNhPeHlmHKLk+X0xEegyoVJ7SBd9qwmDPTnByH+ROYK76ChGlig4rAT0nZHJlf46cpOT/0DWGLxbICPG2JG7IV/BKDV58/z5MsUq/PaGOW2ykG0ub7LxlOLp3xeTIaYCZGjt5Ewn9pTpXi5fiS1Wlc3F+nnS+kF+bP+It6a1azrDlkmPJ28pDWDgRVdO7rdX9cgRjG3BqkUIaxNW5ujxjS/pusz+VJU5nlTwxK+1/Mtn4= X-Microsoft-Exchange-Diagnostics: 1;AM0PR04MB4660;6:95XS8FQyg+b4EmTawdf/THG3vMTf0MjRxPQr2qcSbpmw/TQcORhE1J0Tku286xwZ5LkQzORK7HSG/XL43D0K8l338B9P0/YyYLevxmU3bLloUkRLGXwELpA9Sanky7W/ivMtMymSDIbQvnPj1m7mw1fuRO20hrZDXVu4ys75CuFzIhwP5fz2p2c8M/+lVlm+9ZQi/St7u1RairesG41NJ9ifhQIK4Myhvf1xESsV91RsFINbj59fer2jrA76KcFMnoE1uBVYOYN0Opl3Vw8QKiPK2USdU9ic4NOy230UIu1Ody3r3uXtsrvvx1+A2cHOZWiN2oPt+yWdK9iKKV6DMn+omKe1rHAtgdfbJjh1dY1gTyQADVD2WuB90ZeNF6yxcZA6aTzFNSkhP6RWzyMwgibVlYPa0EbXsLb+XKXimEouNB03oADQ0xQuVnJM3gK23RTDh0Oq5Nlwf4u3QXd2yQ==;5:h1X+vfKwuAXJMzaN7khP0nNROrxBqYcFPKrqCd3qm7/Lf1HDiqvi4aL57ditJRHPpIiEstHvFldnfdya82wPP3EVSshydo6eI1YpP9j6MeymdfRsdTk0Wc39vZPGEzDjoD7Z1R0Z1ievEJHoi9XiWEqpPvZjMgGEvMq2O17/iE0=;7:rs5EyX8IEvlCcRaWVlAQ8ne5T34OQHtxsyO9+oPIma/4407jgw0wAvuFmcgUxJgodhBDif0Lgj2tYVkcIU+lLx3z1IROUk1vXeosaXmiVJh8ZAEW8qnCc7gs3vnkawDCd5xaoT8sBw/Sb9PLI3EvX3SjHEVnYHRuhWCL/bC0oY802hRl1OqTZRoSkeyKimyeIZyu4QkUaY0T0qZxBEQzSd097i9HDQjTBvvkqSK1ZL13dSCrzTKEI10JQdw486FE SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ysoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2018 09:27:30.8195 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9dab4e8e-82ee-4be5-929e-08d6245b7365 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5839965-430f-4be2-b282-d7a3149f2b37 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4660 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The reset signal can be produced by GPIO expander that can sleep. In that case the probe function fails. Allow using GPIO expanders for the reset signal by using the non-atomic gpiod_set_value_cansleep() function. Signed-off-by: Michal Vokáč Reviewed-by: Fabio Estevam --- v2 changes: add R-by from Fabio drivers/video/fbdev/ssd1307fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index ba66c02..e7ae135 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -728,9 +728,9 @@ static int ssd1307fb_probe(struct i2c_client *client, if (par->reset) { /* Reset the screen */ - gpiod_set_value(par->reset, 0); + gpiod_set_value_cansleep(par->reset, 0); udelay(4); - gpiod_set_value(par->reset, 1); + gpiod_set_value_cansleep(par->reset, 1); udelay(4); } From patchwork Thu Sep 27 09:24:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 10617729 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CEB5514BD for ; Thu, 27 Sep 2018 09:27:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BC5C12AFF0 for ; Thu, 27 Sep 2018 09:27:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B00592AFFB; Thu, 27 Sep 2018 09:27:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45ADB2AFF0 for ; Thu, 27 Sep 2018 09:27:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728227AbeI0PpC (ORCPT ); Thu, 27 Sep 2018 11:45:02 -0400 Received: from mail-ve1eur01on0050.outbound.protection.outlook.com ([104.47.1.50]:48730 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727617AbeI0PpB (ORCPT ); Thu, 27 Sep 2018 11:45:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BBE2I6XPHis7MzMwKJVM3WJhq2bf27Khfe0LFubF2Rc=; b=VCQABh+lPIciosIVcwxSy2zqr3/ChXi9R1H7v7J8jQHGyDItqAtOqARJ/ZIwmTE5faRxgJM6wX9PgeRilZfay/BBTAwXiDd36lOuy4FPyUff/6qbn1h9LGf/vdnQwRbFMgoZwxN2LxY0UJa1Rpw3O2VzTVtxU6ivF+Rsv75apog= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Michal.Vokac@ysoft.com; Received: from iota-build.ysoft.local (89.24.100.190) by AM0PR04MB4660.eurprd04.prod.outlook.com (2603:10a6:208:75::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Thu, 27 Sep 2018 09:27:31 +0000 From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: Bartlomiej Zolnierkiewicz , Shawn Guo Cc: Fabio Estevam , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, =?utf-8?b?TWljaGFsIFZva8OhxI0=?= Subject: [RESEND PATCH v2 2/3] video: ssd1307fb: Do not hard code active-low reset sequence Date: Thu, 27 Sep 2018 11:24:40 +0200 Message-Id: <1538040281-21319-2-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1538040281-21319-1-git-send-email-michal.vokac@ysoft.com> References: <1538040281-21319-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 X-Originating-IP: [89.24.100.190] X-ClientProxiedBy: HE1PR05CA0360.eurprd05.prod.outlook.com (2603:10a6:7:94::19) To AM0PR04MB4660.eurprd04.prod.outlook.com (2603:10a6:208:75::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4f79f50a-21a7-4261-3c02-08d6245b7411 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);SRVR:AM0PR04MB4660; X-Microsoft-Exchange-Diagnostics: 1;AM0PR04MB4660;3:HXnIlSDFGCXVxYFx9h+lKf+DBFUrg3AXN7I1dC/ySr1KZsBpMV8jHdAzno31KpiCgoNbwTLJ3yVopxFlS2hYIJy6kpEPxRJTNtobXt6yg8G/MuMJdDNcFVkUmBz7dA63tna3JIS1nYrds/Wi+vxqXHGTTdOJEJCXEqVEx0LOglgoZTKEGS74Qc5MtKTqoT+e40TvELmlEOnQYdCmtd7nufiaBz3llCHwGDr8FgOAxTy+RJZIi5hD94z2Q8YXo7I3;25:+mHc2IbBQh3AeIf/44eyAub3tLtUheqVwhSlqkG5rmFSR6HBK/gjLqQH4ocVE9kIYMhIs27k5VGRno4a1Ksat+m+LaBrDXzDgkQaR4ZewJ9dmcPpfvzlrYoHWzTIPpbZ5XOC/blNuJ1dz2/gdGfgN6LwlM7zTyyoqvuxIMpAqYpYMe3Av5nXuW2IK9VB4vUp7hOVPx4/tY4qY/1f+jfOKOX9byyDDx1fniaISjqoZA9O5ssdd3ijl24XrREbcMMIi3p2Ayv4yc+4AQPtZexoIni68aEO6UVOQcRT3xLiYPclPdVnHpfPHi7fvgnOf9NNvh9vJng5lXgR+ogLechsZw==;31:j68QhDSdJvx1x7uQ9/O/7P2PK188AHojGfFwS69wrwdxWLq4dqEYXfdZJyCMySSTAxxPp1pPS+TcxLc2BXost8HtbHXHTmt0WsbsR3QXCg6c6yf+hSokJlSNG3qt8bubLKYv4NHoBlYuERSDxuuY6v/wHtUvLRFtHOPVnx529PMelBqzoMOuYNPVsn+vN+mmcqGpEdPyCq2NuBQU8AeAqcVoSBCQagYaVIQ7DtTUopg= X-MS-TrafficTypeDiagnostic: AM0PR04MB4660: X-Microsoft-Exchange-Diagnostics: 1;AM0PR04MB4660;20:BDbZp0pFJffRyjyOFr0Uj6y46XdBdTvEbAS3i04EvRAHeDOoFMXgBqI+Fl6RsgTT/kAcoZsf9brAQS29fZCqk0XJxaJM5NP+JvuG09bcZmpoovd4pb3Sn1fuPOpdJP1Oe93MEevpYV9njJRczMB+7lOLXvydEaxO43mN9eleE6eadSah4zUqNNmyNDa9SzlFwq9E0by4zky86EgMEV29Oz2W13c8FacrIxj/aUuqsIrJMAQRPGJmnrGxWgSxDVpM;4:ao8HQwUwMRfM3AHxrFi6l6QJNH/V+I6zXA56CNdKoprD4pNm5HVU8X3guCviA71/JSt6v6CBKN01C0b031IsOvmqwwKyoE2Wui++aPDtEm+uaO4NWAoLRTrZYhsrb8+7Fqg2zOWkPm3LPvdklSfBxciNezc754px9zs3Dv0n6S2z67ve4bj3Ir+MIxK3GjusXR1cyzXaaFkpl9MbVvYO/8Aqc8Ad4GkqsYySsafZjVe1oXEKKivaxADQWUjc3wKzx+fGV6ICtCkNH8N81iFQ9A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231355)(944501410)(52105095)(149066)(150057)(6041310)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(201708071742011)(7699051);SRVR:AM0PR04MB4660;BCL:0;PCL:0;RULEID:;SRVR:AM0PR04MB4660; X-Forefront-PRVS: 0808323E97 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(376002)(346002)(136003)(366004)(39850400004)(396003)(199004)(189003)(446003)(6116002)(3846002)(26005)(476003)(97736004)(2870700001)(81166006)(81156014)(8676002)(486006)(86362001)(316002)(8936002)(72206003)(50226002)(2616005)(186003)(11346002)(956004)(36756003)(16526019)(53936002)(2906002)(52116002)(6512007)(23676004)(47776003)(305945005)(76176011)(217873002)(50466002)(478600001)(6506007)(386003)(6666003)(107886003)(5660300001)(106356001)(66066001)(54906003)(110136005)(4326008)(25786009)(7736002)(34290500001)(105586002)(68736007)(6486002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB4660;H:iota-build.ysoft.local;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: ysoft.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BAM0PR04MB4660=3B23=3Ab3w4gG6?= =?utf-8?q?JLg3rqv9vMjAIVnmZ8v0yt5mGa+yu6ZIvYu74kRofzemb4SZ/rVGXfbXNsJpTACUz?= =?utf-8?q?8dhcG9zfZ011QmPyKp8GeU0qJcbwRJP2TWdGTfFSeBBO9vJbd+yHlONp8+qo0pirX?= =?utf-8?q?632mDnE63ygUG2/SrdmdxJJhFJycywMHe5d5ierpBLf4a85XZGC5qqsgjVdjF0s2W?= =?utf-8?q?5vDUAfal4bOVZBHZM9zmYal4+FzEhFWPQNPeuEiV4HvWUYSrj7KOkg1sGPswqNA4O?= =?utf-8?q?oBrdeqzzPTnyjP7JBP7pwdHLqIpbyN28ExlpNmdWrZllHq0+ALO6bR0Y4izqhGT9s?= =?utf-8?q?8Bb1DmRueoNz63TvLh9fCXVV91j1pCgXqiaOpiEhxXZoxCDexv20kIh/hA+rMZGho?= =?utf-8?q?qtHeiYNew0dwjoe1XfVIH07Bz2kaldhFyNVMH1vze73GWEg+pxboFLwmfHjcLaLlw?= =?utf-8?q?kMPBTrI43nsa/mg8C0E9UD2gQlqwn/yr6toSJyw+FePB19Bvm0uBMQwDD/xh1IVfx?= =?utf-8?q?z/XOnRx94OITNiGqREdgkTMUbr8oOt5o/00wB7G3GfLQuc5NsZNDrnB3FRNLmlK0y?= =?utf-8?q?MHb2qNuK4G+U9ODWwF14uqZ3/WL+LJzeLb5q8vESgz+5yHxZqg7TdSLBSNFKXnz/k?= =?utf-8?q?PcjJJIxbHw8YBB6igaMRflynGpV5KqA+c9bfy/z9OluqEVAqD0Sc3aP+48HCRWl9P?= =?utf-8?q?aF/HptVz3tkuB64SSFa6vcFq9hRUIb7uLQppQ9pWa+7R0fjeoONnbMJ6tJudQe0Ed?= =?utf-8?q?Nd0aVSvXRYFX7xMfnCC9L1mibZREIrj1lrx4dUGMrhJVxpKGmSoZWhks1CH+uoifu?= =?utf-8?q?MjLHCbag38bTrEd9mvAXeu9sIXSzw8PfVc7QE0IBlDOj1Xq9pjF7Utth/2dyruWCp?= =?utf-8?q?ijutovVGq0mcR7P93wJ3k4yjg4E58TZjpygS9Mky7RjP/XX5SLCVbY1pO+txfhBkM?= =?utf-8?q?oK+UTx3dcq2bq9Qmkpmf0O5j4V7RSN9DvQ5Asf5wbKpCHeCjazqAomkc9H+9WV2Ps?= =?utf-8?q?CjOsp6gJIXr3zjfeshqDvUJ9JfAK+xEejqPcuuwuhmtm7Xl7eAkNyMX6LTD53YBja?= =?utf-8?q?LTIYkPsow9SDq+UPAhlZ2oHeG6Fhpd4t5Y4K4po+0XxfoYal4VgKN/qQq/xIJW1U/?= =?utf-8?q?HArLZ2q/AKT3yH2C4Zs2smgwuDXQ9FGVuhfWJok4YB5z99qBX+YkRq4aiPiSw2MjU?= =?utf-8?q?5GBdLte+cCPSr/5d6YY4vNn3UWCkIq6D4FF4TY?= X-Microsoft-Antispam-Message-Info: QOEIpJTXM8vU9ntMUkK3tE74s2pJ+RXMATyDuNCWDq2VTDqR+3O++fI2NW0+1OFtpQhg3O4n/QB5UA0C1Ll3icTSFeAWwDbnsbKgeaDRI4YXvAOdlQ1mBNZnFK6IY5GZtrmS0n5oXNu0F59pGkohKCD2OU7nkEoASRfeVLI4SrI66KWWazRDaFrIjAggD1zvp4bbekUneS2LIOkNGbM8oPBIL80G5dywEB7XXq06SfyFa66D47MF/eBLBBOX23e6MqQeyr7h78UF7fKvI5nAZnVFcnmQuoG8m0WXw8+Pl1pmQ89RxbsDtWlLY+Q0oMsGnZfZALDqkz9eZf0yA5ZQgRs2OgPn376rhtmqa+d09rE= X-Microsoft-Exchange-Diagnostics: 1;AM0PR04MB4660;6:EzRH+oV7Xq4C2V0Nj28wwEX0T9PlbkOsWeIJmthwgo0B/ocIXzBn1cWedWCbXVC7/tjXY4+nNxAFDtTYKczDVzi8gf7dmvlvGYsmtqO/js2c9pI2L3Gffdvpbze7B+XWDHMggvyRIp9oS6+FCHk50hrht1l1wOOm48SR13HgTAbmKD5eory8S+97hJG0j2be36db8g+Qy9qS5yl0tEH+mlGywcv0E0OJLQyq7ZAu+vJ1WI9062xo/3bFBxj9nxKCYgaqWI2HxoRGvxBya0FP9eunwk8dBZ8+L+jbC6ke2UwxdvX4OZbdpvRLefhbta5E2y5X9zJNdIMQbtP3DIgemwe6j7MlBHAHFxb9/Rl22JwcPWYUljCCWmYIZXQGbcQvGk8SW4P9VvRNWAb204VeYEvQuOyjoNl9PFXOWgihh400DLrmWHaE6XQDJ+zjfHgMaSuz7oZMQ98VQ97UXYRG1g==;5:DC5+bwN0uDi1e0mPeAnSaAhPWhTEiIng4P9341oGkqxv3lcURA+0OcCc/7PElnrVl4PzIFWkAAd8JwmcsYH1AI8/JmhycG+b+/7aQgkOsG3cgtDPiE8kpH4Jt4iFiOdPqU4xP+nZByiVgBf6SUUKbDlhmopLSNaUJfP6TElQfj4=;7:DiElf3MrZNHLlV35lsgTs2DF1X6W/Q8LEQ2qZPVetE0nbSs70+376EszVxoDawH+4lUEJIbutIQ+eBTkISZAePbL+F3bxDBpgSkf3cVZd5qL0lskoYl/2+ZXhYbOZ6GNQyZA0sYT4ykiR+e8Bv5tkZsUP4ot6GPxaapyF12J2r8ByLiurhaF/h8rLwl4xeEc/XM1/jIJKBelGmoSzhkW1v+iOOQPl7NKoy4/SIE+Y8/pkMBgdMyUdMC5NFcfLpf1 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ysoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2018 09:27:31.9445 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4f79f50a-21a7-4261-3c02-08d6245b7411 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5839965-430f-4be2-b282-d7a3149f2b37 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4660 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The SSD130x OLED display reset signal is active low. Now the reset sequence is implemented in such a way that users are forced to define reset-gpios as GPIO_ACTIVE_HIGH in DT to make the reset work. Do not hard code the active-low sequence into the driver but instead allow the user to specify the gpio as GPIO_ACTIVE_LOW to reflect the real world. Signed-off-by: Michal Vokáč --- v2 changes: Split the DT changes into separate patch. drivers/video/fbdev/ssd1307fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index e7ae135..7b5bc42 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -728,10 +728,10 @@ static int ssd1307fb_probe(struct i2c_client *client, if (par->reset) { /* Reset the screen */ - gpiod_set_value_cansleep(par->reset, 0); - udelay(4); gpiod_set_value_cansleep(par->reset, 1); udelay(4); + gpiod_set_value_cansleep(par->reset, 0); + udelay(4); } if (par->vbat_reg) { From patchwork Thu Sep 27 09:24:41 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= X-Patchwork-Id: 10617731 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BFBEC174A for ; Thu, 27 Sep 2018 09:27:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AF49C2AFF0 for ; Thu, 27 Sep 2018 09:27:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A39F82AFFB; Thu, 27 Sep 2018 09:27:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1EC1D2AFF0 for ; Thu, 27 Sep 2018 09:27:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728415AbeI0PpF (ORCPT ); Thu, 27 Sep 2018 11:45:05 -0400 Received: from mail-ve1eur01on0050.outbound.protection.outlook.com ([104.47.1.50]:48730 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728025AbeI0PpE (ORCPT ); Thu, 27 Sep 2018 11:45:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ysoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/zjeKlt89emubFnnQrKNJXflxP1xxwZj7WKs9T9TRCY=; b=mFo43Z/PA+yNmRuwZXevDMF4sw50fObhgJ8aTubicJ1amaByAcQ/bmJRH18Db/wS1DDSBbv5VSninifMG5OMszD+tPKL4xwRr7H30RvN8VonyCy0AwSU5krVgmVM0i52XVcD3/A7o13AOXXmU78kFtJJRaNTICfYrLAwaWX/U7A= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Michal.Vokac@ysoft.com; Received: from iota-build.ysoft.local (89.24.100.190) by AM0PR04MB4660.eurprd04.prod.outlook.com (2603:10a6:208:75::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Thu, 27 Sep 2018 09:27:33 +0000 From: =?utf-8?b?TWljaGFsIFZva8OhxI0=?= To: Bartlomiej Zolnierkiewicz , Shawn Guo Cc: Fabio Estevam , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, =?utf-8?b?TWljaGFsIFZva8OhxI0=?= Subject: [RESEND PATCH v2 3/3] ARM: dts: imx28-cfa10036: Fix the reset gpio signal polarity Date: Thu, 27 Sep 2018 11:24:41 +0200 Message-Id: <1538040281-21319-3-git-send-email-michal.vokac@ysoft.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1538040281-21319-1-git-send-email-michal.vokac@ysoft.com> References: <1538040281-21319-1-git-send-email-michal.vokac@ysoft.com> MIME-Version: 1.0 X-Originating-IP: [89.24.100.190] X-ClientProxiedBy: HE1PR05CA0360.eurprd05.prod.outlook.com (2603:10a6:7:94::19) To AM0PR04MB4660.eurprd04.prod.outlook.com (2603:10a6:208:75::14) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2c740844-15b6-4764-e56b-08d6245b74bc X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(4534165)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020);SRVR:AM0PR04MB4660; X-Microsoft-Exchange-Diagnostics: 1;AM0PR04MB4660;3:zaRdhsz7LYCwCbs14o26I1EnndYWMcCZ3AEHbXMEeCic72PaWUxv+lDsBIuV4tsUQhL3RGU6PNaw3ztTrtG9hOTHbglcAkKtqL/azuSbx+P12muf+TJKMmq5uN28Pbhzmk/VSFVzfdiuhI0eK+yjm19NI8SrJoOu2FzGTGywG2RgUIOjNZ7+UIygG3JUI34R9t7AuF9g1Czgg3wAchIC7sC32guzh7V5xVC5dgrcSlXVFISwwKJuaCyFkB5J1iuj;25:zu/LkiskPVX7BH6oEXjmjCMQdMM475Lxu3K7qGJpNjg+0EYdrqkez05vwTI5hf9WBux+2Cj62p5EZQ0EsaFQECQaxRirrM35ey7WBhLYrOAvWPsJVpKk/b3dDHM7O8Urt1Ixu0VE9L4XiY9i7AnLyr4vgS4+e4+U227O6+39svqyQ3UjnMidvJsH6kBEhQzv4G9LjjASB8KD2K2cEv5SND9pmrFuuos0JsEpd8h5n8QoWP+hN9yCzyLZPsQZXlGmK+idAqOMl0lcS5WYzJYVh59WHiF3atLBpm24x8/48Y7BemKV16OOLBmpYeVUIM/DCZ1giSGXWJ0QCy9jikM6ug==;31:Uxd0gfnDlpKoJHMWB1HZSMMYQcDG7JTY6FBhg78ZbcmzKHcz0L7L9VZklv8fVsa788VZ5LSxh5xPTxb9wPZfGUJiWaannRA+u3uw2Oa5IdvnhMhQC55rcsZT3J71wYZdrN/PK2+iYQdCxyDMTcJy57d/MACbvAu2H4es0WKfuFkoG/p7PQiL7Gpz9uYJch729syFhIKhHSwp92ekQfFlr0whfwj98FE8KAipi8Ji4Us= X-MS-TrafficTypeDiagnostic: AM0PR04MB4660: X-Microsoft-Exchange-Diagnostics: 1;AM0PR04MB4660;20:PbUPJJP7MOhnXVgw/1RD+rMJMdzanhtevT7PaQFH/NcahHdW2WZ+hAEf5PlxlFCb7E671CeNc3uorjZ5Qj198qFYWIpJe/scspXM3rMOupT2JQt51MLbPN4D98doW/AlxkqFlgQCyEEAr2Zo39NyIX8yWxTV+xBGTuTd6uV9g/eIOVL4MNEk+Tip4bX/yZvnHLLcwlP8X2r6hWhbHIka228/14dgHkSjb8o/9FSoYOoAi+/O4g0PTsmDbhK2F23O;4:Bd0k5M3qaAaaUBKDCJIdeuYPz5+EA8wmNwF/P975x7K0nnKIIkhMP3uQnp0Q4Lo+kFeW6rVf3WPowLdxzpwgrVyBVOfh/CEiPuMLj3AYxFJNsCIk+n+ph0AwwrdONGU4AJ0ftCW2rMRi+A92mhiq6YdgPHcgkRxS9rABdOlWkbLpzCooVLAqIIz5X+oPQgGivBkfislULJ4Pp1Qgk66NfuVNUZ6g50FLWBW1NKFoZ/G+KNmyob0Lbts/NS2qGMVi3qvjIMFwhiNS3u/m3vbaiQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(3231355)(944501410)(52105095)(149066)(150057)(6041310)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(201708071742011)(7699051);SRVR:AM0PR04MB4660;BCL:0;PCL:0;RULEID:;SRVR:AM0PR04MB4660; X-Forefront-PRVS: 0808323E97 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(376002)(346002)(136003)(366004)(39850400004)(396003)(199004)(189003)(446003)(6116002)(3846002)(26005)(476003)(97736004)(2870700001)(81166006)(81156014)(8676002)(486006)(86362001)(316002)(8936002)(72206003)(50226002)(2616005)(186003)(11346002)(956004)(36756003)(16526019)(53936002)(2906002)(14444005)(52116002)(6512007)(23676004)(47776003)(305945005)(76176011)(217873002)(50466002)(478600001)(6506007)(386003)(6666003)(107886003)(5660300001)(106356001)(66066001)(54906003)(110136005)(4326008)(25786009)(7736002)(34290500001)(105586002)(68736007)(6486002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR04MB4660;H:iota-build.ysoft.local;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: ysoft.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BAM0PR04MB4660=3B23=3A3K9GuRA?= =?utf-8?q?ApblrMHwkzw2Ml78zvaO8soJZkV6k5cdyt0+TA7n6qaUyO2cSrwah9dDWbCUAJnsH?= =?utf-8?q?FL+HssSflCzzmX20tu93RBRPjc7RjvUoziiFmW1b3s8NuIy244G7UOojtCAeRqErQ?= =?utf-8?q?OiQibThL2E28SRTY6nr9BfZabkSUSNFmMeyOpu9dA3feHLIn+UwOscNKpvY13PvLT?= =?utf-8?q?AkIAXlAYn8zenEY8exeFgyjwLqQQDJ2pYrqasOIro51h8mOwnko0BSlulTmZ9rBzB?= =?utf-8?q?yKDfgmNZoAiLHhdq94I7ROqjStEpC6DzBkRXRj4Arc29h7btsoFZjR9o9XmaBSqVI?= =?utf-8?q?5thJoeIHAiskhTyDT52Hpj3yNWFjhblMRFoDCt19ReFlimpTa4iP7BivfMp00MWIT?= =?utf-8?q?GEZ0033LTRbk+asN1/tjOZBvg4k8z/XdejySKQs8XJVmASEyGnWiOmcWSPvpSRcXz?= =?utf-8?q?ThrXQwBWetyCHvGkg/MG6hz8ljbw8JsF3Fa72vE84NsTENZs2peHfhBFXpQS/K5rz?= =?utf-8?q?jQzBCif0YGaLqREhlBikUqih8J0iwBZllW7sWz6ryBoS13TYrw747tf/rqOjeCECj?= =?utf-8?q?sKDDJ1P3Ld2f/zFQbxogDGL6WoW5kRZ9/zfUBZMtfdhaIHYpqBNGrDoqCu7UOyatQ?= =?utf-8?q?r02COtJyHfVvDB7BoeR3hLSHjEufz9Bdqdg8LtEW2M036U8pJE450oSHw/N07M2RF?= =?utf-8?q?4FsXkodZcMuCIbbolx8lIzAtx+x1z8IO3vTNTQeQ6IuKsDXHJhp+9AoGfxZu3gDYq?= =?utf-8?q?2kUQpn2RrSWQoB1gk8fe8tKHrMFNFjrnZt88v+TtDCuIULR5g3bmVkeTtF2AyXGjk?= =?utf-8?q?gdcXjIUhEC+hwbtxdLOomO21sdIYVNnq4InS4rx6OqXjNdkQ2MQjFXRzubjOgZzqI?= =?utf-8?q?wr2d80XGF3FdFLhcXJifUpaMOze11btbfcYsKYVFdjRV6mUTOO9+V7byaCraxp/O5?= =?utf-8?q?048qSlIGfPKzb4JcddbNbGZ3xD7OEqbu2+ItZHXUJ018+FhmT8Gw6x9nezmw/ddAF?= =?utf-8?q?8W8i0M0ivp++j9tsjrOEawZyFutrzRiyY6A+46Xvd0VQlUlPMk0x+wlihmwTkfwyo?= =?utf-8?q?OINzK5pPbPLjxnorOT+vdBMR3Y6tkiHH4Zf9pn1K/oU9xBYV1MvZd9sIJkhvBbGUY?= =?utf-8?q?K37geZlTEI/aC64lHyE6fA+j4jyasvgWwKwuQTXYdiFV/bj34srWEvgBIuUAPXP4h?= =?utf-8?q?btFFDZkWR+WIR9X/5/l674xmKeqc0scji5cc021UiE7K0XLzcqaJiJ5GNohQ=3D?= =?utf-8?q?=3D?= X-Microsoft-Antispam-Message-Info: ttE43guDOlG7wvdldDTCOzVPcOPNFiOMVDbMfxJcfUW6VEuiQp+gE0O0xlMUSC3Dk+3Xyt8WpN8rI3xQQ0AYsmOO56i9J/BQhY/oQlOClGM22UPzdzXyCsArTwKS7UDQ9uFjHKuVGImNt0Q/gZo/5Nw9i5HwN7Zzm5391FPMhmk6mlJQdV+SuW9Lzh+ZoNgYs4fDkefACbUnrJE/bbp0XI5B4KirA7YvAuQoO3W51Tv7hxRl4qbqxBORwz7wcsVCN9O+nvfbo7kUVbbDIlWxzanIlzrnXL5ZPLm7TjVleFOeMReQlq0yG64XFfPamK/yqH8UEdhYJCYlw+G/w02TM71VjUjJ9cJEC9lyupDWIF4= X-Microsoft-Exchange-Diagnostics: 1;AM0PR04MB4660;6:8Np+cs3aSO6VKX+AaU+xUY5CMFGJbeZQ+kbkp6HYrUhn3EPbSEgaFFMVd7+eYutUBEKxDetbKpVl3/KQ67g6+2TWrg7tdmMLFy++66LKsu9+8/k65AuQoDQAw8HywUw4+To+1jWK0zr+MCj49W3pu76BDNvKjiRLK+NkuAiu0VVeK2l6egEBO9vWMi0iUc5KA8FU2RxzrjrcpBS3s0gA/FAd1rzjOaRZniG/btYPazNzqNb8ofsfmFhrKbqPtSf4kKo/iKaakaXCSLQdkAF1gSpFaSyC9UX31rdia8ianyPLU/D4zF0xPWnyHydzZSj5pt081JRHuAgO+wuJ+UQ5mTlTNueo6Us6TXeKnxofQhA5KnJOQa4k5mw8di5MG9ImPdeka0KFnYSGkJcjW98dCWXprXRODhqEPnT+Y1kFxPCijxyYTE7SpAQMM+roNQ1bXTbTAhFRXIcIleSAmbOjww==;5:qlbNWKYIAUIBxEZaMHzcbBP8n2+ixK81+bVNI9BJhGE5TYf2cz4vigvJVEVWaukLWrar9UQ/4rIYjF99b2N99qcN6LgITRemQyJlvUwqNKquQoCmtiOSO/z/SFohS+sbQfOJDzwl8rk3UX8Y/WKT77ewnmtCcyOZkGNh/1Niuwg=;7:Dl776Jq6Lf+mHoKFnHZ2u/6o+uelsvRC4e+t3Am0j18swg78pTaBnF3iS0B3cBxnuFvDDOVtvxJuXRMk7HYQMzZ0POvp2eqrQpXEMp4XabEs6V48l0Se2DRpEfFZPWpkbVfu5YQ271kI+Z1FO03cTReEfAtjkUcv2w8qatEBsHyQ6Pi8aGmt015F0GIzc5FJJqsu1nBK67eBG/EjBW20zvtGQLjCdiatJ4Gz4m0anLcLnC98DYu67OnPyplF4fhI SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: ysoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Sep 2018 09:27:33.0695 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c740844-15b6-4764-e56b-08d6245b74bc X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b5839965-430f-4be2-b282-d7a3149f2b37 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4660 Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The reset signal of the SSD1306 OLED display is actually active-low. Adapt the DT to reflect the real world. Signed-off-by: Michal Vokáč Signed-off-by: Bartlomiej Zolnierkiewicz --- v2 changes: New patch in the series arch/arm/boot/dts/imx28-cfa10036.dts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx28-cfa10036.dts b/arch/arm/boot/dts/imx28-cfa10036.dts index e54f5ab..be3406e 100644 --- a/arch/arm/boot/dts/imx28-cfa10036.dts +++ b/arch/arm/boot/dts/imx28-cfa10036.dts @@ -11,6 +11,7 @@ /dts-v1/; #include "imx28.dtsi" +#include / { model = "Crystalfontz CFA-10036 Board"; @@ -95,7 +96,7 @@ pinctrl-names = "default"; pinctrl-0 = <&ssd1306_cfa10036>; reg = <0x3c>; - reset-gpios = <&gpio2 7 0>; + reset-gpios = <&gpio2 7 GPIO_ACTIVE_LOW>; solomon,height = <32>; solomon,width = <128>; solomon,page-offset = <0>;