From patchwork Thu Feb 6 22:48:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11369353 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8BCBB92A for ; Thu, 6 Feb 2020 22:49:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F9D621927 for ; Thu, 6 Feb 2020 22:49:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="W+wnx4PZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F9D621927 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:47396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izpxy-0002dB-Ht for patchwork-qemu-devel@patchwork.kernel.org; Thu, 06 Feb 2020 17:49:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59942) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1izpxM-0001aw-Q7 for qemu-devel@nongnu.org; Thu, 06 Feb 2020 17:49:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1izpxL-0006oF-Sl for qemu-devel@nongnu.org; Thu, 06 Feb 2020 17:49:08 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:53925 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1izpxL-0006nh-PA for qemu-devel@nongnu.org; Thu, 06 Feb 2020 17:49:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581029347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qYf/Ojw8DoD3PTNFTI9fXiekKBI4qRmD7q/QCymONSA=; b=W+wnx4PZhrKor5BH/R9K55fF5JWCKzFpMqz4+S+hog5TMq4wYidNwtA9MwVmCqw48mNL8f 9QXmcFclxqt3QuMbhIIdYzj2My6+WRlKR3BhPrayTV0ADwb9hAzNz3PiciMsyFM1Mh0Zd6 VujGB2NlibnhvbRchUjRiOSOORZHheY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-118-2d9xMeajOo6yCIon5SB78g-1; Thu, 06 Feb 2020 17:49:05 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90CB6800EB2; Thu, 6 Feb 2020 22:49:04 +0000 (UTC) Received: from x1w.redhat.com (ovpn-204-120.brq.redhat.com [10.40.204.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 651FF87B1C; Thu, 6 Feb 2020 22:49:00 +0000 (UTC) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Andrew Jones Subject: [PATCH] docs/arm-cpu-features: Make kvm-no-adjvtime comment clearer Date: Thu, 6 Feb 2020 23:48:58 +0100 Message-Id: <20200206224858.23184-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: 2d9xMeajOo6yCIon5SB78g-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Peter Maydell , qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" The bold text sounds like 'knock knock'. Only bolding the second 'not' makes it easier to read. Signed-off-by: Philippe Mathieu-Daudé --- docs/arm-cpu-features.rst | 2 +- target/arm/kvm.c | 5 +---- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/docs/arm-cpu-features.rst b/docs/arm-cpu-features.rst index dbf3b7cf42..fc1623aeca 100644 --- a/docs/arm-cpu-features.rst +++ b/docs/arm-cpu-features.rst @@ -185,7 +185,7 @@ the list of KVM VCPU features and their descriptions. kvm-no-adjvtime By default kvm-no-adjvtime is disabled. This means that by default the virtual time - adjustment is enabled (vtime is *not not* + adjustment is enabled (vtime is not *not* adjusted). When virtual time adjustment is enabled each diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 85860e6f95..bcca8c8029 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -194,10 +194,7 @@ static void kvm_no_adjvtime_set(Object *obj, bool value, Error **errp) /* KVM VCPU properties should be prefixed with "kvm-". */ void kvm_arm_add_vcpu_properties(Object *obj) { - if (!kvm_enabled()) { - return; - } - + assert(kvm_enabled()); ARM_CPU(obj)->kvm_adjvtime = true; object_property_add_bool(obj, "kvm-no-adjvtime", kvm_no_adjvtime_get, kvm_no_adjvtime_set, &error_abort);