From patchwork Tue Feb 11 11:38:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kirill Tkhai X-Patchwork-Id: 11375253 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8A984138D for ; Tue, 11 Feb 2020 11:39:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6EA2220848 for ; Tue, 11 Feb 2020 11:39:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EA2220848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B53306B02AF; Tue, 11 Feb 2020 06:39:08 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B04256B02B1; Tue, 11 Feb 2020 06:39:08 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A19836B02B2; Tue, 11 Feb 2020 06:39:08 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id 87CEC6B02AF for ; Tue, 11 Feb 2020 06:39:08 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3801982499B9 for ; Tue, 11 Feb 2020 11:39:08 +0000 (UTC) X-FDA: 76477649976.16.swim74_15721f8b3b732 X-Spam-Summary: 2,0,0,215adfec9b3adca0,d41d8cd98f00b204,ktkhai@virtuozzo.com,:akpm@linux-foundation.org:guro@fb.com:vvs@virtuozzo.com:ktkhai@virtuozzo.com::linux-kernel@vger.kernel.org,RULES_HIT:41:152:355:379:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1381:1437:1515:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2553:2559:2562:2897:2898:3138:3139:3140:3141:3142:3865:3867:4321:5007:6261:10004:10400:11026:11473:11658:11914:12043:12048:12114:12296:12297:12438:12555:12679:12760:13069:13311:13357:14096:14097:14181:14394:14721:21080:21451:21627:30054:30070:30090,0,RBL:185.231.240.75:@virtuozzo.com:.lbl8.mailshell.net-62.2.3.100 64.100.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:160,LUA_SUMMARY:none X-HE-Tag: swim74_15721f8b3b732 X-Filterd-Recvd-Size: 1662 Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Tue, 11 Feb 2020 11:39:07 +0000 (UTC) Received: from dhcp-172-16-24-104.sw.ru ([172.16.24.104] helo=localhost.localdomain) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1j1TsX-0007P4-KK; Tue, 11 Feb 2020 14:38:57 +0300 Subject: [PATCH] mm: Add missed mem_cgroup_iter_break() into shrink_node_memcgs() From: Kirill Tkhai To: akpm@linux-foundation.org, guro@fb.com, vvs@virtuozzo.com, ktkhai@virtuozzo.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Date: Tue, 11 Feb 2020 14:38:57 +0300 Message-ID: <158142103093.888182.8911729633457501747.stgit@localhost.localdomain> User-Agent: StGit/0.19 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Leaving mem_cgroup_iter() loop requires mem_cgroup_iter_break(). Fixes: bf8d5d52ffe8 "memcg: introduce memory.min" Signed-off-by: Kirill Tkhai --- mm/vmscan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index b1863de475fb..f6efe2348ba3 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2653,8 +2653,9 @@ static void shrink_node_memcgs(pg_data_t *pgdat, struct scan_control *sc) continue; } memcg_memory_event(memcg, MEMCG_LOW); - break; + /* fallthrough */ case MEMCG_PROT_NONE: + mem_cgroup_iter_break(target_memcg, memcg); /* * All protection thresholds breached. We may * still choose to vary the scan pressure