From patchwork Tue Feb 11 16:24:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qian Cai X-Patchwork-Id: 11375911 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D0863139A for ; Tue, 11 Feb 2020 16:24:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9C940208C3 for ; Tue, 11 Feb 2020 16:24:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="YXpNNOp7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C940208C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lca.pw Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B18546B02E9; Tue, 11 Feb 2020 11:24:19 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id AC7E86B02EB; Tue, 11 Feb 2020 11:24:19 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B7CD6B02EC; Tue, 11 Feb 2020 11:24:19 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id 7EB486B02E9 for ; Tue, 11 Feb 2020 11:24:19 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0439B18030426 for ; Tue, 11 Feb 2020 16:24:19 +0000 (UTC) X-FDA: 76478368638.13.rule56_2596e8361ba1d X-Spam-Summary: 2,0,0,8a1f2e63ed05e516,d41d8cd98f00b204,cai@lca.pw,:akpm@linux-foundation.org:elver@google.com:catalin.marinas@arm.com::linux-kernel@vger.kernel.org:cai@lca.pw,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1345:1437:1534:1542:1711:1730:1747:1777:1792:1981:2194:2199:2393:2559:2562:2693:2918:3138:3139:3140:3141:3142:3353:3865:3866:3867:3870:3872:4321:4605:5007:6261:6653:7903:7904:8603:8784:8957:9163:10004:11026:11658:11914:12043:12296:12297:12438:12517:12519:12555:12679:12740:12895:12986:13161:13229:14018:14096:14104:14181:14394:14721:21067:21080:21444:21451:21627:21990:30029:30054:30056,0,RBL:209.85.219.65:@lca.pw:.lbl8.mailshell.net-62.2.0.100 66.100.201.201,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:39,LUA_SUMMARY:none X-HE-Tag: rule56_2596e8361ba1d X-Filterd-Recvd-Size: 4830 Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 11 Feb 2020 16:24:18 +0000 (UTC) Received: by mail-qv1-f65.google.com with SMTP id y8so5245737qvk.6 for ; Tue, 11 Feb 2020 08:24:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id; bh=wLPl/cstzWTeMlUQRCBJAM9GpFQjWbFFR3GkPG8wzQ4=; b=YXpNNOp7JzrPirfuXj4Fw25ulXJOqSKTXSPMTVYD9fnCBtHtOGvBwQrHPCC3N8K77O B1nOurTpEqdnUGs/JUG4AS3TKNe1cQjqkHH8YZxwy6BYHb5vIKSqnOnKvYwn5FLAt9uY u5pdbKDdsbXdPFPBu6Rleu1Np1Nepu3O3Hfn+v3pRY3uv/K4nd5mWQ8pIS/5Sc257iLm 9q9ak1rO4E8PK0mfS8gyzF2o55Mv11UBU7bdPD4TLLSj1mIm/Eru1KA3tTovFGVOAc1m 5EDP2K3WtRMkMKhq4Te52he7Zms7OHmkZxoTfz5ltoRnv2TdY65neO41fWQ1ngljxVN6 ZyVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=wLPl/cstzWTeMlUQRCBJAM9GpFQjWbFFR3GkPG8wzQ4=; b=JMfxF59NwkPozkPs3K3MQj5/H10LspgMBClxjpekbvAtcqrwMm49KyFtTHQMyE1CR5 lEtk5Mv1/uL/izj8mM5FkXDPpEZArn1UdxhuotLEYsGjLVlau5EP/3mOGY/z0CXRTo5S 4kZWxmAoHmAfwyLeOoxi3n0aNHU1d6eqKkrjfQfwjqKNdnmCfrBmTjESvlZAZGLzCmSe GJRYaznhsCTG9LPzqClkXQYbXRRnpi04SKyjVe869hOs+Yom3LUzpvXqRMQpK6fgU+0j Wm9fO2BaU84zz/ODaE+AqvxpBARWtXBXH8XMnGExmfns7H7/nUtyPLxaW5vnf5uk8wIQ R8mg== X-Gm-Message-State: APjAAAWgEnfly/ZRjAEICNUpnW7Re36hVBppkk2yRpqECZW7jrlPcopQ mgCwTOhMljOFKchLavEfbopukg== X-Google-Smtp-Source: APXvYqzs+bk5h6W/Qj9KvzQVLRqIJFLobB26Q9E2sfed40GYLzcTZmIP0wnbXsGmesBTAwmcsiz69g== X-Received: by 2002:a0c:eac7:: with SMTP id y7mr3695907qvp.86.1581438257600; Tue, 11 Feb 2020 08:24:17 -0800 (PST) Received: from qcai.nay.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id k4sm2315242qtj.74.2020.02.11.08.24.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Feb 2020 08:24:17 -0800 (PST) From: Qian Cai To: akpm@linux-foundation.org Cc: elver@google.com, catalin.marinas@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH -next] mm/kmemleak: annotate a data race in checksum Date: Tue, 11 Feb 2020 11:24:05 -0500 Message-Id: <1581438245-24391-1-git-send-email-cai@lca.pw> X-Mailer: git-send-email 1.8.3.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001106, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The value of object->pointer could be accessed concurrently as noticed by KCSAN, BUG: KCSAN: data-race in crc32_le_base / do_raw_spin_lock write to 0xffffb0ea683a7d50 of 4 bytes by task 23575 on cpu 12: do_raw_spin_lock+0x114/0x200 debug_spin_lock_after at kernel/locking/spinlock_debug.c:91 (inlined by) do_raw_spin_lock at kernel/locking/spinlock_debug.c:115 _raw_spin_lock+0x40/0x50 __handle_mm_fault+0xa9e/0xd00 handle_mm_fault+0xfc/0x2f0 do_page_fault+0x263/0x6f9 page_fault+0x34/0x40 read to 0xffffb0ea683a7d50 of 4 bytes by task 839 on cpu 60: crc32_le_base+0x67/0x350 crc32_le_base+0x67/0x350: crc32_body at lib/crc32.c:106 (inlined by) crc32_le_generic at lib/crc32.c:179 (inlined by) crc32_le at lib/crc32.c:197 kmemleak_scan+0x528/0xd90 update_checksum at mm/kmemleak.c:1172 (inlined by) kmemleak_scan at mm/kmemleak.c:1497 kmemleak_scan_thread+0xcc/0xfa kthread+0x1e0/0x200 ret_from_fork+0x27/0x50 Reported by Kernel Concurrency Sanitizer on: CPU: 60 PID: 839 Comm: kmemleak Tainted: G W L 5.5.0-next-20200210+ #3 Hardware name: HPE ProLiant DL385 Gen10/ProLiant DL385 Gen10, BIOS A40 07/10/2019 crc32() will dereference object->pointer. If a shattered value was returned due to a data race, it will be corrected in the next scan. Thus, annotate it as an intentional data race using the data_race() macro. Signed-off-by: Qian Cai Acked-by: Catalin Marinas --- mm/kmemleak.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index 3a4259eeb5a0..25b4bcc32b5f 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -1169,7 +1169,12 @@ static bool update_checksum(struct kmemleak_object *object) u32 old_csum = object->checksum; kasan_disable_current(); - object->checksum = crc32(0, (void *)object->pointer, object->size); + /* + * crc32() will dereference object->pointer. If an unstable value was + * returned due to a data race, it will be corrected in the next scan. + */ + object->checksum = data_race(crc32(0, (void *)object->pointer, + object->size)); kasan_enable_current(); return object->checksum != old_csum;