From patchwork Tue Feb 11 21:10:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gustavo A. R. Silva" X-Patchwork-Id: 11376899 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8373392A for ; Tue, 11 Feb 2020 21:07:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 615BB20708 for ; Tue, 11 Feb 2020 21:07:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZI7djp5R"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=embeddedor.com header.i=@embeddedor.com header.b="hUpZtp/Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 615BB20708 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedor.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=YmiujGVzLvQOzfDka3zOFCvsDin89i163bM8IaXDQBo=; b=ZI7djp5RXU5AjQ oRcN5tmGWtlIhWhokR63FpbCiLYAyGCFNuL1tWF6J5zQv7Vdg/M2O1ay0qutNU7FKeeUyP24aK1p2 rKpsqd7z2TSzlTHO/ChmiI0CSIktwyrKjCmyCaS/kQPKgXMD47MkhLEy9BNr4xKpkk+V4+I4lDFl8 pd1aF3gGZj7Hbwt8JjTJiLr4eTBB3U7qe2Mx51QvqU5JtiNEfOCqg8ZtfVGyXSBHWXKq2q074hNji b0N0g8k+KzbxEcIESiHLrxRoJToY1QCeLe5lwv7mcFFnFQi7iukiJ0HJ4ECsczB6A4ex2U2vbmYw7 I9aP8fGD/JAQfHR8xQLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1cku-0003dV-QC; Tue, 11 Feb 2020 21:07:40 +0000 Received: from gateway36.websitewelcome.com ([192.185.188.18]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1cks-0003d5-1O for linux-arm-kernel@lists.infradead.org; Tue, 11 Feb 2020 21:07:39 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway36.websitewelcome.com (Postfix) with ESMTP id C9A6441A6B7A9 for ; Tue, 11 Feb 2020 14:21:36 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id 1ckqjhlkyAGTX1ckqjuA4y; Tue, 11 Feb 2020 15:07:36 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Type:MIME-Version:Message-ID:Subject: Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uQ6KP5z8InjWIXpG49YAqXGZxEhBltFyFNyMqd8msSs=; b=hUpZtp/YmtarBOW5bzCKOqqOzR rkT9/BoT24adZzpp6Zzy9DO3Q99yWgahD5WPoq8+tLpkKL+zIwJArzXaUO2/ok3xFWxeC80HBZ/hP 33pWIcuE0SiR+Y3p9hLtWKDRRfGyy8sfEK204ogotK9OumSTtG2Lhbk37uH1SjUUZxhyf4SDUOjFk IoVzLb4hZEG9T6uHKr/yz9aKGHLuh8vU7yr6dXr3L/92OKoNG3bS+Qb9RZ884XjqvJvZgTH2BB37b QMPjik7Z1twj9H1WvIe/oAmza3g1RdVM7WHij00ZvXGff7swCvP4ERH+tviJfQdCpKA3NclCPgjDe tq0UyxbQ==; Received: from [200.68.140.36] (port=31539 helo=embeddedor) by gator4166.hostgator.com with esmtpa (Exim 4.92) (envelope-from ) id 1j1ckp-0029VO-8X; Tue, 11 Feb 2020 15:07:35 -0600 Date: Tue, 11 Feb 2020 15:10:10 -0600 From: "Gustavo A. R. Silva" To: Arnd Bergmann , Greg Kroah-Hartman , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi Subject: [PATCH] misc: vexpress: Replace zero-length array with flexible-array member Message-ID: <20200211211010.GA32239@embeddedor> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 200.68.140.36 X-Source-L: No X-Exim-ID: 1j1ckp-0029VO-8X X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedor) [200.68.140.36]:31539 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 21 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_130738_173416_6EC31242 X-CRM114-Status: UNSURE ( 8.94 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [192.185.188.18 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Gustavo A. R. Silva" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertenly introduced[3] to the codebase from now on. This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva --- drivers/misc/vexpress-syscfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/vexpress-syscfg.c b/drivers/misc/vexpress-syscfg.c index a3c6c773d9dc..5eb51f2be8f0 100644 --- a/drivers/misc/vexpress-syscfg.c +++ b/drivers/misc/vexpress-syscfg.c @@ -49,7 +49,7 @@ struct vexpress_syscfg_func { struct vexpress_syscfg *syscfg; struct regmap *regmap; int num_templates; - u32 template[0]; /* Keep it last! */ + u32 template[]; /* Keep it last! */ };