From patchwork Fri Feb 21 18:55:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 11397217 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C0D271892 for ; Fri, 21 Feb 2020 18:57:06 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92CE42071E for ; Fri, 21 Feb 2020 18:57:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="XA3PArlv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92CE42071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j5DSv-00086b-J2; Fri, 21 Feb 2020 18:55:57 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1j5DSu-00086W-G7 for xen-devel@lists.xenproject.org; Fri, 21 Feb 2020 18:55:56 +0000 X-Inumbo-ID: c95a4d86-54db-11ea-ade5-bc764e2007e4 Received: from esa5.hc3370-68.iphmx.com (unknown [216.71.155.168]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c95a4d86-54db-11ea-ade5-bc764e2007e4; Fri, 21 Feb 2020 18:55:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1582311354; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=H4K9z5RmDWhaD114wYCtz6MFZ53XL5VGNcMcpyGJVlw=; b=XA3PArlvj++F4h+SWOTTBBMDkgXOfcOuVcU6wogeRktZIAGRpFLuipXF VUnykBvVLFW36cMf6BOK8sjtvX/c958ify2ug6L+jqeqYaesg46VaoGTN 6ffw5QKGfG7WmLvtILGK6qAPK6gRrdNGTtRAlXVLm11peIDfE4WXi/gZJ A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=andrew.cooper3@citrix.com; spf=Pass smtp.mailfrom=Andrew.Cooper3@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of andrew.cooper3@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="andrew.cooper3@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of Andrew.Cooper3@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="Andrew.Cooper3@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com; envelope-from="Andrew.Cooper3@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: bvIlVCw2EO6yYzr3y3bvNgTrAUdnTzx9e4WW7/0MUZOl4NEhzjh2bxRbv2ftfjf7TNdh9rc9Hz C3z+nZ3gTOx1EhG+x/UcFgLSawMyXUrVU7kJA1ImsusETxHY/iiUp1UTZ+8kOypVSfNpJud4Id yw5sFyzQ3mKvxT/7xnCkPu2va35peywpayAes0ewrymkm9hSNxwzRyBk+95QP1rV0vxmJKwbiS Zhf0LZbojPaZpatuYMR7b9ro6w8Sk1xvzHGAwnoyr9Dlkeo7y2K7faeK6m/fMzrsNZ1plAGiPr Uys= X-SBRS: 2.7 X-MesageID: 13192084 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.70,469,1574139600"; d="scan'208";a="13192084" From: Andrew Cooper To: Xen-devel Date: Fri, 21 Feb 2020 18:55:50 +0000 Message-ID: <20200221185550.30545-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Subject: [Xen-devel] [PATCH] x86/build: Fix -mskip-rax-setup handling X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Anthony PERARD , Andrew Cooper , Wei Liu , Jan Beulich , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The way -mskip-rax-setup is currently specified results in compiler support being evaluated per translation unit, rather than per subdir. Switch to using cc-add-option instead. This drops the number of callouts from 428 to 60. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Anthony PERARD This drops about 0.5s from my ccache-accelerated but otherwise-clean build, and will likely have a more pronounced difference on older hardware. If it wants backporting, it wants to go back in this form. Alternatively, it would be nice to get this moved to Kconfig time. Anthony: Do you have any part of your series already doing this, or any suggestions on how best to do it without colliding with your work? --- xen/arch/x86/Rules.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/Rules.mk b/xen/arch/x86/Rules.mk index e69b8e697c..78fa312d38 100644 --- a/xen/arch/x86/Rules.mk +++ b/xen/arch/x86/Rules.mk @@ -63,7 +63,8 @@ CFLAGS += -mno-red-zone -fpic -fno-asynchronous-unwind-tables # Xen doesn't use SSE interally. If the compiler supports it, also skip the # SSE setup for variadic function calls. -CFLAGS += -mno-sse $(call cc-option,$(CC),-mskip-rax-setup) +CFLAGS += -mno-sse +$(call cc-option-add,CFLAGS,CC,-mskip-rax-setup) # Compile with thunk-extern, indirect-branch-register if avaiable. ifeq ($(CONFIG_INDIRECT_THUNK),y)