From patchwork Mon Feb 24 22:56:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 11401951 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 776F817D5 for ; Mon, 24 Feb 2020 22:57:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 559A720838 for ; Mon, 24 Feb 2020 22:57:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="f3JYVcsA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 559A720838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 97C666E22C; Mon, 24 Feb 2020 22:57:12 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 01BEE6E22C for ; Mon, 24 Feb 2020 22:57:11 +0000 (UTC) Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 30340E89; Mon, 24 Feb 2020 23:57:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1582585030; bh=0BYDLIIXHzuYUszryQCjJox6Ug17jkp0uymPPCJ3WWk=; h=From:To:Cc:Subject:Date:From; b=f3JYVcsAMJbsSp0ejkXnghrWsxdZugX+D4e0uNYbeOCbsRso0wjSBoJ/H1IMVvu5S b4LPE6WHIzxWXz+XYs2S5ILibJXG3zdd3QPSNLdwrpQPG1AnQXins/eRfwjNzfKSo+ 4oepQxXdzvwJkMU6JaeHE9FMv9T1szaE3iLaQSK8= From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/bridge: lvds-codec: Add to_lvds_codec() functino Date: Tue, 25 Feb 2020 00:56:45 +0200 Message-Id: <20200224225645.28060-1-laurent.pinchart+renesas@ideasonboard.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrzej Hajda , Jonas Karlman , Boris Brezillon , Jernej Skrabec , Neil Armstrong Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Factor out the manual container_of() uses to a common to_lvds_codec() macro to shorten lines (and provide better type safety, although that won't matter much in this case). Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/bridge/lvds-codec.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) Boris, This patch conflicts with "[PATCH v10 08/12] drm/bridge: lvds-codec: Implement basic bus format negotiation" (it's actually a drive-by patch that I wrote as I was reviewing yours series). Feel free to get it merged first if that can help. diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c index 5f04cc11227e..ae173d84dc8f 100644 --- a/drivers/gpu/drm/bridge/lvds-codec.c +++ b/drivers/gpu/drm/bridge/lvds-codec.c @@ -21,10 +21,14 @@ struct lvds_codec { u32 connector_type; }; +static inline struct lvds_codec *to_lvds_codec(struct drm_bridge *bridge) +{ + return container_of(bridge, struct lvds_codec, bridge); +} + static int lvds_codec_attach(struct drm_bridge *bridge) { - struct lvds_codec *lvds_codec = container_of(bridge, - struct lvds_codec, bridge); + struct lvds_codec *lvds_codec = to_lvds_codec(bridge); return drm_bridge_attach(bridge->encoder, lvds_codec->panel_bridge, bridge); @@ -32,8 +36,7 @@ static int lvds_codec_attach(struct drm_bridge *bridge) static void lvds_codec_enable(struct drm_bridge *bridge) { - struct lvds_codec *lvds_codec = container_of(bridge, - struct lvds_codec, bridge); + struct lvds_codec *lvds_codec = to_lvds_codec(bridge); if (lvds_codec->powerdown_gpio) gpiod_set_value_cansleep(lvds_codec->powerdown_gpio, 0); @@ -41,8 +44,7 @@ static void lvds_codec_enable(struct drm_bridge *bridge) static void lvds_codec_disable(struct drm_bridge *bridge) { - struct lvds_codec *lvds_codec = container_of(bridge, - struct lvds_codec, bridge); + struct lvds_codec *lvds_codec = to_lvds_codec(bridge); if (lvds_codec->powerdown_gpio) gpiod_set_value_cansleep(lvds_codec->powerdown_gpio, 1);