From patchwork Fri Feb 28 11:46:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412083 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8329C1580 for ; Fri, 28 Feb 2020 11:48:10 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59BD3246AA for ; Fri, 28 Feb 2020 11:48:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="enZGkmMw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59BD3246AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e7l-0000fD-Ac for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:48:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41119) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e6g-0007L8-5s for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e6e-00018V-0C for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:01 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:42861 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e6d-00018L-Tl for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:46:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890419; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JwOs2po6nVBrNz+DhsO8Xnl0PhYikRZa4JYienbwBPU=; b=enZGkmMwcthCkeWiHJJV1P3i16eMoKwwNr7UCU4aNwT9T+Xoo6J+fOvpOEdxNLhDL8mDGo IwJVAZ/EkcMaY5+V6adpDIY07gPEYhvXtS/PV/y63ocjj9954WqQTjfFKjp+kUhFaZEOD0 s+7qCJYKVtO8apkB8+hlUPAsr8pKN1M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-cLjOiksVMpS1oKPT7F1fuw-1; Fri, 28 Feb 2020 06:46:57 -0500 X-MC-Unique: cLjOiksVMpS1oKPT7F1fuw-1 Received: by mail-wm1-f71.google.com with SMTP id q20so25316wmg.1 for ; Fri, 28 Feb 2020 03:46:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CpNdsjNPiC6/DnLPjwvW92rGWlXZRi+/lAbWPRuMDaY=; b=i7DcUtnX8LabTOBfrj6io2geYZhagHS4WroRiN9y/yeMu3j9VBveYlhuypExiu8cMo 4Z1fyjRqM0bt6hjzB91h2uZnApAOm1rUdeBUD61+FPv9nrNPDjbdsfrJYbpoOsCIm3YS 0v8ChltaHlnXZwylgHyHu3hUMeoHQKJkSuKaIL7UPTQID5Ue8UsPltGrL7FGzaMgTfPj gafBvuk5FiVb+7JLCj6AyGkCip9EjEkeQwiw/a9QJHWsou450qe8WXRJFQPeAp1PGH7g daVy/A0TkyUs4T0XhHdEBXEFuf/l+n6EkJl8X0vAFg2X6n7EBevBELgMXFdBYZ7ykKCN y2HA== X-Gm-Message-State: APjAAAXhIemmYtQvuTtpafnEIrdcHagsuKgNe/5ATTtKCkD6azNzPN6l rI5p/kNn1fk5yq9bGejNySNJd+kpnCmlkbLuKB7bUQ+w3+jEk5wLd08YqRDCyXIB8szhOVLFSev 1+9ufAgpoellKSVc= X-Received: by 2002:a5d:4b03:: with SMTP id v3mr4785715wrq.81.1582890415985; Fri, 28 Feb 2020 03:46:55 -0800 (PST) X-Google-Smtp-Source: APXvYqxM2/smC26C3TpXbjvfNECRInDeKtZIZJPjM3yZ9lkl22pRKcGsi5IATwr0AxhD1KPwzkMb6w== X-Received: by 2002:a5d:4b03:: with SMTP id v3mr4785695wrq.81.1582890415762; Fri, 28 Feb 2020 03:46:55 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id q138sm1127219wme.41.2020.02.28.03.46.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:46:55 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 01/18] vl: Add missing "hw/boards.h" include Date: Fri, 28 Feb 2020 12:46:32 +0100 Message-Id: <20200228114649.12818-2-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Paolo Bonzini , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" vl.c calls machine_usb() declared in "hw/boards.h". Include it. This fixes (when modifying unrelated headers): vl.c:1283:10: error: implicit declaration of function 'machine_usb' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (!machine_usb(current_machine)) { ^ vl.c:1283:10: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] vl.c:1283:22: error: use of undeclared identifier 'current_machine' if (!machine_usb(current_machine)) { ^ Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- softmmu/vl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/softmmu/vl.c b/softmmu/vl.c index 16ff5a16a3..20b7201451 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -25,6 +25,7 @@ #include "qemu/osdep.h" #include "qemu-common.h" #include "qemu/units.h" +#include "hw/boards.h" #include "hw/qdev-properties.h" #include "qapi/error.h" #include "qemu-version.h" From patchwork Fri Feb 28 11:46:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412081 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C532C14BC for ; Fri, 28 Feb 2020 11:48:09 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B482246AA for ; Fri, 28 Feb 2020 11:48:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d+N1dLOq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B482246AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45745 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e7k-0000dZ-IL for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:48:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41145) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e6g-0007LA-Vg for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e6f-00018y-V4 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:02 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:49785 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e6f-00018e-Ru for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c3546yi0MNEa4PeS8dV7Vwzlyh9MvQJ56uhzxTJLw0w=; b=d+N1dLOq+LcvnjqJbSRSZhq/i9Ls4lTfMdSwLjo8Ee1IDA0TflQOggQunNyAsuo7QbtLK8 0sxXAr8eWygTG2P/8s6jWvmyrrwMx9JFImHkz5lrUqhcYEBCs8G9qPIldKlledxz3f7Kmy hFf7swhKFVC3DV44jVOMqKHlW/UU3cU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-qEoFox1-OWaSAZpJadt_Qw-1; Fri, 28 Feb 2020 06:46:59 -0500 X-MC-Unique: qEoFox1-OWaSAZpJadt_Qw-1 Received: by mail-wr1-f71.google.com with SMTP id o6so1220512wrp.8 for ; Fri, 28 Feb 2020 03:46:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f7g55rjk1KrrisnX/ncLGxvcfXQdY0DJfVs+Hz1podY=; b=C6WoIqJ/Lv3UU/8NDZzdHHGnShQEcdmnoofsWhkxCTCBugA5trspf8TeExM8BCLOOv tjMP3M4m+AL9T2C661SGr6KEX69uoDfVt3UNMKERx422B0oXbInsXQXZgCfGxtQFjzvm 74qitZLTEUYE40UMb/pzNrFpuvRueUxdWIYoVUJ1ynT9ZAlganLLLYwdoaPkY59RR1mp O3MkfGLbOH8jql+LinTSbgdI9Cjq8lI3g1scSEwRB6eMDoLFqvjK4hfbWBpANe3+yIql XjPNphY753bmlyOT5/MBU1elJojtg2MUj/vzAM2zVYH7jqblv+MjhGGGNOTkCAusQbj7 qb1A== X-Gm-Message-State: APjAAAWL9x2F1PhhhcLfFkYJPSPRp2BR3BoI7dbiEW/5gFE2DJlYDkW5 kcDULWucipmnfwM+lpLiedsvdk3G3KLlR6ASyyf9S+Wt5PGyn7CMt1z06CrAIBle2XqKQCLMJF3 z7a737WiaePLbEYM= X-Received: by 2002:adf:f7c4:: with SMTP id a4mr4494905wrq.361.1582890418143; Fri, 28 Feb 2020 03:46:58 -0800 (PST) X-Google-Smtp-Source: APXvYqxnzX87j3iygThg/Ua8j06sDbyEO3Vmhe1XCY219T9ODOfqM0dNbos+7UVje+Hl6zfQMiBUGg== X-Received: by 2002:adf:f7c4:: with SMTP id a4mr4494890wrq.361.1582890417971; Fri, 28 Feb 2020 03:46:57 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id q138sm1127219wme.41.2020.02.28.03.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:46:57 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 02/18] hw/southbridge/ich9: Removed unused headers Date: Fri, 28 Feb 2020 12:46:33 +0100 Message-Id: <20200228114649.12818-3-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Igor Mammedov , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" The ICH9 chipset is not X86/PC specific. These files don't use anything declared by the "hw/i386/pc.h" or "hw/i386/ioapic.h" headers. Remove them. Reviewed-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/ich9.h | 1 - hw/acpi/ich9.c | 1 - hw/isa/lpc_ich9.c | 1 - 3 files changed, 3 deletions(-) diff --git a/include/hw/i386/ich9.h b/include/hw/i386/ich9.h index 72e803f6e2..a98d10b252 100644 --- a/include/hw/i386/ich9.h +++ b/include/hw/i386/ich9.h @@ -5,7 +5,6 @@ #include "hw/sysbus.h" #include "hw/i386/pc.h" #include "hw/isa/apm.h" -#include "hw/i386/ioapic.h" #include "hw/pci/pci.h" #include "hw/pci/pcie_host.h" #include "hw/pci/pci_bridge.h" diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 2034dd749e..fdd0a6c79e 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -27,7 +27,6 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include "qapi/visitor.h" -#include "hw/i386/pc.h" #include "hw/pci/pci.h" #include "migration/vmstate.h" #include "qemu/timer.h" diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index f85b484eac..cb79616ced 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -37,7 +37,6 @@ #include "migration/vmstate.h" #include "hw/irq.h" #include "hw/isa/apm.h" -#include "hw/i386/ioapic.h" #include "hw/pci/pci.h" #include "hw/pci/pci_bridge.h" #include "hw/i386/ich9.h" From patchwork Fri Feb 28 11:46:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412089 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E486C1395 for ; Fri, 28 Feb 2020 11:49:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BBDF4246AA for ; Fri, 28 Feb 2020 11:49:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Z651eW1b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BBDF4246AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45810 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e9U-0004PU-TW for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:49:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41184) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e6l-0007Nh-95 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e6k-0001AK-8x for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:07 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:47876 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e6k-0001AF-5K for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lu32hqItUP7dM4PGcIuD4sRgE5GBtRTQN7Q926tcd10=; b=Z651eW1bEUGaWJT27PG2EPcz+/n8zuxhip1fbS8lTgmzM9E0ZKfJRaV9+HCOXEkip4iQGe xvDAsiQ38rReCwFGHntRFk3jLS/HWRNu1dxc1tWW0UhHe8LnbsLDu9sjWWLkdxHF8fj1tH /Cxunw+GBcfbJME5IGAEw8y3R/j561I= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-Meo-8VRzN-OUuU-2jfabFQ-1; Fri, 28 Feb 2020 06:47:04 -0500 X-MC-Unique: Meo-8VRzN-OUuU-2jfabFQ-1 Received: by mail-wm1-f69.google.com with SMTP id y18so1544428wmi.1 for ; Fri, 28 Feb 2020 03:47:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BP6/+KyIobA7aYPnUFr/bb+oOTNiJS/7LfeIG0A45xo=; b=e9sxYIl5NGmKccTp0KK89IKeo8Okl6N+6Q/h4VK//7T60XJ3Toam6DU0Of9jHUEhMT jggclNIK7qirYpdAmDlx0PuHYa0OtMmpzHM/gFEdDdDdLzTtJ7+dekNipxzvSKrqdLAf pdsx+f5vnBIs2ry+Sa+Ze07S0xYS41VPI2sworIYLctQIEFWo/MoUZS57XXH4BNRl/l/ G1c4lCU0EeCpGAOxli7C4/Od2DjDOD7gBboVXr3WzwyLdirLwEknmLoWa6jeJCXEWw20 SgutKUztaa/Djn5fs8q/CPUVt7fqAlJk6FPR2xLNANNSKCO9tlXQZB2djVjTHo5qWnV5 F5DQ== X-Gm-Message-State: APjAAAU1LwznWuAxBAeZNcsmQPmvEUDrT27FAYKtEKsZiYGqP8+T5Gwz Byze22E8j/bNw2pYp5h4a8118j42TphxaZytHLGo1F0OrsJBaO6Hq3SzcycEgSsmthPthE+YFaJ S/rk3vvzOxoJFRhU= X-Received: by 2002:adf:a18b:: with SMTP id u11mr4669737wru.148.1582890421504; Fri, 28 Feb 2020 03:47:01 -0800 (PST) X-Google-Smtp-Source: APXvYqz0BAxZC0vuVfdrKTugBW7uZS7nErJ64gXrD9UqgMAY8B2pOEjTh7K/y8dhhzFCNjK3dECNSw== X-Received: by 2002:adf:a18b:: with SMTP id u11mr4669648wru.148.1582890419862; Fri, 28 Feb 2020 03:46:59 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id q138sm1127219wme.41.2020.02.28.03.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:46:59 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 03/18] hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header Date: Fri, 28 Feb 2020 12:46:34 +0100 Message-Id: <20200228114649.12818-4-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" The "ioapic_internal.h" does not use anything from "hw/i386/ioapic.h", remove it. Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/ioapic_internal.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/i386/ioapic_internal.h b/include/hw/i386/ioapic_internal.h index d46c87c510..fe06938bda 100644 --- a/include/hw/i386/ioapic_internal.h +++ b/include/hw/i386/ioapic_internal.h @@ -23,7 +23,6 @@ #define QEMU_IOAPIC_INTERNAL_H #include "exec/memory.h" -#include "hw/i386/ioapic.h" #include "hw/sysbus.h" #include "qemu/notify.h" From patchwork Fri Feb 28 11:46:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412087 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AFAB61395 for ; Fri, 28 Feb 2020 11:49:54 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86D63246AA for ; Fri, 28 Feb 2020 11:49:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XDeZf28k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 86D63246AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e9R-0004Im-ND for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:49:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41249) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e79-00082b-GI for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e76-0001Ho-8I for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:29 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53694 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e75-0001HP-PT for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HcSl9tYPSfjtJ+NOfqsYRSXGvzeBOGmRpnqHEMwcJn8=; b=XDeZf28kYIGoxy4pG0EropZLszb0LOm3CmM1Rz2hxxQAbT9SzzVHyPp3pOhoUBntSrSP+Y PxwlXfPV4yAbsHvmIUCdTQ+qwycti3Vf7HFVg4Lc6Hnw5pOSFo74zxLityy8/eU39P/RJn IrnXlPWFR8MekQViCLgvkJNRggKKplE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-260-IvtZlMjQNIi-T1eXS9p_4Q-1; Fri, 28 Feb 2020 06:47:25 -0500 X-MC-Unique: IvtZlMjQNIi-T1eXS9p_4Q-1 Received: by mail-wm1-f71.google.com with SMTP id g26so602810wmk.6 for ; Fri, 28 Feb 2020 03:47:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z3tIZiyEES4D3l4DiwJs/XjoxuErI+/O6hJWeBZfg4c=; b=rQE2BpoK2jjX571FQM/dd5KepTG/zzomrZlS6wleK61/kEYSdtFUXLG5Rvm2c890/j WCAWd0glkOgrzpQJDX3Y7xQvfkvhRmFhSaLdnpY+Ndk78nxgrImj+BLQYP7vfGFg36gI 2uqPAGAPYdU8qJNUEGQ9wmFTXAqZAd9C5/HXUZ6qJAAVt5CzbcIxOFoOBWIpq3Fp3wLa Vjt9bmBmIL/7y/3i7Wyf39esd5bc75PRLn9zQN5ZvkH4/Ec2/Px+yGhlWIReHa8bGfBb zydnWsq/xl6gnrPRNwwiddzX8+L5vXdSO8PwAcZSPACsV/qtQpRiD52sX8zLX5tk+2KZ JGTA== X-Gm-Message-State: APjAAAVGiTprfyKV+NNoQsIV5bKy+FxgXA7TmSvvJOdDza9gVSwgKgaE X/sz/Umfc01PjFw5ZC/CxQ9HCd08y3YC8vqDzeNv9DKt3J5ScwvajxjjChMvK6zfUH1+vn9/PaV vi6zD6wZXpeoZf9c= X-Received: by 2002:a1c:8041:: with SMTP id b62mr3826747wmd.76.1582890444565; Fri, 28 Feb 2020 03:47:24 -0800 (PST) X-Google-Smtp-Source: APXvYqxU73H7mG32Ur+dSO5v+mK7xHg68/d9LWskB3pliSHUYr4inqpSvplnJ/QjyOkGPSYi9yvE+g== X-Received: by 2002:a1c:8041:: with SMTP id b62mr3826732wmd.76.1582890444345; Fri, 28 Feb 2020 03:47:24 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id f1sm12392933wro.85.2020.02.28.03.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:47:23 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 04/18] hw/timer: Remove unused "ui/console.h" header Date: Fri, 28 Feb 2020 12:46:35 +0100 Message-Id: <20200228114649.12818-5-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "open list:nSeries" , Paolo Bonzini Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" The timer models don't need anything from "ui/console.h". Remove it. Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/twl92230.c | 1 - hw/timer/hpet.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/rtc/twl92230.c b/hw/rtc/twl92230.c index 63bd13d2ca..d0011be89e 100644 --- a/hw/rtc/twl92230.c +++ b/hw/rtc/twl92230.c @@ -27,7 +27,6 @@ #include "migration/qemu-file-types.h" #include "migration/vmstate.h" #include "sysemu/sysemu.h" -#include "ui/console.h" #include "qemu/bcd.h" #include "qemu/module.h" diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 8dbcbdca16..4f30dd50a4 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -27,7 +27,6 @@ #include "qemu/osdep.h" #include "hw/i386/pc.h" #include "hw/irq.h" -#include "ui/console.h" #include "qapi/error.h" #include "qemu/error-report.h" #include "qemu/timer.h" From patchwork Fri Feb 28 11:46:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412093 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3651D1395 for ; Fri, 28 Feb 2020 11:50:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C293246AA for ; Fri, 28 Feb 2020 11:50:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MpHaLUBm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C293246AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eA4-0005UW-6E for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:50:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41281) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e7A-00085j-S0 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e79-0001JZ-TM for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:32 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:36440 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e79-0001Iz-Q3 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=73OgrN2M+rMTohi90iBlDHcrDQ0XOXk9OuciFu+Dx5c=; b=MpHaLUBmOg24ni1lZi3xC1LymO2LYimkzhU53Q257Ipjxek2djZ73JUXPx9gZrrLymNdQ6 KTx4LonJ7gvMgJQt6v4e7rFDwftWN9OqSCxXwq/kw03cWC9WVMm/Jsi8+U/RVb2FZRdS3A ulCP8FXNZo59iX9cWJiISnbBwjQLUmk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-dbULidXpOV6StX-QzlDXKg-1; Fri, 28 Feb 2020 06:47:28 -0500 X-MC-Unique: dbULidXpOV6StX-QzlDXKg-1 Received: by mail-wm1-f69.google.com with SMTP id p4so223109wmp.0 for ; Fri, 28 Feb 2020 03:47:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2nnjZZT8SRwguHek+59VriRLt7OR5qsxOtTlGAQZhfs=; b=EZz19cemrYmP6nX+4iSKJnWtCe8adfNJs1FWiiwuk3Kq5vpWFhESsX7A9kPjv6VAP5 PtnqVv7EzNTp7FlR2jVbzi6krbdrhrPq1GvSEvpRRPvN/plmZwRM5f9DOBqRDL8qSwD6 kbpmflewDBQA4/zx9Q952YnB2yRXynEz418pzUmCvXBWGinFb+1ILhdo4myFiLZ3CMZX z/vtpgy6rH64rSd4mInWGJgXp0+Cfx1GbNXacKIb2izVTJVezJqdBtVrS2GuMhA7pugw Pe1vpZuGymx52qztO7JfPcXnEvXIW2BiYmtTg/uA9Q8AEbMy/E/GbDpjApvcqaRZz3D8 cIUg== X-Gm-Message-State: APjAAAVrCX4GE1Hi7Aydz05EAmR03Y17rNunmmZpN/PYiTpa1lXy20Pa iwx1WyjwHB5DRVve9Vi8ERz8PDI+35gxHBUsPRRK7psSBrQMvVzFM4AJ3wmVUBr2Falz4X9DEFV fvBx1OIEZbcgeH1Y= X-Received: by 2002:a1c:cc06:: with SMTP id h6mr4661032wmb.118.1582890446801; Fri, 28 Feb 2020 03:47:26 -0800 (PST) X-Google-Smtp-Source: APXvYqwzy+LStQa1gSChylqIu8s/TQY+qa5cvUG4+ApfOss4KtTM50KgxciBNLjGP10gzmJoTxvMhg== X-Received: by 2002:a1c:cc06:: with SMTP id h6mr4661014wmb.118.1582890446582; Fri, 28 Feb 2020 03:47:26 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id f1sm12392933wro.85.2020.02.28.03.47.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:47:26 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 05/18] hw/usb/dev-storage: Remove unused "ui/console.h" header Date: Fri, 28 Feb 2020 12:46:36 +0100 Message-Id: <20200228114649.12818-6-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" The USB models related to storage don't need anything from "ui/console.h". Remove it. Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé Acked-by: Gerd Hoffmann --- hw/usb/dev-storage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 90da008df1..4883c1d89e 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -17,7 +17,6 @@ #include "desc.h" #include "hw/qdev-properties.h" #include "hw/scsi/scsi.h" -#include "ui/console.h" #include "migration/vmstate.h" #include "monitor/monitor.h" #include "sysemu/sysemu.h" From patchwork Fri Feb 28 11:46:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412091 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 15AB01395 for ; Fri, 28 Feb 2020 11:50:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF917246AA for ; Fri, 28 Feb 2020 11:50:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KGwJZBXm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF917246AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eA3-0005SA-33 for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:50:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41285) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e7B-00086M-17 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e7A-0001Jm-3i for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:32 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:32407) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e7A-0001JQ-0N for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890451; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f8ePsKj5YbwzFmCSbDjLbStV8+VqxxSeQRnfTwIVzUU=; b=KGwJZBXmT07Gv1bApnAxuTj8nYQOZyo9ZDdSyHoDGuvzGyem5qPxfp0tBh0/LF4MZWlteZ e1lBtB4G3+qHRrIa2DmiUQJlC5OxnU2yGj5dE4c3tslDyV6yY3Nr6WFdIEXztsHKwnJOTj /AhIDfFSG88GMJdHcsYU3jCVT8wLAwc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-l2_0s5KrOXO9GRj5UtI4MQ-1; Fri, 28 Feb 2020 06:47:30 -0500 X-MC-Unique: l2_0s5KrOXO9GRj5UtI4MQ-1 Received: by mail-wr1-f71.google.com with SMTP id r1so1213738wrc.15 for ; Fri, 28 Feb 2020 03:47:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=T5sSCEp9I6m1ocN4OvxPRUQZAmULP2h9DUzM0g+WsgY=; b=QfOBjyQBLx04fMyZObzpv6s35E4lLiFqdpNYLsMj53X5btNK97/4Cwh5K0OSRsUgRI p5m9gIy2MCFRQDIrsddFqYFI72j5MRJ/ubtPJNAk8ep95r1+J5JHN3itUIOtDUMyFDFh WCnJEkDjc+CGnU7HvckYDLL8bDEX0Lk8+8x6vjuB6S24zDJj+nL6nzD8oumVcRkW/BQy CQj7lQuoWh+TcgoEp2mmXiEMnw2+swctiJZ5OFnMiwHOx8n1iQKRAAfenWOxBgr57ZYw VV+yrs5INMbmP/0TpwXxC7JgSpgmRZiDZkx+ix+KVLtuewBjxyZgEAxvzF0V64hjcMue z7Pg== X-Gm-Message-State: APjAAAW88E450Fr2JgzZ/ohYN+XgC9AqGfcYOSxpVqdW41n33c+nvnNN hQKn12Y2rHcfqemBrEEHDk9PFemN9JGtw5ZzMCsGZaCoAwowf/HoSbEDIZgIBnLR1nL4QizOSRe hEWywJsFHsB0MdMY= X-Received: by 2002:a5d:6690:: with SMTP id l16mr4741426wru.251.1582890448646; Fri, 28 Feb 2020 03:47:28 -0800 (PST) X-Google-Smtp-Source: APXvYqzHAG/V9Lgl4O+xWBzgNCPVxffpQWXf5zY4ukcAq+l3DPwWUAFh33GHGippgrBm9pBGh5AtmQ== X-Received: by 2002:a5d:6690:: with SMTP id l16mr4741418wru.251.1582890448489; Fri, 28 Feb 2020 03:47:28 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id f1sm12392933wro.85.2020.02.28.03.47.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:47:28 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 06/18] hw/i386/intel_iommu: Remove unused includes Date: Fri, 28 Feb 2020 12:46:37 +0100 Message-Id: <20200228114649.12818-7-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" intel_iommu.h does not use any of these includes, remove them. Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/intel_iommu.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h index 66b931e526..a1c4afcda5 100644 --- a/include/hw/i386/intel_iommu.h +++ b/include/hw/i386/intel_iommu.h @@ -22,11 +22,7 @@ #ifndef INTEL_IOMMU_H #define INTEL_IOMMU_H -#include "sysemu/dma.h" #include "hw/i386/x86-iommu.h" -#include "hw/i386/ioapic.h" -#include "hw/pci/msi.h" -#include "hw/sysbus.h" #include "qemu/iova-tree.h" #define TYPE_INTEL_IOMMU_DEVICE "intel-iommu" From patchwork Fri Feb 28 11:46:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412099 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B5B2C1395 for ; Fri, 28 Feb 2020 11:51:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C5AD2084E for ; Fri, 28 Feb 2020 11:51:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i7j6u6Cn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C5AD2084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eBC-0007lr-Mj for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:51:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41310) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e7D-0008Bz-7A for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e7C-0001Kl-7T for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:35 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:52822 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e7C-0001KY-3t for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:47:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DiwsHxYwluw0cuqUGGkA84vK67eK7P8CIbL4qQHkagU=; b=i7j6u6CnobDzPROWYSc0HKFpfSYmfqaHtFJgUD//dXOdvca/zle1kUT1OyQ8P0xt36Gghu iDxynAKbb4NebQ2boVQfTTXsPgsFO57yJJ0Igb3GkzWGxLjEVJFqDAEPSSPDNgGItWr71I G6/HSbyodjTEW63yqSUWwjnGHtOcxIw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-GtnUaRC7NrCgOVbWh7L1cg-1; Fri, 28 Feb 2020 06:47:32 -0500 X-MC-Unique: GtnUaRC7NrCgOVbWh7L1cg-1 Received: by mail-wr1-f71.google.com with SMTP id u18so1216089wrn.11 for ; Fri, 28 Feb 2020 03:47:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=to/q+TAGTTV4TMCuXzmoJpC1A+khKH9U1vgS0Q0SFBQ=; b=D8iEzpD0X99HPpcrC6rnYXtaTaHEHUB47d5o1BEwmj04zDIyFHH/w2O17YXiLHNV+s PWPRDZUctpGlhC8hV36dO6Ak7fwPb8u8Nw4OIyIibNfvuOuD1WxSBNWd+Y7MRN+sIWCk 5mFF77OnxxSmzQ7BiwM24+9u+iFLg8mUCgIFTrGdGH69YtnXy3kCZ2BKO9hagatCnBkE TUPb2UikL6sr6HnYIuNjt9aayQrUHLSCcDbZe8ZUb8djPTjuy2eItLaOJbsEsdaISWTk Q2Hq+n/vPGd/ogBLtZszh5ihSdB+rcPylZnCs0QvBI04+pBluNjLfhbgoF1fhfUaeb90 dL/g== X-Gm-Message-State: APjAAAXEDkKHkDRT7sWcn9oyMb8cWx1OKH7sTo9wmDF30GhzD9noxg0r GHjNiwQX+AqsDNOEnR6D5i1RJMjV0YPCCo3dReJaqA+RsKvDBy1QYfDHcfw97Qr72Fj1qS2l1IZ RdJIT3SPlzkZKXDQ= X-Received: by 2002:a5d:6acf:: with SMTP id u15mr4730030wrw.182.1582890450753; Fri, 28 Feb 2020 03:47:30 -0800 (PST) X-Google-Smtp-Source: APXvYqwbYVgKMpk9DJ8B7pHReS32Q1gRnOWtmkXXObPKFyp+aHeVvajmQ2zyC3PKEWm6GwHFHu/Rzw== X-Received: by 2002:a5d:6acf:: with SMTP id u15mr4730013wrw.182.1582890450581; Fri, 28 Feb 2020 03:47:30 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id f1sm12392933wro.85.2020.02.28.03.47.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:47:30 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 07/18] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header Date: Fri, 28 Feb 2020 12:46:38 +0100 Message-Id: <20200228114649.12818-8-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , John Snow , Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" alpha_sys.h does not use anything from the "hw/ide.h" header. Remove it. Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/alpha/alpha_sys.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/alpha/alpha_sys.h b/hw/alpha/alpha_sys.h index bc0a286226..e2c02e2bbe 100644 --- a/hw/alpha/alpha_sys.h +++ b/hw/alpha/alpha_sys.h @@ -6,7 +6,6 @@ #include "target/alpha/cpu-qom.h" #include "hw/pci/pci.h" #include "hw/pci/pci_host.h" -#include "hw/ide.h" #include "hw/boards.h" #include "hw/intc/i8259.h" From patchwork Fri Feb 28 11:46:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412107 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9486814BC for ; Fri, 28 Feb 2020 11:53:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C521246B0 for ; Fri, 28 Feb 2020 11:53:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Mg8/aqnG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6C521246B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45894 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eDK-000397-Ku for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:53:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41381) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e7e-0000Qn-Ee for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e7d-0001Qk-84 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:02 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:49962 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e7b-0001QI-Ey for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=clfu+t0nynKAESV4ABRDyRXkvPXe/x1JrxJoUGidyU8=; b=Mg8/aqnG5wg+38GlAPBS9AUzdAkQ7ou90jVBP6UTcwqHE/dAmR+TYrJ7dv2qsfW42F0ZgC 6oAzPYhP3sCqhEzIvm65DosjFLWPJEoA4BTCCyqqZswSTfbw3pxQuXKLZq22JasCsgfUtN baRlrHcoZq2B8ZkhN+V6zCqMmxcb80U= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-Hs-GRtRMMWusOVFh-QMZ3Q-1; Fri, 28 Feb 2020 06:47:55 -0500 X-MC-Unique: Hs-GRtRMMWusOVFh-QMZ3Q-1 Received: by mail-wm1-f72.google.com with SMTP id m4so1051859wmi.5 for ; Fri, 28 Feb 2020 03:47:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=U8Eqv2g+dIkDMylSsAtJ9DdMEi7WvLS94birm3uZOd0=; b=P2+Egw7qHPWuWr57VDByXhmblVesimgi7lH4NuKKTMVbEwmdJDLjxDpR4xNMToPIqt oRq5L7IKxivsgdWTD+YxG0jYC238tKTggT1WlBhr6mj012BxD5ibE6MEm0yNms5UnYjD zel+jajGoYXYVV2i8tnaPcBmUiZoUraNWjG9Il/RuQK0jnFDdEC8kNBSq9K87dN/1VYX BdpBvsKTIzaJaZa9PMgVewXWy5DeAhAEhv1Rep14YMJDoe8u24lvHRx4dYKZlOfyWXzv BNCPznp0MbslkfAawhwCvSFmzHH9qZj85T5XJY/joYI3xnvrMHTzyiRm0MroDWWdjpel VaNA== X-Gm-Message-State: APjAAAUWTpGMqQxyHO9cAiTdZ1FSWBfCZx9XdAMpC2jqYkmJ/lCWiW63 RKyixKvy6wzmjaXEwgEHb2IhY1IFifPIEjD83j7q68ERpv1HAfqkJcCxaDeDzpYm8WiXZOy4/Ud W7ihJXumrxJQjW+4= X-Received: by 2002:adf:e542:: with SMTP id z2mr4756443wrm.150.1582890473976; Fri, 28 Feb 2020 03:47:53 -0800 (PST) X-Google-Smtp-Source: APXvYqx2iWI36tGdl0VSywd6QUA69oq7tyrDCvfw5F6lrV8yE8S+cSaCD2mEtcb5YzQahCaHekJkMw== X-Received: by 2002:adf:e542:: with SMTP id z2mr4756429wrm.150.1582890473738; Fri, 28 Feb 2020 03:47:53 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id v8sm11901514wrw.2.2020.02.28.03.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:47:53 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 08/18] hw/alpha/dp264: Include "net/net.h" Date: Fri, 28 Feb 2020 12:46:39 +0100 Message-Id: <20200228114649.12818-9-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , John Snow , Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" hw/alpha/dp264.c uses NICInfo variables which are declared in "net/net.h". Include it. This fixes (when modifying unrelated headers): hw/alpha/dp264.c:89:21: error: use of undeclared identifier 'nb_nics' for (i = 0; i < nb_nics; i++) { ^ hw/alpha/dp264.c:90:30: error: use of undeclared identifier 'nd_table' pci_nic_init_nofail(&nd_table[i], pci_bus, "e1000", NULL); ^ Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/alpha/dp264.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/alpha/dp264.c b/hw/alpha/dp264.c index 8d71a30617..e264c783c1 100644 --- a/hw/alpha/dp264.c +++ b/hw/alpha/dp264.c @@ -21,6 +21,7 @@ #include "hw/dma/i8257.h" #include "net/net.h" #include "qemu/cutils.h" +#include "net/net.h" #define MAX_IDE_BUS 2 From patchwork Fri Feb 28 11:46:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412103 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 97B361395 for ; Fri, 28 Feb 2020 11:52:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6EF262084E for ; Fri, 28 Feb 2020 11:52:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GozzZqWD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6EF262084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eC3-0000cj-JO for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:52:35 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41393) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e7f-0000Ro-3n for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e7e-0001Qz-2j for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:02 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:44103 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e7d-0001QO-8R for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oG2syAmxddzmH8pkr5M8RpghUELPZIGL0i8vM3fPgM8=; b=GozzZqWD+n0mUsTSR1ocj1s+WW4MTkdVF9hzwJb2PQA2iBINKkUEt1BWWG422QnU+MgGz/ aE1VxINWKow3XGgkI0fEzCfesQgJ6aVoItk1gUD7UcwSRxZaZHkpu32WR2ELfNIMZ6aXF+ rvmvJ7TYaCVR4BSEI2HMW9pTfdogKzs= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-455-cDCv7LXzPtmT5UliULvHrQ-1; Fri, 28 Feb 2020 06:47:57 -0500 X-MC-Unique: cDCv7LXzPtmT5UliULvHrQ-1 Received: by mail-wr1-f72.google.com with SMTP id c6so1209433wrm.18 for ; Fri, 28 Feb 2020 03:47:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CyFzDanqkMTdQtUsYemEsgIvaK/rIvnd/I4zWxBCovs=; b=h/nGsJwiPRxktX0ANS3xni/lm/aCZBpZNsbeiUHSCyjCzRn8RhMSAV5Gm6eGRuZn+k NObW0zztD9oAspIvkXZHv1YJuj4Vs9DbkwAunoLaWTonHRIc7bd2C50TY5phG8m5vgJG 0EhflBcCkBZGRGlj+HdifYek38BPU7fkf5bRjSypsnu0nFoTGvsGJHKCqh+BLyMhMhpv Yo8VU4t6cKHVCUr/4fLA9Pa1KYpbNsslZmUIbJ/zqxb4FOYK0NNPyG79Jqa+cZrWah54 ZjyB8E47l8TGh2ybHN8+iJbUc4qzJx+/RL1i9/G0LPBFz5DkiPNfaBFLAukB9CK7lzLw W5yA== X-Gm-Message-State: APjAAAU1aq/ljn2rcWUCJhoW++Z3SaURObENFy1HPJqv3YUtkYM4rOM8 KyspcPS1+3cU3SewGykbPnkpBIix9krKhNF8mg0bqqurjZC+8lCnc9LvRFhmxRop79tNVoHBg91 VhauFMMPi7sCc80M= X-Received: by 2002:a1c:e483:: with SMTP id b125mr4581417wmh.187.1582890476135; Fri, 28 Feb 2020 03:47:56 -0800 (PST) X-Google-Smtp-Source: APXvYqxoc2NmSiQbBjwvkZ7JfDbfzavlQedgqjrfKmu67Pq/AxFihGtFt1BaY87Dd2WcjsWhpewNUw== X-Received: by 2002:a1c:e483:: with SMTP id b125mr4581397wmh.187.1582890475900; Fri, 28 Feb 2020 03:47:55 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id v8sm11901514wrw.2.2020.02.28.03.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:47:55 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 09/18] hw/hppa/machine: Include "net/net.h" Date: Fri, 28 Feb 2020 12:46:40 +0100 Message-Id: <20200228114649.12818-10-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Helge Deller , Paolo Bonzini , John Snow , Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" hw/hppa/machine.c uses NICInfo variables which are declared in "net/net.h". Include it. This fixes (when modifying unrelated headers): hw/hppa/machine.c:126:21: error: use of undeclared identifier 'nb_nics' for (i = 0; i < nb_nics; i++) { ^ hw/hppa/machine.c:127:30: error: use of undeclared identifier 'nd_table' pci_nic_init_nofail(&nd_table[i], pci_bus, "e1000", NULL); ^ Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/hppa/machine.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 67181e75ba..d1e59a97f6 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -22,6 +22,7 @@ #include "qapi/error.h" #include "net/net.h" #include "qemu/log.h" +#include "net/net.h" #define MAX_IDE_BUS 2 From patchwork Fri Feb 28 11:46:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412105 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9C05414BC for ; Fri, 28 Feb 2020 11:52:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72B042084E for ; Fri, 28 Feb 2020 11:52:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PrvmETWy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72B042084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eC8-0000lg-L2 for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:52:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41435) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e7g-0000V2-8I for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e7f-0001SK-9B for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:04 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:60677 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e7f-0001Rk-5r for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HrRTVdOozv2swNberymfD/6/LBZVv8zEj+lFL8+gIA8=; b=PrvmETWyOxiyo3gYRHdvQCzoJzhWpQyeckfHzjIRstVZHFNSYfBlgc+LC6xArArTsxCu5M Fj0ZXULFwoXxiLgZZXH4xxW1vFKSgJ4RtergABTyeelPeZNyNSPkgMJYtAy360u+oHNOJf SLJQeUj/lWltQVxdEPagKn6uiMYmWkU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-446-wWCx-xZaNZaFSlmBJDwAAw-1; Fri, 28 Feb 2020 06:47:59 -0500 X-MC-Unique: wWCx-xZaNZaFSlmBJDwAAw-1 Received: by mail-wr1-f70.google.com with SMTP id z15so1238868wrw.0 for ; Fri, 28 Feb 2020 03:47:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Yh9hMHA4I8RamAySV+tXZ2gxC3VYLXS2TKM9OKFdh90=; b=EImRpJ9TyBlRu/HnzyFcpsGwfJJejF7b7MT8SEBIyIk2tPPyI/T9P1zGkYyNP7YDzV tzm06iVKSZsJLGItHA4Pwyjm+BIM4W5OEGoebp28bwGDM5bkF958vjPWJe/1VXkGMToH mify985dbt4sTbFeJMULtG4lqXHpRIWPZrREbdl6Txz42UxZWFd8NnuHaD6rWODnwI40 1KjpzkQO2PQ0B7WIAadZ7VVvUYlUvQYN6Scju20iCd+reBcBW04BVQgCTbVPkhFYma9g Yapf1rVR9aAzuSwGrVedfhLJt5mdfWEnRvjBJ7gZVJRSB6NaEV6ZvXq7Opegg5GlR+EB lHpA== X-Gm-Message-State: APjAAAWlFLHqscIwyLtn6FBx2BABha8ZQEyiduGhmBIaPajWfBsi1T51 szq3TXTmAFPnFVUdHabutPdPFbhlKXNsnO7IoA7kekJdM0i1Ej3Lo4+Hz5BrjvL5Rxa/0jiiv2b 8rFgiW62lyhwCtmU= X-Received: by 2002:adf:fa0f:: with SMTP id m15mr4775671wrr.392.1582890477936; Fri, 28 Feb 2020 03:47:57 -0800 (PST) X-Google-Smtp-Source: APXvYqwahxOejGcUYrooOz98isjVLiq45yBuIhe5WFJkm0IJ2JEUp/XhHUcozZZ87r4B+zm0T+daZw== X-Received: by 2002:adf:fa0f:: with SMTP id m15mr4775659wrr.392.1582890477766; Fri, 28 Feb 2020 03:47:57 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id v8sm11901514wrw.2.2020.02.28.03.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:47:57 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 10/18] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h" Date: Fri, 28 Feb 2020 12:46:41 +0100 Message-Id: <20200228114649.12818-11-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Igor Mammedov , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" hw/acpi/cpu_hotplug.c calls pci_address_space_io(). Include "hw/pci/pci.h" which declares it. This fixes (when modifying unrelated headers): hw/acpi/cpu_hotplug.c:103:28: error: implicit declaration of function 'pci_address_space_io' is invalid in C99 [-Werror,-Wimplicit-function-declaration] MemoryRegion *parent = pci_address_space_io(PCI_DEVICE(gpe_cpu->device)); ^ Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/acpi/cpu_hotplug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_hotplug.c index 9c3bcc84de..3e687d227a 100644 --- a/hw/acpi/cpu_hotplug.c +++ b/hw/acpi/cpu_hotplug.c @@ -14,6 +14,7 @@ #include "qapi/error.h" #include "hw/core/cpu.h" #include "hw/i386/pc.h" +#include "hw/pci/pci.h" #include "qemu/error-report.h" #define CPU_EJECT_METHOD "CPEJ" From patchwork Fri Feb 28 11:46:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412109 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DBB161395 for ; Fri, 28 Feb 2020 11:54:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B301B246AC for ; Fri, 28 Feb 2020 11:54:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="P6w2swx1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B301B246AC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45898 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eDe-00040L-SH for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:54:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41432) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e7g-0000Ud-4I for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e7f-0001S4-2f for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:04 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:20072 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e7e-0001RW-Up for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890482; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ZikWdiIjGHwkJ5s5xsyOGuFMUcLn0/m4b9roi2lzt0=; b=P6w2swx1ntky0vhExHpbrQ3FrNowzCFipoqxjdW47cOeEFiV1PDxBCjcx2FuY6EYlilA2V ulByqMJztbA/7/Kj178/PGk7s9hoGNRDqY97VD431vNx0SxSp2iEm7LWuiMjxrfgRpJgYJ TZug8qi+MK5WX4AeluOmylgFPsGxWls= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-277-tBQeJ797M0u4o4U0eLeybw-1; Fri, 28 Feb 2020 06:48:00 -0500 X-MC-Unique: tBQeJ797M0u4o4U0eLeybw-1 Received: by mail-wm1-f72.google.com with SMTP id y18so1545285wmi.1 for ; Fri, 28 Feb 2020 03:48:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7/Nc+BormBNRjwYo07kcxhw053jMRgcHlLvuvF2I3Yg=; b=B8wDl7UYifgBRWBB4pmy1r+J68oEgsgLaA/WMTzk4mX5W9ZsIGc2AL6xovn8TPVmPF sNayEnnAXpM4L9IJrJTd7jlNQstKKS6xeRfaNxkDce/2xA1sBmGoYaPL6bpGA0EtK5z5 EbQoTvanFs3CM5TlkRPVdZ7weh9XpVHnUl5SaA5FGbhIbW70daNzCd/5adYWeep8ZO5S QO307tAICbDnqNVPpKRbawYoveKmt29yh4Vhh4oaiO81o7O8IdQQH1BC4PQu12eKLXYp RAOAMaTRUFS0Of/lQn7dEyOGfNIGlOiNDgf10UTqmMMmeUQl4JQOBpwMm3uIenjQd4R6 Ri3A== X-Gm-Message-State: APjAAAURYpkZeYjbc76/2rZFf2BJO3yyDUEVpHEM3a4G4uGAl4mMoR9S HC1eJ/76lC24J4Vdk5eDyzdQJI4wfVO0ypa9bRFM84v2tWi8F7Yalexz7LOCceTmUgXTqdu8h6Z 42yvLAugii3j6RqU= X-Received: by 2002:adf:fc10:: with SMTP id i16mr1242381wrr.331.1582890479512; Fri, 28 Feb 2020 03:47:59 -0800 (PST) X-Google-Smtp-Source: APXvYqwX1PlFUd70akunglxnfTPEuLh7bKZtTlkbg22tnwWQsflCw+cuFlsy7JGHo5YlLqdJeeG/ug== X-Received: by 2002:adf:fc10:: with SMTP id i16mr1242372wrr.331.1582890479343; Fri, 28 Feb 2020 03:47:59 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id v8sm11901514wrw.2.2020.02.28.03.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:47:58 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 11/18] hw/timer/hpet: Include "exec/address-spaces.h" Date: Fri, 28 Feb 2020 12:46:42 +0100 Message-Id: <20200228114649.12818-12-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Paolo Bonzini , John Snow , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" hw/timer/hpet.c calls address_space_stl_le() declared in "exec/address-spaces.h". Include it. This fixes (when modifying unrelated headers): hw/timer/hpet.c:210:31: error: use of undeclared identifier 'address_space_memory' address_space_stl_le(&address_space_memory, timer->fsb >> 32, ^~~~~~~~~~~~~~~~~~~~ Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/hpet.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/timer/hpet.c b/hw/timer/hpet.c index 4f30dd50a4..380acfa7c8 100644 --- a/hw/timer/hpet.c +++ b/hw/timer/hpet.c @@ -36,6 +36,7 @@ #include "hw/rtc/mc146818rtc_regs.h" #include "migration/vmstate.h" #include "hw/timer/i8254.h" +#include "exec/address-spaces.h" //#define HPET_DEBUG #ifdef HPET_DEBUG From patchwork Fri Feb 28 11:46:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412123 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C822814B4 for ; Fri, 28 Feb 2020 11:56:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F1BD24695 for ; Fri, 28 Feb 2020 11:56:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YplGmz8k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F1BD24695 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45950 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eFQ-0007KT-Vs for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:56:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41553) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e88-0001YE-2V for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e86-0001Xn-5c for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:31 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:43315 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e84-0001XG-CS for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ci83psJipRLmMM102aFH9DJiTrhuqoBAGmTaxPcC9V0=; b=YplGmz8kQImkHexFY+P3QjXD2FqsvrQ5RMzgi3DJR7hCDdpSBnQb5ThFdaqCreBVNmbl/U 3xe4V1F28BKZCN+bfbJD7ytcWgAEAuHiUZqZ7irArvUnW3CbDmyxs6K/Lw9bUxaWG6Ux+J HroJ4YRIKTCfHHt7YHW2CkUb8Gnbdyo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-49eLOWIyPhmUMHfZQUghcg-1; Fri, 28 Feb 2020 06:48:25 -0500 X-MC-Unique: 49eLOWIyPhmUMHfZQUghcg-1 Received: by mail-wr1-f72.google.com with SMTP id p11so1223219wrn.10 for ; Fri, 28 Feb 2020 03:48:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WbQgs/ipNL+I36ywVUaG4Y7AH+d71TJ/LBgfF4qcL6Y=; b=f2WuNHt1tNumJFbXSN3+L6cWe2Ug599cvdXqiDZCiZPzGxh+4Jxl6ij2iJCNBn7JTr c4KJwzAObtPzoKWPGiadhPoS96DrFP8F2Vv61bpWPPMFbhpe731vhyS/7xkLA+1KtMVh 0am46W/5FAPACv4JvZDka+pZssReJbTjUPbci2wwytKWlTMSz0oOGn4nnX5q2xaUCp/m 0eLjc9nh3dSDsRa5r1BRW9GVC9YRfWOOsl5fKKxfA/fn6o9NKuZ6eqA/VBvbZD5ldHGw IyoABQ1iIQ1fct0HNC9bEjzX+2FnC/fNPXSQ2H1CycW7VtKf87lz0D3wRTB1F5aLFe5b CKcw== X-Gm-Message-State: APjAAAXJWbv0+3Bo0EPYE2V9sGk87wBoepv9fbT7Rm1ck8lDDc03ZUB+ LL6j33rhZlIRIm8dU25nbamQKFnRNe4uCcx6dGSHcqcrQWQL652SM+dtZZFLhWhIFLNoS6jIvNj t+qQKUe8Twc4GTVM= X-Received: by 2002:a7b:cc95:: with SMTP id p21mr4227978wma.184.1582890503681; Fri, 28 Feb 2020 03:48:23 -0800 (PST) X-Google-Smtp-Source: APXvYqwQABjkSoRhQ7mYf4Fp+XHNAFXX1MGC0FklN6t+jzS2XcS2Mg7+aoV7AAxB6mPPvyteIIs53w== X-Received: by 2002:a7b:cc95:: with SMTP id p21mr4227957wma.184.1582890503469; Fri, 28 Feb 2020 03:48:23 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id a7sm1736226wmj.12.2020.02.28.03.48.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:48:23 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 12/18] hw/pci-host/q35: Include "qemu/range.h" Date: Fri, 28 Feb 2020 12:46:43 +0100 Message-Id: <20200228114649.12818-13-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" The MCHPCIState structure uses the Range type which is declared in "qemu/range.h". Include it. This fixes (when modifying unrelated headers): In file included from hw/pci-host/q35.c:32: include/hw/pci-host/q35.h:57:11: error: field has incomplete type 'Range' (aka 'struct Range') Range pci_hole; ^ include/qemu/typedefs.h:116:16: note: forward declaration of 'struct Range' typedef struct Range Range; ^ Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci-host/q35.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/hw/pci-host/q35.h b/include/hw/pci-host/q35.h index 976fbae599..47086c645e 100644 --- a/include/hw/pci-host/q35.h +++ b/include/hw/pci-host/q35.h @@ -33,6 +33,7 @@ #include "hw/pci-host/pam.h" #include "hw/i386/intel_iommu.h" #include "qemu/units.h" +#include "qemu/range.h" #define TYPE_Q35_HOST_DEVICE "q35-pcihost" #define Q35_HOST_DEVICE(obj) \ From patchwork Fri Feb 28 11:46:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412101 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C8E191395 for ; Fri, 28 Feb 2020 11:52:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F8372084E for ; Fri, 28 Feb 2020 11:52:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Tuyo18zF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F8372084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45858 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eBz-0000SF-Qh for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:52:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41565) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e88-0001Z5-L2 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e87-0001YA-CD for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:32 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27183 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e86-0001Xe-5L for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a2Kfw5nEVFcSKCWzcOhteR6YpW54ZFAnQQKQBI2MXqg=; b=Tuyo18zFbKQAqU6TuN/qAMGMP2b17He54fHcdkzIso9H8s30HAV9fjMJhy2IfyzYEXjz1c P0+aUo5rZSHy9d454ih/iRR/DD+nVWKXsNZMjE9QjO+wTLFPstKgWyG+o4aAP4QY2lpaO0 zM0YJjiQbKkmdCn6TUYcrOX2Qi3laC4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-248-_Dos33FHPzKrxCrBLO2oAA-1; Fri, 28 Feb 2020 06:48:27 -0500 X-MC-Unique: _Dos33FHPzKrxCrBLO2oAA-1 Received: by mail-wr1-f72.google.com with SMTP id z1so1226120wrs.9 for ; Fri, 28 Feb 2020 03:48:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UifnvwpH88RzXCfeYrjEOymeXNUW1ByC1YLamNivAUM=; b=cMy7ck6/YQfpQlXX8T0bwlosi3NDZpJBTMp9ej5Xn/zX6szqSNgH3UTFT5NC4u7GMN ljAsENUCwOiMX4RqfpNFRU5GtHEZ7oVdb7YwjLWiUw+r0b2/l7xrVIbM1eXkcS5eC8CD jH5YBCykx7kw5l42Re5pn2HI4WNohP83k/L2S9BRzpL4tJ4BxShC+mNT+pf8F5pIEWii CBrNcNfdHiIvm62WaMTq3Oy2I8EAdoRpRMQdgVlxGUhlPbdcI+wl0mJV3haK2IanLVCH yyayPKXSXSnKuC19Gdd8iUCABmwAJrJ6rIGBcf+HsEIYoFnDB2dIfVcnkZqKJeRd3Nsl xGKQ== X-Gm-Message-State: APjAAAWoU2nkssTPdS4FJ25Vn/ro7tcpgu1/ksVdML41Um4q3nNAcu/c +PHVBq0naCuf0Q02cMrwtaVEoq6vHOJX5iTiaGs+k4Krh8vAj5yTAVV7PrLYPQ61VOFi3bzIMDR yvOqfIet2N0IcT0k= X-Received: by 2002:a05:6000:1142:: with SMTP id d2mr4433722wrx.62.1582890505822; Fri, 28 Feb 2020 03:48:25 -0800 (PST) X-Google-Smtp-Source: APXvYqw/YOGrrKpPqdBU/A8oP0QeSk83ur85tLpWBnJ8ZzExIf0wpFgLDVPZSkRhqNA7dkInB/MwmQ== X-Received: by 2002:a05:6000:1142:: with SMTP id d2mr4433710wrx.62.1582890505589; Fri, 28 Feb 2020 03:48:25 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id a7sm1736226wmj.12.2020.02.28.03.48.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:48:25 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 13/18] hw/i2c/smbus_ich9: Include "qemu/range.h" Date: Fri, 28 Feb 2020 12:46:44 +0100 Message-Id: <20200228114649.12818-14-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" hw/i2c/smbus_ich9.c calls range_covers_byte(). Include "qemu/range.h" which declares it. This fixes (when modifying unrelated headers): hw/i2c/smbus_ich9.c:66:9: error: implicit declaration of function 'range_covers_byte' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (range_covers_byte(address, len, ICH9_SMB_HOSTC)) { ^ Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/i2c/smbus_ich9.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c index fd50fb851a..48f1ff4191 100644 --- a/hw/i2c/smbus_ich9.c +++ b/hw/i2c/smbus_ich9.c @@ -21,6 +21,7 @@ */ #include "qemu/osdep.h" +#include "qemu/range.h" #include "hw/i2c/pm_smbus.h" #include "hw/pci/pci.h" #include "migration/vmstate.h" From patchwork Fri Feb 28 11:46:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412137 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BD49692A for ; Fri, 28 Feb 2020 11:57:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93ABB24695 for ; Fri, 28 Feb 2020 11:57:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZxjEki9N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93ABB24695 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45960 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eH3-0000c2-RJ for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:57:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41591) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e8C-0001b6-Oq for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e88-0001Yp-JZ for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:35 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:39214 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e88-0001Y0-1G for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890510; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cEF3Qmm6bE7IZabHdbGWU2GA8rYBohVngOoUCB4NjXg=; b=ZxjEki9NILGxicYSVqdKrkAdZr8RnB1JOAOlo7H5PhKEJDa8pEbMOXL5jB/tv3YaBpEoUG cV9Zj1SXrkqYZF8lR/ViHW4MLMwVPvhybAgXKBoNyysFJaKToF89GCUu9QyRoTSwAa6ITZ fmTvKpSRph6vFY9vU/dDDs0v3E7RqX8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-315-Q77IFNMoOo2szqezyUf37w-1; Fri, 28 Feb 2020 06:48:29 -0500 X-MC-Unique: Q77IFNMoOo2szqezyUf37w-1 Received: by mail-wr1-f71.google.com with SMTP id d9so1211915wrv.21 for ; Fri, 28 Feb 2020 03:48:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6DEmu3UhSlAtdyxITMuOrN+F2EwIEtEtHDhOq1i9rRk=; b=Jtb/6iAjQwftPMFbe6SenTXierSiSak3CsoJbMY7za1NTkXO/03t0E5IhzriBXnuLS BiOQfMO6J2VgB6e72BDsLEel8o4KAGtDp/gSMVNXrMTaM7eWCUCQgJWs0yA2SOF64+0c 6ZfGYa4ojeK7ephGtmNdigdJ+5OZAhLcg2g9cfLpS6kdMpwhh2IsGMs2jr4EH7/9t4fw jO40pcLj5u5lhr3EDi+2YMnuVpxMYd83igWyfJk1i2vRtg8+EhGNIZlcz1jWW4xr3Srf Osx9aiknYGNW01HC3/U4d1EgpyZa0RPxFTikRmV+gO0TUQJxe4EpOariPjRPMXPzXhqJ OHPQ== X-Gm-Message-State: APjAAAXKI4nz0BZUrQ4+kBy0Lm4BVsBZkAMpAFmf8+qIiFjbIXtU4lB8 APQOWGHfLx2vlmI7qDCwPAw661AiOChQioe9We2DAZcX6A810Q2XYXVStpnpYxz5YAl9R5UG6ln C3HWCcXl5AWYOT6c= X-Received: by 2002:a5d:4807:: with SMTP id l7mr4517283wrq.250.1582890507730; Fri, 28 Feb 2020 03:48:27 -0800 (PST) X-Google-Smtp-Source: APXvYqyNYVNMWTQjegzutGFS+8XkogW6S5ZGVDfIKgqyfXf0BvGfRQWXe6SPhJap5Z/7qIyfYFZGOA== X-Received: by 2002:a5d:4807:: with SMTP id l7mr4517268wrq.250.1582890507564; Fri, 28 Feb 2020 03:48:27 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id a7sm1736226wmj.12.2020.02.28.03.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:48:27 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 14/18] hw/pci-host/piix: Include "qemu/range.h" Date: Fri, 28 Feb 2020 12:46:45 +0100 Message-Id: <20200228114649.12818-15-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" hw/pci-host/piix.c calls various functions from the Range API. Include "qemu/range.h" which declares them. This fixes (when modifying unrelated headers): hw/pci-host/i440fx.c:54:11: error: field has incomplete type 'Range' (aka 'struct Range') Range pci_hole; ^ include/qemu/typedefs.h:116:16: note: forward declaration of 'struct Range' typedef struct Range Range; ^ hw/pci-host/i440fx.c:126:9: error: implicit declaration of function 'ranges_overlap' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (ranges_overlap(address, len, I440FX_PAM, I440FX_PAM_SIZE) || ^ hw/pci-host/i440fx.c:126:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] hw/pci-host/i440fx.c:127:9: error: implicit declaration of function 'range_covers_byte' is invalid in C99 [-Werror,-Wimplicit-function-declaration] range_covers_byte(address, len, I440FX_SMRAM)) { ^ hw/pci-host/i440fx.c:127:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] hw/pci-host/i440fx.c:189:13: error: implicit declaration of function 'range_is_empty' is invalid in C99 [-Werror,-Wimplicit-function-declaration] val64 = range_is_empty(&s->pci_hole) ? 0 : range_lob(&s->pci_hole); ^ Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/i440fx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index 11050a0f8b..d980c97049 100644 --- a/hw/pci-host/i440fx.c +++ b/hw/pci-host/i440fx.c @@ -23,6 +23,7 @@ */ #include "qemu/osdep.h" +#include "qemu/range.h" #include "hw/i386/pc.h" #include "hw/pci/pci.h" #include "hw/pci/pci_host.h" From patchwork Fri Feb 28 11:46:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412139 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3E5F814BC for ; Fri, 28 Feb 2020 11:58:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13FAF24695 for ; Fri, 28 Feb 2020 11:58:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DuoicvW3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13FAF24695 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eI2-0001aT-8n for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:58:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41620) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e8G-0001hT-El for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e8F-0001aC-AH for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:40 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:42829 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e8D-0001Yy-Gb for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890513; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a8BGhqYvAxWxH9RR4HNdmBjAggFWzcDPf58d0HXElA0=; b=DuoicvW3PmlexqPMhZY8s2aZ722x1GIQEUUbuDs8Bi86j8E/x8hZM/mt8zlas+T/K+enzU faBINFLteVjPZwuBfLur3fr14bPPxhHMcZdSWnkWwIImzOWdXlwDSi5/Qd0N5uSgRuT9kn VRZ90d6CH/7hNg8XosF7kRyJzdwAx0s= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-79-M5O2Ii90ONi62I8_cEzHHg-1; Fri, 28 Feb 2020 06:48:31 -0500 X-MC-Unique: M5O2Ii90ONi62I8_cEzHHg-1 Received: by mail-wr1-f69.google.com with SMTP id z1so1226188wrs.9 for ; Fri, 28 Feb 2020 03:48:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XJL8zcwpbbfm3fUEVt8ZadYdnagmELDf/cCcBxJaPzQ=; b=sGexRy0KhqTzBxa58HKemQKWeJAHvN8QjEdlHH3G9C/Etl6w8axr3ce6O/mwmtYZgg vRN92fhnhzSJlJBaAqiVWte0kzCBTrkDP+99HFJ+KcF0XUB7Qr+sbhkKfxXmXJr8Kb7u 2E2T8sdot8k1ERD51TuhRveZxgdf2OFauDPHdaxSIWD3yYD0cWeE6XNR0b/YgccdBXcf x2LdngY7TgIkeGIXocgAIEWwECa600shwT8bUUBDjdaWqp7ZqXk0kwAW4dcC/MPWbjrz 7qzHeaFDiXRYvOBEn0rSmQS3sSvigfGZnstOV3qZNjdp3Mfio+6RQfubn2Qu8omiv4// xxWw== X-Gm-Message-State: APjAAAWIRQbRCC1tK0iRO1EjaFsawvEiJOuxv+eIJmPnb5q/4VH4IMAs NnRKi+7AhyIm4+2ugB4S83hv3hHuhr0jx4CWR4qsr5ns7vQ0Gu7DWxsdCueZNgFU3vZR9VMcTOp 3gqIzXyaalX5Rl1o= X-Received: by 2002:adf:f641:: with SMTP id x1mr4461376wrp.248.1582890510052; Fri, 28 Feb 2020 03:48:30 -0800 (PST) X-Google-Smtp-Source: APXvYqxLCjRs3+/wwxvobfNEWrKhWYJfIhitg7qQUMnrsXNtIKgKBTusamdzSQfoVvo9B6Zs8pZyMg== X-Received: by 2002:adf:f641:: with SMTP id x1mr4461361wrp.248.1582890509891; Fri, 28 Feb 2020 03:48:29 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id a7sm1736226wmj.12.2020.02.28.03.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:48:29 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 15/18] hw/acpi: Include "hw/mem/nvdimm.h" Date: Fri, 28 Feb 2020 12:46:46 +0100 Message-Id: <20200228114649.12818-16-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksandar Markovic , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?P?= =?utf-8?q?hilippe_Mathieu-Daud=C3=A9?= , Igor Mammedov , Paolo Bonzini , John Snow , Aurelien Jarno Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Both ich9.c and piix4.c use methods/definitions declared in the NVDIMM device header. Include it. This fixes (when modifying unrelated headers): hw/acpi/ich9.c:507:46: error: use of undeclared identifier 'TYPE_NVDIMM' if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) { ^ hw/acpi/ich9.c:508:13: error: implicit declaration of function 'nvdimm_acpi_plug_cb' is invalid in C99 [-Werror,-Wimplicit-function-declaration] nvdimm_acpi_plug_cb(hotplug_dev, dev); ^ hw/acpi/piix4.c:403:46: error: use of undeclared identifier 'TYPE_NVDIMM' if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) { ^ hw/acpi/piix4.c:404:13: error: implicit declaration of function 'nvdimm_acpi_plug_cb' is invalid in C99 [-Werror,-Wimplicit-function-declaration] nvdimm_acpi_plug_cb(hotplug_dev, dev); ^ Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/acpi/ich9.c | 1 + hw/acpi/piix4.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index fdd0a6c79e..4e74284b65 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -39,6 +39,7 @@ #include "hw/i386/ich9.h" #include "hw/mem/pc-dimm.h" +#include "hw/mem/nvdimm.h" //#define DEBUG diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 6d621c31e7..b84dbba2c3 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -38,6 +38,7 @@ #include "hw/acpi/cpu.h" #include "hw/hotplug.h" #include "hw/mem/pc-dimm.h" +#include "hw/mem/nvdimm.h" #include "hw/acpi/memory_hotplug.h" #include "hw/acpi/acpi_dev_interface.h" #include "hw/xen/xen.h" From patchwork Fri Feb 28 11:46:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412141 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6A751138D for ; Fri, 28 Feb 2020 12:00:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4043D24695 for ; Fri, 28 Feb 2020 12:00:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MtSCFbdA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4043D24695 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45986 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eJO-0002Tv-Bn for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 07:00:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41672) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e8b-0002DV-L0 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:49:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e8Z-0001fH-Ub for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:49:01 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:56528 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e8Z-0001el-Qd for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:48:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0EjffDBHi226hzTHZyYKDBY0an4Sy/NVV/eLW24fAuA=; b=MtSCFbdATYHb6iDoakdBJ16AWdklLr7PaqR/D2//3Kl8NEtuYv/pTycyUhCESjL3VajwCc r78IhveISEnBXJom5CA9W19JJ02fTIBJjXbsEah5hlAHcKwfX6IsqL8sRjW3XyoCm/Ju39 p9/e9k6OUKRhBdRk5j+crSUwmHN5yBk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-UfNw6tDUPeuSHwUYX0vK8w-1; Fri, 28 Feb 2020 06:48:55 -0500 X-MC-Unique: UfNw6tDUPeuSHwUYX0vK8w-1 Received: by mail-wm1-f70.google.com with SMTP id r19so1060080wmh.1 for ; Fri, 28 Feb 2020 03:48:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BPdxKBjgOkVXpave73Lu3/06gouy+pZ7PYERljGC+KE=; b=ImASRwvT/BpUft/lEOncSF1wCByeFGJHS2cY16k/HPp5UK4iq8Uy1VIZP6ViaYqBv7 GIYwCgMYn8qTnXxJhd/ADnbyHzw3Q7e9hft51PR1ii1RoBCvHlhHtZCUg+YOlPJUMqmL ff4Hr6CEeQ8WwebQ+intUB/A2J7QgsNftmkauyDP/vbla1zqhhi2QX0wRJ18NXx41S8e B9mofo1d98ENaLsd4LMioG3e9xo9fvELbH4K0OwrVn1X+OE+q6ri0sMaflD8lLaRB1Xp 5f3olIwCdO3OLbFge62JR04+aLuFrTD18moDbsqd8lmBdkrK19HEHvSf/2GW3c85QbXe M+ww== X-Gm-Message-State: APjAAAV5mvgnmy6vr2Fk11cydSrdN5Q/FKhWv9JLq2PrzaYzv6g2Ur2q scgaM13QL5YThhPa0RnODC80hnPIyHNfoHS9HH5TlcEJCEcuNef0qRwTw9Cbgjk2cqZk7Bs/meR /ZTs1vJj6vyu3QUA= X-Received: by 2002:a05:6000:110b:: with SMTP id z11mr4639896wrw.252.1582890534149; Fri, 28 Feb 2020 03:48:54 -0800 (PST) X-Google-Smtp-Source: APXvYqy//wMIiuctKGtFr41xfgEgf5isK9uuTADKNwt1zPFLxAqJZPIfd7EY0Bb+5FjTtOpyr+fLHg== X-Received: by 2002:a05:6000:110b:: with SMTP id z11mr4639875wrw.252.1582890533948; Fri, 28 Feb 2020 03:48:53 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id 133sm2082799wmd.5.2020.02.28.03.48.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:48:53 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 16/18] hw/i386: Include "hw/mem/nvdimm.h" Date: Fri, 28 Feb 2020 12:46:47 +0100 Message-Id: <20200228114649.12818-17-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?P?= =?utf-8?q?hilippe_Mathieu-Daud=C3=A9?= , Igor Mammedov , Paolo Bonzini , John Snow , Richard Henderson Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" All this files use methods/definitions declared in the NVDIMM device header. Include it. This fixes (when modifying unrelated headers): hw/i386/acpi-build.c:2733:9: error: implicit declaration of function 'nvdimm_build_acpi' is invalid in C99 [-Werror,-Wimplicit-function-declaration] nvdimm_build_acpi(table_offsets, tables_blob, tables->linker, ^ hw/i386/pc.c:1996:61: error: use of undeclared identifier 'TYPE_NVDIMM' const bool is_nvdimm = object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM); ^ hw/i386/pc.c:2032:55: error: use of undeclared identifier 'TYPE_NVDIMM' bool is_nvdimm = object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM); ^ hw/i386/pc.c:2040:9: error: implicit declaration of function 'nvdimm_plug' is invalid in C99 [-Werror,-Wimplicit-function-declaration] nvdimm_plug(ms->nvdimms_state); ^ hw/i386/pc.c:2040:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] nvdimm_plug(ms->nvdimms_state); ^ hw/i386/pc.c:2065:42: error: use of undeclared identifier 'TYPE_NVDIMM' if (object_dynamic_cast(OBJECT(dev), TYPE_NVDIMM)) { ^ hw/i386/pc_i440fx.c:307:9: error: implicit declaration of function 'nvdimm_init_acpi_state' is invalid in C99 [-Werror,-Wimplicit-function-declaration] nvdimm_init_acpi_state(machine->nvdimms_state, system_io, ^ hw/i386/pc_q35.c:332:9: error: implicit declaration of function 'nvdimm_init_acpi_state' is invalid in C99 [-Werror,-Wimplicit-function-declaration] nvdimm_init_acpi_state(machine->nvdimms_state, system_io, ^ Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/acpi-build.c | 1 + hw/i386/pc.c | 1 + hw/i386/pc_piix.c | 1 + hw/i386/pc_q35.c | 1 + 4 files changed, 4 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 9c4e46fa74..9335a82e9f 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -47,6 +47,7 @@ #include "hw/rtc/mc146818rtc_regs.h" #include "migration/vmstate.h" #include "hw/mem/memory-device.h" +#include "hw/mem/nvdimm.h" #include "sysemu/numa.h" #include "sysemu/reset.h" diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 6ab4acb0c6..362eb2a180 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -76,6 +76,7 @@ #include "hw/boards.h" #include "acpi-build.h" #include "hw/mem/pc-dimm.h" +#include "hw/mem/nvdimm.h" #include "qapi/error.h" #include "qapi/qapi-visit-common.h" #include "qapi/visitor.h" diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index fa12203079..82f1693901 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -60,6 +60,7 @@ #include "migration/global_state.h" #include "migration/misc.h" #include "sysemu/numa.h" +#include "hw/mem/nvdimm.h" #define MAX_IDE_BUS 2 diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 84cf925cf4..d37c425e22 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -53,6 +53,7 @@ #include "qapi/error.h" #include "qemu/error-report.h" #include "sysemu/numa.h" +#include "hw/mem/nvdimm.h" /* ICH9 AHCI has 6 ports */ #define MAX_SATA_PORTS 6 From patchwork Fri Feb 28 11:46:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412111 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 005331580 for ; Fri, 28 Feb 2020 11:54:24 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAD4F2084E for ; Fri, 28 Feb 2020 11:54:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YUj6SSB9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAD4F2084E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eDn-0004Jk-0t for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:54:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41716) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e8h-0002Gi-9p for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:49:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e8b-0001gH-Ms for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:49:06 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:25393 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e8b-0001fa-JQ for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:49:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HpvhBcgDEFXbW4nnsILUgB/YwCbsH+JgLvDjsUesnxw=; b=YUj6SSB9Ta0MX0beBL5PUKYoH6oH9xU4RKP5pha9kutCTYAlKNKAq8TizJA6S0DAjbM+3u pzZqjDl6lfX4LGj2py4QDfibebfTt+W07tDojMUhtMTOsdJ/6s2vePoOMR+850Q4/PZF6m ZTVebsWmdQJz5BrcM6Zj3WoGw+c8/rs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-186-WuA10LXOPia12mY7TbPupw-1; Fri, 28 Feb 2020 06:48:57 -0500 X-MC-Unique: WuA10LXOPia12mY7TbPupw-1 Received: by mail-wm1-f69.google.com with SMTP id j130so1046319wmj.9 for ; Fri, 28 Feb 2020 03:48:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TAAC6hBU6t+zLFkPHrngSmK6nZvpAvnMhu+yhsKCpbQ=; b=igVsA/9tfqBL9IEgw1oYHzdJG2naErDMSqgp2Ygnza6nyFmu23iNyqdDu/+19K4Sx+ QzeAHhPcpp7CT8bU2lxfAgCic3m7S5SZ0k1ICf3MrRCLaVKnk5uNY8IIM7EFLBzUzSGY xUYxaWwHOqBPgEmXJoQVmXCvtY5lGfH8H7i8L4DJ5kmnmTbHuzr0YZJDs4gq9324ZZw7 Ydb2qLv7tUFXXRt/d9O4I8U/uBtLbt73/A6sjtplVXPTSY0fdP9lPMR6O8aSakByPjnX M9qdOx38/pVQSS76xMcSD3BJgwsAyhYwG35NHpXJZ/ir8l4iqKXtJXsHVhdbdqIYfqr8 q2mA== X-Gm-Message-State: APjAAAUy50cp/sJbKgwp/X6B8Afut4ownv2yhT9O/KVQrS4WM4MTIAov N8FsiXIkEO57bLBAd8KwoeHoj5TN0s0/cnSgYt7mjLqGSVcPb2vm5ukqSU3b1xOwgd+LnPzBwb/ OtiZyZwqG2MrChao= X-Received: by 2002:a05:600c:2503:: with SMTP id d3mr4452250wma.84.1582890535988; Fri, 28 Feb 2020 03:48:55 -0800 (PST) X-Google-Smtp-Source: APXvYqwZl9sQglFXX2f58Og2cQLISqqwnYjcxfrvyrAnaP7z/50j7WPYiaW2EQvhFtgE5mUHQ9bYdA== X-Received: by 2002:a05:600c:2503:: with SMTP id d3mr4452232wma.84.1582890535765; Fri, 28 Feb 2020 03:48:55 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id 133sm2082799wmd.5.2020.02.28.03.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:48:55 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 17/18] hw/pci-host/q35: Remove unused includes Date: Fri, 28 Feb 2020 12:46:48 +0100 Message-Id: <20200228114649.12818-18-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Only q35.c requires declarations from "hw/i386/pc.h", move it there. Remove all the includes not used by "q35.h". Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci-host/q35.h | 7 ------- hw/pci-host/q35.c | 1 + 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/include/hw/pci-host/q35.h b/include/hw/pci-host/q35.h index 47086c645e..070305f83d 100644 --- a/include/hw/pci-host/q35.h +++ b/include/hw/pci-host/q35.h @@ -22,16 +22,9 @@ #ifndef HW_Q35_H #define HW_Q35_H -#include "hw/isa/isa.h" -#include "hw/sysbus.h" -#include "hw/i386/pc.h" -#include "hw/isa/apm.h" #include "hw/pci/pci.h" #include "hw/pci/pcie_host.h" -#include "hw/acpi/acpi.h" -#include "hw/acpi/ich9.h" #include "hw/pci-host/pam.h" -#include "hw/i386/intel_iommu.h" #include "qemu/units.h" #include "qemu/range.h" diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index a9b9ccc876..993f467668 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -29,6 +29,7 @@ */ #include "qemu/osdep.h" +#include "hw/i386/pc.h" #include "hw/pci-host/q35.h" #include "hw/qdev-properties.h" #include "migration/vmstate.h" From patchwork Fri Feb 28 11:46:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11412135 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A24E814B4 for ; Fri, 28 Feb 2020 11:56:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78A2024695 for ; Fri, 28 Feb 2020 11:56:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RGHbZ3B+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78A2024695 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45952 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7eG1-0007tj-NG for patchwork-qemu-devel@patchwork.kernel.org; Fri, 28 Feb 2020 06:56:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41701) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7e8e-0002El-Ni for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:49:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7e8d-0001hT-Mo for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:49:04 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:58171 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7e8d-0001gN-Ih for qemu-devel@nongnu.org; Fri, 28 Feb 2020 06:49:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582890541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qTdLeO/j/e6eP/jAK/QSTo2ZeP6lsa0GUR9L2pxBWEY=; b=RGHbZ3B+ihNxayMtFx5j2HT3AWCW+IpN2CjJpRxtba9xQfWG7z115NITwdPkmznDXOMwgM esEr4XjPkIkTKSdgHDrue5Kxjwd+mnBUqOb/13i3j4QMp0wyBuki7YwOjVQChJhaHnSVt0 /QAWQLruU6fQd0sW3haGYxg4FEMa0/I= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-dWDFremBO2SYb7vTO0lotQ-1; Fri, 28 Feb 2020 06:48:59 -0500 X-MC-Unique: dWDFremBO2SYb7vTO0lotQ-1 Received: by mail-wm1-f70.google.com with SMTP id r19so1060149wmh.1 for ; Fri, 28 Feb 2020 03:48:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dgOorqpkh3gN4b7sAM5gmxbiZ9joAGYWI1QUJBzOx9g=; b=p1+9/hHXoWqiuhpvlkzN0SkRFHk9Js2jfjq96IE0EVwYel8EsxIPkBWt68zxiNjm9E R4bGbaFZJQb1hECaxf8lJwDDz0kWScNLj6vT8qdNurGY3RW4Oob704bguEmuNoX/YxZy 9qcpRKTo31cLjuw1wDStq+eeI9JGDa8TG9lVUKeHvQnPtjCD6ddAskk97M7uvSvDE/US NOxzip+t0h8sP7i9A5+kAvM1HNeTxMLXehHD6aPlLUlpgfEYJeNiR8DcM4b8B8HTR9JT Li/IaeOF2Rfm+Si0/M00WqTomr02aiKtS9TlXU1VEFq9itOOMAmn22pnkT4Ra1BFUGEo my8w== X-Gm-Message-State: APjAAAVsWOK1TOmDXAhT3bzjn+CyuxeYseWJbB31BFyBQaBrzVoRI1P/ eqmAkgIF7qtYB1AL+7eW2fDupXPInw/lgaU3Fhvh4JpYZlBtW3x6Fp40IiyJBAN7LmVsmtzQ6zP SgsNfEjM6zYVwiY4= X-Received: by 2002:a7b:cf39:: with SMTP id m25mr4483317wmg.146.1582890538278; Fri, 28 Feb 2020 03:48:58 -0800 (PST) X-Google-Smtp-Source: APXvYqzSECnXVOCZYvsdQaRgO3slzYjheg1QWBdEwrqqjtLopf28EMMyXYnzPgpXVuQahIv26lkZyQ== X-Received: by 2002:a7b:cf39:: with SMTP id m25mr4483298wmg.146.1582890538096; Fri, 28 Feb 2020 03:48:58 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id 133sm2082799wmd.5.2020.02.28.03.48.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 03:48:57 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 18/18] hw/i386/pc: Clean up includes Date: Fri, 28 Feb 2020 12:46:49 +0100 Message-Id: <20200228114649.12818-19-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228114649.12818-1-philmd@redhat.com> References: <20200228114649.12818-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , qemu-trivial@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Various headers are not required by hw/i386/pc.h: - "qemu/range.h" - "qemu/bitmap.h" - "qemu/module.h" - "exec/memory.h" - "hw/pci/pci.h" - "hw/mem/pc-dimm.h" - "hw/mem/nvdimm.h" - "net/net.h" Remove them. Add 3 headers that were missing: - "hw/hotplug.h" PCMachineState::acpi_dev is of type HotplugHandler - "qemu/notify.h" PCMachineState::machine_done is of type Notifier - "qapi/qapi-types-common.h" PCMachineState::vmport/smm is of type OnOffAuto Acked-by: John Snow Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index d5ac76d54e..6ab6eda046 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -1,20 +1,15 @@ #ifndef HW_PC_H #define HW_PC_H -#include "exec/memory.h" +#include "qemu/notify.h" +#include "qapi/qapi-types-common.h" #include "hw/boards.h" #include "hw/block/fdc.h" #include "hw/block/flash.h" -#include "net/net.h" #include "hw/i386/x86.h" -#include "qemu/range.h" -#include "qemu/bitmap.h" -#include "qemu/module.h" -#include "hw/pci/pci.h" -#include "hw/mem/pc-dimm.h" -#include "hw/mem/nvdimm.h" #include "hw/acpi/acpi_dev_interface.h" +#include "hw/hotplug.h" #define HPET_INTCAP "hpet-intcap"