From patchwork Tue Oct 2 02:59:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jun qian X-Patchwork-Id: 10623011 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A413E13BB for ; Tue, 2 Oct 2018 03:01:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9678928385 for ; Tue, 2 Oct 2018 03:01:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 85BC42838B; Tue, 2 Oct 2018 03:01:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F3B1B28385 for ; Tue, 2 Oct 2018 03:01:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2CD016B0003; Mon, 1 Oct 2018 23:01:20 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 27CE26B0005; Mon, 1 Oct 2018 23:01:20 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1933E6B0006; Mon, 1 Oct 2018 23:01:20 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by kanga.kvack.org (Postfix) with ESMTP id E047F6B0003 for ; Mon, 1 Oct 2018 23:01:19 -0400 (EDT) Received: by mail-oi1-f199.google.com with SMTP id e15-v6so387591oie.16 for ; Mon, 01 Oct 2018 20:01:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id; bh=/JQZIX+zvmfNbG4mUXW50jwQ83j36qjnhRJIjM3rb9g=; b=egh/WIU5WS+0SiRIxBQFsqkMj4b2jf6POw3TzFIHzdUR0n6D3Tu9U+cGiz0QYPUmcD 5tTn/94wHzAXXcZ+BWoSjpua5/+hCYTPAlTFEWYbwUHhprwuyWTPM85S01a3wG/bTE2Y qXD49d4TXddY1lzzqzCLQosDojwwgoQUoriXbo/+CMw/ssHajFjXkZNu67nj6X2E9EJr qpkUnSd6hQtq7UGniYlgt3mybIo07SWGMk6tFGvEGUCJag672GnKDm2UDTEpxifGK3jN /cdgHgIADqPsZNQ0PdTarU15wrLGOihA8onEWGx4tsvADHZeYeyTVfP+momefUZlio1I hfLw== X-Gm-Message-State: ABuFfoj3iTbXSlOIB0Lh2ySWyG0lkGzy2iBLaPFaCbvle5kz9Gy9EVtp 9L8RDKeSrtmlk3/Dlz4Y3Cp/0c6GRK6aFLY0GOgy+NOLDiJCG4Wdpqv6nykq6ip/Vl6B1Z6/+uL Xi2F9IPzdS5TVh2hEGk51UiePi6ilEA5PoRIsPlaBzZaCRON7sGYjuCBMiOWNpWwQ9w== X-Received: by 2002:a9d:518c:: with SMTP id y12-v6mr8834940otg.252.1538449279553; Mon, 01 Oct 2018 20:01:19 -0700 (PDT) X-Google-Smtp-Source: ACcGV61zrIB9KzbE+I/WGdoGRO0BvjwvUr3X6dueL0Vi/tIIrMV4ThXEpRiTrBXS8LX2tS6ILq/h X-Received: by 2002:a9d:518c:: with SMTP id y12-v6mr8834897otg.252.1538449278546; Mon, 01 Oct 2018 20:01:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538449278; cv=none; d=google.com; s=arc-20160816; b=BUW+NoLRSf2cgTai1blAu5G9q3RA+hQTO+549UrmKn7ALydlJhwsZ4Wtk/JVkXFwtL WK2diPas9DXMzYU4IVGUxbVEORfjDQdfmYnYjzSv9hSVRnCZtwzX8hY8rj5XNBtjyZ/2 oSTrbRZTS0KcqeHpF03zFtK0HYh67fa1QqxPqETz56e4C30/M91asUWro/rqQ2hewBhj 4lx/loDhLR7hI5FjYartWInV8c2QVqSkPeAj/uC9FDYb4PPxmQm+cJ2iD/jaVptcy22E F4cTRvmxG+K283onYrFFENgWQCibNtpbWzauzfs33ASdTN53LAFyMe5RyjPD74yvTECJ jdyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=/JQZIX+zvmfNbG4mUXW50jwQ83j36qjnhRJIjM3rb9g=; b=fkXc79DTGysBnRuHcEqS8R6NLXZ4JJpBnQLbDi2dR4Azo1GCURLMLAutODPRHRc44n jk1B5o6Iy2li6OgYwdXc9DizSIwXkkz7wl1sGO9ZnxY/fEjhPP43Tis944KKhN75cBdV X3p9xTTXg3ByPGpvNsE2zTnQmTvs0HRzq4s497NkgwT/K9/Nvzp1U6f31xwEhLZKtSHO c7pBizPzZ+gqWzpJ4+YrXr903ax8PtXccp8z/dziYGV1yleB/pxHNqu4cHDAGXrIkCCA kL3+WmTj4wVlllvSeLA12mv/UcgREURHTzJtGlOgDJBHveFZz+PmnbG3UJ+89RmcAQBK XDBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=bVvk9bbE; spf=pass (google.com: domain of hangdianqj@163.com designates 220.181.12.14 as permitted sender) smtp.mailfrom=hangdianqj@163.com Received: from m12-14.163.com (m12-14.163.com. [220.181.12.14]) by mx.google.com with ESMTP id a133-v6si1783051oih.126.2018.10.01.20.01.17 for ; Mon, 01 Oct 2018 20:01:18 -0700 (PDT) Received-SPF: pass (google.com: domain of hangdianqj@163.com designates 220.181.12.14 as permitted sender) client-ip=220.181.12.14; Authentication-Results: mx.google.com; dkim=pass header.i=@163.com header.s=s110527 header.b=bVvk9bbE; spf=pass (google.com: domain of hangdianqj@163.com designates 220.181.12.14 as permitted sender) smtp.mailfrom=hangdianqj@163.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=/JQZIX+zvmfNbG4mUX W50jwQ83j36qjnhRJIjM3rb9g=; b=bVvk9bbEqh0cUX/RyEv9IT8OR4aDlyEfGz ztqAn4f93ClmQmCcEQrCwnV5uvWO5+Q5QJqH6KThc18M63BF9YibJjvWr9iDo2lD zXme01nYxtx98295nLbJ1LirndG/A7SZsbd9QNox5ONHVPHIT0QHLB5kQzsyXBKg H7Q/WnzgM= Received: from localhost (unknown [183.156.114.194]) by smtp10 (Coremail) with SMTP id DsCowACHm7FJ37JbxXe7Sw--.17030S5; Tue, 02 Oct 2018 11:00:27 +0800 (CST) From: jun qian To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, jun qian , Barry song <21cnbao@gmail.com> Subject: [PATCH] mm:slab: Adjust the print format for the slabinfo Date: Mon, 1 Oct 2018 19:59:39 -0700 Message-Id: <20181002025939.115804-1-hangdianqj@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: DsCowACHm7FJ37JbxXe7Sw--.17030S5 X-Coremail-Antispam: 1Uf129KBjvJXoW7urWxGw1ruw47Ar4UArW7CFg_yoW8tF4Upw 43twnrX3yxJryjgrZIva4vqryYgFn5AFWUZr97tw1vvw1UCwn7W34j9r1xZFZxtFySyana vw4v9F13WFWkX3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UlPfQUUUUU= X-Originating-IP: [183.156.114.194] X-CM-SenderInfo: pkdqwvpldq1yi6rwjhhfrp/xtbBSQvTR1aDzWPJewAAsf X-Bogosity: Ham, tests=bogofilter, spamicity=0.001149, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Header and the corresponding information is not aligned, adjust the printing format helps us to understand the slabinfo better. Signed-off-by: jun qian Cc: Barry song <21cnbao@gmail.com> --- mm/slab_common.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/mm/slab_common.c b/mm/slab_common.c index fea3376f9816..07a324cbbfb6 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -1263,9 +1263,13 @@ static void print_slabinfo_header(struct seq_file *m) #else seq_puts(m, "slabinfo - version: 2.1\n"); #endif - seq_puts(m, "# name "); - seq_puts(m, " : tunables "); - seq_puts(m, " : slabdata "); + seq_printf(m, "%-22s %-14s %-11s %-10s %-13s %-14s", + "# name", "", "", "", + "", ""); + seq_printf(m, " : %-9s %-8s %-13s %-14s", + "tunables", "", "", ""); + seq_printf(m, " : %-9s %-15s %-12s %-16s", + "slabdata", "", "", ""); #ifdef CONFIG_DEBUG_SLAB seq_puts(m, " : globalstat "); seq_puts(m, " : cpustat "); @@ -1319,13 +1323,13 @@ static void cache_show(struct kmem_cache *s, struct seq_file *m) memcg_accumulate_slabinfo(s, &sinfo); - seq_printf(m, "%-17s %6lu %6lu %6u %4u %4d", + seq_printf(m, "%-22s %-14lu %-11lu %-10u %-13u %-14d", cache_name(s), sinfo.active_objs, sinfo.num_objs, s->size, sinfo.objects_per_slab, (1 << sinfo.cache_order)); - seq_printf(m, " : tunables %4u %4u %4u", + seq_printf(m, " : %-9s %-8u %-13u %-14u", "tunables", sinfo.limit, sinfo.batchcount, sinfo.shared); - seq_printf(m, " : slabdata %6lu %6lu %6lu", + seq_printf(m, " : %-9s %-15lu %-12lu %-16lu", "slabdata", sinfo.active_slabs, sinfo.num_slabs, sinfo.shared_avail); slabinfo_show_stats(m, s); seq_putc(m, '\n');