From patchwork Fri Mar 13 08:45:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Roger Pau Monne X-Patchwork-Id: 11436275 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 874A7139A for ; Fri, 13 Mar 2020 08:47:41 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5914F206FA for ; Fri, 13 Mar 2020 08:47:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="gIpIXNkE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5914F206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jCfxV-0006hj-Ca; Fri, 13 Mar 2020 08:46:21 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1jCfxU-0006hc-9H for xen-devel@lists.xenproject.org; Fri, 13 Mar 2020 08:46:20 +0000 X-Inumbo-ID: 1b9ed900-6507-11ea-b34e-bc764e2007e4 Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1b9ed900-6507-11ea-b34e-bc764e2007e4; Fri, 13 Mar 2020 08:46:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1584089179; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=nUPbTKXL4KgWk5SobesvIKkID2FOqCoGQrUd1cVLpjI=; b=gIpIXNkEV8DHBk8hrDaLxnKAHXCb8EdMrW69lG1wNJOd5qdf0mDCZ9Z4 4cfaH93X8J93+XGUYyqt8X4mmMjPYvWfNu7pDvwp8mVm4B9SbH53ZPNdP XShY9keyhsc+eqK+OLDZXYt7CO+1WVctaNRQcAj1gYEGfnJCU/9+BZ0bU o=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=roger.pau@citrix.com; spf=Pass smtp.mailfrom=roger.pau@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of roger.pau@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of roger.pau@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="roger.pau@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ip4:168.245.78.127 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="roger.pau@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: l1i59W7ooNQ1IGF9SQi73SGyl0CXyhnlSIduFJ+CXhCxLBInLPSDfveriJJ6q86wmzj+sf9E67 ylwxsD7MywbwQp7TJRZ6Bj7mgsxLEx8wyRlWI230g8yrliSg+zKw+0wz6pMlf1zkwiunzxFp9H lK/vrzzl6H/sySBGpUFb3KGT2s7H2oIYAWnL3IpKdQaHH4jAeuVcPnvNK9LC+EUabsJtV1n/vk t7CpW+URlzhwJvIEnm7SDdRaDCYqcZd7cDgCRKxFqX5V+SfJ8rzntgZoulfChoO1c3p/j9FmEg GnI= X-SBRS: 2.7 X-MesageID: 14317943 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.70,548,1574139600"; d="scan'208";a="14317943" From: Roger Pau Monne To: Date: Fri, 13 Mar 2020 09:45:58 +0100 Message-ID: <20200313084558.13759-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200313084558.13759-1-roger.pau@citrix.com> References: <20200313084558.13759-1-roger.pau@citrix.com> MIME-Version: 1.0 Subject: [Xen-devel] [PATCH 2/2] libfsimage: fix parentheses in macro parameters X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Ian Jackson , Wei Liu , Roger Pau Monne Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" VERIFY_DN_TYPE and VERIFY_OS_TYPE should use parentheses when accessing the type parameter. Note that none of the current usages require this, it's just done for correctness. Signed-off-by: Roger Pau Monné --- tools/libfsimage/zfs/fsys_zfs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libfsimage/zfs/fsys_zfs.h b/tools/libfsimage/zfs/fsys_zfs.h index 721972a05a..b4be51b50d 100644 --- a/tools/libfsimage/zfs/fsys_zfs.h +++ b/tools/libfsimage/zfs/fsys_zfs.h @@ -71,7 +71,7 @@ typedef unsigned int size_t; * Can only be used in functions returning non-0 for failure. */ #define VERIFY_DN_TYPE(dnp, type) \ - if (type != DMU_OT_NONE && (dnp)->dn_type != type) { \ + if ((type) != DMU_OT_NONE && (dnp)->dn_type != (type)) { \ return (ERR_FSYS_CORRUPT); \ } @@ -80,7 +80,7 @@ typedef unsigned int size_t; * Can only be used in functions returning 0 for failure. */ #define VERIFY_OS_TYPE(osp, type) \ - if (type != DMU_OST_NONE && (osp)->os_type != type) { \ + if ((type) != DMU_OST_NONE && (osp)->os_type != (type)) { \ errnum = ERR_FSYS_CORRUPT; \ return (0); \ }