From patchwork Thu Mar 19 16:29:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Lazar X-Patchwork-Id: 11447657 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8562592A for ; Thu, 19 Mar 2020 16:25:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B5422080C for ; Thu, 19 Mar 2020 16:25:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=startmail.com header.i=@startmail.com header.b="t/WlRgiN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727994AbgCSQZP (ORCPT ); Thu, 19 Mar 2020 12:25:15 -0400 Received: from mx-out1.startmail.com ([145.131.90.139]:57795 "EHLO mx-out1.startmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727821AbgCSQZP (ORCPT ); Thu, 19 Mar 2020 12:25:15 -0400 From: Alexandru Lazar DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=startmail.com; s=2017-11; t=1584635113; bh=MPbLEpCgR5tkqEvEHLXGhGKYlNzqLnTNrbqcH4sQsG0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t/WlRgiNnEimPfDGN/VlP3PgrEZAUU7j0t7oUXf2UoocmLOrsDnTY7jLM837YyeIW DGIo4UucOmdVw48fv3nCwAEOpYzMwNicAinBhX9v2/1+m7d30NPhKAzbvJdkapN+iI PjG2SNKhuY2u57EhPPztO0j88LeGfPDHHWj21BzxusPjrVI7g1tgvVqFdaQ72p5wNX 10oB7jPLKws0G+aBV0aXCyNpwBbdcLo5lELsp4R88sw/ZyTf/uVfXaBeI3EivU/9Ba ziecAlj0X9zgk8ntixiWWkMYrkIeWhFUIqif/JunvaH7N8779v3vKVMeodzNeBFytJ nFXOuiV8fov9g== To: linux-iio@vger.kernel.org Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com, Alexandru Lazar Subject: [PATCH v3 1/2] iio: adc: Add MAX1241 driver Date: Thu, 19 Mar 2020 18:29:36 +0200 Message-Id: <20200319162937.34664-2-alazar@startmail.com> In-Reply-To: <20200319162937.34664-1-alazar@startmail.com> References: <20200319162937.34664-1-alazar@startmail.com> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Add driver for the Maxim MAX1241 12-bit, single-channel ADC. The driver includes support for this device's low-power operation mode. Signed-off-by: Alexandru Lazar Reviewed-by: Alexandru Ardelean --- drivers/iio/adc/Kconfig | 10 ++ drivers/iio/adc/Makefile | 1 + drivers/iio/adc/max1241.c | 206 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 217 insertions(+) create mode 100644 drivers/iio/adc/max1241.c diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig index 5d8540b7b427..55f6462cd93f 100644 --- a/drivers/iio/adc/Kconfig +++ b/drivers/iio/adc/Kconfig @@ -566,6 +566,16 @@ config MAX1118 To compile this driver as a module, choose M here: the module will be called max1118. +config MAX1241 + tristate "Maxim max1241 ADC driver" + depends on SPI_MASTER + help + Say yes here to build support for Maxim max1241 12-bit, single-channel + ADC. + + To compile this driver as a module, choose M here: the module will be + called max1241. + config MAX1363 tristate "Maxim max1363 ADC driver" depends on I2C diff --git a/drivers/iio/adc/Makefile b/drivers/iio/adc/Makefile index a1f1fbec0f87..37d6f17559dc 100644 --- a/drivers/iio/adc/Makefile +++ b/drivers/iio/adc/Makefile @@ -54,6 +54,7 @@ obj-$(CONFIG_LTC2497) += ltc2497.o obj-$(CONFIG_MAX1027) += max1027.o obj-$(CONFIG_MAX11100) += max11100.o obj-$(CONFIG_MAX1118) += max1118.o +obj-$(CONFIG_MAX1241) += max1241.o obj-$(CONFIG_MAX1363) += max1363.o obj-$(CONFIG_MAX9611) += max9611.o obj-$(CONFIG_MCP320X) += mcp320x.o diff --git a/drivers/iio/adc/max1241.c b/drivers/iio/adc/max1241.c new file mode 100644 index 000000000000..0278510ec346 --- /dev/null +++ b/drivers/iio/adc/max1241.c @@ -0,0 +1,206 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * MAX1241 low-power, 12-bit serial ADC + * + * Datasheet: https://datasheets.maximintegrated.com/en/ds/MAX1240-MAX1241.pdf + */ + +#include +#include +#include +#include +#include +#include + +#define MAX1241_VAL_MASK 0xFFF +#define MAX1241_SHDN_DELAY_USEC 4 + +enum max1241_id { + max1241, +}; + +struct max1241 { + struct spi_device *spi; + struct mutex lock; + struct regulator *reg; + struct gpio_desc *shdn; + + __be16 data ____cacheline_aligned; +}; + +static const struct iio_chan_spec max1241_channels[] = { + { + .type = IIO_VOLTAGE, + .indexed = 1, + .channel = 0, + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | + BIT(IIO_CHAN_INFO_SCALE), + .scan_index = 0, + .scan_type = { + .sign = 'u', + .realbits = 12, + .storagebits = 16, + }, + }, +}; + +static int max1241_read(struct max1241 *adc) +{ + struct spi_transfer xfers[] = { + /* + * Begin conversion by bringing /CS low for at least + * tconv us. + */ + { + .len = 0, + .delay.value = 8, + .delay.unit = SPI_DELAY_UNIT_USECS, + }, + /* + * Then read two bytes of data in our RX buffer. + */ + { + .rx_buf = &adc->data, + .len = 2, + }, + }; + + return spi_sync_transfer(adc->spi, xfers, ARRAY_SIZE(xfers)); +} + +static int max1241_read_raw(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + int *val, int *val2, long mask) +{ + int ret, vref_uV; + struct max1241 *adc = iio_priv(indio_dev); + + switch (mask) { + case IIO_CHAN_INFO_RAW: + mutex_lock(&adc->lock); + + if (adc->shdn) { + gpiod_set_value(adc->shdn, 0); + udelay(MAX1241_SHDN_DELAY_USEC); + } + + ret = max1241_read(adc); + + if (adc->shdn) + gpiod_set_value(adc->shdn, 1); + + if (ret) { + mutex_unlock(&adc->lock); + return ret; + } + + *val = (be16_to_cpu(adc->data) >> 3) & MAX1241_VAL_MASK; + + mutex_unlock(&adc->lock); + return IIO_VAL_INT; + case IIO_CHAN_INFO_SCALE: + vref_uV = regulator_get_voltage(adc->reg); + + if (vref_uV < 0) + return vref_uV; + + *val = vref_uV / 1000; + *val2 = 12; + + return IIO_VAL_FRACTIONAL_LOG2; + default: + return -EINVAL; + } +} + +static const struct iio_info max1241_info = { + .read_raw = max1241_read_raw, +}; + +static void max1241_disable_reg_action(void *data) +{ + struct max1241 *adc = data; + int err; + + err = regulator_disable(adc->reg); + if (err) + dev_err(&adc->spi->dev, "could not disable reference regulator.\n"); +} + +static int max1241_probe(struct spi_device *spi) +{ + struct iio_dev *indio_dev; + struct max1241 *adc; + int ret = 0; + + indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*adc)); + if (!indio_dev) + return -ENOMEM; + + adc = iio_priv(indio_dev); + adc->spi = spi; + mutex_init(&adc->lock); + + spi_set_drvdata(spi, indio_dev); + + adc->reg = devm_regulator_get(&spi->dev, "vref"); + if (IS_ERR(adc->reg)) { + dev_err(&spi->dev, "failed to get vref regulator\n"); + return PTR_ERR(adc->reg); + } + + ret = regulator_enable(adc->reg); + if (ret) + return ret; + + ret = devm_add_action_or_reset(&spi->dev, max1241_disable_reg_action, + adc); + if (ret) { + dev_err(&spi->dev, "could not set up regulator cleanup action!\n"); + return ret; + } + + adc->shdn = devm_gpiod_get_optional(&spi->dev, "shdn", GPIOD_OUT_HIGH); + + if (IS_ERR(adc->shdn)) + return PTR_ERR(adc->shdn); + + if (!adc->shdn) + dev_dbg(&spi->dev, "no shdn pin passed, low-power mode disabled"); + else + dev_dbg(&spi->dev, "shdn pin passed, low-power mode enabled"); + + indio_dev->name = spi_get_device_id(spi)->name; + indio_dev->dev.parent = &spi->dev; + indio_dev->info = &max1241_info; + indio_dev->modes = INDIO_DIRECT_MODE; + indio_dev->channels = max1241_channels; + indio_dev->num_channels = ARRAY_SIZE(max1241_channels); + + return devm_iio_device_register(&spi->dev, indio_dev); +} + +static const struct spi_device_id max1241_id[] = { + { "max1241", max1241 }, + {}, +}; + +static const struct of_device_id max1241_dt_ids[] = { + { .compatible = "maxim,max1241" }, + {}, +}; +MODULE_DEVICE_TABLE(of, max1241_dt_ids); + +static struct spi_driver max1241_spi_driver = { + .driver = { + .name = "max1241", + .of_match_table = max1241_dt_ids, + }, + .probe = max1241_probe, + .id_table = max1241_id, +}; +module_spi_driver(max1241_spi_driver); + +MODULE_AUTHOR("Alexandru Lazar "); +MODULE_DESCRIPTION("MAX1241 ADC driver"); +MODULE_LICENSE("GPL v2"); From patchwork Thu Mar 19 16:29:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru Lazar X-Patchwork-Id: 11447659 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 187E617E6 for ; Thu, 19 Mar 2020 16:25:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBFBF20775 for ; Thu, 19 Mar 2020 16:25:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=startmail.com header.i=@startmail.com header.b="WBLKgWza" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728015AbgCSQZS (ORCPT ); Thu, 19 Mar 2020 12:25:18 -0400 Received: from mx-out1.startmail.com ([145.131.90.139]:53285 "EHLO mx-out1.startmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727821AbgCSQZS (ORCPT ); Thu, 19 Mar 2020 12:25:18 -0400 From: Alexandru Lazar DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=startmail.com; s=2017-11; t=1584635116; bh=XeWrEWWKkKuHxAE3Ufutfrlrgjivl1HEfR3mh9Il1og=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WBLKgWzaIUvA2WIS8hJd+xLGAkouvYuRStfGXlOJmYsgBDVXcbPqwQdYsYyqsYYL/ OBxuotKU2q6gi865Hr4X2rWC6MgAwgh2PQmaqU9Ayk2J2KI4k9VGNYin56R5rjphub Kk9MpIt0Fe19Z9XzzkEvVR6x6eghJrbR3oGi97QmLSmnpYCrYCEcdfE0QjyOq41Ala x0CcpCGeOigvgO9gZHkDpFzLckQkV2fiZN7QYUrTZC4upjUToBQUiHKXdxlV/ewzyB rQOQD/kKxvf1WWEPKse98JjONAa7nO3bi2Hbr/McT5tX1rQKmGkWJ/N2SMPSDQm+sN U9OcNUyhO+vdA== To: linux-iio@vger.kernel.org Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com, Alexandru Lazar Subject: [PATCH v3 2/2] dt-bindings: iio: adc: Add MAX1241 device tree bindings in documentation Date: Thu, 19 Mar 2020 18:29:37 +0200 Message-Id: <20200319162937.34664-3-alazar@startmail.com> In-Reply-To: <20200319162937.34664-1-alazar@startmail.com> References: <20200319162937.34664-1-alazar@startmail.com> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Add device-tree bindings documentation for the MAX1241 device driver. Signed-off-by: Alexandru Lazar --- .../bindings/iio/adc/maxim,max1241.yaml | 62 +++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml diff --git a/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml b/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml new file mode 100644 index 000000000000..28c73ed795aa --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/maxim,max1241.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: GPL-2.0 +# Copyright 2020 Ioan-Alexandru Lazar +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/maxim,max1241.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim MAX1241 12-bit, single-channel analog to digital converter + +maintainers: + - Ioan-Alexandru Lazar + +description: | + Bindings for the max1241 12-bit, single-channel ADC device. This + driver supports voltage reading and can optionally be configured for + power-down mode operation. The datasheet can be found at: + https://datasheets.maximintegrated.com/en/ds/MAX1240-MAX1241.pdf + +properties: + compatible: + enum: + - maxim,max1241 + + reg: + description: SPI chip select number for this device + maxItems: 1 + + vref-supply: + description: + Device tree identifier of the regulator that provides the external + reference voltage. + maxItems: 1 + + shdn-gpios: + description: + GPIO spec for the GPIO pin connected to the ADC's /SHDN pin. If + specified, the /SHDN pin will be asserted between conversions, + thus enabling power-down mode. + maxItems: 1 + +required: + - compatible + - reg + - vref-supply + +examples: + - | + #include + spi0 { + #address-cells = <1>; + #size-cells = <0>; + + adc@0 { + compatible = "maxim,max1241"; + reg = <0>; + vref-supply = <&vdd_3v3_reg>; + spi-max-frequency = <1000000>; + shdn-gpios = <&gpio 26 1>; + }; + }; + +