From patchwork Thu Mar 19 16:59:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mateusz Nosek X-Patchwork-Id: 11447729 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E915E1667 for ; Thu, 19 Mar 2020 17:00:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A1E1A2072D for ; Thu, 19 Mar 2020 17:00:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OEiV91Rj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1E1A2072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CFAAE6B0007; Thu, 19 Mar 2020 13:00:18 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id CAAE36B0008; Thu, 19 Mar 2020 13:00:18 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B72BA6B0010; Thu, 19 Mar 2020 13:00:18 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0142.hostedemail.com [216.40.44.142]) by kanga.kvack.org (Postfix) with ESMTP id 9CB336B0007 for ; Thu, 19 Mar 2020 13:00:18 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3C0C718042E1C for ; Thu, 19 Mar 2020 17:00:18 +0000 (UTC) X-FDA: 76612724916.22.pies17_1fb408caa9447 X-Spam-Summary: 2,0,0,3f12cb3598a59464,d41d8cd98f00b204,mateusznosek0@gmail.com,,RULES_HIT:41:355:379:541:800:960:966:968:973:988:989:1260:1345:1437:1534:1539:1711:1714:1730:1747:1777:1792:2196:2199:2282:2393:2559:2562:3138:3139:3140:3141:3142:3350:3865:3867:3868:3871:3872:4321:4385:5007:6261:6653:7514:7576:7901:9413:10004:11026:11658:11914:12297:12438:12517:12519:12555:12679:12895:13069:13311:13357:14096:14181:14384:14394:14721:21080:21444:21451:21627:21666:30012:30054,0,RBL:209.85.208.193:@gmail.com:.lbl8.mailshell.net-62.18.0.100 66.100.201.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:25,LUA_SUMMARY:none X-HE-Tag: pies17_1fb408caa9447 X-Filterd-Recvd-Size: 3403 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 17:00:17 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id s13so3351741ljm.1 for ; Thu, 19 Mar 2020 10:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=CK/uSp7BbTSCKl35tJIDZhjlJczfTeolJYVvbwptV4M=; b=OEiV91RjCb5SrrrpKvHbyVq/Ll2bovI/WapuWca/s7CqnkAZGQK6F7gh6yzyXi7lGy G+EJV29vkwqhd1XzS5a6wmoTyvJvIYFHxajzzoir0JwgkT32VS4BV+TO1b4+J0LKONX9 D9+hGdfQNgZau0wso1+mHTM4MIRvNh5zvk7oYvdVa/gPEtE+gTnqfs439Ueenuxs8ktJ kJ1MDrSQDJHgyJdhniEG2ZJwhAA0dPGUhtNUzJPyJfvKL5RI2nTM/N26wjM6udQ6pMu6 we+QvsK4tFm9va7xAIQVlhQpo32w33erghO0yntQMbQd7pOM9f7JNGzDSgp0dwYwQ8CI s7fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=CK/uSp7BbTSCKl35tJIDZhjlJczfTeolJYVvbwptV4M=; b=JbnapnsB3smPfaGZXqtY9jWKw2F5V0Cc7M0jmjmG49MlUJDJLz0v1/K6Xux9ga4L3u 5dapCO4u4oyxdfK8dc2Rg+A2G/R/Tg0LWhFHkyDrkBcWVy45eCxWuEZXpBRVDj8+vEmd zEyqbAw9FQZBzbP8UHjP0cQvjGG4+ciXwM4SGrGj5x34K6OVHmNGgEFMbFjt9eqg+q/t qX9mokC7CAIKA3ER/bZsoPRuuMN7ooJorywhxaWt7gpFsyblmrVcRlNEmC6HCe5fIHWi YuVB5jy+Mw8ClgqBElbz/20saI7ef5xwOYfk3ia/NRl0AW9KRz+O8Ei7XQfbcMsKQL/9 hRrw== X-Gm-Message-State: ANhLgQ1Ir3U983ER3nUveMxVOQ32iEeu608NSNxFPmOCWJP8TJE+ZLfA oXBsvzAd7R5ZulZEPWLn3qAXSHD7o/0= X-Google-Smtp-Source: ADFU+vtQX6AgLn/ilsvkGpf8R2Braooqufkbkhu7QjG1ypfPxJPMQDzdS1N4dIBmwrnNMf8q3wTDww== X-Received: by 2002:a2e:b701:: with SMTP id j1mr2795557ljo.6.1584637213833; Thu, 19 Mar 2020 10:00:13 -0700 (PDT) Received: from localhost.localdomain (188.146.97.196.nat.umts.dynamic.t-mobile.pl. [188.146.97.196]) by smtp.gmail.com with ESMTPSA id h22sm1785027ljc.15.2020.03.19.10.00.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 10:00:13 -0700 (PDT) From: mateusznosek0@gmail.com To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Mateusz Nosek , akpm@linux-foundation.org Subject: [PATCH] mm/vmscan.c: Clean code by removing unnecessary assignment Date: Thu, 19 Mar 2020 17:59:38 +0100 Message-Id: <20200319165938.23354-1-mateusznosek0@gmail.com> X-Mailer: git-send-email 2.17.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Mateusz Nosek Previously 0 was assigned to 'sc->skipped_deactivate'. It could happen only if 'sc->skipped_deactivate' was 0 so the assignment is unnecessary and can be removed. Signed-off-by: Mateusz Nosek Acked-by: Johannes Weiner --- mm/vmscan.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index dca623db51c8..453ff2abcb58 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -3093,7 +3093,6 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist, if (sc->memcg_low_skipped) { sc->priority = initial_priority; sc->force_deactivate = 0; - sc->skipped_deactivate = 0; sc->memcg_low_reclaim = 1; sc->memcg_low_skipped = 0; goto retry;