From patchwork Wed Mar 25 03:14:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 11457587 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4041692A for ; Wed, 25 Mar 2020 11:50:39 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 4CC0120714 for ; Wed, 25 Mar 2020 11:50:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="Fn32tZyU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CC0120714 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-18218-patchwork-kernel-hardening=patchwork.kernel.org@lists.openwall.com Received: (qmail 10128 invoked by uid 550); 25 Mar 2020 11:50:36 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Delivered-To: mailing list kernel-hardening@lists.openwall.com Delivered-To: moderator for kernel-hardening@lists.openwall.com Received: (qmail 17697 invoked from network); 25 Mar 2020 03:15:24 -0000 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com 02P3EoCw025927 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1585106091; bh=S5jEMGj/iPjxiPM2qpwETTmm50qFMMgViufRDHA4UYY=; h=From:To:Cc:Subject:Date:From; b=Fn32tZyU6S/FbmgTUNVYw/4mgJsDn7KA/fxkT/MCad0McZ3zqYtMJSj1sCVuNl+2A NaXYDYrLmdttewD0irHM2OQFQ5x3LwX9JHjnrDrEifjNgcGJmXmJC06KwqYD4N73Pk EUt3WS4kao/rxOcQKWldzMdttDHJWApWk+mIbFcP8v2g+VmvsKk9pOWd3d8NRUAwO/ M3I3R8DR6SAeiyj/Wg3QZ47DJGNdVm16I1eR5nkz0Npa79NVQCGz7C10cMkQ4nfWFd 9kIx/6WnzyqL6LvmcOtW+HfbETF2duFoijog6PE+opUO84lGozT7Nuxa+dNAoy+q2A oxyeCKZaYP2uA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Kees Cook , kernel-hardening@lists.openwall.com, Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH 1/2] kconfig: remove unused variable in qconf.cc Date: Wed, 25 Mar 2020 12:14:31 +0900 Message-Id: <20200325031433.28223-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 If this file were compiled with -Wall, the following warning would be reported: scripts/kconfig/qconf.cc:312:6: warning: unused variable ‘i’ [-Wunused-variable] int i; ^ The commit prepares to turn on -Wall for C++ host programs. Signed-off-by: Masahiro Yamada Reviewed-by: Kees Cook --- scripts/kconfig/qconf.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc index 82773cc35d35..50a5245d87bb 100644 --- a/scripts/kconfig/qconf.cc +++ b/scripts/kconfig/qconf.cc @@ -309,8 +309,6 @@ ConfigList::ConfigList(ConfigView* p, const char *name) showName(false), showRange(false), showData(false), mode(singleMode), optMode(normalOpt), rootEntry(0), headerPopup(0) { - int i; - setObjectName(name); setSortingEnabled(false); setRootIsDecorated(true); From patchwork Wed Mar 25 03:14:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 11457589 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1925D92A for ; Wed, 25 Mar 2020 11:50:45 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 755452077D for ; Wed, 25 Mar 2020 11:50:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nifty.com header.i=@nifty.com header.b="AxIyTfdu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 755452077D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-18219-patchwork-kernel-hardening=patchwork.kernel.org@lists.openwall.com Received: (qmail 11556 invoked by uid 550); 25 Mar 2020 11:50:40 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Delivered-To: mailing list kernel-hardening@lists.openwall.com Delivered-To: moderator for kernel-hardening@lists.openwall.com Received: (qmail 17788 invoked from network); 25 Mar 2020 03:15:33 -0000 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com 02P3EoCx025927 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1585106092; bh=cgsIqWqugMjz8HN6+lxwzq+uunzWFHXqk0J7yNJ3uGk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AxIyTfduvH5EL0D4ELrczuAbTkEw+h/281HSvn4KmAckOS9onjIlDYuzphTOAe2lm ZXhgen488xporCpvw0MiSjNyXnhF+h1nVU8mLVC0RmvfLTyToyvhcOh+BKY+G9+4Xx Ryf1y3+g4mMnlB+zrYuv/O6juACAjDVuSqFwGZAxG1U2JlMIKvq1mRRz/YL9YX83Oc y94dpFAap5NRspesnE3EEUstyT78StGRe5Vl6mmprqf47FB13vNZXhxyU2iBJqfQzb vfP70xBwyZkaDkBAvltd/Cd+Ea25kQW1ma/+KYwqyvuVj7pvOxSbUUT4Ej//+P8WnY 9OPilZGNKzJdw== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Kees Cook , kernel-hardening@lists.openwall.com, Masahiro Yamada , Emese Revfy , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH 2/2] kbuild: add -Wall to KBUILD_HOSTCXXFLAGS Date: Wed, 25 Mar 2020 12:14:32 +0900 Message-Id: <20200325031433.28223-2-masahiroy@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200325031433.28223-1-masahiroy@kernel.org> References: <20200325031433.28223-1-masahiroy@kernel.org> Add -Wall to catch more warnings for C++ host programs. When I submitted the previous version, the 0-day bot reported -Wc++11-compat warnings for old GCC: HOSTCXX -fPIC scripts/gcc-plugins/latent_entropy_plugin.o In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:28:0, from scripts/gcc-plugins/gcc-common.h:15, from scripts/gcc-plugins/latent_entropy_plugin.c:78: /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:102:21: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] fprintf ((FILE), "%s"HOST_WIDE_INT_PRINT_UNSIGNED"\n",\ ^ /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/config/elfos.h:170:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ In file included from /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/tm.h:42:0, from scripts/gcc-plugins/gcc-common.h:15, from scripts/gcc-plugins/latent_entropy_plugin.c:78: /usr/lib/gcc/x86_64-linux-gnu/4.8/plugin/include/defaults.h:126:24: warning: C++11 requires a space between string literal and macro [-Wc++11-compat] fprintf ((FILE), ","HOST_WIDE_INT_PRINT_UNSIGNED",%u\n", \ ^ The source of the warnings is in the plugin headers, so we have no control of it. I just suppressed them by adding -Wno-c++11-compat to scripts/gcc-plugins/Makefile. Signed-off-by: Masahiro Yamada Acked-by: Kees Cook --- Makefile | 2 +- scripts/gcc-plugins/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 3b57ccab367b..593d8f1bbe90 100644 --- a/Makefile +++ b/Makefile @@ -400,7 +400,7 @@ HOSTCXX = g++ KBUILD_HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ -fomit-frame-pointer -std=gnu89 $(HOST_LFS_CFLAGS) \ $(HOSTCFLAGS) -KBUILD_HOSTCXXFLAGS := -O2 $(HOST_LFS_CFLAGS) $(HOSTCXXFLAGS) +KBUILD_HOSTCXXFLAGS := -Wall -O2 $(HOST_LFS_CFLAGS) $(HOSTCXXFLAGS) KBUILD_HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) $(HOSTLDFLAGS) KBUILD_HOSTLDLIBS := $(HOST_LFS_LIBS) $(HOSTLDLIBS) diff --git a/scripts/gcc-plugins/Makefile b/scripts/gcc-plugins/Makefile index f2ee8bd7abc6..efff00959a9c 100644 --- a/scripts/gcc-plugins/Makefile +++ b/scripts/gcc-plugins/Makefile @@ -10,7 +10,7 @@ else HOSTLIBS := hostcxxlibs HOST_EXTRACXXFLAGS += -I$(GCC_PLUGINS_DIR)/include -I$(src) -std=gnu++98 -fno-rtti HOST_EXTRACXXFLAGS += -fno-exceptions -fasynchronous-unwind-tables -ggdb - HOST_EXTRACXXFLAGS += -Wno-narrowing -Wno-unused-variable + HOST_EXTRACXXFLAGS += -Wno-narrowing -Wno-unused-variable -Wno-c++11-compat export HOST_EXTRACXXFLAGS endif