From patchwork Fri Mar 27 11:02:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: afzal mohammed X-Patchwork-Id: 11462201 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 240A96CA for ; Fri, 27 Mar 2020 11:02:22 +0000 (UTC) Received: by mail.kernel.org (Postfix) id 1F440206F6; Fri, 27 Mar 2020 11:02:22 +0000 (UTC) Delivered-To: soc@kernel.org Received: from mail-pj1-f65.google.com (mail-pj1-f65.google.com [209.85.216.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1224206F1 for ; Fri, 27 Mar 2020 11:02:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bJ109yOb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1224206F1 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=afzal.mohd.ma@gmail.com Received: by mail-pj1-f65.google.com with SMTP id mj6so3694817pjb.5 for ; Fri, 27 Mar 2020 04:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=LuZLdXSN+q5r2FCozutdTsV9yrLtEZwRUZnlKK97vv4=; b=bJ109yObX3ShgbbK5n+aKh28Zik6wxz2ISvHWNZ/BfVQOuBkwnZmyd2cxuHOua1K8l +lV8+7sOkEnycypCeOhvGhUqbQfdVVpwZSlniOZFWzoT/cIfITibZdO3m+ML+aBxr+3L S3mlVolka5jOFH8lHFSsekNu9i6Htmcs8BCFM5P+pxiDFLV3eZVmMfDMciPdd78eszyc qCkMhuIE4sq0NGU1g46YKQi6awEbLQ49Q53FJTGVTYBm0L4r5mA/fPcZcugbWbBPnyHq rSR+6kYNrVmEvte7d200ftpB+C+wKDCR25TiA0XINS1eOy5p3JW7lKYrI/F8GgroVvnE z9xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=LuZLdXSN+q5r2FCozutdTsV9yrLtEZwRUZnlKK97vv4=; b=luq0BYqEsecPm22Lwgz+sopMnCYTHjuCfPE6b0VozE8jXWbK1kuKt+WnvZOxXmExFo SWVb5pizsxpuueNFTl48kSmMnUyLcaM2GndCDIz8sg2m2wosLgepFPnlcIQzrSSPBC+0 WsiHlf8WqG+1C/8kyqLMNPHM8Wa3CSkSXx4XJQs593m6o1tVWW/WTkY3zXCsUSfIVcHE diNhpGkruyN271OomCHhoz6M2LvvXpkH8pMVAi6pRCxPfC29r/EElYDKB/2JC2xwGRkn MPVd/p6qAMqAndtHRGQOWUrgdHy7ybRELf/OGhBSrHugaW4e15eJ5iY68mYjxmvK1Dmh 9ZKw== X-Gm-Message-State: ANhLgQ1c6QzDAjSCxAOjuElptvg6+Z0rjsyCp0piZ1Ezfx5sEQMXA+Bx IeDgr2EHTbQfFfYyeeK0gLg3LPVP X-Google-Smtp-Source: ADFU+vvkAa6Pz/lh/v/k+TwArZpuS/sLy8hL5F5Dm/Vjpwcu4OiMIR0a3TFItVZ0ixNMTCMXYrkpaA== X-Received: by 2002:a17:90a:e50e:: with SMTP id t14mr5071698pjy.98.1585306941024; Fri, 27 Mar 2020 04:02:21 -0700 (PDT) Received: from localhost ([183.82.181.40]) by smtp.gmail.com with ESMTPSA id bt19sm3531247pjb.3.2020.03.27.04.02.20 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Mar 2020 04:02:20 -0700 (PDT) Date: Fri, 27 Mar 2020 16:32:18 +0530 From: afzal mohammed List-Id: To: soc@kernel.org Subject: [afzal.mohd.ma@gmail.com: [PATCH v3] ARM: cns3xxx: replace setup_irq() by request_irq()] Message-ID: <20200327110218.GC8207@afzalpc> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.3 (2018-01-21) ----- Forwarded message from afzal mohammed ----- Date: Sun, 1 Mar 2020 17:51:55 +0530 From: afzal mohammed To: Viresh Kumar , Krzysztof Halasa , Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: afzal mohammed Subject: [PATCH v3] ARM: cns3xxx: replace setup_irq() by request_irq() X-Mailer: git-send-email 2.18.0 request_irq() is preferred over setup_irq(). Invocations of setup_irq() occur after memory allocators are ready. Per tglx[1], setup_irq() existed in olden days when allocators were not ready by the time early interrupts were initialized. Hence replace setup_irq() by request_irq(). [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos Signed-off-by: afzal mohammed --- Hi sub-arch maintainers, If the patch is okay, please take it thr' your tree. Regards afzal v3: * Split out from series, also split out from ARM patch to subarch level as Thomas suggested to take it thr' respective maintainers * Modify string displayed in case of error as suggested by Thomas * Re-arrange code as required to improve readability * Remove irrelevant parts from commit message & improve v2: * Replace pr_err("request_irq() on %s failed" by pr_err("%s: request_irq() failed" * Commit message massage arch/arm/mach-cns3xxx/core.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-cns3xxx/core.c b/arch/arm/mach-cns3xxx/core.c index 1d61a7701c11..e4f4b20b83a2 100644 --- a/arch/arm/mach-cns3xxx/core.c +++ b/arch/arm/mach-cns3xxx/core.c @@ -189,12 +189,6 @@ static irqreturn_t cns3xxx_timer_interrupt(int irq, void *dev_id) return IRQ_HANDLED; } -static struct irqaction cns3xxx_timer_irq = { - .name = "timer", - .flags = IRQF_TIMER | IRQF_IRQPOLL, - .handler = cns3xxx_timer_interrupt, -}; - /* * Set up the clock source and clock events devices */ @@ -245,7 +239,9 @@ static void __init __cns3xxx_timer_init(unsigned int timer_irq) writel(val, cns3xxx_tmr1 + TIMER1_2_CONTROL_OFFSET); /* Make irqs happen for the system timer */ - setup_irq(timer_irq, &cns3xxx_timer_irq); + if (request_irq(timer_irq, cns3xxx_timer_interrupt, + IRQF_TIMER | IRQF_IRQPOLL, "timer", NULL)) + pr_err("Failed to request irq %d (timer)\n", timer_irq); cns3xxx_clockevents_init(timer_irq); }