From patchwork Thu Apr 2 09:53:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 11470409 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0D3E11392 for ; Thu, 2 Apr 2020 09:53:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFF7B2073B for ; Thu, 2 Apr 2020 09:53:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="uXXinP3Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFF7B2073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A6E436EA38; Thu, 2 Apr 2020 09:53:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id ECC156EA33 for ; Thu, 2 Apr 2020 09:53:36 +0000 (UTC) Received: from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1CC9F80E; Thu, 2 Apr 2020 11:53:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1585821215; bh=tDuoun2j+1h5NtCFxtfhisJohP5EPRywtUTzUnFzhQ8=; h=From:To:Cc:Subject:Date:From; b=uXXinP3YfQbIqSZ6TY1WbeA7OyCbl5lKajTIInDKB+ycWc9GlhEdkjPzvJRrxir+A d1z57nvzr4/9DdtoZUckhoK0U7YKxdEMS5Qrjix1ZUPFL/twNKzamg3RNxW2GoHAOM uwJ9jJgBaxaXEXzGNYrIS8FzoyWyru+DthwJJ2eo= From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm: Fix wrong kfree() in managed resource usage example Date: Thu, 2 Apr 2020 12:53:25 +0300 Message-Id: <20200402095325.5266-1-laurent.pinchart+renesas@ideasonboard.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The example code showing how to use the managed resource API calls kfree() on the wrong pointer. Fix it. Fixes: d33b58d0115e ("drm: Garbage collect drm_dev_fini") Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 7dad7813fca1..c15c9b4540e1 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -305,7 +305,7 @@ void drm_minor_release(struct drm_minor *minor) * * ret = devm_drm_dev_init(&pdev->dev, drm, &driver_drm_driver); * if (ret) { - * kfree(drm); + * kfree(priv); * return ret; * } * drmm_add_final_kfree(drm, priv);