From patchwork Fri Jul 27 22:24:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Darrick J. Wong" X-Patchwork-Id: 10547779 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 57315180E for ; Fri, 27 Jul 2018 22:24:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 457832C76B for ; Fri, 27 Jul 2018 22:24:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 378432C793; Fri, 27 Jul 2018 22:24:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CDBA2C76B for ; Fri, 27 Jul 2018 22:24:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730953AbeG0XsP (ORCPT ); Fri, 27 Jul 2018 19:48:15 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:50576 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730850AbeG0XsP (ORCPT ); Fri, 27 Jul 2018 19:48:15 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w6RMOGYO059735; Fri, 27 Jul 2018 22:24:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : mime-version : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=X+JQsvMt2S14leAXuAd3T3UG5iLNMrbzWXd/+TOtOcs=; b=NVnd6WMyp5LgtU0ui0XTu0mGi7HyiJMfcpuhLu/elVEPxxSYkhZoIVrfIH09IbWfdJSj mtmxLxDKASYLUZUT+OJUaSmcBQs+YAuU9QrmaA5EqdNcP6zW2M4aH51xTuH7u4p9AdrT zBnEVDMyTD9YJG24o9x12UNDJ8JTVzxR0DSGdRI1COldIQMJXtdIlcbQHP/EL1ChdrHE tCIbSedbBlr0aiPHiP6mlzqGjuodzzkwodWnZJP5bVsGLsVSMtA54Jyb5iNt8KzexsBJ Hd4idplkgyrrzqKPJDK45RmYazIqgdUhGUZa+F5ve6I4BMrtjRZuRoid/sN39Tp3wFNT tA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2kbwfq8s4b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Jul 2018 22:24:16 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w6RMOFH8025672 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 27 Jul 2018 22:24:15 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w6RMOEA4014459; Fri, 27 Jul 2018 22:24:15 GMT Received: from localhost (/10.145.179.122) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 27 Jul 2018 15:24:14 -0700 Subject: [PATCH 1/2] misc: use xfs_agfl_walk where appropriate From: "Darrick J. Wong" To: sandeen@redhat.com, darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org Date: Fri, 27 Jul 2018 15:24:13 -0700 Message-ID: <153273025311.29060.14065633572750924491.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8967 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807270227 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Darrick J. Wong Use the xfs_agfl_walk function to iterate every block in the AGFL, instead of open-coding it db and repair. Signed-off-by: Darrick J. Wong --- db/check.c | 60 ++++++++++++++++++++++-------------------- db/freesp.c | 31 ++++++++-------------- libxfs/libxfs_api_defs.h | 1 + repair/scan.c | 66 +++++++++++++++++++++++++--------------------- 4 files changed, 81 insertions(+), 77 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/db/check.c b/db/check.c index 9846d672..76c28d49 100644 --- a/db/check.c +++ b/db/check.c @@ -4010,16 +4010,30 @@ scan_ag( pop_cur(); } +struct agfl_state { + xfs_agnumber_t agno; + unsigned int count; +}; + +static int +scan_agfl( + struct xfs_mount *mp, + xfs_agblock_t bno, + void *priv) +{ + struct agfl_state *as = priv; + + set_dbmap(as->agno, bno, 1, DBM_FREELIST, as->agno, XFS_AGFL_BLOCK(mp)); + as->count++; + return 0; +} + static void scan_freelist( - xfs_agf_t *agf) + xfs_agf_t *agf) { - xfs_agnumber_t seqno = be32_to_cpu(agf->agf_seqno); - xfs_agfl_t *agfl; - xfs_agblock_t bno; - uint count; - int i; - __be32 *freelist; + xfs_agnumber_t seqno = be32_to_cpu(agf->agf_seqno); + struct agfl_state state; if (XFS_SB_BLOCK(mp) != XFS_AGFL_BLOCK(mp) && XFS_AGF_BLOCK(mp) != XFS_AGFL_BLOCK(mp) && @@ -4032,46 +4046,36 @@ scan_freelist( set_cur(&typtab[TYP_AGFL], XFS_AG_DADDR(mp, seqno, XFS_AGFL_DADDR(mp)), XFS_FSS_TO_BB(mp, 1), DB_RING_IGN, NULL); - if ((agfl = iocur_top->data) == NULL) { + if (iocur_top->data == NULL) { dbprintf(_("can't read agfl block for ag %u\n"), seqno); serious_error++; pop_cur(); return; } - i = be32_to_cpu(agf->agf_flfirst); /* verify agf values before proceeding */ if (be32_to_cpu(agf->agf_flfirst) >= libxfs_agfl_size(mp) || be32_to_cpu(agf->agf_fllast) >= libxfs_agfl_size(mp)) { dbprintf(_("agf %d freelist blocks bad, skipping " - "freelist scan\n"), i); + "freelist scan\n"), seqno); pop_cur(); return; } /* open coded XFS_BUF_TO_AGFL_BNO */ - freelist = xfs_sb_version_hascrc(&((mp)->m_sb)) ? &agfl->agfl_bno[0] - : (__be32 *)agfl; - count = 0; - for (;;) { - bno = be32_to_cpu(freelist[i]); - set_dbmap(seqno, bno, 1, DBM_FREELIST, seqno, - XFS_AGFL_BLOCK(mp)); - count++; - if (i == be32_to_cpu(agf->agf_fllast)) - break; - if (++i == libxfs_agfl_size(mp)) - i = 0; - } - if (count != be32_to_cpu(agf->agf_flcount)) { + state.count = 0; + state.agno = seqno; + libxfs_agfl_walk(mp, agf, iocur_top->bp, scan_agfl, &state); + if (state.count != be32_to_cpu(agf->agf_flcount)) { if (!sflag) dbprintf(_("freeblk count %u != flcount %u in ag %u\n"), - count, be32_to_cpu(agf->agf_flcount), - seqno); + state.count, + be32_to_cpu(agf->agf_flcount), + seqno); error++; } - fdblocks += count; - agf_aggr_freeblks += count; + fdblocks += state.count; + agf_aggr_freeblks += state.count; pop_cur(); } diff --git a/db/freesp.c b/db/freesp.c index de0d5e10..903c60d7 100644 --- a/db/freesp.c +++ b/db/freesp.c @@ -219,45 +219,38 @@ scan_ag( pop_cur(); } +static int +scan_agfl( + struct xfs_mount *mp, + xfs_agblock_t bno, + void *priv) +{ + addtohist(*(xfs_agnumber_t *)priv, bno, 1); + return 0; +} + static void scan_freelist( xfs_agf_t *agf) { xfs_agnumber_t seqno = be32_to_cpu(agf->agf_seqno); - xfs_agfl_t *agfl; - xfs_agblock_t bno; - int i; - __be32 *agfl_bno; if (be32_to_cpu(agf->agf_flcount) == 0) return; push_cur(); set_cur(&typtab[TYP_AGFL], XFS_AG_DADDR(mp, seqno, XFS_AGFL_DADDR(mp)), XFS_FSS_TO_BB(mp, 1), DB_RING_IGN, NULL); - agfl = iocur_top->data; - i = be32_to_cpu(agf->agf_flfirst); - - /* open coded XFS_BUF_TO_AGFL_BNO */ - agfl_bno = xfs_sb_version_hascrc(&mp->m_sb) ? &agfl->agfl_bno[0] - : (__be32 *)agfl; /* verify agf values before proceeding */ if (be32_to_cpu(agf->agf_flfirst) >= libxfs_agfl_size(mp) || be32_to_cpu(agf->agf_fllast) >= libxfs_agfl_size(mp)) { dbprintf(_("agf %d freelist blocks bad, skipping " - "freelist scan\n"), i); + "freelist scan\n"), seqno); pop_cur(); return; } - for (;;) { - bno = be32_to_cpu(agfl_bno[i]); - addtohist(seqno, bno, 1); - if (i == be32_to_cpu(agf->agf_fllast)) - break; - if (++i == libxfs_agfl_size(mp)) - i = 0; - } + libxfs_agfl_walk(mp, agf, iocur_top->bp, scan_agfl, &seqno); pop_cur(); } diff --git a/libxfs/libxfs_api_defs.h b/libxfs/libxfs_api_defs.h index 74a5af16..e5cf1554 100644 --- a/libxfs/libxfs_api_defs.h +++ b/libxfs/libxfs_api_defs.h @@ -54,6 +54,7 @@ #define xfs_attr_remove libxfs_attr_remove #define xfs_attr_leaf_newentsize libxfs_attr_leaf_newentsize +#define xfs_agfl_walk libxfs_agfl_walk #define xfs_alloc_fix_freelist libxfs_alloc_fix_freelist #define xfs_alloc_min_freelist libxfs_alloc_min_freelist #define xfs_alloc_read_agf libxfs_alloc_read_agf diff --git a/repair/scan.c b/repair/scan.c index 7b671123..63d20071 100644 --- a/repair/scan.c +++ b/repair/scan.c @@ -2095,17 +2095,36 @@ _("inode btree block claimed (state %d), agno %d, bno %d, suspect %d\n"), } } +struct agfl_state { + unsigned int count; + xfs_agnumber_t agno; +}; + +static int +scan_agfl( + struct xfs_mount *mp, + xfs_agblock_t bno, + void *priv) +{ + struct agfl_state *as = priv; + + if (verify_agbno(mp, as->agno, bno)) + set_bmap(as->agno, bno, XR_E_FREE); + else + do_warn(_("bad agbno %u in agfl, agno %d\n"), + bno, as->agno); + as->count++; + return 0; +} + static void scan_freelist( - xfs_agf_t *agf, - struct aghdr_cnts *agcnts) + xfs_agf_t *agf, + struct aghdr_cnts *agcnts) { - xfs_buf_t *agflbuf; - xfs_agnumber_t agno; - xfs_agblock_t bno; - int count; - int i; - __be32 *freelist; + xfs_buf_t *agflbuf; + xfs_agnumber_t agno; + struct agfl_state state; agno = be32_to_cpu(agf->agf_seqno); @@ -2127,39 +2146,26 @@ scan_freelist( if (agflbuf->b_error == -EFSBADCRC) do_warn(_("agfl has bad CRC for ag %d\n"), agno); - freelist = XFS_BUF_TO_AGFL_BNO(mp, agflbuf); - i = be32_to_cpu(agf->agf_flfirst); - if (no_modify) { /* agf values not fixed in verify_set_agf, so recheck */ if (be32_to_cpu(agf->agf_flfirst) >= libxfs_agfl_size(mp) || be32_to_cpu(agf->agf_fllast) >= libxfs_agfl_size(mp)) { do_warn(_("agf %d freelist blocks bad, skipping " - "freelist scan\n"), i); + "freelist scan\n"), agno); return; } } - count = 0; - for (;;) { - bno = be32_to_cpu(freelist[i]); - if (verify_agbno(mp, agno, bno)) - set_bmap(agno, bno, XR_E_FREE); - else - do_warn(_("bad agbno %u in agfl, agno %d\n"), - bno, agno); - count++; - if (i == be32_to_cpu(agf->agf_fllast)) - break; - if (++i == libxfs_agfl_size(mp)) - i = 0; - } - if (count != be32_to_cpu(agf->agf_flcount)) { - do_warn(_("freeblk count %d != flcount %d in ag %d\n"), count, - be32_to_cpu(agf->agf_flcount), agno); + state.count = 0; + state.agno = agno; + libxfs_agfl_walk(mp, agf, agflbuf, scan_agfl, &state); + if (state.count != be32_to_cpu(agf->agf_flcount)) { + do_warn(_("freeblk count %d != flcount %d in ag %d\n"), + state.count, be32_to_cpu(agf->agf_flcount), + agno); } - agcnts->fdblocks += count; + agcnts->fdblocks += state.count; libxfs_putbuf(agflbuf); }