From patchwork Wed Apr 8 19:05:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 11480687 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1CDB492A for ; Wed, 8 Apr 2020 19:06:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC6632075E for ; Wed, 8 Apr 2020 19:06:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ftof1Crg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC6632075E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=UtO7CLMSWNXR1W6K+7a6gGD35Do9ofuZf1HNPzACkCY=; b=ftof1Crgc7GJUL ZHrFnOvB5ciD7XU5KMJy5++xk9ZAlY1jhq8uYBtCLnYm+2dnRSI+//sGycP7yvs0mLSvFtbR/Hk08 Plbvgs2jWksbPk3Atom+APaec6F9hmfJrt+NvIw1o61ndV9E5SMxlP0ozBATXj61/bfJoRVRRtN8c iJX3mM6b7cBzNuhYh9AJawLHUBFrHmsWF0434RY6lfHXOqAR7RxtI9hyi7Mo0+ZszOV9UjTcxLIwH YRv2EpUZCZjDYtximggXRkfL8WYO1qbvuBlpsdJRqSjqttscAsfUyb8qI3JaGmDDpJHE2jziOyb3r c9A96M1uu6gfW9JarGHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMG1k-0007Kd-Ir; Wed, 08 Apr 2020 19:06:20 +0000 Received: from mout.kundenserver.de ([217.72.192.73]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMG1i-0007KA-2B for ath11k@lists.infradead.org; Wed, 08 Apr 2020 19:06:19 +0000 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPA (Nemesis) id 1Mnq0K-1ixdiP2yeg-00pIaM; Wed, 08 Apr 2020 21:06:07 +0200 From: Arnd Bergmann To: Kalle Valo , "David S. Miller" , Pradeep Kumar Chitrapu Subject: [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling Date: Wed, 8 Apr 2020 21:05:57 +0200 Message-Id: <20200408190606.870098-1-arnd@arndb.de> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:SeyubJqFpa1uafAlCsFxxDdFdIAWrMtRLnpLQBjRCYvNbclJZd+ 3TPNst9q4QXUyugz143HRknRijNEFwEvl9MBJr/brYhGtVhUtFFEs/eK8GVOgPzmehL2NcT Buc+ywYb93iNu8gC+h6PmnazxslEYSHKztCYXZPVkI26WDLYIdsph1dg5wsHjOEvuyVgFjy P5faWwfYJcYYudJ9/c2GA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:6+0XJ7spHeE=:c38GdB3GYqq35dV+iS/LzJ yqnSpzMGz26tnARxwvAnIYB0Jm7RqRQNgOXeiBOSpyEfbcCmAWBaKj2Qewl9/5TdWv9tDWCea 1A8teM01nY/STU5PfZZLJS6zfkpDESqz0IKo9xZJfGKnlzgzdqew4Yt8VYxJbQaImBmHga09n JYGEYcR5V+9D4vkcOawjLR9ZXckzEI7TJsKUXeSI8JYsBOM0E6y1GSPc9heLNTSwH/L4/xjE3 BRogw47X0eSyUWzJ0Drb7gC0Il7ygmKvWlOmh0v+r6zste7W55M0ARvL6z8aO0z6kgZP7r16f +42l0QH6NmkcPRgFDJ3eucLNYpnyTRA2wv5qdxaQy6EDRkmso26KW9be6U7G32WndgYYGRRMI 18buGGuMfDm9OHABOhXjumFWTuOe33630T23nq4VD8ShUDi2GnlkOekyJ0lFQIkaD/MNHxDQo wPiWZD9WIpN+yk/Wh+ZT741wLq51ppWTQCmh2JZtCOuJ1rwfVbqsEthQXHAWwsdPqQFVOHEcu 9MzrGzLNg4k5qDPjckmFB8S3gRerZPftuNsI70kHIjo7RAiuRKuSfgUdoIkBj/StgVNvXwZxo 7Lo16TKe6/uwxhJyjdqDSeM2JNtW+SbOdPR+OFHJLQLUY655g91YxJZp1EiXUVUxJ3y+TMvQj 8MApRnajPz538QFmRMvrdeFc9pWJwCd8PcMwQGLkvbCt+TybYlz3sRjYb4dg+k5sou/5gOd5Z 1DjQSShjxKOHdx/hjqWVOv1XhiikOPO6qcsHwHSJ4/95o8pL4NLbwtrKXLisU0WVJ2anb6TQE Gqvtczba9hsT48NSJcWmaOETPRm58u2n92dPYWhstv8uWPGsAo= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200408_120618_402078_52313AA8 X-CRM114-Status: UNSURE ( 9.30 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [217.72.192.73 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, Arnd Bergmann , linux-kernel@vger.kernel.org Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org The empty stub version of this function causes a compile-time warning: In file included from drivers/net/wireless/ath/ath11k/core.h:23, from drivers/net/wireless/ath/ath11k/dp_rx.h:8, from drivers/net/wireless/ath/ath11k/ce.c:6: drivers/net/wireless/ath/ath11k/thermal.h: In function 'ath11k_thermal_set_throttling': drivers/net/wireless/ath/ath11k/thermal.h:45:1: error: no return statement in function returning non-void [-Werror=return-type] Just return success here. Fixes: a41d10348b01 ("ath11k: add thermal sensor device support") Signed-off-by: Arnd Bergmann --- drivers/net/wireless/ath/ath11k/thermal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h index 459b8d49c184..f1395a14748c 100644 --- a/drivers/net/wireless/ath/ath11k/thermal.h +++ b/drivers/net/wireless/ath/ath11k/thermal.h @@ -42,6 +42,7 @@ static inline void ath11k_thermal_unregister(struct ath11k *ar) static inline int ath11k_thermal_set_throttling(struct ath11k *ar, u32 throttle_state) { + return 0; } static inline void ath11k_thermal_event_temperature(struct ath11k *ar, From patchwork Wed Apr 8 19:05:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 11480691 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4F4B192C for ; Wed, 8 Apr 2020 19:06:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 295C920768 for ; Wed, 8 Apr 2020 19:06:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UByTQyFU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 295C920768 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=55sFl3kelZhu8DNDSz/sQib+lCEoePKzn30OkBq7Q5s=; b=UByTQyFUa35wCp fEvu7aUunS+jkxY64uxz0oaCDdoHSJkvJR3IbNDtKgY08Fh7ELtYHcz0sQKzAqNYNwQMR3BE+TYAo PT0hf6T/GjooQKm02ki1/LiDAlC+suXV7Evh5VC1/5ufMM1YGKd0qNw9WxzLFZ//oxxqHYqhxgkaw KDlbhPWFBVkvLog1MnDSEAVX9wZhz+vlNy+J3ARY7D7rR+8vtPFm9OOxJ7yDNrWgzOKPOFrWq07Uf gP43CdUq5QUuJ+C6vjIIDDKlu9RaKLM0OE7IX2enoT26jrWajHp5JxccUjNSmD/LpyEQVUAML3B0L VUdfk17CAAno3esnzxTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMG1p-0007Mx-T2; Wed, 08 Apr 2020 19:06:25 +0000 Received: from mout.kundenserver.de ([217.72.192.73]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jMG1m-0007LO-P6 for ath11k@lists.infradead.org; Wed, 08 Apr 2020 19:06:24 +0000 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPA (Nemesis) id 1MvsMz-1j3Usz47Ff-00syup; Wed, 08 Apr 2020 21:06:15 +0200 From: Arnd Bergmann To: Kalle Valo , "David S. Miller" , Pradeep Kumar Chitrapu Subject: [PATCH 2/2] ath11k: fix ath11k_thermal_unregister() prototype Date: Wed, 8 Apr 2020 21:05:58 +0200 Message-Id: <20200408190606.870098-2-arnd@arndb.de> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200408190606.870098-1-arnd@arndb.de> References: <20200408190606.870098-1-arnd@arndb.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:oCd7sSwGt5YtvhR1EtVG0EnYB9ND3DYTFpON3rvHRhezeRJWaRg Ci6yzknixyP/4TPSc1fyYK73SO0IkwNLsHhHTzYYSG5k/1dnG1fjxvWXV50DYhHixOZbMdv +42Z2mRdZSFWAqVbcg5V+d9vHOiLGFsaK8ip4Dicrmfl5S3uUCgIxwAKdPFKVXbwriEa6Sa O/F6qoAP0GvkXWi2IC4qw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:zxTRjTk5c/c=:zhbeWRqSNt8W0fzyMu5juw MRbewvuYqX9K1I0IDrbEIfVCPD2xbdooiMURmcTFDAC2RcpS/hDgLYx4eVs50PlalUNU9aAsg guWyWIDkxhidVDkwWDCt5/pGHpz5HomTasdnRbBatxfQ2ndfu7Bx/0WY6V/l9OOlzPoA6gLJ5 kOYDGB0LZFxyBrmi7pRNaCxSzUDxusPYqBuP6iJfIe8N46CUdMsUwtiCjpS0waxyJh27adnmW cxLaXjW2vN1a8/Zz2sOXwq/s7CO78H6S4aLiLoTjL1VcqGJeOredn5gGg5a/Qv10T8Zc1KxUu hEyy/ly4rycB9ilP7Pj7761hABxe4h59D2N6OdGisHQDSjU0XgI7YVsK01Ng/THs5WRCXV9iA bCbMRJGN49+07ZXStR34cBfy7KblaWScaSRUonTsSSOwnM9ZZDATYBwXJqiJSZV3jvc4gn3FD y45gg5ANZ51wEqiEZogkjz0kYyNrfyS8HYywNGLal/tPfEv12TY/rBhcvwcx5r/dsai7TsxYW bzc9Ds6+xqCveZjqL6bieq7PBYAE3/Xr9ALMIMSXIRn95Mh1R0gFntQcbjFTknA4ov0fWQ0Kk rAM4DkJfw1PpmWpdidK4mn6lvYBEvUmSrR+vrKpVyFPzalx9KXqg0opkKq0CTfG5mezpuDOkk LXtqlTdM6egg62XdXns6znUqmbR7px5Cfaganv7HH8BFvby5XhHqasViE4JCryd4CffrcOwMT hPNuj/dedv+w0lmubBYBU1D2yYSCVJuaTscvyq+u1payGmjtA5L72ysDj8yMFSLwehcMcfahA 1WetWAtMqVq8znb6W3WOFaJTlxgutZE2JZkFzzfWDZZ+unbVpE= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200408_120623_107049_DC1EB152 X-CRM114-Status: GOOD ( 11.25 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [217.72.192.73 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, Arnd Bergmann , linux-kernel@vger.kernel.org Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org The stub function has the wrong prototype, causing a warning: drivers/net/wireless/ath/ath11k/core.c: In function 'ath11k_core_pdev_destroy': drivers/net/wireless/ath/ath11k/core.c:416:28: error: passing argument 1 of 'ath11k_thermal_unregister' from incompatible pointer type [-Werror=incompatible-pointer-types] Change it to take the same arguments as the normal implementation. Fixes: 2a63bbca06b2 ("ath11k: add thermal cooling device support") Signed-off-by: Arnd Bergmann --- drivers/net/wireless/ath/ath11k/thermal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h index f1395a14748c..ea9a58bf6a93 100644 --- a/drivers/net/wireless/ath/ath11k/thermal.h +++ b/drivers/net/wireless/ath/ath11k/thermal.h @@ -36,7 +36,7 @@ static inline int ath11k_thermal_register(struct ath11k_base *sc) return 0; } -static inline void ath11k_thermal_unregister(struct ath11k *ar) +static inline void ath11k_thermal_unregister(struct ath11k_base *ar) { }