From patchwork Wed Apr 8 19:05:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 11480689 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7913992A for ; Wed, 8 Apr 2020 19:06:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5FC4A2075E for ; Wed, 8 Apr 2020 19:06:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729348AbgDHTGV (ORCPT ); Wed, 8 Apr 2020 15:06:21 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:51681 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbgDHTGU (ORCPT ); Wed, 8 Apr 2020 15:06:20 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPA (Nemesis) id 1Mnq0K-1ixdiP2yeg-00pIaM; Wed, 08 Apr 2020 21:06:07 +0200 From: Arnd Bergmann To: Kalle Valo , "David S. Miller" , Pradeep Kumar Chitrapu Cc: Arnd Bergmann , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] ath11k: fix missing return in ath11k_thermal_set_throttling Date: Wed, 8 Apr 2020 21:05:57 +0200 Message-Id: <20200408190606.870098-1-arnd@arndb.de> X-Mailer: git-send-email 2.26.0 MIME-Version: 1.0 X-Provags-ID: V03:K1:SeyubJqFpa1uafAlCsFxxDdFdIAWrMtRLnpLQBjRCYvNbclJZd+ 3TPNst9q4QXUyugz143HRknRijNEFwEvl9MBJr/brYhGtVhUtFFEs/eK8GVOgPzmehL2NcT Buc+ywYb93iNu8gC+h6PmnazxslEYSHKztCYXZPVkI26WDLYIdsph1dg5wsHjOEvuyVgFjy P5faWwfYJcYYudJ9/c2GA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:6+0XJ7spHeE=:c38GdB3GYqq35dV+iS/LzJ yqnSpzMGz26tnARxwvAnIYB0Jm7RqRQNgOXeiBOSpyEfbcCmAWBaKj2Qewl9/5TdWv9tDWCea 1A8teM01nY/STU5PfZZLJS6zfkpDESqz0IKo9xZJfGKnlzgzdqew4Yt8VYxJbQaImBmHga09n JYGEYcR5V+9D4vkcOawjLR9ZXckzEI7TJsKUXeSI8JYsBOM0E6y1GSPc9heLNTSwH/L4/xjE3 BRogw47X0eSyUWzJ0Drb7gC0Il7ygmKvWlOmh0v+r6zste7W55M0ARvL6z8aO0z6kgZP7r16f +42l0QH6NmkcPRgFDJ3eucLNYpnyTRA2wv5qdxaQy6EDRkmso26KW9be6U7G32WndgYYGRRMI 18buGGuMfDm9OHABOhXjumFWTuOe33630T23nq4VD8ShUDi2GnlkOekyJ0lFQIkaD/MNHxDQo wPiWZD9WIpN+yk/Wh+ZT741wLq51ppWTQCmh2JZtCOuJ1rwfVbqsEthQXHAWwsdPqQFVOHEcu 9MzrGzLNg4k5qDPjckmFB8S3gRerZPftuNsI70kHIjo7RAiuRKuSfgUdoIkBj/StgVNvXwZxo 7Lo16TKe6/uwxhJyjdqDSeM2JNtW+SbOdPR+OFHJLQLUY655g91YxJZp1EiXUVUxJ3y+TMvQj 8MApRnajPz538QFmRMvrdeFc9pWJwCd8PcMwQGLkvbCt+TybYlz3sRjYb4dg+k5sou/5gOd5Z 1DjQSShjxKOHdx/hjqWVOv1XhiikOPO6qcsHwHSJ4/95o8pL4NLbwtrKXLisU0WVJ2anb6TQE Gqvtczba9hsT48NSJcWmaOETPRm58u2n92dPYWhstv8uWPGsAo= Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The empty stub version of this function causes a compile-time warning: In file included from drivers/net/wireless/ath/ath11k/core.h:23, from drivers/net/wireless/ath/ath11k/dp_rx.h:8, from drivers/net/wireless/ath/ath11k/ce.c:6: drivers/net/wireless/ath/ath11k/thermal.h: In function 'ath11k_thermal_set_throttling': drivers/net/wireless/ath/ath11k/thermal.h:45:1: error: no return statement in function returning non-void [-Werror=return-type] Just return success here. Fixes: a41d10348b01 ("ath11k: add thermal sensor device support") Signed-off-by: Arnd Bergmann --- drivers/net/wireless/ath/ath11k/thermal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h index 459b8d49c184..f1395a14748c 100644 --- a/drivers/net/wireless/ath/ath11k/thermal.h +++ b/drivers/net/wireless/ath/ath11k/thermal.h @@ -42,6 +42,7 @@ static inline void ath11k_thermal_unregister(struct ath11k *ar) static inline int ath11k_thermal_set_throttling(struct ath11k *ar, u32 throttle_state) { + return 0; } static inline void ath11k_thermal_event_temperature(struct ath11k *ar, From patchwork Wed Apr 8 19:05:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 11480693 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6446492A for ; Wed, 8 Apr 2020 19:06:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B9FF2075E for ; Wed, 8 Apr 2020 19:06:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729623AbgDHTG0 (ORCPT ); Wed, 8 Apr 2020 15:06:26 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:42319 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726730AbgDHTGZ (ORCPT ); Wed, 8 Apr 2020 15:06:25 -0400 Received: from threadripper.lan ([149.172.19.189]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.145]) with ESMTPA (Nemesis) id 1MvsMz-1j3Usz47Ff-00syup; Wed, 08 Apr 2020 21:06:15 +0200 From: Arnd Bergmann To: Kalle Valo , "David S. Miller" , Pradeep Kumar Chitrapu Cc: Arnd Bergmann , ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] ath11k: fix ath11k_thermal_unregister() prototype Date: Wed, 8 Apr 2020 21:05:58 +0200 Message-Id: <20200408190606.870098-2-arnd@arndb.de> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200408190606.870098-1-arnd@arndb.de> References: <20200408190606.870098-1-arnd@arndb.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:oCd7sSwGt5YtvhR1EtVG0EnYB9ND3DYTFpON3rvHRhezeRJWaRg Ci6yzknixyP/4TPSc1fyYK73SO0IkwNLsHhHTzYYSG5k/1dnG1fjxvWXV50DYhHixOZbMdv +42Z2mRdZSFWAqVbcg5V+d9vHOiLGFsaK8ip4Dicrmfl5S3uUCgIxwAKdPFKVXbwriEa6Sa O/F6qoAP0GvkXWi2IC4qw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:zxTRjTk5c/c=:zhbeWRqSNt8W0fzyMu5juw MRbewvuYqX9K1I0IDrbEIfVCPD2xbdooiMURmcTFDAC2RcpS/hDgLYx4eVs50PlalUNU9aAsg guWyWIDkxhidVDkwWDCt5/pGHpz5HomTasdnRbBatxfQ2ndfu7Bx/0WY6V/l9OOlzPoA6gLJ5 kOYDGB0LZFxyBrmi7pRNaCxSzUDxusPYqBuP6iJfIe8N46CUdMsUwtiCjpS0waxyJh27adnmW cxLaXjW2vN1a8/Zz2sOXwq/s7CO78H6S4aLiLoTjL1VcqGJeOredn5gGg5a/Qv10T8Zc1KxUu hEyy/ly4rycB9ilP7Pj7761hABxe4h59D2N6OdGisHQDSjU0XgI7YVsK01Ng/THs5WRCXV9iA bCbMRJGN49+07ZXStR34cBfy7KblaWScaSRUonTsSSOwnM9ZZDATYBwXJqiJSZV3jvc4gn3FD y45gg5ANZ51wEqiEZogkjz0kYyNrfyS8HYywNGLal/tPfEv12TY/rBhcvwcx5r/dsai7TsxYW bzc9Ds6+xqCveZjqL6bieq7PBYAE3/Xr9ALMIMSXIRn95Mh1R0gFntQcbjFTknA4ov0fWQ0Kk rAM4DkJfw1PpmWpdidK4mn6lvYBEvUmSrR+vrKpVyFPzalx9KXqg0opkKq0CTfG5mezpuDOkk LXtqlTdM6egg62XdXns6znUqmbR7px5Cfaganv7HH8BFvby5XhHqasViE4JCryd4CffrcOwMT hPNuj/dedv+w0lmubBYBU1D2yYSCVJuaTscvyq+u1payGmjtA5L72ysDj8yMFSLwehcMcfahA 1WetWAtMqVq8znb6W3WOFaJTlxgutZE2JZkFzzfWDZZ+unbVpE= Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org The stub function has the wrong prototype, causing a warning: drivers/net/wireless/ath/ath11k/core.c: In function 'ath11k_core_pdev_destroy': drivers/net/wireless/ath/ath11k/core.c:416:28: error: passing argument 1 of 'ath11k_thermal_unregister' from incompatible pointer type [-Werror=incompatible-pointer-types] Change it to take the same arguments as the normal implementation. Fixes: 2a63bbca06b2 ("ath11k: add thermal cooling device support") Signed-off-by: Arnd Bergmann --- drivers/net/wireless/ath/ath11k/thermal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/thermal.h b/drivers/net/wireless/ath/ath11k/thermal.h index f1395a14748c..ea9a58bf6a93 100644 --- a/drivers/net/wireless/ath/ath11k/thermal.h +++ b/drivers/net/wireless/ath/ath11k/thermal.h @@ -36,7 +36,7 @@ static inline int ath11k_thermal_register(struct ath11k_base *sc) return 0; } -static inline void ath11k_thermal_unregister(struct ath11k *ar) +static inline void ath11k_thermal_unregister(struct ath11k_base *ar) { }