From patchwork Sat Apr 11 00:19:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jules Irenge X-Patchwork-Id: 11483843 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D274C1805 for ; Sat, 11 Apr 2020 00:20:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B483A21BE5 for ; Sat, 11 Apr 2020 00:20:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fbgzlwyn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726839AbgDKAU0 (ORCPT ); Fri, 10 Apr 2020 20:20:26 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:45010 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726898AbgDKAUZ (ORCPT ); Fri, 10 Apr 2020 20:20:25 -0400 Received: by mail-wr1-f67.google.com with SMTP id c15so4025674wro.11; Fri, 10 Apr 2020 17:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=evS1Gd0mYBhXTAjCV3dzUcM/sTYhBLIlQOkalJ0AkMA=; b=FbgzlwynoTQPwao9PAPWW39jzj/Gzj1N394UpRJZ9TvXyJIxAU7+4rmoMaf8fFLE2r RcQg667B2vZGgXiY7F7cOasoi786I/UqhvdCVDa7ALXNae63/kQMStGL0URM90FPMoSa DJ1K0kNkDsGKPBhxEzFQKO3MqDjwFLAVJCsWYoUj6HCiMX1t40JcAQ8N4Y+VX7QOxzWy 6I4qnvklmwEe7+xnjnkWsqxPzKwxng8L+eJQiQKOw0qYEDrskuPZW2wO43TUOG39a9MZ CggT5hiqZx81ok2WmPvig0OWjlA6Fr+El15Hxb/N5w+O35E2EFp9nobnyhe1dhGC85iw AAgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=evS1Gd0mYBhXTAjCV3dzUcM/sTYhBLIlQOkalJ0AkMA=; b=icEOEpsH0GZrtL61Ohy7hBnHkH2fcllia8XPWhHjrGJquBDBdfh5FKIHB69MZ+JXdg 339Qgg6XpYW4atcP11D5Mk6r32K13wpv0KFeBvhnw8UCzigyDx+D4YkCmcl31dLQtltu Ypes4Uz/J1MemmJhQqGPQdKlZbulW0EvN8HOo7fjXUGyWkjAm/sEC8EtsY4kIxNzqpvq YFPyWMnJcWR4YYE5I2cm22irUXDpY1cDuRjIchx6xcV0p4aQM1lZBwp774rnU76x4k1w C5sqd4dlNXwHrM1aP1WCvwJrs3mGOmnN67KEEo2z9x6XqFaPrENy0IQyCych92EIeio7 j/FQ== X-Gm-Message-State: AGi0PuYLyz0liSPt45OoiQfFu8thSQI5mM5OoGXKwivMDcaqP9DuXU0z CFx5m2xwjw/h+ku0TxhceEUMMLJa9jaY X-Google-Smtp-Source: APiQypL9+Y3FnS59lypT6b279qCBb89m8eNsC0cDe/afDwiChzijzhfuMVss+6+KaUKZ2JovWOY2RA== X-Received: by 2002:adf:f790:: with SMTP id q16mr6690593wrp.94.1586564422500; Fri, 10 Apr 2020 17:20:22 -0700 (PDT) Received: from ninjahost.lan (host-2-102-14-153.as13285.net. [2.102.14.153]) by smtp.gmail.com with ESMTPSA id b191sm5091594wmd.39.2020.04.10.17.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 17:20:22 -0700 (PDT) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, "Rafael J. Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , linux-pm@vger.kernel.org (open list:HIBERNATION (aka Software Suspend, aka swsusp)) Subject: [PATCH 8/9] power: wakeup: Add missing annotation for wakeup_sources_stats_seq_start() and wakeup_sources_stats_seq_stop() Date: Sat, 11 Apr 2020 01:19:32 +0100 Message-Id: <20200411001933.10072-9-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200411001933.10072-1-jbi.octave@gmail.com> References: <0/9> <20200411001933.10072-1-jbi.octave@gmail.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Sparse reports warnings at wakeup_sources_stats_seq_start() and wakeup_sources_stats_seq_stop() warning: context imbalance in wakeup_sources_stats_seq_start() - wrong count at exit context imbalance in wakeup_sources_stats_seq_stop() - unexpected unlock The root cause is the missing annotation at wakeup_sources_stats_seq_start() and wakeup_sources_stats_seq_stop() Add the missing __acquires(&wakeup_srcu) annotation Add the missing __releases(&wakeup_srcu) annotation Signed-off-by: Jules Irenge --- drivers/base/power/wakeup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c index 27f3e60608e5..41ce086d8f57 100644 --- a/drivers/base/power/wakeup.c +++ b/drivers/base/power/wakeup.c @@ -1092,6 +1092,7 @@ static int print_wakeup_source_stats(struct seq_file *m, static void *wakeup_sources_stats_seq_start(struct seq_file *m, loff_t *pos) + __acquires(&wakeup_srcu) { struct wakeup_source *ws; loff_t n = *pos; @@ -1132,6 +1133,7 @@ static void *wakeup_sources_stats_seq_next(struct seq_file *m, } static void wakeup_sources_stats_seq_stop(struct seq_file *m, void *v) + __releases(&wakeup_srcu) { int *srcuidx = m->private; From patchwork Sat Apr 11 00:19:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jules Irenge X-Patchwork-Id: 11483847 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 82C541805 for ; Sat, 11 Apr 2020 00:20:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6402821841 for ; Sat, 11 Apr 2020 00:20:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GUZ+gowP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726898AbgDKAUg (ORCPT ); Fri, 10 Apr 2020 20:20:36 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:53893 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726897AbgDKAUZ (ORCPT ); Fri, 10 Apr 2020 20:20:25 -0400 Received: by mail-wm1-f68.google.com with SMTP id d77so4066711wmd.3; Fri, 10 Apr 2020 17:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TE3sMAOxYDEKsrqGbaQEWcZdkId7UvPKpC1cYAS9Bb4=; b=GUZ+gowPiKiUow4O9M2HabHPSHLL480L/OTu8zEtqyHcAhIJ5hl5HaWjK+P1z0MW/y kNhTwww5jaisDQoxtRveKw1lsq/8NmPm4aPVc7vCdQdQo8YaYvG1V7cT6RoeGQu4unKy gOoayXt3b1qctBo110K+40gtZzVE9ZHprMSHbm9+HnywZvpsDK/vy1cWVccGxMP7r6oO FzjyTol44+KxQGYv2cIMxl3BlfugfRF6ydXlSQLfmWfVgBhTU2wHiDic1+1Ly91BgonE KPK6WcY5wiMuPYnXWsyJ6CtSG0UjB8WXGIZsjs/V/73bN+lbsvmGJ477sN/619XPWLXN 2s8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TE3sMAOxYDEKsrqGbaQEWcZdkId7UvPKpC1cYAS9Bb4=; b=F9Ctm4YxOMjMlsGmu3/E0qviiuIbDHXCSCZTcXbLSXqJM2MO8o2MIMv3Jw2Y9llDqN dg8KtRDRUBCjCIWLKIDSSyzHz79VigvS0Jqr5onAyHeeh+CdneQV8GaX2xoqXpKvmc+W z7w/fa8kWvZRvWM2DW56nTnweBoliO0x4aB8WNMtNGQi4dMZQu5ti06M+PxxebX3YP2t mJEwcB7aGirzUEcybsS0UwPbzX6K07tgAwbATmuuIImuVuCFmO0W/I6lsuBRiawl7q91 2hI84/aN0mD0BLwfBVk5PiNo92UNtYgwCxld9SOljdAUNz5ugSr538qDbTq5jXMALNWa 8fvw== X-Gm-Message-State: AGi0PuYg/E+IZkrj4Fcx8YsgSHd4BNNUXtaBrER3Vs2i6u4OQWlU97EL DjOAbhpNLpwctxq3Ov7+SQ/mw0X+xkjA X-Google-Smtp-Source: APiQypLmI3kOoMegOugkPKgJfR0jWXdEoWwlIgoTtC1TiO5weHkh3/vOlXbmIHhWPaov2aHfK1w5Jw== X-Received: by 2002:a7b:cd8c:: with SMTP id y12mr7877443wmj.106.1586564423558; Fri, 10 Apr 2020 17:20:23 -0700 (PDT) Received: from ninjahost.lan (host-2-102-14-153.as13285.net. [2.102.14.153]) by smtp.gmail.com with ESMTPSA id b191sm5091594wmd.39.2020.04.10.17.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2020 17:20:23 -0700 (PDT) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , linux-pm@vger.kernel.org (open list:POWER MANAGEMENT CORE) Subject: [PATCH 9/9] power: wakeup: Add missing annotation for wakeup_sources_read_lock() and wakeup_sources_read_unlock() Date: Sat, 11 Apr 2020 01:19:33 +0100 Message-Id: <20200411001933.10072-10-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200411001933.10072-1-jbi.octave@gmail.com> References: <0/9> <20200411001933.10072-1-jbi.octave@gmail.com> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Sparse reports warnings at wakeup_sources_read_lock() and wakeup_sources_read_unlock() warning: context imbalance in wakeup_sources_read_lock() - wrong count at exit context imbalance in wakeup_sources_read_unlock() - unexpected unlock The root cause is the missing annotation at wakeup_sources_read_lock() and wakeup_sources_read_unlock() Add the missing __acquires(&wakeup_srcu) annotation Add the missing __releases(&wakeup_srcu) annotation Signed-off-by: Jules Irenge --- drivers/base/power/wakeup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c index 41ce086d8f57..753e9a46e04e 100644 --- a/drivers/base/power/wakeup.c +++ b/drivers/base/power/wakeup.c @@ -254,6 +254,7 @@ EXPORT_SYMBOL_GPL(wakeup_source_unregister); * This index must be passed to the matching wakeup_sources_read_unlock(). */ int wakeup_sources_read_lock(void) + __acquires(&wakeup_srcu) { return srcu_read_lock(&wakeup_srcu); } @@ -264,6 +265,7 @@ EXPORT_SYMBOL_GPL(wakeup_sources_read_lock); * @idx: return value from corresponding wakeup_sources_read_lock() */ void wakeup_sources_read_unlock(int idx) + __releases(&wakeup_srcu) { srcu_read_unlock(&wakeup_srcu, idx); }