From patchwork Mon Apr 13 15:35:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 11485795 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D453C1392 for ; Mon, 13 Apr 2020 15:36:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB72C2072C for ; Mon, 13 Apr 2020 15:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586792169; bh=Fghdcs+Xo3g6CsC/I9zekJS+Thc3LL56X6I8ePl7Iqw=; h=From:To:Cc:Subject:Date:List-ID:From; b=W6Vtj1bgzXthQz3zkKD3g2OLY9vK+s+faKjyKlwkPbVtypOczpizfySEWx4/fCSm3 PcQxXFQfe6dd9/FcQohBHu/Hk+UoOaOgkg+WfX9oF4QrXfb97faAg5TznmPR7CHy8N e43yuSaUv/HUEdJiwEq38VSV6nBqq6DfiBFa5w2M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728808AbgDMPgE (ORCPT ); Mon, 13 Apr 2020 11:36:04 -0400 Received: from conuserg-10.nifty.com ([210.131.2.77]:22932 "EHLO conuserg-10.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728194AbgDMPgE (ORCPT ); Mon, 13 Apr 2020 11:36:04 -0400 Received: from oscar.flets-west.jp (softbank060142179096.bbtec.net [60.142.179.96]) (authenticated) by conuserg-10.nifty.com with ESMTP id 03DFZl6i014699; Tue, 14 Apr 2020 00:35:47 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-10.nifty.com 03DFZl6i014699 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1586792148; bh=I/IO9cMQMpuzJ0W5BPTg8gDTRyOF5xRFRKZp//cctOg=; h=From:To:Cc:Subject:Date:From; b=JG8bOQ0Us8rszC44gpthN3SCLP8FYSYtgIhPI8n8r7mP6OV+a6gUf85MExMAgXhOh KroUXPzbw+3CDGRIiiXRDbP5+bxdGk7Prz+LSaHXBWb7RPv2ouzGDam2R70vO5AcUL Fx0W8CmZ2pwQXZqLGAbdmnjgyeEa/hFE7L2G9x0ndtYU88ZuzzopN6wBec5Ax5sq1v 278+C2DFjleS1GgSU9ZVyVVf4tUcF3YgbA+/UFnsIfsBibs4w3IUIrTc8zOSOBonGg u3VW9ydy3f5Y5kcxdiv9nUb9iosqCH8OjufdbPXQODYeGyodVohzQZk5S4EwlUQS5W rPHG0wecqzU7w== X-Nifty-SrcIP: [60.142.179.96] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH] kconfig: do not assign a variable in the return statement Date: Tue, 14 Apr 2020 00:35:42 +0900 Message-Id: <20200413153542.94064-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Sender: linux-kbuild-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org I am not a big fan of doing assignment in a return statement. Split it into two lines. Signed-off-by: Masahiro Yamada --- scripts/kconfig/menu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c index e436ba44c9c5..a5fbd6ccc006 100644 --- a/scripts/kconfig/menu.c +++ b/scripts/kconfig/menu.c @@ -65,7 +65,8 @@ void menu_add_entry(struct symbol *sym) struct menu *menu_add_menu(void) { last_entry_ptr = ¤t_entry->list; - return current_menu = current_entry; + current_menu = current_entry; + return current_menu; } void menu_end_menu(void)