From patchwork Tue Apr 14 12:07:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 11487387 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 316CB15AB for ; Tue, 14 Apr 2020 12:07:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A3762076B for ; Tue, 14 Apr 2020 12:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586866066; bh=f54QUWTL7Sm0QSJgiSrfBNqCbPeLYKWiWSTskIIizIo=; h=From:To:Cc:Subject:Date:List-ID:From; b=2djXEzueQLYJlQ/irsPmul+epAbmyeMU9C/6neA7Y/yZB9lqux83gQge+q+zDWWcs qOXPeY0HyVBMofGJkkMWjBj8Vx9hl6S3otLoN+RaodO1h47qwimP4C1umtsCVPNfet 6v7X3SszLXcMGxyUQi3kNM3NYhsgicDptgG5atmM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439855AbgDNMHp (ORCPT ); Tue, 14 Apr 2020 08:07:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:35898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439808AbgDNMHm (ORCPT ); Tue, 14 Apr 2020 08:07:42 -0400 Received: from tleilax.com (68-20-15-154.lightspeed.rlghnc.sbcglobal.net [68.20.15.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19C892075E; Tue, 14 Apr 2020 12:07:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586866061; bh=f54QUWTL7Sm0QSJgiSrfBNqCbPeLYKWiWSTskIIizIo=; h=From:To:Cc:Subject:Date:From; b=tAZ74R0gWLkKKbRvuWYP64FARLO/cH/OS5Cc+UZ8TKqULm4QS9DtQtQZERVk1jpoL lc/oSJmOVPhmF35hODCR0uwt9WRP5aK0/1OSi5no2L1cm9DliXveAK8KFiVRcd2/2D iqtizVgyCBB1fQPNSQaw52LG4B5628soYLHFpBOY= From: Jeff Layton To: guaneryu@gmail.com Cc: fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [RFC PATCH xfstests] generic: test reporting of wb errors via syncfs Date: Tue, 14 Apr 2020 08:07:40 -0400 Message-Id: <20200414120740.293998-1-jlayton@kernel.org> X-Mailer: git-send-email 2.25.2 MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org From: Jeff Layton Add a test for new syncfs error reporting behavior. When an inode fails to be written back, ensure that a subsequent call to syncfs() will also report an error. Signed-off-by: Jeff Layton --- tests/generic/999 | 98 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/999.out | 8 ++++ tests/generic/group | 1 + 3 files changed, 107 insertions(+) create mode 100755 tests/generic/999 create mode 100644 tests/generic/999.out diff --git a/tests/generic/999 b/tests/generic/999 new file mode 100755 index 000000000000..7383ce24c8fd --- /dev/null +++ b/tests/generic/999 @@ -0,0 +1,98 @@ +#! /bin/bash +# FS QA Test No. 999 +# +# Open a file and write to it and fsync. Then, flip the data device to throw +# errors, write to it again and do an fdatasync. Then open an O_RDONLY fd on +# the same file and call syncfs against it and ensure that an error is reported. +# Then call syncfs again and ensure that no error is reported. Finally, repeat +# the open and syncfs and ensure that there is no error reported. +# +#----------------------------------------------------------------------- +# Copyright (c) 2020, Jeff Layton +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* + _dmerror_cleanup +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/dmerror + +# real QA test starts here +_supported_os Linux +_require_scratch_nocheck +# This test uses "dm" without taking into account the data could be on +# realtime subvolume, thus the test will fail with rtinherit=1 +_require_no_rtinherit +_require_dm_target error + +rm -f $seqres.full + +echo "Format and mount" +_scratch_mkfs > $seqres.full 2>&1 +_dmerror_init +_dmerror_mount + +datalen=65536 +_require_fs_space $SCRATCH_MNT $datalen + +# use fd 5 to hold file open +testfile=$SCRATCH_MNT/syncfs-reports-errors +exec 5>$testfile + +# write some data to file and fsync it out +$XFS_IO_PROG -c "pwrite -W -q 0 $datalen" $testfile + +# flip device to non-working mode +_dmerror_load_error_table + +# rewrite the data, and do fdatasync +$XFS_IO_PROG -c "pwrite -w -q 0 $datalen" $testfile + +# heal the device error +_dmerror_load_working_table + +# open again and call syncfs twice +echo "One of the following syncfs calls should fail with EIO:" +$XFS_IO_PROG -r -c syncfs -c syncfs $testfile +echo "done" + +echo "This syncfs call should succeed:" +$XFS_IO_PROG -r -c syncfs $testfile +echo "done" + +# close file +exec 5>&- + +# success, all done +_dmerror_cleanup + +status=0 +exit diff --git a/tests/generic/999.out b/tests/generic/999.out new file mode 100644 index 000000000000..950a2ba42503 --- /dev/null +++ b/tests/generic/999.out @@ -0,0 +1,8 @@ +QA output created by 999 +Format and mount +fdatasync: Input/output error +One of the following syncfs calls should fail with EIO: +syncfs: Input/output error +done +This syncfs call should succeed: +done diff --git a/tests/generic/group b/tests/generic/group index 99d06c9ad945..028cdbd0d52b 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -598,3 +598,4 @@ 594 auto quick quota 595 auto quick encrypt 596 auto quick +999 auto quick