From patchwork Fri Oct 5 08:10:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun KS X-Patchwork-Id: 10627521 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D55E015E2 for ; Fri, 5 Oct 2018 08:10:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA38B29252 for ; Fri, 5 Oct 2018 08:10:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BDB7029257; Fri, 5 Oct 2018 08:10:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F3AF929252 for ; Fri, 5 Oct 2018 08:10:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 392826B000A; Fri, 5 Oct 2018 04:10:25 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 344BD6B000C; Fri, 5 Oct 2018 04:10:25 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BEB96B000E; Fri, 5 Oct 2018 04:10:25 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by kanga.kvack.org (Postfix) with ESMTP id CE8CA6B000A for ; Fri, 5 Oct 2018 04:10:24 -0400 (EDT) Received: by mail-pf1-f199.google.com with SMTP id n81-v6so2366086pfi.20 for ; Fri, 05 Oct 2018 01:10:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id; bh=cmgL6wN5XUmkrBJ5RggUoJ527CRR0zdb2y3EANMTkWY=; b=GjhBLJF3Aibcmd2gRCGW1ix3Jt83RHE3Ycn7/h1Euvw7/gKGHGjQJTB7LBCMXhfn2D +rAEknx/sZSZMROlBLtxoEr/hT2yeGGCSrjhewJAYdLh0f8fgmtOYOsLMwxw6xi78GG4 qsfWoVz1+/XEvLFqAOhrvvBRrMxOOSJJPIPSBeoANYuOzkr5JTfAoGDa1GTJUtrZilP5 urh8bv13JdCk0Ors+yZlcUf8GDnEyaM6jjxzjsrsijNjERmz/rZUtNAWSZqUc7uwN2pd qdtGkmR49VbyppZbAxvlQqxm5RqbjPusxNJyNTXUAMcKhrjhXlr40KkigT9GjqdvM/+1 7GLA== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-Gm-Message-State: ABuFfogVjQYh9cUINJ8Wc8x2hIkilE1MyyyXfAAPnbYAiIYshRRU2Hqq nz7+77nroNQCU9hruSaze87pdMqGxi7X3WPPY1AwxsxZ1avXsu3x72YF6NUbnYRRT9idelqZUXH EQGtOVqP1ZqFyMmcbK+pqZDkRxHyBuuUJHK0TGGHAVUVL2vTi9YkV4EtKalhExiE= X-Received: by 2002:a65:448a:: with SMTP id l10-v6mr9293208pgq.382.1538727024441; Fri, 05 Oct 2018 01:10:24 -0700 (PDT) X-Google-Smtp-Source: ACcGV63r8IBdiVn7x12xVnnfbQBJM4HZC51FhVAqf24MMcokASzXdRxaCVmnrRSP6lcdaShrxFzs X-Received: by 2002:a65:448a:: with SMTP id l10-v6mr9293130pgq.382.1538727023191; Fri, 05 Oct 2018 01:10:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538727023; cv=none; d=google.com; s=arc-20160816; b=Qg6piqIWuK2+ApIx8yUEjzb65lkJhC2WBQPUmRPexuk4kVczXCi76gdmd0IDPTQZOc T8AD8vOQRdPk8i0gkDILgeSDsp8HvlVtWcSz7O/zFYTN6DH/u3RbxTCN0zrRfpPqRu0j OLcT9F0+UZQmHT+q71wXSBazM+TtO3O7i3KN7gmCp5scwMCqtWoAKMtNIeuUXQlN4Q80 A0wOsGrCpc7xAkMHSwcZD7bEFU+5VYCtBzMcJEK6ZO5bYdp6SMiq+pPzo367e7o8gfay fA2NdFSjM2tp69DdWfr3p+uYULBpjkjebb49996wUhrrii71OqKMo47Dh3gTtiRpv580 G05A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from; bh=cmgL6wN5XUmkrBJ5RggUoJ527CRR0zdb2y3EANMTkWY=; b=jhpZoJpExF6qlNCgaZLVjsu295ZUt0rfrqahhI0V2Vtu2Gc2YnXRqKIqW57QkhnwWW Duh6dOVJjhDo8Oe41D7Qxfd/U3KM/op6Y0azV2uGzdVOZhi7AOTk0M37kpFW5iHniTDB WH85JsGQETESsJ7pq1aYQ9MJEboj62x3S6XSqXxIQb2Wi5qtmzCd++UcR1U4YD3OEKzG hAMn/f5pouCwVpmryqJ8g1aopmbjrrJhlJnuNO6vuQ2S1kdFIVMzicvtkdVOuFgnGAPO FQVoJ5GyhXrc0ixkpMd2vfRdSKWfTz7NZXhi3+36uHIlFTLiN5575OhNRIbgx2HXHfhq T/mg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com Received: from alexa-out-blr-01.qualcomm.com (alexa-out-blr-01.qualcomm.com. [103.229.18.197]) by mx.google.com with ESMTPS id a15-v6si7806628plm.216.2018.10.05.01.10.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Oct 2018 01:10:23 -0700 (PDT) Received-SPF: pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) client-ip=103.229.18.197; Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-IronPort-AV: E=Sophos;i="5.54,343,1534789800"; d="scan'208";a="236076" Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by alexa-out-blr-01.qualcomm.com with ESMTP/TLS/AES256-SHA; 05 Oct 2018 13:40:19 +0530 X-IronPort-AV: E=McAfee;i="5900,7806,9036"; a="1466213" Received: from blr-ubuntu-104.ap.qualcomm.com (HELO blr-ubuntu-104.qualcomm.com) ([10.79.40.64]) by ironmsg02-blr.qualcomm.com with ESMTP; 05 Oct 2018 13:40:19 +0530 Received: by blr-ubuntu-104.qualcomm.com (Postfix, from userid 346745) id B73902391; Fri, 5 Oct 2018 13:40:17 +0530 (IST) From: Arun KS To: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, boris.ostrovsky@oracle.com, jgross@suse.com, akpm@linux-foundation.org, dan.j.williams@intel.com, mhocko@suse.com, vbabka@suse.cz, iamjoonsoo.kim@lge.com, gregkh@linuxfoundation.org, osalvador@suse.de, malat@debian.org, kirill.shutemov@linux.intel.com, jrdr.linux@gmail.com, yasu.isimatu@gmail.com, mgorman@techsingularity.net, aaron.lu@intel.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org Cc: vatsa@codeaurora.org, vinmenon@codeaurora.org, getarunks@gmail.com, Arun KS Subject: [PATCH v5 1/2] memory_hotplug: Free pages as higher order Date: Fri, 5 Oct 2018 13:40:05 +0530 Message-Id: <1538727006-5727-1-git-send-email-arunks@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP When free pages are done with higher order, time spend on coalescing pages by buddy allocator can be reduced. With section size of 256MB, hot add latency of a single section shows improvement from 50-60 ms to less than 1 ms, hence improving the hot add latency by 60%. Modify external providers of online callback to align with the change. Signed-off-by: Arun KS Reviewed-by: Oscar Salvador Acked-by: Michal Hocko --- Changes since v4: - As suggested by Michal Hocko, - Simplify logic in online_pages_block() by using get_order(). - Seperate out removal of prefetch from __free_pages_core(). Changes since v3: - Renamed _free_pages_boot_core -> __free_pages_core. - Removed prefetch from __free_pages_core. - Removed xen_online_page(). Changes since v2: - Reuse code from __free_pages_boot_core(). Changes since v1: - Removed prefetch(). Changes since RFC: - Rebase. - As suggested by Michal Hocko remove pages_per_block. - Modifed external providers of online_page_callback. v4: https://lore.kernel.org/patchwork/patch/995111/ v3: https://lore.kernel.org/patchwork/patch/992348/ v2: https://lore.kernel.org/patchwork/patch/991363/ v1: https://lore.kernel.org/patchwork/patch/989445/ RFC: https://lore.kernel.org/patchwork/patch/984754/ --- drivers/hv/hv_balloon.c | 6 ++++-- drivers/xen/balloon.c | 23 +++++++++++++++-------- include/linux/memory_hotplug.h | 2 +- mm/internal.h | 1 + mm/memory_hotplug.c | 42 ++++++++++++++++++++++++++++++------------ mm/page_alloc.c | 8 ++++---- 6 files changed, 55 insertions(+), 27 deletions(-) diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c index b1b7880..c5bc0b5 100644 --- a/drivers/hv/hv_balloon.c +++ b/drivers/hv/hv_balloon.c @@ -771,7 +771,7 @@ static void hv_mem_hot_add(unsigned long start, unsigned long size, } } -static void hv_online_page(struct page *pg) +static int hv_online_page(struct page *pg, unsigned int order) { struct hv_hotadd_state *has; unsigned long flags; @@ -783,10 +783,12 @@ static void hv_online_page(struct page *pg) if ((pfn < has->start_pfn) || (pfn >= has->end_pfn)) continue; - hv_page_online_one(has, pg); + hv_bring_pgs_online(has, pfn, (1UL << order)); break; } spin_unlock_irqrestore(&dm_device.ha_lock, flags); + + return 0; } static int pfn_covered(unsigned long start_pfn, unsigned long pfn_cnt) diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c index e12bb25..58ddf48 100644 --- a/drivers/xen/balloon.c +++ b/drivers/xen/balloon.c @@ -390,8 +390,8 @@ static enum bp_state reserve_additional_memory(void) /* * add_memory_resource() will call online_pages() which in its turn - * will call xen_online_page() callback causing deadlock if we don't - * release balloon_mutex here. Unlocking here is safe because the + * will call xen_bring_pgs_online() callback causing deadlock if we + * don't release balloon_mutex here. Unlocking here is safe because the * callers drop the mutex before trying again. */ mutex_unlock(&balloon_mutex); @@ -411,15 +411,22 @@ static enum bp_state reserve_additional_memory(void) return BP_ECANCELED; } -static void xen_online_page(struct page *page) +static int xen_bring_pgs_online(struct page *pg, unsigned int order) { - __online_page_set_limits(page); + unsigned long i, size = (1 << order); + unsigned long start_pfn = page_to_pfn(pg); + struct page *p; + pr_debug("Online %lu pages starting at pfn 0x%lx\n", size, start_pfn); mutex_lock(&balloon_mutex); - - __balloon_append(page); - + for (i = 0; i < size; i++) { + p = pfn_to_page(start_pfn + i); + __online_page_set_limits(p); + __balloon_append(p); + } mutex_unlock(&balloon_mutex); + + return 0; } static int xen_memory_notifier(struct notifier_block *nb, unsigned long val, void *v) @@ -744,7 +751,7 @@ static int __init balloon_init(void) balloon_stats.max_retry_count = RETRY_UNLIMITED; #ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG - set_online_page_callback(&xen_online_page); + set_online_page_callback(&xen_bring_pgs_online); register_memory_notifier(&xen_memory_nb); register_sysctl_table(xen_root); diff --git a/include/linux/memory_hotplug.h b/include/linux/memory_hotplug.h index 34a2822..7b04c1d 100644 --- a/include/linux/memory_hotplug.h +++ b/include/linux/memory_hotplug.h @@ -87,7 +87,7 @@ extern int test_pages_in_a_zone(unsigned long start_pfn, unsigned long end_pfn, unsigned long *valid_start, unsigned long *valid_end); extern void __offline_isolated_pages(unsigned long, unsigned long); -typedef void (*online_page_callback_t)(struct page *page); +typedef int (*online_page_callback_t)(struct page *page, unsigned int order); extern int set_online_page_callback(online_page_callback_t callback); extern int restore_online_page_callback(online_page_callback_t callback); diff --git a/mm/internal.h b/mm/internal.h index 87256ae..636679c 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -163,6 +163,7 @@ static inline struct page *pageblock_pfn_to_page(unsigned long start_pfn, extern int __isolate_free_page(struct page *page, unsigned int order); extern void __free_pages_bootmem(struct page *page, unsigned long pfn, unsigned int order); +extern void __free_pages_core(struct page *page, unsigned int order); extern void prep_compound_page(struct page *page, unsigned int order); extern void post_alloc_hook(struct page *page, unsigned int order, gfp_t gfp_flags); diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 38d94b7..e379e85 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -47,7 +47,7 @@ * and restore_online_page_callback() for generic callback restore. */ -static void generic_online_page(struct page *page); +static int generic_online_page(struct page *page, unsigned int order); static online_page_callback_t online_page_callback = generic_online_page; static DEFINE_MUTEX(online_page_callback_lock); @@ -655,26 +655,44 @@ void __online_page_free(struct page *page) } EXPORT_SYMBOL_GPL(__online_page_free); -static void generic_online_page(struct page *page) +static int generic_online_page(struct page *page, unsigned int order) { - __online_page_set_limits(page); - __online_page_increment_counters(page); - __online_page_free(page); + __free_pages_core(page, order); + totalram_pages += (1UL << order); +#ifdef CONFIG_HIGHMEM + if (PageHighMem(page)) + totalhigh_pages += (1UL << order); +#endif + return 0; +} + +static int online_pages_blocks(unsigned long start, unsigned long nr_pages) +{ + unsigned long end = start + nr_pages; + int order, ret, onlined_pages = 0; + + while (start < end) { + order = min(MAX_ORDER - 1, + get_order(PFN_PHYS(end) - PFN_PHYS(start))); + + ret = (*online_page_callback)(pfn_to_page(start), order); + if (!ret) + onlined_pages += (1UL << order); + else if (ret > 0) + onlined_pages += ret; + + start += (1UL << order); + } + return onlined_pages; } static int online_pages_range(unsigned long start_pfn, unsigned long nr_pages, void *arg) { - unsigned long i; unsigned long onlined_pages = *(unsigned long *)arg; - struct page *page; if (PageReserved(pfn_to_page(start_pfn))) - for (i = 0; i < nr_pages; i++) { - page = pfn_to_page(start_pfn + i); - (*online_page_callback)(page); - onlined_pages++; - } + onlined_pages = online_pages_blocks(start_pfn, nr_pages); online_mem_sections(start_pfn, start_pfn + nr_pages); diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 89d2a2a..7ab5274 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1252,7 +1252,7 @@ static void __free_pages_ok(struct page *page, unsigned int order) local_irq_restore(flags); } -static void __init __free_pages_boot_core(struct page *page, unsigned int order) +void __free_pages_core(struct page *page, unsigned int order) { unsigned int nr_pages = 1 << order; struct page *p = page; @@ -1331,7 +1331,7 @@ void __init __free_pages_bootmem(struct page *page, unsigned long pfn, { if (early_page_uninitialised(pfn)) return; - return __free_pages_boot_core(page, order); + return __free_pages_core(page, order); } /* @@ -1421,14 +1421,14 @@ static void __init deferred_free_range(unsigned long pfn, if (nr_pages == pageblock_nr_pages && (pfn & (pageblock_nr_pages - 1)) == 0) { set_pageblock_migratetype(page, MIGRATE_MOVABLE); - __free_pages_boot_core(page, pageblock_order); + __free_pages_core(page, pageblock_order); return; } for (i = 0; i < nr_pages; i++, page++, pfn++) { if ((pfn & (pageblock_nr_pages - 1)) == 0) set_pageblock_migratetype(page, MIGRATE_MOVABLE); - __free_pages_boot_core(page, 0); + __free_pages_core(page, 0); } } From patchwork Fri Oct 5 08:10:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun KS X-Patchwork-Id: 10627523 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 49AAB174A for ; Fri, 5 Oct 2018 08:10:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 407C829252 for ; Fri, 5 Oct 2018 08:10:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3445729257; Fri, 5 Oct 2018 08:10:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C711529252 for ; Fri, 5 Oct 2018 08:10:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62C176B000C; Fri, 5 Oct 2018 04:10:25 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 543C56B0010; Fri, 5 Oct 2018 04:10:25 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25BB56B000D; Fri, 5 Oct 2018 04:10:25 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by kanga.kvack.org (Postfix) with ESMTP id D846F6B000C for ; Fri, 5 Oct 2018 04:10:24 -0400 (EDT) Received: by mail-pl1-f198.google.com with SMTP id f59-v6so7295935plb.5 for ; Fri, 05 Oct 2018 01:10:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:in-reply-to:references; bh=qHXP3NcYstB6MFsCsD+xzW1ExB+LfhN6o50KTDhaKlA=; b=SWlV4V6ZnS4QaTZt7hKgZ45+W41Tt7D44+f6gdQXVw792HTG2RFp7pYMMZNenzxBDd dkbBsMTshe3oVI2M3D/3nTirl5yvGjqASKOL3rBjIQa6AGAIighWQx8t8AOQoSdDklA7 eW6jy+LcToHTPWrvfrUSW0N0Oa5I4qSs1wxrMaUsweQ7GjxdqSznojQ9du09g08IpM02 8Grsn7HVkOm68kkn0ibBP8EoMKfeK8BLTkK+QIAoWCw3bVUxKBwn2/yP+XK5zmDuam2g +3k4NtQgB0D7LT9Tg8qV/5kcGGRlJ9bnX7v0LHpzmmk/FtwVwQm3jhMppa+c6ihygM52 fbVg== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-Gm-Message-State: ABuFfogJrrSx25sW52GXBmCb5qMUpCT3GDAF2um2cPt+0aPoQEJ+O617 ZkNk28C8d9J4cWF7BtFIm2qCr+hdHWyI1SzCABGty6owvB2h5yFb+eA7NP1LjvqYZk7cmzad3NZ C6yTOvc9xgUoatk+WbkzKBrp1haDnmKS4Vcjv6a6UZfgkCfMI626iYXMA2hgUgWU= X-Received: by 2002:a17:902:2:: with SMTP id 2-v6mr10612654pla.178.1538727024577; Fri, 05 Oct 2018 01:10:24 -0700 (PDT) X-Google-Smtp-Source: ACcGV629DBXwMUu4gq0smUpkRH1W5ZXJFtudbWylf+KAecoDLm49vGgCFZkjWxasckwrnvEyiIHZ X-Received: by 2002:a17:902:2:: with SMTP id 2-v6mr10612595pla.178.1538727023962; Fri, 05 Oct 2018 01:10:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538727023; cv=none; d=google.com; s=arc-20160816; b=aDipnkMFrNLdORKyH9giCQPg/g5PUrIKLG3UOp6MFuqptTIAi539x7+2npod1XuCqA F7T7KiwI3uvEwP60UnIeEY1OvpsJmnLrrFpaZ3MUaSTqrNrDaX9e6IWha2rwfM0+F96j kf8EwlITH/cerZNAE4p/joQy0dI1Cv5Qn+rWEFfipz9PoxsFNhaNgWSrhvvrVZb1qFxl x0h6AgKzioiHVi7IWq+TQ3erO5aoBSG1asnyDI7cTHHatNJ4bqGnXuD3vUXjO11xUzAp OdpjWVeFatR0PJhy9pWf2MFcOl3IzkN5ZgUiqyUZEUuu+QkfISXF+1cunUGl8Xdq8FNN Medw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from; bh=qHXP3NcYstB6MFsCsD+xzW1ExB+LfhN6o50KTDhaKlA=; b=QD+hYZQQiUFGsF+QpPMQyXdwnqGalYELGPVEKdE4nKrLhh04kPP9IKFpC9EdVFZ3PF SL2MnbwstCrhsd1mPzTYa+VC2/Uk87xUVnnUjbXEw+FbqDddsD+K0DAP7UhEceQ5u2Mm agxg2ml7RaDyiuwS9p6PP63hz/kmlihse1AZbfAzmoMusO+YP1Km2io17yfzHq4VbmzF F6leW+ESrAtrV7QKwX11b/pNdleWr1w7eOvPZeUeifIk4AESwpzcfkNcfkHomk+1dPM4 r9LTKj/TcT7TZ/vI44SgSa8QRy1cu8tdw1f2Sz0+LJG0ByAlYa3KnTQ/IdgWyekTCfrR 6DXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com Received: from alexa-out-blr-01.qualcomm.com (alexa-out-blr-01.qualcomm.com. [103.229.18.197]) by mx.google.com with ESMTPS id n24-v6si7546760pff.136.2018.10.05.01.10.23 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Oct 2018 01:10:23 -0700 (PDT) Received-SPF: pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) client-ip=103.229.18.197; Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-IronPort-AV: E=Sophos;i="5.54,343,1534789800"; d="scan'208";a="236081" Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by alexa-out-blr-01.qualcomm.com with ESMTP/TLS/AES256-SHA; 05 Oct 2018 13:40:22 +0530 X-IronPort-AV: E=McAfee;i="5900,7806,9036"; a="1466215" Received: from blr-ubuntu-104.ap.qualcomm.com (HELO blr-ubuntu-104.qualcomm.com) ([10.79.40.64]) by ironmsg02-blr.qualcomm.com with ESMTP; 05 Oct 2018 13:40:22 +0530 Received: by blr-ubuntu-104.qualcomm.com (Postfix, from userid 346745) id 05F742391; Fri, 5 Oct 2018 13:40:20 +0530 (IST) From: Arun KS To: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, boris.ostrovsky@oracle.com, jgross@suse.com, akpm@linux-foundation.org, dan.j.williams@intel.com, mhocko@suse.com, vbabka@suse.cz, iamjoonsoo.kim@lge.com, gregkh@linuxfoundation.org, osalvador@suse.de, malat@debian.org, kirill.shutemov@linux.intel.com, jrdr.linux@gmail.com, yasu.isimatu@gmail.com, mgorman@techsingularity.net, aaron.lu@intel.com, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, xen-devel@lists.xenproject.org Cc: vatsa@codeaurora.org, vinmenon@codeaurora.org, getarunks@gmail.com, Arun KS Subject: [PATCH v5 2/2] mm/page_alloc: remove software prefetching in __free_pages_core Date: Fri, 5 Oct 2018 13:40:06 +0530 Message-Id: <1538727006-5727-2-git-send-email-arunks@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1538727006-5727-1-git-send-email-arunks@codeaurora.org> References: <1538727006-5727-1-git-send-email-arunks@codeaurora.org> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP They not only increase the code footprint, they actually make things slower rather than faster. Remove them as contemporary hardware doesn't need any hint. Suggested-by: Dan Williams Signed-off-by: Arun KS Acked-by: Vlastimil Babka --- mm/page_alloc.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 7ab5274..90db431 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1258,14 +1258,10 @@ void __free_pages_core(struct page *page, unsigned int order) struct page *p = page; unsigned int loop; - prefetchw(p); - for (loop = 0; loop < (nr_pages - 1); loop++, p++) { - prefetchw(p + 1); + for (loop = 0; loop < nr_pages ; loop++, p++) { __ClearPageReserved(p); set_page_count(p, 0); } - __ClearPageReserved(p); - set_page_count(p, 0); page_zone(page)->managed_pages += nr_pages; set_page_refcounted(page);