From patchwork Fri Oct 5 19:27:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 10628685 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8729D1731 for ; Fri, 5 Oct 2018 19:27:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7782A29BDB for ; Fri, 5 Oct 2018 19:27:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6B44229C1A; Fri, 5 Oct 2018 19:27:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E044E29C16 for ; Fri, 5 Oct 2018 19:27:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7ED76B000D; Fri, 5 Oct 2018 15:27:42 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id D2F996B000E; Fri, 5 Oct 2018 15:27:42 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1DF46B0010; Fri, 5 Oct 2018 15:27:42 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by kanga.kvack.org (Postfix) with ESMTP id 7DE6A6B000D for ; Fri, 5 Oct 2018 15:27:42 -0400 (EDT) Received: by mail-pg1-f198.google.com with SMTP id t3-v6so7819558pgp.0 for ; Fri, 05 Oct 2018 12:27:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id:mime-version:content-transfer-encoding; bh=O8MUoMdyZp7VnFk86cz/bxEv7KcxO90a6K0fUhGYRKA=; b=U0HhWExXkmrNP5kNpF+VtLWOTaK8DYz+lC2BKDviGY0V1/KvmRDIV2p9C8heY/xEqa NtdSsjgp/qcoAWaL2EvSArT93MOVO0TzdL51XVUsHI8aun7qKdYx1u4APgEeu2ElO/qD KnqQ+SQGYMg5Ci2iAr1rbAEk8raycoW51cXJe+JtzVlmTdTyX9B+NlCxsepjp5Mc9cRI znfVUPFTGf7NShdfuaKP3w0DrrhAgOkSMjlFZqmxljQHeOOaxbsRMyQ3UWIZzNCfMuku 3Hybv30IiQ21ek3k2KWK4O5dGammH275zh54yOJp/igrphCsDKrcOFIe+vjfZy9+Lw19 tLDg== X-Gm-Message-State: ABuFfojhUZrHNdKynKL0aTYRZ/V1N5pjWR9+Lcu1UoWZhlzbG1MUMYcI ofligByC0AViRIhRnBMfyyj0+3gxmYMfcdpLWKPNJRwfXpRFvJTHNeeP+H18MEZqD01ThR9Wu0V rbRqfiIzuD3s22V0S0S4PH5vsJ14IB1JAG8ShjFTBkluSCVijsCzBd4J2qjocljMkDu2v0QEk17 7HFiIp+/evw2w7+Wkucys15nFydcOCj7zHYpwc+DZB+3a1Fw7H00dslNYdTc9zC1jGiJM+gTAEO 7ZUNCVm9uKhPHltTYmrl8FjQL0KatoNxKhY4gn3zyzcapLoqKtLsZWj66/OPhaVeuh53rORw0cY 8pO2MIpbOyTIeaBC/yjxtqSgnpZkX43/qJAZKIdnBZwP3zdNKuf9hiXDgP1P6guRoEf7aGe6c8J O X-Received: by 2002:a62:120b:: with SMTP id a11-v6mr11000264pfj.165.1538767662176; Fri, 05 Oct 2018 12:27:42 -0700 (PDT) X-Received: by 2002:a62:120b:: with SMTP id a11-v6mr11000214pfj.165.1538767661227; Fri, 05 Oct 2018 12:27:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538767661; cv=none; d=google.com; s=arc-20160816; b=cRhexEVCM4xa+jEyt1Eg3oV9mzcVJtrtGIx15kMipg02SozYeDeqiajRq9CV5Xec3v ZM/4hNmrCRW8EIImVIHMqEfSLXvHxkHz0Bkwgwmv9LFAhPHyHxo6CgSdvLCGFIEDe7KH s+xCULVLGKCohFBro0DVKUOkienlPstMNBbVUYGF5/rTyUYurZtGF23LU53/hBvLJloM yHahlVkhbgnIYRU4ehBr3e0KGMefsTta+cIrpxP3znaiqi0YP70Wru7Gsvdxm2+Fmbs1 hqRNLrB5J/IqLdNSEwULHeJUj4WqyWsTLuFyHQ56FR2UQj/aU3Asf0ZL/iS4EOhC4CJN aDpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=O8MUoMdyZp7VnFk86cz/bxEv7KcxO90a6K0fUhGYRKA=; b=svsbv2WZCQkk+OXuPRWFWQz2+wQ+qdZ4TxfTx9ndM4JKsc1s7g2PyH9rR+HRtseHvG 5PFIefK0Appj38jCDE/fv7G1etbUa+veZkoXSGD0VXnbOZE+8X1tBk/tPnl0Ho4Ul+uc OddhnscQR6HENxZ/PpOPQkCu6pGg59imtlj9M6pEvl1EjJO3HZ1SrEEhy1jmrdNXRMtP UyGm/HcEMfLR8snPGNgBs8k4ozBPfPxSys79tbzrGcdvaMzMWojqBvmeIfG3CvI4iXeh EwMaTeFKW9eedPjQ9r0GO9cJfUGw/TAysKuujupP21rFbs+cbDT7G8u36sEQteFB/9M6 IdYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=TyGED5py; spf=pass (google.com: domain of joel@joelfernandes.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=joel@joelfernandes.org Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id p76-v6sor3609458pfd.48.2018.10.05.12.27.40 for (Google Transport Security); Fri, 05 Oct 2018 12:27:41 -0700 (PDT) Received-SPF: pass (google.com: domain of joel@joelfernandes.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@joelfernandes.org header.s=google header.b=TyGED5py; spf=pass (google.com: domain of joel@joelfernandes.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=joel@joelfernandes.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=O8MUoMdyZp7VnFk86cz/bxEv7KcxO90a6K0fUhGYRKA=; b=TyGED5pyaQZWWBdVUycfsGP3LhusgFUJp+EHbH6ZUBs8OYQhY+LDyCi36QgONUT/OE epxlgl1k5wW3Sqr4sf1RhIbzjF21B3QsuLSet6ognNUqOWjcKtrN2+YwY0U6H915YVLc OLMH6fniWBFsmSzTcdCGtblCqe+LqgcccbJ00= X-Google-Smtp-Source: ACcGV637nbvtU1/IOfHQBe0ZOxC4LT6wSr5iQYENxkPw88+Kap9FfbHNNYbfx2Q/1MyJP5ytiF079A== X-Received: by 2002:a62:968a:: with SMTP id s10-v6mr13202004pfk.191.1538767660352; Fri, 05 Oct 2018 12:27:40 -0700 (PDT) Received: from joelaf.mtv.corp.google.com ([2620:0:1000:1601:3aef:314f:b9ea:889f]) by smtp.gmail.com with ESMTPSA id z15-v6sm11469300pfn.170.2018.10.05.12.27.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Oct 2018 12:27:38 -0700 (PDT) From: "Joel Fernandes (Google)" To: linux-kernel@vger.kernel.org Cc: kernel-team@android.com, "Joel Fernandes (Google)" , jreck@google.com, john.stultz@linaro.org, tkjos@google.com, gregkh@linuxfoundation.org, Al Viro , Andrew Morton , "J. Bruce Fields" , Jeff Layton , Khalid Aziz , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz Subject: [PATCH RFC] mm: Add an fs-write seal to memfd Date: Fri, 5 Oct 2018 12:27:27 -0700 Message-Id: <20181005192727.167933-1-joel@joelfernandes.org> X-Mailer: git-send-email 2.19.0.605.g01d371f741-goog MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Android uses ashmem for sharing memory regions. We are looking forward to migrating all usecases of ashmem to memfd so that we can possibly remove the ashmem driver in the future from staging while also benefiting from using memfd and contributing to it. Note staging drivers are also not ABI and generally can be removed at anytime. One of the main usecases Android has is the ability to create a region and mmap it as writeable, then drop its protection for "future" writes while keeping the existing already mmap'ed writeable-region active. This allows us to implement a usecase where receivers of the shared memory buffer can get a read-only view, while the sender continues to write to the buffer. See CursorWindow in Android for more details: https://developer.android.com/reference/android/database/CursorWindow This usecase cannot be implemented with the existing F_SEAL_WRITE seal. To support the usecase, this patch adds a new F_SEAL_FS_WRITE seal which prevents any future mmap and write syscalls from succeeding while keeping the existing mmap active. The following program shows the seal working in action: int main() { int ret, fd; void *addr, *addr2, *addr3, *addr1; ret = memfd_create_region("test_region", REGION_SIZE); printf("ret=%d\n", ret); fd = ret; // Create map addr = mmap(0, REGION_SIZE, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0); if (addr == MAP_FAILED) printf("map 0 failed\n"); else printf("map 0 passed\n"); if ((ret = write(fd, "test", 4)) != 4) printf("write failed even though no fs-write seal " "(ret=%d errno =%d)\n", ret, errno); else printf("write passed\n"); addr1 = mmap(0, REGION_SIZE, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0); if (addr1 == MAP_FAILED) perror("map 1 prot-write failed even though no seal\n"); else printf("map 1 prot-write passed as expected\n"); ret = fcntl(fd, F_ADD_SEALS, F_SEAL_FS_WRITE); if (ret == -1) printf("fcntl failed, errno: %d\n", errno); else printf("fs-write seal now active\n"); if ((ret = write(fd, "test", 4)) != 4) printf("write failed as expected due to fs-write seal\n"); else printf("write passed (unexpected)\n"); addr2 = mmap(0, REGION_SIZE, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0); if (addr2 == MAP_FAILED) perror("map 2 prot-write failed as expected due to seal\n"); else printf("map 2 passed\n"); addr3 = mmap(0, REGION_SIZE, PROT_READ, MAP_SHARED, fd, 0); if (addr3 == MAP_FAILED) perror("map 3 failed\n"); else printf("map 3 prot-read passed as expected\n"); } The output of running this program is as follows: ret=3 map 0 passed write passed map 1 prot-write passed as expected fs-write seal now active write failed as expected due to fs-write seal map 2 prot-write failed as expected due to seal : Permission denied map 3 prot-read passed as expected Cc: jreck@google.com Cc: john.stultz@linaro.org Cc: tkjos@google.com Cc: gregkh@linuxfoundation.org Signed-off-by: Joel Fernandes (Google) --- include/uapi/linux/fcntl.h | 1 + mm/memfd.c | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/include/uapi/linux/fcntl.h b/include/uapi/linux/fcntl.h index 6448cdd9a350..bafd1233b6a8 100644 --- a/include/uapi/linux/fcntl.h +++ b/include/uapi/linux/fcntl.h @@ -41,6 +41,7 @@ #define F_SEAL_SHRINK 0x0002 /* prevent file from shrinking */ #define F_SEAL_GROW 0x0004 /* prevent file from growing */ #define F_SEAL_WRITE 0x0008 /* prevent writes */ +#define F_SEAL_FS_WRITE 0x0010 /* prevent all write-related syscalls */ /* (1U << 31) is reserved for signed error codes */ /* diff --git a/mm/memfd.c b/mm/memfd.c index 2bb5e257080e..4b09f446c2d2 100644 --- a/mm/memfd.c +++ b/mm/memfd.c @@ -150,7 +150,8 @@ static unsigned int *memfd_file_seals_ptr(struct file *file) #define F_ALL_SEALS (F_SEAL_SEAL | \ F_SEAL_SHRINK | \ F_SEAL_GROW | \ - F_SEAL_WRITE) + F_SEAL_WRITE | \ + F_SEAL_FS_WRITE) static int memfd_add_seals(struct file *file, unsigned int seals) { @@ -219,6 +220,9 @@ static int memfd_add_seals(struct file *file, unsigned int seals) } } + if ((seals & F_SEAL_FS_WRITE) && !(*file_seals & F_SEAL_FS_WRITE)) + file->f_mode &= ~(FMODE_WRITE | FMODE_PWRITE); + *file_seals |= seals; error = 0;