From patchwork Sat Oct 6 11:23:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srikar Dronamraju X-Patchwork-Id: 10629243 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D05FC112B for ; Sat, 6 Oct 2018 11:23:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B475C29095 for ; Sat, 6 Oct 2018 11:23:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A7D48290A7; Sat, 6 Oct 2018 11:23:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 28A6E29095 for ; Sat, 6 Oct 2018 11:23:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 954DC6B000A; Sat, 6 Oct 2018 07:23:51 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 8DA066B000C; Sat, 6 Oct 2018 07:23:51 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77A856B000D; Sat, 6 Oct 2018 07:23:51 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by kanga.kvack.org (Postfix) with ESMTP id 48D4D6B000A for ; Sat, 6 Oct 2018 07:23:51 -0400 (EDT) Received: by mail-oi1-f198.google.com with SMTP id r68-v6so10577284oie.12 for ; Sat, 06 Oct 2018 04:23:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id; bh=MhvLOxnM4Vz1387Ds/fQw3MUtGYObymz66J6HqFIlAI=; b=GyUujnV1/G+OXQ8wgdc/U6c9JvuHfx5Nml78sanOFjzuGZ1plBqXyxytMWLzs2WnGS ENWwbdE9fdGwnrssX2DQJx8J/UCp6sik0W/lmpbAZVDfG5BsV0uqC9eJI3+zO8nSFFEB Drj1QfA+neADdza3tl67uPOFGEN0Lh+Lc4WlBESZyY0oPwtOXAqfn6P5t2GRWZ+yi/K8 y3QvZqUwZ8KwxFNmOM3AAr8OBL7dUXF8ZTnFX0GxumdzacjmQtVe3oa4LOow6Z4RxY16 Jgn6TwfoOgRYCWJVYdA/CdsbbDOp7lsmmhHYrqHvQgFhvFg4nY/VDX6xo7sSayS0l2uV lm/Q== X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 148.163.156.1 is neither permitted nor denied by best guess record for domain of srikar@linux.vnet.ibm.com) smtp.mailfrom=srikar@linux.vnet.ibm.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com X-Gm-Message-State: ABuFfoisNvegwHw3YKhPek97xqkg19nO5O4ejuRHSEkJ3Uy+1zXDpOrO vKYXeSAunauvkS/88QW4vqpoc/kiGWxXMmEIfUYvECZR6t+ooB06Llrx4c2MX5VJ5sQq8iHYS33 MRzfl1ZidVb2qJNB/Qzxqk5VmWaK/LDcd9tmixnrXeZr/RxyElOJzUlil4qN87rI= X-Received: by 2002:aca:bf07:: with SMTP id p7-v6mr1288270oif.285.1538825030967; Sat, 06 Oct 2018 04:23:50 -0700 (PDT) X-Google-Smtp-Source: ACcGV60f9yvJkR+FVNEJMcMJF0sbp1CngL1wkBeIIvHCYQBVQrZaMJJ9AefJh0ejDneb9jUljR2T X-Received: by 2002:aca:bf07:: with SMTP id p7-v6mr1288249oif.285.1538825030059; Sat, 06 Oct 2018 04:23:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1538825030; cv=none; d=google.com; s=arc-20160816; b=c960z6PXA0uXiqob5IS4ms8qqd4PpqgE/yvwW3MVfPtwjMFgjPbgP4y01mFVs0yjNo A5P+JOFpmSwGanCwVNvBw5/1kgV0NRdNTsfUODz1jV1+iLmiN+CniJCKAJUyTs4Ia9QV FqjL3WRd9saTACuJw7Vckm565Pf75xwBOQuASIbhMPwi3LBvY05Z6QyZnU9BNXXVYCSE X6hHjDSu6o1RxEEEHY4daGgkUCkeORncgMW88yvtoiwaf/EJpP2Yp65nPyISprNos92q HrrKleDZngtmLdlhqKzyTpJ+yAO0tEW/zll1BTrvxNVFBnPp/uCPRJK87ISFwnDlXpKS s6mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from; bh=MhvLOxnM4Vz1387Ds/fQw3MUtGYObymz66J6HqFIlAI=; b=q48Tl7KHRiVqGb2hQEh/8QDioLcGjAb8OhWh1f9E5qEZeagLVt96I1veLL+D94SU6d GdMQwt5/G4Sl577t8cTDuXm+EqPKVdTd76isAhc64+JGEfxmEXGpa+m9rLRHdXnl73H/ J86e5EaS96mbFZPzCb7yrz/04tMYxrGr7ylUFyfFZu6dRvoZ2544rxltfWKIWLtp6oxA WBulT1yVM++Hjkx/Qs/G1923FHyl+tzuNwoKGKGFiQau782idhVtpgyP03UVIp3xBpeA IPqAT+y+jV4hCFufN+LxA7VHVxseszpRu8Z33/npSX4JNQKolEfBwFd0yDrAYFgvsrUf s0UQ== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 148.163.156.1 is neither permitted nor denied by best guess record for domain of srikar@linux.vnet.ibm.com) smtp.mailfrom=srikar@linux.vnet.ibm.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com. [148.163.156.1]) by mx.google.com with ESMTPS id b23si5396676otb.226.2018.10.06.04.23.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 06 Oct 2018 04:23:49 -0700 (PDT) Received-SPF: neutral (google.com: 148.163.156.1 is neither permitted nor denied by best guess record for domain of srikar@linux.vnet.ibm.com) client-ip=148.163.156.1; Authentication-Results: mx.google.com; spf=neutral (google.com: 148.163.156.1 is neither permitted nor denied by best guess record for domain of srikar@linux.vnet.ibm.com) smtp.mailfrom=srikar@linux.vnet.ibm.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w96BNflu132353 for ; Sat, 6 Oct 2018 07:23:48 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2mxqcq2duj-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 06 Oct 2018 07:23:48 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sat, 6 Oct 2018 12:23:46 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sat, 6 Oct 2018 12:23:42 +0100 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w96BNf4X55967952 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 6 Oct 2018 11:23:41 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EFF785204E; Sat, 6 Oct 2018 14:23:16 +0100 (BST) Received: from srikart450.in.ibm.com (unknown [9.85.74.129]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 68C415204F; Sat, 6 Oct 2018 14:23:15 +0100 (BST) From: Srikar Dronamraju To: Ingo Molnar , Peter Zijlstra Cc: LKML , Mel Gorman , Rik van Riel , Srikar Dronamraju , Thomas Gleixner , Linux-MM Subject: [PATCH] mm,numa: Remove remaining traces of rate-limiting. Date: Sat, 6 Oct 2018 16:53:19 +0530 X-Mailer: git-send-email 2.7.4 X-TM-AS-GCONF: 00 x-cbid: 18100611-0012-0000-0000-000002B35D3B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18100611-0013-0000-0000-000020E7A247 Message-Id: <1538824999-31230-1-git-send-email-srikar@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-10-06_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810060120 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP With Commit efaffc5e40ae ("mm, sched/numa: Remove rate-limiting of automatic NUMA balancing migration"), we no more require migrate lock and its initialization. Its redundant. Hence remove it. Signed-off-by: Srikar Dronamraju Acked-by: Mel Gorman --- include/linux/mmzone.h | 4 ---- mm/page_alloc.c | 10 ---------- 2 files changed, 14 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 3f4c0b1..d4b0c79 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -668,10 +668,6 @@ typedef struct pglist_data { wait_queue_head_t kcompactd_wait; struct task_struct *kcompactd; #endif -#ifdef CONFIG_NUMA_BALANCING - /* Lock serializing the migrate rate limiting window */ - spinlock_t numabalancing_migrate_lock; -#endif /* * This is a per-node reserve of pages that are not available * to userspace allocations. diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 706a738..e2ef1c1 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6193,15 +6193,6 @@ static unsigned long __init calc_memmap_size(unsigned long spanned_pages, return PAGE_ALIGN(pages * sizeof(struct page)) >> PAGE_SHIFT; } -#ifdef CONFIG_NUMA_BALANCING -static void pgdat_init_numabalancing(struct pglist_data *pgdat) -{ - spin_lock_init(&pgdat->numabalancing_migrate_lock); -} -#else -static void pgdat_init_numabalancing(struct pglist_data *pgdat) {} -#endif - #ifdef CONFIG_TRANSPARENT_HUGEPAGE static void pgdat_init_split_queue(struct pglist_data *pgdat) { @@ -6226,7 +6217,6 @@ static void __meminit pgdat_init_internals(struct pglist_data *pgdat) { pgdat_resize_init(pgdat); - pgdat_init_numabalancing(pgdat); pgdat_init_split_queue(pgdat); pgdat_init_kcompactd(pgdat);