From patchwork Sun Oct 7 04:33:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Li Qiang X-Patchwork-Id: 10629361 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 40E6F14BD for ; Sun, 7 Oct 2018 04:34:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 255E228E8F for ; Sun, 7 Oct 2018 04:34:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 18F7E28FEF; Sun, 7 Oct 2018 04:34:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 647DF28E8F for ; Sun, 7 Oct 2018 04:34:27 +0000 (UTC) Received: from localhost ([::1]:41121 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g90lu-0000FL-Ne for patchwork-qemu-devel@patchwork.kernel.org; Sun, 07 Oct 2018 00:34:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g90lG-0008Nc-BV for qemu-devel@nongnu.org; Sun, 07 Oct 2018 00:33:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g90lB-0002N7-RB for qemu-devel@nongnu.org; Sun, 07 Oct 2018 00:33:46 -0400 Received: from m12-11.163.com ([220.181.12.11]:34711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g90lB-0002JK-00 for qemu-devel@nongnu.org; Sun, 07 Oct 2018 00:33:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=BR28F58puqR/7x+0Ms eiJvyacW8+RLa00G5iSjtm4Z8=; b=ebfKw0wIpNfdXJf6GKAX11xbkeKWMbmwLX cpDCuS0B2rM8d53XOYq5Y3mIqbGeb84BQDD57Mqzi4EXPWEtlQkRXIO1Am5YC/oZ XAa5jZCAzPtoF0FF3P7enrlgMIoLoE5scCsjTLSoyviEZJrmV1wzN6J/NRZPLirk U89qvBaP8= Received: from ubuntu.localdomain (unknown [183.159.200.5]) by smtp7 (Coremail) with SMTP id C8CowAD303SgjLlbi12FDA--.23021S2; Sun, 07 Oct 2018 12:33:37 +0800 (CST) From: Li Qiang To: pbonzini@redhat.com Date: Sat, 6 Oct 2018 21:33:35 -0700 Message-Id: <20181007043335.23631-1-liq3ea@163.com> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: C8CowAD303SgjLlbi12FDA--.23021S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7JFW5GF18JF1DWr13Jr45GFg_yoW3JFX_Ca 4vqw18uw4DZFy3ZFn7Ars0va4IgayDZFs3X34fKayayF1UJw4aqrs2qrZ5JrWfuw47KrZx t34kZwnxJFn7ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjrWFUUUUUU== X-Originating-IP: [183.159.200.5] X-CM-SenderInfo: 5oltjvrd6rljoofrz/1tbiTwHYbVsGMSYxEwAAsT X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 220.181.12.11 Subject: [Qemu-devel] [PATCH] vl.c: print error message if load fw_cfg file failed X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP It makes sense to print the error message while reading file failed. Signed-off-by: Li Qiang Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Philippe Mathieu-Daudé --- vl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/vl.c b/vl.c index cc55fe04a2..3db410e771 100644 --- a/vl.c +++ b/vl.c @@ -2207,8 +2207,9 @@ static int parse_fw_cfg(void *opaque, QemuOpts *opts, Error **errp) size = strlen(str); /* NUL terminator NOT included in fw_cfg blob */ buf = g_memdup(str, size); } else { - if (!g_file_get_contents(file, &buf, &size, NULL)) { - error_report("can't load %s", file); + GError *error = NULL; + if (!g_file_get_contents(file, &buf, &size, &error)) { + error_report("can't load %s, %s", file, error->message); return -1; } }