From patchwork Mon May 4 17:54:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ewan Milne X-Patchwork-Id: 11527309 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3372515AB for ; Mon, 4 May 2020 17:54:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1133120705 for ; Mon, 4 May 2020 17:54:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gsebzKml" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730129AbgEDRyX (ORCPT ); Mon, 4 May 2020 13:54:23 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:40800 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728158AbgEDRyX (ORCPT ); Mon, 4 May 2020 13:54:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588614862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=CjIIS1m4iAVPSDxzJVwEDqZnulFbyKq6kX/pTDDnEa0=; b=gsebzKmlElRSDmZ6TghZiqQkOHBh56O7a+ru21teekZydEd2YQwa/dRCC0ijGoByjri7Qt 0yC6SLPvR+hNlLkWrWB1ksaRp1ZYC0aNw/PO79PC8+gshf2MIKRZ1KUp4dzkdBuYYvUBT0 uY6RcnXvnXsDVxZF8JSMJmJ/4Mbjgy4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-HkLQWVgeNZKg-G3tKppgzg-1; Mon, 04 May 2020 13:54:18 -0400 X-MC-Unique: HkLQWVgeNZKg-G3tKppgzg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 827021005510; Mon, 4 May 2020 17:54:17 +0000 (UTC) Received: from emilne.bos.redhat.com (unknown [10.18.25.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id C65725D9D3; Mon, 4 May 2020 17:54:16 +0000 (UTC) From: "Ewan D. Milne" To: linux-scsi@vger.kernel.org Cc: stable@vger.kernel.org, njavali@marvell.com, himanshu.madhani@oracle.com Subject: [PATCH] scsi: qla2xxx: Do not log message when reading port speed via sysfs Date: Mon, 4 May 2020 13:54:16 -0400 Message-Id: <20200504175416.15417-1-emilne@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Calling ql_log() inside qla2x00_port_speed_show() is causing messages to be output to the console for no particularly good reason. The sysfs read routine should just return the information to userspace. The only reason to log a message is when the port speed actually changes, and this already occurs elsewhere. Cc: # v5.1+ Fixes: 4910b524ac9 ("scsi: qla2xxx: Add support for setting port speed") Signed-off-by: Ewan D. Milne Reviewed-by: Laurence Oberman Reviewed-by: Himanshu Madhani Reviewed-by: Lee Duncan --- drivers/scsi/qla2xxx/qla_attr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c index 3325596..2c9e5ac 100644 --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -1850,9 +1850,6 @@ qla2x00_port_speed_show(struct device *dev, struct device_attribute *attr, return -EINVAL; } - ql_log(ql_log_info, vha, 0x70d6, - "port speed:%d\n", ha->link_data_rate); - return scnprintf(buf, PAGE_SIZE, "%s\n", spd[ha->link_data_rate]); }