From patchwork Sat Jul 28 23:16:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: bugzilla-daemon@freedesktop.org X-Patchwork-Id: 10548091 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4B5D0112B for ; Sat, 28 Jul 2018 23:16:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1FD112AD6B for ; Sat, 28 Jul 2018 23:16:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EFF972ADD4; Sat, 28 Jul 2018 23:16:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,HTML_MESSAGE, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id ED4CF2AD6B for ; Sat, 28 Jul 2018 23:16:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4914B6E13D; Sat, 28 Jul 2018 23:16:36 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 9BBBA6E0AA for ; Sat, 28 Jul 2018 23:16:35 +0000 (UTC) Received: by culpepper.freedesktop.org (Postfix, from userid 33) id 91B77727A1; Sat, 28 Jul 2018 23:16:35 +0000 (UTC) From: bugzilla-daemon@freedesktop.org To: dri-devel@lists.freedesktop.org Subject: [Bug 107384] random tab crashes in firefox nightly Date: Sat, 28 Jul 2018 23:16:35 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: DRI X-Bugzilla-Component: libdrm X-Bugzilla-Version: DRI git X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: haagch@frickel.club X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: medium X-Bugzilla-Assigned-To: dri-devel@lists.freedesktop.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP https://bugs.freedesktop.org/show_bug.cgi?id=107384 --- Comment #7 from Christoph Haag --- (In reply to Chris Wilson from comment #5) > Sigh. > > diff --git a/src/loader/loader.c b/src/loader/loader.c > index 43275484cc..87b7281f78 100644 > --- a/src/loader/loader.c > +++ b/src/loader/loader.c > @@ -274,7 +274,7 @@ int loader_get_user_preferred_fd(int default_fd, bool > *different_device) > static int > drm_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id) > { > - drmDevicePtr device; > + drmDevicePtr device = NULL; > int ret; > > if (drmGetDevice2(fd, 0, &device) == 0) { Thanks, looks like this is my issue too. if (drmGetDevice2(fd, 0, &device) != 0) @@ -274,7 +274,7 @@ int loader_get_user_preferred_fd(int default_fd, bool *different_device) static int drm_get_pci_id_for_fd(int fd, int *vendor_id, int *chip_id) { - drmDevicePtr device; + drmDevicePtr device = NULL; int ret; if (drmGetDevice2(fd, 0, &device) == 0) { diff --git a/src/loader/loader.c b/src/loader/loader.c index 43275484cc2..02a1f97684f 100644 --- a/src/loader/loader.c +++ b/src/loader/loader.c @@ -167,7 +167,7 @@ static bool drm_device_matches_tag(drmDevicePtr device, const char *prime_tag) static char *drm_get_id_path_tag_for_fd(int fd) { - drmDevicePtr device; + drmDevicePtr device = NULL; char *tag;