From patchwork Thu May 7 08:29:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 11532851 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EB15E1668 for ; Thu, 7 May 2020 08:29:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2223207DD for ; Thu, 7 May 2020 08:29:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2223207DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D5E66E0AA; Thu, 7 May 2020 08:29:40 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0572D6E0AA for ; Thu, 7 May 2020 08:29:38 +0000 (UTC) X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from build.alporthouse.com (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP id 21135519-1500050 for multiple; Thu, 07 May 2020 09:29:12 +0100 From: Chris Wilson To: intel-gfx@lists.freedesktop.org Date: Thu, 7 May 2020 09:29:10 +0100 Message-Id: <20200507082910.10481-1-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200507082124.1673-3-chris@chris-wilson.co.uk> References: <20200507082124.1673-3-chris@chris-wilson.co.uk> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH] drm/i915: Treat weak-dependencies as bidirectional when applying priorities X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chris Wilson Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Clients may use a submit-fence as bidirectional bond between two or more co-operating requests, and so if we bump the priority of one, we wish to bump the priority of the set. Testcase: igt/gem_exec_fence/submitN Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_scheduler.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_scheduler.c b/drivers/gpu/drm/i915/i915_scheduler.c index 6e2d4190099f..1c33973dbd20 100644 --- a/drivers/gpu/drm/i915/i915_scheduler.c +++ b/drivers/gpu/drm/i915/i915_scheduler.c @@ -291,6 +291,19 @@ static void __i915_schedule(struct i915_sched_node *node, if (prio > READ_ONCE(p->signaler->attr.priority)) list_move_tail(&p->dfs_link, &dfs); } + + /* + * A weak dependency is used for submit-fence, which while + * not strongly coupled, we do need to treat as a coordinated + * set of co-operating requests that need to be run + * concurrently. So if one request of that set receives a + * priority boost, they all receive a priority boost. + */ + list_for_each_entry(p, &node->waiters_list, wait_link) { + if (p->flags & I915_DEPENDENCY_WEAK && + prio > READ_ONCE(p->waiter->attr.priority)) + list_move_tail(&p->dfs_link, &dfs); + } } /*