From patchwork Fri May 8 05:33:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Qu Wenruo X-Patchwork-Id: 11535529 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7767792A for ; Fri, 8 May 2020 05:33:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64E2C208D6 for ; Fri, 8 May 2020 05:33:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725875AbgEHFdK (ORCPT ); Fri, 8 May 2020 01:33:10 -0400 Received: from mx2.suse.de ([195.135.220.15]:46156 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725681AbgEHFdK (ORCPT ); Fri, 8 May 2020 01:33:10 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 7A4A0ADD7 for ; Fri, 8 May 2020 05:33:11 +0000 (UTC) From: Qu Wenruo To: linux-btrfs@vger.kernel.org Subject: [PATCH] btrfs-progs: Doc: Add extra warning for -i option of snapshot creation Date: Fri, 8 May 2020 13:33:04 +0800 Message-Id: <20200508053304.27723-1-wqu@suse.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org That -i option of snapshot creation can easily make qgroup inconsistent. And unlike 'btrfs qgroup assign', the ioctl involved doesn't have way to inform user space that qgroup is inconsistent. So add extra warning in the man page. Signed-off-by: Qu Wenruo --- Documentation/btrfs-subvolume.asciidoc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/btrfs-subvolume.asciidoc b/Documentation/btrfs-subvolume.asciidoc index 1de6a6febbee..70ecc641e85e 100644 --- a/Documentation/btrfs-subvolume.asciidoc +++ b/Documentation/btrfs-subvolume.asciidoc @@ -222,6 +222,12 @@ Make the new snapshot read only. -i :::: Add the newly created subvolume to a qgroup. This option can be given multiple times. ++ +WARNING: This parameter can make qgroup inconsistent, and due to the +limitation of snapshot creation ioctl, there is no way to inform user space +that qgroup is inconsistent due to this operation. +Please use 'btrfs qgroup assign' instead. + *sync* [subvolid...]:: Wait until given subvolume(s) are completely removed from the filesystem after