From patchwork Fri May 8 21:19:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Cooper X-Patchwork-Id: 11537625 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4BB70139F for ; Fri, 8 May 2020 21:20:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31E7024960 for ; Fri, 8 May 2020 21:20:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BFtOvUkb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727803AbgEHVUC (ORCPT ); Fri, 8 May 2020 17:20:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbgEHVUB (ORCPT ); Fri, 8 May 2020 17:20:01 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 570E3C061A0C; Fri, 8 May 2020 14:20:01 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id k12so11641788wmj.3; Fri, 08 May 2020 14:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dq0TqQky1nAFrd/UmJjerH5DUbLlLnhiDz64ca0nS+c=; b=BFtOvUkb9cbuzMMRhdzBNK5ecXEQM9byzqclZfaTmo8jWlWrx6L9He1mdy+Oicdpmy C2wpLwR4YwShUVE2tDjxEsNxw630unsx/V7Exl68ovCKx9bcttuUXdQBMSPxKR1Vga8c TJuy7qafu2UeYOspf+o/58evciXpbWP25FqkIrxTxxyi9gQd78GAwY09T5hnNTsqitOx F5WTxRrtCJBTA1CRuJAdxmfq0tMEd9fRF7wDNrop93QCpEtTGvkE+WNVbecX5icnEnlP tU9o50N90gD97YxKR08fEFe6vAXu90Agi8XRvmqx/s/75UxkNXQM0DUBJygnNdQE9GDg dPog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dq0TqQky1nAFrd/UmJjerH5DUbLlLnhiDz64ca0nS+c=; b=CrZVpPkbJLzjnBDX0Js4D/aVBzZdHcvP0EqWfwo5W5flgDCr3zXzLt3rqoe2aMcsIX wYQbbU3MN5P0Kq/IANNxBTeXAHIv5Kcf7/sp0+03bDm2Q1JOniS8HQOKtpKLAU4DAuRm TvR41uKcOEK5KEIEom1fCoNKRQluryhF4QtOc2W753jl9jta65+GZJ7bPGFwwEFLMV6o OioIcac3F4GSpWgU8AcZNFSobsxXaIMosx2w9LG2RDuvfp/7qFQUxmXT4VTFM3M111kn fbpUUVv9wI61aa1cgwu0NNuIhasTloLw6ghiH5PGLwi5h51Ft/OH+bOKfjK0dyiZabyl FqIg== X-Gm-Message-State: AGi0Pub+CXAiNUHz9GgiFtRfp2KxR2Px4BBnyTibIbv/BWH7uaRq7e0G wWO3JFyP8h8z75wXUg/FMVbl76tQqdQ= X-Google-Smtp-Source: APiQypKJ+gnuUbus38CVokjh5igSLze560rfF4SF8l36zNto5ZlMR2hFAWskJxCoVQ8iCXxb1AiSSQ== X-Received: by 2002:a05:600c:2f17:: with SMTP id r23mr17145297wmn.81.1588972799227; Fri, 08 May 2020 14:19:59 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id n9sm4669705wrv.43.2020.05.08.14.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 14:19:58 -0700 (PDT) From: Al Cooper To: linux-kernel@vger.kernel.org Cc: Al Cooper , Alan Stern , Andy Shevchenko , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, Greg Kroah-Hartman , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Mathias Nyman , Rob Herring , Yoshihiro Shimoda , Andy Shevchenko Subject: [PATCH v8 1/5] usb: xhci: Change the XHCI link order in the Makefile Date: Fri, 8 May 2020 17:19:25 -0400 Message-Id: <20200508211929.39020-2-alcooperx@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200508211929.39020-1-alcooperx@gmail.com> References: <20200508211929.39020-1-alcooperx@gmail.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Some BRCMSTB USB chips have an XHCI, EHCI and OHCI controller on the same port where XHCI handles 3.0 devices, EHCI handles 2.0 devices and OHCI handles <2.0 devices. Currently the Makefile has XHCI linking at the bottom which will result in the XHIC driver initalizing after the EHCI and OHCI drivers and any installed 3.0 device will be seen as a 2.0 device. Moving the XHCI linking above the EHCI and OHCI linking fixes the issue. Signed-off-by: Al Cooper Reviewed-by: Florian Fainelli Tested-by: Yoshihiro Shimoda --- drivers/usb/host/Makefile | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile index b191361257cc..a7f0b8ff7179 100644 --- a/drivers/usb/host/Makefile +++ b/drivers/usb/host/Makefile @@ -37,6 +37,16 @@ endif obj-$(CONFIG_USB_PCI) += pci-quirks.o +# NOTE: BRCMSTB systems require that xhci driver be linked before the +# ehci/ohci drivers because they share a port and need the XHCI driver +# to come up first to properly enumerate 3.0 devices. +obj-$(CONFIG_USB_XHCI_HCD) += xhci-hcd.o +obj-$(CONFIG_USB_XHCI_PCI) += xhci-pci.o +obj-$(CONFIG_USB_XHCI_PLATFORM) += xhci-plat-hcd.o +obj-$(CONFIG_USB_XHCI_HISTB) += xhci-histb.o +obj-$(CONFIG_USB_XHCI_MTK) += xhci-mtk.o +obj-$(CONFIG_USB_XHCI_TEGRA) += xhci-tegra.o + obj-$(CONFIG_USB_EHCI_HCD) += ehci-hcd.o obj-$(CONFIG_USB_EHCI_PCI) += ehci-pci.o obj-$(CONFIG_USB_EHCI_HCD_PLATFORM) += ehci-platform.o @@ -69,12 +79,6 @@ obj-$(CONFIG_USB_OHCI_HCD_DAVINCI) += ohci-da8xx.o obj-$(CONFIG_USB_UHCI_HCD) += uhci-hcd.o obj-$(CONFIG_USB_FHCI_HCD) += fhci.o -obj-$(CONFIG_USB_XHCI_HCD) += xhci-hcd.o -obj-$(CONFIG_USB_XHCI_PCI) += xhci-pci.o -obj-$(CONFIG_USB_XHCI_PLATFORM) += xhci-plat-hcd.o -obj-$(CONFIG_USB_XHCI_HISTB) += xhci-histb.o -obj-$(CONFIG_USB_XHCI_MTK) += xhci-mtk.o -obj-$(CONFIG_USB_XHCI_TEGRA) += xhci-tegra.o obj-$(CONFIG_USB_SL811_HCD) += sl811-hcd.o obj-$(CONFIG_USB_SL811_CS) += sl811_cs.o obj-$(CONFIG_USB_U132_HCD) += u132-hcd.o From patchwork Fri May 8 21:19:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Cooper X-Patchwork-Id: 11537623 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 98349159A for ; Fri, 8 May 2020 21:20:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 80DB9218AC for ; Fri, 8 May 2020 21:20:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A+07F/U3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727952AbgEHVUJ (ORCPT ); Fri, 8 May 2020 17:20:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727898AbgEHVUD (ORCPT ); Fri, 8 May 2020 17:20:03 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 742F1C061A0C; Fri, 8 May 2020 14:20:03 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id h9so3566459wrt.0; Fri, 08 May 2020 14:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RS2ptxmKb3ffwIAhZDMnM3dCIs8tmDEdZCAAPTqFzQ8=; b=A+07F/U3f0MrRotSRljdPjGnVKFx9RMOeIhdLwxoO/kDHdIrz1s0HHehh9pWGlFQe/ rSyrZqgik4cHbB14XfYyDbRNKcnZDZ8AiFrtbSlXFmT1rMv7DTvX3mC15EDt2b/cbWZu LzjBzrNsIP7aWHpDS57OAsbj0ziTvxhl1lf6uX58nKOXijH4q2pYAo+a66T0EtCvdiRC mHBsVaParRRKAMb/NBxkCEKKzs90pMABIjUGs+K/kRckc95U8udBbmo5OvACBYhY4rNK jyQKbL+JLlgN2aCDAhY8OG6ZpiSGz0tHAc2/Vv7P6WJ2A6RXm8miqaOMunX/1IG8EThn Br+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RS2ptxmKb3ffwIAhZDMnM3dCIs8tmDEdZCAAPTqFzQ8=; b=aGayFm4iTmXY+CNdNJNif8zNoTrj2dt4jUv4EaMxt5IBizVkRUURYl6GhzPD/dUekT le6iQ4LzWJGpStcPZCOqIOpIigVvWFgNs2LxTH56PZVkSndIYsS/rc3KPDRIZO0IbQ0/ 1BBIQq47lQjKuHRiK8xzapRAWNGrpcgcma9sMPPYg6+SMlR71VdDceQpg8Jat73nST20 Ks7EEee1BOluF1WW4sJ/2R7KpqCldBejvCA0O0GUUJUxrQ47suJmKovb0qL5TUXA7mBt /5DruVIVuO2AUOpW6gs/n+fKlAwvwPKfn02Fw4x74Ny1GSG2k36OUQFZr058FLRjVUs7 VhWA== X-Gm-Message-State: AGi0PuY6VsYnalcbx/YiGhP4ywQxQyw5dxTr00yMWaVLPdV502o7CYq1 kdt6dwsim5N1+M+aM1EPsenbiYyNskU= X-Google-Smtp-Source: APiQypKODx2brOOBHWWSAOsBJfBScus9jb75m1v6WcD/ETNO75Cy4XAvkUe8LuDT7u4hjuSvbJN+SQ== X-Received: by 2002:adf:ee03:: with SMTP id y3mr4759217wrn.190.1588972801877; Fri, 08 May 2020 14:20:01 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id n9sm4669705wrv.43.2020.05.08.14.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 14:20:01 -0700 (PDT) From: Al Cooper To: linux-kernel@vger.kernel.org Cc: Al Cooper , Alan Stern , Andy Shevchenko , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, Greg Kroah-Hartman , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Mathias Nyman , Rob Herring , Yoshihiro Shimoda , Andy Shevchenko Subject: [PATCH v8 2/5] dt-bindings: Add Broadcom STB USB support Date: Fri, 8 May 2020 17:19:26 -0400 Message-Id: <20200508211929.39020-3-alcooperx@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200508211929.39020-1-alcooperx@gmail.com> References: <20200508211929.39020-1-alcooperx@gmail.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Add DT bindings for Broadcom STB USB EHCI and XHCI drivers. NOTE: The OHCI driver is not included because it uses the generic platform driver. Signed-off-by: Al Cooper Reviewed-by: Rob Herring Reviewed-by: Florian Fainelli --- .../bindings/usb/brcm,bcm7445-ehci.yaml | 59 +++++++++++++++++++ .../devicetree/bindings/usb/usb-xhci.txt | 1 + 2 files changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml diff --git a/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml b/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml new file mode 100644 index 000000000000..2a9acf2b5a64 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/brcm,bcm7445-ehci.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Broadcom STB USB EHCI Controller Device Tree Bindings + +allOf: + - $ref: "usb-hcd.yaml" + +maintainers: + - Al Cooper + +properties: + compatible: + const: brcm,bcm7445-ehci + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + description: Clock specifier for the EHCI clock + + clock-names: + const: sw_usb + + phys: + maxItems: 1 + + phy-names: + const: usbphy + +required: + - compatible + - reg + - interrupts + - phys + - clocks + +additionalProperties: false + +examples: + - | + usb@f0b00300 { + compatible = "brcm,bcm7445-ehci"; + reg = <0xf0b00300 0xa8>; + interrupts = <0x0 0x5a 0x0>; + phys = <&usbphy_0 0x0>; + phy-names = "usbphy"; + clocks = <&usb20>; + clock-names = "sw_usb"; + }; + +... diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt index dc025f126d71..23e89d798b1b 100644 --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt @@ -24,6 +24,7 @@ Required properties: device - "renesas,rcar-gen3-xhci" for a generic R-Car Gen3 or RZ/G2 compatible device + - "brcm,bcm7445-xhci" for Broadcom STB SoCs with XHCI - "xhci-platform" (deprecated) When compatible with the generic version, nodes must list the From patchwork Fri May 8 21:19:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Cooper X-Patchwork-Id: 11537617 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9A98B139F for ; Fri, 8 May 2020 21:20:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8271C21974 for ; Fri, 8 May 2020 21:20:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EouHjzqz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727938AbgEHVUI (ORCPT ); Fri, 8 May 2020 17:20:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727925AbgEHVUH (ORCPT ); Fri, 8 May 2020 17:20:07 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DDECC061A0C; Fri, 8 May 2020 14:20:06 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id y24so12233276wma.4; Fri, 08 May 2020 14:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vkQbZ0OEnEU7UUbpzBp0+WjmUbWo04Z45g1QFzRKmTk=; b=EouHjzqzm/494wG6EcB1CIMJYU4kdLHbavWF8FuDc6i3pyLM8HI1UyMXx781m+Famw 4Br/r8lBNPieXkek0it5gU4JKPyfZScUSdz+rc4v6JX+4m9zWkPpVRR73fcCOdExNGOL sHSR7aryRPASpZaz4r5N70NqZ/9+mQWJhihoY+Gj68WJ5NM5AKctldERP75GTct90yDm 9Oz2t0hjkMqqfnJM7Zo0O8zZKmtRsHuAduznbrYbdFGEqe+BjaXC+EWa0XNnOnaxM/14 QW/FaXs4GZUPD1KDSSMcoYn7eHf3KPNyN3hu4fYxe0I9ANeiJy9OmcVP81lv2h/o18UM wKAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vkQbZ0OEnEU7UUbpzBp0+WjmUbWo04Z45g1QFzRKmTk=; b=Ai+UGRay3UedwfIc0bUOXtH6Q1cTrjUBsUJDuvqJWR/14PKgYv9irUxbXzVl9mTFSU Qtv3WK4Jfi/2jiIIhRbjKDGEoz7KM5GoreUvIAdsxKoMbgRrI0ip2cPADmtaMVCuEHHQ afL1Exr+S+4CLLK9Oxf3NMkSOs6FmQIu3oAIXcHBiXJSKZp1B7oSZMeVtfSp1NXVZsej PDC5bNQy4v+zElKZ0ljl7kFVyZBhN+FHCCrw+UsnvKTT2lEnamwgh1vcpwO0Y3hfpWVb TPwa0xlTuHPtSan1HRDOBuHzDG1Cj9mRZm+tYA8tRIpDEIfrFYW5WzQeXTZnmcfDV1vF fLIA== X-Gm-Message-State: AGi0PuaFQgubH8U6hSCefufF8jzUsjC90PrUpAPh/K7bUTfAujX9Y0IA BjXJI4oPbrHJFcHb6J+WYhYn09sYwxI= X-Google-Smtp-Source: APiQypL9SvSACY/ptDdzKnQdmAQ81UAswVboa0ILmySMCSCfOVnPumxavUbh4Kfxq9thk5duJGYnQw== X-Received: by 2002:a1c:9c0a:: with SMTP id f10mr17972530wme.139.1588972804547; Fri, 08 May 2020 14:20:04 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id n9sm4669705wrv.43.2020.05.08.14.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 14:20:04 -0700 (PDT) From: Al Cooper To: linux-kernel@vger.kernel.org Cc: Al Cooper , Alan Stern , Andy Shevchenko , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, Greg Kroah-Hartman , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Mathias Nyman , Rob Herring , Yoshihiro Shimoda , Andy Shevchenko Subject: [PATCH v8 3/5] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's Date: Fri, 8 May 2020 17:19:27 -0400 Message-Id: <20200508211929.39020-4-alcooperx@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200508211929.39020-1-alcooperx@gmail.com> References: <20200508211929.39020-1-alcooperx@gmail.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Add support for Broadcom STB SoC's to the xhci platform driver Signed-off-by: Al Cooper Acked-by: Mathias Nyman Reviewed-by: Florian Fainelli --- drivers/usb/host/xhci-plat.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index 1d4f6f85f0fe..44406d0eb317 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -112,6 +112,10 @@ static const struct xhci_plat_priv xhci_plat_renesas_rcar_gen3 = { SET_XHCI_PLAT_PRIV_FOR_RCAR(XHCI_RCAR_FIRMWARE_NAME_V3) }; +static const struct xhci_plat_priv xhci_plat_brcm = { + .quirks = XHCI_RESET_ON_RESUME, +}; + static const struct of_device_id usb_xhci_of_match[] = { { .compatible = "generic-xhci", @@ -147,6 +151,12 @@ static const struct of_device_id usb_xhci_of_match[] = { }, { .compatible = "renesas,rcar-gen3-xhci", .data = &xhci_plat_renesas_rcar_gen3, + }, { + .compatible = "brcm,xhci-brcm-v2", + .data = &xhci_plat_brcm, + }, { + .compatible = "brcm,bcm7445-xhci", + .data = &xhci_plat_brcm, }, {}, }; From patchwork Fri May 8 21:19:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Cooper X-Patchwork-Id: 11537621 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CDA2F159A for ; Fri, 8 May 2020 21:20:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABB742496B for ; Fri, 8 May 2020 21:20:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LOA+SeLB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728011AbgEHVUT (ORCPT ); Fri, 8 May 2020 17:20:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727925AbgEHVUK (ORCPT ); Fri, 8 May 2020 17:20:10 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2FCDC061A0C; Fri, 8 May 2020 14:20:08 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id e16so3543755wra.7; Fri, 08 May 2020 14:20:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6yI77b/cfKgKEM/ps8AW6DeKzYbRWwOIhMDGPrLzBCQ=; b=LOA+SeLB6MpnZH5lTEY0xipY/clP/TukbYl8hJ2HDewQuW5qVaWj5SmNx6qDADsQVV rx3D/HXvGW+sKVyTbxV6FOdItZN4X239jggc2duZmQf7VVhatTER9eYHlTyl+fEdTHA8 u5DclCmEfWCxCRnGfSrHgvN1zalaaicOA8u8gqAFINE2bFA6A7anAyyvm623/PrLovvu 2UjSqhZNJikQbQvbjiUHNSDQgxecYHrpWI+M/qzJEhm+HtaIW3Da2EMfsToeGKBvNbAx X51jv8p2N+bon4w7icAR6m20OE4+VI0QF0XDovUJ9l9ZtMfaTtzEIt8G/STbQq86XKvb SlbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6yI77b/cfKgKEM/ps8AW6DeKzYbRWwOIhMDGPrLzBCQ=; b=piT3zCu9V8icKOm7OTQk69FNfEWXzeFyQaIBiVSmUeD5f2SHLcn73DbTpr/j84dO/e niQpO+bzk8TN1/PUggX8c4U5GbhWbQnmIMTf1/Vr6JZEW2OAOugZ+EerM7c0aFSe0vbt aD5ZMOgGmr4KKm7zyWwV9Mj7Mpi8p1Lp8e4IIx5QWoiFcEkkqQlXGhggZFxCqBeU2qXj cVRm7mcXBvigXP8Crtt1zXBNt12E5WY9q+lhMNh5qACOpjBT2JlKnfszVbOkCFBPjdE8 2FWmtOTQ8d4R7JVI1az1ArY2vYJTBOku/gQfzULjtw3y///Yq8af5dgt9NDxJAME7oUw MukA== X-Gm-Message-State: AGi0PuaOQz13kdINvb3CEvjOm9QaaN1MicQe4PdSKAIIe/VcGNsfPK72 pJI8FUPb5JK+syfIaqli+MDDF6EPznA= X-Google-Smtp-Source: APiQypLj63cdFX2npqPKqEjT/e6T7YOmEB7iA7FFuSFQhCRyP3swFWu/kqim5h5JiKPrzQngtMBQkw== X-Received: by 2002:a05:6000:1105:: with SMTP id z5mr5098956wrw.208.1588972806885; Fri, 08 May 2020 14:20:06 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id n9sm4669705wrv.43.2020.05.08.14.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 14:20:06 -0700 (PDT) From: Al Cooper To: linux-kernel@vger.kernel.org Cc: Al Cooper , Alan Stern , Andy Shevchenko , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, Greg Kroah-Hartman , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Mathias Nyman , Rob Herring , Yoshihiro Shimoda , Andy Shevchenko Subject: [PATCH v8 4/5] usb: ehci: Add new EHCI driver for Broadcom STB SoC's Date: Fri, 8 May 2020 17:19:28 -0400 Message-Id: <20200508211929.39020-5-alcooperx@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200508211929.39020-1-alcooperx@gmail.com> References: <20200508211929.39020-1-alcooperx@gmail.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Add a new EHCI driver for Broadcom STB SoC's. A new EHCI driver was created instead of adding support to the existing ehci platform driver because of the code required to workaround bugs in the EHCI controller. The primary workround is for a bug where the Core violates the SOF interval between the first two SOFs transmitted after resume. This only happens if the resume occurs near the end of a microframe. The fix is to intercept the echi-hcd request to complete RESUME and align it to the start of the next microframe. Signed-off-by: Al Cooper Reviewed-by: Andy Shevchenko Reviewed-by: Florian Fainelli --- drivers/usb/host/ehci-brcm.c | 281 +++++++++++++++++++++++++++++++++++ 1 file changed, 281 insertions(+) create mode 100644 drivers/usb/host/ehci-brcm.c diff --git a/drivers/usb/host/ehci-brcm.c b/drivers/usb/host/ehci-brcm.c new file mode 100644 index 000000000000..763f0b9b3f37 --- /dev/null +++ b/drivers/usb/host/ehci-brcm.c @@ -0,0 +1,281 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright (c) 2020, Broadcom */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "ehci.h" + +#define hcd_to_ehci_priv(h) ((struct brcm_priv *)hcd_to_ehci(h)->priv) + +struct brcm_priv { + struct clk *clk; +}; + +/* + * ehci_brcm_wait_for_sof + * Wait for start of next microframe, then wait extra delay microseconds + */ +static inline void ehci_brcm_wait_for_sof(struct ehci_hcd *ehci, u32 delay) +{ + u32 frame_idx = ehci_readl(ehci, &ehci->regs->frame_index); + u32 val; + int res; + + /* Wait for next microframe (every 125 usecs) */ + res = readl_relaxed_poll_timeout(&ehci->regs->frame_index, val, + val != frame_idx, 1, 130); + if (res) + dev_err(ehci_to_hcd(ehci)->self.controller, + "Error waiting for SOF\n"); + udelay(delay); +} + +/* + * ehci_brcm_hub_control + * The EHCI controller has a bug where it can violate the SOF + * interval between the first two SOF's transmitted after resume + * if the resume occurs near the end of the microframe. This causees + * the controller to detect babble on the suspended port and + * will eventually cause the controller to reset the port. + * The fix is to Intercept the echi-hcd request to complete RESUME and + * align it to the start of the next microframe. + * See SWLINUX-1909 for more details + */ +static int ehci_brcm_hub_control( + struct usb_hcd *hcd, + u16 typeReq, + u16 wValue, + u16 wIndex, + char *buf, + u16 wLength) +{ + struct ehci_hcd *ehci = hcd_to_ehci(hcd); + int ports = HCS_N_PORTS(ehci->hcs_params); + u32 __iomem *status_reg; + unsigned long flags; + int retval, irq_disabled = 0; + + status_reg = &ehci->regs->port_status[(wIndex & 0xff) - 1]; + + /* + * RESUME is cleared when GetPortStatus() is called 20ms after start + * of RESUME + */ + if ((typeReq == GetPortStatus) && + (wIndex && wIndex <= ports) && + ehci->reset_done[wIndex-1] && + time_after_eq(jiffies, ehci->reset_done[wIndex-1]) && + (ehci_readl(ehci, status_reg) & PORT_RESUME)) { + + /* + * to make sure we are not interrupted until RESUME bit + * is cleared, disable interrupts on current CPU + */ + ehci_dbg(ehci, "SOF alignment workaround\n"); + irq_disabled = 1; + local_irq_save(flags); + ehci_brcm_wait_for_sof(ehci, 5); + } + retval = ehci_hub_control(hcd, typeReq, wValue, wIndex, buf, wLength); + if (irq_disabled) + local_irq_restore(flags); + return retval; +} + +static int ehci_brcm_reset(struct usb_hcd *hcd) +{ + struct ehci_hcd *ehci = hcd_to_ehci(hcd); + int len; + + ehci->big_endian_mmio = 1; + + ehci->caps = (void __iomem *)hcd->regs; + len = HC_LENGTH(ehci, ehci_readl(ehci, &ehci->caps->hc_capbase)); + ehci->regs = (void __iomem *)(hcd->regs + len); + + /* This fixes the lockup during reboot due to prior interrupts */ + ehci_writel(ehci, CMD_RESET, &ehci->regs->command); + mdelay(10); + + /* + * SWLINUX-1705: Avoid OUT packet underflows during high memory + * bus usage + * port_status[0x0f] = Broadcom-proprietary USB_EHCI_INSNREG00 @ 0x90 + */ + ehci_writel(ehci, 0x00800040, &ehci->regs->port_status[0x10]); + ehci_writel(ehci, 0x00000001, &ehci->regs->port_status[0x12]); + + return ehci_setup(hcd); +} + +static struct hc_driver __read_mostly ehci_brcm_hc_driver; + +static const struct ehci_driver_overrides brcm_overrides __initconst = { + .reset = ehci_brcm_reset, + .extra_priv_size = sizeof(struct brcm_priv), +}; + +static int ehci_brcm_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct resource *res_mem; + struct brcm_priv *priv; + struct usb_hcd *hcd; + int irq; + int err; + + err = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)); + if (err) + return err; + + irq = platform_get_irq(pdev, 0); + if (irq <= 0) + return irq; + + /* Hook the hub control routine to work around a bug */ + ehci_brcm_hc_driver.hub_control = ehci_brcm_hub_control; + + /* initialize hcd */ + hcd = usb_create_hcd(&ehci_brcm_hc_driver, dev, dev_name(dev)); + if (!hcd) + return -ENOMEM; + + platform_set_drvdata(pdev, hcd); + priv = hcd_to_ehci_priv(hcd); + + priv->clk = devm_clk_get_optional(dev, NULL); + if (IS_ERR(priv->clk)) { + err = PTR_ERR(priv->clk); + goto err_hcd; + } + + err = clk_prepare_enable(priv->clk); + if (err) + goto err_hcd; + + hcd->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res_mem); + if (IS_ERR(hcd->regs)) { + err = PTR_ERR(hcd->regs); + goto err_clk; + } + hcd->rsrc_start = res_mem->start; + hcd->rsrc_len = resource_size(res_mem); + err = usb_add_hcd(hcd, irq, IRQF_SHARED); + if (err) + goto err_clk; + + device_wakeup_enable(hcd->self.controller); + device_enable_async_suspend(hcd->self.controller); + + return 0; + +err_clk: + clk_disable_unprepare(priv->clk); +err_hcd: + usb_put_hcd(hcd); + + return err; +} + +static int ehci_brcm_remove(struct platform_device *dev) +{ + struct usb_hcd *hcd = platform_get_drvdata(dev); + struct brcm_priv *priv = hcd_to_ehci_priv(hcd); + + usb_remove_hcd(hcd); + clk_disable_unprepare(priv->clk); + usb_put_hcd(hcd); + return 0; +} + +static int __maybe_unused ehci_brcm_suspend(struct device *dev) +{ + int ret; + struct usb_hcd *hcd = dev_get_drvdata(dev); + struct brcm_priv *priv = hcd_to_ehci_priv(hcd); + bool do_wakeup = device_may_wakeup(dev); + + ret = ehci_suspend(hcd, do_wakeup); + if (ret) + return ret; + clk_disable_unprepare(priv->clk); + return 0; +} + +static int __maybe_unused ehci_brcm_resume(struct device *dev) +{ + struct usb_hcd *hcd = dev_get_drvdata(dev); + struct ehci_hcd *ehci = hcd_to_ehci(hcd); + struct brcm_priv *priv = hcd_to_ehci_priv(hcd); + int err; + + err = clk_prepare_enable(priv->clk); + if (err) + return err; + /* + * SWLINUX-1705: Avoid OUT packet underflows during high memory + * bus usage + * port_status[0x0f] = Broadcom-proprietary USB_EHCI_INSNREG00 + * @ 0x90 + */ + ehci_writel(ehci, 0x00800040, &ehci->regs->port_status[0x10]); + ehci_writel(ehci, 0x00000001, &ehci->regs->port_status[0x12]); + + ehci_resume(hcd, false); + + pm_runtime_disable(dev); + pm_runtime_set_active(dev); + pm_runtime_enable(dev); + + return 0; +} + +static SIMPLE_DEV_PM_OPS(ehci_brcm_pm_ops, ehci_brcm_suspend, + ehci_brcm_resume); + +static const struct of_device_id brcm_ehci_of_match[] = { + { .compatible = "brcm,ehci-brcm-v2", }, + { .compatible = "brcm,bcm7445-ehci", }, + {} +}; + +static struct platform_driver ehci_brcm_driver = { + .probe = ehci_brcm_probe, + .remove = ehci_brcm_remove, + .shutdown = usb_hcd_platform_shutdown, + .driver = { + .name = "ehci-brcm", + .pm = &ehci_brcm_pm_ops, + .of_match_table = brcm_ehci_of_match, + } +}; + +static int __init ehci_brcm_init(void) +{ + if (usb_disabled()) + return -ENODEV; + + ehci_init_driver(&ehci_brcm_hc_driver, &brcm_overrides); + return platform_driver_register(&ehci_brcm_driver); +} +module_init(ehci_brcm_init); + +static void __exit ehci_brcm_exit(void) +{ + platform_driver_unregister(&ehci_brcm_driver); +} +module_exit(ehci_brcm_exit); + +MODULE_ALIAS("platform:ehci-brcm"); +MODULE_DESCRIPTION("EHCI Broadcom STB driver"); +MODULE_AUTHOR("Al Cooper"); +MODULE_LICENSE("GPL"); From patchwork Fri May 8 21:19:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Cooper X-Patchwork-Id: 11537619 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4CA42139F for ; Fri, 8 May 2020 21:20:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 34ADD24956 for ; Fri, 8 May 2020 21:20:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OnAVIHm0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727991AbgEHVUM (ORCPT ); Fri, 8 May 2020 17:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727978AbgEHVUL (ORCPT ); Fri, 8 May 2020 17:20:11 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAB6BC061A0C; Fri, 8 May 2020 14:20:10 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id s8so3544596wrt.9; Fri, 08 May 2020 14:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EPpfdrDWyIyJoF1ulwtJ3Qw81WLSoebaZdFuuGZoDek=; b=OnAVIHm0tfjIc2NibvMhJwLGl2CL40M3yxtSeUuzYhavYsy87/kPDPXF4y/UIcR3Nz /G13c0MgHhdkrpgPqXpchbCcYG2J4L2iJlaqsSldny2oCX2NjeUufnZRbdOkPj69ls1H c3fhBHRH/CV3d64GynddHyZygq8loDBU1/yNC5ostKqkOBdjdBhYvkZOjAHRQEB4xS2o T+wfhh7knyeVHsKiYFM6jjlJ+EqChpE4GcR7M3BWG4dBrIfVUXi0RzNoCBPi/rOiDTYj L7KA4Roa5VSdyz0UbU+Y54ZcJxCxaTsl32+jBQGdLnzkliC/8LrQTtYFSb/8/WGbihgR mNWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EPpfdrDWyIyJoF1ulwtJ3Qw81WLSoebaZdFuuGZoDek=; b=mueeeN150aWvAUd0gFEySHdnU/auCZWAo6Hzn2sJEYmHz9tQ2ps47NlQLoBOEnWZf0 9DGP8+rHMI52nuETd1xT+VbCFYeU3UG1ktTwcsY7y4JWjC7+nSxdX/wqY9BEuFv9OOin pIBpts5/TGAQa0wMA996u8/tlFMMWJVmj3dtAa3iFO+pkqweEnl29EzVmikA87sybHLt xMmEQtKldzYqQ8CBvp4YdeEIWeldJvooGwsWUmdSlR4E+hLt2OhqG/GAK5rYw3c7wlXe cTBBznd0/eUNnNrHLuWWTxQdpcyLEI5DUk2GNZJmYF9NEdwbhyvroupNgL51+8wMYOMc 6Huw== X-Gm-Message-State: AGi0PubLU+o/RhvAi+F96Tg7KQg6LIDpnUPsPzNZndwVc8Wz+THUytHL TiJjp/M2Mho6xgnT98QwexGOkBX0wZ0= X-Google-Smtp-Source: APiQypKbsNs1EGz2yStUD4V1y76G1Omvs2yge9aFnapbHsI3Mw9hhhSdpUGSwXKYyotjxPwcNjlLJQ== X-Received: by 2002:adf:f487:: with SMTP id l7mr4358463wro.381.1588972809267; Fri, 08 May 2020 14:20:09 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id n9sm4669705wrv.43.2020.05.08.14.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 14:20:08 -0700 (PDT) From: Al Cooper To: linux-kernel@vger.kernel.org Cc: Al Cooper , Alan Stern , Andy Shevchenko , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, Greg Kroah-Hartman , Krzysztof Kozlowski , linux-usb@vger.kernel.org, Mathias Nyman , Rob Herring , Yoshihiro Shimoda , Andy Shevchenko Subject: [PATCH v8 5/5] usb: host: Add ability to build new Broadcom STB USB drivers Date: Fri, 8 May 2020 17:19:29 -0400 Message-Id: <20200508211929.39020-6-alcooperx@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200508211929.39020-1-alcooperx@gmail.com> References: <20200508211929.39020-1-alcooperx@gmail.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Add the build system changes needed to get the Broadcom STB XHCI, EHCI and OHCI functionality working. The OHCI support does not require anything unique to Broadcom so the standard ohci-platform driver is being used. Also update MAINTAINERS. Signed-off-by: Al Cooper Reviewed-by: Florian Fainelli --- MAINTAINERS | 8 ++++++++ drivers/usb/host/Kconfig | 20 ++++++++++++++++++++ drivers/usb/host/Makefile | 1 + 3 files changed, 29 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2926327e4976..fb55300c2a84 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3481,6 +3481,14 @@ S: Supported F: Documentation/devicetree/bindings/i2c/brcm,brcmstb-i2c.yaml F: drivers/i2c/busses/i2c-brcmstb.c +BROADCOM BRCMSTB USB EHCI DRIVER +M: Al Cooper +L: linux-usb@vger.kernel.org +L: bcm-kernel-feedback-list@broadcom.com +S: Maintained +F: Documentation/devicetree/bindings/usb/brcm,bcm7445-ehci.yaml +F: drivers/usb/host/ehci-brcm.* + BROADCOM BRCMSTB USB2 and USB3 PHY DRIVER M: Al Cooper L: linux-kernel@vger.kernel.org diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig index 55bdfdf11e4c..973386bbb522 100644 --- a/drivers/usb/host/Kconfig +++ b/drivers/usb/host/Kconfig @@ -97,6 +97,26 @@ config USB_XHCI_TEGRA endif # USB_XHCI_HCD +config USB_EHCI_BRCMSTB + tristate + +config USB_BRCMSTB + tristate "Broadcom STB USB support" + depends on (ARCH_BRCMSTB && PHY_BRCM_USB) || COMPILE_TEST + select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD + select USB_EHCI_BRCMSTB if USB_EHCI_HCD + select USB_XHCI_PLATFORM if USB_XHCI_HCD + help + Enables support for XHCI, EHCI and OHCI host controllers + found in Broadcom STB SoC's. + + To compile these drivers as modules, choose M here: the + modules will be called ohci-platform.ko, ehci-brcm.ko and + xhci-plat-hcd.ko + + Disabling this will keep the controllers and corresponding + PHYs powered down. + config USB_EHCI_HCD tristate "EHCI HCD (USB 2.0) support" depends on HAS_DMA && HAS_IOMEM diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile index a7f0b8ff7179..265e26cf9209 100644 --- a/drivers/usb/host/Makefile +++ b/drivers/usb/host/Makefile @@ -59,6 +59,7 @@ obj-$(CONFIG_USB_EHCI_HCD_STI) += ehci-st.o obj-$(CONFIG_USB_EHCI_EXYNOS) += ehci-exynos.o obj-$(CONFIG_USB_EHCI_HCD_AT91) += ehci-atmel.o obj-$(CONFIG_USB_EHCI_TEGRA) += ehci-tegra.o +obj-$(CONFIG_USB_EHCI_BRCMSTB) += ehci-brcm.o obj-$(CONFIG_USB_OXU210HP_HCD) += oxu210hp-hcd.o obj-$(CONFIG_USB_ISP116X_HCD) += isp116x-hcd.o