From patchwork Fri May 8 22:59:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11537741 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 02C071862 for ; Fri, 8 May 2020 22:59:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5AD424954 for ; Fri, 8 May 2020 22:59:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VPEPKfr0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5AD424954 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 95AC56E21D; Fri, 8 May 2020 22:59:24 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by gabe.freedesktop.org (Postfix) with ESMTPS id 059766E21D for ; Fri, 8 May 2020 22:59:22 +0000 (UTC) Received: by mail-pj1-x1042.google.com with SMTP id js4so978783pjb.5 for ; Fri, 08 May 2020 15:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=o4yPuc1IBO0Fpnm5cH3RYbHF1/VvJ8rseVz+WFhHEck=; b=VPEPKfr0LpFXRwKZseBAaugcPZIisNSbI8QDDiJ5iM7IDfqVfeloezY7Mx5OmrxuXJ n0fWKGZ6VaznJFxuCz+eQRHIKwjre+sRj8KVs5Rwrq+C/UWwJDgi5xda9Gf7lFEVTATy pryaY5dZVtK7IlkgvcMQje0Wi0ArhUEKlGh3c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=o4yPuc1IBO0Fpnm5cH3RYbHF1/VvJ8rseVz+WFhHEck=; b=WjuxV0+qEYey0A0Tko0M/LeFlR5EMrn7ej69798ZqURhoAtoGe2AoqszzNG9K6eMJf nPjnC8t1xq8uHa2sbQQtOnwge6CZ0h2IwPhC9eudLTRy46D3AIqMT2h7+UtFtYSFmRrE Peg0UUBc6CgMaehc1esMCwfFuzl7xpbhJl6SBA5TgaMSqAWAO3qxLT00pcp3xBnKXvuZ ljQ61fnmgJAsmSZA3EPi6FotGHURk28ewD5xvHpy+P53b8b5SJvZ9t1Y1yA3F2n+BI0P 9c1fywBc+ZbSY4Pn6X5GAFtCOT7Zx85Q4I7H5XdzbmOALOQI6WIgb8mcY9IzPkfgUy3v ORYA== X-Gm-Message-State: AGi0Pubc9xoRyeD7fP7f+alfYzCzVE7abF3K4rG5kzXEWfnQxuuwta9y e7/j7bhQkL8/64pPTZIszjPiug== X-Google-Smtp-Source: APiQypLq9GOG18q+UNqlsvudYEAfECHIF4Ub5kQ4kC7q+ReXKvIaZAAJMf/RFYQ9gNVjy8LNt8MdNw== X-Received: by 2002:a17:902:23:: with SMTP id 32mr4625148pla.40.1588978762408; Fri, 08 May 2020 15:59:22 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id i72sm3062874pfe.104.2020.05.08.15.59.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 15:59:21 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Sam Ravnborg Subject: [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61 Date: Fri, 8 May 2020 15:59:00 -0700 Message-Id: <20200508155859.1.I4d29651c0837b4095fb4951253f44036a371732f@changeid> X-Mailer: git-send-email 2.26.2.645.ge9eca65c58-goog MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, David Airlie , linux-arm-msm@vger.kernel.org, Douglas Anderson , dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The BOE NV133FHM-N61 is documented in the original commit to be a 13.3" panel, but the size listed in our struct doesn't match. Specifically: math.sqrt(30.0 * 30.0 + 18.7 * 18.7) / 2.54 ==> 13.92 Searching around on the Internet shows that the size that was in the structure was the "Outline Size", not the "Display Area". Let's fix it. Also the Internet says that this panel supports 262K colors. That's 6bpp, not 8bpp. Fixes: b0c664cc80e8 ("panel: simple: Add BOE NV133FHM-N61") Signed-off-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-simple.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index d6c29543e510..7219436499f1 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1189,10 +1189,10 @@ static const struct drm_display_mode boe_nv133fhm_n61_modes = { static const struct panel_desc boe_nv133fhm_n61 = { .modes = &boe_nv133fhm_n61_modes, .num_modes = 1, - .bpc = 8, + .bpc = 6, .size = { - .width = 300, - .height = 187, + .width = 294, + .height = 165, }, .delay = { .hpd_absent_delay = 200, From patchwork Fri May 8 22:59:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11537743 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2C08415E6 for ; Fri, 8 May 2020 22:59:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06ECD206B9 for ; Fri, 8 May 2020 22:59:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="n9+oTteo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06ECD206B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BBB326E2C8; Fri, 8 May 2020 22:59:24 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1F986E21D for ; Fri, 8 May 2020 22:59:23 +0000 (UTC) Received: by mail-pg1-x541.google.com with SMTP id 207so1544967pgc.6 for ; Fri, 08 May 2020 15:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vsTJfgywY7Yh1c9SFAQgkpGdzTCsAoe2msx951M+8gg=; b=n9+oTteokcsg2gGmnR4zRXRtCjsq5CrG2/r4VvKp5PLRS6msCbvUx5BSWg8VI7PfNH fzOsZRW3n3BzVqfaRQEfeYZ0ExlYzMI38EGyARXFt1+uLUQiP9Ay33UhJpvbrHKTotIb LxOQG9/Gg5iz7YwU/lMlQXNVEpWwfcZUhnxWM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vsTJfgywY7Yh1c9SFAQgkpGdzTCsAoe2msx951M+8gg=; b=FYaVbhDPJT8nOWNK87tGIN1rwKTt+5D8ZmWNYFmDNgfG4fbxdGVL8JibgdjcpKnQZ8 9dIcgZgk4PKeJ2OrOWdSJ5FHX0HbHnFVXHDDd/qt7F+SVDvmnSnngfkQ4kU5fuS9Lpbp n/edMjF0jnikagpgWtjjanbyafMCBNColdzFAIu6xzcZSDJzv92AXkocyofeNYXBPri6 XblexQRK/WujlceboknEx66BnWUrpo6nFNaBCPkgTQWxZ5tgncabNGuXrskOBAxrBtub Bmf2a6QhjyWWsGfqRLPlteY7O1i9PT+5m6npLMMjvqJK4GHiV0PAydwDCZyKqQhl9Coc AcJQ== X-Gm-Message-State: AGi0PuYgFGU3jTTMHq6JIuUILi/kpy6DEW7Ju5W4KpruPqIywO6p6qm3 ywvkfWHt50VzxrpgdTkSXiNlMQ== X-Google-Smtp-Source: APiQypLZztC92CaipNrfEO6dJof+q2mxxAWh+ZlB67X3GIWQuimnyFCwmWlKu1p11C9clTK29MCtRg== X-Received: by 2002:a62:780b:: with SMTP id t11mr5202971pfc.196.1588978763500; Fri, 08 May 2020 15:59:23 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id i72sm3062874pfe.104.2020.05.08.15.59.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 15:59:23 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Sam Ravnborg Subject: [PATCH 2/3] dt-bindings: display: simple: Add BOE NV133FHM-N62 Date: Fri, 8 May 2020 15:59:01 -0700 Message-Id: <20200508155859.2.I37c879ef4ec6d4028a3d45728bc3a58060bba175@changeid> X-Mailer: git-send-email 2.26.2.645.ge9eca65c58-goog In-Reply-To: <20200508155859.1.I4d29651c0837b4095fb4951253f44036a371732f@changeid> References: <20200508155859.1.I4d29651c0837b4095fb4951253f44036a371732f@changeid> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, Douglas Anderson , dri-devel@lists.freedesktop.org, Bjorn Andersson , Rob Herring , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This panel appears to be the same or nearly the same as the BOE NV133FHM-N61, but since (in the very least) it identifies itself as a different model in the EDID we should add a new compatible string for it. Signed-off-by: Douglas Anderson --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index fdd74d07f645..d6cca1479633 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -75,6 +75,8 @@ properties: - boe,nv101wxmn51 # BOE NV133FHM-N61 13.3" FHD (1920x1080) TFT LCD Panel - boe,nv133fhm-n61 + # BOE NV133FHM-N62 13.3" FHD (1920x1080) TFT LCD Panel + - boe,nv133fhm-n62 # BOE NV140FHM-N49 14.0" FHD a-Si FT panel - boe,nv140fhmn49 # CDTech(H.K.) Electronics Limited 4.3" 480x272 color TFT-LCD panel From patchwork Fri May 8 22:59:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 11537749 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 443341668 for ; Fri, 8 May 2020 22:59:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2233C206B9 for ; Fri, 8 May 2020 22:59:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="K5ld8pUS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2233C206B9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CF98B6E2CA; Fri, 8 May 2020 22:59:27 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AABF6E2CA for ; Fri, 8 May 2020 22:59:25 +0000 (UTC) Received: by mail-pg1-x542.google.com with SMTP id j21so1544896pgb.7 for ; Fri, 08 May 2020 15:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gy8mRnKGCdAlapJUNLKgnq4stIzTWpMgvZsJaIARMf4=; b=K5ld8pUSdKEuNRDrb6rIvsCRyHYpaDMubCYD4sukObf0hIGmT4kVqWfF36QvqNYGpr NxoCH0TZi5eD9+cXXa8WS93UxuRODo8rjVOUshlEwZQABiMryGUnwTLF35PqcIcpj4ku bF32L3llPP+k2g9M6lBkn9AY84SaUi3yZ34Ac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gy8mRnKGCdAlapJUNLKgnq4stIzTWpMgvZsJaIARMf4=; b=AMHrvoJ54d85puE8dPvDBcded3GCSNf6TRYoCocaOy747a30tZ3NIIoQ5RmC5Hb11D 62jcbNB0egFkuxZJ1Wo9npYyZkSxknAttE8asPWPi1Atfeel4H6V8Jexte4tpfpdzQgt fzfu7f5mN4q/opz8sZr7NyhOv+R9oY8HatwKjyA5o71OLlv3XxOcZh0SmzzxVwhqEWhU K4bcwp2sljrgSbSXaIkDL2K/TsQi6FHeQ2CpGeiJzwq1xInRf2eZra47xGrk7K2WBrZg fOYV+HGWj371b+eeMFcZZJDOhvfmUvlmdKTFJ6b1o4nkwtv/n0RA9KCNL1as2qUphX5r Dgtg== X-Gm-Message-State: AGi0PuaJJroDVY43A3xDxKWcG6VrWUg2ji1AXLNYuw6BNqCnjibx30X6 zSs7C9xXkPf1/6Wi0NSgvUfm7w== X-Google-Smtp-Source: APiQypIh2ee0YZT2wE0RprXGN5jO2Gbnro485v/sWkDaPIfiCHYp61N2iTZmNPK4/xQdSaGusoO57A== X-Received: by 2002:aa7:9251:: with SMTP id 17mr4911760pfp.315.1588978764710; Fri, 08 May 2020 15:59:24 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id i72sm3062874pfe.104.2020.05.08.15.59.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 15:59:24 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Sam Ravnborg Subject: [PATCH 3/3] panel: simple: Add BOE NV133FHM-N62 Date: Fri, 8 May 2020 15:59:02 -0700 Message-Id: <20200508155859.3.I525ebd471f5340a6a369af7bde06ef04174d2f41@changeid> X-Mailer: git-send-email 2.26.2.645.ge9eca65c58-goog In-Reply-To: <20200508155859.1.I4d29651c0837b4095fb4951253f44036a371732f@changeid> References: <20200508155859.1.I4d29651c0837b4095fb4951253f44036a371732f@changeid> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, David Airlie , linux-arm-msm@vger.kernel.org, Douglas Anderson , dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" All info I could find about this panel show that it behaves the same as the BOE NV133FHM-N61. However, it definitely appears to be a unique panel because reading the EDID shows "NV133FHM-N62". We'll add a string match for the new panel but until we find something unique about it we'll just point at the N61's structures. Signed-off-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-simple.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 7219436499f1..7fb7b257f968 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1173,6 +1173,7 @@ static const struct panel_desc boe_nv101wxmn51 = { }, }; +/* Also used for boe_nv133fhm_n62 */ static const struct drm_display_mode boe_nv133fhm_n61_modes = { .clock = 147840, .hdisplay = 1920, @@ -1186,6 +1187,7 @@ static const struct drm_display_mode boe_nv133fhm_n61_modes = { .vrefresh = 60, }; +/* Also used for boe_nv133fhm_n62 */ static const struct panel_desc boe_nv133fhm_n61 = { .modes = &boe_nv133fhm_n61_modes, .num_modes = 1, @@ -3659,6 +3661,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "boe,nv133fhm-n61", .data = &boe_nv133fhm_n61, + }, { + .compatible = "boe,nv133fhm-n62", + .data = &boe_nv133fhm_n61, }, { .compatible = "boe,nv140fhmn49", .data = &boe_nv140fhmn49,